gmane.os.cygwin.patches

May I remove setup.xml and cygwin-ug.xml?

Warren Young — 2013-05-10T18:19:49

These files in winsup/doc appear to have been replaced by setup-net.xml 
and cygwin-ug-net.xml.  The Makefile doesn't use either of these as 
input to any of its outputs, and they're not referenced by any of the 
other input files.

Further, if you try to build a document from either of these, you get 
errors due to missing XML chunks.  (e.g. setup-reg.xml, referenced by 
setup.xml, doesn't exist.)

When I first discovered this, I thought for sure it meant I'd somehow 
screwed up the SGML to DocBook XML conversion, but ruled that out thus:

     $ grep -Rsl setup-reg winsup

If you do that to both the current tree and to a tree rolled back to 
before I got my commit bit, you find that only setup.{xml,sgml} contains 
that string.  It means the pre-Warren tree couldn't build documents from 
this file, either.

I'm not in any particular hurry to get rid of these files.  They only 
trouble they're causing is the same any clutter causes.  I want to make 
sure no one knows a reason either has to remain in existenc

[PATCH] fix GCC 4.7 warnings

Yaakov (Cygwin/X — 2013-04-30T02:49:06

The attached patch fixes the remaining warnings in HEAD with GCC 4.7.3. 
  OK to apply?


Yaakov

Forgotted appersand

Алексей Павлов — 2013-04-02T08:46:32

Hi!
On cygwin-64bit-branch I think one appersand is forgotten.

--- a/winsup/cygwin/fhandler_disk_file.cc
+++ b/winsup/cygwin/fhandler_disk_file.cc
< at >< at > -1176,7 +1176,7 < at >< at > fhandler_disk_file::ftruncate (off_t length,
bool allow_truncate)
       /* Create sparse files only when called through ftruncate, not when
  called through posix_fallocate. */
       if (allow_truncate && pc.support_sparse ()
-  & !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
+  && !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
   && length >= fsi.EndOfFile.QuadPart + (128 * 1024))
 {
   status = NtFsControlFile (get_handle (), NULL, NULL, NULL, &io,

Best regards,
Alexey.

[PATCH 64bit] Fix ONDEE for 64bit, part 2

Yaakov (Cygwin/X — 2013-03-20T06:22:03

Unfortunately I missed something last time when I tried fixing ONDEE.
Patch attached.

--
Yaakov

[PATCH 64bit] Fix ONDEE for 64bit

Yaakov — 2013-03-04T08:12:24

Corinna,

More fun from our good friend, size_t:

Because operator new (in its various forms) takes a size_t argument, it
is mangled differently on x86_64 above and beyond the common leading
underscore issue.  Patches for winsup/cygwin and gcc (on top of your
latest patch) attached.


Yaakov

[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target, part 2

Yaakov — 2013-02-21T05:15:48

The attached patch is a follow-up to my previous lsaauth patch. FWIW,
it worked as intended only because the toplevel Makefile provided
target_alias; this fixes make in the subdir.


Yaakov

[PATCH] Missing dllimport's in

Yaakov — 2013-02-21T02:38:28

The attached patch for HEAD is required for compiling code which uses
<error.h> and -Wl,--disable-auto-import.


Yaakov

[PATCH] utils: force static linkage

Yaakov — 2013-02-20T21:31:03

Last time I checked, we were linking all utils statically, so this
caught me by surprise:

$ /bin/ldd dumper.exe 
ntdll.dll => /cygdrive/c/Windows/SysWOW64/ntdll.dll (0x77d70000)
kernel32.dll => /cygdrive/c/Windows/syswow64/kernel32.dll (0x75a50000)
KERNELBASE.dll => /cygdrive/c/Windows/syswow64/KERNELBASE.dll (0x76ef0000)
cygwin1.dll => /usr/bin/cygwin1.dll (0x61000000)
cygintl-8.dll => /usr/bin/cygintl-8.dll (0x49bd0000)
cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x6bfb0000)
??? => ??? (0x550000)

The -static flag implies -static-libgcc (see gcc -dumpspecs) and affects
all other libraries (including libstdc++).  Patch for HEAD attached.


Yaakov

[PATCH 64bit] Export symbols with underscore

Yaakov — 2013-02-20T21:16:00

I have already encountered issues with the lack of leading-underscored
exports for symbols declared in <io.h>, as usage thereof often occurs
in shared Cygwin/Win32 conditional code, and on Win32 these are
underscored.  Patch attached for the two symbols I have seen so far,
but I wonder if I should just get it over with and add _access as well.


Yaakov

[PATCH 64bit] ssize_t

Yaakov (Cygwin/X — 2013-02-20T09:32:59

Here is the patch for cygwin necessary for my newly-posted newlib patch.


Yaakov

Qsort defects (in C-library)

Dennis de Champeaux — 2013-02-18T16:51:22


// I hope this is the proper mailing list

Qsort defects

Qsort was described in a 1993 paper by Bentley & McIlroy.

Let me start with the good news.
Someone replaced a 2nd recursive call at the bottom by tail recursion.

Here the bad news.
Someone modified the code with an "improvement", which has seriously
damaged the performance.
The idea of the "improvement" was to keep track of whether during
partitioning a swap had occurred.  If not it was deemed good to call
up insertion sort with:

       if (swap_cnt == 0) {  /* Switch to insertion sort */
        for (pm = (char *) a + es; pm < (char *) a + n * es; pm += es)
            for (pl = pm; pl > (char *) a && cmp(pl - es, pl) > 0;
                 pl -= es)
                swap(pl, pl - es);
        return;
    } 

This causes qsort to descend in quadratic explosions on around 3% of
the 630 problems of the Bentley-test bench (described in the paper).

The fix: remove this code fragment a

[PATCH 64bit] Fix speclib for x86_64

Yaakov — 2013-02-17T10:46:22

[PATCH 64bit] utils: port dumper to 64bit

Yaakov — 2013-02-15T08:02:35

I just uploaded cygwin64-libiconv, cygwin64-gettext, and
cygwin64-libbfd to Ports, so that dumper.exe could be built.  It
appears it hasn't been ported yet, so here's a first attempt.  Comments
welcome.


Yaakov

[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target

Yaakov — 2013-02-15T02:09:56

Console modes: cursor style

Thomas Wolff — 2013-01-11T08:33:00

The attached patch adds two escape control sequences to the Cygwin Console:

  * Show/Hide Cursor (DECTCEM)
  * Set cursor style (DECSCUSR): block vs. underline cursor, or
    arbitrary size (as an extension, using values > 4)

Thomas

2013-01-13  Thomas Wolff  <towo< at >towo.net>

* fhandler.h (class dev_console): Flag for expanded control sequence.
* fhandler_console.cc (char_command): Supporting cursor style modes.

diff -rup sav/fhandler.h ./fhandler.h
--- sav/fhandler.h2012-10-13 14:34:17.000000000 +0200
+++ ./fhandler.h2013-01-08 16:02:54.601269200 +0100
< at >< at > -1246,6 +1246,7 < at >< at > class dev_console
   unsigned rarg;
   bool saw_question_mark;
   bool saw_greater_than_sign;
+  bool saw_space;
   bool vt100_graphics_mode_G0;
   bool vt100_graphics_mode_G1;
   bool iso_2022_G1;
diff -rup sav/fhandler_console.cc ./fhandler_console.cc
--- sav/fhandler_console.cc2012-08-17 17:57:30.000000000 +0200
+++ ./fhandler_console.cc2013-01-08 16:50:05.467534000 +0100
< at >< at > -1510,6 +1510,31 < at >< at > fhandler_console::char_command

[PATCH] waitpid(2) WAIT_* macros

Yaakov (Cygwin/X — 2012-12-06T05:20:29

WAIT_ANY and WAIT_MYPGRP are defined by glibc[1] as symbolic constants
for special values in the first argument to waitpid(2).  Patch attached.


Yaakov

[1]
http://www.gnu.org/software/libc/manual/html_node/Process-Completion.html

[PATCH] add cfsetspeed

Yaakov (Cygwin/X — 2012-11-21T10:54:03

This patchset adds cfsetspeed(3), a BSD extension also available in
glibc:

http://man7.org/linux/man-pages/man3/termios.3.html

Per the description, cfsetspeed() is the equivalent of cfsetospeed() and
cfsetispeed() with the same baud rate.  Patch for winsup/cygwin
attached.


Yaakov

[WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

Christopher Faylor — 2012-11-12T20:02:23

I decided over the weekend to port over configury changes that I made to
Cygwin's now-out-of-date GIT repository.

These changes basically just cleaned up some of the configure scripts
and made it easier to pinpoint where windows headers and libraries come
from by adding a --with-windows-headers and --with-windows-libs options.
However, some of the assumptions made for the git repository weren't
really valid for the CVS repository so there was a fair amount of work
involved.

I thought that I'd do this so I could easily get up-and-running with the
MinGW64 stuff but I ran into some problems building things with gentoo's
MinGW64 implementation.  So, I switched to using the files from the
Cygwin release.

As I mentioned in cygwin-developers, getting the most recent version of
mingw64 stuff working required making some changes to some Cygwin source
files.  Most of the changes just involved #undef'ing constants defined
in Windows headers.  Still, I was surprised that these hadn't already
been handled since I thou

[PATCH] additional sys/termios.h defines

Yaakov (Cygwin/X — 2012-11-05T02:41:46

The attached patch adds a few defines to <sys/termios.h> to make it
compatible with Linux and *BSD.


Yaakov

[patch cygwin]: Rename strechr to strchrnul

Kai Tietz — 2012-10-26T20:13:07

Hello,

this patch replaces strechr by strchrnul symbol-name.  The strchrnul
name is that one also present in new-libc for this function behavior.
ChangeLog

2012-10-26  Kai Tietz

* dcrt0.cc (quoted): Renamed strechr to strchrnul.
* environ.cc (environ_init): Likewise.
* sec_acl.cc (aclfromtext32): Likewise.
* sec_auth.cc (extract_nt_dom_user): Likewise.
* uinfo.cc (pwdgrp::next_str): Likewise.
* string.h (strechr): Likewise.

Ok for apply?

Regards,
Kai

Index: dcrt0.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/dcrt0.cc,v
retrieving revision 1.434
diff -p -u -r1.434 dcrt0.cc
--- dcrt0.cc9 Aug 2012 19:58:52 -00001.434
+++ dcrt0.cc26 Oct 2012 20:06:23 -0000
< at >< at > -162,7 +162,7 < at >< at > quoted (char *cmd, int winshell)
     {
       char *p;
       strcpy (cmd, cmd + 1);
-      if (*(p = strechr (cmd, quote)))
+      if (*(p = strchrnul (cmd, quote)))
 strcpy (p, p + 1);
       return p;
     }
Index: environ.cc
==================================

[Fwd: Re: Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building]

Corinna Vinschen — 2012-10-24T12:25:17

FYI.

----- Forwarded message from Earnie Boyd <...> -----


----- End forwarded message -----