gmane.org.freifunk.batman

hotplug.d

Filippo Sallemi — 2012-05-26T17:33:02

Hi all,

there is an error in /etc/hotplug.d/net/99-batman-adv at line 9.

The function that be called is bat_config and not config_bat

Could someone fix it in latest batman-adv stable release?

Rgds

Can't create new originator

puyou.lu — 2012-05-26T09:20:28

Hi.
I saw strange batman logs while testing a batman-adv mesh. Batman-adv module was continuously generating the same logs including a " Creating new originator: b0:c6:9b:80:01:43". But b0:c6:9b:80:01:43 never appears in the output of 'batctl o':
admin< at >HND-Mesh:~# batctl o
[B.A.T.M.A.N. adv 2012.0.0, MainIF/MAC: wlan0/b0:c6:9b:80:01:5b (bat0)]
  Originator      last-seen (#/255)           Nexthop [outgoingIF]:   Potential nexthops ...
b0:c6:9b:80:01:5c    0.010s   (255) b0:c6:9b:80:01:5c [     wlan0]: b0:c6:9b:80:01:5f (209) b0:c6:9b:80:01:6b (231) b0:c6:9b:80:01:6b (227) b0:c6:9b:80:01:5c (255) b0:c6:9b:80:01:5c (  0)
b0:c6:9b:80:01:45    3.830s   (223) b0:c6:9b:80:01:5f [     wlan0]: b0:c6:9b:80:01:5c (209) b0:c6:9b:80:01:6b (  0) b0:c6:9b:80:01:6b (  0) b0:c6:9b:80:01:5f (223)
b0:c6:9b:80:01:6b    4.520s   (255) b0:c6:9b:80:01:6b [     wlan0]: b0:c6:9b:80:01:5f (206) b0:c6:9b:80:01:5c (245) b0:c6:9b:80:01:6b (255) b0:c6:9b:80:01:6b (251)
b0:c6:9b:80:01:3b    1.570s   (237) b0:c6:9b:80:01:5f [     wlan0]:

[PATCH] batman-adv: Use batctl indentation ofbat_packettype

Sven Eckelmann — 2012-05-25T06:55:55

The style of the indentation was changed in
206af118414355e867e725ea83bc3a2989db5a40

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 packet.h |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/packet.h b/packet.h
index 205879e..c90219c 100644
--- a/packet.h
+++ b/packet.h
< at >< at > -23,14 +23,14 < at >< at >
 #define ETH_P_BATMAN  0x4305/* unofficial/not registered Ethertype */
 
 enum bat_packettype {
-BAT_IV_OGM       = 0x01,
-BAT_ICMP         = 0x02,
-BAT_UNICAST      = 0x03,
-BAT_BCAST        = 0x04,
-BAT_VIS          = 0x05,
+BAT_IV_OGM = 0x01,
+BAT_ICMP = 0x02,
+BAT_UNICAST = 0x03,
+BAT_BCAST = 0x04,
+BAT_VIS = 0x05,
 BAT_UNICAST_FRAG = 0x06,
-BAT_TT_QUERY     = 0x07,
-BAT_ROAM_ADV     = 0x08
+BAT_TT_QUERY = 0x07,
+BAT_ROAM_ADV = 0x08
 };
 
 /* this file is included by batctl which needs these defines */

[PATCHv2] batman-adv: beautify tt_global_add()argument list

Antonio Quartulli — 2012-05-24T22:00:54

Instead of adding a new bool argument each time it is needed, it is better (and
simpler) to pass an 8bit flag argument which contains all the needed flags

Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ< at >public.gmane.org>
---

changes in v2:
- rebased on top of the last patches for code restyling

 routing.c           |    4 ++--
 translation-table.c |   24 +++++++++---------------
 translation-table.h |    4 ++--
 3 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/routing.c b/routing.c
index c3160be..1260253 100644
--- a/routing.c
+++ b/routing.c
< at >< at > -697,8 +697,8 < at >< at > int batadv_recv_roam_adv(struct sk_buff *skb, struct hard_iface *recv_if)
    roam_adv_packet->src, roam_adv_packet->client);
 
 batadv_tt_global_add(bat_priv, orig_node, roam_adv_packet->client,
-     atomic_read(&orig_node->last_ttvn) + 1, true,
-     false);
+     TT_CLIENT_ROAM,
+     atomic_read(&orig_node->last_ttvn) + 1);
 
 /* Roaming phase starts: I have new information but the ttvn has not

[PATCHv3] batman-adv: clear ADD+DEL (and viceversa)events in the same orig-interval

Antonio Quartulli — 2012-05-24T22:00:42

During an OGM-interval (time between two different OGM sendings) the same client
could roam away and then roam back to us. In this case the node would add two
events to the events list (that is going to be sent appended to the next OGM). A
DEL one and an ADD one. Obviously they will only increase the overhead (either in
the air and on the receiver side) and eventually trigger wrong states/events
without producing any real effect.

For this reason we can safely delete any ADD event with its related DEL one.

Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ< at >public.gmane.org>
---

changes in v3:
- rebased on top of the last patches for code restyling

 translation-table.c |   40 +++++++++++++++++++++++++++++++++++++---
 1 file changed, 37 insertions(+), 3 deletions(-)

diff --git a/translation-table.c b/translation-table.c
index cb1d3a8..2c8266a 100644
--- a/translation-table.c
+++ b/translation-table.c
< at >< at > -156,7 +156,9 < at >< at > batadv_tt_orig_list_entry_free_ref(struct tt_orig_list_entry *orig_entry)

[PATCH] batman-adv: Avoid gcc inline problems withvararg functions

Sven Eckelmann — 2012-05-19T07:37:55

gcc doesn't support the inlining of functions using vararg. Sparse fails to
build the source when having such functions marked using the keyword "inline".

This problem was introduced in 3b896e321c49e3cbbfd540f537c007db883c3900

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 main.h |   20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/main.h b/main.h
index 977de45..4721c86 100644
--- a/main.h
+++ b/main.h
< at >< at > -196,6 +196,17 < at >< at > static inline void batadv_vdbg(int type, struct bat_priv *bat_priv,
 batadv_debug_log(bat_priv, fmt, args);
 }
 
+__printf(3, 4)
+static inline void batadv_dbg(int type, struct bat_priv *bat_priv,
+       const char *fmt, ...)
+{
+va_list args;
+
+va_start(args, fmt);
+batadv_vdbg(type, bat_priv, fmt, args);
+va_end(args);
+}
+
 #else /* !CONFIG_BATMAN_ADV_DEBUG */
 
 static inline void batadv_vdbg(int type __always_unused,
< at >< at > -205,19 +216,14 < at >< at > static inline void batadv_vdbg(int type __always_unused,
 {

[PATCH] batman-adv: Revert Distributed ARP Table

Sven Eckelmann — 2012-05-17T15:18:33

David S. Miller did not like the idea of batman-adv modifying and reading the
ARP table and refused to pull this feature. It has to be rewritten after an
acceptable solution was found.

This reverts following commits:
 * batman-adv: add UNICAST_4ADDR packet type
 * batman-adv: add a new log level for DAT debugging
 * batman-adv: Distributed ARP Table - create DHT helper functions
 * batman-adv: Distributed ARP Table - add ARP parsing functions
 * batman-adv: Distributed ARP Table - add snooping functions for ARP messages
 * batman-adv: Distributed ARP Table - increase default soft_iface ARP table timeout
 * batman-adv: Distributed ARP Table - add compile option

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
This patch is for next... I repeat: this patch is for the branch next

 Makefile                |    2 -
 Makefile.kbuild         |    1 -
 README                  |    3 +-
 README.external         |    1 -
 bat_sysfs.c             |    2 +-
 distributed-arp-table.c |

Remaining cleanup/prefixing patches

Sven Eckelmann — 2012-05-16T17:38:28

Hi,

it seems that just too many changes were done and now all were committed in 
the order or the version that I send to the mailinglist. Therefore, I would 
ask to ignore all my remaining patches and wait for the the complete list of 
patches not yet committed. I will send them to this mailing list in some 
hours.

Thanks,
Sven

[PATCH] batman-adv: Correctly check return valuefrom debugfs_create_dir

Martin Hundebøll — 2012-05-15T22:06:20

The setup code in batadv_socket_setup() and debug_log_setup() wrongly
assumes that debugfs_create_file() returns !0 on error. Since it
actually returns a pointer on success[1], the following check should
be inverted.

Also, use the return value from the two setup functions in
batadv_debugfs_add_meshif().

[1] http://www.fsl.cs.sunysb.edu/kernel-api/re464.html

Signed-off-by: Martin Hundebøll <martin-SHBFXCSm21MJGwgDXS7ZQA< at >public.gmane.org>
---
 bat_debugfs.c |   11 +++++++----
 icmp_socket.c |    4 ++--
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/bat_debugfs.c b/bat_debugfs.c
index cd636db..bd9325d 100644
--- a/bat_debugfs.c
+++ b/bat_debugfs.c
< at >< at > -193,13 +193,13 < at >< at > static int debug_log_setup(struct bat_priv *bat_priv)
 
 d = debugfs_create_file("log", S_IFREG | S_IRUSR,
 bat_priv->debug_dir, bat_priv, &log_fops);
-if (d)
+if (!d)
 goto err;
 
 return 0;
 
 err:
-return 1;
+return -ENOMEM;
 }
 
 static void debug_log_cleanup(struct bat_priv *bat_priv)
< at >< at > -347,8 +347,11 < at >< at > int

Some problems with batman-adv

Jochen Jägers — 2012-05-14T15:53:27

Hello,

i try to set up a ad-hoc-mesh network with batman-adv.

There are three test-nodes with following configuration:

Nvidia Tegra 2 Dual Core ARM-Cortex A9 Processor with Linux 2.6.36.2
USB-Wifi Dongle with Ralink 5370 Chipset
Ralink rt5370sta driver kernel module
batman-adv 2012.1.0 (also tried with 2012.0.0)

I've set up the ad-hoc network with WPA-Encryption. This is working
fine. I can access all nodes if i configure the ra0 (ralink wifi)
interface with static ip addresses. I've done this for testing purpose
only. Normally only the bat0 interface has an ip address.

After wireless connection is established I activate the batman-adv
interface.

Example from first node:
modprobe batman-adv
batctl if add ra0                                                   
ifconfig bat0 up                                                      
ifconfig bat0 192.168.50.1 netmask 255.255.255.0
ifconfig bat0 mtu 1472

After booting up all nodes "batctl o" returns:
# batctl o
[B.A.T.M.A.N. adv 2012.1.0, MainIF/MAC: ra0/80

[PATCH] batman-adv: beautify tt_global_add()argument list

Antonio Quartulli — 2012-05-14T07:44:10

Instead of adding a new bool argument each time it is needed, it is better (and
simpler) to pass an 8bit flag argument which contains all the needed flags

Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ< at >public.gmane.org>
---
 routing.c           |    2 +-
 translation-table.c |   19 +++++++------------
 translation-table.h |    3 +--
 3 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/routing.c b/routing.c
index e4d13dc..6c50b1d 100644
--- a/routing.c
+++ b/routing.c
< at >< at > -686,7 +686,7 < at >< at > int recv_roam_adv(struct sk_buff *skb, struct hard_iface *recv_if)
 roam_adv_packet->src, roam_adv_packet->client);
 
 tt_global_add(bat_priv, orig_node, roam_adv_packet->client,
-      atomic_read(&orig_node->last_ttvn) + 1, true, false);
+      TT_CLIENT_ROAM, atomic_read(&orig_node->last_ttvn) + 1);
 
 /* Roaming phase starts: I have new information but the ttvn has not
  * been incremented yet. This flag will make me check all the incoming
diff --git a/translation-table.c b/translatio

[PATCH] batman-adv: clear ADD+DEL (and viceversa)events in the same orig-interval

Antonio Quartulli — 2012-05-14T07:32:42

During an OGM-interval (time between two different OGM sendings) the same client
could roam away and then roam back to us. In this case the node would add two
events to the events list (that is going to be sent appended to the next OGM). A
DEL one and an ADD one. Obviously they will only increase the overhead (either in
the air and on the receiver side) and eventually trigger wrong states/events
without producing any real effect.

For this reason we can safely delete any ADD event with its related DEL one.

Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ< at >public.gmane.org>
---
 translation-table.c |   41 ++++++++++++++++++++++++++++++++++++++---
 1 file changed, 38 insertions(+), 3 deletions(-)

diff --git a/translation-table.c b/translation-table.c
index 2ecf3a2..c134a29 100644
--- a/translation-table.c
+++ b/translation-table.c
< at >< at > -154,7 +154,9 < at >< at > static void tt_orig_list_entry_free_ref(struct tt_orig_list_entry *orig_entry)
 static void tt_local_event(struct bat_priv *bat_priv, const uint8_t

pull request: batman-adv 2012-05-14

Antonio Quartulli — 2012-05-14T07:17:30

Hello David,

here is our last set of changes intended for net-next/linux-3.5.
In this patchset there are:

1) several minor cleanups and fixes
2) an optimisation that avoid to linearise the whole packet when not needed
3) an optimisation for client traffic rerouting after a roaming event.

Patches that modify the whole naming schema will be sent later for merging
with linux-3.6.

Thank you,
Antonio

The following changes since commit f96a8a0b78548c0ec06b0b4b438db6ee895d67e9:

  igb: Add Support for new i210/i211 devices. (2012-05-12 13:17:13 -0700)

are available in the git repository at:

  git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem

for you to fetch changes up to 521251f2f5fa16747cc21e71580e404af855d140:

  batman-adv: unset the TT_CLIENT_PENDING flag if the new local entry already exists (2012-05-14 09:05:08 +0200)

----------------------------------------------------------------
Included changes:

* an improvement to avoid to linearise the whole received packet when not needed
*

[PATCH] batman-adv: Directly print to seq_file in vis

Sven Eckelmann — 2012-05-13T09:39:01

The vis output doesn't need to be buffered in an character buffer before it can
be send to the userspace program that reads from the vis debug file.

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 vis.c |  228 ++++++++++++++++++++++++-----------------------------------------
 1 file changed, 83 insertions(+), 145 deletions(-)

diff --git a/vis.c b/vis.c
index 6b7a1c0..3095c41 100644
--- a/vis.c
+++ b/vis.c
< at >< at > -140,72 +140,117 < at >< at > static void batadv_vis_data_insert_interface(const uint8_t *interface,
 hlist_add_head(&entry->list, if_list);
 }
 
-static ssize_t batadv_vis_prim_sec(char *buff, const struct hlist_head *if_list)
+static void batadv_vis_data_read_prim_sec(struct seq_file *seq,
+  const struct hlist_head *if_list)
 {
 struct if_list_entry *entry;
 struct hlist_node *pos;
-size_t len = 0;
 
 hlist_for_each_entry(entry, pos, if_list, list) {
 if (entry->primary)
-len += sprintf(buff + len, "PRIMARY, ");
+seq_printf(seq, "PRIMARY, ");
 else
-len

[PATCH 1/2] batman-adv: Replace simple function likedefines with functions

Sven Eckelmann — 2012-05-13T09:01:42

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 bat_debugfs.c           |    5 +---
 distributed-arp-table.c |   75 +++++++++++++++++++++++++++++++++--------------
 distributed-arp-table.h |    8 -----
 main.h                  |   37 +++++++++++++++--------
 4 files changed, 79 insertions(+), 46 deletions(-)

diff --git a/bat_debugfs.c b/bat_debugfs.c
index 004d94f..b4d622b 100644
--- a/bat_debugfs.c
+++ b/bat_debugfs.c
< at >< at > -74,16 +74,13 < at >< at > static int batadv_fdebug_log(struct debug_log *debug_log, const char *fmt, ...)
 return 0;
 }
 
-int batadv_debug_log(struct bat_priv *bat_priv, const char *fmt, ...)
+int batadv_debug_log(struct bat_priv *bat_priv, const char *fmt, va_list args)
 {
-va_list args;
 char tmp_log_buf[256];
 
-va_start(args, fmt);
 vscnprintf(tmp_log_buf, sizeof(tmp_log_buf), fmt, args);
 batadv_fdebug_log(bat_priv->debug_log, "[%10u] %s",
   jiffies_to_msecs(jiffies), tmp_log_buf);
-va_end(args);
 
 return 0;
 }
diff --git a/distributed-arp-table.

[PATCH] batman-adv: Mark only locally used symbolbatadv_tt_local_crc as static

Sven Eckelmann — 2012-05-13T06:45:17

29ccfec94d51f7725124786e29d023b212920661 changed the translation table code in
such a way that it doesn't use the symbol tt_local_crc outside of
translation-table.c

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 translation-table.c |    2 +-
 translation-table.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/translation-table.c b/translation-table.c
index f50e795..62dda2b 100644
--- a/translation-table.c
+++ b/translation-table.c
< at >< at > -1172,7 +1172,7 < at >< at > static uint16_t batadv_tt_global_crc(struct bat_priv *bat_priv,
 }
 
 /* Calculates the checksum of the local table */
-uint16_t batadv_tt_local_crc(struct bat_priv *bat_priv)
+static uint16_t batadv_tt_local_crc(struct bat_priv *bat_priv)
 {
 uint16_t total = 0, total_one;
 struct hashtable_t *hash = bat_priv->tt_local_hash;
diff --git a/translation-table.h b/translation-table.h
index 56e8016..7edc9df 100644
--- a/translation-table.h
+++ b/translation-table.h
< at >< at > -41,7 +41,6 < at >< at > void batadv_tt_global

[PATCH 01/18] batman-adv: Prefix bat_debugfs localstatic functions with batadv_

Sven Eckelmann — 2012-05-12T16:33:50

All non-static symbols of batman-adv were prefixed with batadv_ to avoid
collisions with other symbols of the kernel. Other symbols of batman-adv
should use the same prefix to keep the naming scheme consistent.

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 bat_debugfs.c |  143 +++++++++++++++++++++++++++++----------------------------
 1 file changed, 72 insertions(+), 71 deletions(-)

diff --git a/bat_debugfs.c b/bat_debugfs.c
index cd636db..004d94f 100644
--- a/bat_debugfs.c
+++ b/bat_debugfs.c
< at >< at > -32,25 +32,25 < at >< at >
 #include "icmp_socket.h"
 #include "bridge_loop_avoidance.h"
 
-static struct dentry *bat_debugfs;
+static struct dentry *batadv_debugfs;
 
 #ifdef CONFIG_BATMAN_ADV_DEBUG
-#define LOG_BUFF_MASK (log_buff_len-1)
+#define LOG_BUFF_MASK (batadv_log_buff_len - 1)
 #define LOG_BUFF(idx) (debug_log->log_buff[(idx) & LOG_BUFF_MASK])
 
-static int log_buff_len = LOG_BUF_LEN;
+static int batadv_log_buff_len = LOG_BUF_LEN;
 
-static void emit_log_char(struct debug_log

[PATCH] batman-adv: fix comment style and typo

Antonio Quartulli — 2012-05-12T12:38:01

Fix to David's style

Introduced by b46c60b9e1ee7a1909c542413a85875a750955d6

Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ< at >public.gmane.org>
---

This patch is for next


 routing.c           |    3 ++-
 translation-table.c |    3 ++-
 unicast.c           |    5 +++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/routing.c b/routing.c
index 2181a91..4f2059f 100644
--- a/routing.c
+++ b/routing.c
< at >< at > -922,7 +922,8 < at >< at > static int check_unicast_ttvn(struct bat_priv *bat_priv,
 sizeof(struct unicast_packet));
 
 /* we don't have an updated route for this client, so we should
- * not try to reroute the packet!! */
+ * not try to reroute the packet!!
+ */
 if (tt_global_client_is_roaming(bat_priv, ethhdr->h_dest))
 return 1;
 
diff --git a/translation-table.c b/translation-table.c
index 88e4c8e..a66c2dc 100644
--- a/translation-table.c
+++ b/translation-table.c
< at >< at > -2122,7 +2122,8 < at >< at > request_table:
 
 /* returns true whether we know that the client has moved from it

[PATCH 1/8] batman-adv: Move hash_ipv4 todistributed-arp-table.c

Sven Eckelmann — 2012-05-12T11:48:52

hash_ipv4 is only used in distributed-arp-table.c and therefore can be placed
inside this file instead of the header.

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 distributed-arp-table.c |   24 +++++++++++++++++++++++-
 distributed-arp-table.h |   22 ----------------------
 2 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/distributed-arp-table.c b/distributed-arp-table.c
index e678ec4..4894a85 100644
--- a/distributed-arp-table.c
+++ b/distributed-arp-table.c
< at >< at > -32,6 +32,28 < at >< at >
 #include "translation-table.h"
 #include "unicast.h"
 
+/* hash function to choose an entry in a hash table of given size.
+ * hash algorithm from http://en.wikipedia.org/wiki/Hash_table
+ */
+static uint32_t batadv_hash_ipv4(const void *data, uint32_t size)
+{
+const unsigned char *key = data;
+uint32_t hash = 0;
+size_t i;
+
+for (i = 0; i < 4; i++) {
+hash += key[i];
+hash += (hash << 10);
+hash ^= (hash >> 6);
+}
+
+hash += (hash << 3);
+hash ^= (hash >> 11);
+ha

[PATCHv3 01/23] batman-adv: Fix namespace forhash_set_lock_class

Sven Eckelmann — 2012-05-12T00:09:21

This function was introduced in 2c9aa3b4c37bd55148f5f25212c89e7bf5f28497
without a proper namespace prefix.

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 bridge_loop_avoidance.c |    7 ++++---
 hash.c                  |    3 ++-
 hash.h                  |    3 ++-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c
index 89e9721..314e37b 100644
--- a/bridge_loop_avoidance.c
+++ b/bridge_loop_avoidance.c
< at >< at > -1172,9 +1172,10 < at >< at > int bla_init(struct bat_priv *bat_priv)
 if (!bat_priv->claim_hash || !bat_priv->backbone_hash)
 return -ENOMEM;
 
-hash_set_lock_class(bat_priv->claim_hash, &claim_hash_lock_class_key);
-hash_set_lock_class(bat_priv->backbone_hash,
-    &backbone_hash_lock_class_key);
+batadv_hash_set_lock_class(bat_priv->claim_hash,
+   &claim_hash_lock_class_key);
+batadv_hash_set_lock_class(bat_priv->backbone_hash,
+   &backbone_hash_lock_class_key);
 
 bat_dbg(DBG_BLA, bat_priv, "bl

[PATCHv2 1/3] batman-adv: Prefix non-staticfunctions with batadv_

Sven Eckelmann — 2012-05-11T19:26:08

batman-adv can be compiled as part of the kernel instead of an module. In that
case the linker will see all non-static symbols of batman-adv and all other
non-static symbols of the kernel. This could lead to symbol collisions. A
prefix for the batman-adv symbols that defines their private namespace avoids
such a problem.

Reported-by: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q< at >public.gmane.org>
Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw< at >public.gmane.org>
---
 bat_algo.h              |    2 +-
 bat_debugfs.c           |   31 +++----
 bat_debugfs.h           |    8 +-
 bat_iv_ogm.c            |  130 ++++++++++++++--------------
 bat_sysfs.c             |   34 ++++----
 bat_sysfs.h             |   13 +--
 bitarray.c              |    8 +-
 bitarray.h              |    4 +-
 bridge_loop_avoidance.c |   46 +++++-----
 bridge_loop_avoidance.h |   65 +++++++-------
 compat.c                |    8 +-
 compat.h                |    2 +-
 distributed-arp-table.c |   46 +++++-----
 distributed-arp-table.