gmane.network.ssh.libssh2.devel

[PATCH] knownhost.c: use LIBSSH2_FREE macro instead of free

Marc Hoersken — 2013-05-18T21:52:32

Hello everyone,

another small patch to fix warnings I noticed during development. free
is actually not explicitly declared since the corresponding header
file is not imported.

It also makes sense to free the buffers using the same wrapper
interface they have been created with.

Best regards,
Marc
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

#265: agent_disconnect_unix closes stdin on Solaris 10 x64

libssh2 Trac — 2013-05-17T18:25:05

#265: agent_disconnect_unix closes stdin on Solaris 10 x64
-------------------------+--------------------
 Reporter:  mkerestesch  |       Owner:
     Type:  defect       |      Status:  new
 Priority:  normal       |   Milestone:  1.4.3
Component:  SFTP         |     Version:  1.4.2
 Keywords:               |  Blocked By:
   Blocks:               |
-------------------------+--------------------
 Hi there.
 i'm, using libssh2 1.4.3 in a multi-threaded environment to connect to an
 sftp-server via curl (curl 7.30.0, openssl 1.0.1e).
 My code is working perfectly in a windows 7, Linux x64, Solaris 11 x64 and
 Mac OS X x64 environment, but shutting down a thread local curl
 handle under Solaris 10 x64 somehow seems to close stdin (which i rely on
 due to ipc-requirements).
 Anyway. I was able to generate a stacktrace for the problem and the
 offending call seems to be agent_disconnect_unix, which obviously
 closes fd with fd == 0.
 As I can see from libssh2_agent_init the LIBSSH_AGENT struct is zeroed,
 which a

[PATCH] libcrypt.c: Fixed typo in function parameter type

Marc Hoersken — 2013-05-09T20:06:52

Hello everyone,

while looking into the crypto backends I noticed a small typo.
Attached you will find a patch.

Best regards,
Marc
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

#264: SCP send not properly setting mtime or atime

libssh2 Trac — 2013-04-29T18:41:38

#264: SCP send not properly setting mtime or atime
--------------------------+--------------------
 Reporter:  wguynes       |       Owner:
     Type:  defect        |      Status:  new
 Priority:  normal        |   Milestone:  1.4.3
Component:  examples      |     Version:  1.4.2
 Keywords:  scp examples  |  Blocked By:
   Blocks:                |
--------------------------+--------------------
 When using libssh2_scp_send_ex() or libssh2_scp_send64() with non-zero
 mtime or atime parameters the time stamp does not get set.

 This is not so much a fault with the library, but that the scp send
 examples are misleading. After the data is actually sent the remote side
 is expecting one NULL byte. This will trigger the remote side to actually
 set the timestamp on the now fully received file. At present the examples
 merely slam the channel closed which the remote side meekly accepts.

 This will also be critical to implementation of any recursive SCP feature
 in the future. Multiple file transfers over one, op

libssh2_userauth_password return value

2013-04-17T08:00:04

If the authentication fails for a couple of times  (libssh2_userauth_password() returns LIBSSH2_ERROR_AUTHENTICATION_FAILED) and the server closes the connection because of too many authentication failures libssh2_userauth_password() returns LIBSSH2_ERROR_TIMEOUT but in this case it should return LIBSSH2_ERROR_SOCKET_DISCONNECT.




src/userauth.c


        if (session->userauth_pswd_state == libssh2_NB_state_sent) {
            rc = _libssh2_packet_requirev(session, reply_codes,
                                          &session->userauth_pswd_data,
                                          &session->userauth_pswd_data_len,
                                          0, NULL, 0,
                                          &session->
                                          userauth_pswd_packet_requirev_state);
            if (rc == LIBSSH2_ERROR_EAGAIN) {
                return _libssh2_error(session, LIBSSH2_ERROR_EAGAIN,
                                      "Would block waiting");
            } else if (rc)

proper use of non-blocking read

Eric Frias — 2013-04-10T20:46:36

I've been trying to figure out how to use libssh2's non-blocking API
correctly, and I'm stuck.  I can get it to work 99% of the time, but
that last 1% is eludes me.

The main problem I'm battling is what happens when I need to do a read
on a channel, and I don't know if there's going to be any data there to
read.  If there is, I want to read it.  If there's no data, I want to be
able to do other stuff like write to the channel or read or write to
another channel.  Seems pretty normal.

So let's say I call libssh2_channel_read_ex() and it returns
LIBSSH2_ERROR_EAGAIN.  My problem is that I can't tell what this means. 
It could mean that:
* there was no data on that channel, and it's safe to go write some data
or service another channel.  or,
* in the process of doing the read, libssh2 wandered into
_libssh2_channel_receive_window_adjust, sending a message to the ssh
server.  While sending the adjust message, the TCP send buffer filled
up, and the OS level send(2) call returned EAGAIN

Of course, this second c

#263: libssh2_channel_read for exec ends unpredictably

libssh2 Trac — 2013-04-09T22:26:22

#263: libssh2_channel_read for exec ends unpredictably
---------------------+--------------------
 Reporter:  xtravar  |       Owner:
     Type:  defect   |      Status:  new
 Priority:  normal   |   Milestone:  1.4.3
Component:  API      |     Version:  1.4.2
 Keywords:           |  Blocked By:
   Blocks:           |
---------------------+--------------------
 Problem: libssh2_channel_exec is returning EOF sooner than expected
 randomly

 Client Platform: iOS
 Versions tried: 1.4.3, 1.4.4-20130409

 *Tried with blocking & non-blocking
 *Piped to 'tee' to verify the process isn't ending prematurely (the file
 gets written out completely)
 *Same problem does not happen with SCP
 *Never happens on the first run of the code

 My code vaguely looks like:
 {{{
 chan = libssh2_channel_open_session(session);
 libssh2_channel_exec(chan, "convert \"test.jpg\" -quality 60 -resize 100%
 -format JPEG - 2>/dev/null | tee converttest.jpg")
 // loop until read returns 0 (eof also becomes true at this point)
 libssh2_channe

[PATCH] sftp: Add support for fsync (OpenSSH extension).

Richard W.M. Jones — 2013-04-09T09:42:08

The patch (in the following email) adds fsync support to libssh2 via a
new API function called 'libssh2_sftp_fsync'.

*NOTE:* For this to work you will need a patched OpenSSH with an
accepted-upstream-but-not-included patch that adds the
fsync-ZT/51Pfwho1BDgjK7y7TUQ< at >public.gmane.org extension to OpenSSH sftp-server.  For details see
here:

https://bugzilla.mindrot.org/show_bug.cgi?id=1798

I have tested this via my qemu ssh block device patch both with and
without fsync support on the server side.

Rich.

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

[PATCH] sftp: statvfs: Along error path, reset the correct 'state' variable.

Richard W.M. Jones — 2013-04-08T16:32:10

This appears to be a typo in the code.

Rich.

Transfering files

Paul Radaz — 2013-04-03T17:23:15

Hello all, I want to make something like this:
http://www.mail-archive.com/libssh2-devel-nuDYylZla2DMSbncWqzJgw< at >public.gmane.org/msg01481.html but
when I trying to create sftp_session instance for C through channel in my
app, then libssh2_sftp_init return NULL and error code is set
to LIBSSH2_ERROR_INVAL.
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

#262: libssh2_userauth_publickey_fromfile_ex declaration in man missis one parameter

libssh2 Trac — 2013-03-28T19:03:42

#262: libssh2_userauth_publickey_fromfile_ex declaration in man missis one
parameter
--------------------+--------------------
 Reporter:  pastey  |       Owner:
     Type:  defect  |      Status:  new
 Priority:  low     |   Milestone:  1.4.3
Component:  SFTP    |     Version:  1.4.2
 Keywords:  man     |  Blocked By:
   Blocks:          |
--------------------+--------------------
 in manual entry for libssh2_userauth_publickey_fromfile_ex function
 declaration misses "username_len" parameter (in SYNOPSIS section), however
 "username_len" is described in DESCRIPTION section

[PATCH] sftp: seek: Don't flush buffers if the requested offset is the same as current

Richard W.M. Jones — 2013-03-26T16:58:03

I encountered a problem when adding libssh2 support to qemu:

http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg04626.html

which was that my code always called libssh2_sftp_seek64 between every
request.  Because the requests come randomly, this makes sense from
the point of view of making the code simple.

There seems to be an impact on performance in my measurements of
perhaps 1/5th - 1/3rd, and that appears to come down to libssh2
flushing readahead buffers when you call libssh2_sftp_seek64.

I since changed the code of qemu to avoid calling libssh2_sftp_seek64
unless it is necessary, but the patch I'm attaching here should at
least partially fix the problem at the libssh2 API level.

To be honest I'm having a hard time measuring the impact of this
change because the variability in my measurements is about the same as
the benefit I'm expecting to see.  Nevertheless the change should be
obviously correct by inspection, so I don't see what harm it would do.

Rich.

____________________________________

sftp_read/write returning LIBSSH2_ERROR_TIMEOUT

Richard W.M. Jones — 2013-03-21T14:27:20

Firstly I wrote a patch for qemu which uses libssh2 to access remote
disks.  It might be interesting for some people on this list:

  http://www.mail-archive.com/qemu-devel-qX2TKyscuCcdnm+yROfE0A< at >public.gmane.org/msg161996.html
  http://www.mail-archive.com/qemu-devel-qX2TKyscuCcdnm+yROfE0A< at >public.gmane.org/msg161997.html

Now my question: The libssh2_sftp_{read,write} functions sometimes
return LIBSSH2_ERROR_TIMEOUT, maybe 1 time in 5, and apparently at
random.

I don't understand why they do this, and so far I've managed to work
around the "problem" by retrying the operation, and things seem to be
fine.  However I don't know if this is the correct thing to do.  Any
advice would be helpful.

Rich.

#261: buildconf fails with recent automake

libssh2 Trac — 2013-03-21T10:41:10

#261: buildconf fails with recent automake
---------------------+--------------------
 Reporter:  Quintus  |       Owner:
     Type:  defect   |      Status:  new
 Priority:  normal   |   Milestone:  1.4.3
Component:  misc     |     Version:  1.4.2
 Keywords:           |  Blocked By:
   Blocks:           |
---------------------+--------------------
 Hi there,

 Running ''buildconf'' from the current 1.4.3 release tarball with a recent
 automake installed fails like this:

 {{{
 % ./buildconf
 configure.ac:5: error: 'AM_CONFIG_HEADER': this macro is obsolete.
     You should use the 'AC_CONFIG_HEADERS' macro instead.
 /usr/share/aclocal-1.13/obsolete-err.m4:12: AM_CONFIG_HEADER is expanded
 from...
 configure.ac:5: the top level
 autom4te: /usr/bin/m4 failed with exit status: 1
 aclocal: error: echo failed with exit status: 1
 configure.ac:19: error: version mismatch.  This is Automake 1.13.1,
 configure.ac:19: but the definition used by this AM_INIT_AUTOMAKE
 configure.ac:19: comes from Automake 1.11.6.  You

Multiple direct_tcp_ip_channel

Daniel Satori — 2013-03-14T15:58:50

Hello, I created connection direct_tcp_ip_channel o host in private
network, authentificate this connection and I can creating channels,
executing commands etc - all works fine. My questions are: its possible to
make next direct_tcp_ip_channel from this connection to another private
network?

Somethink like a this:

  PUBLIC
       ||(direct_tcp_ip)
 ------------
| PRIVATE | host in first private network
 ------------
       ||(next direct_tcp_ip)
 ------------
| PRIVATE | host in second private network
 ------------
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

RouterOS Handshake problem

Antonio Modesto — 2013-03-12T11:36:03

 

Hello, 

I work at an ISP and I'm writing a C program to create and
fetch backup files from routers running RouterOS, the problem is that
there is a compatibility problem between routeros's ssh implementation e
and libssh2 (The problem is with routeros, I think). Here is the error:


ssh_privatekey_connect() - Host: 189.90.192.117 - SSH handshake error


ssh_privatekey_connect() - Error code: -8, Error: Unable to exchange
encryption keys 

While googling I found that changing the encryption to
diffie-hellman-group1-sha1 would work, but I didn't find the way to
force libssh2 to use this kind of encryption. 

Any suggestions?


Thanks. 
 _______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

troubleshooting connection failure

2013-03-09T16:51:29

I'm having trouble building a version libssh2 that will connect to this
site (tigr.mckesson.com).  I've seen it get past this point with a
binary I downloaded from the curl webpage, but I can't reproduce the
same results.  Any thoughts?  Is there an option I need to turn on/off
that I'm not seeing?

(using...)
curl 7.29.0 (i386-pc-win32) libcurl/7.29.0 OpenSSL/1.0.1e zlib/1.2.7
libidn/1.26  libssh2/1.4.3
Protocols: dict file ftp ftps gopher http https imap imaps ldap pop3
pop3s rtsp scp sftp smtp smtps telnet tftp
Features: AsynchDNS GSS-Negotiate IDN IPv6 Largefile NTLM SSL SSPI libz

C:\install\CURL\work>curl -v -l sftp://tigr.mckesson.com/
* About to connect() to tigr.mckesson.com port 22 (#0)
*   Trying 143.112.128.164...
* Connected to tigr.mckesson.com (143.112.128.164) port 22 (#0)
* User:
* Password:
* SSH socket: 1900
[libssh2] 0.750000 Conn: Setting blocking mode OFF
[libssh2] 0.750000 Transport: session_startup for socket 1900
[libssh2] 0.750000 Transport: Sending Banner:
SSH-2.0-libssh2_1.4.4-20

Need help with libssh2_userauth_keyboard_interactive method.

Velichko Yuriy — 2013-02-28T15:14:51

Hello everyone!

II try to use the libssh2 in my application. And I have question about  the
libssh2_userauth_keyboard_interactive function.

I took the kbd_callback method from examples:

static void kbd_callback(

                 const char *name,

                  int name_len,

                  const char *instruction,

                  int instruction_len,

                  int num_prompts,

                  const LIBSSH2_USERAUTH_KBDINT_PROMPT *prompts,

                  LIBSSH2_USERAUTH_KBDINT_RESPONSE *responses,

                  void **abstract )

{

    (void)name;

    (void)name_len;

    (void)instruction;

    (void)instruction_len;

    if (num_prompts == 1) {

        responses[0].text = strdup(password);

        responses[0].length = strlen(password);

    }

    (void)prompts;

    (void)abstract;

}


Here, the password is a global variable.

QUESTION: Is there a method to pass the variable into this function?

Keepalive Issue

alberto Villa — 2013-02-28T10:43:45

Hello, I'm trying to use libssh2 example ssh2_exec.c slightly modified
in order to experiment keepalive support.

I modified the following line:

// Here I want a blocking session
libssh2_session_set_blocking(session, 0); --->
libssh2_session_set_blocking(session, 1);

and added the following:

libssh2_keepalive_config(session, 1, 20);

just before the call to libssh2_channel_open_session(). Now I use this
version of ssh2_exec to exec the command

tail -f file

on my remote host. No one is writing on file on the remote host.

What happens is that my ssh connection (on my side) times-out and is
closed. Is this a feature of libssh2? does the connection times-out
because no IO is done since no one is writing on the file on the remote
host? Or am I missing something in using keepalives?

thank you

Alberto

Force deallocate all resources within session

Anton Obukhov — 2013-02-22T15:05:54

Hi, I'm having the following scenario: I manage a bunch of remote devices,
and some of them may sit on a bad connection. Whenever I detect that the
connection is unsatisfactory, I want to shutdown all the channels, session
and resources, linked to the session.

The problem is - if say the device went down, all the functions (including
libssh2_session_free) return EAGAIN, and I seem to leak a lot of resources
if I keep it as is... So now all I do is I close the socket linked to the
session. What I'd like to do is to tell libssh to force close & deallocate
a selected resource (channel, session, etc). Is there a way for it?

Thanks,
Anton
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

#260: libssh2 1.2.5 file permission issues

libssh2 Trac — 2013-02-21T00:31:15

#260: libssh2 1.2.5 file permission issues
--------------------+--------------------
 Reporter:  Raji    |       Owner:
     Type:  defect  |      Status:  new
 Priority:  normal  |   Milestone:  1.4.3
Component:  API     |     Version:  1.4.2
 Keywords:          |  Blocked By:
   Blocks:          |
--------------------+--------------------
 I’m using libssh2 1.2.5 and try to do a sftp write. For the newly created
 files, write permission is not set for group and others,eventhough I make
 use of the flags (LIBSSH2_SFTP_S_IWGRP and LIBSSH2_SFTP_S_IWOTH).Always
 the files are created with read,write permission for owner and read
 permission for group,others.

 libssh2_sftp_open(sftp_session,
 sftppath,LIBSSH2_FXF_WRITE|LIBSSH2_FXF_CREAT|LIBSSH2_FXF_TRUNC,
 LIBSSH2_SFTP_S_IRUSR|LIBSSH2_SFTP_S_IWUSR|LIBSSH2_SFTP_S_IRGRP|
 LIBSSH2_SFTP_S_IWGRP | LIBSSH2_SFTP_S_IROTH | LIBSSH2_SFTP_S_IWOTH);

 Is this a known issue with libssh2 1.2.5?.This was working fine with
 libssh2 0.1.4.I used to pass 0 for mode value and