http://blog.gmane.org/gmane.linux.nfs hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.linux.nfs/50089 <pre>nsm_client needs to link against libtirpc. diff -x config.log -x config.status -ru tmp/nfs-utils-1.2.6/tests/nsm_client/Makefile.am work/nfs-utils-1.2.6/tests/nsm_client/Makefile.am --- tmp/nfs-utils-1.2.6/tests/nsm_client/Makefile.am2012-05-14 15:40:52.000000000 +0100 +++ work/nfs-utils-1.2.6/tests/nsm_client/Makefile.am2012-05-26 22:18:50.999001661 +0100 &lt; at &gt;&lt; at &gt; -13,7 +13,7 &lt; at &gt;&lt; at &gt; BUILT_SOURCES = $(GENFILES) nsm_client_LDADD = ../../support/nfs/libnfs.a \ - ../../support/nsm/libnsm.a $(LIBCAP) + ../../support/nsm/libnsm.a $(LIBCAP) $(LIBTIRPC) if CONFIG_RPCGEN RPCGEN= $(top_builddir)/tools/rpcgen/rpcgen </pre> Adam Sampson 2012-05-26T21:32:14 http://comments.gmane.org/gmane.linux.nfs/50088 <pre>(Also worth noting that the NEWS file in nfs-utils is obsolete, and the README file has the wrong version number in it.) Installing osd_login would fail if $DESTDIR/sbin didn't exist. Get automake to do the installation, which'll fix this as a side-effect. diff -x config.log -x config.status -ru tmp/nfs-utils-1.2.6/utils/osd_login/Makefile.am work/nfs-utils-1.2.6/utils/osd_login/Makefile.am --- tmp/nfs-utils-1.2.6/utils/osd_login/Makefile.am2012-05-14 15:40:52.000000000 +0100 +++ work/nfs-utils-1.2.6/utils/osd_login/Makefile.am2012-05-26 22:25:17.890001662 +0100 &lt; at &gt;&lt; at &gt; -1,12 +1,7 &lt; at &gt;&lt; at &gt; ## Process this file with automake to produce Makefile.in -OSD_LOGIN_FILES= osd_login +rootsbindir = /sbin -EXTRA_DIST= $(OSD_LOGIN_FILES) - -all-local: $(OSD_LOGIN_FILES) - -install-data-hook: -$(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login +rootsbin_SCRIPTS = osd_login MAINTAINERCLEANFILES = Makefile.in </pre> Adam Sampson 2012-05-26T21:33:51 http://comments.gmane.org/gmane.linux.nfs/50078 <pre>Exchange ID can be called in a lease reclaim situation, so it will deadlock if it then tries to write out dirty NFS pages. Signed-off-by: Trond Myklebust &lt;Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- fs/nfs/nfs4proc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index e8988c0..f8817e8 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c &lt; at &gt;&lt; at &gt; -5192,20 +5192,20 &lt; at &gt;&lt; at &gt; int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred) clp-&gt;cl_rpcclient-&gt;cl_auth-&gt;au_flavor); res.server_owner = kzalloc(sizeof(struct nfs41_server_owner), -GFP_KERNEL); +GFP_NOFS); if (unlikely(res.server_owner == NULL)) { status = -ENOMEM; goto out; } res.server_scope = kzalloc(sizeof(struct nfs41_server_scope), -GFP_KERNEL); +GFP_NOFS); if (unlikely(res.server_scope == NULL)) { status = -ENOMEM; goto out_server_owner; } -res.impl_id = kzalloc(sizeof(struct nfs41_impl_id), GFP_KERNEL); +</pre> Trond Myklebust 2012-05-26T18:39:52 http://comments.gmane.org/gmane.linux.nfs/50076 <pre>Hello, I am trying to compile nfs-utils 1.2.6 with NFSv4 and gss support, but am running into the following error: ./configure --prefix=/usr --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --docdir=/usr/share/doc/nfs-utils-1.2.6 --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --enable-fast-install --libdir=/usr/lib64 --mandir=/usr/share/man --enable-largefile --enable-libmount-mount --enable-mount --enable-mountconfig --enable-tirpc --with-statduser=nobody --with-statedir=/var/lib/nfs --disable-caps --enable-gss --enable-ipv6 --enable-nfsv4 --enable-nfsv41 --enable-nfsdcld --with-tcp-wrappers [...] x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../support/include -I/usr/include/tirpc -D_GNU_SOURCE -Wall -Wextra -Wstrict-prototypes -pipe -march=native -O2 -pipe -I/usr/include/gssglue -I/usr/include -march=native -O2 -pipe -c -o gssd-context_lucid.o `test -f 'context_lucid.c' </pre> Markus Rothe 2012-05-26T12:37:52 http://comments.gmane.org/gmane.linux.nfs/50075 <pre></pre> FROM MRS SUSAN SHABANGU 2012-05-26T10:56:23 http://comments.gmane.org/gmane.linux.nfs/50069 <pre>This patchset implements a new upcall mechanism that uses the sunrpc client to talk to gssproxy[1], a new userspace daemon that handles gssapi operations on behalf of other processes on the system. The main driver for this new mechanism is to overcome limitations with the current daemon and upcall. The current code cannot handle tickets larger than approximatively 2k and cannot handle sending back large user credential sets to the kernel. These patches have been tested against the development version of gssproxy tagged as kernel_v0.1 in the master repo[2]. I have tested walking into mountpoints using tickets artificially pumped up to 64k and the user is properly authorized, after the accept_se_context call is performed through the new upcall mechanism and gssproxy. The gssproxy has the potential of handling also init_sec_context calls, but at the moment the only targeted system is nfsd. Simo. [1] https://fedorahosted.org/gss-proxy/ [2] http://git.fedorahosted.org/git/?p=gss-proxy.git;a=shortlog;h=refs/</pre> Simo Sorce 2012-05-25T22:09:52 http://comments.gmane.org/gmane.linux.nfs/50061 <pre>Exchange ID can be called in a lease reclaim situation, so it will deadlock if it then tries to write out dirty NFS pages. Signed-off-by: Trond Myklebust &lt;Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- fs/nfs/nfs4proc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index e8988c0..f8817e8 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c &lt; at &gt;&lt; at &gt; -5192,20 +5192,20 &lt; at &gt;&lt; at &gt; int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred) clp-&gt;cl_rpcclient-&gt;cl_auth-&gt;au_flavor); res.server_owner = kzalloc(sizeof(struct nfs41_server_owner), -GFP_KERNEL); +GFP_NOFS); if (unlikely(res.server_owner == NULL)) { status = -ENOMEM; goto out; } res.server_scope = kzalloc(sizeof(struct nfs41_server_scope), -GFP_KERNEL); +GFP_NOFS); if (unlikely(res.server_scope == NULL)) { status = -ENOMEM; goto out_server_owner; } -res.impl_id = kzalloc(sizeof(struct nfs41_impl_id), GFP_KERNEL); +</pre> Trond Myklebust 2012-05-25T22:03:15 http://comments.gmane.org/gmane.linux.nfs/50054 <pre>I got the below on a 3.4-rc7 based Benny's pnfs tree. During normal nfs4 only operations. (Just my development trees mounted on client machine) If it will happen again I will investigate. I'll leave it off for now (busy with other stuff) Just wanted to know if it might have already been fix or seen by someone else [ 3830.441139] BUG: unable to handle kernel NULL pointer dereference at 0000000000000078 [ 3830.442024] IP: [&lt;ffffffff812894ce&gt;] key_instantiate_and_link+0x2e/0xa0 [ 3830.442024] PGD 0 [ 3830.442024] Oops: 0000 [#1] SMP [ 3830.442024] CPU 1 [ 3830.442024] Modules linked in: osd libosd nfsd nfs lockd fscache auth_rpcgss nfs_acl sunrpc ip6t_REJECT be2iscsi nf_conntrack_ipv6 nf_defrag_ipv6 iscsi_boot_sysfs xt_state bnx2i nf_conntrack cnic uio cxgb3i libcxgbi cxgb3 mdio ip6table_filter ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_core ib_addr ip6_tables iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi joydev virtio_balloon i2c_piix4 i2c_core pcspkr virtio_net microcode floppy virtio_blk [last</pre> Boaz Harrosh 2012-05-25T10:12:47 http://comments.gmane.org/gmane.linux.nfs/50052 <pre>Hello. I updated my nfs server machine to kernel 3.0, and noticed that its main usage become, well, problematic. While trying to dig deeper, I also found a few other interesting issues, which are mentioned below. But first thing first: nfs. i686pae kernel, lots of RAM, Atom-based (cedar trail) machine with usual rtl8169 NIC. 3.0 or 3.2 kernel (I will try current 3.4 but I don't have much hopes there). NFSv4. When a client machine (also 3.0 kernel) does some reading, the process often stalls somewhere in the read syscall, or, rarer, during close, for up to two MINUTES. During this time, the client (kernel) reports "NFS server &lt;foo&gt; does not respond" several times, and finally "NFS server &lt;foo&gt; ok", client process "unstucks" from the read(2), and is able to perform a few more reads till the whole thing repeats. While this happens, ie, while the client process is stuck, any access to the mounted filesystem results in an uninterruptible sleep - all processes including the initial client are unkillable. </pre> Michael Tokarev 2012-05-25T06:53:11 http://comments.gmane.org/gmane.linux.nfs/50050 <pre>This patch adds the BIND_CONN_TO_SESSION operation which is needed for upcoming SP4_MACH_CRED work and useful for recovering from broken connections without destroying the session. Signed-off-by: Weston Andros Adamson &lt;dros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- Updated with comment from Trond fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4proc.c | 54 ++++++++++++++++++++++++++ fs/nfs/nfs4xdr.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ include/linux/nfs4.h | 5 ++ include/linux/nfs_xdr.h | 6 +++ 5 files changed, 161 insertions(+), 0 deletions(-) diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index edeef71..ad90bc7 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h &lt; at &gt;&lt; at &gt; -215,6 +215,7 &lt; at &gt;&lt; at &gt; struct vfsmount *nfs4_submount(struct nfs_server *, struct dentry *, extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *, struct nfs4_setclientid_res *); extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct nfs4_setclie</pre> Weston Andros Adamson 2012-05-24T21:19:33 http://comments.gmane.org/gmane.linux.nfs/50042 <pre>This fault injection hook causes all SEQUENCE operation replies to have the SEQ4_STATUS_CB_PATH_DOWN flag set until the client calls BIND_CONN_TO_SESSION or creates a new session. Signed-off-by: Weston Andros Adamson &lt;dros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- fs/nfsd/fault_inject.c | 4 ++++ fs/nfsd/fault_inject.h | 2 ++ fs/nfsd/nfs4state.c | 20 ++++++++++++++++++++ 3 files changed, 26 insertions(+), 0 deletions(-) diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c index e6c3815..ab81144 100644 --- a/fs/nfsd/fault_inject.c +++ b/fs/nfsd/fault_inject.c &lt; at &gt;&lt; at &gt; -38,6 +38,10 &lt; at &gt;&lt; at &gt; static struct nfsd_fault_inject_op inject_ops[] = { .file = "recall_delegations", .func = nfsd_recall_delegations, }, +{ +.file = "kill_backchannel", +.func = nfsd_kill_backchannel, +}, }; static long int NUM_INJECT_OPS = sizeof(inject_ops) / sizeof(struct nfsd_fault_inject_op); diff --git a/fs/nfsd/fault_inject.h b/fs/nfsd/fault_inject.h index 90bd057..b058e03 100644 --- a/fs/nfsd/f</pre> Weston Andros Adamson 2012-05-24T19:42:16 http://comments.gmane.org/gmane.linux.nfs/50041 <pre>The error values that TEST_STATEID is allowed to return does not include NFS4ERR_STALE_STATEID. In addition, RFC 5661 says: 15.1.16.5. NFS4ERR_STALE_STATEID (Error Code 10023) A stateid generated by an earlier server instance was used. This error is moot in NFSv4.1 because all operations that take a stateid MUST be preceded by the SEQUENCE operation, and the earlier server instance is detected by the session infrastructure that supports SEQUENCE. I triggered the NFS4ERR_STALE_STATEID during nograce recovery testing. My client had updated its boot verifier, so the server instance hadn't changed, but the client instance had. Thus the server allowed the SEQUENCE operation, but returned NFS4ERR_STALE_STATEID on the TEST_STATEID operation. After a client's lease expires, TEST_STATEID should report NFS4ERR_EXPIRED for state IDs that the client tries to recover. I don't see a way to make that happen, though. Finally, RFC 5661, section 18.48.3 has this: o Special stateids are always consi</pre> Chuck Lever 2012-05-24T19:29:51 http://comments.gmane.org/gmane.linux.nfs/50039 <pre>This patch adds the BIND_CONN_TO_SESSION operation which is needed for upcoming SP4_MACH_CRED work and useful for recovering from broken connections without destroying the session. Signed-off-by: Weston Andros Adamson &lt;dros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- Reposted with changes addressing Chuck's comments. fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4proc.c | 54 ++++++++++++++++++++++++++ fs/nfs/nfs4xdr.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ include/linux/nfs4.h | 5 ++ include/linux/nfs_xdr.h | 6 +++ 5 files changed, 161 insertions(+), 0 deletions(-) diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index edeef71..ad90bc7 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h &lt; at &gt;&lt; at &gt; -215,6 +215,7 &lt; at &gt;&lt; at &gt; struct vfsmount *nfs4_submount(struct nfs_server *, struct dentry *, extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *, struct nfs4_setclientid_res *); extern int nfs4_proc_setclientid_confirm(struct nfs_client *, </pre> Weston Andros Adamson 2012-05-24T17:22:50 http://comments.gmane.org/gmane.linux.nfs/50037 <pre>From: Andy Adamson &lt;andros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; Only resending NFSv4.1 add nfs_inode book keeping for mdsthreshold. Responded to Trond's comments. I have not tested the directio nor the memmap io cases. The regular file i/o works as intended. Andy Adamson (4): NFSv4.1 mdsthreshold attribute xdr NFSv4.1 cache mdsthreshold values on OPEN NFSv4.1 add nfs_inode book keeping for mdsthreshold NFSv4.1 test the mdsthreshold hint parameters fs/nfs/direct.c | 2 + fs/nfs/file.c | 1 + fs/nfs/inode.c | 4 ++ fs/nfs/nfs4proc.c | 38 ++++++++++++-- fs/nfs/nfs4xdr.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++- fs/nfs/pnfs.c | 94 +++++++++++++++++++++++++++++++++++ fs/nfs/pnfs.h | 21 ++++++++ fs/nfs/read.c | 2 + include/linux/nfs4.h | 7 +++ include/linux/nfs_fs.h | 4 ++ include/linux/nfs_xdr.h | 10 ++++ 11 files changed, 301 insertions(+), 7 deletions(-) </pre> andros-HgOvQuBEEgTQT0dZR+AlfA< at >public.gmane.org 2012-05-24T17:13:23 http://comments.gmane.org/gmane.linux.nfs/50030 <pre>This patch adds the BIND_CONN_TO_SESSION operation which is needed for upcoming SP4_MACH_CRED work and useful for recovering from broken connections without destroying the session. Signed-off-by: Weston Andros Adamson &lt;dros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4proc.c | 54 ++++++++++++++++++++++++++++ fs/nfs/nfs4xdr.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++ include/linux/nfs4.h | 5 +++ include/linux/nfs_xdr.h | 6 +++ 5 files changed, 156 insertions(+), 0 deletions(-) diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index edeef71..ad90bc7 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h &lt; at &gt;&lt; at &gt; -215,6 +215,7 &lt; at &gt;&lt; at &gt; struct vfsmount *nfs4_submount(struct nfs_server *, struct dentry *, extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *, struct nfs4_setclientid_res *); extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct nfs4_setclientid_res *arg, struct rpc_cred</pre> Weston Andros Adamson 2012-05-24T16:26:36 http://comments.gmane.org/gmane.linux.nfs/50017 <pre>Time: 9:30 AM PST (12:30 PM EST) The call in numbers are: U.S. and Canada: (800) 451-8679 International dial-in number: (212) 729-5016 Israel Toll-Free: 1-809-462-557 Conference code: 564.272.1552 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA&lt; at &gt;public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Steve Dickson 2012-05-24T10:56:34 http://comments.gmane.org/gmane.linux.nfs/50015 <pre>v2: 1) Set global nfsd_serv pointer to NULL only if no running threads left. Otherwise we will get NULL pointer dereference. Signed-off-by: Stanislav Kinsbursky &lt;skinsbursky-bzQdu9zFT3WakBO8gow8eQ&lt; at &gt;public.gmane.org&gt; --- fs/nfsd/nfsctl.c | 8 ++------ fs/nfsd/nfsd.h | 11 +++++++++++ fs/nfsd/nfssvc.c | 24 ++++++++---------------- 3 files changed, 21 insertions(+), 22 deletions(-) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index c55298e..fa49cff 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c &lt; at &gt;&lt; at &gt; -673,9 +673,7 &lt; at &gt;&lt; at &gt; static ssize_t __write_ports_addfd(char *buf) err = svc_addsock(nfsd_serv, fd, buf, SIMPLE_TRANSACTION_LIMIT); if (err &lt; 0) { -if (nfsd_serv-&gt;sv_nrthreads == 1) -svc_shutdown_net(nfsd_serv, net); -svc_destroy(nfsd_serv); +nfsd_destroy(net); return err; } &lt; at &gt;&lt; at &gt; -744,9 +742,7 &lt; at &gt;&lt; at &gt; out_close: svc_xprt_put(xprt); } out_err: -if (nfsd_serv-&gt;sv_nrthreads == 1) -svc_shutdown_net(nfsd_serv, net); -svc_destroy(nfsd_serv); +nfsd_destroy(net); return err; } </pre> Stanislav Kinsbursky 2012-05-24T10:15:39 http://comments.gmane.org/gmane.linux.nfs/50011 <pre> Benny hi If I remember/understand correctly, there is a mode in the RFC errata about the layout forgetful-model and a client sending a layout_get with an open_state_id after he already had previous state (layouts) on the file. As I understood this is an indication to the server that client has "forgotten" all it's layouts on a file, and Server can assume their return. Is my understanding correct? If Yes: Did we implement the internal return of all layouts, if above open_state_id is encountered? I thought we did but I can't find this code. Currently, I always set ROC so there is no leak. But theoretically ROC does not have to be set. I'm doing some heavy lifting of layout_return, and I want to make sure I have not missed a spot. If I'm correct that it is needed, and it's missing: My suggestion for now is that we always set ROC, disregarding FS so not to leak layouts and therefor inode-refs, until such time that we implement it. Thanks Boaz -- To unsubscribe from this list: send the line "unsubscrib</pre> Boaz Harrosh 2012-05-24T00:16:40 http://comments.gmane.org/gmane.linux.nfs/49996 <pre>While working on some locking fixes I ran into trouble understanding the setclientid and setclientid_confirm code. So, here's some cleanup and minor bugfixes. The result is a lot simpler. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA&lt; at &gt;public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> J. Bruce Fields 2012-05-23T21:40:30 http://comments.gmane.org/gmane.linux.nfs/49985 <pre>Session initialisation is not complete until the lease manager has run. We need to ensure that both nfs4_init_session and nfs4_init_ds_session do so, and that they check for any resulting errors in clp-&gt;cl_cons_state. Only after this is done, can nfs4_ds_connect check the contents of clp-&gt;cl_exchange_flags. Signed-off-by: Trond Myklebust &lt;Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; Cc: Andy Adamson &lt;andros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- fs/nfs/client.c | 16 --------- fs/nfs/internal.h | 3 +- fs/nfs/nfs4filelayoutdev.c | 23 +------------ fs/nfs/nfs4proc.c | 77 ++++++++++++++++++++++++++++--------------- 4 files changed, 52 insertions(+), 67 deletions(-) diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 60f7e4e..78970a1 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c &lt; at &gt;&lt; at &gt; -593,22 +593,6 &lt; at &gt;&lt; at &gt; void nfs_mark_client_ready(struct nfs_client *clp, int state) } /* - * With sessions, the client is not marked ready until after a - * successf</pre> Trond Myklebust 2012-05-23T17:32:41 http://comments.gmane.org/gmane.linux.nfs/49981 <pre>From: Andy Adamson &lt;andros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; We only support one layout type per file system, so one threshold_item4 per mdsthreshold4. Signed-off-by: Andy Adamson &lt;andros-HgOvQuBEEgTQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; --- fs/nfs/nfs4xdr.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++- include/linux/nfs4.h | 7 +++ include/linux/nfs_xdr.h | 10 ++++ 3 files changed, 140 insertions(+), 2 deletions(-) diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index db040e9..db199f8 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c &lt; at &gt;&lt; at &gt; -99,9 +99,12 &lt; at &gt;&lt; at &gt; static int nfs4_stat_to_errno(int); #define nfs4_path_maxsz(1 + ((3 + NFS4_MAXPATHLEN) &gt;&gt; 2)) #define nfs4_owner_maxsz(1 + XDR_QUADLEN(IDMAP_NAMESZ)) #define nfs4_group_maxsz(1 + XDR_QUADLEN(IDMAP_NAMESZ)) +/* We support only one layout type per file system */ +#define decode_mdsthreshold_maxsz (1 + 1 + nfs4_fattr_bitmap_maxsz + 1 + 8) /* This is based on getfattr, which uses the most attributes: */ #define nfs4_fattr_</pre> andros-HgOvQuBEEgTQT0dZR+AlfA< at >public.gmane.org 2012-05-23T09:02:34 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.nfs