gmane.linux.network

nl80211 NULL pointer dereference

Linus Torvalds — 2013-06-19T01:46:13

Hmm. Maybe this is old, but I don't think I've seen it before (who
knows, maybe it has killed the machine before, I had a hard hang the
other day).

It's a NULL pointer dereference in nl80211_set_reg() on my Pixel. The
machine kind of stayed up afterwards, although with no working
wireless, and it would not shut down cleanly presumably due to locks
held etc.

Any ideas? I'm including the few wireless-related messages that
happened justr before the oops. Being a pixel, this is with the ath9k
driver.

                     Linus

---
  wlp1s0: authenticate with 00:c0:23:ba:27:40
  wlp1s0: send auth to 00:c0:23:ba:27:40 (try 1/3)
  wlp1s0: authenticated
  ath9k 0000:01:00.0 wlp1s0: disabling HT as WMM/QoS is not supported by the AP
  ath9k 0000:01:00.0 wlp1s0: disabling VHT as WMM/QoS is not supported by the AP
  wlp1s0: associate with 00:c0:23:ba:27:40 (try 1/3)
  wlp1s0: RX AssocResp from 00:c0:23:ba:27:40 (capab=0x501 status=0 aid=4)
  wlp1s0: associated
  cfg80211: Calling CRDA for country: US

  BUG: unable

Problems in tc-ematch.8

2013-06-19T01:02:57

This is automatically generated email about markup problems in a man
page for which you appear to be responsible.  If you are not the right
person or list, please tell me so I can correct my database.

See http://catb.org/~esr/doclifter/bugs.html for details on how and
why these patches were generated.  Feel free to email me with any
questions.  Note: These patches do not change the modification date of
any manual page.  You may wish to do that by hand.

I apologize if this message seems spammy or impersonal. The volume of
markup bugs I am tracking is over five hundred - there is no real
alternative to generating bugmail from a database and template.

--
                             Eric S. Raymond
Problems with tc-ematch.8:

Use of low-level troff hackery to set special indents or breaks can't
be translated. The page will have rendering faults in HTML, and
probably also under third-party man page browsers such as Xman,
Rosetta, and the KDE help browser.  This patch eliminates .br, .ta, .ti,
.ce, .in, and \h

[PATCH v2 net-next 0/2] bnx2x: add support for low latency rx

Dmitry Kravkov — 2013-06-18T22:36:03

Hi Dave

This series adds to bnx2x driver capabilities for low latency rx.
It bases on ixgbe driver code and tested with TCP_RR/UDP_RR.
The results show about 50% boost in both scenarious. With second patch
we have additional 5%.

Please, consider applying it to net-next.

V1->V2
* change function prototypes from int to bool (from Eric)
* do not allow poll when GRO/LRO enabled

Thanks,
Dmitry

[PATCH net] vxlan: fix check for migration of static entry

Stephen Hemminger — 2013-06-18T21:27:01

The check introduced by:
commit 26a41ae604381c5cc0caf1c3261ca6b298b5fe69
Author: stephen hemminger <stephen< at >networkplumber.org>
Date:   Mon Jun 17 12:09:58 2013 -0700

    vxlan: only migrate dynamic FDB entries

was not correct because it is checking flag about type of FDB
entry, rather than the state (dynamic versus static). The confusion
arises because vxlan is reusing values from bridge, and bridge is
reusing values from neighbour table, and easy to get lost in translation.

Signed-off-by: Stephen Hemminger <stephen< at >networkplumber.org>
---
 drivers/net/vxlan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index dda997a..57325f3 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
< at >< at > -579,7 +579,7 < at >< at > static bool vxlan_snoop(struct net_device *dev,
 return false;
 
 /* Don't migrate static entries, drop packets */
-if (!(f->flags & NTF_SELF))
+if (f->state & NUD_NOARP)
 return true;
 
 if (net_ratelimit())

Suply Sample

Donald Ness — 2013-06-18T18:40:42


Hello sir/madam how are you doing i hope fine. Sir i contacted you r company so we can go into seriouse business . I will like you to supply the following product in a large quantity to my company i have attach a sample of it kindly view the sample in the attachment and see if you can supply much of it to my compnay. View it and get back to me as soon as possible so i can place and order for it. I look forward to hear from you soon thanks and have a great day .

Kind regars

Donald

[PATCH V2] rtlwifi: rtl8192cu: Fix duplicate if test

Larry Finger — 2013-06-18T18:25:05

A typo causes routine rtl92cu_phy_rf6052_set_cck_txpower() to test the
same condition twice. The problem was found using cppcheck-1.49, and the
proper fix was verified against the pre-mac80211 version of the code.

This patch was originally included as commit 1288aa4, but was accidentally
reverted in a later patch.

Reported-by: David Binderman <dcb314< at >hotmail.com> [original report]
Reported-by: Andrea Morello <andrea.merello< at >gmail.com> [report of accidental reversion]
Signed-off-by: Larry Finger <Larry.Finger< at >lwfinger.net>
Cc: stable <stable< at >vger.kernel.org>  [back to 2.6.39]
---

John,

Although this patch is trivial and could be included in the 3.10 stream,
I think we should not burden DaveM nor Linus with it this late in the 3.10
cycle. Please push it into the 3.11 stream.

Thanks,

Larry
---

V2 - Fix error in stable mailing address
---
 drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/ne

[PATCH] rtlwifi: rtl8192cu: Fix duplicate if test

Larry Finger — 2013-06-18T18:18:17

A typo causes routine rtl92cu_phy_rf6052_set_cck_txpower() to test the
same condition twice. The problem was found using cppcheck-1.49, and the
proper fix was verified against the pre-mac80211 version of the code.

This patch was originally included as commit 1288aa4, but was accidentally
reverted in a later patch.

Reported-by: David Binderman <dcb314< at >hotmail.com> [original report]
Reported-by: Andrea Morello <andrea.merello< at >gmail.com> [report of accidental reversion]
Signed-off-by: Larry Finger <Larry.Finger< at >lwfinger.net>
Cc: stable <stable< at >kernel.org>  [back to 2.6.39]
---

John,

Although this patch is trivial and could be included in the 3.10 stream,
I think we should not burden DaveM nor Linus with it this late in the 3.10
cycle. Please push it into the 3.11 stream.

Thanks,

Larry
---
 drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
index 953f1a0..21

[PATCH net] sfc: Remove write permission from phy_type attribute

Ben Hutchings — 2013-06-18T16:45:40

Driver probe currently results in:

WARNING: at drivers/base/core.c:576 device_create_file+0x57/0x7e()
Attribute phy_type: write permission without 'store'

Signed-off-by: Ben Hutchings <bhutchings< at >solarflare.com>
---
 drivers/net/ethernet/sfc/efx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 39e4cb3..4a14a94 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
< at >< at > -2139,7 +2139,7 < at >< at > show_phy_type(struct device *dev, struct device_attribute *attr, char *buf)
 struct efx_nic *efx = pci_get_drvdata(to_pci_dev(dev));
 return sprintf(buf, "%d\n", efx->phy_type);
 }
-static DEVICE_ATTR(phy_type, 0644, show_phy_type, NULL);
+static DEVICE_ATTR(phy_type, 0444, show_phy_type, NULL);
 
 static int efx_register_netdev(struct efx_nic *efx)
 {

[PATCH net-next V1 0/2] Low latency Socket support

Amir Vadai — 2013-06-18T13:18:26

Hi Dave,

Please pull those 2 patches, which add support in Low Latency Socket (LLS) to
mlx4_en.

Will send performance numbers later on

Thanks,
Amir

Changes from v0:
- Make sure we respect RCU grace period after calling napi_hash_del
- Disable GRO if LL polling is in process
- Allways enable LLS statistics when LLS is in use.
- Move code related to statistics that was mistakenly placed in patch 1/1 into
  patch 2/2
- MLX4_EN_CQ_STATEXXXX => MLX4_EN_CQ_STATE_XXXX
- Use bool instead of int

Amir Vadai (2):
  net/mlx4_en: Add Low Latency Socket (LLS) support
  net/mlx4_en: Low Latency recv statistics

 drivers/net/ethernet/mellanox/mlx4/en_cq.c      |   3 +
 drivers/net/ethernet/mellanox/mlx4/en_ethtool.c |  20 +++-
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c  |  47 ++++++++-
 drivers/net/ethernet/mellanox/mlx4/en_rx.c      |  15 ++-
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h    | 127 ++++++++++++++++++++++++
 5 files changed, 207 insertions(+), 5 deletions(-)

[PATCH net-next] tcp:typo unset should be unsent

Weiping Pan — 2013-06-18T13:00:31

Signed-off-by: Weiping Pan <wpan< at >redhat.com>
---
 net/ipv4/tcp_output.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 3dd46ea..e2c1333 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
< at >< at > -185,7 +185,7 < at >< at > static inline void tcp_event_ack_sent(struct sock *sk, unsigned int pkts)
 u32 tcp_default_init_rwnd(u32 mss)
 {
 /* Initial receive window should be twice of TCP_INIT_CWND to
- * enable proper sending of new unset data during fast recovery
+ * enable proper sending of new unsent data during fast recovery
  * (RFC 3517, Section 4, NextSeg() rule (2)). Further place a
  * limit when mss is larger than 1460.
  */

redirect host vs ip route cache

Sergey — 2013-06-18T12:42:56

Hello guys,

the network scheme is the following:

Servers in network 10.0.0.0/24 -> 10.0.0.1 (core) -> 10.0.0.2 (router with 
NAT to 1.2.3.4) -> internet

As you might have guessed I have the problem with "router with NAT".
It is Debian with kernel 3.2.0-0.bpo.4-amd64.

When I try to ping/telnet/etc. I get a problem.

Example:

Server 10.0.0.123 ping 4.2.2.4:

# ping 4.2.2.4
PING 4.2.2.4 (4.2.2.4) 56(84) bytes of data.
From 10.0.0.1: icmp_seq=3 Redirect Host(New nexthop: 10.0.0.2)
From 1.2.3.4 icmp_seq=1 Destination Host Unreachable 

On 10.0.0.2 we can see in ip route cache:

10.0.0.123 from 4.2.2.4 dev eth0  src 1.2.3.4
    cache  ipid 0x3837 rtt 75ms rttvar 60ms cwnd 10 iif eth0.635
4.2.2.4 from 10.0.0.123 tos lowdelay via 10.0.0.2 dev eth0.635  src 10.0.0.2 
    cache <src-direct,redirected>  ipid 0x6955 iif eth0
4.2.2.4 from 10.0.0.123 via 10.0.0.2 dev eth0.635  src 10.0.0.2 
    cache <src-direct>  ipid 0x6955 iif eth0
4.2.2.4 via 10.0.0.2 dev eth0.635  src 1.2.3.4
    cache <redirected>  ipid 0x6955

[PATCH net-next] bonding: trivial: make alb use bond_slave_has_mac()

Veaceslav Falico — 2013-06-18T11:44:52

Also, cleanup bond_alb_handle_active_change() from 2 identical ifs.

Signed-off-by: Veaceslav Falico <vfalico< at >redhat.com>
---
 drivers/net/bonding/bond_alb.c | 53 +++++++++---------------------------------
 1 file changed, 11 insertions(+), 42 deletions(-)

diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 27fe329..4ea8ed1 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
< at >< at > -1129,6 +1129,7 < at >< at > static void alb_change_hw_addr_on_detach(struct bonding *bond, struct slave *sla
 {
 int perm_curr_diff;
 int perm_bond_diff;
+struct slave *found_slave;
 
 perm_curr_diff = !ether_addr_equal_64bits(slave->perm_hwaddr,
   slave->dev->dev_addr);
< at >< at > -1136,21 +1137,12 < at >< at > static void alb_change_hw_addr_on_detach(struct bonding *bond, struct slave *sla
   bond->dev->dev_addr);
 
 if (perm_curr_diff && perm_bond_diff) {
-struct slave *tmp_slave;
-int i, found = 0;
-
-bond_for_each_slave(bond, tmp_slave, i) {
-if (ether_addr_equal_64bits

UDP "accept" proposed

James Yonan — 2013-06-18T08:48:26

One of the frustrations of creating UDP servers using BSD sockets is 
that there isn't an easy way for a server to pass off a socket for a 
particular client instance to a handler thread or process.

By contrast, with TCP you can "accept" an incoming connection, and pass 
the socket representing that connection off to any arbitrary handler.

But UDP servers that want to play well with stateful firewalls and NAT 
are forced to aggregate their entire connection pool onto a single 
socket, since BSD sockets don't have the equivalent of an "accept" 
mechanism to provide a connection-specific socket.

This is a disaster from a performance perspective because you can't take 
a UDP server that binds to a single port and efficiently scale it up 
across multiple threads or processors because you must operate off a 
single socket.

So why can't I "accept" a UDP socket?  The conventional response would 
be that UDP is connectionless and that "accept" is meaningless outside 
the context of a connection.  UDP may be conn

[net PATCH 1/1] drivers: net: cpsw: fix cpsw clock gating issue across suspend/resume

Mugunthan V N — 2013-06-18T09:34:35

Due to some hardware integration issue, CPSW sliver modules requires a
reset across suspend/resume cycle for a successful clock gating to
CPGMAC (CPSW and Davinci MDIO) in AM335x PG1.0.
This issue is fixed in PG2.x, though to support suspend/resume on PG1.0
this reset is required.

Signed-off-by: Mugunthan V N <mugunthanvnm< at >ti.com>
---
 drivers/net/ethernet/ti/cpsw.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 2fd69db..e66a202 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
< at >< at > -1976,6 +1976,8 < at >< at > static int cpsw_suspend(struct device *dev)
 
 if (netif_running(ndev))
 cpsw_ndo_stop(ndev);
+soft_reset("sliver 0", &priv->slaves[0].sliver->soft_reset);
+soft_reset("sliver 1", &priv->slaves[1].sliver->soft_reset);
 pm_runtime_put_sync(&pdev->dev);
 
 return 0;

[PATCH net-next 0/5] Further SCTP changes

Daniel Borkmann — 2013-06-18T08:55:15

Mostly it's all about getting rid of unnecessary code, and/or making
it more clean and readable.

Code has been tested with lksctp-tools functional test suite and
also my small sctp stress test helper that was used to discover
the recent null-ptr derefs. This test was also sucessfully run against
auth_enabled=0 and auth_enabled=1, where I also previously applied
the following two patches:

  - http://marc.info/?l=linux-crypto-vger&m=137121898331017&w=2
    -> not yet applied, still pending review for crypto tree
  - 1abd165 (net: sctp: fix NULL pointer dereference in socket destruction)
    -> cherry picked from net tree

Daniel Borkmann (5):
  net: sctp: remove TEST_FRAME ifdef
  ktime: add ms_to_ktime() and ktime_add_ms() helpers
  net: sctp: migrate cookie life from timeval to ktime
  net: sctp: decouple cleaning socket data from endpoint
  net: sctp: minor: sctp_seq_dump_local_addrs add missing newline

 include/linux/ktime.h      | 13 +++++++++++++
 include/net/sctp/sctp.h    | 25 ----------------------

[PATCH net-next 0/2] bnx2x: add support for low latency rx

Dmitry Kravkov — 2013-06-18T07:42:11

Hi Dave

This series adds to bnx2x driver capabilities for low latency rx.
It bases on ixgbe driver code and tested with TCP_RR/UDP_RR.
The results show about 50% boost in both scenarious. With second patch
we have additional 5%.

Please, consider applying it to net-next.

Thanks,
Dmitry

[RFC patch RESEND net-next 1/1] tcp: introduce TCP experimental option for SMC-R

Ursula Braun — 2013-06-18T07:07:55

From: Ursula Braun <ubraun< at >linux.vnet.ibm.com>

Since I haven't received any comments to my posting from 2013/06/05
I plan to submit my patch for real inclusion into net-next. Any
objections before I start submitting?

RDMA is considered to become an important technology for IBM System z
(which is "s390" in Linux kernel terminology).
We intend to introduce a new socket protocol family providing Shared
Memory Communications over RDMA called SMC-R. The respective IETF draft
can be found at [1]. Its objective is to come up with a low latency, but
also low CPU cost communication vehicle exploiting RDMA technology
transparently while keeping the TCP/IP administration model and allowing
fallback to TCP sockets if necessary. The SMC-R protocol makes use of
the existing TCP 3-way hand shake, the TCP connection and IP topology to
preserve the traditional network administrative model including network
security. The SMC-R protocol also enables redundancy and load balancing
across multiple RDMA-capable devices.

An esse

[PATCH v2.33] datapath: Add basic MPLS support to kernel

Simon Horman — 2013-06-18T07:06:49

Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.

Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.

Cc: Ravi K <rkerur< at >gmail.com>
Cc: Leo Alterman <lalterman< at >nicira.com>
Cc: Isaku Yamahata <yamahata< at >valinux.co.jp>
Cc: Joe Stringer <joe< at >wand.net.nz>
Signed-off-by: Simon Horman <horms< at >verge.net.au>

---

This patch depends on "gre: Restructure tunneling" which it aims
to be compatible with.

This is the remaining patch of the series "MPLS actions and matches".
To aid review it and its dependency are available in git at:

        git://github.com/horms/openvswitch.git devel/mpls-v2.33

v2.33
* Ensure that inner_protocol is always set to to the current
  skb->protocol value in ovs_execute_actions(). This ensures
  it is set to the correct value in the absence of a push_mpls action.
  Also remove setting of inner_protocol in push_mpls() as
  it duplicates the code now in ovs_execute_actions().
* Call _

[stmmac] On mtu change, Not able to ping Host

sivareddy kallam — 2013-06-18T05:57:33

Hi All,
We are working on ARM based SoC and using STMMAC Ethernet driver.
In our scenario, we are setting MTU size as more than Ethernet frame size.

Scenario:
1) Setting MTU for Host side, Target side(ARM based SoC) as 5000 bytes.
2) pinging host with packet size 3000, it is fail to ping host.
3) ping host with packet size less than 1586, it is able to ping host

Can you please guide me on this issue?

Thank you.
Siva

[PATCH (net.git)] stmmac: fix EEE setup

Giuseppe CAVALLARO — 2013-06-18T05:03:23

This patch fixes the EEE setup allowing to configure this support
when the link changes.

Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro< at >st.com>
---
 drivers/net/ethernet/stmicro/stmmac/common.h      |    4 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |   66 ++++++++++-----------
 2 files changed, 33 insertions(+), 37 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
index 7788fbe..9517697 100644
--- a/drivers/net/ethernet/stmicro/stmmac/common.h
+++ b/drivers/net/ethernet/stmicro/stmmac/common.h
< at >< at > -297,8 +297,8 < at >< at > struct dma_features {
 #define MAC_RNABLE_RX0x00000004/* Receiver Enable */
 
 /* Default LPI timers */
-#define STMMAC_DEFAULT_LIT_LS_TIMER0x3E8
-#define STMMAC_DEFAULT_TWT_LS_TIMER0x0
+#define STMMAC_DEFAULT_LIT_LS0x3E8
+#define STMMAC_DEFAULT_TWT_LS0x0
 
 #define STMMAC_CHAIN_MODE0x1
 #define STMMAC_RING_MODE0x2
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro

Problems in bridge.8, ip-netns.8, ip-maddress.8, ip-tunnel.8, ip-route.8, ip-neighbour.8, ip-rule.8

2013-06-18T05:14:05

This is automatically generated email about markup problems in a man
page for which you appear to be responsible.  If you are not the right
person or list, please tell me so I can correct my database.

See http://catb.org/~esr/doclifter/bugs.html for details on how and
why these patches were generated.  Feel free to email me with any
questions.  Note: These patches do not change the modification date of
any manual page.  You may wish to do that by hand.

I apologize if this message seems spammy or impersonal. The volume of
markup bugs I am tracking is over five hundred - there is no real
alternative to generating bugmail from a database and template.

--
                             Eric S. Raymond
Problems with ip-route.8:

Presentation-level use of SS could not be structurally
translated. I changed lower-level instances to .TP.

--- ip-route.8-unpatched2013-06-01 06:58:12.898961138 -0400
+++ ip-route.82013-06-01 06:58:34.070960742 -0400
< at >< at > -246,10 +246,16 < at >< at >
 .I policy routing
 is used.
 
-.SS ip route a