http://blog.gmane.org/gmane.linux.kernel.janitors hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.linux.kernel.janitors/23361 <pre>Sparse complains that these signed bitfields look "dubious". The problem is that instead of being either 0 or 1 like people would expect, signed one bit variables like this are either 0 or -1. It doesn't cause a problem in this case but it's ugly so lets fix them. Signed-off-by: Dan Carpenter &lt;dan.carpenter&lt; at &gt;oracle.com&gt; --- I just did this against linux next but it applies fine on top of Mathieu's recent patches. diff --git a/drivers/staging/lttng/lib/ringbuffer/backend_types.h b/drivers/staging/lttng/lib/ringbuffer/backend_types.h index 1d301de..019929a 100644 --- a/drivers/staging/lttng/lib/ringbuffer/backend_types.h +++ b/drivers/staging/lttng/lib/ringbuffer/backend_types.h &lt; at &gt;&lt; at &gt; -65,7 +65,7 &lt; at &gt;&lt; at &gt; struct channel_backend { * for writer. */ unsigned int buf_size_order;/* Order of buffer size */ -int extra_reader_sb:1;/* Bool: has extra reader subbuffer */ +unsigned int extra_reader_sb:1;/* Bool: has extra reader subbuffer */ struct lib_ring_buffer *buf;/* Channel per-cpu buffers */ </pre> Dan Carpenter 2011-12-01T09:37:47 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.kernel.janitors