http://blog.gmane.org/gmane.linux.kernel.firewire.devel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15557 <pre>The following patches are available in the "testing" branch at git://git.kernel.org/pub/scm/libs/ieee1394/libraw1394.git testing and will also be posted right away for review. If there are no complaints, I will fetch it into the master branch and cut a 2.0.9 release from this soon. Motives for the changes are explained in patch 2/3. I don't recommend to do something like this in each and every firewire-cdev based program; I just felt that this is preferable for the case of a base library that libraw1394 is, especially after an incident in which obscure problems with audio devices were caused by a libraw1394 which was built with outdated kernel headers. Stefan Richter (3): Add firewire-{cdev,constants}.h from Linux v3.4 Include local firewire-*.h instead of system-wide &lt;linux/firewire-*.h&gt; Remove unused code configure.ac | 7 - src/Makefile.am | 11 +- src/firewire-cdev.h | 1038 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/</pre> Stefan Richter 2012-05-25T22:18:02 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15556 <pre>Hi all, Linux kernel 3.4 has been released last Sunday. These are the IEEE 1394 related changes: &lt;linux/firewire-cdev.h&gt; API: - Added FW_CDEV_IOC_FLUSH_ISO ioctl which lets an application get any currently completed isochronous packets reported. A corresponding libraw1394 update to use this ioctl in raw1394_iso_recv_flush() has been committed to libraw1394.git too and will show up in the next libraw1394 release. firewire-core, -net, -ohci, -sbp2: - All messages to the kernel log are now consistently prefixed by driver name and device name or number. firewire-ohci: - Fix premature completion of multichannel isochronous reception DMA. Also fixed in kernel 3.3.1, 3.2.14, 3.0.27. - Fix missing completion notification in isochronous I/O in case of big intervals between interrupt packets or with big packet headers. firewire-sbp2: - If the target's unit directory contains a Unit_Unique_ID entry, use it instead of the node unique ID as the target's GUID in the ieee139</pre> Stefan Richter 2012-05-24T20:44:47 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15555 <pre>Linus, please pull from the tag "firewire-updates" at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git firewire-updates to receive the following IEEE 1394 (FireWire) subsystem updates: - Fix mismatch between DMA mapping direction (was wrong) and DMA synchronization direction (was correct) of isochronous reception buffers of userspace drivers if vma-mapped for R/W access. For example, libdc1394 was affected. - more consistent retry stategy in device discovery/ rediscovery, and improved failure diagnostics - various small cleanups, e.g. use SCSI layer's DMA mapping API in firewire-sbp2 The last few commits happened rather late for this pull request but I feel comfortable with them. ALSA firewire-lib changes were written by Clemens, hence are implicitly ACKed. Axel Lin (1): firewire: use module_pci_driver Clemens Ladisch (10): firewire: core: wait for inaccessible devices after bus reset firewire: core: improve reread_config_rom() interface </pre> Stefan Richter 2012-05-24T19:14:55 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15550 <pre>The type of the length field of the fw_address_handler structure was size_t, which restricted it to 32 bits on 32-bit architectures. While making it u32 would match the userspace API, all calculations on this field use 64 bits anyway, and the ability to use 4 GB or larger address ranges is useful in the kernel. Signed-off-by: Clemens Ladisch &lt;clemens&lt; at &gt;ladisch.de&gt; --- include/linux/firewire.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- a/include/linux/firewire.h +++ b/include/linux/firewire.h &lt; at &gt;&lt; at &gt; -307,7 +307,7 &lt; at &gt;&lt; at &gt; struct fw_transaction { struct fw_address_handler { u64 offset; -size_t length; +u64 length; fw_address_callback_t address_callback; void *callback_data; struct list_head link; ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile </pre> Clemens Ladisch 2012-05-24T17:28:17 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15535 <pre> drivers/firewire/sbp2.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ </pre> Clemens Ladisch 2012-05-18T16:38:20 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15522 <pre>Hi all, at the moment I would like to proceed with libraw1394 like this: 1. Add a copy of linux/firewire-{constants,cdev}.h to the libraw1394 sources in order to ensure that all features which a particular libraw1394 version supports are actually built, rather than silently disabled at build time if older kernel headers are present. 2. Release libraw1394 v2.0.9. 3. Add an API to add a descriptor to the local Config ROM: http://thread.gmane.org/gmane.linux.kernel.firewire.devel/14878/focus=14881 - Do we want the remove-descriptor counterpart too, or would applications be satisfied with exit() or raw1394_destroy_handle() to do so? 4. Add an API which does the same as raw1394_read_cycle_timer() but lets the user select a clock other than CLOCK_REALTIME (e.g. the monotonic clock which is never reset by ntpd or other means to set the clock). http://subversion.ffado.org/ticket/242 - Should that new API stay with u_int64_t *local_time (microseconds, i.e. a like the struct timeval *tv argument</pre> Stefan Richter 2012-05-11T18:44:34 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15516 <pre>Hi all, today, editing functionality of the wikis at kernel.org has been restored. I will slowly update the ieee1394.wiki with current release notes, to-do items etc. but everyone else is of course welcome to do so as well. </pre> Stefan Richter 2012-05-02T21:02:13 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15515 <pre>For the list to know: Date: Tue, 1 May 2012 11:09:12 GMT From: bugzilla-daemon&lt; at &gt;bugzilla.kernel.org To: stefanr&lt; at &gt;s5r6.in-berlin.de Subject: [Bug 10935] fw-ohci: ALi M52xx unsupported https://bugzilla.kernel.org/show_bug.cgi?id=10935 Stefan Richter &lt;stefanr&lt; at &gt;s5r6.in-berlin.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #15 from Stefan Richter &lt;stefanr&lt; at &gt;s5r6.in-berlin.de&gt; 2012-05-01 11:09:12 --- After a long while of using the PCI slots for other cards, I put the Belkin F50508 back in yesterday in order to get back to this bug again. ------------------------------------------------------------------------- boot ------------------------------------------------------------------------- Apr 30 20:38:16 stein kernel: pci 0000:0c:07.0: [10b9:5237] type 00 class 0x0c0310 Apr 30 20:38:16 </pre> Stefan Richter 2012-05-01T11:14:25 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15510 <pre>Hello, My name is Staff Sergeant Larry Wayne with a desperate need for an mutual business proposal that will benefit both of us, please get back to me if you are interested to hear Sgt Larry Wayne ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ </pre> Sgt Larry Wayne 2012-04-28T08:40:15 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15469 <pre>... I just got annoyed that the "BM lock failed" and "giving up" messages did not show the actual error; and fixed other things along the way. drivers/firewire/core-card.c | 4 drivers/firewire/core-device.c | 124 +++++++++++++--------------- drivers/firewire/core-transaction.c | 26 +++++ include/linux/firewire.h | 1 sound/firewire/lib.c | 28 ------ sound/firewire/lib.h | 1 6 files changed, 91 insertions(+), 93 deletions(-) ------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev </pre> Clemens Ladisch 2012-04-11T15:35:39 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15451 <pre>bus_reset_work's reg is a bitfield. Signed-off-by: Stefan Richter &lt;stefanr&lt; at &gt;s5r6.in-berlin.de&gt; --- drivers/firewire/ohci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c &lt; at &gt;&lt; at &gt; -1822,8 +1822,8 &lt; at &gt;&lt; at &gt; static void bus_reset_work(struct work_s { struct fw_ohci *ohci = container_of(work, struct fw_ohci, bus_reset_work); -int self_id_count, i, j, reg; -int generation, new_generation; +int self_id_count, generation, new_generation, i, j; +u32 reg; unsigned long flags; void *free_rom = NULL; dma_addr_t free_rom_bus = 0; </pre> Stefan Richter 2012-04-09T19:39:53 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15449 <pre>fw_device_op_mmap()'s decision for a DMA direction can go wrong. I just got this after a libdc1394 update on a PC with DMA mapping API debugging turned on: Apr 9 17:56:14 mini WARNING: at lib/dma-debug.c:989 check_sync+0x2e4/0x508() Apr 9 17:56:14 mini Hardware name: Macmini1,1 Apr 9 17:56:14 mini firewire_ohci 0000:03:03.0: DMA-API: device driver syncs DMA memory with different direction [device address=0x00000000316e3000] [size=4096 bytes] [mapped with DMA_TO_DEVICE] [synced with DMA_FROM_DEVICE] Apr 9 17:56:14 mini Modules linked in: firewire_ohci firewire_core netconsole nfs lockd sunrpc rtc sr_mod cdrom sg applesmc snd_hda_codec_idt input_polldev coretemp i2c_i801 snd_hda_intel snd_hda_codec snd_pcm snd_timer sky2 snd snd_page_alloc Apr 9 17:56:14 mini Pid: 12837, comm: coriander Not tainted 3.4.0-rc2 #3 Apr 9 17:56:14 mini Call Trace: Apr 9 17:56:14 mini [&lt;c10219e4&gt;] warn_slowpath_common+0x65/0x7a Apr 9 17:56:14 mini [&lt;c1111b32&gt;] ? check_sync+0x2e4/0x508 Apr 9 17:56:14 mini [&lt;c1021a5d&gt;] warn</pre> Stefan Richter 2012-04-09T16:26:23 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15445 <pre>Hello, I use Ubuntu 10.10 on a laptop dell latitude e5520. When I take to hibernate the computer, and then I reboot it, appears an error : uname -a : I attach to the email a cat of the syslog on the reboot time of the machine (going out of hibernation). What could I do in order to help you to debug this problem ? Regards, Anael ------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev</pre> Anael 2012-04-03T10:14:12 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15444 <pre>This patch converts the drivers in drivers/firewire/* to use module_pci_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Axel Lin &lt;axel.lin&lt; at &gt;gmail.com&gt; Cc: Kristian Hoegsberg &lt;krh&lt; at &gt;bitplanet.net&gt; --- drivers/firewire/nosy.c | 20 ++++---------------- drivers/firewire/ohci.c | 15 ++------------- 2 files changed, 6 insertions(+), 29 deletions(-) diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c index a7c4422..4ebfb22 100644 --- a/drivers/firewire/nosy.c +++ b/drivers/firewire/nosy.c &lt; at &gt;&lt; at &gt; -693,6 +693,8 &lt; at &gt;&lt; at &gt; static struct pci_device_id pci_table[] __devinitdata = { { }/* Terminating entry */ }; +MODULE_DEVICE_TABLE(pci, pci_table); + static struct pci_driver lynx_pci_driver = { .name =driver_name, .id_table =pci_table, &lt; at &gt;&lt; at &gt; -700,22 +702,8 &lt; at &gt;&lt; at &gt; static struct pci_driver lynx_pci_driver = { .remove =remove_card, }; +module_pci_driver(lynx_pci_driver); + MODULE_AUTHOR("Kristian Hoegsberg"); MODULE_DESCRIPTION("Snoop mode driver for TI pcilynx 1394 control</pre> Axel Lin 2012-04-03T02:07:01 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15439 <pre>One of the changes from OHCI-1394 v1.0 to v1.1 is that the PHY's SClk signal may sometimes not be present during normal operation, and accesses to certain registers fail then. See OHCI-1394 v1.1 sections 1.4.1, 4., and 6.1. The specification does not tell us though how to recover from this condition. This patch adds a check for this condition at each and every register access within the SClk domain. If the access failure is encountered, the access is retried 20 times in a busy loop in atomic contexts, or with 50 ms period (i.e. 1 second total retry time) in process contexts. If the failure persists, the error is passed up to higher layers. For example, if loss of SClk persists when the controller is initialized or is woken up in PM resume, the controller is not enabled and the pci_probe or resume fails. Since some of the accesses are in performance sensitive paths, notably cycleTimer access in the interrupt handler, this patch should perhaps be followed up by an optimization for OHCI 1.0 controllers an</pre> Stefan Richter 2012-04-01T22:57:47 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15438 <pre>Some of our subscribers already enjoyed the explosion! IKC_C.OB is one step closer to its target of $.50! Trade date: Friday, March 30th, 2012 Ticker: IKC_C.OB Recent press release of March 29: GameFace Gaming Inc announced today that its site, when launched shortly, will offer a innovative private table home-game experience on its web-based social gaming network "FaceUpGaming". "We have already completed the design and will very shortly launch the best internet home game experience". This PR will move IKC_C.OB to 0.50 in the shortest period. Get in immediately! Follow IKC_C.OB! Add it on your watch-list! Last 48 hours profit equals 50%! Exposure is closer! ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure </pre> Valentine Dodson 2012-03-30T13:14:15 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15435 <pre>Dear maintainers, During boot I saw the following message, so I complied [ 8.654566] firewire_ohci: Register access failure - please notify linux1394-devel&lt; at &gt;lists.sf.net [ 8.654756] firewire_ohci: Added fw-ohci device 0000:09:00.0, OHCI v1.10, 8 IR + 8 IT contexts, quirks 0x10 [ 8.654932] initcall fw_ohci_init+0x0/0x20 [firewire_ohci] returned 0 after 50723 usecs In attachment you can find the full dmesg log, the output of lspci -vv, and the output of lsmod. I have a Dell Latitude 5420 laptop running arch linux, 64-bit: Linux gerbil 3.2.12-1-ARCH #1 SMP PREEMPT Mon Mar 19 17:50:01 CET 2012 x86_64 Intel(R) Core(TM) i3-2330M CPU &lt; at &gt; 2.20GHz GenuineIntel GNU/Linux hth, Robrecht Dewaele ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure</pre> Robrecht Dewaele 2012-03-24T11:41:21 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15412 <pre>handle_ir_buffer_fill() assumed that a completed descriptor would be indicated by a non-zero transfer_status (as in most other descriptors). However, this field is written by the controller as soon as (the end of) the first packet has been written into the buffer. As a consequence, if we happen to run into such a descriptor when the interrupt handler is executed after such a packet has completed, the descriptor would be taken out of the list of active descriptors as soon as the buffer had been partially filled, so the event for the buffer being completely filled would never be sent. To fix this, handle descriptors only when they have been completely filled, i.e., when res_count == 0. (This also matches the condition that is reported by the controller with an interrupt.) Signed-off-by: Clemens Ladisch &lt;clemens&lt; at &gt;ladisch.de&gt; Cc: 2.6.36+ &lt;stable&lt; at &gt;vger.kernel.org&gt; --- drivers/firewire/ohci.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/</pre> Clemens Ladisch 2012-03-12T20:45:47 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15410 <pre>CONFIG_FIREWIRE_OHCI_DEBUG could have been exposed to kernel tweakers if CONFIG_EXPERT was set. But in hindsight, this stuff is far too useful to omit it. So get rid of two #else branches that are only going to bitrot otherwise. Signed-off-by: Stefan Richter &lt;stefanr&lt; at &gt;s5r6.in-berlin.de&gt; --- drivers/firewire/Kconfig | 5 ----- drivers/firewire/ohci.c | 20 +------------------- 2 files changed, 1 insertion(+), 24 deletions(-) --- a/drivers/firewire/Kconfig +++ b/drivers/firewire/Kconfig &lt; at &gt;&lt; at &gt; -28,11 +28,6 &lt; at &gt;&lt; at &gt; config FIREWIRE_OHCI To compile this driver as a module, say M here: The module will be called firewire-ohci. -config FIREWIRE_OHCI_DEBUG -bool -depends on FIREWIRE_OHCI -default y - config FIREWIRE_SBP2 tristate "Storage devices (SBP-2 protocol)" depends on FIREWIRE &amp;&amp; SCSI --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c &lt; at &gt;&lt; at &gt; -338,8 +338,6 &lt; at &gt;&lt; at &gt; MODULE_PARM_DESC(quirks, "Chip quirks (d #define OHCI_PARAM_DEBUG_IRQS4 #define OHCI_PARAM_DEBUG_BUSRESETS8 /* only effectiv</pre> Stefan Richter 2012-03-04T20:34:21 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15408 <pre>So here is about half of the necessary implementation for SCLK loss handling. The "fixme" comments in the ohci.h diff at the end of this patch indicate which registers are not yet checked against regAccessFail in some or all of their accesses. In terms of functions that need to be modified yet, this means: ohci_read_csr() ohci_write_csr() get_cycle_time() context_run() context_stop() detect_dead_context() ohci_flush_iso() and possibly some of their callers. The latter four functions may encounter regAccessFail only together with IR contexts, not with AT, AR, or IT contexts. ohci_read_csr() and ohci_write_csr() will need to have their function prototypes changed to return 0 or -ERRNO. This change needs to bubble up to core.h::struct fw_card_driver and to firewire-core's call sites. A thorough reader of the diff will notice that a great deal of failure handling merely serves to limit the damage somewhat; recovery is hardly possible anywhere. Sometimes an error message in the log is still the only </pre> Stefan Richter 2012-03-04T19:45:28 http://comments.gmane.org/gmane.linux.kernel.firewire.devel/15407 <pre>The "skipped bus generations" message was added together with the respective fw_device retaining/ reviving code in order to see how it all works out. It did well, so don't spam the log anymore. The "register access failure" situation still needs an actual handler. But at this point it makes less sense to ask folks to send mails about it. We now have a pretty good picture of what controllers emit this and when: Texas Instruments PCIxx21 FireWire + CardBus + flash memory card controller: https://bugzilla.redhat.com/show_bug.cgi?id=608544 O2 Micro FireWire + flash memory card controller: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/801719 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/881688 http://marc.info/?l=linux1394-devel&amp;m=132309283531423 http://marc.info/?l=linux1394-devel&amp;m=132368567907469 http://marc.info/?l=linux1394-devel&amp;m=132516165727468 http://marc.info/?l=linux1394-devel&amp;m=133006486927699 Pinnacle Movieboard: commit 7f7e37115a8b6724f26d0637a04e1d35e3c59717 http://marc.info/?l=</pre> Stefan Richter 2012-03-04T13:24:31 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.kernel.firewire.devel