gmane.linux.kernel.device-mapper.devel

path_checker within multipath {}

Matthew Kent — 2008-11-27T19:47:54

Am I missing something obvious here? /usr/share/doc/device-mapper-multipath-0.4.7/multipath.conf.annotated says this should work, and I can't find a RHEL 5 issue for it: My config says: multipaths { multipath { wwid "22263000155ada9e9" path_grouping_policy failover path_checker tur } multipath { wwid "36090a018108277e8ed92e4e9cee1733e" path_grouping_policy multibus path_checker readsector0 } } but multipathd -k"show conf" says: multipaths { multipath { wwid 22263000155ada9e9 path_grouping_policy failover } multipath { wwid 36090a018108277e8ed92e4e9cee1733e path_grouping_policy multibus } and multipath -v3 shows them all sdb: path checker = readsector0 (config file default) while the grouping policy seems to work, pgpolicy = multibus (LUN setting) I'm sure I can use 'tur' on bot

Announce: unlimited number of shared snapshots

Mikulas Patocka — 2008-11-27T05:41:36

Hi I made first release of my snapshot storage that can hold unlimited number of snapshots and share data between them: http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/ How-to-use is at the beginning of dm-multisnapshot.patch If you see some errors, report them. This storage uses btree with the key (chunk number, snapshot range). It uses log-structured storage, so that it is safe w.r.t. crash. TODO: - reclaim allocated space, allow deleting snapshots - writable snapshots Mikulas

[PATCH 0/9] dm snapshot: shared exception store (v4)

FUJITA Tomonori — 2008-11-26T16:17:30

This is the fourth version of the shared exception store (based on Zumastor code). You can find the previous submissions: https://www.redhat.com/archives/dm-devel/2008-August/msg00003.html https://www.redhat.com/archives/dm-devel/2008-August/msg00087.html https://www.redhat.com/archives/dm-devel/2008-October/msg00159.html Except for bug fixes, the major change since the previous version is fixing the disk endian (Zumastor simply uses the CPU endian for the disk format). The current code uses little endian for the disk format (I just slightly tested it with ppc64. It needs more tests, of course). I also modified the snapshot disk initialization code to reserve chunks for the journaling mechanism. I've not implemented the journaling mechanism but there is no need to change the disk format for that later. There are 9 patches and I modified only 7th patch (Zumastor shared snapshot code) since the last submission. IOW, I have not change the way to refactor the existing code. I'll think about how to integrate

[RFC][PATCH 1/4] dm-log: fix io_client_destroy leak

Takahiro Yasui — 2008-11-26T00:01:37

In create_log_context function, dm_io_client_destroy function needs to be called, when memory allocation of disk_header, sync_bits and recovering_bits failed, but dm_io_client_destroy is not called. This patch fixes it. Signed-off-by: Takahiro Yasui redhat.com> --- drivers/md/dm-log.c | 5 +++++ 1 file changed, 5 insertions(+) Index: linux-2.6.28-rc4/drivers/md/dm-log.c =================================================================== --- linux-2.6.28-rc4.orig/drivers/md/dm-log.c +++ linux-2.6.28-rc4/drivers/md/dm-log.c < at >< at > -467,6 +467,7 < at >< at > static int create_log_context(struct dm_ lc->disk_header = vmalloc(buf_size); if (!lc->disk_header) { DMWARN("couldn't allocate disk log buffer"); +dm_io_client_destroy(lc->io_req.client); kfree(lc); return -ENOMEM; } < at >< at > -483,6 +484,8 < at >< at > static int create_log_context(struct dm_ if (!dev) vfree(lc->clean_bits); vfree(lc->disk_header); +if (dev) +dm_io_client_destroy(lc->io_req.client); kfree(lc); return -ENOMEM;

[RFC][PATCH 3/4] dm-log: support multiple log devices

Takahiro Yasui — 2008-11-26T00:01:41

This patch introduces multiple log devices feature. * "log" member is added into log context to keep a device status and device info. * read_headers function reads log data from each log devices and check if they contain the same header values. * write_headers issues write I/O to all active log devices at the same time and check each result when all I/Os complete. * add parse_params to search "region size" in the parameter list. Signed-off-by: Takahiro Yasui redhat.com> --- drivers/md/dm-log.c | 579 +++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 416 insertions(+), 163 deletions(-) Index: linux-2.6.28-rc4/drivers/md/dm-log.c =================================================================== --- linux-2.6.28-rc4.orig/drivers/md/dm-log.c +++ linux-2.6.28-rc4/drivers/md/dm-log.c < at >< at > -249,6 +249,15 < at >< at > struct log_header { sector_t nr_regions; }; +struct log { +struct log_c *lc; +int failed; + +struct dm_dev *dev; +struct log_header header; +struct dm_i

[RFC][PATCH 4/4] dm-log: interface update for multiplelog devices

Takahiro Yasui — 2008-11-26T00:01:43

This patch introduces a new interface for multi-log devices. disk log has two interfaces, constructor and status, and disk_ctr function and disk_status functions are extended to handle multiple log device paths. - Current interface disk_ctr(): log_path region_size [[no]sync] disk_status() - STATUSTYPE_INFO: nr_params disk log_path log_status:"A" or "D" disk_status() - STATUSTYPE_TABLE: disk nr_params log_path region_size [[no]sync] - Proposed interface disk_ctr(): [log_path]{1,} region_size [[no]sync] disk_status() - STATUSTYPE_INFO: nr_params disk [log_path]{1,} [log_status:"A" or "D"]{1,} disk_status() - STATUSTYPE_TABLE: disk nr_params [log_path]{1,} region_size [[no]sync] Signed-off-by: Takahiro Yasui redhat.com> --- drivers/md/dm-log.c | 75 ++++++++++++++++++++++++++++++++++++++------------ drivers/md/dm-raid1.c | 2 - 2 files changed, 59 insertions(+), 18 deletions(-) Index: linux-2.6.28-rc4/drivers/m

[RFC][PATCH 2/4] dm-log: unify rw_header toread/write_header

Takahiro Yasui — 2008-11-26T00:01:39

rw_header function updates three members of io_req data every time when I/O is processed. bi_rw and notify.fn are never modified once they get initialized, and also they can be set in advance. This patch removes unnecessary update operations. Signed-off-by: Takahiro Yasui redhat.com> --- drivers/md/dm-log.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) Index: linux-2.6.28-rc4/drivers/md/dm-log.c =================================================================== --- linux-2.6.28-rc4.orig/drivers/md/dm-log.c +++ linux-2.6.28-rc4/drivers/md/dm-log.c < at >< at > -323,20 +323,13 < at >< at > static void header_from_disk(struct log_ core->nr_regions = le64_to_cpu(disk->nr_regions); } -static int rw_header(struct log_c *lc, int rw) -{ -lc->io_req.bi_rw = rw; -lc->io_req.mem.ptr.vma = lc->disk_header; -lc->io_req.notify.fn = NULL; - -return dm_io(&lc->io_req, 1, &lc->header_location, NULL); -} - static int read_header(struct log_c *log) { int r; -r = rw_header(log, READ)

[RFC][PATCH 0/4] dm-log: support multi-log devices

Takahiro Yasui — 2008-11-26T00:01:35

Hi All, This is my first post to this mailing list, but let me introduce a patch set to implement multi-log devices for dm-mirror. I appreciate your kind comments and suggestions on this patch set. PATCH SET ========= 1/4: dm-log: fix no io_client_destroy 2/4: dm-log: remove unnecessary updates of io_req members 3/4: dm-log: introduce multi-log devices 4/4: dm-log: update interface to control multi-log devices BACKGROUND ========== device mapper mirroring (dm-mirror) uses "log" to keep status of consistency among mirror devices. There are two types of log, "core" and "disk". The former keep its data only on memory, and the latter can keep data on a device. When system starts booting and setup disks managed by device mapper, device mapper checks log data if each region is in sync state among mirror devices. And if not, it executes data replication from default-mirror device to others. However, once log disk breaks down, data replications are required for a whole data disks, and if a size of dat

[PATCH] Read the verbosity level from multipath.confconfiguration file

Ritesh Raj Sarraf — 2008-11-21T10:54:30

With this patch, multipathd can read the verbosity level from the multipath.conf configuration file. For example: verbosity 5 Signed-off-by: Ritesh Raj Sarraf netapp.com> --- libmultipath/config.c | 2 +- libmultipath/defaults.h | 1 + libmultipath/dict.c | 20 ++++++++++++++++++++ multipath/multipath.conf.5 | 5 +++++ 4 files changed, 27 insertions(+), 1 deletions(-) diff --git a/libmultipath/config.c b/libmultipath/config.c index 6d731d2..b49cc90 100644 --- a/libmultipath/config.c +++ b/libmultipath/config.c < at >< at > -420,7 +420,7 < at >< at > load_config (char * file) * internal defaults */ if (!conf->verbosity) -conf->verbosity = 2; +conf->verbosity = DEFAULT_VERBOSITY; conf->dev_type = DEV_NONE; conf->minio = 1000; diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h index 87b155e..a943673 100644 --- a/libmultipath/defaults.h +++ b/libmultipath/defaults.h < at >< at > -11,6 +11,7 < at >< at > #define DEFAULT_NO_PATH_RETRY NO_PATH_RETRY_UNDEF #define DEFAULT_PGTIMEO

[PATCH] Read the verbosity level from multipath.confconfiguration file

2008-11-20T12:41:15

From: Ritesh Raj Sarraf researchut.com> With this patch, multipathd can read the verbosity level from the multipath.conf configuration file. For example: verbosity 5 Signed-off-by: Ritesh Raj Sarraf researchut.com> --- libmultipath/config.c | 2 +- libmultipath/defaults.h | 1 + libmultipath/dict.c | 20 ++++++++++++++++++++ multipath/multipath.conf.5 | 5 +++++ 4 files changed, 27 insertions(+), 1 deletions(-) diff --git a/libmultipath/config.c b/libmultipath/config.c index 6d731d2..b49cc90 100644 --- a/libmultipath/config.c +++ b/libmultipath/config.c < at >< at > -420,7 +420,7 < at >< at > load_config (char * file) * internal defaults */ if (!conf->verbosity) -conf->verbosity = 2; +conf->verbosity = DEFAULT_VERBOSITY; conf->dev_type = DEV_NONE; conf->minio = 1000; diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h index 87b155e..a943673 100644 --- a/libmultipath/defaults.h +++ b/libmultipath/defaults.h < at >< at > -11,6 +11,7 < at >< at > #define DEFAULT_NO_PATH_RETRY

[PATCH] Change occurences of netapp to ontap.

Ritesh Raj Sarraf — 2008-11-20T09:59:16

From: Ritesh Raj Sarraf researchut.com> Change all occurences of netapp to ontap to be consistent. This was proposed earlier, before the libprio change, but was deferred for compatibility reasons. Also update maintainers. --- libmultipath/prioritizers/netapp.c | 243 ------------------------------------ libmultipath/prioritizers/netapp.h | 7 - libmultipath/prioritizers/ontap.c | 243 ++++++++++++++++++++++++++++++++++++ libmultipath/prioritizers/ontap.h | 7 + 4 files changed, 250 insertions(+), 250 deletions(-) delete mode 100644 libmultipath/prioritizers/netapp.c delete mode 100644 libmultipath/prioritizers/netapp.h create mode 100644 libmultipath/prioritizers/ontap.c create mode 100644 libmultipath/prioritizers/ontap.h diff --git a/libmultipath/prioritizers/netapp.c b/libmultipath/prioritizers/netapp.c deleted file mode 100644 index 812ecf6..0000000 --- a/libmultipath/prioritizers/netapp.c +++ /dev/null < at >< at > -1,243 +0,0 < at >< at > -/* - * Copyright 2005 Network Appliance, Inc., All Rights R

[Patch 2 of 2]: Cluster-aware dirty log - log module

Jonathan Brassow — 2008-11-14T17:44:27

Please note that I have not yet tested this module (outside of compiling) with the latest kernel. The only concern I have is with the newly refactored region hash code. I'll probably get to testing this next week. brassow This patch contains a cluster-aware log module. When used by dm-raid1, device-mapper mirroring can be cluster-aware. There is a kernel component (provided in this patch) and a user space component. The kernel component implements the logging interface and passes all requests to userspace via 'connector' (a netlink wrapper). The userspace daemon is built upon OpenAIS for cluster communication and is fault tolerant. The logging interface code (found in dm-clog.c) is fairly simple and should be close to completion. I would really enjoy feedback on: 1) Connector code (found in dm-clog-tfr.c) 2) Suggestions on possible break-ups of dm-clog-tfr.h, since some of that code is meant to be used by both userspace and kernel space, and some is meant only for kernel space... (I thin

[Patch 1 of 2]: Cluster-aware dirty log - Log APIaddition

Jonathan Brassow — 2008-11-14T17:44:21

This patch can be considered by itself. The second patch I am sending will be the actual cluster log module, but these 2 patches don't necessarily need to go together. brassow The logging API needs an extra function to make cluster mirroring possible. This new function allows us to check whether a mirror region is being recovered on another machine in the cluster. This helps us prevent simultaneous recovery I/O and process I/O to the same locations on disk. Cluster-aware log modules will implement this function. Single machine log modules will not. So, there is no performance penalty for single machine mirrors. Signed-off-by: Jonathan Brassow redhat.com> Index: linux-2.6/drivers/md/dm-raid1.c =================================================================== --- linux-2.6.orig/drivers/md/dm-raid1.c +++ linux-2.6/drivers/md/dm-raid1.c < at >< at > -588,6 +588,9 < at >< at > static void do_writes(struct mirror_set int state; struct bio *bio; struct bio_list sync, nosync, recover, *this_list = NULL; +

[PATCHES] new solution for dm_any_congested crash

Mikulas Patocka — 2008-11-14T01:55:27

Hi The Chandra's patch was correct, but the problem is more serious (the same crash could happen in dm_merge_bvec, dm_unplug_all or at some other dm places), so I had to rework reference counting. These are three patches. 1. reverts Chadra's changes 2. just a little swap of two calls, to prepare for the third 3. the reference counting rework Chandra, please test the patches at your system (without your original patch) and verify that they avoid the crashes as well as your patch does. MikulasRevert dm-avoid-destroying-table-in-dm_any_congested.patch The patch is correct, however the problem is more serious. The same lazy destructor calls can happen in dm_merge_bvec, dm_unplug_all and in many other device mapper places. So, a more generalized solution needs to be developed. Signed-off-by: Mikulas Patocka redhat.com> --- drivers/md/dm.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) Index: linux-2.6.28-rc4-devel/drivers/md/dm.c ===========

[git pull] 2.6.28-rc5 device-mapper fixes

Alasdair G Kergon — 2008-11-13T23:49:33

Please pull the following device-mapper fixes from: master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git Chandra Seetharaman (3): dm mpath: avoid attempting to activate null path dm mpath: warn if args ignored dm: avoid destroying table in dm_any_congested Heinz Mauelshagen (1): dm stripe: fix init failure Mikulas Patocka (2): dm raid1: flush workqueue before destruction dm: move pending queue wake_up end_io_acct drivers/md/dm-mpath.c | 8 ++++++-- drivers/md/dm-raid1.c | 1 + drivers/md/dm-stripe.c | 4 +++- drivers/md/dm.c | 34 +++++++++++++++++++++------------- 4 files changed, 31 insertions(+), 16 deletions(-) Thanks, Alasdair

[PATCH 5 of 5] dm-exception-store API

Jonathan Brassow — 2008-11-13T10:12:45

brassow I took the liberty of refactoring the shared exception store code. It now aligns nicely with the interface instead of altering all sorts of things that it should not have been. 'message' interface is gone, no need to pass around snapid's, it's now a module, etc... I didn't spend huge amounts of time on this. It compiles, but there are probably some bugs there now. I would also like to see a 'UUID -> snapid' translation added to the code. This would eliminate the need to go around asking which indices are open for use. The translation table could be stored in the on-disk header. get_[shared|unique]_info functions need to be macros... function args should be cleaned up... etc. - brassow Index: linux-2.6/drivers/md/Kconfig =================================================================== --- linux-2.6.orig/drivers/md/Kconfig +++ linux-2.6/drivers/md/Kconfig < at >< at > -249,6 +249,14 < at >< at > config DM_SNAPSHOT ---help--- Allow volume managers to take writable snapshots of a device. +

[PATCH 4 of 5] dm-exception-store API

Jonathan Brassow — 2008-11-13T10:12:39

brassow After twiddling with phillips/tomonori's shared snapshot, I believe the addition of the 'lookup_completed_exception' function to the exception store API will be useful. If I understand correctly, it allows us to defer populating a snapshot's exception cache up front. Instead allowing us to look them up as necessary. This is nice, because when the exception store is shared, we don't want 60 copies of all the exceptions for each snapshot structure. We just want one copy in the exceptions store that we can lookup. - brassow Index: linux-2.6/drivers/md/dm-exception-store.h =================================================================== --- linux-2.6.orig/drivers/md/dm-exception-store.h +++ linux-2.6/drivers/md/dm-exception-store.h < at >< at > -78,6 +78,18 < at >< at > struct dm_exception_store_type { void *callback_context); /* + * An exception store implementation can forgo using the + * callbacks provided to read_metadata, which would populate + * all exception data upfront. Instead, it can cho

[PATCH 3 of 5] dm-exception-store API

Jonathan Brassow — 2008-11-13T10:12:35

brassow This patch completes the clean break we wanted between snapshots and exception stores. Now it is possible to create exception store modules and be able to use them without having to alter the snapshot code. There are currently two types of exception stores, but more have been proposed - including a 'shared' exception store. Additionally, the constructor table has been enhanced to allow more flexibility in the arguments passed to the exception stores, as well as providing an easy path to further expand options in the future. This was done while maintaining backwards compatibility. Signed-off-by: Jonathan Brassow redhat.com> Index: linux-2.6/drivers/md/dm-exception-store.h =================================================================== --- linux-2.6.orig/drivers/md/dm-exception-store.h +++ linux-2.6/drivers/md/dm-exception-store.h < at >< at > -10,6 +10,7 < at >< at > #define _LINUX_DM_EXCEPTION_STORE #include +#include /* * The snapshot code deals wi

[PATCH 2 of 5] dm-exception-store API

Jonathan Brassow — 2008-11-13T10:12:29

brassow If the exception store API ever becomes as popular as the dm-dirty-log.h API, then we should make the name of the exception store structure a little more official. s/exception_store/dm_exception_store/ Signed-off-by: Jonathan Brassow redhat.com> Index: linux-2.6/drivers/md/dm-exception-store.c =================================================================== --- linux-2.6.orig/drivers/md/dm-exception-store.c +++ linux-2.6/drivers/md/dm-exception-store.c < at >< at > -462,19 +462,19 < at >< at > static int read_exceptions(struct pstore return 0; } -static struct pstore *get_info(struct exception_store *store) +static struct pstore *get_info(struct dm_exception_store *store) { return (struct pstore *) store->context; } -static void persistent_fraction_full(struct exception_store *store, +static void persistent_fraction_full(struct dm_exception_store *store, sector_t *numerator, sector_t *denominator) { *numerator = get_info(store)->next_free * store->snap->chunk_size; *denominato

[PATCH 1 of 5] dm-exception-store API

Jonathan Brassow — 2008-11-13T10:12:22

brassow Creation of dm-exception-store.h Pull structures that bridge the gap between snapshot and exception store out of dm-snap.h and put them in a new .h file - dm-exception-store.h. This file will define the API for new exception stores. Ultimately, dm-snap.h is unnecessary, since only dm-snap.c should be using it. Signed-off-by: Jonathan Brassow redhat.com> Index: linux-2.6/drivers/md/dm-exception-store.c =================================================================== --- linux-2.6.orig/drivers/md/dm-exception-store.c +++ linux-2.6/drivers/md/dm-exception-store.c < at >< at > -7,6 +7,7 < at >< at > * This file is released under the GPL. */ +#include "dm-exception-store.h" #include "dm-snap.h" #include Index: linux-2.6/drivers/md/dm-exception-store.h =================================================================== --- /dev/null +++ linux-2.6/drivers/md/dm-exception-store.h < at >< at > -0,0 +1,131 < at >< at > +/* + * Copyright (C) 2008 Red Hat, Inc. All rights reserved. + * + * Device-mapper exce

[PATCH 0 of 5] dm-exception-store API

Jonathan Brassow — 2008-11-13T10:12:13

I think the API patches are ready for serious review. The API patches are the first 3 of 5 that I will be sending. The last 2 concern the refactoring of the "dm snapshot: shared exception store" patches. I left these in a somewhat rough state, and they will need more work. However, I hope it shows that we can create a clean exception store API and adhere to it - even with the more exotic exception stores. brassow