gmane.comp.window-managers.fvwm.devel

CVS tadam: Fix compilation problems.

2012-05-04T13:18:09

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/05/04 08:18:09

Modified files:
.              : Tag: branch-2_6 ChangeLog 
libs           : Tag: branch-2_6 PictureImageLoader.c 

Log message:
Fix compilation problems.

Print to stderr instead.

CVS tadam: Improve image loading messages.

2012-05-02T08:02:44

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/05/02 03:02:44

Modified files:
.              : Tag: branch-2_6 ChangeLog 
fvwm           : Tag: branch-2_6 menus.c 
libs           : Tag: branch-2_6 PictureImageLoader.c 

Log message:
Improve image loading messages.

Give hints to the user why an image couldn't be loaded.

CVS tadam fvwm-web: Updated for 2.6.5

2012-04-20T11:21:52

CVSROOT:/home/cvs/fvwm
Module name:fvwm-web
Changes by:tadam12/04/20 06:21:52

Modified files:
.              : ChangeLog definitions.inc 
documentation/manpages/stable: FvwmAnimate.php FvwmAuto.php 
                               FvwmBacker.php FvwmBanner.php 
                               FvwmButtons.php FvwmCommand.php 
                               FvwmConsole.php 
                               FvwmConsoleC.pl.php FvwmCpp.php 
                               FvwmDebug.php FvwmDragWell.php 
                               FvwmEvent.php FvwmForm.php 
                               FvwmGtk.php FvwmGtkDebug.php 
                               FvwmIconBox.php FvwmIconMan.php 
                               FvwmIdent.php FvwmM4.php 
                               FvwmPager.php FvwmPerl.php 
                               FvwmProxy.php FvwmRearrange.php 
                               FvwmSave.php FvwmSaveDesk.php 
                               FvwmScript.php FvwmScroll.php

FVWM 2.6.5 released -- tarballs in pub/incoming on FTP site.

Thomas Adam — 2012-04-20T11:14:57

Jason,

I've released FVWM 2.6.5 -- tarballs in the usual place.

Kindly,

CVS tadam: 2.6.6 (CVS HEAD) changes.

2012-04-20T11:14:00

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/04/20 06:14:00

Modified files:
.              : Tag: branch-2_6 NEWS ChangeLog configure.ac 

Log message:
2.6.6 (CVS HEAD) changes.

CVS tadam: Update key files in prep for 2.6.5 release.

2012-04-20T11:03:33

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/04/20 06:03:33

Modified files:
.              : Tag: branch-2_6 ChangeLog NEWS configure.ac 
docs           : Tag: branch-2_6 ANNOUNCE 

Log message:
Update key files in prep for 2.6.5 release.

CVS tadam: Wrap window titles in FvwmPager

2012-04-14T09:46:38

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/04/14 04:46:38

Modified files:
.              : Tag: branch-2_6 NEWS 
modules        : Tag: branch-2_6 ChangeLog 
modules/FvwmPager: Tag: branch-2_6 x_pager.c 

Log message:
Wrap window titles in FvwmPager

Patch largely by Anton Khirno.  Tweaked by tadam< at >

CVS tadam: Fix memory leak with InfoStore

2012-04-14T09:40:45

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/04/14 04:40:45

Modified files:
modules        : Tag: branch-2_6 ChangeLog 

Log message:
Fix memory leak with InfoStore

CVS tadam: Fix memory leak with InfoStore

2012-04-14T09:34:33

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/04/14 04:34:33

Modified files:
fvwm           : Tag: branch-2_6 infostore.c 

Log message:
Fix memory leak with InfoStore

[PATCH] Fix segfault and memory issues in infostore.c

2012-04-14T07:32:43

Hi, fvwm-workers; long time no see! GNOME 3 / Unity have ended my
4-year fling and sent me crawling back; I always come back to fvwm, in
the end :)

I found a segfault when polishing up and modernizing my config, and
then found a few much more minor memory issues.

The first patch should be non-controversial; the only reason it works
at all in some cases is that the mi_store is NULL after the memset
(and also writing zeros over some other random memory), and
mi_new->next becomes NULL on the first item being stored.

Author: epg <epg< at >pretzelnet.org>
Date:   Fri Apr 13 22:06:51 2012 -0700

    Fix segfault in new_metainfo:

    Need to memset the newly allocated block of memory at the address held in
    mi_store, not the stack memory holding that address.

The second fixes various memory leaks I found; the latest one is only
an issue after the above fix (as mi_store is now pointing to a dead
object during initialization rather than a NULL pointer).

commit a297778dede814070ddbba7da8ab7d992fddcc9e
Author: epg

FVWM Patch for Interaction problem with Java 7

Schaaf, Jonathan P (GE Healthcare — 2012-04-11T22:23:23

Greetings,

I've spent the past few days hunting down a bug that involves an
interaction between FVWM and Java 7.

I can provide more detail for anyone who is curious, but here are the
key points:

a)    Java version 7 creates a special "FocusProxy" window to get
keyboard input.  See
 
http://www.docjar.com/html/api/sun/awt/X11/XFocusProxyWindow.java.html 

b)    frame.c contains a work around and a comment that begins with  the
fated phrase "For some reason".  
      It seems like there was a bug in a ~1999 X server that doesn't
exist in 2012 era Xorg.

c)    The code in frame.c takes focus away from java's "Focus Proxy"
window and gives it to a java window 
      that doesn't know what to do with keyboard input.

I'm including a proposed patch (very simple - comment out the hack from
1999) as well as java code that can be used to reproduce the issue.

Let me know if you have any thoughts.

Thanks and best regards,

Jonathan


=====================================================

diff -urNp fvwm-2.6.4/fvwm

[PATCH 1/2] Flocale: fix counting UTF-8 bytes.

Anton Khirnov — 2012-04-04T15:18:00

Current check is broken for 2-byte characters due to str[0] getting
sign-extended.

Also support 4-byte characters.
---
 libs/Flocale.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/libs/Flocale.c b/libs/Flocale.c
index 058dc49..9ec9a3f 100644
--- a/libs/Flocale.c
+++ b/libs/Flocale.c
< at >< at > -205,14 +205,13 < at >< at > int FlocaleStringNumberOfBytes(FlocaleFont *flf, const char *str)
         {
         bytes = 1;
         }
-else if((str[0] & ~0xdf) == 0)
-{
-        bytes = 2;
-}
 else
 {
-        /* this handles only 16-bit Unicode */
-        bytes = 3;
+switch (str[0] & 0xf0) {
+case 0xc0: bytes = 2; break;
+case 0xe0: bytes = 3; break;
+default:   bytes = 4;
+}
 }
 }
 else if(flf->flags.is_mb)

CVS tadam: Handle deleted windows properly in FvwmButtons.

2012-03-26T10:17:54

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/03/26 05:17:54

Modified files:
.              : Tag: branch-2_6 NEWS 
modules        : Tag: branch-2_6 ChangeLog 
modules/FvwmButtons: Tag: branch-2_6 FvwmButtons.c 

Log message:
Handle deleted windows properly in FvwmButtons.

Bug report - FvwmButtons, stalonetray and DestroyNotify events

Robert Parlett — 2012-03-21T22:06:34

Configuration Information [Automatically generated, do not change]:
uname: Linux vega.poges 2.6.31-21-generic-pae #59-Ubuntu SMP Wed Mar 24
08:47:55 UTC 2010 i686 GNU/Linux
compiler flags: gcc -Wall -Wno-implicit-int -g -O2

FVWM Version:    2.6.4
FVWM_MODULEDIR:    /usr/local/libexec/fvwm/2.6.4
FVWM_DATADIR:    /usr/local/share/fvwm
FVWM_USERDIR:    /home/rparlett/.fvwm

Description:

FvwmButtons is causing problems with swallowed programs because it is
misinterpreting DestroyNotify messages, wrongly concluding that the
swallowed window has been destroyed (when in fact only a child of the
swallowed window has been destroyed).  This causes particular problems
with stalonetray, since the tray icons are children of the swallowed
window, and are destroyed as a matter of course in normal operation
when a tray application exits.

The problem is the following piece of code in FvwmButtons.c :-

   1455       case DestroyNotify:
   1456         ub = UberButton;button = -1;
   1457         while (NextButton(&ub, &b,

CVS tadam: Fix XSizeHints problem with FVWM not correctly allowing resizing of

2012-03-17T23:52:53

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/03/17 18:52:53

Modified files:
.              : Tag: branch-2_6 ChangeLog 
fvwm           : Tag: branch-2_6 events.c 

Log message:
Fix XSizeHints problem with FVWM not correctly allowing resizing of
windows when the hints are toggled with respect to FVWM processing
XA_WM_NORMAL_HINTS.  Noticed by R. Parlett.

Bug report - problem with window dynamically changing its resizability

Robert Parlett — 2012-03-17T23:29:38

Configuration Information [Automatically generated, do not change]:
uname: Linux vega.poges 2.6.31-21-generic-pae #59-Ubuntu SMP Wed Mar 24
08:47:55 UTC 2010 i686 GNU/Linux
compiler flags: gcc -Wall -Wno-implicit-int -g -O2

FVWM Version:    2.6.4
FVWM_MODULEDIR:    /usr/local/libexec/fvwm/2.6.4
FVWM_DATADIR:    /usr/local/share/fvwm
FVWM_USERDIR:    /home/rparlett/.fvwm

Description:

This is a very minor bug.

The problem can best be seen by running the attached program.  Compile
with

gcc -lX11 fvwm-hints-problem.c

The window of this program accepts three keyboard inputs, namely
   'q' to quit
   'y' to allow resizability (by setting XSizeHints), and
   'n' to disallow resizability (also by setting XSizeHints)

To observe the bug, proceed as follows.
   1) Start the program.  The window is initially resizable.
   2) Press 'n' to disable resizability.  Note at this point that if
      you have a fvwm "Resize" menu item on your window menu, it is
      not greyed out, which it should be.
   3) Try to resiz

CVS tadam: Honour EWMH working area for "PositionPlacement UnderMouse" by default

2012-03-16T08:36:17

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/03/16 03:36:17

Modified files:
.              : Tag: branch-2_6 ChangeLog NEWS 
fvwm           : Tag: branch-2_6 placement.c 

Log message:
Honour EWMH working area for "PositionPlacement UnderMouse" by default

When the EWMH working area is in use, and a window is asked to place itself
under the cursor, force it on-screen by taking in to account the working
area if it's in use.

fvwm html pages with asciidoc

Thomas Funk — 2012-03-13T12:25:48

Hi Thomas,

I've played around with the asciidoc manpages to include them into fvwm 
html
pages (interesting for fvwm-web).

Atached is a working example which uses two asciidoc manpages (FvwmForm and
FvwmTheme) inside the actual Fvwm page.

It is based on the asciidoc webpage example. On Debian you'll find it under
/usr/share/doc/asciidoc/examples/website/


Used componnents:
- layout_fvwm.conf to build the manpage inside a fvwm page

- build-website.sh
     create the html pages

- manpage.css -
     stylesheet for the manpage formating. It is very poor at the
     moment, and need some changes to fit the fvwm look. But that's no 
prob, cause
     if you create a standalone asciidoc html page with

     "asciidoc -f manpage <manpage.txt>"

     the complete formating will be found at the beginning of the page.

- style.css
     the original fvwm style sheet

I've put two links for testing in FvwmForm:
-> external link: FvwmTheme - in "*FvwmForm: Colorset n"
-> internal link: DEFAULTS - in "*FvwmForm: Back

fvwm for Fedora

Ranjan Maitra — 2012-03-13T04:18:14

Hi,

I have been looking at the fvwm RPM for fedora and i noticed that the
following patches are in there:

fvwm-0005-Explicitly-link-against-fontconfig.patch
fvwm-2.5.21-menu-generate.patch
fvwm-2.5.30-mimeopen.patch
fvwm-2.5.30-more-mouse-buttons.patch
fvwm-2.5.30-xdg-open.patch

There is also the following:
fvwm-xdg-menu.py

From looking at the archives, it is not clear to me if the last one
should be included/excluded? Are any of the above no longer necessary
for fvwm-2.6.4?

Separately, I also was wondering: do any of these patches conflict with
the following more commonly used patches (for Gentoo/ArchLinux)?

01-TranslucentMenus.patch    11-MultiBorder.patch
02-ColourBorders.patch       12-FvwmButtonsTips.patch
03-ResizeOutlineThin.patch   13-FvwmIconMan.patch
04-Conditionals.patch        14-Hover.patch
05-FlatSeparators.patch      15-FirstItemUnderPointer.patch
06-BorderUnderTitle.patch    16-ThinGeometryProxy.patch
07-InactiveFont.patch        
08-FluxRoundedCorners.patch  
09-TopBorder.patch

FvwmRearrange bug if Style TitleAtLeft/TitleAtRight is used

Tiziano Zito — 2012-02-27T17:34:14

Hi FVWM developers,

first of all thank you for maintaining my window manager :)

I recently switched all my windows to a style where the title is on
the left using the TitleAtLeft style. 

The FvwmRearrange module, when used with the -tile option, is not
able to cope with this and windows are tiled such that the right
most ones fall out of the screen.

The reason is that FvwmRearrange assumes the title to be always
either on top or on the bottom of windows. Looking in
FvwmRearrange.c (FVWM version 2.6.4) within the tile_window function

305     int nw = wdiv - w->bw * 2;
306     int nh = hdiv - w->bw * 2 - w->th;
339     int nw = wdiv - w->bw * 2;
340     int nh = hdiv - w->bw * 2 - w->th;

you see that the new width of the window is calculated removing
twice the border width, whereas the height gets the title height
removed too. 

In order to solve my particular problem I simply patched those lines
to be

305     int nw = wdiv - w->bw * 2 - w->th;
306     int nh = hdiv - w->bw * 2;
339     int nw = wdiv -

CVS tadam: Don't block signals.

2012-02-20T01:03:54

CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by:tadam12/02/19 19:03:54

Modified files:
.              : Tag: branch-2_6 ChangeLog NEWS 
fvwm           : Tag: branch-2_6 fvwm.c 

Log message:
Don't block signals.

Unblock signals registered so as not to queue them up with repeated events.