gmane.comp.video.libav.devel

[PATCH] configure: Remove unneeded icl inlinecompatibility definition

Alex Smith — 2013-06-19T00:39:47

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 93a9b30..543763f 100755
--- a/configure
+++ b/configure
< at >< at > -2625,7 +2625,7 < at >< at > probe_cc(){
         # -Qdiag-error to make icl error when presented with certain unknown arguments
         _flags='-nologo -Qdiag-error:4044,10157'
         # -Qvec- -Qsimd- to prevent miscompilation, -GS for consistency with msvc which enables it by default
-        _cflags='-D_USE_MATH_DEFINES -Dinline=__inline -FIstdlib.h -Dstrtoll=_strtoi64 -Qms0 -Qvec- -Qsimd- -GS'
+        _cflags='-D_USE_MATH_DEFINES -FIstdlib.h -Dstrtoll=_strtoi64 -Qms0 -Qvec- -Qsimd- -GS'
         if [ $pfx = hostcc ]; then
             append _cflags -Dsnprintf=_snprintf
         fi

[PATCH] lavc: free the padded last frame during audioencoding properly

Anton Khirnov — 2013-06-18T09:51:24

---
 libavcodec/utils.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 3dddafc..ee0b571 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
< at >< at > -1245,12 +1245,7 < at >< at > int attribute_align_arg avcodec_encode_audio2(AVCodecContext *avctx,
     avpkt->flags |= AV_PKT_FLAG_KEY;
 
 end:
-    if (padded_frame) {
-        av_freep(&padded_frame->data[0]);
-        if (padded_frame->extended_data != padded_frame->data)
-            av_freep(&padded_frame->extended_data);
-        av_freep(&padded_frame);
-    }
+    av_frame_free(&padded_frame);
 
     return ret;
 }

[PATCH] lavc doxy: document thatavcodec_flush_buffers() invalidates decoded frames

Anton Khirnov — 2013-06-18T09:38:25

---
 libavcodec/avcodec.h |   16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index bb33d4a..2b043df 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
< at >< at > -3318,8 +3318,8 < at >< at > void avcodec_align_dimensions2(AVCodecContext *s, int *width, int *height,
  *                   to the frame if av_frame_is_writable() returns 1.
  *                   When AVCodecContext.refcounted_frames is set to 0, the returned
  *                   reference belongs to the decoder and is valid only until the
- *                   next call to this function or until closing the decoder.
- *                   The caller may not write to it.
+ *                   next call to this function or until closing or flushing the
+ *                   decoder. The caller may not write to it.
  * < at >param[out] got_frame_ptr Zero if no frame could be decoded, otherwise it is
  *                           non-zero.
  * < at >param[in]  avpkt The input AVPacket con

[PATCH 1/6] lavfi: add const to the AVFilterparameter of avfilter_graph_create_filter()

Anton Khirnov — 2013-06-18T09:19:52

This function should never modify the filter.
---
 libavfilter/avfilter.h      |    2 +-
 libavfilter/avfiltergraph.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
index b59e292..b6c9a53 100644
--- a/libavfilter/avfilter.h
+++ b/libavfilter/avfilter.h
< at >< at > -1000,7 +1000,7 < at >< at > int avfilter_graph_add_filter(AVFilterGraph *graphctx, AVFilterContext *filter);
  * < at >return a negative AVERROR error code in case of failure, a non
  * negative value otherwise
  */
-int avfilter_graph_create_filter(AVFilterContext **filt_ctx, AVFilter *filt,
+int avfilter_graph_create_filter(AVFilterContext **filt_ctx, const AVFilter *filt,
                                  const char *name, const char *args, void *opaque,
                                  AVFilterGraph *graph_ctx);
 
diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
index e93a5bb..bfb5838 100644
--- a/libavfilter/avfiltergraph.c
+++ b/libavfilter/avfiltergraph.c
< at >< at > -136,7 +1

[PATCH] lafi: math typo in interlace filter

Vittorio Giovara — 2013-06-17T09:54:26

---
 libavfilter/vf_interlace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_interlace.c b/libavfilter/vf_interlace.c
index d3c3d4d..ff54896 100755
--- a/libavfilter/vf_interlace.c
+++ b/libavfilter/vf_interlace.c
< at >< at > -150,7 +150,7 < at >< at > static void copy_picture_field(AVFrame *src_frame, AVFrame *dst_frame,
                     srcp_below = srcp; // there is no line below
                 for (i = 0; i < linesize; i++) {
                     // this calculation is an integer representation of
-                    // '0.5 * current + 0.25 * above + 0.25 + below'
+                    // '0.5 * current + 0.25 * above + 0.25 * below'
                     // '1 +' is for rounding.
                     dstp[i] = (1 + srcp[i] + srcp[i] + srcp_above[i] + srcp_below[i]) >> 2;
                 }

[PATCH] Announce Release 9.7

Reinhard Tartler — 2013-06-16T20:07:39

---
 src/download | 22 +++++++++++-----------
 src/news     | 21 +++++++++++++++++++++
 2 files changed, 32 insertions(+), 11 deletions(-)

diff --git a/src/download b/src/download
index 98b7411..e31fd83 100644
--- a/src/download
+++ b/src/download
< at >< at > -208,23 +208,23 < at >< at > and much faster bug fixes such as additional features and security patches.
 <a name="release_9"></a><h2>Libav 9 "plain 9"</h2>
 
 <p>
-9.6 was released on 2013-05-12. It is the latest point release from
+9.7 was released on 2013-06-16. It is the latest point release from
 the version 9 release branch, which was released on 2013-01-05. Please
 give us feedback and use our Bugzilla for filing
 bugs: <a href="https://bugzilla.libav.org">https://bugzilla.libav.org/</a>
 </p>
 
 <p>
-<a href="releases/libav-9.6.tar.xz">Download XZ tarball</a>&nbsp;&nbsp;
-<a href="releases/libav-9.6.tar.xz.md5">MD5</a>
-<a href="releases/libav-9.6.tar.xz.sha1">SHA1</a>
-<a href="releases/libav-9.6.tar.xz.asc">PGP signature</a><br />
-<a href="releases/libav-9.6.t

[PATCH 1/5] x86: lpc: simd av_update_lls

Loren Merritt — 2013-06-16T00:53:43

5x-7x faster on sandybridge

FIXME: This adds alignment constraints and changes a struct that used to be
public. External use of LLS is already deprecated, but I guess we can't
actually enable this optimization until the next major version bump.
---
 libavcodec/lpc.c         |   4 +-
 libavutil/lls.c          |  13 +++-
 libavutil/lls.h          |  23 +++++-
 libavutil/x86/Makefile   |   2 +
 libavutil/x86/lls.asm    | 184 +++++++++++++++++++++++++++++++++++++++++++++++
 libavutil/x86/lls_init.c |  36 ++++++++++
 6 files changed, 255 insertions(+), 7 deletions(-)
 create mode 100644 libavutil/x86/lls.asm
 create mode 100644 libavutil/x86/lls_init.c

diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
index bada368..7247a76 100644
--- a/libavcodec/lpc.c
+++ b/libavcodec/lpc.c
< at >< at > -200,7 +200,9 < at >< at > int ff_lpc_calc_coefs(LPCContext *s,
             ref[i] = fabs(lpc[i][i]);
     } else if (lpc_type == FF_LPC_TYPE_CHOLESKY) {
         LLSModel m[2];
-        double var[MAX_LPC_ORDER+1], av_uninit(weight);
+        LO

Pending stuff

Luca Barbato — 2013-06-15T19:24:52

Here the whole bunch, everything should be more or less with an OK

[PATCH] utils: fix avcodec_flush_bufferspre-reference counting compatibility

Rémi Denis-Courmont — 2013-06-15T19:11:55

From: Janne Grunau <janne-libav< at >jannau.net>

The to_free AVframe must be freed just like the other ones. Indeed,
the calling application may expect all frames to be released.
(This regression caused use-after-free in VLC with hwaccel.)

Tested-by: Rémi Denis-Courmont <remi< at >remlab.net>
---
 libavcodec/utils.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index accb6b3..3dddafc 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
< at >< at > -1804,6 +1804,9 < at >< at > void avcodec_flush_buffers(AVCodecContext *avctx)
         ff_thread_flush(avctx);
     else if (avctx->codec->flush)
         avctx->codec->flush(avctx);
+
+    if (!avctx->refcounted_frames)
+        av_frame_unref(&avctx->internal->to_free);
 }
 
 int av_get_exact_bits_per_sample(enum AVCodecID codec_id)

Thin utils.c

Luca Barbato — 2013-06-15T10:12:21

I'm moving some functions out of utils.c since that cage of madness
could be at least 1/4 of it size and all the timestamp guessing could
stay in a timestamp.c stand alone file.

Here the fist set of low hanging fruits.

[PATCH 1/2] bitstream: K&R formatting cosmetics

Luca Barbato — 2013-06-15T08:30:19

---
 libavcodec/bitstream.c | 116 +++++++++++++++++++++++++------------------------
 1 file changed, 60 insertions(+), 56 deletions(-)

diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c
index 2c8692a..4315f1b 100644
--- a/libavcodec/bitstream.c
+++ b/libavcodec/bitstream.c
< at >< at > -44,38 +44,41 < at >< at > const uint8_t ff_log2_run[41]={
 
 void avpriv_align_put_bits(PutBitContext *s)
 {
-    put_bits(s,s->bit_left & 7,0);
+    put_bits(s, s->bit_left & 7, 0);
 }
 
-void avpriv_put_string(PutBitContext *pb, const char *string, int terminate_string)
+void avpriv_put_string(PutBitContext *pb, const char *string,
+                       int terminate_string)
 {
-    while(*string){
+    while (*string) {
         put_bits(pb, 8, *string);
         string++;
     }
-    if(terminate_string)
+    if (terminate_string)
         put_bits(pb, 8, 0);
 }
 
 void avpriv_copy_bits(PutBitContext *pb, const uint8_t *src, int length)
 {
-    int words= length>>4;
-    int bits= length&15;
+    int words = length >> 4;
+    in

h264_mp4toannexb_bsf cleanup

Luca Barbato — 2013-06-15T07:09:54

The padded buffer one might be a candidate for backporting.

[Archive-PATCH] On2 AVC decoder

Kostya Shishkov — 2013-06-14T18:54:41

---
Not sure if it should be really included into our codebase, so I post it
mostly for archival purposes.

I am too lazy (and have better things to do) than to fix this decoder (at
least right now).

Standing issues:
* sometimes frames are not decoded correctly (especially 8 short winodws ones)
* weird 512-sample windows (types 4-6) are not reconstructed properly
---
 Changelog               |    1 +
 configure               |    1 +
 doc/general.texi        |    1 +
 libavcodec/Makefile     |    1 +
 libavcodec/allcodecs.c  |    1 +
 libavcodec/avcodec.h    |    1 +
 libavcodec/codec_desc.c |    7 +
 libavcodec/on2avc.c     |  551 ++++
 libavcodec/on2avcdata.c | 7182 +++++++++++++++++++++++++++++++++++++++++++++++
 libavcodec/on2avcdata.h |   57 +
 libavformat/riff.c      |    2 +
 11 files changed, 7805 insertions(+)
 create mode 100644 libavcodec/on2avc.c
 create mode 100644 libavcodec/on2avcdata.c
 create mode 100644 libavcodec/on2avcdata.h

diff --git a/Changelog b/Changelog
index db2be8d..6315084 1006

[RFC] mem: add av_reallocp

Luca Barbato — 2013-06-14T09:50:54

---

Yet another utility function to be API complete, I'll add the version and
changelog if you like the idea.

 libavutil/mem.c | 16 ++++++++++++++++
 libavutil/mem.h | 13 +++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/libavutil/mem.c b/libavutil/mem.c
index e901533..1e2f914 100644
--- a/libavutil/mem.c
+++ b/libavutil/mem.c
< at >< at > -136,6 +136,22 < at >< at > void *av_realloc(void *ptr, size_t size)
 #endif
 }

+int av_reallocp(void *ptr, size_t size)
+{
+    void **ptrptr = ptr;
+    void *ret;
+
+    ret = av_realloc(*ptrptr, size);
+
+    if (!ret) {
+        av_freep(ptr);
+        return AVERROR(ENOMEM);
+    }
+
+    *ptrptr = ret;
+    return 0;
+}
+
 void *av_realloc_array(void *ptr, size_t nmemb, size_t size)
 {
     if (size <= 0 || nmemb >= INT_MAX / size)
diff --git a/libavutil/mem.h b/libavutil/mem.h
index 8a4fcd9..e71de57 100644
--- a/libavutil/mem.h
+++ b/libavutil/mem.h
< at >< at > -112,6 +112,19 < at >< at > av_alloc_size(1, 2) static inline void *av_malloc_array(size_t nmemb, size_t siz
 void *av_realloc(v

configure and friends?

2013-06-13T16:41:17

Can anyone help? I've modified the msvc sections of configure to produce DLL
files with full debug info (PDB format) when --enable-debug is set, along
with the ability to select statically linked runtimes. Problem is that I
cannot persuade the linker to perform dead code elimination in debug mode so
have built a single .c file containing stubs for functions referenced but
never used. Questions arising are:

 

Is this possible with VS2012?

How do I add the stub file to configure? I tried adding add_compat
msvcrt/dbgfuncs.o but this only seems to get propagated to the makefile for
libavutil, not the others.

If there is interest how do I get this change into GIT?

 

Thanks

BGRA to YUV420P segmentation fault

Arash Shafiei — 2013-06-12T16:08:48

Hello,

I have an application which uses sw_scale API.

int sws_scale(struct SwsContext *c, const uint8_t *const srcSlice[],
               const int srcStride[], int srcSliceY, int srcSliceH,
               uint8_t *const dst[], const int dstStride[]);

The application runs on multiple threads. So the srcSlice passed to 
sw_scale is allocated one thread and used in another thread.

sw_scale is converting from BGRA to YUV420P.

I get a segmentation fault while doing sw_scale.

I debuged it. It turns out that the bug is in the swscale.c file in the 
rgb16_32ToY_c_template function at this line:

         int px = input_pixel(i) >> shp;

input_pixel(i) happens to be a macro which wants to access "src" 
(AV_RN32A(&src[(i)*4])) which has the same address as "srcSlice". The 
debuger says that it is out of bound.

So I get a segmentation fault at this line.

Note that while converting an image from YUV420P to YUV420P the 
application works without any problem.

Do you have a clue what is happening here?

I would a

[PATCH] On2 AVC decoder

Kostya Shishkov — 2013-06-12T18:49:00

---
aka The Most Original Audio Codec in the World

Reconstruction is not perfect but at least it's recognisable (there are some
problems with decoding stereo but it's better than nothing).
Samples are at http://samples.libav.org/V-codecs/VP5/ and
http://samples.libav.org/V-codecs/VP6/ and
http://samples.libav.org/V-codecs/VP7/
---
 Changelog               |    1 +
 doc/general.texi        |    1 +
 libavcodec/Makefile     |    1 +
 libavcodec/allcodecs.c  |    1 +
 libavcodec/avcodec.h    |    1 +
 libavcodec/codec_desc.c |    7 +
 libavcodec/on2avc.c     |  560 ++++
 libavcodec/on2avcdata.c | 7104 +++++++++++++++++++++++++++++++++++++++++++++++
 libavcodec/on2avcdata.h |   47 +
 libavformat/riff.c      |    2 +
 10 files changed, 7725 insertions(+)
 create mode 100644 libavcodec/on2avc.c
 create mode 100644 libavcodec/on2avcdata.c
 create mode 100644 libavcodec/on2avcdata.h

diff --git a/Changelog b/Changelog
index db2be8d..6e40f0a 100644
--- a/Changelog
+++ b/Changelog
< at >< at > -24,6 +24,7 < at >< at > version 10:
 - VC-

[PATCH 1/4] smacker: fix an off by one in huff.lengthcomputation

Luca Barbato — 2013-06-12T13:15:41

From: Kostya Shishkov <kostya.shishkov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>

Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable-LOOeJiBropLYtjvyW6yDsg< at >public.gmane.org

Signed-off-by: Luca Barbato <lu_zero-aBrp7R+bbdUdnm+yROfE0A< at >public.gmane.org>
---
 libavcodec/smacker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index a89cbd3..ca9194f 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
< at >< at > -246,7 +246,7 < at >< at > static int smacker_decode_header_tree(SmackVContext *smk, GetBitContext *gb, int
     ctx.recode2 = tmp2.values;
     ctx.last = last;
 
-    huff.length = ((size + 3) >> 2) + 3;
+    huff.length = ((size + 3) >> 2) + 4;
     huff.maxlength = 0;
     huff.current = 0;
     huff.values = av_mallocz(huff.length * sizeof(int));

[PATCH] g2meet: Fix a typo in the height comparison

Martin Storsjö — 2013-06-12T09:42:23

From: Michael Niedermayer <michaelni-RbZlAiThDcE< at >public.gmane.org>

---
 libavcodec/g2meet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c
index 43888dc..a617df6 100644
--- a/libavcodec/g2meet.c
+++ b/libavcodec/g2meet.c
< at >< at > -440,7 +440,7 < at >< at > static int g2m_init_buffers(G2MContext *c)
 {
     int aligned_height;
 
-    if (!c->framebuf || c->old_width < c->width || c->height < c->height) {
+    if (!c->framebuf || c->old_width < c->width || c->old_height < c->height) {
         c->framebuf_stride = FFALIGN(c->width * 3, 16);
         aligned_height     = FFALIGN(c->height,    16);
         av_free(c->framebuf);

[PATCH 3/3] g2meet: do not leak buffers

Kostya Shishkov — 2013-06-11T17:11:12

---
 libavcodec/g2meet.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c
index 779889e..1cb909e 100644
--- a/libavcodec/g2meet.c
+++ b/libavcodec/g2meet.c
< at >< at > -455,6 +455,8 < at >< at > static int g2m_init_buffers(G2MContext *c)
         aligned_height = FFALIGN(c->tile_height,    16);
         av_free(c->synth_tile);
         av_free(c->jpeg_tile);
+        av_free(c->kempf_buf);
+        av_free(c->kempf_flags);
         c->synth_tile  = av_mallocz(c->tile_stride      * aligned_height);
         c->jpeg_tile   = av_mallocz(c->tile_stride      * aligned_height);
         c->kempf_buf   = av_mallocz((c->tile_width + 1) * aligned_height

[PATCH 2/3] g2meet: more graceful cursor loading

Kostya Shishkov — 2013-06-11T17:10:56

---
 libavcodec/g2meet.c |   70 ++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 52 insertions(+), 18 deletions(-)

diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c
index d0a4302..779889e 100644
--- a/libavcodec/g2meet.c
+++ b/libavcodec/g2meet.c
< at >< at > -468,16 +468,62 < at >< at > static int g2m_init_buffers(G2MContext *c)
     return 0;
 }
 
-static int g2m_load_cursor(G2MContext *c, GetByteContext *gb)
+static int g2m_load_cursor(AVCodecContext *avctx, G2MContext *c,
+                           GetByteContext *gb)
 {
     int i, j, k;
     uint8_t *dst;
     uint32_t bits;
+    uint32_t cur_size, cursor_w, cursor_h, cursor_stride;
+    uint32_t cursor_hot_x, cursor_hot_y;
+    int cursor_fmt;
+    uint8_t *tmp;
 
-    c->cursor_stride = c->cursor_w * 4;
-    c->cursor        = av_realloc(c->cursor, c->cursor_stride * c->cursor_h);
-    if (!c->cursor)
+    cur_size      = bytestream2_get_be32(gb);
+    cursor_w      = bytestream2_get_byte(gb);
+    cursor_h      = bytestream2_get_byte(gb);
+