http://blog.gmane.org/gmane.comp.video.dvdnav.general hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.comp.video.dvdnav.general/579 Author: rathann Date: Sat Aug 30 13:54:03 2008 New Revision: 1121 Log: Rename includedir to $prefix/include/dvdread to remain API-compatible with old upstream. Modified: trunk/libdvdread/configure2 trunk/libdvdread/src/Makefile.am Modified: trunk/libdvdread/configure2 ============================================================================== --- trunk/libdvdread/configure2(original) +++ trunk/libdvdread/configure2Sat Aug 30 13:54:03 2008 < at >< at > -96,7 +96,7 < at >< at > PREFIX=`cd $PREFIX && pwd` test -z "$libdir" && libdir=$PREFIX/lib test -z "$shlibdir" && shlibdir=$PREFIX/lib -test -z "$incdir" && dvdread_incdir=$PREFIX/include/libdvdread +test -z "$incdir" && dvdread_incdir=$PREFIX/include/dvdread targetos=`uname -s` case $targetos in Modified: trunk/libdvdread/src/Makefile.am ============================================================================== --- trunk/libdvdread/src/Makefile.am(original) +++ trunk/libdvdread/src/Makefile.amSat Aug 30 13:54:03 2008 < at >< at > -1,6 +1,6 < at >< at > include $(top_s rathann 2008-08-30T11:54:04 http://comments.gmane.org/gmane.comp.video.dvdnav.general/572 I used libdvdread-0.9.7 in my own project (llink) but since it appears that libdvdread has come to a stand-still, I have moved to use libdvdnav-4.2.1 instead, or rather, the dvdread inside libdvdnav. In future I will explore the additional features of libdvdnav to see what more I can do with it, but for now it was a simple transition. In aid of being backward compatible (so that I could move to using libdvdnav) I applied the 0.9.7 patches for the various *stat() API methods. This is so I can simulate "directory listing" of an ISO file. Patch 1: Add in DVDFileStat and "struct dvd_stat_t" for backward compatibility and maintaining portability. Patch 2: I added a new dvd_input method for calling "unrar". This to allow my program to use libdvdread on .ISO files inside RAR archives. It uses a slightly patched "unrar" executable with a new -sk<offset> flag to specify starting seek position. It takes about two unrar spawns to "list" an ISO file, and on average, 2 unrar spawns to send a .VOB file. (A Jorgen Lundman 2008-08-20T04:12:28 http://comments.gmane.org/gmane.comp.video.dvdnav.general/564 Author: nicodvb Date: Fri Jul 25 08:25:27 2008 New Revision: 1120 Log: removed duplicated #pragma directives and definitions; patch by Erik Hovland Modified: trunk/libdvdread/src/nav_types.h Modified: trunk/libdvdread/src/nav_types.h ============================================================================== --- trunk/libdvdread/src/nav_types.h(original) +++ trunk/libdvdread/src/nav_types.hFri Jul 25 08:25:27 2008 < at >< at > -32,24 +32,6 < at >< at > #include <inttypes.h> #include "ifo_types.h" /* only dvd_time_t, vm_cmd_t and user_ops_t */ - -#undef ATTRIBUTE_PACKED -#undef PRAGMA_PACK_BEGIN -#undef PRAGMA_PACK_END - -#if defined(__GNUC__) -#if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ >= 95) -#define ATTRIBUTE_PACKED __attribute__ ((packed)) -#define PRAGMA_PACK 0 -#endif -#endif - -#if !defined(ATTRIBUTE_PACKED) -#define ATTRIBUTE_PACKED -#define PRAGMA_PACK 1 -#endif - - /* The length including the substream id byte. */ #define PCI_BYTES 0x3d4 #define DSI_BYTES 0x3fa < at >< at > -60,12 +42,6 < at >< at > /* Remove nicodvb 2008-07-25T06:25:27 http://comments.gmane.org/gmane.comp.video.dvdnav.general/562 Author: nicodvb Date: Fri Jul 25 00:03:06 2008 New Revision: 1119 Log: added dvdread_print_time() and removed the file-static print_time() in nav_print.c; based on a patch by Erik Hovland org Modified: trunk/libdvdread/src/ifo_print.c trunk/libdvdread/src/ifo_print.h trunk/libdvdread/src/nav_print.c Modified: trunk/libdvdread/src/ifo_print.c ============================================================================== --- trunk/libdvdread/src/ifo_print.c(original) +++ trunk/libdvdread/src/ifo_print.cFri Jul 25 00:03:06 2008 < at >< at > -60,6 +60,10 < at >< at > static void ifo_print_time(int level, dv printf(" < at > %s fps", rate); } +void dvdread_print_time(dvd_time_t *dtime) { + ifo_print_time(5, dtime); +} + /* Put this in some other file / package? It's used in nav_print too. Possibly also by the vm / navigator. */ static void ifo_print_cmd(int row, vm_cmd_t *command) { < at >< at > -655,7 +659,7 < at >< at > static void ifo_print_CELL_PLAYBACK(cell for(i=0;i<nr;i++) { printf("Cell: %3i ", i + 1); - ifo_p nicodvb 2008-07-24T22:03:06 http://comments.gmane.org/gmane.comp.video.dvdnav.general/559 ifo_print.c and nav_print.c both have a function print_time. That aside from the asserts vs. CHECK_VALUE are exactly the same. There is even a comment about it. So I moved print_time to a new file, dvdread_internal.c and renamed it. Then changed the usage in {ifo,nav}_print.c to that function. E Erik Hovland 2008-07-21T20:41:28 http://comments.gmane.org/gmane.comp.video.dvdnav.general/558 For some reason nav_types.h has exactly the same preprocessor directives that ifo_types.h has and it includes ifo_types.h. This patch removes the duplicates. E Erik Hovland 2008-07-21T20:32:03 http://comments.gmane.org/gmane.comp.video.dvdnav.general/557 While looking through dvd_input.{h,c}, I noticed a few typos. E Erik Hovland 2008-07-21T20:29:31 http://comments.gmane.org/gmane.comp.video.dvdnav.general/556 The function pointer declarations in dvd_input.{h,c} are redundant. This patch puts them only in the header and makes it so extern is not used internally in the C file. E Erik Hovland 2008-07-21T18:45:49 http://comments.gmane.org/gmane.comp.video.dvdnav.general/554 Author: nicodvb Date: Wed Jul 16 09:46:33 2008 New Revision: 1118 Log: moved various pieces of duplicated code to free_ptl_mait(); patch by Erik Hovland org Modified: trunk/libdvdread/src/ifo_read.c Modified: trunk/libdvdread/src/ifo_read.c ============================================================================== --- trunk/libdvdread/src/ifo_read.c(original) +++ trunk/libdvdread/src/ifo_read.cWed Jul 16 09:46:33 2008 < at >< at > -276,6 +276,15 < at >< at > static void read_playback_type(playback_ pt->title_or_time_play = dvdread_getbits(&state, 1); } +static void free_ptl_mait(ptl_mait_t* ptl_mait, int num_entries) { + int i; + for (i = 0; i < num_entries; i++) + free(ptl_mait->countries[i].pf_ptl_mai); + + free(ptl_mait->countries); + free(ptl_mait); +} + ifo_handle_t *ifoOpen(dvd_reader_t *dvd, int title) { ifo_handle_t *ifofile; < at >< at > -1299,21 +1308,13 < at >< at > int ifoRead_PTL_MAIT(ifo_handle_t *ifofi info_length = (ptl_mait->nr_of_vtss + 1) * sizeof(pf_level_t); pf_temp = (uint nicodvb 2008-07-16T07:46:33 http://comments.gmane.org/gmane.comp.video.dvdnav.general/553 This patch removes some duplicate code in ifo_read.c. The code to delete the pmt_maint_t struct is duplicated in a few places. This is in the libdvdread tree. E Erik Hovland 2008-07-15T23:42:26 http://comments.gmane.org/gmane.comp.video.dvdnav.general/551 Author: rathann Date: Sun Jul 13 23:13:40 2008 New Revision: 1117 Log: Merge Dan's autotools pkgconfig support. Added: trunk/libdvdnav/misc/dvdnav.pc.in trunk/libdvdnav/misc/dvdnavmini.pc.in Modified: trunk/libdvdnav/Makefile trunk/libdvdnav/configure.ac trunk/libdvdnav/misc/Makefile.am Modified: trunk/libdvdnav/Makefile ============================================================================== --- trunk/libdvdnav/Makefile(original) +++ trunk/libdvdnav/MakefileSun Jul 13 23:13:40 2008 < at >< at > -40,12 +40,12 < at >< at > BUILDDEPS = Makefile config.mak ifeq ($(BUILD_SHARED),yes) all:$(SHLIB) $(MINI_SHLIB) dvdnav-config -install: $(SHLIB) install-shared install-dvdnav-config install-dvdnav.pc +install: $(SHLIB) install-shared install-dvdnav-config install-pkgconfig endif ifeq ($(BUILD_STATIC),yes) all:$(LIB) dvdnav-config -install: $(LIB) install-static install-dvdnav-config install-dvdnav.pc +install: $(LIB) install-static install-dvdnav-config install-pkgconfig endif install: install- rathann 2008-07-13T21:13:40 http://comments.gmane.org/gmane.comp.video.dvdnav.general/550 Author: rathann Date: Sun Jul 13 23:12:49 2008 New Revision: 1116 Log: Rework dvdread-config handling. --cflags may be empty. Modified: trunk/libdvdnav/configure2 Modified: trunk/libdvdnav/configure2 ============================================================================== --- trunk/libdvdnav/configure2(original) +++ trunk/libdvdnav/configure2Sun Jul 13 23:12:49 2008 < at >< at > -103,13 +103,15 < at >< at > test -z "$libdir" && libdir=$PREFIX/lib test -z "$shlibdir" && shlibdir=$PREFIX/lib test -z "$incdir" && incdir=$PREFIX/include/dvdnav -dvdread_cflags=`$DVDREAD_CONFIG --cflags` -dvdread_libs=`$DVDREAD_CONFIG --libs` -if test -z "$dvdread_cflags" ; then - echo "$DVDREAD_CONFIG --cflags returned an error. Can't proceed" +dvdread=no +$DVDREAD_CONFIG --prefix >> /dev/null 2>&1 && dvdread=yes +test "$dvdread" != "yes" && $DVDREAD_CONFIG --exists >> /dev/null 2>&1 && dvdread=yes +if test "$dvdread" != "yes" ; then + echo "$DVDREAD_CONFIG returned an error. Can't proceed" exit 1 fi - +dvdread_cflags=`$DVDR rathann 2008-07-13T21:12:49 http://comments.gmane.org/gmane.comp.video.dvdnav.general/549 Author: rathann Date: Sun Jul 13 23:11:08 2008 New Revision: 1115 Log: Merge Dan's autotools pkgconfig support. Added: trunk/libdvdread/misc/dvdread.pc.in Modified: trunk/libdvdread/Makefile trunk/libdvdread/configure.ac trunk/libdvdread/misc/Makefile.am Modified: trunk/libdvdread/Makefile ============================================================================== --- trunk/libdvdread/Makefile(original) +++ trunk/libdvdread/MakefileSun Jul 13 23:11:08 2008 < at >< at > -50,12 +50,12 < at >< at > BUILDDEPS = Makefile config.mak ifeq ($(BUILD_SHARED),yes) all:$(SHLIB) $(DVDREAD_SHLIB) dvdread-config -install: $(SHLIB) $(DVDREAD_SHLIB) install-shared install-dvdread-config install-dvdread.pc +install: $(SHLIB) $(DVDREAD_SHLIB) install-shared install-dvdread-config install-pkgconfig endif ifeq ($(BUILD_STATIC),yes) all:$(LIB) $(DVDREAD_LIB) dvdread-config -install: $(LIB) $(DVDREAD_LIB) install-static install-dvdread-config install-dvdread.pc +install: $(LIB) $(DVDREAD_LIB) install-static install-dvd rathann 2008-07-13T21:11:09 http://comments.gmane.org/gmane.comp.video.dvdnav.general/542 Author: rathann Date: Sun Jul 13 21:05:44 2008 New Revision: 1114 Log: pkgconfig support Modified: trunk/libdvdnav/Makefile trunk/libdvdnav/configure2 Modified: trunk/libdvdnav/Makefile ============================================================================== --- trunk/libdvdnav/Makefile(original) +++ trunk/libdvdnav/MakefileSun Jul 13 21:05:44 2008 < at >< at > -40,12 +40,12 < at >< at > BUILDDEPS = Makefile config.mak ifeq ($(BUILD_SHARED),yes) all:$(SHLIB) $(MINI_SHLIB) dvdnav-config -install: $(SHLIB) install-shared install-dvdnav-config +install: $(SHLIB) install-shared install-dvdnav-config install-dvdnav.pc endif ifeq ($(BUILD_STATIC),yes) all:$(LIB) dvdnav-config -install: $(LIB) install-static install-dvdnav-config +install: $(LIB) install-static install-dvdnav-config install-dvdnav.pc endif install: install-headers < at >< at > -140,6 +140,23 < at >< at > install-dvdnav-config: dvdnav-config install -d $(DESTDIR)$(PREFIX)/bin install -m 0755 $(.OBJDIR)/dvdnav-config $(DESTDIR)$(PREFIX)/bin/dvdnav-confi rathann 2008-07-13T19:05:45 http://comments.gmane.org/gmane.comp.video.dvdnav.general/541 Author: rathann Date: Sun Jul 13 21:04:14 2008 New Revision: 1113 Log: pkgconfig support Modified: trunk/libdvdread/Makefile Modified: trunk/libdvdread/Makefile ============================================================================== --- trunk/libdvdread/Makefile(original) +++ trunk/libdvdread/MakefileSun Jul 13 21:04:14 2008 < at >< at > -50,12 +50,12 < at >< at > BUILDDEPS = Makefile config.mak ifeq ($(BUILD_SHARED),yes) all:$(SHLIB) $(DVDREAD_SHLIB) dvdread-config -install: $(SHLIB) $(DVDREAD_SHLIB) install-shared install-dvdread-config +install: $(SHLIB) $(DVDREAD_SHLIB) install-shared install-dvdread-config install-dvdread.pc endif ifeq ($(BUILD_STATIC),yes) all:$(LIB) $(DVDREAD_LIB) dvdread-config -install: $(LIB) $(DVDREAD_LIB) install-static install-dvdread-config +install: $(LIB) $(DVDREAD_LIB) install-static install-dvdread-config install-dvdread.pc endif install: install-headers < at >< at > -146,6 +146,22 < at >< at > install-dvdread-config: dvdread-config install -d $(DESTDIR)$(PREFIX)/bin install -m rathann 2008-07-13T19:04:17 http://comments.gmane.org/gmane.comp.video.dvdnav.general/539 Author: rathann Date: Sun Jul 13 18:52:11 2008 New Revision: 1112 Log: reverted MP_DVDNAV #define removal Added: trunk/libdvdnav/src/dvdnav.h - copied unchanged from r1110, /trunk/libdvdnav/src/dvdnav.h rathann 2008-07-13T16:52:11 http://comments.gmane.org/gmane.comp.video.dvdnav.general/530 Hi. This is a similar patch for libdvdnav. The only difference is that pkg-config doesn't support --prefix, so I made configure2 check for $dvdreadconfig --cflags output instead. Patch attached. OK to apply? Dan, could you add the corresponding autotools part? Regards, R. Dominik 'Rathann' Mierzejewski 2008-07-13T15:03:27 http://comments.gmane.org/gmane.comp.video.dvdnav.general/529 Author: rathann Date: Sun Jul 13 15:17:35 2008 New Revision: 1111 Log: remove unused #define Modified: trunk/libdvdnav/src/dvdnav.h Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h(original) +++ trunk/libdvdnav/src/dvdnav.hSun Jul 13 15:17:35 2008 < at >< at > -29,8 +29,6 < at >< at > #ifndef DVDNAV_H_INCLUDED #define DVDNAV_H_INCLUDED -#define MP_DVDNAV 1 - #ifdef __cplusplus extern "C" { #endif rathann 2008-07-13T13:17:35 http://comments.gmane.org/gmane.comp.video.dvdnav.general/528 Hi. This adds pkgconfig .pc file generation to the build system. Patch attached. OK to apply? Dan, could you add the corresponding autotools part? Regards, R. Dominik 'Rathann' Mierzejewski 2008-07-13T12:39:18 http://comments.gmane.org/gmane.comp.video.dvdnav.general/527 Author: rathann Date: Sun Jul 13 14:27:17 2008 New Revision: 1110 Log: cosmetics: fix indentation Modified: trunk/libdvdread/src/ifo_print.h Modified: trunk/libdvdread/src/ifo_print.h ============================================================================== --- trunk/libdvdread/src/ifo_print.h(original) +++ trunk/libdvdread/src/ifo_print.hSun Jul 13 14:27:17 2008 < at >< at > -21,7 +21,7 < at >< at > #define IFO_PRINT_H_INCLUDED #include <inttypes.h> -# include "ifo_types.h" +#include "ifo_types.h" void ifo_print(dvd_reader_t *dvd, int title); rathann 2008-07-13T12:27:17 http://comments.gmane.org/gmane.comp.video.dvdnav.general/526 Author: nicodvb Date: Sun Jun 29 14:58:08 2008 New Revision: 1109 Log: after an AUDIO change event assign the logical stream to the returned event, that for some reason was being ignored. The physical stream is still wrong Modified: trunk/libdvdnav/src/dvdnav.c Modified: trunk/libdvdnav/src/dvdnav.c ============================================================================== --- trunk/libdvdnav/src/dvdnav.c(original) +++ trunk/libdvdnav/src/dvdnav.cSun Jun 29 14:58:08 2008 < at >< at > -699,6 +699,7 < at >< at > dvdnav_status_t dvdnav_get_next_cache_bl #endif (*len) = sizeof(dvdnav_audio_stream_change_event_t); stream_change->physical = vm_get_audio_active_stream( this->vm ); + stream_change->logical = this->position_next.audio_channel; this->position_current.audio_channel = this->position_next.audio_channel; #ifdef LOG_DEBUG fprintf(MSG_OUT, "libdvdnav: AUDIO_STREAM_CHANGE stream_id=%d returning DVDNAV_STATUS_OK\n",stream_change->physical); nicodvb 2008-06-29T12:58:09 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.video.dvdnav.general