gmane.comp.version-control.coccinelle

Coccinelle question

Majid Java — 2013-04-24T10:03:35

Hello,

last night i saw your website and projects from google search im really
interested in what Coccinelle doing as i understand its kind of open source
c parser library that follow in source code for variables and trace all
source and headers for it,Right?

now i have some questions:
Are you take care of Variable Scopes when you are searching the source code?

Thanks

junk output

Artem Bityutskiy — 2013-04-26T13:52:17

Hi Julia, Richard,

not sure if this was already reported, but the latest Fedora 18
coccinelle produces a lot of junk. Just an example using the linux
kernel scripts:

$ spatch -sp_file ./scripts/coccinelle/free/clk_put.cocci drivers/gpio/gpio-sch.c

init_defs_builtins: /usr/share/coccinelle/standard.h
HANDLING: drivers/gpio/gpio-sch.c
No matches found for clk_get clk_put
Skipping:drivers/gpio/gpio-sch.c
left
left
left
left
left
left
left
right
right
right
right
right
right
left
left
left
left
left
left
left
left
left
left

Notice these lefts and rights.

$ rpm -q coccinelle 
coccinelle-1.0.0-0.rc14.6.fc18.x86_64

Any suggestions?

Thanks!

1.0.0-rc17

Julia Lawall — 2013-04-07T05:39:55

Version 1.0.0-rc17 has been released.  Some changes are:

- allow __ at the beginning of a struct or union name

- unparsing with precedence (insertion of parentheses when needed)

- Type metavariables no longer match a case where there is no type in the
C code.

- An expression list metavariable can now be attached with < at > to a
parameter list metavariable, to allow using the parameter names as an
argument list.

julia

Analysis for Linux source files

SF Markus Elfring — 2013-04-02T10:12:38

Hello,

I try out a bit of static source code analysis again by the following command.

elfring< at >Sonne:~/Projekte/Coccinelle/lokal/demos/pass-through>
XY=/usr/src/linux-stable/ && spatch -sp_file list_pass-through_functions.cocci \
-dir $XY \
-I ${XY}include \
-I ${XY}usr/include \
-I ${XY}arch/ia64/include \
-I ${XY}arch/ia64/include/uapi \
-I ${XY}arch/x86/include \
-I ${XY}arch/x86/include/generated \
-I /usr/include \
-I /usr/include/c++/4.7/tr1 \
-recursive_includes \
2>list_pass-through_functions-linux-errors.txt


I notice results like the following in my log file.

...
HANDLING: /usr/src/linux-stable/init/noinitramfs.c
EXN:Failure("empty list, max_min_ii_by_pos")
Note: processing took    85.2s: /usr/src/linux-stable/init/noinitramfs.c
HANDLING: /usr/src/linux-stable/init/do_mounts_md.c
EXN:Failure("empty list, max_min_ii_by_pos")
Note: processing took   109.5s: /usr/src/linux-stable/init/do_mounts_md.c
...


Can the shown error message be avoided?
What does it really mean?

openSUSE package: coccinell

Control flow query across files

LANCIA Julien — 2013-03-26T14:29:06

Hello,
I've stumbled accross coccinelle and I'm interested in using it to perform queries on the control flow graph (quite similarly to what have been done in "Finding Error Handling Bugs in OpenSSL using Coccinelle" by Lawall and al.).
However, I wonder if it is possible to perform queries on the control flow graph that span across a single C file.

An example to be clear:

fileA.h : f(), g(), h()
fileA.c : f() calls g() calls h() calls i()

fileA.h : i() j() k()
fileA.c : i() calls j() calls k()

Is it possible with coccinelle to match the query
f()
...
k()

that spans across fileA.c and fileB.c ?

Thanks in advance for your help,
Regards,

Julien Lancia

parameter list to expression list?

Michael Stefaniuc — 2013-03-25T16:09:08

Hello,

is there an intrinsic way to get from a parameter list to an expression
list? That would come in handy when forwarding from one function to
another one. At the moment I help myself with a python rule that
transforms the parameter list to an identifier but that feels clumsy.
E.g. in SmPL pseudo code something like this would be nice:

< at >< at >
type T;
parameter list P;
expression list E = P;
expression ret;
< at >< at >
 T foo(P)
 {
     return
-           ret
+           bar(E)
     ;
 }



thanks
bye
michael

Invitation to the thesis defense of Suman Saha (fwd)

Julia Lawall — 2013-03-22T17:31:47

If you are in the Paris area and are interested in bug finding in C code,
you may be interested in coming to the following PhD defense on Monday.
We plan to make the tool developed as part of this PhD publicly available
shortly.  It has already been used to find quite a number of
resource-release omission faults in Linux, as well as some other systems
software.

julia

---------- Forwarded message ----------
Date: Thu, 21 Mar 2013 13:30:17 +0100
From: Suman <suman.saha< at >lip6.fr>
To: Tout LIP6 <tout-lip6< at >lip6.fr>
Subject: Invitation to the thesis defense of Suman Saha


Hello,

I am pleased to invite you to my thesis defense.

My thesis is entitled "Improving the Quality of Error-Handling Code in
Systems Software using Function-Local Information"

The defense will take place Monday, March 25th at 14:00 pm at Jussieu in
room 25-26/101

---------------------------------------------------------------------------
---------------------------------------------------------------------------
--------------------------

Have coccinelle follow typedef ?

Eric Leblond — 2013-03-19T16:16:17

Hello,

I've got the following construction in a code:
 typedef struct Packet_ {
struct Flow_ * flow;
 } Packet;
and in an other include file:
 typedef struct Flow_ {
...
 } Flow;

My problem here is that if p is a Packet then p->flow is a Flow at least
from a developer point of view. But coccinelle is not detecting the
match "Flow f" do not match on a "p->flow".

I've thought about adding a new isomorphism to solve this but I don't
like the idea...

How could I fix this issue ? 

BR,

Small 'make install' problem

Eric Leblond — 2013-03-19T15:25:11

Hello,

It seems there is an installation issue in current git tree. I was not
able to run make install without doing:
mkdir ocaml/coccilib
in the base project directory.

BR,

how to consider castings in semantic patchs

Andrés More — 2013-03-12T13:51:49

Hi, I've been playing with Coccinele, I find it really useful.

I'm trying to create a semantic patch to rename a structure (and its
fields).
I could get almost everything in place in several patches: the structure
gets renamed, also variables of that type, also their attributes. However,
the code (not mine) uses some explicit castings and I couldn't find a way
to cover those cases also.

I've tried to follow the documented grammar but I think I got lost without
finding how to declare such castings.

I'm appending the last version of the semantic patch I've been working on
just to give the rough idea how what I am trying to describe. The code is a
Linux kernel staging driver (VIA VT6656), using their own Ethernet packet
struct.

Thanks, I will really appreciate any hints on how to consider explicit
casting.

"virtual rule patch not supported"

Brice Goglin — 2013-03-11T08:25:00

Hello,
I am running the kernel 3.9-rc2 coccicheck script on some of my module,
and I get the following message:
  virtual rule patch not supported
Things seem to work fine aside of this message. Anything to be worried
about?
I already upgraded to coccinelle 1.0-rc16 (from Debian experimental)
since rc12 didn't accept orplus.cocci. Anything else to upgrade to avoid
the message?
Thanks
Brice

Class library for "CTL-VW"?

SF Markus Elfring — 2013-03-07T13:05:01

Hello,

Your software uses the technology "computation tree logic with variables and
witnesses" (CTL-VW) like it is described in the document "A Foundation for
Flow-Based Program Matching Using Temporal Logic and Model Checking".
http://coccinelle.lip6.fr/papers/popl09.pdf
http://doi.acm.org/10.1145/1480881.1480897

Is a function or class library available which enables the reuse of this
technique by other source code transformation tools besides your program
implementation "spatch"?

Do you develop any further extensions for this knowledge area from computer science?

Regards,
Markus

Addition of source code documentation generation to thebuild system?

SF Markus Elfring — 2013-03-03T20:21:19

Hello,

I try to generate some documentation from the source files of your current software.

elfring< at >Sonne:~/Projekte/Coccinelle/lokal> MY_DIR=../Probe/Doku/ &&
MY_NAMES=${MY_DIR}file_name_list11.txt && find . \( -name '*.ml' -o -name
'*.mli' \) -a ! -name 'myocamlbuild.ml' -type f -fprint0 $MY_NAMES &&
ocamldoc.opt -d ${MY_DIR} -I commons -I commons/ocamlextra -I
commons/ocollection -I globals -I engine -I parsing_c -I parsing_cocci -I ctl -I
ocaml -I ocamlsexp -I python -I popl09 -I extra -I /usr/local/share/menhir -I
bundles/pcre -I bundles/pycaml -dot -o ${MY_DIR}my_graph.gv -html $(sed 's/\x0/
/g' $MY_NAMES)


I get a couple of error messages because my approach is incomplete so far. I
stumble on technical challenges here.
Would you like to suggest an improved way for the construction of include
directories and file names which should be passed to the command?
Are there any chances to adapt it to the chosen build configuration?

Regards,
Markus

[PATCH 1/4] Coccinelle: Restore coccicheck verbosity inONLINE mode (C=1 or C=2)

Nicolas Palix — 2013-03-02T21:36:25

A recent patch have introduce the VERBOSE variable and comments
now depend on it. However, the message printed for each cocci file
such not be printed when the ONLINE mode is active, whatever is
the value of VERBOSE.

Signed-off-by: Nicolas Palix <nicolas.palix< at >imag.fr>
---
 scripts/coccicheck |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 85d3189..7f0d6a6 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
< at >< at > -72,7 +72,7 < at >< at > coccinelle () {
 #
 #    $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
 
-    if [ $VERBOSE -ne 0 ] ; then
+    if [ $VERBOSE -ne 0 -a $ONLINE -eq 0 ] ; then
 
 FILE=`echo $COCCI | sed "s|$srctree/||"`

1.0.0-rc16: Further fine-tuning for the build system?

SF Markus Elfring — 2013-03-02T21:02:37

Hello,

I try to regenerate your current software from the Git repository on my openSUSE
system. I stumble on the following issue.

elfring< at >Sonne:~/Projekte/Coccinelle/Bau> ../lokal/configure --enable-opt
--enable-ocaml --enable-python --enable-release
configure: loading site script /usr/share/site/x86_64-unknown-linux-gnu
configure: configuring coccinelle 1.0.0-rc15 in
/home/elfring/Projekte/Coccinelle/Bau
...
configure: configuring package menhirLib
checking for OCaml findlib package menhirLib... not found
configure: OCaml package menhirLib is not available
checking for a bundled substitute of menhirLib... not available
configure: error: OCaml package menhirLib is required. Please make sure it is
available.


This library is installed under the directory "/usr/local/share/menhir" and is
found if I let the configuration script run while the source "lokal" is also the
working directory.
Would you like to adjust any configuration checks to support an
"out-of-source-tree build"? (How do you think about to stor

[Coccinellery] drop_continue/cont.cocci broken ?

Cyril Roelandt — 2013-02-19T20:44:12

Hi!

I think the drop_continue/cont.cocci script is broken. Here is a simple 
semantic patch extracted from it:


$ cat foo.cocci
< at >< at >
statement S;
< at >< at >
for (...;...;...) {
   ...
   if (...)
- {
     S
-   continue;
- }
}


A simple C file:

$ cat continue.c
static void
foo(int max)
{
int i;
for (i = 0; i < max; i++) {
do_stuff();
if (i == 42) {
do_stg_else();
continue;
}
}
}

$ spatch -sp_file foo.cocci continue.c --debug --verbose-parsing
init_defs_builtins: /home/cyril/opt/spatch/share/coccinelle/standard.h
-----------------------------------------------------------------------
processing semantic patch file: foo.cocci
with isos from: /home/cyril/opt/spatch/share/coccinelle/standard.iso
-----------------------------------------------------------------------
< at >< at >
statement S;
< at >< at >
for (...;...;...) {
   ...
   if (...)
- {
     S
-   continue;
- }
}

warning: iso braces1 does not match the code below on line 4
{
   ...
   if (...) {
     S
     continue;
   }
}
braces must be all minus (plus code a

Wrong --parse-c stats

Michael Stefaniuc — 2013-02-07T21:46:39

Hello,

not sure if somebody is interested: while running --parse-c on the Wine
source I've noticed impossible stats for 3 C files. As those are test
files those are heavy macro (ab)users.

dlls/quartz/tests/dsoundrender.c
http://source.winehq.org/git/wine.git/blob_plain/HEAD:/dlls/quartz/tests/dsoundrender.c
NB total files = 1; perfect = 0; pbs = 0; timeout = 0; =========> 0%
nb good = 1124,  nb passed = 25 =========> 2.224199% passed
nb good = 1124,  nb bad = -891 =========> 482.403433% good


dlls/quartz/tests/videorenderer.c
http://source.winehq.org/git/wine.git/blob_plain/HEAD:/dlls/quartz/tests/videorenderer.c
NB total files = 1; perfect = 0; pbs = 0; timeout = 0; =========> 0%
nb good = 522,  nb passed = 20 =========> 3.831418% passed
nb good = 522,  nb bad = -358 =========> 318.292683% good


dlls/msxml3/tests/domdoc.c
http://source.winehq.org/git/wine.git/blob_plain/HEAD:/dlls/msxml3/tests/domdoc.c
NB total files = 1; perfect = 0; pbs = 0; timeout = 0; =========> 0%
nb good = 135789,  nb passed = 10

C parse error: multiplication with pointer dereference

Michael Stefaniuc — 2013-02-06T09:41:44

Hello!

I get this parse error for the attached test case:
spatch --parse-c foo.c 2>&1 | grep BAD
BAD:!!!!!     return i * *j;

gcc -Wall -Werror has no issues with it.


thanks
bye
michael

Dangling whitespace on added newlines

Michael Stefaniuc — 2013-01-29T21:10:30

Hello,

when coccinelle automatically adds a newline after removing "{}" the
added newline has dangling whitespace corresponding to the indentation
level. Please see the attached test case and generated patch.

thanks
bye
michael
< at >< at >
identifier mem;
statement S;
< at >< at >
 mem = malloc(...);
 if (mem == NULL)
-{
-    ERR(...);
     S
-}

[PATCH V2] scripts/coccinelle/misc/memcpy-assign.cocci:Replace memcpy with struct assignment

Peter Senna Tschudin — 2013-01-23T22:06:30

There are error-prone memcpy() that can be replaced by struct
assignment that are type-safe and much easier to read. This semantic
patch looks for memcpy() that can be replaced by struct assignment.

Inspired by patches sent by Ezequiel Garcia <elezegarcia< at >gmail.com>

Signed-off-by: Peter Senna Tschudin <peter.senna< at >gmail.com>
---
Changes from V1:
 Updated commit message
 Changed Confidence comment to High on the semantic patch

 scripts/coccinelle/misc/memcpy-assign.cocci | 103 ++++++++++++++++++++++++++++
 1 file changed, 103 insertions(+)
 create mode 100644 scripts/coccinelle/misc/memcpy-assign.cocci

diff --git a/scripts/coccinelle/misc/memcpy-assign.cocci b/scripts/coccinelle/misc/memcpy-assign.cocci
new file mode 100644
index 0000000..afd058b
--- /dev/null
+++ b/scripts/coccinelle/misc/memcpy-assign.cocci
< at >< at > -0,0 +1,103 < at >< at >
+//
+// Replace memcpy with struct assignment.
+//
+// Confidence: High
+// Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Com

Two identical declarer macros handled differently

Håkon Løvdal — 2013-01-15T16:14:54

Hi list. I started writing a script to be a grep for a declarer macro and
print its arguments. For one of the source files however, it produced
a false positive by printing arguments for another declarer macro as
well. Investigating this, I found the following which I think is at
least related, if not the same issue.

With the following two identical D1 and D2 macros, coccinelle fails to
handle D1.

$ more declarer_test.c declarer_test-d2.cocci
::::::::::::::
declarer_test.c
::::::::::::::

static void foo(void *arg)
{
}
D1(foo, 0, 0, 0, 0);

static void bar(void *arg)
{
}
D2(bar, 0, 0, 0, 0);

::::::::::::::
declarer_test-d2.cocci
::::::::::::::
< at >r< at >
declarer name D1;
declarer name D2;
expression E1, E2, E3, E4, E5;
< at >< at >
        D2(E1, E2, E3, E4, E5);

< at >script:python< at >
e1 << r.E1;
e2 << r.E2;
e3 << r.E3;
e4 << r.E4;
e5 << r.E5;
< at >< at >
print "MATCH: 1: %s, 2: %s, 3: %s, 4: %s, 5: %s" % (e1, e2, e3, e4, e5)

$ spatch --sp-file declarer_test-d2.cocci declarer_test.c
init_defs_builtins: /usr/share/coccinelle/standar