gmane.comp.lang.go.devel

code review 9606045: go.tools/go/types: resolve objects in type checker (issue 9606045)

2013-05-25T20:28:22

Reviewers: adonovan,

Message:
Hello adonovan-hpIqsD4AKlfQT0dZR+AlfA< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go.tools


Description:
go.tools/go/types: resolve objects in type checker

By setting resolve = true in check.go, the type checker
will do all identifier resolution during type checking
time and ignore (and not depend on) parser objects. This
permits the type checker to run easily on ASTs that are
not generated with invariants guaranteed by the parser.

There is a lot of new code much of it slightly modified
copies of old code. There is also a lot of duplication.
After removing the dead code resulting from resolve = true
permanently (and removing the flag as well), it will be
easier to perform a thorough cleanup. As is, there are
to many intertwined code paths.

For now resolve = false. To be enabled in a successor CL.

Please review this at https://codereview.appspot.com/9606045/

Affected files:
   A

code review 9777043: ssh/terminal: support home, end, up and down keys. (issue 9777043)

2013-05-25T19:09:37

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go.crypto/


Description:
ssh/terminal: support home, end, up and down keys.

Please review this at https://codereview.appspot.com/9777043/

Affected files:
   M ssh/terminal/terminal.go

code review 9665046: runtime: update comment on stack allocator (issue 9665046)

2013-05-25T17:47:24

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://dvyukov%40google.com-LGSXBDjVo1BibQn6LdNjmg< at >public.gmane.org/p/go/


Description:
runtime: update comment on stack allocator

Please review this at https://codereview.appspot.com/9665046/

Affected files:
   M src/pkg/runtime/stack.c


Index: src/pkg/runtime/stack.c
===================================================================
--- a/src/pkg/runtime/stack.c
+++ b/src/pkg/runtime/stack.c
< at >< at > -81,13 +81,10 < at >< at >
  if(g != m->g0)
  runtime·throw("stackalloc not on scheduler stack");

-// Stack allocator uses malloc/free most of the time,
-// but if we're in the middle of malloc and need stack,
-// we have to do something else to avoid deadlock.
-// In that case, we fall back on a fixed-size free-list
-// allocator, assuming that inside malloc all the stack
-// frames are small, so that all the stack allocations
-// will be a single size, the minimum (right now, 5

code review 9752044: runtime: explicit init of runtime-gdb helpers (issue 9752044)

2013-05-25T14:19:46

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://code.google.com/p/go


Description:
runtime: explicit init of runtime-gdb helpers

If using other gdb python scripts loaded before Go's gdb-runtime.py
and that have a different init prototype:
Traceback (most recent call last):
   File "/usr/lib/go/src/pkg/runtime/runtime-gdb.py", line 446, in
<module>
     k()
TypeError: __init__() takes exactly 3 arguments (1 given)

The problem is that gdb keeps all python scripts in the same namespace,
so vars() contains them. To avoid that, load helpers one by one.

Please review this at https://codereview.appspot.com/9752044/

Affected files:
   M src/pkg/runtime/runtime-gdb.py


Index: src/pkg/runtime/runtime-gdb.py
===================================================================
--- a/src/pkg/runtime/runtime-gdb.py
+++ b/src/pkg/runtime/runtime-gdb.py
< at >< at > -436,6 +436,9 < at >< at >
  #
  # Register all convenience functions and CLI comman

code review 9703044: go.tools/ssa: print identifer location if not found in ... (issue 9703044)

2013-05-25T16:19:41

Reviewers: adonovan,

Message:
Hello adonovan-hpIqsD4AKlfQT0dZR+AlfA< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go.tools


Description:
go.tools/ssa: print identifer location if not found in TypeInfo

Please review this at https://codereview.appspot.com/9703044/

Affected files:
   M ssa/builder.go
   M ssa/typeinfo.go


Index: ssa/builder.go
===================================================================
--- a/ssa/builder.go
+++ b/ssa/builder.go
< at >< at > -2471,6 +2471,7 < at >< at >
  //
  func (b *Builder) typecheck(importPath string, files []*ast.File)  
(*types.Package, *TypeInfo, error) {
  info := &TypeInfo{
+fset:      b.Prog.Files,
  types:     make(map[ast.Expr]types.Type),
  idents:    make(map[*ast.Ident]types.Object),
  constants: make(map[ast.Expr]*Literal),
Index: ssa/typeinfo.go
===================================================================
--- a/ssa/typeinfo.go
+++ b/ssa/typeinfo.go
< at >< at > -7,11 +7,

code review 9774043: go.tools/ssa: fix debug printing (issue 9774043)

2013-05-25T16:03:59

Reviewers: adonovan,

Message:
Hello adonovan (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go.tools


Description:
go.tools/ssa: fix debug printing

Please review this at https://codereview.appspot.com/9774043/

Affected files:
   M ssa/promote.go


Index: ssa/promote.go
===================================================================
--- a/ssa/promote.go
+++ b/ssa/promote.go
< at >< at > -262,7 +262,7 < at >< at >
  sig := types.NewSignature(types.NewVar(nil, "recv", typ), old.Params(),  
old.Results(), old.IsVariadic())

  if prog.mode&LogSource != 0 {
-defer logStack("makeBridgeMethod %s, %s, type %s", typ, cand, &sig)()
+defer logStack("makeBridgeMethod %s, %s, type %s", typ, cand, sig)()
  }

  fn := &Function{

code review 9762045: go-mode: fix godef-jump on Windows. (issue 9762045)

2013-05-25T03:45:40

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org (cc: dominik.honnef-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go


Description:
go-mode: fix godef-jump on Windows.

Fixes issue 5555.

Please review this at https://codereview.appspot.com/9762045/

Affected files:
   M misc/emacs/go-mode.el


Index: misc/emacs/go-mode.el
===================================================================
--- a/misc/emacs/go-mode.el
+++ b/misc/emacs/go-mode.el
< at >< at > -873,16 +873,18 < at >< at >
  (defun godef--find-file-line-column (specifier)
    "Given a file name in the format of `filename:line:column',
  visit FILENAME and go to line LINE and column COLUMN."
-  (let* ((components (split-string specifier ":"))
-         (line (string-to-number (nth 1 components)))
-         (column (string-to-number (nth 2 components))))
-    (with-current-buffer (find-file (car components))
-      (goto-char (point-min))
-      (forward-line (1- l

code review 9751044: fmt: change evalutation of indexed arg to match docs (issue 9751044)

2013-05-25T02:52:15

Reviewers: rsc,

Message:
Hello rsc (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
fmt: change evalutation of indexed arg to match docs
The old code put the index before the period in the precision;
it should be after so it's always before the star, as documented.
A little trickier to do in one pass but compensated for by more
tests and catching a couple of other error cases.

Please review this at https://codereview.appspot.com/9751044/

Affected files:
   M src/pkg/fmt/doc.go
   M src/pkg/fmt/fmt_test.go
   M src/pkg/fmt/print.go


Index: src/pkg/fmt/doc.go
===================================================================
--- a/src/pkg/fmt/doc.go
+++ b/src/pkg/fmt/doc.go
< at >< at > -131,7 +131,7 < at >< at >
  For example,
  fmt.Sprintf("%[2]d %[1]d\n", 11, 22)
  will yield "22, 11", while
-fmt.Sprintf("%[3]*[2].*[1]f", 12.0, 2, 6),
+fmt.Sprintf("%[3]*.[2]*[1]f", 12.0, 2, 6),
  equivalent to
  fmt.Sprintf("%6.2f", 12.

code review 9761043: fmt: fix documentation glitch in index expressions in Printf (issue 9761043)

2013-05-24T23:40:10

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
fmt: fix documentation glitch in index expressions in Printf
Also clean up the code a bit.

Please review this at https://codereview.appspot.com/9761043/

Affected files:
   M src/pkg/fmt/doc.go
   M src/pkg/fmt/fmt_test.go
   M src/pkg/fmt/print.go


Index: src/pkg/fmt/doc.go
===================================================================
--- a/src/pkg/fmt/doc.go
+++ b/src/pkg/fmt/doc.go
< at >< at > -124,9 +124,9 < at >< at >
  formatting verb to format successive arguments passed in the call.
  However, the notation [n] immediately before the verb indicates that the
  nth one-indexed argument is to be formatted instead. The same notation
-before a '*' for a width or precision selects the argument index holding
-the value. After processing a bracketed expression [n], arguments n+1,
-n+2, etc. will be processed unless otherwise directed.
+befo

code review 9750043: doc: start go 1.2 notes (issue 9750043)

2013-05-24T19:39:17

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
doc: start go 1.2 notes

This is a file of hints, not a file of polished text.
Let's not try to do polished text until we start the
release process.

Please review this at https://codereview.appspot.com/9750043/

Affected files:
   A doc/go1.2.txt


Index: doc/go1.2.txt
===================================================================
new file mode 100644
--- /dev/null
+++ b/doc/go1.2.txt
< at >< at > -0,0 +1,11 < at >< at >
+This file collects notes about what has changed since Go 1.1
+and should be mentioned in the Go 1.2 release notes.
+During the Go 1.2 release process it will be necessary to convert
+it to HTML, similar to go1.1.html, but for now it is a text file,
+to make the process of keeping it up-to-date more lightweight.
+
+Please keep the descriptions to a single line, starting with the
+package or cmd/xxx directory name, and ending in a CL

code review 7880043: crypto/tls: support TLS 1.1. (issue 7880043)

2013-05-24T18:30:25

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
crypto/tls: support TLS 1.1.

The significant change between TLS 1.0 and 1.1 is the addition of an
explicit IV in the case of CBC encrypted records. Support for TLS 1.1 is
needed in order to support TLS 1.2.

Please review this at https://codereview.appspot.com/7880043/

Affected files:
   M src/pkg/crypto/cipher/cbc.go
   M src/pkg/crypto/tls/cipher_suites.go
   src/pkg/crypto/tls/common.go
   M src/pkg/crypto/tls/conn.go
   M src/pkg/crypto/tls/handshake_client.go
   M src/pkg/crypto/tls/handshake_client_test.go
   M src/pkg/crypto/tls/handshake_server.go
   M src/pkg/crypto/tls/handshake_server_test.go
   M src/pkg/crypto/tls/key_agreement.go
   M src/pkg/crypto/tls/prf.go
   M src/pkg/crypto/tls/prf_test.go

code review 9713044: path/filepath: Skip TestEvalSymlinks. Plan 9 doesn't ha... (issue 9713044)

2013-05-24T17:47:31

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://code.google.com/p/go


Description:
path/filepath: Skip TestEvalSymlinks. Plan 9 doesn't have symlinks.

Please review this at https://codereview.appspot.com/9713044/

Affected files:
   M src/pkg/path/filepath/path_test.go


Index: src/pkg/path/filepath/path_test.go
===================================================================
--- a/src/pkg/path/filepath/path_test.go
+++ b/src/pkg/path/filepath/path_test.go
< at >< at > -630,6 +630,10 < at >< at >
  }

  func TestEvalSymlinks(t *testing.T) {
+if runtime.GOOS == "plan9" {
+t.Skip("Skipping test: symlinks don't exist under Plan 9")
+}
+
  tmpDir, err := ioutil.TempDir("", "evalsymlink")
  if err != nil {
  t.Fatal("creating temp dir:", err)

code review 9736043: crypto/x509: harmonise error prefixes. (issue 9736043)

2013-05-24T17:09:59

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
crypto/x509: harmonise error prefixes.

crypto/x509 has ended up with a variety of error formats. This change
makes them all start with "crypto/x509: ".

Please review this at https://codereview.appspot.com/9736043/

Affected files:
   M src/pkg/crypto/x509/pem_decrypt.go
   M src/pkg/crypto/x509/pkcs1.go
   M src/pkg/crypto/x509/verify.go
   M src/pkg/crypto/x509/x509.go


Index: src/pkg/crypto/x509/pem_decrypt.go
===================================================================
--- a/src/pkg/crypto/x509/pem_decrypt.go
+++ b/src/pkg/crypto/x509/pem_decrypt.go
< at >< at > -102,7 +102,7 < at >< at >
  }

  // IncorrectPasswordError is returned when an incorrect password is  
detected.
-var IncorrectPasswordError = errors.New("x509: decryption password  
incorrect")
+var IncorrectPasswordError = er

code review 9730043: runtime: allocate chan in 2 allocations (Hchan and user... (issue 9730043)

2013-05-24T16:40:29

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://dvyukov%40google.com-LGSXBDjVo1BibQn6LdNjmg< at >public.gmane.org/p/go/


Description:
runtime: allocate chan in 2 allocations (Hchan and user buffer)
Several reasons for this change:
1. Simplify GC code.
2. Allows lazy chan buffer allocations (i.e. chan(int, 1e7)).
3. Allow bitmask-based GC (otherwise it's unclear how to handle chans,
because it's not a struct and not an array).
Benchmarks results are noisy.
chan(int) allocation is faster because it does not need to call
setype(),
it just sets FlagNoPointers during mallocgc().

benchmark                             old ns/op    new ns/op    delta
BenchmarkChanUncontended                     55           56   +0.90%
BenchmarkChanUncontended-2                   29           28   -1.37%
BenchmarkChanUncontended-4                   19           19   +1.02%
BenchmarkChanUncontended-8                   14           12  -18.12%
Benc

code review 9734043: A+C: Gerasimos Dimitriadis (individual CLA) (issue 9734043)

2013-05-24T16:36:58

Reviewers: gobot_swtch.com,

Message:
Hello gobot-kPPrOchjzlEAvxtiuMwx3w< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
A+C: Gerasimos Dimitriadis (individual CLA)

Generated by addca.

Please review this at https://codereview.appspot.com/9734043/

Affected files:
   M AUTHORS
   M CONTRIBUTORS


Index: AUTHORS
===================================================================
--- a/AUTHORS
+++ b/AUTHORS
< at >< at > -115,6 +115,7 < at >< at >
  Frithjof Schulze <schulze-o02PS0xoJP8jwdJHFrQ6C0zuTB+3w3uf< at >public.gmane.org>
  Gary Burd <gary-4WmyQNmiWaAkC3o8klp1IA< at >public.gmane.org>
  Georg Reinke <guelfey-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
+Gerasimos Dimitriadis <gedimitr-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
  Gideon Jan-Wessel Redelinghuys <gjredelinghuys-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
  Giles Lean <giles.lean-e+AXbWqSrlAAvxtiuMwx3w< at >public.gmane.org>
  Google Inc.
Index: CONTRIBUTORS
===============

code review 9706044: google-api-go-generator: always reference the strings p... (issue 9706044)

2013-05-24T14:59:00

Reviewers: campoy,

Message:
Hello campoy-hpIqsD4AKlfQT0dZR+AlfA< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/google-api-go-client/


Description:
google-api-go-generator: always reference the strings package

Fixes generation after 49979a5f144 which stopped always referencing
strings.Replace and strings.Map.

Please review this at https://codereview.appspot.com/9706044/

Affected files:
   M google-api-go-generator/gen.go


Index: google-api-go-generator/gen.go
===================================================================
--- a/google-api-go-generator/gen.go
+++ b/google-api-go-generator/gen.go
< at >< at > -434,6 +434,8 < at >< at >
  p("\t%q\n", pkg)
  }
  p(")\n\n")
+pn("// Always reference these packages, just in case the auto-generated  
code")
+pn("// below don't.")
  pn("var _ = bytes.NewBuffer")
  pn("var _ = strconv.Itoa")
  pn("var _ = fmt.Sprintf")
< at >< at > -442,6 +444,7 < at >< at >
  pn("var _ = url.Parse")
  pn("var _

code review 9666045: google-api-go-client: add nickcw-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org to CONTRIBUTORS (issue 9666045)

2013-05-24T14:47:57

Reviewers: bradfitz,

Message:
Hello bradfitz-iFWiy5xATs8dnm+yROfE0A< at >public.gmane.org (cc: golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,
nickcw-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/google-api-go-client


Description:
google-api-go-client: add nickcw-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org to CONTRIBUTORS

Please review this at https://codereview.appspot.com/9666045/

Affected files:
   M CONTRIBUTORS


Index: CONTRIBUTORS
===================================================================
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
< at >< at > -34,5 +34,6 < at >< at >
  Alain Vongsouvanhalainv <alainv-hpIqsD4AKlfQT0dZR+AlfA< at >public.gmane.org>
  Brad Fitzpatrick <bradfitz-iFWiy5xATs8dnm+yROfE0A< at >public.gmane.org>
  Francesc Campoy <campoy-iFWiy5xATs8dnm+yROfE0A< at >public.gmane.org>
+Nick Craig-Wood <nickcw-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
  Jason Hall <jasonhall-hpIqsD4AKlfQT0dZR+AlfA< at >public.gmane.org>
  Johan Euphrosine <proppy-hpIqsD4AKlfQT0dZR+AlfA< at >publ

code review 9721044: Scan: Unify error strings with Scan: prefix (issue 9721044)

2013-05-24T10:24:23

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org (cc: hamo.by-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org),

I'd like you to review this change to
https://code.google.com/p/go


Description:
     Scan: Unify error strings with Scan: prefix

Fixes issue 4944

Please review this at https://codereview.appspot.com/9721044/

Affected files:
   M src/pkg/fmt/scan.go


Index: src/pkg/fmt/scan.go
===================================================================
--- a/src/pkg/fmt/scan.go
+++ b/src/pkg/fmt/scan.go
< at >< at > -444,7 +444,7 < at >< at >
  if s.nlIsSpace {
  continue
  }
-s.errorString("unexpected newline")
+s.errorString("Scan: unexpected newline")
  return
  }
  if !isSpace(r) {
< at >< at > -478,7 +478,7 < at >< at >

  // typeError indicates that the type of the operand did not match the  
format
  func (s *ss) typeError(field interface{}, expected string) {
-s.errorString("expected field of type pointer to " + expected + ";  
found " + reflect.TypeOf(field).String())
+s.er

google-api-go-client: Fix socket leak caused by not closing response.Body (issue 9709044)

2013-05-24T12:30:51

Reviewers: golang-dev1,

Message:
Please review!

Apologies if this is a duplicate - not sure it went out the first time

Description:
google-api-go-client: Fix socket leak caused by not closing res.Body -
Issue #23

Please review this at https://codereview.appspot.com/9709044/

Affected files:
   M google-api-go-generator/gen.go


Index: google-api-go-generator/gen.go
===================================================================
--- a/google-api-go-generator/gen.go
+++ b/google-api-go-generator/gen.go
< at >< at > -1163,6 +1163,7 < at >< at >
  pn(`req.Header.Set("User-Agent", "google-api-go-client/` + goGenVersion +  
`")`)
  pn("res, err := c.s.client.Do(req);")
  pn("if err != nil { return %serr }", nilRet)
+pn("defer res.Body.Close()")
  pn("if err := googleapi.CheckResponse(res); err != nil { return %serr }",  
nilRet)
  if retTypeComma == "" {
  pn("return nil")

code review 9678046: runtime: remove unused filed from Hchan (issue 9678046)

2013-05-24T11:20:28

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://dvyukov%40google.com-LGSXBDjVo1BibQn6LdNjmg< at >public.gmane.org/p/go/


Description:
runtime: remove unused filed from Hchan
Remove alignment logic as well, it's not respected by chanbuf() anyway.

Please review this at https://codereview.appspot.com/9678046/

Affected files:
   M src/pkg/runtime/chan.c


Index: src/pkg/runtime/chan.c
===================================================================
--- a/src/pkg/runtime/chan.c
+++ b/src/pkg/runtime/chan.c
< at >< at > -39,7 +39,6 < at >< at >
  uintgodataqsiz;// size of the circular q
  uint16elemsize;
  boolclosed;
-uint8elemalign;
  Alg*elemalg;// interface for element type
  uintgosendx;// send index
  uintgorecvx;// receive index
< at >< at > -93,7 +92,6 < at >< at >
  runtime·makechan_c(ChanType *t, int64 hint)
  {
  Hchan *c;
-uintptr n;
  Type *elem;

  elem = t->elem;
< at >< at > -105,22 +103,19 < at >< at >
  if(hint < 0 || (intgo)hint != hi

code review 9722043: log/syslog: fix deadlock in test (issue 9722043)

2013-05-24T10:30:25

Reviewers: golang-dev1,

Message:
Hello golang-dev-/JYPxA39Uh5TLH3MbocFFw< at >public.gmane.org,

I'd like you to review this change to
https://dvyukov%40google.com-LGSXBDjVo1BibQn6LdNjmg< at >public.gmane.org/p/go/


Description:
log/syslog: fix deadlock in test
The problem was that server handlers block on done<-,
the goroutine that reads from done blocks on count<-,
and the main goroutine that is supposed to read from count
waits for server handlers to exit.
Fixes issue 5547.

Please review this at https://codereview.appspot.com/9722043/

Affected files:
   M src/pkg/log/syslog/syslog_test.go


Index: src/pkg/log/syslog/syslog_test.go
===================================================================
--- a/src/pkg/log/syslog/syslog_test.go
+++ b/src/pkg/log/syslog/syslog_test.go
< at >< at > -281,12 +281,12 < at >< at >
  for i := 0; i < 10; i++ {
  wg.Add(1)
  go func() {
+defer wg.Done()
  err := w.Info("test")
  if err != nil {
  t.Errorf("Info() failed: %v", err)
  return
  }
-wg.Done()
  }()
  }