http://blog.gmane.org/gmane.comp.kde.devel.core hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.comp.kde.devel.core/79235 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110625/ ----------------------------------------------------------- Review request for kdelibs. Description ------- Currently, all KAbstractFileItemActionPlugins which are installed are embedded into file management-related context menus unless the user explicitly disables them in the settings. This becomes problematic if the plugin's actions() method executes code that is not guaranteed to return very fast - the user will notice that the host application freezes without even knowing that one of the plugins is the culprit. In a perfect world, all code executed by plugins would be perfect and the problem would not exist at all. Unfortunately, the world is not perfect, and there are plugins which do things that succeed most of the time, but cause trouble sometimes: https://bugs.kde.org/show_bug.cgi?id=314575 It seems that what Activities is trying to a</pre> Frank Reininghaus 2013-05-23T20:55:11 http://comments.gmane.org/gmane.comp.kde.devel.core/79206 <pre>HI, Over in Kate's mailing list ( http://lists.kde.org/?l=kwrite-devel&amp;m=136804130419019&amp;w=2) there is a discussion about how to support the discovery of plugins written in Python. Currently, this is done in a very Python-centric way using KStandardDirs to find the plugins, and then docstrings within the .py files to load (for example) the description of the module. One problem that has emerged from this approach is that i18n of the docstring-based description strings is problematic, and one possible option to deal with this is to use .desktop files in the usual way. First, note that the plugins written in Python don't plugin to Kate in the normal sense of a KDE C++ plugin, but they themselves plugin into a "hosting" plugin called Pate which *is* a normal KDE C++ plugin with a .desktop file and all. Second these Python plugins are intended to encourage user-hacking by allowing a "search path" concept. So, if the system has the foo Python plugin in these three places: $HOME/.kde/share/apps/kate/pate </pre> Shaheed Haque 2013-05-20T20:26:07 http://comments.gmane.org/gmane.comp.kde.devel.core/79205 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110563/ ----------------------------------------------------------- Review request for Build System and kdelibs. Description ------- Like discussed in the thread "Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)" on kde-core-devel ( http://lists.kde.org/?t=136829863100001&amp;r=1&amp;w=2 ) symbols from QtUitools.a are not hidden by default in Qt4 and thus will be added to the public symbols of the module/shared lib they are linked to. And thus can appear multiple times in the same process, resulting in symbol clashes and leading to problems at least with the Bsymbolic-functions flag or when being possibly incompatible versions. Attached patch sees to solve that problem, by adding a macro KDE4_HIDE_SYMBOLS_FROM_STATIC_LIBS which should add any needed linker flags depending on the platform/linker used. </pre> Friedrich W. H. Kossebau 2013-05-20T18:34:15 http://comments.gmane.org/gmane.comp.kde.devel.core/79196 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110529/ ----------------------------------------------------------- Review request for kdelibs. Description ------- more error handling in KIdleTime Segfaults could result in some rare circumstances Diffs ----- tier1/kidletime/src/xsyncbasedpoller.cpp e5f5328ae66d44e9224582ad759207bc42333d80 tier1/kidletime/src/kidletime.cpp fe18ee5d5c4525086a56d99e76e8ea0a4a92ce08 Diff: http://git.reviewboard.kde.org/r/110529/diff/ Testing ------- Thanks, Ian Monroe </pre> Ian Monroe 2013-05-20T02:05:08 http://comments.gmane.org/gmane.comp.kde.devel.core/79181 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/ ----------------------------------------------------------- Review request for kdelibs and David Faure. Description ------- "Unable to open temporary file" isn't very informative. Diffs ----- kdecore/io/ksavefile.cpp 6cdd41e Diff: http://git.reviewboard.kde.org/r/110514/diff/ Testing ------- yep Thanks, Sergio Luis Martins </pre> Sergio Luis Martins 2013-05-18T19:43:22 http://comments.gmane.org/gmane.comp.kde.devel.core/79167 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ ----------------------------------------------------------- Review request for kdelibs. Description ------- This implemets a step in the kdeui crumble epic. moves the classes kstatusnotifieritem and knotificationsrestrictions in the knotifiactions library. The patch works, but there are still several issues: * porting from kdebug to qdebug loses the area number * adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons * the test adds ki18n kde4support kdecore * the KActionCollection becomes a qhash of actions: how should be kactioncollections ported? I guess it should use the qt translation system, and redo the quit dialog to not usekstandardgui at all? Diffs ----- kdeui/CMakeLists.txt cfa29ef kdeui/tests/CMakeLists.txt cd055d5 staging/knotifications/src/CMakeLists.txt 266b67c staging/knotifications/src/knot</pre> Marco Martin 2013-05-17T12:11:43 http://comments.gmane.org/gmane.comp.kde.devel.core/79154 <pre>Hello, This issue is triggered by kopete's OTR plugin that stopped compiling with LibOTR 4.0.0 because it undergone some imported structure changes. Pali Rohar managed to modify the FindLibOTR.cmake, we now set-up a version range starting with 3.2.0 (initial requirement) to 4.0.0 and kopete compiles by excluding the offending, too recent, LibOTR. However, the final cmake status outputs this : ----------------------------------------------------------------------------- </pre> Valentin Rusu 2013-05-16T19:07:15 http://comments.gmane.org/gmane.comp.kde.devel.core/79153 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110476/ ----------------------------------------------------------- Review request for kde-workspace. Description ------- Call KNotification::close() when user clicks the 'X' button in the Notifications applet. This prevents leaking persistent notifications and allows applications to depend on KNotification::closed() signal. Diffs ----- plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 64d9298 plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 Diff: http://git.reviewboard.kde.org/r/110476/diff/ Testing ------- Thanks, Dan Vrátil </pre> Dan Vrátil 2013-05-16T18:21:11 http://comments.gmane.org/gmane.comp.kde.devel.core/79150 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110462/ ----------------------------------------------------------- Review request for kdelibs, kdewin, Patrick Spendrin, and Patrick von Reth. Description ------- Currently when a second instance of a KUniqueApplication is created KUniqueapplication on Windows just tries to bring the existing process to the front. The problem with this is that the commandline arguments are lost. Kontact parts of kdepim solved this problem in pimuniqueapplication by calling NewInstance with the correct parameters on the existing application. This review Request is about adding that code from kdepimlibs/kontactinterface/pimuniqueapplication.cpp also to KUniqueapplication on Windows. This addresses bug 258489. http://bugs.kde.org/show_bug.cgi?id=258489 Diffs ----- kdeui/kernel/kuniqueapplication.cpp 777fc35 Diff: http://git.reviewboard.kde.org/r/110462/diff/ </pre> Andre Heinecke 2013-05-16T10:21:23 http://comments.gmane.org/gmane.comp.kde.devel.core/79144 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110459/ ----------------------------------------------------------- Review request for kde-workspace. Description ------- This patch allows users to prevent important items from being overwritten in the clipboard history. Methods keep and setKeep were added to HistoryItem. If an item has keep set to true, it will not be overwritten. A submenu was added to set whether an item should be kept in history. Even if there are more elements in the list than the maximum number of entries, the newest element copied to the clipboard will be in the clipboard item. In order to allow Klipper to read history files written with previous versions of Klipper, saving and loading if an item should be kept is handled in klipper.cpp and not by the item. This addresses bug 54212. http://bugs.kde.org/show_bug.cgi?id=54212 Diffs ----- klipper/history.cpp 49e9bb0 k</pre> José Millán Soto 2013-05-15T19:39:36 http://comments.gmane.org/gmane.comp.kde.devel.core/79126 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ ----------------------------------------------------------- Review request for kde-workspace. Description ------- This patch adds a feature present in KDE3 and requested by some users (see open bugs), that is performing an action when a taskbar entry is middle-clicked. I have added three possible actions: Close the application, hide it or move it to the current desktop, where the first two were user requests. This addresses bugs 182689 and 190951. http://bugs.kde.org/show_bug.cgi?id=182689 http://bugs.kde.org/show_bug.cgi?id=190951 Diffs ----- plasma/desktop/applets/tasks/tasks.h fe79a12 plasma/desktop/applets/tasks/tasks.cpp 0a86dcf plasma/desktop/applets/tasks/tasksConfig.ui 6f3ff18 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110430/diff/ Testing ------- Manual tes</pre> Albert Vaca Cintora 2013-05-14T18:47:49 http://comments.gmane.org/gmane.comp.kde.devel.core/79119 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/ ----------------------------------------------------------- Review request for KDE Runtime. Description ------- This adds a 'Insert query placeholder' button to the add/modify web shortcut dialog. -Clicking this button inserts \{&lt; at &gt;} in the shortcut URL lineEdit. -The button is only enabled when the shortcut URL lineEdit has focus. This makes it easy to add new web shortcuts. Users don't have to remember and type the query placeholder. The eventfilter complicates this patch a lot. But there is no slot to detect if a lineedit has focus. We could drop it but it looks messy when the button is always enabled. This addresses bug 146879. http://bugs.kde.org/show_bug.cgi?id=146879 Diffs ----- kurifilter-plugins/ikws/searchproviderdlg.h e931e11 kurifilter-plugins/ikws/searchproviderdlg.cpp 5f40f5f Diff: http://git.reviewboard.kde.org/r/1</pre> Maarten De Meyer 2013-05-14T13:49:43 http://comments.gmane.org/gmane.comp.kde.devel.core/79112 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/ ----------------------------------------------------------- Review request for KDE Base Apps and David Faure. Description ------- The attached patch fixes Konqueror's midnight commander profile so that it correctly works with dolphinpart. Not sure if all the functionality as original intended is preserved, but at least it is not completely useless. This addresses bug 312093. http://bugs.kde.org/show_bug.cgi?id=312093 Diffs ----- Diff: http://git.reviewboard.kde.org/r/110421/diff/ Testing ------- Thanks, Dawit Alemayehu </pre> Dawit Alemayehu 2013-05-14T02:05:42 http://comments.gmane.org/gmane.comp.kde.devel.core/79090 <pre>Hi, there is a little misunderstanding: those two settings are not global settings. This is how it works: if you check BackProp, the neural network will be trained using back propagation. If you check GenAlg, the network will be trained with genetic algorithms. If you check both them, the network will be trained using both methods. In some cases, you may want to use BackProp, in others GenAlg or both them: it depends on the points you are using and on the curve you want to fit. For example, I see that if you use a line as fittign function (y=m*x+q) BackProp is all you need. But if you want to use something more complex (like a third grade function, x^3) GenAlg gives you better results. So those settings are not global: the user must be able to change them every time he/she needs, because usually to find the best fitting curve you have to try different settings. Talking about the translation, BackProp and GenAlg, in my opinion, shouldn't be translated: they are commonly used in many countries (in</pre> LucaTringali 2013-05-11T16:25:36 http://comments.gmane.org/gmane.comp.kde.devel.core/79089 <pre>Ooops: I thought I already corrected this problem, for some reason I did not upload to git this correction. On my system the build goes fine also with that line, but I decide to remove it because it can cause problems with other compiler configurations (on mine I just get a wrining, on other systems it is an error). I corrected the line, anyway just commenting it should be fine: this line is not needed, and it presence does not affect the running of the program. I read that you have commented this line, so you should now be able to run Kartesio. To try it, you can load the file "parabola.kartesio" which is on the git repo. Luca Tringali the return). </pre> LucaTringali 2013-05-11T12:37:06 http://comments.gmane.org/gmane.comp.kde.devel.core/79088 <pre>Yes, I also think adding new features now is not a good idea in this moment. This is the reason why the new version of Kartesio I uploaded to git (about 45 minutes ago) contains basically all the corrctions you suggested, but no new features. Luca Tringali already a big amount of work to be done from the comments you got. I don't think adding features now is a smart move, review is a phase where your program should reach KDE standards. Using Qt libs wherever possible is the priority and getting all the required fixes will make you busy enough. </pre> LucaTringali 2013-05-11T10:21:14 http://comments.gmane.org/gmane.comp.kde.devel.core/79087 <pre>Hi, no, build.sh is not needed. Since I'm kinda lazy, I prepared a shell script to run the following commands: mkdir build cd build sudo make uninstall make clean rm CMakeCache.txt cmake .. -DCMAKE_INSTALL_PREFIX=`kde4-config --prefix` make sudo make install so I don't have to type all those every time I want to build Kartesio again. I'm not sure why you get that error, mainlybecause I don't know which is the instruction that gives that problem since I changed a lot the code in these hours. Try to download the latest git version and build it, so I will know exactly where the problem is. Luca Tringali my build error? </pre> LucaTringali 2013-05-11T10:18:39 http://comments.gmane.org/gmane.comp.kde.devel.core/79066 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ ----------------------------------------------------------- Review request for kdelibs and David Faure. Description ------- The attached patch fixes KTar so that the contents of a sample archive: d/ d/f1.txt d/ d/f2.txt are shown correctly as d/f1.txt d/f2.txt instead of d/f2.txt See the bug report for details on what kind of archives are not shown correctly in Konqueror vs Ark. This addresses bug 206994. http://bugs.kde.org/show_bug.cgi?id=206994 Diffs ----- kdecore/io/ktar.cpp 142a80a Diff: http://git.reviewboard.kde.org/r/110392/diff/ Testing ------- Thanks, Dawit Alemayehu </pre> Dawit Alemayehu 2013-05-11T20:43:50 http://comments.gmane.org/gmane.comp.kde.devel.core/79062 <pre>Hi, tl;dr how to avoid crashes if libQtUiTools.a is linked multiple times into a process? You use at least one of kross, kjsembed, or plasma in your application/lib/module and possibly also directly libQtUiTools yourself? Then bugs.kde.org shows that chances are that you have seen crashes with this in the backtrace: #6 0xb5320313 in QFormInternal::domPropertyToVariant(QFormInternal::QAbstractFormBuilder*, QMetaObject const*, QFormInternal::DomProperty const*) () from XXX where XXX could be libplasma, libkjsembed, krossmoduleforms or your own binary/lib/module. For historic reasons libQtUiTools is a static lib, not a shared, and there has been no work to change that, compare https://bugreports.qt-project.org/browse/QTBUG-437 A few days ago I looked into Kross scripts in Calligra the first time, only to ran into this problem, as reported to my distri here: https://bugzilla.novell.com/show_bug.cgi?id=819437 As can be read in that report, I saw in my backtrace that QFormInternal methods are o</pre> Friedrich W. H. Kossebau 2013-05-11T18:53:46 http://comments.gmane.org/gmane.comp.kde.devel.core/79061 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ ----------------------------------------------------------- Review request for KDE Runtime. Description ------- This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. I made two changes. The first change is renaming of ready() signal from AudioSetup class to pulseAudioReady() which is connected to slot in KCM which sets PulseAudio to enabled in Phonon::DevicePreference. The second change is a new signal emitted when GUI is initialized and only when pulseAudioReady() signal was emitted before. This signal is connected to slot in KCM which inserts this widget to KCM and connects changed() signal to KCM changed() slot. Diffs ----- phonon/kcm/audiosetup.h 4887efe phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.h 277adfe phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390</pre> Jan Grulich 2013-05-11T18:46:18 http://comments.gmane.org/gmane.comp.kde.devel.core/79059 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110388/ ----------------------------------------------------------- Review request for kdelibs. Description ------- The freedesktop spec[0] has changed the default location of the thumbnail cache directory. Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of ~/.thumbnails/ GNOME has already made this change. Some applications[1] and documentation[2] (maybe thumbnailers) will have to be changed to adapt to this new directory. If this patch is accepted I'll make the needed changes. For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate review for that. All thumbnails will have to be regenerated. We could symlink the directory? Is fromLocal8Bit correct or is UTF8 needed now? [0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html [1] configurepreviewdialog.cpp in Dolphin [2]http://techbase</pre> Maarten De Meyer 2013-05-11T14:40:41 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.kde.devel.core