http://blog.gmane.org/gmane.comp.graphics.openscenegraph.cvs hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10583 <pre>Hi, I ran into an issue with osg::TextBase.cpp not computing the bounding box correctly. The problem manifested whenever you used user rotations of non-multiple-of-90 degree angles. I’ve attached a program demonstrating the problem and a patch against the 3.0.1 release that fixed the issue. John.#include &lt;osg/Geode&gt; #include &lt;osgViewer/Viewer&gt; #include &lt;osgGA/TrackballManipulator&gt; #include &lt;osgText/Text&gt; #include &lt;osg/PolygonMode&gt; #include &lt;osg/BlendFunc&gt; struct BBDrawer : osg::NodeCallback { inline BBDrawer(osg::Group* root) { _geom = osg::createTexturedQuadGeometry(osg::Vec3(0,0,0),osg::Vec3(1,0,0),osg::Vec3(0,1,0)); _geom-&gt;setUseDisplayList(false); _geom-&gt;setUseVertexBufferObjects(false); _geom-&gt;getOrCreateStateSet()-&gt;setAttributeAndModes(new osg::PolygonMode(osg::PolygonMode::FRONT_AND_BACK, osg::PolygonMode::LINE)); osg::Geode* geode = new osg::Geode; geode-&gt;addDrawable(_geom); root-&gt;addChild(geode); } virtual void operator()(os</pre> John Swan-Stone 2012-05-25T21:07:37 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10578 <pre>Dear all, I am an employee of dGB Earth Sciences, and we are currently porting the 3D visualization of our open-source seismic interpretation package OpendTect to OpenSceneGraph. I want to submit three minor dragger fixes in osgManipulator. It concerns the files Dragger.cpp, TabPlaneDragger and TabPlaneDragger.cpp. The changed files have been drawn from the last public release OSG 3.0.1, and have been attached to this email. A&gt; Missing break in switch statement at following function of Dragger.cpp: bool Dragger::handle(const osgGA::GUIEventAdapter&amp;, osgGA::GUIActionAdapter&amp;) The case osgGA::GUIEventAdapter::PUSH has no terminating break statement. This was discovered because I was twice receiving a DraggerCallback with its MotionCommand-stage set to osgManipulator::MotionCommand::START. B&gt; Missing body implementation at following function of Dragger.cpp: Dragger::removeDraggerCallback(DraggerCallback* dc) While using DraggerCallbacks in my application, this omission resulted into a crash at remova</pre> Jaap Glas 2012-05-24T15:04:26 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10576 <pre>Hi Robert, A very small but maybe fatal problem was found when I saved models with shader and uniforms (with new double types support) to osgb format and tried to read it again. The application will crash here. And the serializer file should be slightly changed to fix it. Please replace the original file in osgWrappers/serializers/osg/Uniform.cpp. Cheers, Wang Rui _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> Wang Rui 2012-05-22T10:32:24 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10574 <pre>Robert The v3.01 implementation of the ReversePrimitiveFunctor is incorrect for triangle_strips - at least with odd numbers of vertices since the last vertex will be swapped with data beyond the end of the index array. In general the method is also incorrect in that the triangulation of the strip will change in the reversed strip - important if the strip is not plane. The attached code corrects this by merely reversing the indices of the strip (sharing code with reversing lines &amp; polygons) - however this will still have an error if the normals are per_primitive since the reversed strip has not reversed the associated normals. Any suggestions on how to find the normals associated with the reversed strip(s) appreciated - the normals of course are attached to the osg::Geometry not the primitiveset. Should we pass into the reversefunctor the entire geometry? Geoff/* -*-c++-*- OpenSceneGraph - Copyright (C) 1998-2006 Robert Osfield * * This library is open source and may be redistributed and/or modified un</pre> Geoff Michel 2012-05-17T07:59:08 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10573 <pre>Hi Robert Attached is a fix for osgViewers CMakeList.txt when configuring for Android on OSX. Before it was defaulting into the IF(APPLE) branch when selecting WindowingSystem. Then when comparing the "macosx10.7" variable an error was occurring. Presumable as I was targeting Android. Cheers Tom # FIXME: For OS X, need flag for Framework or dylib IF(DYNAMIC_OPENSCENEGRAPH) ADD_DEFINITIONS(-DOSGVIEWER_LIBRARY) ELSE() ADD_DEFINITIONS(-DOSG_LIBRARY_STATIC) ENDIF() SET(LIB_NAME osgViewer) SET(HEADER_PATH ${OpenSceneGraph_SOURCE_DIR}/include/${LIB_NAME}) SET(TARGET_H ${HEADER_PATH}/CompositeViewer ${HEADER_PATH}/Export ${HEADER_PATH}/GraphicsWindow ${HEADER_PATH}/Renderer ${HEADER_PATH}/Scene ${HEADER_PATH}/Version ${HEADER_PATH}/View ${HEADER_PATH}/Viewer ${HEADER_PATH}/ViewerBase ${HEADER_PATH}/ViewerEventHandlers ) SET(LIB_COMMON_FILES CompositeViewer.cpp GraphicsWindow.cpp HelpHandler.cpp Renderer.cpp Scene.cpp ScreenCaptureHandler.</pre> Thomas Hogarth 2012-05-17T00:11:41 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10572 <pre>Hi Robert, the current NVTTProcessor.cpp crashed on my system in the convertRGBAToBGRA method. For me it looks as if it accidentially uses the n variable to access the red channel. I fixed it by reading column*4+0 as it is done for the other channels. The error was introduced with the change to non-contiguous images in OSG old code: [code] // Convert RGBA to BGRA : nvtt only accepts BGRA pixel format void NVTTProcessor::convertRGBAToBGRA( std::vector&lt;unsigned char&gt;&amp; outputData, const osg::Image&amp; image ) { unsigned int n=0; for(int row=0; row&lt;image.t(); ++row) { const unsigned char* data = image.data(0,row); for(int column=0; column&lt;image.s(); ++column) { outputData[n] = data[column*4+2]; outputData[n+1] = data[column*4+1]; outputData[n+2] = data[column*4+n]; // TG crash here outputData[n+3] = data[column*4+3]; n+=4; } } } [/code] fixed code: [code] // Convert RGBA to BGRA : nvtt only accepts BGRA </pre> Tassilo Glander 2012-05-16T13:42:14 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10571 <pre>Hi Robert, With refernce to email "[osg-users] Strategies for reducing visual terrain-tile-popping with osgTerrain" (2012-04-24), I've made a small patch that can alleviate some of the worst "in-your-face" popping by adding CullSettings::setMaxPagedLODLevel(unsigned int). In conjunction with LODScale, this setting can be tuned to minimize terrain tile popping for flight paths that do not vary to much in altitude. The changes are made against the 3.0.1 tag. Note that the changes have only been tested in SingleTreaded mode If the addition/changes are acceptable, please feel free to make the changes you deem necessary for inclusion in OSG:-) Would have preferred not to introduce a dynamic_cast in PageLOD::traverse().... Best regards, John </pre> John Vidar Larring 2012-05-15T12:58:56 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10569 <pre>Hi Robert Attached is a change to the main CMakeLists.txt which just sets the IOS sdk paths to default to the new /Application/Xcode path. It also sets the default sdk version to 5.1 and the default min version to 4.0 This is to fit in with the new XCode and the new tutorial on the osg site. I've seen the thread on automatic selection of the sdk path, which I'm planning to look into, but this will make things easier on new comers till then. Cheers Tom set(CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS TRUE) set_property(GLOBAL PROPERTY USE_FOLDERS ON) IF(WIN32) CMAKE_MINIMUM_REQUIRED(VERSION 2.4.6 FATAL_ERROR) ELSE(WIN32) IF(APPLE) CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0 FATAL_ERROR) ELSE(APPLE) CMAKE_MINIMUM_REQUIRED(VERSION 2.4.4 FATAL_ERROR) ENDIF(APPLE) ENDIF(WIN32) if(COMMAND cmake_policy) # Works around warnings libraries linked against that don't # have absolute paths (e.g. -lpthreads) cmake_policy(SET CMP0003 NEW) # Works around warnings about escaped quotes in </pre> Thomas Hogarth 2012-05-14T23:16:52 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10568 <pre>hi robert, attached are a few nvtt fixes for the latest nvtt, osg(r13078), and osx. bob </pre> Bob Kuehne 2012-05-05T19:18:39 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10567 <pre>Hi, I’ve run into three bugs with osgText.cpp with OSG 3.0.1. The first happens when you use setCharacterSizeMode(osgText::Text::OBJECT_COORDS_WITH_MAXIMUM_SCREEN_SIZE_CAPPED_BY_FONT_HEIGHT); and you place text in any plane other than osgText::Text::XY_PLANE The essence of the issue is the auto-sizing code doesn’t work correctly for text in any plane other than XY_PLANE. I’ve attached the program and a screen shot showing the problem. The fix was simply scaling all 3 dimensions instead of just X and Y. The second showed up with using osgText::Text::FILLEDBOUNDINGBOX draw mode with osgText::TextLYGON_OFFSET backdropImplementation with a osglygonOffset stateAttribute attached. osgText.cpp wasn’t respecting the PolygonOffset in the current State. I also noticed some incorrect values in a couple glPushAttrib calls. I’ve attached a patch file generated by SVN. Thanks, John.#include &lt;osg/Geode&gt; #include &lt;osgViewer/Viewer&gt; #include &lt;osgGA/TrackballManipulator&gt; #include &lt;osgText/Text&gt; void main(</pre> John Swan-Stone 2012-05-05T01:15:24 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10566 <pre>Add key bindings to the help and add on-screen help for osgmanipulator to make it easier to figure out how to activate the draggers. Modified from r13078. -- Bryan Thrall Principal Software Engineer FlightSafety International bryan.thrall-A7WBat7Xm6L28lPXxEEMUQ&lt; at &gt;public.gmane.org   _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> Thrall, Bryan 2012-05-03T20:09:55 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10563 <pre>Good day! Could you pls consider a change to text3D implementation: In case of VERTICAL layout we use linelength variable but never increase its value during charcode iterations. What I suggest: Code: diff --git a/3rdparty/osg/OpenSceneGraph/src/osgText/Text3D.cpp b/3rdparty/osg/OpenSceneGraph/src/osgText/Text3D.cpp index a4ae866..e7c2108 100644 --- a/3rdparty/osg/OpenSceneGraph/src/osgText/Text3D.cpp +++ b/3rdparty/osg/OpenSceneGraph/src/osgText/Text3D.cpp &lt; at &gt;&lt; at &gt; -362,6 +362,7 &lt; at &gt;&lt; at &gt; void Text3D::computeGlyphRepresentation() previous_charcode = charcode; } +linelength++; } } else Modified Text3D.cpp attached. Cheers, Mihail ------------------ Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=47323#47323 Attachments: http://forum.openscenegraph.org//files/text3d_438.cpp </pre> Mihail Baranov 2012-04-26T15:24:04 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10559 <pre>Hi Robert, I added a method to force the index mesh visitor to rebuild index of geometry even if it's already indexed. It's because the optimizer convert any polygons primitives to indexed triangles so It's easier to reuse this optimizer instead of rewriting a specific Optimizer that will do that. Cedric Pinson Provide OpenGL, WebGL services +33 659 598 614 - http://cedricpinson.com - http://osgjs.org - http://sketchfab.com _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> Cedric Pinson 2012-04-23T15:02:57 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10552 <pre>This patch modifies ReaderWriterPNG.cpp to 1. Check the bit depth of the passed Image and return an error if not 8 or 16. (not fully featured, but still an improvement over hard coded 8bit for everything) 2. Detect GL_DEPTH_COMPONENT pixelFormat and write it as greyscale. 3. Endian swap 16bit image data when on a little endian architecture. ------------------ Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=47178#47178 Attachments: http://forum.openscenegraph.org//files/readerwriterpng_176.cpp </pre> John Kaniarz 2012-04-20T18:35:25 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10537 <pre> Hi Robert, Attached is a change to the ac3d model loader as of rev 11498, that uses indexed draws instead of plain array draws to save some amount of main memory. Draw performance does not change with the nvidia binary blob as well as with the open source drivers. Please apply, Thanks! Mathias_______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> Mathias Fröhlich 2012-04-18T17:36:16 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10535 <pre>Hi Robert, attaching submision of osg::Group::removeAllChildren() as I am often removing all the children of a group when restructuring the scene graph. This simplifies complex commands like: appSingleton-&gt;getCurrentModel()-&gt;removeChildren(0, appSingleton- to much nicer and more readable (and more quickly typeable): appSingleton-&gt;getCurrentModel()-&gt;removeAllChildren(); If you like the submission, you can merge it. John_______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> PCJohn 2012-04-18T14:46:25 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10528 <pre>Hi Robert, Here new type that could be usefull with new Integer VertexAttrib{I,L}Pointer. Cheers David _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> David Callu 2012-04-17T19:51:30 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10527 <pre>Hi Robert, Here a patch to provide glVertexAttribLPointer and glVertexAttribIPointer in OSG. I add in Geometry an enum enum AttributeType { FLOAT, INTEGER, DOUBLE }; and a variable to ArrayData "osg::Geometry::ArrayData::AttributeType type" to specify which kind of data we want to give to OpenGL. default value if FLOAT Cheers David _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> David Callu 2012-04-17T19:46:17 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10526 <pre>Hi Robert, PrimitiveSet can use multiple instance but If I need to use the same PrimitiveSet with different number of instance, I have to duplicate the PrimitiveSet and potentially use many memory just for one integer. I submit a new function that allow user to specify how many instance to draw on draw call. void osg::PrimitiveSet::draw(State&amp; state, bool useVertexBufferObjects, unsigned int numInstances); Cheers David _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> David Callu 2012-04-17T19:37:06 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10525 <pre>Hi Robert, Here the fix for Matrix{2,3,4}x{2,3,4}{fd} defined in Uniform header. My previous patch for Atomic Counter Uniform provide new template implementation of Matrix{2,3,4}x{2,3,4}{fd}. This new implementation use Column-Major Matrix. Original code define matrix as Row-Major matrix like other Matrix in OSG, and my matrix implementation break compatibility with previous code. For example osg_normalMatrix define in osg::State report by Roland Hill. Thanks to Paul Martz to spot me when the bug appear. Cheers David _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> David Callu 2012-04-17T19:28:02 http://comments.gmane.org/gmane.comp.graphics.openscenegraph.cvs/10524 <pre>Mostly small changes to add more compile options, and shared linking (still testing that capability, but this enables on a compile basis if the user wants). Robert, when you give the Ok I'll update/rewrite the Android section in the old/new wiki you'll say where is better. Mostly to be clear for the future users what options can configure and what are their purpose. Cheers. _______________________________________________ osg-submissions mailing list osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF&lt; at &gt;public.gmane.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org </pre> Jorge Izquierdo Ciges 2012-04-17T11:20:40 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.graphics.openscenegraph.cvs