http://blog.gmane.org/gmane.comp.gcc.patches hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.comp.gcc.patches/263885 <pre>In C++, C99 a compound literal creates a temporary object, unlike C, where it creates an automatic or static object. As a result, using an array compound literal to initialize a pointer variable leads to undefined behavior, as the array's lifetime ends after the declaration statement. This patch changes the C++ front end to reject decay of temporary array compound literals to pointers, and the C front end to warn about it with -Wc++-compat. Tested x86_64-pc-linux-gnu. Is the C front-end change OK? </pre> Jason Merrill 2012-05-26T19:02:03 http://comments.gmane.org/gmane.comp.gcc.patches/263881 <pre>Hi, As described in PR53447, many 64bit ALU operations with constant can be optimized to use corresponding 32bit instructions with immediate operands. This is the first part of the patches that deals with 64bit add. It directly extends the patterns adddi3, arm_adddi3 and adddi3_neon to handle constant operands. Tested on arm qemu without regression. OK for trunk? thanks Carrot 2012-05-26 Wei Guozhi &lt;carrot&lt; at &gt;google.com&gt; PR target/53447 * gcc.target/arm/pr53447-1.c: New testcase. 2012-05-26 Wei Guozhi &lt;carrot&lt; at &gt;google.com&gt; PR target/53447 * config/arm/arm-protos.h (const_ok_for_adddi): New prototype. * config/arm/arm.c (const_ok_for_adddi): New function. * config/arm/constraints.md (Dd): New constraint. * config/arm/arm.md (adddi3): Extend it to handle constants. (arm_adddi3): Likewise. * config/arm/neon.md (adddi3_neon): Likewise. Index: testsuite/gcc.target/arm/pr53447-1.c =================================================================== --- testsuite/gcc.target/arm/pr53447-1.c(revis</pre> Carrot Wei 2012-05-26T13:42:52 http://comments.gmane.org/gmane.comp.gcc.patches/263880 <pre>Hi, I found the time to return to this issue, where -Wmissing-braces is often overeager to warn, thus annoying, for example, people using -Wall together with std::array: std::array&lt;int, 3&gt; s = { 1, 2, 3 }; I handle the issue following the letter of the suggestion given by Ian at the time: do not warn when the class type has only one field and that field is an aggregate (recursively, of course). Indeed, that seems to me quite conservative. I also make sure to change nothing wrt the designated initializers extension. Bootstrapped and tested x86_64-linux. Thanks, Paolo. //////////////////////// /cp 2012-05-26 Paolo Carlini &lt;paolo.carlini&lt; at &gt;oracle.com&gt; PR c++/25137 * decl.c (reshape_init_r): Add bool parameter. (reshape_init_class): If the struct has only one field and that field is an aggregate, don't warn if there is only one set of braces in the initializer. (reshape_init_array_1, reshape_init_class, reshape_init): Adjust. /testsuite 2012-05-26 Paolo Carlini &lt;paolo.carlini&lt; at &gt;oracle.co</pre> Paolo Carlini 2012-05-26T13:30:48 http://comments.gmane.org/gmane.comp.gcc.patches/263876 <pre>The problem is that the new call to cleanup_cfg in gimple_expand_cfg has short-circuited the machinery that emits nops to carry goto locus at -O0. The machinery works in CFGLAYOUT mode, but here we're still in CFGRTL. The attached patch makes it so that forwarder blocks are not deleted by try_optimize_cfg if CLEANUP_NO_INSN_DEL and partially extends the above machinery to the CFGRTL mode. Bootstrapped/regtested on x86_64-suse-linux, applied on the mainline. 2012-05-26 Eric Botcazou &lt;ebotcazou&lt; at &gt;adacore.com&gt; * cfgcleanup.c (try_optimize_cfg): Do not delete forwarder blocks if CLEANUP_NO_INSN_DEL. * cfgrtl.c (unique_locus_on_edge_between_p): New function extracted from cfg_layout_merge_blocks. (emit_nop_for_unique_locus_between): New function. (rtl_merge_blocks): Invoke emit_nop_for_unique_locus_between. (cfg_layout_merge_blocks): Likewise. </pre> Eric Botcazou 2012-05-26T12:00:55 http://comments.gmane.org/gmane.comp.gcc.patches/263875 <pre>There is one more goto in the .optimized dump because the latch of a loop is now preserved. Tested on i586-suse-linux, applied on the mainline. 2012-05-26 Eric Botcazou &lt;ebotcazou&lt; at &gt;adacore.com&gt; * gnat.dg/renaming5.adb: Adjust dg-final directive. </pre> Eric Botcazou 2012-05-26T11:43:36 http://comments.gmane.org/gmane.comp.gcc.patches/263874 <pre>To have the name of the types of the variant part and the fields therein be unique instead of mere duplicates of those of the base type, which makes it easier to debug type merging issues in LTO mode. Tested on i586-suse-linux, applied on the mainline, 4.7 and 4.6 branches. 2012-05-26 Eric Botcazou &lt;ebotcazou&lt; at &gt;adacore.com&gt; * gcc-interface/decl.c (variant_desc): Rename 'record' to 'new_type'. (build_variant_list): Adjust to above renaming. (gnat_to_gnu_entity) &lt;E_Record_Subtype&gt;: Likewise. Give a unique name to the type of the variant containers. (create_variant_part_from): Likewise. Give a unique name to the type of the variant part. </pre> Eric Botcazou 2012-05-26T10:38:49 http://comments.gmane.org/gmane.comp.gcc.patches/263873 <pre>Hi, There is an off by one error in neon_evpc_vrev which means it rarely gets triggerred. The problem is that if you are looking at d-&gt;perm [i +j] and you increment i by just diff you end up starting looking where you looked at the end of the last place where you checked. Given this I think this patch should make it to trunk and to the 4.7 branch after appropriate testing and if the release managers don't object to such a change. The point is that this helps generate proper vect_reverse style instructions for arm_neon. There is scope for a follow up patch that fixes up the intrinsics essentially identical to all the functions in the test that I've added (except for a couple of missing v2sf and v4sf type operations which should boil down to the same implementation) . It's a permute so the type really doesn't matter. However it requires some ML magic with permutations for the masks which will prove to be good fun on a plane trip. Testing currently in progress and if there are no regressions I intend</pre> Ramana Radhakrishnan 2012-05-26T08:27:53 http://comments.gmane.org/gmane.comp.gcc.patches/263868 <pre>Hi, an ICE on invalid, regression in 4.7 and 4.8. In 4.7 (vs 4.6) we started using stabilize_expr in one more place in cp_build_modify_expr without also adding a preliminary check that the expr isn't of void type, thus we can easily end up calling build_type_target_expr_with_type on it and crash. The fix I tested could be even simpler but I guess we want to also emit the error line " in evaluation of...", like in 4.6. If you can't imagine how we could regress with this sort of fix (I can't ;) probably the issue should be also addressed in 4.7, this kind of invalid code must be quite common. Thanks, Paolo. ///////////////////////// /cp 2012-05-26 Paolo Carlini &lt;paolo.carlini&lt; at &gt;oracle.com&gt; PR c++/53491 * typeck.c (cp_build_modify_expr): Fo binary ops, check that the right-hand side isn't of void type. /testsuite 2012-05-26 Paolo Carlini &lt;paolo.carlini&lt; at &gt;oracle.com&gt; PR c++/53491 * g++.dg/parse/crash60.C: New. Index: testsuite/g++.dg/parse/crash60.C ==========================================</pre> Paolo Carlini 2012-05-26T01:11:52 http://comments.gmane.org/gmane.comp.gcc.patches/263863 <pre>Hello, The following patch was necessary to make check_makefile_deps.sh work on powerpc64-unknown-linux-gnu. Is this OK? Ciao! Steven Index: contrib/ChangeLog =================================================================== --- contrib/ChangeLog(revision 187901) +++ contrib/ChangeLog(working copy) &lt; at &gt;&lt; at &gt; -1,3 +1,8 &lt; at &gt;&lt; at &gt; +2012-05-25 Steven Bosscher &lt;steven at gcc dot gnu dot org&gt; + +* check_makefile_deps.sh: Add ecrti.o and ecrtn.o to the list of +objects to skip unconditionaly. Check for c-common.o in c-family/. + 2012-05-25 H.J. Lu &lt;hongjiu dot lu at intel dot com&gt; PR bootstrap/53472 Index: contrib/check_makefile_deps.sh =================================================================== --- contrib/check_makefile_deps.sh(revision 187901) +++ contrib/check_makefile_deps.sh(working copy) &lt; at &gt;&lt; at &gt; -19,7 +19,7 &lt; at &gt;&lt; at &gt; # Skip some objects unconditionally; make sure each name in this list is # surrounded by spaces. -skip=" crtbegin.o crtbeginS.o crtbeginT.o crtend.o crtendS.o crtfastmath.o crtprec64.o crtp</pre> Steven Bosscher 2012-05-25T23:38:10 http://comments.gmane.org/gmane.comp.gcc.patches/263861 <pre>I've merged gcc-4_7-branch revision 187900 to the gccgo branch. Ian </pre> Ian Lance Taylor 2012-05-25T22:45:03 http://comments.gmane.org/gmane.comp.gcc.patches/263857 <pre>This patch is for the google/gcc-4_6 branch. It fixes a problem where we were still trying to output entries in the .debug_addr table for location lists that were removed, and fixes a problem where we were getting an ICE while trying to output a pubname for a member function of a struct. Tested with the GCC testsuite and validate-failures.py, and also with an internal Google build with -gfission enabled. 2012-05-25 Sterling Augustine &lt;saugustine&lt; at &gt;google.com&gt; Cary Coutant &lt;ccoutant&lt; at &gt;google.com&gt; * gcc/dwarf2out.c (remove_loc_list_addr_table_entries): New function. (is_class_die): Return TRUE for DW_TAG_structure_type. (resolve_addr): Remove address table entries when replacing a location list. Index: gcc/dwarf2out.c =================================================================== --- gcc/dwarf2out.c(revision 187887) +++ gcc/dwarf2out.c(working copy) &lt; at &gt;&lt; at &gt; -7864,6 +7864,19 &lt; at &gt;&lt; at &gt; remove_addr_table_entry (unsigned int i) attr-&gt;dw_attr = (enum dwarf_attribute) 0; } +/* Given a location list</pre> Cary Coutant 2012-05-25T22:29:27 http://comments.gmane.org/gmane.comp.gcc.patches/263855 <pre>This patch to libgo makes the implementation of function trampolines, used for nested functions that refer to variables in an enclosing function scope, much more efficient. Previously we were allocating a separate page for each trampoline. This patch packs them on a single page as much as possible. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Commited to mainline and 4.7 branch. Ian </pre> Ian Lance Taylor 2012-05-25T21:51:47 http://comments.gmane.org/gmane.comp.gcc.patches/263852 <pre>This patch to the Go frontend changes it to not produce a closure for an embedded function if one is not needed. Earlier, when Go permitted comparisons of function types, it was necessary to always create a closure for an embedded function, so that each embedded function would be reliably distinct. Go 1 removed function comparisons, for this and other reasons. Now, if an embedded function does not require a closure, because it does not refer to any variables defined in enclosing functions, we don't need to create a closure. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian </pre> Ian Lance Taylor 2012-05-25T21:14:51 http://comments.gmane.org/gmane.comp.gcc.patches/263850 <pre>When using the gold linker, the linker will adjust the split-stack prologue to call __morestack_non_split if it sees that the function calls a different function compiled without -fsplit-stack. The __morestack_non_split function has an optimization I committed 2011-12-20 to avoid splitting the stack if it has a lot of space. Unfortunately, I forgot that if the function calling __morestack_non_split is a varargs function, then it expects %ebp to have a particular value when __morestack_non_split returns. There is no reasonable way for __morestack_non_split to set %ebp to the right value without actually splitting the stack. This patch changes __morestack_non_split to do a stack split when called by a varargs function. It detects a call from a varargs function by looking at the instruction it is going to return to, to see if it uses %ebp. Bootstrapped and ran Go testsuite and split-stack tests on x86_64-unknown-linux-gnu, both 32-bit and 64-bit. Added a new test to check this case in the future. With an</pre> Ian Lance Taylor 2012-05-25T20:50:00 http://comments.gmane.org/gmane.comp.gcc.patches/263836 <pre>This patch to libgo fixes a cast error in the new file print.c that shows up on 32-bit systems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian </pre> Ian Lance Taylor 2012-05-25T18:22:44 http://comments.gmane.org/gmane.comp.gcc.patches/263817 <pre>Hello! 2012-05-25 Uros Bizjak &lt;ubizjak&lt; at &gt;gmail.com&gt; PR target/53474 * config/i386/i386.c (ix86_print_operand) &lt;case 'O'&gt;: Print '.' here. &lt;case 'C', case 'c', case 'F', case 'f'&gt;: Print '.' only for C and c. Tested on i386-pc-solaris2.10 by Rainer, and on x86_64-pc-linux-gnu {,-m32}. Committed to mainline SVN. Uros. Index: config/i386/i386.c =================================================================== --- config/i386/i386.c(revision 187882) +++ config/i386/i386.c(working copy) &lt; at &gt;&lt; at &gt; -13931,8 +13931,8 &lt; at &gt;&lt; at &gt; C -- print opcode suffix for set/cmov insn. c -- like C, but print reversed condition F,f -- likewise, but for floating-point. - O -- if HAVE_AS_IX86_CMOV_SUN_SYNTAX, print the opcode suffix for -the size of the current operand, otherwise nothing. + O -- if HAVE_AS_IX86_CMOV_SUN_SYNTAX, expand to "w.", "l." or "q.", +otherwise nothing R -- print the prefix for register names. z -- print the opcode suffix for the size of the current operand. Z -- likewise, with specia</pre> Uros Bizjak 2012-05-25T15:12:14 http://comments.gmane.org/gmane.comp.gcc.patches/263814 <pre>Fix parser initialization and parsing of gimple_assign. This patch fixes the parser to use the new line map table initialization code. It was not setting the allocation function pointers properly. Additionally, we were only expecting binary RHS for gimple_assign. This was causing failures in the small test file I added yesterday. Sandeep, now that we have an initial harness for testing, could you please add a set of .gimple files that test the *whole* gimple grammar? (or at least a large chunk of it). An initial starting point would be to use -fdump-tree-gimple-raw on the compilation of several C/C++ source files. This will give you an initial set of test cases to put in the testsuite to exercise the recognizer. Tested on x86_64. 2012-05-25 Diego Novillo &lt;dnovillo&lt; at &gt;google.com&gt; gimple/ChangeLog * parser.c (gimple_register_var_decl_in_symtab): Tidy. (gl_peek_token): New. (gl_consume_token): Call it. (gl_tree_code_for_token): Add FIXME note. (gl_gimple_code_for_token): Likewise. (gl_dump): Surro</pre> Diego Novillo 2012-05-25T15:04:03 http://comments.gmane.org/gmane.comp.gcc.patches/263810 <pre>Hi, I've noticed that libitm is always rebuild with a non-bootstrap tree even with merely a sequence of two makes. The reason turns out to be that installation of unwind.h from libgcc, which is always done with a simple make: # make # make -d ... dest=../.././gcc/include/tmp$$-unwind.h; \ cp unwind.h $dest; \ chmod a+r $dest; \ sh ../../../gcc/libgcc/../move-if-change $dest ../.././gcc/include/unwind.h (this is still fine, because it uses move-if-change) ... make install-leaf DESTDIR=../.././gcc \ slibdir= libsubdir= MULTIOSDIR=. ... /bin/sh ../../../gcc/libgcc/../mkinstalldirs ../.././gcc/include /usr/bin/install -c -m 644 unwind.h ../.././gcc/include This one updates the mtime of gcc/include/unwind.h, and is the problematic one, ultimately resulting in: Prerequisite `/matz/gcc/svn/real-trunk/dev/gcc/include/unwind.h' is newer than target `aatree.lo'. And all of libitm (our only c++ library) is rebuilt as all objects therein have a dependency on unw</pre> Michael Matz 2012-05-25T14:30:45 http://comments.gmane.org/gmane.comp.gcc.patches/263792 <pre>This is a patch from Patrick, based on an earlier patch by Dave Boutcher. Thanks folks. In the failing testcase below we have a transaction_safe function being accessed indirectly, but for -O1 and above, the corresponding clone is not generated because we think it is unused. Fixed by forcing the clone output if it is accessed indirectly. Tested on x86-64 Linux. OK? Would this be acceptable for the 4.7 branch as well? PR middle-end/53008 * trans-mem.c (ipa_tm_create_version_alias): Output new_node if accessed indirectly. (ipa_tm_create_version): Same. Index: testsuite/gcc.dg/tm/pr53008.c =================================================================== --- testsuite/gcc.dg/tm/pr53008.c(revision 0) +++ testsuite/gcc.dg/tm/pr53008.c(revision 0) &lt; at &gt;&lt; at &gt; -0,0 +1,14 &lt; at &gt;&lt; at &gt; +/* { dg-do compile } */ +/* { dg-options "-fgnu-tm -O" } */ + +void __attribute__((transaction_safe)) (*fn)(void); + +static void __attribute__((transaction_safe)) +foo(void) +{ +} + +void set_fn(void) +{ + fn = foo; +} Index: trans-</pre> Aldy Hernandez 2012-05-25T13:25:47 http://comments.gmane.org/gmane.comp.gcc.patches/263790 <pre> The attached patch solves PR53453. The upcoming dsymutil release will now issue a warning when no debug notes are emitted for an object file on linkage. This causes several thousand failures in the FSF gcc testsuite. The origin of this problem is that the darwin linker requires the presence of both AT_name and AT_comp_dir attributes for each object file otherwise their debug notes will be omitted on linkage. The patch adds a new TARGET_FORCE_AT_COMP_DIR target hook for darwin so that AT_comp_dir will be present for all object files. Bootstrap and regression tested on x86_64-apple-darwin12. http://gcc.gnu.org/ml/gcc-testresults/2012-05/msg02331.html Okay for gcc trunk and later gcc-4_7-branch and gcc-4_6-branch? Jack ps Note that this is a pre-existing problem on darwin and that the newer dsymutil simply has alerted us to the issue. pps Added correction of s/AT_comp_dir/DW_AT_comp_dir/g to gcc/target.def change. 2012-05-24 Jack Howarth &lt;howarth&lt; at &gt;bromo.med.uc.edu&gt; PR debug/53453 *</pre> Jack Howarth 2012-05-25T13:17:20 http://comments.gmane.org/gmane.comp.gcc.patches/263787 <pre> The attached patch limits the linkage of -lcrt1.10.6.o to darwin10 and darwin11 since its usage is deprecated in the 10.8sdk. The patch also solves radr://11491405, "-pg broken for -mmacosx-version-min=10.8"... 19-May-2012 11:10 PM Jack Howarth: Summary: The default -mmacosx-version-min=10.8 under Xcode 4.4 breaks a number of FSF gcc tests which rely on -pg. such as... FAIL: gcc.dg/nest.c execution test FAIL: gcc.dg/nested-func-4.c execution test Steps to Reproduce: The attached compressed archive for xcodebug_pg_10.8.tar.bz2 contains the files from compiling these test cases with... gcc-fsf-4.7 /sw/src/fink.build/gcc47-4.7.1-1000/gcc-4.7-20120518/gcc/testsuite/gcc.dg/nest.c --save-temps -v -O2 -pg -lm -m32 -o ./nest.exe and gcc-fsf-4.7 /sw/src/fink.build/gcc47-4.7.1-1000/gcc-4.7-20120518/gcc/testsuite/gcc.dg/nested-func-4.c -v --save-temps -pg -lm -m32 -o ./nested-func-4.exe as well as shell scripts for bad_runs.sh and bad_runs2.sh to execute each of the miscompiled binaries against the bundled </pre> Jack Howarth 2012-05-25T13:06:51 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.gcc.patches