http://blog.gmane.org/gmane.comp.audio.pulseaudio.general hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13339 <pre>From: "Jan Alexander Steffens (heftig)" &lt;jan.steffens&lt; at &gt;gmail.com&gt; These symbols were removed in libudev.so.1.0.0. Replace them with hardcoded strings. Signed-off-by: Jan Alexander Steffens (heftig) &lt;jan.steffens&lt; at &gt;gmail.com&gt; --- src/modules/module-udev-detect.c | 9 +++------ src/modules/udev-util.c | 4 ++-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/modules/module-udev-detect.c b/src/modules/module-udev-detect.c index 1192194..31416bd 100644 --- a/src/modules/module-udev-detect.c +++ b/src/modules/module-udev-detect.c &lt; at &gt;&lt; at &gt; -123,7 +123,7 &lt; at &gt;&lt; at &gt; static char *card_get_sysattr(const char *card_idx, const char *name) { goto finish; } - t = pa_sprintf_malloc("%s/class/sound/card%s", udev_get_sys_path(udev), card_idx); + t = pa_sprintf_malloc("/sys/class/sound/card%s", card_idx); card = udev_device_new_from_syspath(udev, t); pa_xfree(t); &lt; at &gt;&lt; at &gt; -282,7 +282,7 &lt; at &gt;&lt; at &gt; static void verify_access(struct userdata *u, struct device *d) { pa_assert(u); p</pre> Jan Alexander Steffens (heftig 2012-05-26T01:28:45 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13336 <pre>Please review! This helps to change log target on the fly. _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss&lt; at &gt;lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss </pre> rong deng 2012-05-25T06:47:33 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13335 <pre>Please review and hopefully got accepted. :) I did a simple grep and saw there are lots of other usages of strcmp, but let's translate it bit by bit... --deng _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss&lt; at &gt;lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss </pre> rong deng 2012-05-25T02:22:42 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13334 <pre>I've been trying to figure out a problem I'm having with continuous dopplering of VLC when using pulseaudio for sound. There is no dopplering with use of pure ALSA output. I'd greatly appreciate any assistance as I've been unable to resolve this on my own after extensive google digging. Here's the behavior (from vlc -vvv): [0xb3f59e98] pulse audio output warning: too late by 87060 us [0xb3f59e98] pulse audio output debug: changed sample rate to 48092 Hz [0xb4d1f458] main decoder debug: removing module "subsdec" [0xb4d1f458] main decoder debug: killing decoder fourcc `subt', 0 PES in FIFO [0xb3f59e98] pulse audio output warning: too late by 99491 us [0xb3f59e98] pulse audio output debug: changed sample rate to 48138 Hz [0xb3f59e98] pulse audio output warning: too late by 113518 us [0xb3f59e98] pulse audio output debug: changed sample rate to 48184 Hz [0xb3f59e98] pulse audio output warning: too late by 116756 us [0xb3f59e98] pulse audio output debug: changed sample rate to 48230 Hz [0xb3f59e98] pulse audi</pre> Drew 2012-05-24T18:08:12 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13332 <pre>From: Peter Meerwald &lt;p.meerwald&lt; at &gt;bct-electronic.com&gt; --- src/modules/module-pipe-sink.c | 4 ++-- src/modules/module-pipe-source.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/modules/module-pipe-sink.c b/src/modules/module-pipe-sink.c index 91e01f9..fa0a080 100644 --- a/src/modules/module-pipe-sink.c +++ b/src/modules/module-pipe-sink.c &lt; at &gt;&lt; at &gt; -221,7 +221,7 &lt; at &gt;&lt; at &gt; finish: pa_log_debug("Thread shutting down"); } -int pa__init(pa_module*m) { +int pa__init(pa_module *m) { struct userdata *u; struct stat st; pa_sample_spec ss; &lt; at &gt;&lt; at &gt; -338,7 +338,7 &lt; at &gt;&lt; at &gt; int pa__get_n_used(pa_module *m) { return pa_sink_linked_by(u-&gt;sink); } -void pa__done(pa_module*m) { +void pa__done(pa_module *m) { struct userdata *u; pa_assert(m); diff --git a/src/modules/module-pipe-source.c b/src/modules/module-pipe-source.c index 3335907..eb531d8 100644 --- a/src/modules/module-pipe-source.c +++ b/src/modules/module-pipe-source.c &lt; at &gt;&lt; at &gt; -208,7 +208,7 &lt; at &gt;&lt; at &gt; finish: p</pre> Peter Meerwald 2012-05-24T15:52:55 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13330 <pre>Hello, I have a couple of issues with module-pipe: 1. module-pipe-source and module-pipe-sink do not check the return value ofmkfifo(), hence PulseAudio happily opens the same pipe several times I think PulseAudio should check if mkfifo() fails to create the FIFO file and abort -- see suggested patch in next mail 2. documentation at http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules#module-pipe-sink incorrectly states that the FIFO of module-pipe-sink defaults to /tmp/music.output, in fact it defaults to /tmp/pulse-xxxxxxxxx/fifo_output 3. module-pipe-source defaults to /tmp/music.input (as per documentation), but this is inconsistent with module-pipe-sink thoughts? regards, p. </pre> Peter Meerwald 2012-05-24T15:46:54 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13328 <pre>Hi folks, I've been thinking about this issue for a while and I'd like to share my thoughts and receive opinions back. While developing a PulseAudio driver for Wine, I ran into the issue of implementing the volume control interfaces. Microsoft's APIs allow the application to make calls that set the stream volume. However, the Windows 7 mixer /also/ allows the user to set stream volumes. These two volumes are entirely independent of each other. I think this makes complete sense. For example, you might have a music player which implements a crossfade between tracks. The obvious way to implement this to open two streams, and as the first stream reaches its last 5 seconds, you fade its volume down and simultaneously start and increase the volume for the second stream. The user can then set the music player's volume at 50% relative to their chat program, and everything works as expected. Crossfading in this manner works fine in PulseAudio, but it conflicts with the user's volume settings. When the music playe</pre> Andrew Eikum 2012-05-24T14:28:34 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13326 <pre>--- src/modules/module-loopback.c | 5 ++ src/pulse/channelmap.c | 2 + src/pulse/client-conf.c | 2 + src/pulse/context.c | 2 + src/pulse/ext-device-manager.c | 2 + src/pulse/ext-device-restore.c | 2 + src/pulse/ext-stream-restore.c | 2 + src/pulse/format.c | 2 + src/pulse/introspect.c | 2 + src/pulse/mainloop-api.c | 2 + src/pulse/mainloop-signal.c | 2 + src/pulse/mainloop.c | 2 + src/pulse/operation.c | 2 + src/pulse/proplist.c | 2 + src/pulse/sample.c | 2 + src/pulse/scache.c | 2 + src/pulse/stream.c | 2 + src/pulse/subscribe.c | 2 + src/pulse/thread-mainloop.c | 2 + src/pulse/timeval.c | 2 + src/pulse/utf8.c | 2 + src/pulse/util.c | 2 + src/pulse/volume.c | 2 + src/pulse/xmalloc.c | 2 + src/pulsecore/authkey.c | </pre> Deng Zhengrong 2012-05-24T13:46:40 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13320 <pre>These two patches add state change debug prints to sinks and sink-inputs. Jarkko Suontausta (2): core: Add functions that return the logical name of the state of sinks and sink inputs. core: Add debug prints for state changes in sinks and sink-inputs. src/pulsecore/sink-input.c | 5 +++++ src/pulsecore/sink-input.h | 12 ++++++++++++ src/pulsecore/sink.c | 6 ++++++ src/pulsecore/sink.h | 13 +++++++++++++ 4 files changed, 36 insertions(+), 0 deletions(-) </pre> Jarkko Suontausta 2012-05-24T10:43:24 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13312 <pre>Based on Coverity findings, the return values of pa_memblockq_push and pa_memblockq_push_align calls were not taken into account. These patches are addressing many of those cases by adding an assertion. Thanks to a thorough review of the first version, Tanu is already familiar with the patches. He had many good proposals for the remaining FIXME cases, but unfortunately I do not have time to address them now. Jarkko Suontausta (2): core: Assert on memchunk divisibility by sample spec in pa_memblockq_push(). modules, pulse, core: React to failing pa_memblockq_push calls. src/modules/echo-cancel/module-echo-cancel.c | 4 ++-- src/modules/module-combine-sink.c | 2 ++ src/modules/module-equalizer-sink.c | 4 ++-- src/modules/module-ladspa-sink.c | 2 +- src/modules/module-loopback.c | 1 + src/modules/module-virtual-sink.c | 2 +- src/modules/module-virtual-source.c | 2 +- src/modules/module-virtual-surround-sin</pre> Jarkko Suontausta 2012-05-24T07:38:21 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13311 <pre>I'm trying to understand how PulseAudio is supposed to work in my situation but I think I need some help: Basically my workstation is shared between 3 users who are always logged in (tho on different virtual consoles). Additionally, they all share a single (system-wide) MPD daemon to play the music. IIUC running a system-wide pulseaudio is the wrong thing to do. So I should run a PA daemon for each user. Somehow those PA daemons should figure out when we Ctl-Alt-Fn to switch from one virtual console to another and (re|dis)connect from the actual output sound driver. OK, I'm not sure this always works reliably, but assuming it does, how should the MPD daemon enter the picture? Clearly we don't want the music to be interrupted merely by someone switching virtual console. Stefan </pre> Stefan Monnier 2012-05-24T02:11:42 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13303 <pre> I am attaching 3 patches for consideration upstream: - pulseaudio-05-shm.diff The shm files on Solaris end up with a different name. This patch makes the code work on Solaris too. - pulseaudio-07-sada.diff Fixes to improve the SunAudio plugin so it works better. - pulsaudio-10-endian.diff On Sparc, WORDS_BIGENDIAN needs to get set if _BIG_ENDIAN is set. Brian --- pulseaudio-1.1/src/pulsecore/shm.c-orig2011-10-24 19:42:44.692685416 -0500 +++ pulseaudio-1.1/src/pulsecore/shm.c2011-10-24 20:24:30.605598557 -0500 &lt; at &gt;&lt; at &gt; -68,8 +68,13 &lt; at &gt;&lt; at &gt; * /dev/shm. We can use that information to list all blocks and * cleanup unused ones */ #define SHM_PATH "/dev/shm/" +#define SHM_ID_LEN 10 +#elif defined(__sun) +#define SHM_PATH "/tmp" +#define SHM_ID_LEN 15 #else #undef SHM_PATH +#define SHM_ID_LEN 0 #endif #define SHM_MARKER ((int) 0xbeefcafe) &lt; at &gt;&lt; at &gt; -359,10 +364,14 &lt; at &gt;&lt; at &gt; int pa_shm_cleanup(void) { char fn[128]; struct shm_marker *m; - if (strncmp(de-&gt;d_name, "pulse-shm-", 10)) +#</pre> Brian Cameron 2012-05-23T01:55:45 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13296 <pre>A new function was added to module.c to handle unload requests by name. The native protocol was extended and a new opcode was introduced, and finally pactl was extended to make use of the new functionality. PROTOCOL | 7 +++++++ configure.ac | 2 +- man/pactl.1.xml.in | 4 ++-- src/map-file | 2 ++ src/pulse/introspect.c | 31 ++++++++++++++++++++++++++++++- src/pulse/introspect.h | 12 +++++++++--- src/pulsecore/module.c | 11 +++++++++++ src/pulsecore/module.h | 1 + src/pulsecore/native-common.h | 5 ++++- src/pulsecore/protocol-native.c | 30 ++++++++++++++++++++++++++---- src/utils/pactl.c | 15 +++++++++++---- </pre> poljar 2012-05-22T16:06:11 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13295 <pre>Based on a patch by Marko Ollonen. --- src/modules/bluetooth/module-bluetooth-device.c | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c index 0b12cc7..68c4efc 100644 --- a/src/modules/bluetooth/module-bluetooth-device.c +++ b/src/modules/bluetooth/module-bluetooth-device.c &lt; at &gt;&lt; at &gt; -1731,11 +1731,18 &lt; at &gt;&lt; at &gt; static void thread_func(void *userdata) { pollfd-&gt;events = (short) (((u-&gt;sink &amp;&amp; PA_SINK_IS_LINKED(u-&gt;sink-&gt;thread_info.state) &amp;&amp; !writable) ? POLLOUT : 0) | (u-&gt;source &amp;&amp; PA_SOURCE_IS_LINKED(u-&gt;source-&gt;thread_info.state) ? POLLIN : 0)); - if ((ret = pa_rtpoll_run(u-&gt;rtpoll, TRUE)) &lt; 0) + if ((ret = pa_rtpoll_run(u-&gt;rtpoll, TRUE)) &lt; 0) { + pa_log_debug("pa_rtpoll_run failed with: %d", ret); goto fail; - - if (ret == 0) + } + if (ret == 0) { + pa_log_debug("IO t</pre> Jarkko Suontausta 2012-05-22T12:58:33 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13294 <pre>The PA_IDXSET_FOREACH is easier to read than the standard for loop. Also pa_streq() should be used for checking string equality. --- src/pulsecore/protocol-native.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/protocol-native.c b/src/pulsecore/protocol-native.c index c2d5fcf..f221d21 100644 --- a/src/pulsecore/protocol-native.c +++ b/src/pulsecore/protocol-native.c &lt; at &gt;&lt; at &gt; -4621,8 +4621,8 &lt; at &gt;&lt; at &gt; static void command_extension(pa_pdispatch *pd, uint32_t command, uint32_t tag, if (idx != PA_INVALID_INDEX) m = pa_idxset_get_by_index(c-&gt;protocol-&gt;core-&gt;modules, idx); else { - for (m = pa_idxset_first(c-&gt;protocol-&gt;core-&gt;modules, &amp;idx); m; m = pa_idxset_next(c-&gt;protocol-&gt;core-&gt;modules, &amp;idx)) - if (strcmp(name, m-&gt;name) == 0) + PA_IDXSET_FOREACH(m, c-&gt;protocol-&gt;core-&gt;modules, idx) { + if (pa_streq(name, m-&gt;name)) break; } </pre> poljar 2012-05-22T12:37:09 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13292 <pre>when i give command aplay gong.wav the file plays ok via bluetooth speaker, but i get to console: Playing WAVE 'gong.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo May 22 10:57:59 siika kernel: [27439.133117] input: 00:02:3C:30:37:DE as /devices/virtual/input/input28 May 22 10:57:59 siika pulseaudio[4416]: [pulseaudio] module.c: Failed to load module "module-bluetooth-device" (argument: "address="00:02:3C:30:37:DE" path="/org/bluez/2553/hci0/dev_00_02_3C_30_37_DE""): initialization failed. May 22 10:57:59 siika pulseaudio[4416]: [pulseaudio] module.c: Failed to load module "module-bluetooth-device" (argument: "address="00:02:3C:30:37:DE" path="/org/bluez/2553/hci0/dev_00_02_3C_30_37_DE""): initialization failed. May 22 10:57:59 siika pulseaudio[4416]: [pulseaudio] module.c: Failed to load module "module-bluetooth-device" (argument: "address="00:02:3C:30:37:DE" path="/org/bluez/2553/hci0/dev_00_02_3C_30_37_DE""): initialization failed. jh&lt; at &gt;siika:~$ May 22 10:58:04 siika rtkit-daemon[4418]: Succes</pre> Juha Heinanen 2012-05-22T08:04:56 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13287 <pre>Hi Col, According to your advice, I'm setting my blog up, to track my status and some thoughts during this GSoC project. The URL is http://zhengrong.wordpress.com I'll make everything related to PulseAudio into the category "PulseAudio", so hopefully it would only output the correct RSS. There's already one post there. :D --deng _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss&lt; at &gt;lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss </pre> rong deng 2012-05-21T15:45:08 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13282 <pre>- Add new API `pa_operation_set_cancel_callback` for users to set cancelation callbacks. --- src/pulse/context.c | 9 +++++++-- src/pulse/internal.h | 3 +++ src/pulse/operation.c | 25 ++++++++++++++++++++++++- src/pulse/operation.h | 7 +++++++ 4 files changed, 41 insertions(+), 3 deletions(-) diff --git a/src/pulse/context.c b/src/pulse/context.c index 4618635..1ce2738 100644 --- a/src/pulse/context.c +++ b/src/pulse/context.c &lt; at &gt;&lt; at &gt; -199,8 +199,13 &lt; at &gt;&lt; at &gt; static void context_unlink(pa_context *c) { s = n; } - while (c-&gt;operations) - pa_operation_cancel(c-&gt;operations); + while (c-&gt;operations) { + pa_operation *o = c-&gt;operations; + if (o-&gt;cancel_callback) + o-&gt;cancel_callback(o, o-&gt;cancel_userdata); + + pa_operation_cancel(o); + } if (c-&gt;pdispatch) { pa_pdispatch_unref(c-&gt;pdispatch); diff --git a/src/pulse/internal.h b/src/pulse/internal.h index c5bdcb1..c647c96 100644 --- a/src/pulse/internal.h +++ b/src/pulse/interna</pre> Favonia 2012-05-20T00:03:19 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13281 <pre>Date: Sat, 19 May 2012 10:03:01 +0200 The used command for fixing the script is the following. $ git grep sepera | cut --delimiter=: --fields=1 | xargs sed -i s,sepera,separa,g This patch is motivated by a patch in Debian from Martin-Éric Racine [1]. [1] http://anonscm.debian.org/gitweb/?p=pkg-pulseaudio/pulseaudio.git;a=commitdiff;h=70e7261a615141908c0cf366fd49e0fc0f550fbf --- I am not sure why just those eight translation files contain the incorrect spelled string and the others not. --- man/pulse-daemon.conf.5.xml.in | 2 +- po/as.po | 4 ++-- po/bn_IN.po | 4 ++-- po/gu.po | 4 ++-- po/hi.po | 4 ++-- po/ml.po | 4 ++-- po/pa.po </pre> Paul Menzel 2012-05-19T08:25:04 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13280 <pre>Hi, I just rebuilt PulseAudio 2.0 with latest systemd/udev git. It requires removing some deprecated functions. --- ./src/modules/module-udev-detect.c.orig 2012-03-01 02:02:19.000000000 -0700 +++ ./src/modules/module-udev-detect.c 2012-05-18 20:02:12.549056842 -0600 &lt; at &gt;&lt; at &gt; -123,7 +123,7 &lt; at &gt;&lt; at &gt; static char *card_get_sysattr(const char goto finish; } - t = pa_sprintf_malloc("%s/class/sound/card%s", udev_get_sys_path(udev), card_idx); + t = pa_sprintf_malloc("/sys/class/sound/card%s", card_idx); card = udev_device_new_from_syspath(udev, t); pa_xfree(t); &lt; at &gt;&lt; at &gt; -282,7 +282,7 &lt; at &gt;&lt; at &gt; static void verify_access(struct userdat pa_assert(u); pa_assert(d); - cd = pa_sprintf_malloc("%s/snd/controlC%s", udev_get_dev_path(u-&gt;udev), path_get_card_id(d-&gt;path)); + cd = pa_sprintf_malloc("/dev/snd/controlC%s", path_get_card_id(d-&gt;path)); accessible = access(cd, R_OK|W_OK) &gt;= 0; pa_log_debug("%s is accessible: %s", cd, pa_yes_no(accessible)); &lt; at &gt;&lt; at &gt; -621,7 +621,6 &lt; at &gt;&lt; at &gt;</pre> Kelly Anderson 2012-05-19T07:39:49 http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/13278 <pre>There was a race in the existing code that could cause the pa_once code to be run twice, see: http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-April/013354.html Therefore the existing implementation was rewritten to instead look like the reference implementation here: http://www.hpl.hp.com/research/linux/atomic_ops/example.php4 Signed-off-by: David Henningsson &lt;david.henningsson&lt; at &gt;canonical.com&gt; --- We had some discussion about this a little while ago, but no patch was merged, so the bug was left unfixed. If there are no objections I'll push this one. src/pulsecore/once.c | 43 +++++++++++++------------------------------ src/pulsecore/once.h | 8 ++++---- 2 files changed, 17 insertions(+), 34 deletions(-) diff --git a/src/pulsecore/once.c b/src/pulsecore/once.c index 4e509e0..30b35a6 100644 --- a/src/pulsecore/once.c +++ b/src/pulsecore/once.c &lt; at &gt;&lt; at &gt; -24,46 +24,33 &lt; at &gt;&lt; at &gt; #endif #include &lt;pulsecore/macro.h&gt; -#include &lt;pulsecore/mutex.h&gt; #include "once.h" +/* See http://www.hpl.hp.com/re</pre> David Henningsson 2012-05-18T20:43:45 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.audio.pulseaudio.general