gmane.org.wikimedia.mediawiki.codereview

[pywikipedia r10251]: New comment added

MediaWiki Mail — 2012-05-26T13:54:30

"Valhallasw" posted a comment on pywikipedia.r10251.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10251#c32828

Commit summary for pywikipedia.r10251:

Reverting my edit+disabling trailing feature for fa.wp+adding feature of changing trail to pipe if there is ZWNJ for fa.wp

Valhallasw's comment:

In addition, please actually remove code - don't comment it out. You can always retrieve the code by getting an earlier revision of the same file.

[pywikipedia r8679]: Revision status changed

MediaWiki Mail — 2012-05-26T13:04:28

"Xqt" changed the status of pywikipedia.r8679 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/8679

Old status:  new
New status: ok

Commit summary for pywikipedia.r8679:

If summary is more than 200 characters will be created copyright violation

[pywikipedia r10152]: Revision status changed

MediaWiki Mail — 2012-05-26T12:57:21

"Xqt" changed the status of pywikipedia.r10152 to "reverted"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10152

Old status:  fixme
New status: reverted

Commit summary for pywikipedia.r10152:

Adding categories sort for Persian Wikipedia

[pywikipedia r10251]: New comment added,and revision status changed

MediaWiki Mail — 2012-05-26T12:54:16

"Xqt" changed the status of pywikipedia.r10251 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10251#c32827

Old Status: new
New Status: fixme

Commit summary for pywikipedia.r10251:

Reverting my edit+disabling trailing feature for fa.wp+adding feature of changing trail to pipe if there is ZWNJ for fa.wp

Xqt's comment:

Pipes and link trails should be fixed in family.py file (self.linktrails) and must be the same as defined in setting in LanguageFa.php.

[MediaWiki r115395]: Revision status changed

MediaWiki Mail — 2012-05-26T07:16:34

"Krinkle" changed the status of MediaWiki.r115395 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115395

Old status:  new
New status: ok

Commit summary for MediaWiki.r115395:

Aligned the position

[MediaWiki r115385]: Revision status changed

MediaWiki Mail — 2012-05-26T07:16:17

"Krinkle" changed the status of MediaWiki.r115385 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115385

Old status:  new
New status: ok

Commit summary for MediaWiki.r115385:

changed the strings of status to lower case so that it better fit to text

[MediaWiki r114925]: Revision status changed

MediaWiki Mail — 2012-05-26T07:15:36

"Krinkle" changed the status of MediaWiki.r114925 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114925

Old status:  new
New status: deferred

Commit summary for MediaWiki.r114925:

Localisation updates from http://translatewiki.net.

[MediaWiki r115413]: Revision status changed

MediaWiki Mail — 2012-05-26T07:15:33

"Krinkle" changed the status of MediaWiki.r115413 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115413

Old status:  new
New status: deferred

Commit summary for MediaWiki.r115413:

Localisation updates from http://translatewiki.net.

[MediaWiki r115430]: Revision status changed

MediaWiki Mail — 2012-05-26T07:15:09

"Krinkle" changed the status of MediaWiki.r115430 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115430

Old status:  ok
New status: resolved

Commit summary for MediaWiki.r115430:

Cleaned up CSS and JavaScript

* Moved repeated CSS rules to a general stylesheet
* Fixed lots of whitespace issues
* Reorganized JS for performance and readability

[MediaWiki r115430]: Revision status changed

MediaWiki Mail — 2012-05-26T07:15:05

"Krinkle" changed the status of MediaWiki.r115430 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115430

Old status:  new
New status: ok

Commit summary for MediaWiki.r115430:

Cleaned up CSS and JavaScript

* Moved repeated CSS rules to a general stylesheet
* Fixed lots of whitespace issues
* Reorganized JS for performance and readability

[MediaWiki r115429]: Revision status changed

MediaWiki Mail — 2012-05-25T17:52:19

"Krinkle" changed the status of MediaWiki.r115429 to "new"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429

Old status:  fixme
New status: new

Commit summary for MediaWiki.r115429:

style of code

[MediaWiki r115428]: Revision status changed

MediaWiki Mail — 2012-05-25T17:51:15

"Krinkle" changed the status of MediaWiki.r115428 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115428

Old status:  new
New status: ok

Commit summary for MediaWiki.r115428:

removed old function we don't use

[MediaWiki r115433]: Revision status changed

MediaWiki Mail — 2012-05-25T17:50:47

"Krinkle" changed the status of MediaWiki.r115433 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115433

Old status:  new
New status: ok

Commit summary for MediaWiki.r115433:

stylize.php.

[MediaWiki r115434]: Revision status changed

MediaWiki Mail — 2012-05-25T17:48:29

"Krinkle" changed the status of MediaWiki.r115434 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115434

Old status:  new
New status: ok

Commit summary for MediaWiki.r115434:

Update indentation and some other coding style related thingies.

No functional changes. Ping r115429.

[MediaWiki r102566]: New comment added

MediaWiki Mail — 2012-05-25T14:05:31

"Mormegil" posted a comment on MediaWiki.r102566.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102566#c32826

Commit summary for MediaWiki.r102566:

Adding bt-button and rt-button to interface messages.

Mormegil's comment:

The more interesting thing is that the “donate_interface-rt-button” message is unterminated – it has mismatched quotation characters, beginning with a double quote, ending with a single quote. But then, “donate_interface-donor-legend” has the opposite problem, meaning to wrongs make a right, and everything is quite fine. :-)

(The message documentation has already been fixed using TranslateWiki.net.)

_______________________________________________
MediaWiki-CodeReview mailing list
MediaWiki-CodeReview< at >lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T14:05:27

"Petrb" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32825

Commit summary for MediaWiki.r115429:

style of code

Petrb's comment:

ah, I see, from guideline this isn't clear, the example there has lines so short that it actually seems to be aligned just as I did.

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T11:57:37

"Krinkle" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32824

Commit summary for MediaWiki.r115429:

style of code

Krinkle's comment:

[[CC|.. and the closing bracket should align]] with the opening statement.

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T11:56:21

"Krinkle" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32823

Commit summary for MediaWiki.r115429:

style of code

Krinkle's comment:

Nearly every line, actually.

I think the problem is that it appears you start counting the extra tab from roughly where the contents of the previous line ends (rather than where the indention of the previous line ends).

<pre>
+$foo = $bar->getOption(
+→→→→'Test',
+→→→→$example
+→→);
+$foo = $bar->baz->quux->getOption(
+→→→→→'Test',
+→→→→→$example
+→→);
</pre>

vs.
<pre>
+$foo = $bar->getOption(
+→'Test',
+→$example
+);
+$foo = $bar->baz->quux->getOption(
+→'Test',
+→$example
+);
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
MediaWiki-CodeReview< at >lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T09:06:03

"Petrb" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32822

Commit summary for MediaWiki.r115429:

style of code

Petrb's comment:

line?

[MediaWiki r115429]: New comment added,and revision status changed

MediaWiki Mail — 2012-05-25T07:45:36

"Nikerabbit" changed the status of MediaWiki.r115429 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32821

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r115429:

style of code

Nikerabbit's comment:

I think style guideline says to use one tab for one level of indentation, not six.

[MediaWiki r105406]: Revision status changed

MediaWiki Mail — 2012-05-25T01:07:27

"Krinkle" changed the status of MediaWiki.r105406 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105406

Old status:  deferred
New status: ok

Commit summary for MediaWiki.r105406:

fix for onlinestatusbar ajax loader:
* since we're building HTML text, use mw.html.element() to build source instead of $('<img>') to build a DOM element
* break a couple things up into multiple lines to make them easier to read/maintain
* use wgExtensionAssetsPath rather than wgScriptPath to ensure this'll work on configs like Wikimedia's where the assets are loaded from another domain