gmane.network.wireshark.devel

Commit 49949 broke packet_win.c

Joerg Mayer — 2013-06-19T02:00:51

for WANT_PACKET_EDITOR:

In file included from /home/jmayer/work/wireshark/svn/trunk/wiretap/wtap.h:32:0,
                 from /home/jmayer/work/wireshark/svn/trunk/epan/nstime.h:30,
                 from /home/jmayer/work/wireshark/svn/trunk/epan/frame_data.h:30,
                 from /home/jmayer/work/wireshark/svn/trunk/epan/epan.h:32,
                 from /home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:44:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c: In function ‘finfo_window_refresh’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:251:35: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
   data = buffer_start_ptr(&DataPtr->buf) + DataPtr->start_offset + old_finfo->start;
                                   ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:37: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:251:35: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
   data = buffer_start_ptr(&DataPtr->buf) + DataPtr->start_offset + old_finfo->start;
                                   ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:54: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                                      ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:261:35: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
   data = buffer_start_ptr(&DataPtr->buf) + DataPtr->start_offset + old_finfo->appendix_start;
                                   ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:37: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:261:35: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
   data = buffer_start_ptr(&DataPtr->buf) + DataPtr->start_offset + old_finfo->appendix_start;
                                   ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:54: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                                      ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:271:66: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  epan_dissect_run(&edt, &DataPtr->phdr, buffer_start_ptr(&DataPtr->buf), DataPtr->frame, NULL);
                                                                  ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:37: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:271:66: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  epan_dissect_run(&edt, &DataPtr->phdr, buffer_start_ptr(&DataPtr->buf), DataPtr->frame, NULL);
                                                                  ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:54: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                                      ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c: In function ‘finfo_integer_common’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:298:40: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  guint8 *pd = buffer_start_ptr(&DataPtr->buf);
                                        ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:37: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:298:40: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  guint8 *pd = buffer_start_ptr(&DataPtr->buf);
                                        ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:54: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                                      ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c: In function ‘finfo_string_changed’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:342:40: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  guint8 *pd = buffer_start_ptr(&DataPtr->buf);
                                        ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:37: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:342:40: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  guint8 *pd = buffer_start_ptr(&DataPtr->buf);
                                        ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:54: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                                      ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c: In function ‘finfo_bv_key_pressed_cb’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:433:37: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  data.pd = buffer_start_ptr(&DataPtr->buf);
                                     ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:37: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:433:37: error: ‘struct FieldinfoWinData’ has no member named ‘buf’
  data.pd = buffer_start_ptr(&DataPtr->buf);
                                     ^
/home/jmayer/work/wireshark/svn/trunk/wiretap/buffer.h:58:54: note: in definition of macro ‘buffer_start_ptr’
 # define buffer_start_ptr(buffer) ((buffer)->data + (buffer)->start)
                                                      ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c: In function ‘edit_pkt_common_key_pressed_cb’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:771:72: error: invalid operands to binary & (have ‘Buffer’ and ‘int’)
     DataPtr->pd[DataPtr->pd_offset] = (DataPtr->pd[DataPtr->pd_offset] & 0x0f) | (val << 4);
                                                                        ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:774:72: error: invalid operands to binary & (have ‘Buffer’ and ‘int’)
     DataPtr->pd[DataPtr->pd_offset] = (DataPtr->pd[DataPtr->pd_offset] & 0xf0) | val;
                                                                        ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:793:37: error: invalid operands to binary | (have ‘Buffer’ and ‘int’)
     DataPtr->pd[DataPtr->pd_offset] |= (1 << (7-DataPtr->pd_bitoffset));
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:795:37: error: invalid operands to binary & (have ‘Buffer’ and ‘int’)
     DataPtr->pd[DataPtr->pd_offset] &= ~(1 << (7-DataPtr->pd_bitoffset));
                                     ^
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c: In function ‘edit_pkt_win_key_pressed_cb’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/packet_win.c:829:10: error: assignment from incompatible pointer type [-Werror]
  data.pd = buffer_start_ptr(&DataPtr->buf);
          ^
cc1: all warnings being treated as errors
make[2]: *** [ui/gtk/CMakeFiles/gtkui.dir/packet_win.c.o] Error 1

"Type-punned pointer... breaks anti-aliasing rules" in dfilter-macro.c

Stephen Fisher — 2013-06-18T23:14:54

When trying to compile Wireshark (SVN trunk) on FreeBSD for the first time in a long time, I ran across a familiar error:

    dfilter-macro.c: In function 'dfilter_macro_init':
    dfilter-macro.c:614: warning: dereferencing type-punned pointer will break strict-aliasing rules

However, line 614 has a history of being changed between this:

    (void*) &macros,

and this (as it currently is):

    (void**) &macros,

Which is the fifth parameter in a call to uat_new() where parameter five's type is "void** data_ptr" and macros is type dfilter_macro_t*.  

This was most recently changed with SVN revision 48355 that Anders committed in response to bug 8416 ("remove C++ incompatibilities") according to the SVN log.  Before that, judging by the "svn annotate" output in Emacs of a few lines earlier, I changed it from (void**) to (void*) way back in 2007 as SVN revision 21330 to "Fix warnings on Linux/gcc 4.1.1" and it may have changed at other times as well.

What should the fix ultimately be if one way breaks FreeBSD/gcc 4.2.1 compiles and if it introduces C++ compatibility issues (which I'm not familiar with since I haven't been following development for a while lately).       
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

Wmem has reached feature-parity with emem

Evan Huus — 2013-06-18T21:54:38

As per the subject, as of revision 50020.

If I've missed an API somewhere please let me know, but as far as I
can tell every function defined in emem.h has a wmem equivalent.

This means that unless there are any objections, emem is now
deprecated. New code should only use wmem.

Most of the APIs are fairly similar, and doc/README.wmem provides a
good overview of how wmem differs from emem and how to use it. I'm
sure there are things I've missed or explained poorly, so please feel
free to email if you have any questions after reading the docs.

I will start converting existing emem calls to wmem - I expect most of
it will be regexable.

Cheers,
Evan
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

how does cmake know how to generate plugin.c

Dirk Jagdmann — 2013-06-18T19:34:08

I'm studying cmake rules in the plugin/ directory. I can not find out, 
how cmake knows how to build the plugin.c file for each of the plugins. 
Where is this defined?

cast errors reported by a OsX cmake build

Dirk Jagdmann — 2013-06-18T00:22:41

I just tried to use cmake to build current Wireshark SVN trunk source 
code. It fails early on with errors like:


[  5%] Building C object tools/lemon/CMakeFiles/lemon.dir/lemon.c.o
/Users/djagdmann/ws-trunk/trunk/tools/lemon/lemon.c:443:8: error: cast 
from 'char *' to 'struct action *' increases required
       alignment from 1 to 8 [-Werror,-Wcast-align]
   ap = (struct action *)msort((char *)ap,(char **)&ap->next,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/djagdmann/ws-trunk/trunk/tools/lemon/lemon.c:457:24: error: cast 
from 'char *' to 'struct state *' increases required
       alignment from 1 to 8 [-Werror,-Wcast-align]
     newaction->x.stp = (struct state *)arg;

and many more of this type. Is somebody looking into cmake builds on OsX?

Running BPF filters on raw packet data (no devices)

Gal Sagie — 2013-06-16T17:05:49

Hello,

I want to achieve the following :

1) I have a raw packet buffer, i want to search if they match a certain BPF
filter (i dont care about the device or how i received this packet buffer)
just want
   to know it match or doesn't match.

The code i tried :

   1.  pkt = pointer to packet data
   2.         char errbuf[PCAP_ERRBUF_SIZE];
   3.         pcap_t* pc = pcap_create("any",&errbuf);
   4.         int active = pcap_activate(pc);
   5.
   6.         struct bpf_program fp;
   7.         int res = pcap_compile(pc,&fp,"ip",0,0);
   8.
   9.         struct pcap_pkthdr hdr;
   10.         memset(&hdr,0,sizeof(hdr));
   11.         hdr.caplen = pkt->pkt_len;
   12.         hdr.len = pkt->pkt_len;
   13.
   14.         u_char* data = (unsigned char *)pkt->data
   15.
   16.        int match = pcap_offline_filter(&fp, &hdr ,data);
   17.        printf("Packet Match = %d\r\n",match);


   That doesn't work.... (it doesn't fail but return "0" on match every
   time even that the packet is IP packet as i debugged it)

   Any ideas ? what am i doing wrong? or how else can i achieve the same
   results?
   Thanks in advance!

   Gal.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

It would be useful to be able to sum a column, and get mean, variance, etc

Richard Sharpe — 2013-06-16T03:01:42

Hi folks,

It would be useful to be able to sum columns with the appropriate
type, like smb.time. It would also be useful to be able to display
things like max, min, average, variance, median, etc.

Anyone feel like adding such support?

New Defects reported by Coverity Scan for Wireshark(forw)

Joerg Mayer — 2013-06-14T12:32:02

Hi,

I'm receiving coverity reports via email. Unfortunately I don't really have
the time to look at them most of the time.
What I might do if there is interest in it: I could open a bug for each
dissector and copy the contents into the bug.

Opinions?

Ciao
     Jörg

smb.time || smb2.time is valid in a filter string but not in a custom column field?

Richard Sharpe — 2013-06-14T00:16:29

Hi folks,

I thought I would try to work around my issue with smb.time vs
smb2.time by using a custom column field and putting in an expression,
but it seems not to work. An expression that is acceptable in the
Filter field is not acceptable in a custom column.

Why is this?

smb2_time considered bad ...

Richard Sharpe — 2013-06-13T23:54:50

Hi folks,

I found out today that the time from request field is named
differently for packet_smb.c and packet_smb2.c.

This seems like a bad idea. I like to have that column displayed
pretty much all the time, regardless of whether the capture contains
SMB1 or SMB2 traffic.

Jurassic packets

Gerald Combs — 2013-06-13T18:09:51

For Monday's Sharkfest keynote I wanted to show everyone what things
looked like back in the early days of the project. After doing
unspeakable things to a Red Hat 6.2 VM I managed to get a copy of
Ethereal 0.2.0 up and running. Screenshot attached.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

Wireshark and tshark show different data for the smb.file field for certain files

Richard Sharpe — 2013-06-12T20:04:28

Hi folks,

I have a capture file with some weird file names in SMB requests.
Wireshark shows them as this:

\\somewhere\\eng\\Project\\HZX - City of
SomePlace\\xxxxyyyyzzz\\Planning-study\\Reports\\UNC\\somecmpy.com\\csfile\\eng\\Project\\HZX
- City of SomePlace\\xxxxyyyyzzz

This appears to be correct because I see that same data in the data pane.

However, tshark shows this:

\\somewhere\\eng\\Project\\HZX - City of
SomePlace\\xxxxyyyyzzz\\Planning-study\\Reports\\UNC

Now, there are longer file paths that tshark shows, so it is not
truncating. it seems to object to the component after the UNC string
and stops there.

Has anyone seen this?

Wireshark version 1.8.6. tshark version 1.10.0 (Copyright 1998-2013)

GTK warnings with 1.10.0

Stig Bjørlykke — 2013-06-07T07:44:22

Hi.

I'm getting this GTK warnings when setting a capture filter (Edit
Interface Settings) on a device from the welcome page:

(wireshark:30153): GLib-GObject-CRITICAL **: gpointer
g_object_get_data(GObject *, const gchar *): assertion `G_IS_OBJECT
(object)' failed
(wireshark:30153): Gtk-CRITICAL **: void
gtk_toggle_button_set_active(GtkToggleButton *, gboolean): assertion
`GTK_IS_TOGGLE_BUTTON (toggle_button)' failed
(wireshark:30153): GLib-GObject-CRITICAL **: gpointer
g_object_get_data(GObject *, const gchar *): assertion `G_IS_OBJECT
(object)' failed
(wireshark:30153): Gtk-CRITICAL **: void
gtk_combo_box_text_insert_text(GtkComboBoxText *, gint, const gchar
*): assertion `GTK_IS_COMBO_BOX_TEXT (combo_box)' failed
(wireshark:30153): GLib-GObject-CRITICAL **: gpointer
g_object_get_data(GObject *, const gchar *): assertion `G_IS_OBJECT
(object)' failed
(wireshark:30153): Gtk-CRITICAL **: void
gtk_combo_box_set_active(GtkComboBox *, gint): assertion
`GTK_IS_COMBO_BOX (combo_box)' failed

Misaligned columns in hex dump pane with Wireshark 1.10.0rc2 and GTK+ 2.12.0

Reinhard Speyerer — 2013-06-04T20:06:05

Hi,

I noticed today that columns in the hex dump pane are misaligned when
using wireshark 1.10.0rc2 built with the following configuration

Compiled (32-bit) with GTK+ 2.12.0, with Cairo 1.4.10, with Pango 1.18.2, with
GLib 2.14.1, with libpcap, with libz 1.2.3, without POSIX capabilities, without
libnl, without SMI, without c-ares, without ADNS, with Lua 5.1, without Python,
with GnuTLS 1.6.1, with Gcrypt 1.2.4, without Kerberos, without GeoIP, without
PortAudio, with AirPcap.

Running on Linux 2.6.22.5-31-bigsmp, with locale en_US, with libpcap version
0.9.7, with libz 1.2.3, GnuTLS 1.6.1, Gcrypt 1.2.4, without AirPcap.

Built using gcc 4.2.1 (SUSE Linux).

while they are aligned OK when using Wireshark 1.8.7 built on the same system

Compiled (32-bit) with GTK+ 2.12.0, with Cairo 1.4.10, with Pango 1.18.2, with
GLib 2.14.1, with libpcap, with libz 1.2.3, without POSIX capabilities, without
SMI, without c-ares, without ADNS, with Lua 5.1, without Python, with GnuTLS
1.6.1, with Gcrypt 1.2.4, without Kerberos, without GeoIP, without PortAudio,
with AirPcap.

Running on Linux 2.6.22.5-31-bigsmp, with locale en_US, with libpcap version
0.9.7, with libz 1.2.3, GnuTLS 1.6.1, Gcrypt 1.2.4, without AirPcap.

Built using gcc 4.2.1 (SUSE Linux).

In my preferences I use the default font (Monospace 10).

Has anybody else also observed this behaviour?

Regards,
Reinhard
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

1.8 to 1.10 API compatibility report

Gerald Combs — 2013-06-04T15:55:15

In case anyone is interested I ran an API compatibility report between
the current 1.8 and 1.10 branches. The results are available at


http://www.wireshark.org/download/automated/analysis/compat_report_1.8_to_1.10/
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

Reassembly Lengths

Evan Huus — 2013-06-02T21:44:52

Does anybody know why reassembling n packets each of payload-length m
might result in a reassembled packet of length less than n*m?

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8717

Removing the use of tvb_get_ptr would `fix` the problem in that it
would just throw an exception rather than blowing up, but that doesn't
explain why the reassembled packet seems too short in the first
place...

Thanks,
Evan
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

GTPV2 packets in GPRS Tunneling protocol

Manish Kumar — 2013-06-02T16:01:09

Hi All,

I am a beginner to wireshark development. I want to add a small filter
related to small information contained in GTPV2 packets. Can any one guide
me how to go about this.

Which one is the main file in the whole code through I can browse the code.
Any help will be appreciated.

Regards,
Manish
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

typo in the Developer manual

Ran Proshan — 2013-06-02T13:21:55

Hi,



You probably know this already, but just in case you don't, there's a typo in the Wireshark Developer's Guide on page 3 section 1.4:



[cid:image001.jpg-YuZP9JGQ4ugV00ceL2X1bTRmByFHzeGd< at >public.gmane.org]


RAN PROSHAN



___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

small randpkt issue (?)

Toralf Förster — 2013-06-01T19:01:58

While running the test suite I updated the wireshark sources in another terminal and recompiled it.
The test suite failed - ofc.
What let me wonder is however the error message about the "mv" command.

...
Pass 2:
    arp: (-nVxr) (-nr)  OK
    bgp: (-nVxr) (-nr)  OK
    bvlc: (-nVxr) (-nr)  OK
    dns: (-nVxr) (-nr)  OK
    eth: (-nVxr) (-nr)  OK
    fddi: (-nVxr) (-nr)  OK
    giop: (-nVxr) (-nr)  OK
    icmp: (-nVxr) (-nr) mv: ‘/tmp/randpkt-2013-06-01-6259.pcap’ and ‘/tmp/randpkt-2013-06-01-6259.pcap’ are the same file
  Output file: /tmp/randpkt-2013-06-01-6259.pcap

 ERROR
Processing failed. Capture info follows:

  Input file: 
stderr follows:

Input file: 

Build host information:
Linux n22 3.9.4 #20 SMP Tue May 28 20:18:57 CEST 2013 i686 Intel(R) Core(TM) i5-2540M CPU < at > 2.60GHz GenuineIntel GNU/Linux
LSB Version:    n/a
Distributor ID: Gentoo
Description:    Gentoo Base System release 2.2
Release:        2.2
Codename:       n/a

Return value:  127

Dissector bug:  0

Valgrind error count: 



Subversion revision
------------------------------------------------------------------------
r49680 | guy | 2013-06-01 20:38:36 +0200 (Sat, 01 Jun 2013) | 2 lines

More constification.

------------------------------------------------------------------------


Command and args: ./tshark -nr

/home/tfoerste/devel/wireshark/.libs/tshark: error while loading shared libraries: libwireshark.so.0: cannot open shared object file: No such file or directory

epan/dissectors/dcerpc/idl2wrs.c?

Guy Harris — 2013-06-01T22:03:26

Is that a functional translator from some flavor of DCE RPC IDL (OSF, Microsoft, Samba PIDL) to a Wireshark dissector?

If the IDL is PIDL, is it better than Samba's translator, inferior to Samba's translator, or none of the above?

Should we be building it with the autotools and with MSVC++, or should we leave it out of the CMake build?  (I see no point in building it with some of those but not others.)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe

Data (dissector) payload

2013-05-31T18:16:48

Bug 8741 contains the UDT dissector, which is a UDP protocol that may carry its own payload.  The (new-style) dissector was explicitly calling the data dissector and returning the full tvb length.  I thought one of the benefits of the new-style dissectors was that the "parent" dissector could see that the tvb wasn't fully dissected.  And if it wasn't fully dissected, the parent could try to dissect the rest (which would probably just end up in calling the data dissector).  This would lessen the burder on the parent's payload dissector to make sure the full tvb was dissected (if it didn't need to be).

So is there a bug in the UDP dissector (in decode_udp_ports), that it's not calling the data dissector is there is data remaining on the tvb?  Or should all UDP protocols have to explicitly get a handle to the data dissector to call it?  Was this functionality waiting on all dissectors to be converted to the "new style"?
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request-IZ8446WsY0/dtAWm4Da02A< at >public.gmane.org?subject=unsubscribe