http://blog.gmane.org/gmane.lisp.editors.hints.devel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.lisp.editors.hints.devel/36 <pre>The patch below adds support for cmucl/unicode. This basically adds an implementation of %make-readtable-iterator, updates %clear-readtable for cmucl (like sbcl), a fix for %get-dispatch-macro-character, a fix for %get-macro-character (like allegro). With these changes (and a small change in named-readtables.lisp that has already been mentioned by Stas Boukarev last month. With these changes cmucl passes all 36 of the tests. Oh, one thing. I noticed that in %clear-readtable, the last sexp is #+common-lisp. CMUCL has the :common-lisp feature, so the table is set twice. Perhaps this is oversight and the reader conditional should be #-(or allegro sbcl cmu)? Ray Change log: * Add implementation of %make-readtable-iterator for cmucl/unicode. * Implement %clear-readtable for cmucl. * Make %get-dispatch-macro-character return NIL where cmucl actually has #'lisp::dispatch-char-error. It seems named-readtables wants this. * Update %get-macro-character for cmucl, which behaves like allegro here. diff -u --recursive ./cruft.lisp /Volumes/share2/src/sourceforge/matlisp/matlisp-cvs/lib-src/named-readtables-0.9/cruft.lisp --- ./cruft.lisp 2009-10-10 04:19:32.000000000 -0400 +++ /Volumes/share2/src/sourceforge/matlisp/matlisp-cvs/lib-src/named-readtables-0.9/cruft.lisp 2011-01-28 00:49:30.000000000 -0500 &lt; at &gt;&lt; at &gt; -235,8 +235,55 &lt; at &gt;&lt; at &gt; subch-fn)))))))) #'grovel-macro-chars))) +;; This really only needed for CMUCL with unicode support. Without +;; unicode, the default implementation is probably fast enough. +#+(and cmu unicode) +(defun %make-readtable-iterator (readtable) + (let ((char-macro-ht (lisp::character-macro-hash-table readtable)) + (dispatch-tables (lisp::dispatch-tables readtable)) + (char-code 0)) + (with-hash-table-iterator (ht-iterator char-macro-ht) + (labels ((grovel-base-chars () + (if (&gt;= char-code lisp::attribute-table-limit) + (grovel-unicode-chars) + (let* ((char (code-char (shiftf char-code (1+ char-code)))) + ;; Need %get-macro-character here, not + ;; get-macro-character because we want NIL + ;; to be returned instead of + ;; #'lisp::read-token. + (reader-fn (%get-macro-character char readtable))) + (if reader-fn + (yield char reader-fn) + (grovel-base-chars))))) + (grovel-unicode-chars () + (multiple-value-bind (more? char reader-fn) + (ht-iterator) + (if (not more?) + (values nil nil nil nil nil) + (yield char reader-fn)))) + (yield (char reader-fn) + (let ((disp-ht)) + (cond + ((setq disp-ht (cdr (assoc char dispatch-tables))) + (let ((disp-fn (get-macro-character char readtable)) + (sub-char-alist)) + (if (&lt; (char-code char) lisp::attribute-table-limit) + (let ((disp (lisp::char-dispatch-table-table disp-ht))) + (dotimes (k lisp::attribute-table-limit) + (let ((f (aref disp k))) + (unless (eq f #'lisp::dispatch-char-error) + (push (cons (code-char k) f) + sub-char-alist))))) + (let ((disp-ht (lisp::char-dispatch-table-hash-table disp-ht))) + (maphash (lambda (k v) + (push (cons k v) sub-char-alist)) + disp-ht))) + (values t char disp-fn t sub-char-alist))) + (t + (values t char reader-fn nil nil)))))) + #'grovel-base-chars)))) -#-(or sbcl clozure allegro) +#-(or sbcl clozure allegro (and cmu unicode)) (eval-when (:compile-toplevel) (let ((*print-pretty* t)) (simple-style-warn &lt; at &gt;&lt; at &gt; -246,7 +293,7 &lt; at &gt;&lt; at &gt; On Unicode-aware implementations this may come with some costs.~&lt; at &gt;:&gt;" (package-name '#.*package*) (lisp-implementation-type)))) -#-(or sbcl clozure allegro) +#-(or sbcl clozure allegro (and cmu unicode)) (defun %make-readtable-iterator (readtable) (check-type readtable readtable) (let ((char-code 0)) &lt; at &gt;&lt; at &gt; -325,6 +372,11 &lt; at &gt;&lt; at &gt; (do-readtable (char readtable) (set-syntax-from-char char #\A readtable)) (setf (sb-impl::dispatch-tables readtable) nil)) + #+:cmu + (prog1 readtable + (do-readtable (char readtable) + (set-syntax-from-char char #\A readtable)) + (setf (lisp::dispatch-tables readtable) nil)) #+ :allegro (prog1 readtable (do-readtable (char readtable) &lt; at &gt;&lt; at &gt; -343,17 +395,28 &lt; at &gt;&lt; at &gt; "Ensure ANSI behaviour for GET-DISPATCH-MACRO-CHARACTER." #+ :ccl (ignore-errors (get-dispatch-macro-character char subchar rt)) - #+ :common-lisp (get-dispatch-macro-character char subchar rt)) + #+cmu + (let ((f (get-dispatch-macro-character char subchar rt))) + ;; CMUCL returns #'lisp::dispatch-char-error, and named-readtables + ;; wants nil in those cases. + (unless (eq f #'lisp::dispatch-char-error) + f)) + #-(or :ccl :cmu) (get-dispatch-macro-character char subchar rt)) ;;; Allegro stores READ-TOKEN as reader macro function of each -;;; constituent character. +;;; constituent character. CMUCL does the same. (define-cruft %get-macro-character (char rt) "Ensure ANSI behaviour for GET-MACRO-CHARACTER." #+ :allegro (let ((fn (get-macro-character char rt))) (cond ((not fn) nil) ((function= fn #'excl::read-token) nil) (t fn))) - #+ :common-lisp (get-macro-character char rt)) + #+cmu + (let ((fn (get-macro-character char rt))) + (cond ((not fn) nil) + ((function= fn #'lisp::read-token) nil) + (t fn))) + #-(or :allegro cmu) (get-macro-character char rt)) </pre> Raymond Toy 2011-01-28T06:07:15 http://comments.gmane.org/gmane.lisp.editors.hints.devel/35 <pre> I ran into a problem with SLIME where I was getting errors the second time I would compile a buffer with contents such as the following: (cl:eval-when (:compile-toplevel :load-toplevel :execute) (ql:quickload 'named-readtables)) (defpackage #:reader-macro-test (:use #:cl)) (in-package #:reader-macro-test) (eval-when (:compile-toplevel :load-toplevel :execute) (named-readtables:defreadtable readtable-test (:merge :standard))) (named-readtables:in-readtable readtable-test) It turns out that the problem has to do with the way SLIME deals with the style-warning that the defreadtable gives about overwriting the existing readtable. The defreadtable form clears out the bindings for the existing reader, then issues the warning. SLIME parses the buffer and picks up that we're in the #:reader-macro-test package and sets *readtable* to be the readtable that we've just clobbered and then in SLIMEs error/warning handling code it further frobs (a copy of) the (now empty-ish) readtable and then attempts to read using that readtable and fails. Tobias rightly points out that SLIME should have better support for named-readtables. It also seems to me that SLIME might want to make greater assurances about the state of the reader in its error handling code. But the simple, expedient fix is: --- named-readtables.lisp2011-01-27 09:14:38.000000000 -0800 +++ /Users/sly/quicklisp/dists/quicklisp/software/named-readtables-20101006-darcs/named-readtables.lisp2011-01-27 13:36:53.000000000 -0800 &lt; at &gt;&lt; at &gt; -132,9 +132,9 &lt; at &gt;&lt; at &gt; (cond ((not readtable) (setq readtable (make-readtable ',name))) (t - (setq readtable (%clear-readtable readtable)) (simple-style-warn "Overwriting already existing readtable ~S." - readtable))) + readtable) + (setq readtable (%clear-readtable readtable)))) ,&lt; at &gt;(loop for option in merge-clauses collect (process-option option 'readtable)) ,&lt; at &gt;(loop for option in case-clauses Explicit SLIME support for named-readtables would be great, but, in the meantime, it would be nice to see this in the named-readtables source. Thanks, Cyrus </pre> Cyrus Harmon 2011-01-27T21:41:30 http://comments.gmane.org/gmane.lisp.editors.hints.devel/34 <pre>The default value of error-p optional parameter for excl:named-readtable was changed to T in Allegro 8.2, which causes errors whenever find-readtable is called on non existent readtable. CMUCL has an issue with ordering of loop initializations in the loop of define-api macro. And the spec is quite confusing on how it really should behave. The workaround is to use (progn x (loop ...)) instead of (loop initially x ...) </pre> Stas Boukarev 2010-12-09T10:09:43 http://comments.gmane.org/gmane.lisp.editors.hints.devel/33 <pre> luis/lichtblau, Wrt our discussion on yesterday's evening, I think that REGISTER-DOCUMENTATION should probably become a macro which expands to symbols in *PACKAGE* only -- in particular, it does not expand to symbols from the HYPERDOC package so not to impose a runtime dependency. Essentially that is to restore to the old ways of doing things -- although the API has changed somewhat. I didn't (and still don't) like the set-some-magic-variables way as an _interface_ which was the reason I came up with REGISTER-DOCUMENTATION. It seems to be the right implementation choice, though. Are you d'accord? -T. </pre> Tobias C. Rittweiler 2009-12-09T08:19:30 http://comments.gmane.org/gmane.lisp.editors.hints.devel/32 <pre> The [editor-hints] project is pleased to announce _Named Readtables_. What are Named Readtables? It's a library a) to help you to organize your readtable hacks, and b) to help your development environment to deal with these hacks. For detailed information see [What are Named-Readtables?] in the documentation. Foretaste DEFREADTABLE (analogously to DEFPACKAGE) can be used to specify the content of a readtable. IN-READTABLE (analogously to IN-PACKAGE) can be used to specify what readtable should be used while compiling a .lisp file. Named-Readtables has an API very much inspired by the existing API of packages. But see [Important API idiosyncrasies] in the documentation. Documentation See [Named-Readtables Documentation]. Download darcs get http://common-lisp.net/project/editor-hints/darcs/named-readtables/ Release Notes The release was tagged as 0.9 even though it's actually pretty much a 1.0. Experience tells that no matter how much you try to polish a piece of software, there will be two to three issues. The 1.0 will wait for these issues be reported. Implementations The library has been tested on SBCL, CCL, Clisp, ABCL (head), ECL, Allegro 8.1, Lispworks 5.1. Links [editor-hints] http://common-lisp.net/project/editor-hints/ [Named-Readtables Documentation] http://common-lisp.net/project/editor-hints/darcs/named-readtables/doc/named-readtables.html [What are Named-Readtables?] http://common-lisp.net/project/editor-hints/darcs/named-readtables/doc/named-readtables.html#what_are_named-readtables? [Important API idiosyncrasies] http://common-lisp.net/project/editor-hints/darcs/named-readtables/doc/named-readtables.html#important_api_idiosyncrasies </pre> Tobias C. Rittweiler 2009-10-10T10:29:52 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.lisp.editors.hints.devel