gmane.lisp.clx.devel

trivial-features, CLX and SBCL mutual incompatibility

Cyrus Harmon — 2011-02-18T21:40:06

Forgive me if you've heard me rant about this before, but there is a mutual incompatibility between CLX, trivial-features (which, for me at least, gets pulled in whenever I try to use CFFI) and SBCL. The problem is that trivial-features puts :little-endian on *features* and CLX has the following code in defdeps.lisp:

#+(or lispm vax little-endian Minima)
(eval-when (eval compile load)
  (pushnew :clx-little-endian *features*))

These old-style eval-when conditions cause SBCL to issue a warning, which causes ASDF to stop compiling CLX. There are many workarounds to this, such as loading CLX before CFFI and there are many possible fixes (such as making SBCL less pedantic or making ASDF not stop on warnings of this kind, etc...) But it seems to me that either fixing the CLX source code such that it is more tolerant of SBCL's pedantry or, alternatively, picking less common names for the *features* in trivial-features would be a good thing. I don't really have a preference, but it would be nice if the CLX and trivial-features maintainers would play nice with each other such that, at least when using SBCL, one can load trivial-features and then CFFI.

I'm certainly open to other suggestions, but I've grown tired of working around this particular problem.

thanks,

Cyrus

get-best-authorization and localhost/unix:0

Raymond Toy — 2010-11-16T18:40:10

Ran into the following issue with the current clx (running on cmucl).
On my linux system, the xauth file (created by the system, not me) has
only one entry for localhost/unix:0.  When I try to open-clx-display, it
fails because get-best-authorization can't find the authorization data.
 The problem is that when the protocol is :local, get-best-auth looks up
the hostname and sets host-address to that.  The hostname isn't
"localhost", so nothing matches.

Here is a proposed patch.  The patch works for me, but I'm not sure if
it is the right thing to do.  Basically, in addition to matching
host-address to the xauth address, if the protocol is :local, allow a
match with "localhost".

Ray



Index: display.lisp
===================================================================
RCS file: /project/cmucl/cvsroot/src/clx/display.lisp,v
retrieving revision 1.15
diff -u -r1.15 display.lisp
--- display.lisp13 Jul 2009 13:54:35 -00001.15
+++ display.lisp16 Nov 2010 18:38:16 -0000
< at >< at > -117,7 +117,9 < at >< at >
  (read-xauth-entry stream)
        (unless family (return))
        (when (and (eql family protocol)
-  (equal host-address address)
+  (or (equal host-address address)
+      (and (eql protocol :local)
+   (equal "localhost" address)))
   (= number display)
   (let ((pos1 (position name *known-authorizations*
 :test #'string=)))