gmane.lisp.cclan.general

[PATCH] COMPONENT-DEPENDS-ON and operation subclasses

Richard M Kreuter — 2008-11-07T14:31:09

Hello, The method of COMPONENT-DEPENDS-ON specializing on OPERATION and COMPONENT doesn't do what I'd expect when the operation is an indirect instance of an operation class in a component's IN-ORDER-TO slot. Here's an example involving two SBCL contribs with an inter-system dependency: * (asdf:find-system "sb-md5") # * (asdf:component-depends-on (make-instance 'asdf:load-op) (asdf:find-system "sb-md5")) ((ASDF:COMPILE-OP "sb-md5") (ASDF:LOAD-OP SB-MD5-SYSTEM::SB-ROTATE-BYTE)) * (defclass my-load-op (asdf:load-op) ()) # * (asdf:component-depends-on (make-instance 'my-load-op) (asdf:find-system "sb-md5")) ((ASDF:COMPILE-OP "sb-md5")) The net effect is that subclasses of operation classes don't inherit dependency behavior; in the example above, MY-LOAD-OP isn't able to load sb-md5, because sb-rotate-byte doesn't get loaded. I think it would make sense for operation subclasses to inherit dependency behavior (patch attached), but maybe there's some reason why they don't. Can anybody think up a story under which the current implementation is the right thing? Thanks, Richard --- asdf.lisp15 Oct 2008 18:56:08 -00001.130 +++ asdf.lisp7 Nov 2008 14:22:46 -0000 < at >< at > -640,8 +640,7 < at >< at > (component-depends-on (make-instance op-spec) c)) (defmethod component-depends-on ((o operation) (c component)) - (cdr (assoc (class-name (class-of o)) - (slot-value c 'in-order-to)))) + (cdr (assoc o (slot-value c 'in-order-to) :test #'typep))) (defgeneric component-self-dependencies (operation component)) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________ cclan-list mailing list cclan-list< at >lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cclan-list

asdf replacement

Faré — 2008-10-18T18:46:59

Note that if you want to develop something that's incompatible with ASDF yet has a migration path from ASDF, you might be interested in hacking XCVB. It's not production-ready yet (and it currently depends on ASDF to be installed itself), but it does its job and brings interesting new features like separate compilation. [ François-René ÐVB Rideau | Reflection&Cybernethics | http://fare.tunes.org ] Be liberal in what you accept and conservative in what you send. -- Jon Postel ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

a non-contentious patch for ASDF...

Gary King — 2008-10-15T18:54:37

I made a mistake when I applied Richard Kreuter's fix for ASDF's broken circularity detection a while back: I kept in the old ASDF code and added Richard's fix. The patch below removes the code that should have been removed then. With this in, ASDF passes all 14-tests. Index: asdf.lisp =================================================================== RCS file: /cvsroot/cclan/asdf/asdf.lisp,v retrieving revision 1.129 diff -u -w -r1.129 asdf.lisp --- asdf.lisp4 Oct 2008 22:41:04 -00001.129 +++ asdf.lisp15 Oct 2008 18:52:03 -0000 < at >< at > -751,8 +751,6 < at >< at > (if (component-visiting-p operation c) (error 'circular-dependency :components (list c))) (setf (visiting-component operation c) t) - (loop for (required-op . deps) in (component-depends-on operation c) - do (do-dep required-op deps)) (unwind-protect (progn (loop for (required-op . deps) in I've just committed this. -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

adding system-loaded-p to ASDF

Gary King — 2008-10-15T19:01:23

AFAIK, there is no _easy_ way to tell if a system has been loaded in ASDF. #'find-system lets me know if a system is defined but I have to look at operation-done-p to know whether or not it has been loaded. The following adds #'system-loaded-p and two methods on #'operation- done-p to make it easier to use by converting symbols into instances of reasonable classes. (in-package #:asdf) (defmethod operation-done-p ((o symbol) (c t)) (operation-done-p (make-instance o) c)) (defmethod operation-done-p ((o t) (c symbol)) (operation-done-p o (find-system c))) (defun system-loaded-p (system) (operation-done-p 'load-op (find-system system))) If there is no disagreement, I'll add some documentation and tests and commit. -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

rfc - delay the parsing of system components

Gary King — 2008-10-08T14:12:00

I just finished a rough cut of an ASDF overall that makes three largish changes: 1. delays the parsing of system components until needed by traverse. In particular, this means that the :components clause of defsystem form happens after that system's dependencies have been loaded rather than when the ASD file itself is loaded. 2. rewrites traverse as a set of methods that immediately call perform (rather than building up a list of perform actions that are then called in operate). 3. does away with :do-first and moves what it did into :in-order-to The main motivation for change #1 is to be able to define new operations and source file classes in a system's dependencies and have them used in that systems definitions; the main motivation#2 was #1: it does no good to delay parsing of the defsystem form if traverse has to complete the parse before anything else happens!. As for #3, while doing three things at once is just very human (and besides, it made #2 easier). I've got several hours of work left cleaning up loose ends and moving restarts and with-compilation-units around into better places. What I'd appreciate is any high-level feedback about the idea of these changes and whether or not I've missed some horrible interaction that nullifies the whole direction. I hope to post the suggested changes later in the week. Until then, happy coding. -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

in-order-to and/or do-first

Gary King — 2008-10-07T23:45:55

Can anyone recall why we have both in-order-to and do-first? Doesn't in-order-to subsume do-first? thanks, -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

small patch for asdf output

Gary King — 2008-10-05T19:48:09

The patch below moves asdf status output into a single function, asdf- message, and uses this to print whatever ASDF prints. It also moves a comment about CMUCL out into a separate function and uses enough-namestring when not running on CMUCL. If no-one has objections, I'll commit in a few days. Index: asdf.lisp =================================================================== RCS file: /cvsroot/cclan/asdf/asdf.lisp,v retrieving revision 1.129 diff -u -w -r1.129 asdf.lisp --- asdf.lisp4 Oct 2008 22:41:04 -00001.129 +++ asdf.lisp5 Oct 2008 19:46:02 -0000 < at >< at > -150,6 +150,10 < at >< at > (define-modify-macro appendf (&rest args) append "Append onto list") +(defun asdf-message (message &rest args) + (declare (dynamic-extent args)) + (apply #'format *verbose-out* message args)) + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; classes, condiitons < at >< at > -399,6 +403,15 < at >< at > (package (try counter) (try counter))) (package package)))) +;;; special handling for cmucl +;; FIXME: This wants to be (ENOUGH-NAMESTRING +;; ON-DISK), but CMUCL barfs on that. +(defun asdf-enough-namestring (it) + #+cmucl + it + #-cmucl + (enough-namestring it)) + (defun find-system (name &optional (error-p t)) (let* ((name (coerce-name name)) (in-memory (system-registered-p name)) < at >< at > -409,12 +422,9 < at >< at > (let ((package (make-temporary-package))) (unwind-protect (let ((*package* package)) - (format - *verbose-out* + (asdf-message "~&~< at ><; ~< at >;loading system definition from ~A into ~A~< at >:>~%" - ;; FIXME: This wants to be (ENOUGH-NAMESTRING - ;; ON-DISK), but CMUCL barfs on that. - on-disk + (asdf-enough-namestring on-disk) *package*) (load on-disk)) (delete-package package)))) < at >< at > -425,7 +435,7 < at >< at > (if error-p (error 'missing-component :requires name)))))) (defun register-system (name system) - (format *verbose-out* "~&~< at ><; ~< at >;registering ~A as ~A~< at >:>~%" system name) + (asdf-message "~&~< at ><; ~< at >;registering ~A as ~A~< at >:>~%" system name) (setf (gethash (coerce-name name) *defined-systems*) (cons (get-universal-time) system))) < at >< at > -812,7 +822,7 < at >< at > nil) (defmethod explain ((operation operation) (component component)) - (format *verbose-out* "~&;;; ~A on ~A~%" operation component)) + (asdf-message "~&;;; ~A on ~A~%" operation component)) ;;; compile-op -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

removed load-preferences support from ASDF

Gary King — 2008-10-04T22:42:08

As was discussed several months ago, I have removed load-preferences support from ASDF 2007-10-04 10:55 gwking< at >metabang.com Removed preference loading machinery completely. Also removed the following test files that tested the machinery. * test/test-preferences-1.lisp * test/test-preferences-1.script * test/test-preferences-system-1.asd * test/test-preferences-system-load.lisp * test/test-preferences-system-test.lisp * test/test6.script * test/test7.script -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

ASDF component-self-dependencies

Robert Goldman — 2008-09-23T19:38:46

Does anyone have a clear understanding of the role of this function, and its relationship to component-depends-on? Examination suggests that the coder considered the possibility that component-depends-on would overgenerate, returning some dependencies that actually didn't match the component, and these dependencies would be weeded out by component-self-dependencies. Is that correct? Anyone know why component-self-dependencies is a generic function? It's internal, so I assume that the ASDF extender is not expected to extend this generic function. If someone can clue me in, I will try to write up a documentation string that can be inserted into the source.... Also, am I correct in thinking that component-depends-on is a candidate for having its standard method combination replaced by append? Or would that be a mistake? thanks, r ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

Circularity detection fix exposed a bug

Richard M Kreuter — 2008-09-09T14:48:28

Hi, After the circularity detection patch applied in 1.125, test3 fails with a spurious CIRCULAR-DEPENDENCY error. I think the trouble is that TRAVERSE fails to unvisit an operation/component pair at least for feature-dependencies, and maybe elsewhere. The patch below does the un-visiting in an UNWIND-PROTECT cleanup, so should ensure that ASDF always unvisit as desired. All the tests pass with this change, but I'm not really confident about anything TRAVERSE-related. Does this look like a reasonable thing to do? Thanks, Richard --- asdf.lisp6 Sep 2008 22:57:16 -00001.127 +++ asdf.lisp9 Sep 2008 13:28:30 -0000 < at >< at > -725,45 +725,47 < at >< at > (if (component-visiting-p operation c) (error 'circular-dependency :components (list c))) (setf (visiting-component operation c) t) - (loop for (required-op . deps) in (component-depends-on operation c) - do (do-dep required-op deps)) - ;; constituent bits - (let ((module-ops - (when (typep c 'module) - (let ((at-least-one nil) - (forced nil) - (error nil)) - (loop for kid in (module-components c) - do (handler-case - (appendf forced (traverse operation kid )) - (missing-dependency (condition) - (if (eq (module-if-component-dep-fails c) :fail) - (error condition)) - (setf error condition)) - (:no-error (c) - (declare (ignore c)) - (setf at-least-one t)))) - (when (and (eq (module-if-component-dep-fails c) :try-next) - (not at-least-one)) - (error error)) - forced)))) - ;; now the thing itself - (when (or forced module-ops - (not (operation-done-p operation c)) - (let ((f (operation-forced (operation-ancestor operation)))) - (and f (or (not (consp f)) - (member (component-name - (operation-ancestor operation)) - (mapcar #'coerce-name f) - :test #'string=))))) - (let ((do-first (cdr (assoc (class-name (class-of operation)) - (slot-value c 'do-first))))) - (loop for (required-op . deps) in do-first - do (do-dep required-op deps))) - (setf forced (append (delete 'pruned-op forced :key #'car) - (delete 'pruned-op module-ops :key #'car) - (list (cons operation c)))))) - (setf (visiting-component operation c) nil) + (unwind-protect + (progn + (loop for (required-op . deps) in (component-depends-on operation c) + do (do-dep required-op deps)) + ;; constituent bits + (let ((module-ops + (when (typep c 'module) + (let ((at-least-one nil) + (forced nil) + (error nil)) + (loop for kid in (module-components c) + do (handler-case + (appendf forced (traverse operation kid )) + (missing-dependency (condition) + (if (eq (module-if-component-dep-fails c) :fail) + (error condition)) + (setf error condition)) + (:no-error (c) + (declare (ignore c)) + (setf at-least-one t)))) + (when (and (eq (module-if-component-dep-fails c) :try-next) + (not at-least-one)) + (error error)) + forced)))) + ;; now the thing itself + (when (or forced module-ops + (not (operation-done-p operation c)) + (let ((f (operation-forced (operation-ancestor operation)))) + (and f (or (not (consp f)) + (member (component-name + (operation-ancestor operation)) + (mapcar #'coerce-name f) + :test #'string=))))) + (let ((do-first (cdr (assoc (class-name (class-of operation)) + (slot-value c 'do-first))))) + (loop for (required-op . deps) in do-first + do (do-dep required-op deps))) + (setf forced (append (delete 'pruned-op forced :key #'car) + (delete 'pruned-op module-ops :key #'car) + (list (cons operation c))))))) + (setf (visiting-component operation c) nil)) (visit-component operation c (and forced t)) forced))) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

operation-done-p (test-op system)

Gary King — 2008-09-06T22:30:18

I just applied Luís Oliveira's patch that supplies a default method for operation-done-p (test-op system). (it's only been 9-months... sheesh). -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

on using system-registered-p where it can be used.

Gary King — 2008-09-04T12:57:32

The attached diff (which I just committed) replaces calls to gethash with calls to system-registered-p Index: asdf.lisp =================================================================== RCS file: /cvsroot/cclan/asdf/asdf.lisp,v retrieving revision 1.123 diff -u -w -r1.123 asdf.lisp --- asdf.lisp5 Jul 2008 02:57:20 -00001.123 +++ asdf.lisp4 Sep 2008 12:55:13 -0000 < at >< at > -375,7 +375,7 < at >< at > (or (some (lambda (x) (funcall x system-name)) *system-definition-search-functions*) - (let ((system-pair (gethash system-name *defined-systems*))) + (let ((system-pair (system-registered-p system-name))) (and system-pair (system-source-file (cdr system-pair))))))) < at >< at > -407,7 +407,7 < at >< at > (defun find-system (name &optional (error-p t)) (let* ((name (coerce-name name)) - (in-memory (gethash name *defined-systems*)) + (in-memory (system-registered-p name)) (on-disk (system-definition-pathname name))) (when (and on-disk (or (not in-memory) < at >< at > -424,7 +424,7 < at >< at > *package*) (load on-disk)) (delete-package package)))) - (let ((in-memory (gethash name *defined-systems*))) + (let ((in-memory (system-registered-p name))) (if in-memory (progn (if on-disk (setf (car in-memory) (file-write-date on-disk))) (cdr in-memory)) < at >< at > -438,6 +438,7 < at >< at > (defun system-registered-p (name) (gethash (coerce-name name) *defined-systems*)) + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;; finding components -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

Circularity detection broken in ASDF

Richard M Kreuter — 2008-09-03T22:27:54

Hi, (I tried posting this once before, but gmane and sourceforge seem to disagree about what got through. I've subscribed now.) It seems that circularity detection is broken in asdf 1.123 and therabouts. Patch attached. Demonstration: * (require "ASDF") ("ASDF") * (progn (with-open-file (f "0.lisp" :direction :output :if-exists :supersede) (print 'foo f)) (with-open-file (f "1.lisp" :direction :output :if-exists :supersede) (print 'bar f)) nil) NIL * (asdf:defsystem circ :pathname *default-pathname-defaults* :components ((:file "0" :depends-on ("1")) (:file "1" :depends-on ("0")))) # * (asdf:oos 'asdf:compile-op "circ") Control stack guard page temporarily disabled: proceed with caution debugger invoked on a SB-KERNEL::CONTROL-STACK-EXHAUSTED in thread #: Control stack exhausted (no more space for function call frames). This is probably due to heavily nested or infinitely recursive function calls, or a tail call that SBCL cannot or has not optimized away. Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL. restarts (invokable by number or by possibly-abbreviated name): 0: [ABORT] Exit debugger, returning to top level. (SB-KERNEL::CONTROL-STACK-EXHAUSTED-ERROR) 0] :a -- RmK --- asdf.lisp 5 Jul 2008 02:57:20 -0000 1.123 +++ asdf.lisp 21 Jul 2008 13:34:40 -0000 < at >< at > -588,7 +588,7 < at >< at > (defgeneric component-visiting-p (operation component)) (defmethod component-visiting-p ((o operation) (c component)) - (let ((node (cons o c))) + (let ((node (node-for o c))) (member node (operation-visiting-nodes (operation-ancestor o)) :test 'equal))) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________ cclan-list mailing list cclan-list< at >lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cclan-list

asdf and relative names

Faré — 2008-09-03T19:03:25

At ITA, we've been happily using the attached file to allow names such as "foo/bar/baz" to be used for component names, either modules or files. It works great for us, and allows to portably use #\/ to denote relative pathnames where the character was previously forbidden in portable systems. Could cClan aintainers include it in the upstream ASDF? Or is there a good reason not to? [ François-René ÐVB Rideau | Reflection&Cybernethics | http://fare.tunes.org ] Atheism is a non-prophet organization. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________ cclan-list mailing list cclan-list< at >lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cclan-list

asdf and provide / require

Gary King — 2008-09-03T02:40:29

I'd like to build a system A that loads certain files if and only if some other system B is _not_ loaded. One natural way to do this would be to have system B push some feature (call it :b) onto *features* and have system A say something like :components ((:file "something-like-b" :depends-on ((feature (not :b))))) which is supposed to say "compile and load the file 'something-like-b' if the feature :b is not present when you actually get around to loading this system. Depends-on isn't quite the right term but I'm hoping to keep changes down to a minimum. The above won't work both because ASDF can't express anything about the absence of a feature and because you can't depend on a feature being present in the depends-on clause. The closest I think you can get now is :in-order-to ((:compile-op (feature :foo)) (load-op (feature :bar)))) Is there some other to express what I want? Is there some reason that I shouldn't be trying to express this at all! (Lastly, if there is any sense to this "include file iff some feature is present / absent, then why not generalize and allow ;; more complex feature tests (:file "some-file" :include-when ((feature (:and :foo (:not :bar)))) ;; more general computation (:file "some-file" :include-when ((test (some-predicate-i-know-not- what-p))) (In the last psuedo-example, I'm imaging that the current component and system are available via specials.) thoughts and comments welcome, -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

:around methods on LOAD-OP and COMPILE-OP

Nikodemus Siivola — 2008-07-30T08:14:39

These two are a relatively recent addition: (defmethod perform :around ((o load-op) (c cl-source-file)) (let ((state :initial)) (loop until (or (eq state :success) (eq state :failure)) do (case state (:recompiled (setf state :failure) (call-next-method) (setf state :success)) (:failed-load (setf state :recompiled) (perform (make-instance 'asdf:compile-op) c)) (t (with-simple-restart (:try-recompiling "Recompile ~a and try loading it again" (component-name c)) (setf state :failed-load) (call-next-method) (setf state :success))))))) (defmethod perform :around ((o compile-op) (c cl-source-file)) (let ((state :initial)) (loop until (or (eq state :success) (eq state :failure)) do (case state (:recompiled (setf state :failure) (call-next-method) (setf state :success)) (:failed-compile (setf state :recompiled) (perform (make-instance 'asdf:compile-op) c)) (t (with-simple-restart (:try-recompiling "Try recompiling ~a" (component-name c)) (setf state :failed-compile) (call-next-method) (setf state :success))))))) from about 3 months ago. Sorry for not noticing this earlier, but they stop in the middle of one of the nicer places for users to hook into global ASDF behaviour: (defmethod asdf:perform :around ((op asdf:load-op) (c asdf:cl-source-file)) (handler-case (call-next-method) (sb-ext:invalid-fasl () (asdf:perform (make-instance 'asdf:compile-op) c) (call-next-method)))) ...or perhaps rather, such user tweaks stomp on the TRY-RECOMPILING restarts. Maybe they could be hung on (unexported) BASIC-LOAD-OP and (to be added) BASIC-COMPILE-OP instead, so that users can still do their thing without nuking bits of the official ASDF? Cheers, -- Nikodemus I don't have a really clean solution yet, but one option would be to inject an unexpo ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/

[PATCH] circularity detection broken in 1.123

Richard M Kreuter — 2008-07-21T13:44:32

Hi, It seems that circularity detection is broken in asdf 1.123 and therabouts. Patch attached. Demonstration: * (require "ASDF") ("ASDF") * (progn (with-open-file (f "0.lisp" :direction :output :if-exists :supersede) (print 'foo f)) (with-open-file (f "1.lisp" :direction :output :if-exists :supersede) (print 'bar f)) nil) NIL * (asdf:defsystem circ :pathname *default-pathname-defaults* :components ((:file "0" :depends-on ("1")) (:file "1" :depends-on ("0")))) # * (asdf:oos 'asdf:compile-op "circ") Control stack guard page temporarily disabled: proceed with caution debugger invoked on a SB-KERNEL::CONTROL-STACK-EXHAUSTED in thread #: Control stack exhausted (no more space for function call frames). This is probably due to heavily nested or infinitely recursive function calls, or a tail call that SBCL cannot or has not optimized away. Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL. restarts (invokable by number or by possibly-abbreviated name): 0: [ABORT] Exit debugger, returning to top level. (SB-KERNEL::CONTROL-STACK-EXHAUSTED-ERROR) 0] :a -- RmK ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________ cclan-list mailing list cclan-list< at >lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cclan-list

I just updated asdf

Gary King — 2008-07-05T02:58:33

with the patch to modify system-definition-pathname so that even systems that are loaded "by hand" will be reloaded by ASDF if they change. Also added two tests for this behavior. Tests pass on OS X under sbcl, clisp, allegro and allegromodern. enjoy, -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08

Ensuring that ASDF reloads out of date system defs,take 2

Gary King — 2008-06-29T15:38:18

The patch below is a followup / altered version to my proposed patch of June 15th. Both patches ensure that ASDF treats systems _it_ can find using *system-definition-search-functions* the same way it treats systems that have been loaded by hand. The previous patch modified find-system; this one modifies system-definition-pathname which, to me at least, seems to be the "right" place to put the fix. I'm going to add a test or two of the behavior for both kinds of system loading and then I'd like to commit. Comments very welcome! Index: asdf.lisp =================================================================== RCS file: /cvsroot/cclan/asdf/asdf.lisp,v retrieving revision 1.122 diff -c -r1.122 asdf.lisp *** asdf.lisp29 Jun 2008 15:10:16 -00001.122 --- asdf.lisp29 Jun 2008 15:33:32 -0000 *************** *** 1,4 **** ! ;;; This is asdf: Another System Definition Facility. $Revision: 1.122 $ ;;; ;;; Feedback, bug reports, and patches are all welcome: please mail to ;;; lists.sf.net>. But note first that the canonical --- 1,4 ---- ! ;;; This is asdf: Another System Definition Facility. $Revision: 1.121 $ ;;; ;;; Feedback, bug reports, and patches are all welcome: please mail to ;;; lists.sf.net>. But note first that the canonical *************** *** 119,125 **** (in-package #:asdf) ! (defvar *asdf-revision* (let* ((v "$Revision: 1.122 $") (colon (or (position #\: v) -1)) (dot (position #\. v))) (and v colon dot --- 119,125 ---- (in-package #:asdf) ! (defvar *asdf-revision* (let* ((v "$Revision: 1.121 $") (colon (or (position #\: v) -1)) (dot (position #\. v))) (and v colon dot *************** *** 371,378 **** '(sysdef-central-registry-search)) (defun system-definition-pathname (system) ! (some (lambda (x) (funcall x system)) ! *system-definition-search-functions*)) (defvar *central-registry* '(*default-pathname-defaults* --- 371,383 ---- '(sysdef-central-registry-search)) (defun system-definition-pathname (system) ! (let ((system-name (coerce-name system))) ! (or ! (some (lambda (x) (funcall x system-name)) ! *system-definition-search-functions*) ! (let ((system-pair (gethash system-name *defined-systems*))) ! (and system-pair ! (system-source-file (cdr system-pair))))))) (defvar *central-registry* '(*default-pathname-defaults* *************** *** 701,708 **** (or (member (car dep) *features*) (error 'missing-dependency :required-by c ! :requires (car dep) ! :version nil))) (t (dolist (d dep) (cond ((consp d) --- 706,712 ---- (or (member (car dep) *features*) (error 'missing-dependency :required-by c ! :requires (car dep)))) (t (dolist (d dep) (cond ((consp d) *************** *** 1310,1322 **** (error "RUN-SHELL-PROGRAM not implemented for this Lisp") )) ! (defun system-source-file (system-name) ! (let ((system (asdf:find-system system-name))) ! (make-pathname ! :type "asd" ! :name (asdf:component-name system) ! :defaults (asdf:component-relative-pathname system)))) (defun system-source-directory (system-name) (make-pathname :name nil :type nil --- 1314,1334 ---- (error "RUN-SHELL-PROGRAM not implemented for this Lisp") )) ! (defgeneric system-source-file (system) ! (:documentation "Return the source file in which system is defined.")) + (defmethod system-source-file ((system-name t)) + (system-source-file (find-system system-name))) + + (defmethod system-source-file ((system system)) + (let ((pn (and (slot-boundp system 'relative-pathname) + (make-pathname + :type "asd" + :name (asdf:component-name system) + :defaults (asdf:component-relative-pathname system))))) + (when pn + (probe-file pn)))) + (defun system-source-directory (system-name) (make-pathname :name nil :type nil -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php

Finally applied Matthew Swank's try-compiling patch

Gary King — 2008-06-29T15:11:51

(Sorry for the delay). -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php

committed patch for system-relative-pathname

Gary King — 2008-06-26T03:06:05

(defun system-relative-pathname (system pathname &key name type) - (let ((directory (pathname-directory pathname))) + ;; you're not allowed to muck with the return value of pathname-X + (let ((directory (copy-list (pathname-directory pathname)))) (when (eq (car directory) :absolute) (setf (car directory) :relative)) (merge-pathnames -- Gary Warren King, metabang.com Cell: (413) 559 8738 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php