http://blog.gmane.org/gmane.linux.systemtap hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.linux.systemtap/10403 Hi, These are tests results on 2.6.28-rc6. No much regression. 1. Some failures caused by test cache, like marker.exp 2. Kernel config, like utrace. 3. Machine related, like smp, scsi. Regards, Wenji ------------------------------------------------------------------------------ Package: systemtap_snapshot (0.8/0.131-master(224e23be)-2.6.28_rc6-snapshot) Previous build: 2008/11/17 04:53:56 - 2008/11/17 04:53:56 Current build: 2008/11/26 22:21:14 - 2008/11/26 22:21:14 Host: rctest-32 Platform: Linux 2.6.28-rc6 i386 (EL4U6) (before: Linux 2.6.28-rc5 i386 (EL4U6)) URL: http://build.alchar.org/cgi/showBuild?host=rctest-32&pkg=systemtap_snapshot&date=20081126-222114 First failure: test Test result: 826: 758 +, 40 -, 28 S, 0 E (before: 823: 760 +, 34 -, 29 S, 0 E) Old -> New Test ----- ----- ---------------------------------- FAIL -> PASS test - systemtap.pass1-4/buildok.exp(buildok/sched_test.stp) N/A -> FAIL test - systemtap.base/marker.exp(K_MARKER18 was cached) PASS -> FAIL test - systemtap.base/stmt_rel.exp(systemtap.base/stmt_rel.stp) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit uid16) N/A -> FAIL test - systemtap.base/marker.exp(K_MARKER11 was cached) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit sendfile) PASS -> N/A test - systemtap.base/marker.exp(K_MARKER04 wasn't cached) PASS -> N/A test - systemtap.base/marker.exp(K_MARKER18 wasn't cached) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit unlink) N/A -> PASS test - systemtap.base/cmd_parse.exp(cmd_parse14) N/A -> FAIL test - systemtap.base/marker.exp(K_MARKER04 was cached) PASS -> FAIL test - systemtap.pass1-4/semok.exp(semok/twentyseven.stp) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit swap) PASS -> N/A test - systemtap.base/marker.exp(K_MARKER11 wasn't cached) N/A -> FAIL test - systemtap.base/skipped.exp(skip tracking) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit forkwait) SKIP -> N/A test - systemtap.maps/pmap_agg_overflow.exp(pmap_agg_overflow requires smp) N/A -> FAIL test - systemtap.base/static_uprobes.exp(unable to compile /home/wjhuang/systemtap/testsuite/static_uprobes.c) N/A -> PASS test - systemtap.maps/pmap_agg_overflow.exp(pmap_agg_overflow) PASS -> FAIL test - systemtap.pass1-4/buildok.exp(buildok/scsi-all-probes.stp) ------------------------------------------------------------------------------ Package: systemtap_snapshot (0.8/0.131-master(224e23be)-2.6.28_rc6-snapshot) Previous build: 2008/11/17 15:26:43 - 2008/11/17 15:26:43 Current build: 2008/11/27 09:32:31 - 2008/11/27 09:32:31 Host: rctest-64 Platform: Linux 2.6.28-rc6 x86_64 (EL5.2) (before: Linux 2.6.28-rc5 x86_64 (EL5.2)) URL: http://build.alchar.org/cgi/showBuild?host=rctest-64&pkg=systemtap_snapshot&date=20081127-093231 First failure: test Test result: 859: 783 +, 44 -, 32 S, 0 E (before: 854: 785 +, 38 -, 31 S, 0 E) Old -> New Test ----- ----- ---------------------------------- FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit alarm) FAIL -> N/A test - systemtap.base/declaration.exp(empty-struct resolve-pass was cached) FAIL -> N/A test - systemtap.base/marker.exp(K_MARKER18 was cached) FAIL -> N/A test - systemtap.base/marker.exp(K_MARKER11 was cached) FAIL -> N/A test - systemtap.syscall/syscall.exp(64-bit acct) N/A -> PASS test - systemtap.base/marker.exp(K_MARKER04 wasn't cached) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit trunc) N/A -> PASS test - systemtap.base/marker.exp(K_MARKER18 wasn't cached) N/A -> PASS test - systemtap.base/cmd_parse.exp(cmd_parse14) FAIL -> N/A test - systemtap.base/marker.exp(K_MARKER04 was cached) PASS -> N/A test - systemtap.syscall/syscall.exp(forkwait) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit futimes) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit forkwait) PASS -> N/A test - systemtap.syscall/syscall.exp(stat) PASS -> FAIL test - systemtap.base/warnings.exp(warnings) N/A -> PASS test - systemtap.base/marker.exp(K_MARKER11 wasn't cached) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit uid) N/A -> SKIP test - systemtap.base/skipped.exp(skip tracking) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit forkwait) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit openclose) N/A -> PASS test - systemtap.base/static_uprobes.exp(compiling /home/wjhuang/systemtap/testsuite/static_uprobes.c) PASS -> N/A test - systemtap.syscall/syscall.exp(net1) PASS -> N/A test - systemtap.syscall/syscall.exp(mmap) N/A -> FAIL test - systemtap.base/static_uprobes.exp(sduprobes) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit umask) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit stat) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit mmap) FAIL -> PASS test - systemtap.examples/check.exp(systemtap.examples/general/graphs run) PASS -> N/A test - systemtap.syscall/syscall.exp(openclose) N/A -> PASS test - systemtap.base/declaration.exp(empty-struct resolve-pass wasn't cached) N/A -> PASS test - systemtap.syscall/syscall.exp(acct) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit link) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit readwrite) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit timer) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit net1) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit mmap) Wenji Huang 2008-12-03T02:49:54 http://comments.gmane.org/gmane.linux.systemtap/10397 Hi, Can you please add git url for systemtap source, in "Building Systemtap Mainline" section of link "http://sources.redhat.com/systemtap/wiki/SystemtapOnUbuntu". Currently shown steps are : sudo apt-get install git-core dejagnu sudo apt-get build-dep systemtap cd path/to/systemtap ./configure --disable-pie make && sudo make install Thanks in advance. Gowri gowrishankar 2008-12-02T12:00:44 http://comments.gmane.org/gmane.linux.systemtap/10392 A new automated systemtap source snapshot is available ftp://sources.redhat.com/pub/systemtap/snapshots/systemtap-20081129.tar.bz2 1089973 bytes, fd2aeae9e2d04d2cf417a32f98257041e8ff0e2c tag See also ftp://sources.redhat.com/pub/systemtap/snapshots/ fche< at >sourceware.org 2008-11-29T14:27:07 http://comments.gmane.org/gmane.linux.systemtap/10382 Hello, I tried to run sleeptime.stp script from http://sourceware.org/systemtap/wiki/ScriptsTools on maemo platform (diablo version). Running stap -vvv sleeptime.stp I've got the following Running /usr/bin/staprun -v -v /var/tmp/stapqX8ReO/stap_07ac9da65fb9eda7439c65904e2b95 60_12133.ko staprun:main:249 modpath="/var/tmp/stapqX8ReO/stap_07ac9da65fb9eda7439c65904e2b9560_12133.ko", modname="stap_07ac9da65fb9eda7439c65904e2b9560_12133" staprun:init_staprun:207 init_staprun staprun:insert_module:47 inserting module staprun:insert_module:66 module options: _stp_bufsize=0 Error inserting module '/var/tmp/stapqX8ReO/stap_07ac9da65fb9eda7439c65904e2b9560_12133.ko': Unknown symbol in module Pass 5: run completed in 10usr/120sys/210real ms. Pass 5: run failed. Try again with more '-v' (verbose) options. dmesg command says: [ 6783.937500] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol relay_open [ 6783.937500] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol relay_buf_full [ 6783.945312] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol unregister_kretprobe [ 6783.945312] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol relay_close [ 6783.953125] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol relay_flush [ 6783.953125] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol register_kprobe [ 6783.953125] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol register_kretprobe [ 6783.960937] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol unregister_kprobe [ 6783.960937] stap_07ac9da65fb9eda7439c65904e2b9560_12133: Unknown symbol relay_file_operations [ 6827.679687] cx3110x: WARNING prism_softmac_frame_tx_done() returned an empty frame. The kernel was compiled with option CONFIG_RELAY=y I don't understand this error enough good. Could you please tell me in what direction I should move to get rid of this error? How serious is the problem? Kernel version: diablo kernel 2.6.21 Systemtap version: version 0.7.1/0.131 Thanks in advance, Dmitry Malichenko Dmitry Malichenko 2008-11-27T17:28:01 http://comments.gmane.org/gmane.linux.systemtap/10368 probe never {p <<< 1} global p results in ERROR: empty aggregate near identifier 'p' at <input>:1:28 but should result in p < at >count=0x0 fche at redhat dot com 2008-11-25T19:19:45 http://comments.gmane.org/gmane.linux.systemtap/10365 I think we could branch git tree only for upstream kernel. that is good for upstream kernel developers. In this branch, we should; - remove all autoconf-*. - use new kernel functions/macros. Then, it could be easy to port upstream kernel. mhiramat at redhat dot com 2008-11-25T17:57:07 http://comments.gmane.org/gmane.linux.systemtap/10363 ksebasti found several issues with this widget: printf ("%n%4d", 0) prints 0x04 0x00 0x00 0x00 0x00 printf ("%n%n%n") prints junk printf ("%n") prints junk If we keep %n around at all, it needs to compose sensibly. We could make it mean "total record length", so that the previous three cases would print printf ("%n%4d", 0) would print 0x05 0x00 0x00 0x00 0x00 printf ("%n%n%n") would print 0x03 0x03 0x03 printf ("%n") would print 0x01 fche at redhat dot com 2008-11-25T16:48:29 http://comments.gmane.org/gmane.linux.systemtap/10362 In most of our kernel-side code, translator-generated or runtime, we use the kosher smp_processor_id function to get the cpu number. Considering that we always disable preemption, it seems useful to switch to raw_smp_processor_id() in several spots, which would exclude the redundant runtime checks compiled into the plain variant. fche at redhat dot com 2008-11-25T15:57:33 http://comments.gmane.org/gmane.linux.systemtap/10352 Current checks in tapsets.cxx:validate_module_elf do not consider the valid possibility of probing an x86 binary on an x86-64 kernel, and unfairly rejects debuginfo/elf processing for them. (The same problem probably exists on ppc.) fche at redhat dot com 2008-11-24T15:57:52 http://comments.gmane.org/gmane.linux.systemtap/10350 My systemtap is the latest: git describe release-0.7-521-g01b05e2 I have been getting the following errors throughout the whole of last week, not sure what is the status: In file included from /tmp/stapJzFK4J/stap_7146.c:46: /usr/local/share/systemtap/runtime/stat.c: In function '_stp_stat_get': /usr/local/share/systemtap/runtime/stat.c:213: error: incompatible type for argument 2 of 'cpumask_next' _stp_stat_clear /usr/local/share/systemtap/runtime/stat.c: In function '_stp_stat_clear': /usr/local/share/systemtap/runtime/stat.c:248: error: incompatible type for argument 2 of 'cpumask_next' task_nsproxy put_nsproxy get_nsproxy ns_cgroup_clone get_uts_ns put_uts_ns copy_utsname utsname init_utsname pagefault_disable pagefault_enable function__dwarf_tvar_get_size_0 function_exit probe_1386 probe_1387 probe_1388 enter_begin_probe enter_end_probe enter_error_probe enter_kprobe_probe enter_kretprobe_probe enter_hrtimer_probe systemtap_module_init systemtap_module_exit probe_start probe_exit Execution times (seconds) preprocessing : 0.20 (34%) usr 0.13 (20%) sys 0.47 (29%) wall 4956 kB (26%) ggc lexical analysis : 0.07 (12%) usr 0.32 (50%) sys 0.46 (29%) wall 0 kB ( 0%) ggc parser : 0.21 (36%) usr 0.17 (27%) sys 0.59 (37%) wall 10801 kB (57%) ggc tree gimplify : 0.08 (14%) usr 0.00 ( 0%) sys 0.07 ( 4%) wall 1280 kB ( 7%) ggc symout : 0.02 ( 3%) usr 0.02 ( 3%) sys 0.01 ( 1%) wall 1265 kB ( 7%) ggc TOTAL : 0.58 0.64 1.61 18979 kB make[1]: *** [/tmp/stapJzFK4J/stap_7146.o] Error 1 make: *** [_module_/tmp/stapJzFK4J] Error 2 Pass 4: compiled C into "stap_7146.ko" in 2490usr/1270sys/7662real ms. Pass 4: compilation failed. Try again with more '-v' (verbose) options. Peter Teoh 2008-11-24T03:44:25 http://comments.gmane.org/gmane.linux.systemtap/10348 A new automated systemtap source snapshot is available ftp://sources.redhat.com/pub/systemtap/snapshots/systemtap-20081122.tar.bz2 1066088 bytes, 7320987632c7029c3b351b9ff8e5118d18979693 tag See also ftp://sources.redhat.com/pub/systemtap/snapshots/ fche< at >sourceware.org 2008-11-22T14:27:10 http://comments.gmane.org/gmane.linux.systemtap/10345 Support unified trace buffer instead of relayfs, since relay will be replaced by it. see kernel/trace/ring_buffer.c. mhiramat at redhat dot com 2008-11-21T13:31:07 http://comments.gmane.org/gmane.linux.systemtap/10343 They requires more explicit commitments to upstream kernel. - refine their requirements - picking up previous mails. - ask them what we can do for them. - better integration with upstream kernel - merging minimum runtime. - merging minimum systemtap(or systemtap like scriptable tracer). - easy to use of systemtap on upstream kernel - no-dwarf(debuginfo) mode by default. - porting tapsets to upstream kernel. This entry is a meta entry, please list up your ideas. mhiramat at redhat dot com 2008-11-21T13:24:46 http://comments.gmane.org/gmane.linux.systemtap/10333 Hi All, If you are like Roland and looking for a newer version of the Systemtap RPMs for Fedora, you are in luck. The newer Systemtap 0.8 RPMs are now available for testing on Fedora 8 and Fedora 9. There is also a request for Fedora 10 but the rpms haven't been pushed to the F10 repository: https://admin.fedoraproject.org/updates/F8/FEDORA-2008-9787 https://admin.fedoraproject.org/updates/F9/FEDORA-2008-9695 https://admin.fedoraproject.org/updates/systemtap-0.8-1.fc10 The RPMs can be installed on a fedora 8/9 machines with: yum install --enablerepo=updates-testing-newkey systemtap Or the RPMs can upgraded with: yum upgrade --enablerepo=updates-testing-newkey "systemtap*" Please check to see that the newer version of systemtap works as expected and report your results on the update URLs towards the top of this email. -Will William Cohen 2008-11-19T19:41:32 http://comments.gmane.org/gmane.linux.systemtap/10328 It looks like for_each_cpu() interface has changed again on tip.git, breaking stp_for_each_cpu. The error I get when compiling a stap module here is: /usr/local/share/systemtap/runtime/stat.c: In function ‘_stp_stat_get’: /usr/local/share/systemtap/runtime/stat.c:213: error: incompatible type for argument 2 of ‘cpumask_next’ Using for_each_possible_cpu() should be equivalent to for_each_cpu(cpu, cpu_possible_map), but its interface didn't change like for_each_cpu() did. I kept the 2.6.28 #ifdef just in case, but for_each_possible_cpu() should work even on older kernels. Signed-off-by: Eduardo Habkost <ehabkost< at >redhat.com> --- runtime/runtime.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/runtime/runtime.h b/runtime/runtime.h index 7507e59..90113b6 100644 --- a/runtime/runtime.h +++ b/runtime/runtime.h < at >< at > -41,7 +41,7 < at >< at > #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28) #ifndef stp_for_each_cpu -#define stp_for_each_cpu(cpu) for_each_cpu((cpu), cpu_possible_map) +#define stp_for_each_cpu(cpu) for_each_possible_cpu((cpu)) #endif #else #ifndef stp_for_each_cpu Eduardo Habkost 2008-11-19T14:03:32 http://comments.gmane.org/gmane.linux.systemtap/10327 Hi, These are test results on 2.6.28-rc5 from labrat. ------------------------------------------------------------------------------ Package: systemtap_snapshot (0.8/0.131-master(a6ce1707)-2.6.28_rc5-snapshot) Previous build: 2008/11/11 02:25:03 - 2008/11/11 02:25:03 Current build: 2008/11/17 04:53:56 - 2008/11/17 04:53:56 Host: rctest-32 Platform: Linux 2.6.28-rc5 i386 (EL4U6) (before: Linux 2.6.28-rc4 i386 (EL4U6)) URL: http://build.alchar.org/cgi/showBuild?host=rctest-32&pkg=systemtap_snapshot&date=20081117-045356 First failure: test Test result: 823: 760 +, 34 -, 29 S, 0 E Old -> New Test ----- ----- ---------------------------------- FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit alarm) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit uid16) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit sendfile) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit unlink) PASS -> FAIL test - systemtap.base/global_end.exp(global_end) PASS -> FAIL test - systemtap.samples/queue_demo.exp(queue_demo) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit dir) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit stat) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit chmod) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit clock) ------------------------------------------------------------------------------ Package: systemtap_snapshot (0.8/0.131-master(a6ce1707)-2.6.28_rc5-snapshot) Previous build: 2008/11/11 09:55:56 - 2008/11/11 09:55:56 Current build: 2008/11/17 15:26:43 - 2008/11/17 15:26:43 Host: rctest-64 Platform: Linux 2.6.28-rc5 x86_64 (EL5.2) (before: Linux 2.6.28-rc4 x86_64 (EL5.2)) URL: http://build.alchar.org/cgi/showBuild?host=rctest-64&pkg=systemtap_snapshot&date=20081117-152643 First failure: test Test result: 854: 785 +, 38 -, 31 S, 0 E (before: 854: 787 +, 36 -, 31 S, 0 E) Old -> New Test ----- ----- ---------------------------------- PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit alarm) N/A -> FAIL test - systemtap.base/declaration.exp(empty-struct resolve-pass was cached) FAIL -> N/A test - systemtap.syscall/syscall.exp(64-bit alarm) N/A -> FAIL test - systemtap.base/marker.exp(K_MARKER18 was cached) FAIL -> N/A test - systemtap.syscall/syscall.exp(64-bit link) N/A -> FAIL test - systemtap.base/marker.exp(K_MARKER11 was cached) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit acct) PASS -> N/A test - systemtap.base/marker.exp(K_MARKER04 wasn't cached) N/A -> PASS test - systemtap.syscall/syscall.exp(alarm) PASS -> N/A test - systemtap.base/marker.exp(K_MARKER18 wasn't cached) FAIL -> N/A test - systemtap.syscall/syscall.exp(64-bit futimes) N/A -> FAIL test - systemtap.base/marker.exp(K_MARKER04 was cached) N/A -> PASS test - systemtap.syscall/syscall.exp(futimes) FAIL -> PASS test - systemtap.base/alternatives.exp(LOCAL1) PASS -> N/A test - systemtap.base/marker.exp(K_MARKER11 wasn't cached) N/A -> PASS test - systemtap.syscall/syscall.exp(net1) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit umask) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit mmap) PASS -> FAIL test - systemtap.examples/check.exp(systemtap.examples/general/graphs run) PASS -> N/A test - systemtap.base/declaration.exp(empty-struct resolve-pass wasn't cached) N/A -> PASS test - systemtap.syscall/syscall.exp(link) PASS -> N/A test - systemtap.syscall/syscall.exp(acct) FAIL -> N/A test - systemtap.syscall/syscall.exp(64-bit net1) Wenji Huang 2008-11-19T07:03:16 http://comments.gmane.org/gmane.linux.systemtap/10310 This is wrong: % stap -r /sdfijsdfoidf -L 'kernel.function("*")' % echo $? 0 This is more like it, though the "pass 2..." line is probably unhelpful. % stap -r /sdfijsdfoidf -e 'probe kernel.function("*") {}' semantic error: libdwfl failure (missing kernel /sdfijsdfoidf x86_64 debuginfo): No such file or directory while resolving probe point kernel.function("*") semantic error: no probes found Pass 2: analysis failed. Try again with more '-v' (verbose) options. % echo $? 1 fche at redhat dot com 2008-11-17T14:25:14 http://comments.gmane.org/gmane.linux.systemtap/10308 A new automated systemtap source snapshot is available ftp://sources.redhat.com/pub/systemtap/snapshots/systemtap-20081115.tar.bz2 1059250 bytes, 3ca1f6524b3592b377b1f9ad19bdae6eaa511bc4 tag See also ftp://sources.redhat.com/pub/systemtap/snapshots/ fche< at >sourceware.org 2008-11-15T14:27:09 http://comments.gmane.org/gmane.linux.systemtap/10306 Currently, systemtap locks whole of a probe handler which uses global variables. However, I think translator can shrink the locking region to the best size. { (lock(a) and lock(b)) ... a = xxx <- only here, we actually needs a's lock. ... if (yyy) b = zzz <- only here, we actually needs b's lock. ... (unlock(a) and unlock(b)) } mhiramat at redhat dot com 2008-11-14T23:26:34 http://comments.gmane.org/gmane.linux.systemtap/10299 This patch will change for_each_cpu macro definition to avoid name collusion in 2.6.28-rc4. See mainline commit: cb56d98e2a7530615899597551db685d68a2e852. --- runtime/counter.c | 4 ++-- runtime/map-stat.c | 4 ++-- runtime/map.c | 14 +++++++------- runtime/pmap-gen.c | 6 +++--- runtime/runtime.h | 10 ++++++++-- runtime/stat.c | 6 +++--- runtime/transport/procfs.c | 6 +++--- 7 files changed, 28 insertions(+), 22 deletions(-) diff --git a/runtime/counter.c b/runtime/counter.c index d037654..a3c3669 100644 --- a/runtime/counter.c +++ b/runtime/counter.c < at >< at > -58,7 +58,7 < at >< at > Counter _stp_counter_init (void) #if NEED_COUNTER_LOCKS == 1 { int i; -for_each_cpu(i) { +stp_for_each_cpu(i) { Counter c = per_cpu_ptr (cnt, i); spin_lock_init(c->lock); } < at >< at > -119,7 +119,7 < at >< at > int64_t _stp_counter_get (Counter cnt, int clear) int i; int64_t sum = 0; -for_each_cpu(i) { +stp_for_each_cpu(i) { Counter c = per_cpu_ptr (cnt, i); COUNTER_LOCK(c); sum += c->count; diff --git a/runtime/map-stat.c b/runtime/map-stat.c index dc3fd6a..c557d18 100644 --- a/runtime/map-stat.c +++ b/runtime/map-stat.c < at >< at > -68,7 +68,7 < at >< at > static PMAP _stp_pmap_new_hstat_linear (unsigned max_entries, int ksize, int sta if (pmap) { int i; MAP m; -for_each_cpu(i) { +stp_for_each_cpu(i) { m = (MAP)per_cpu_ptr (pmap->map, i); m->hist.type = HIST_LINEAR; m->hist.start = start; < at >< at > -95,7 +95,7 < at >< at > static PMAP _stp_pmap_new_hstat_log (unsigned max_entries, int key_size) if (pmap) { int i; MAP m; -for_each_cpu(i) { +stp_for_each_cpu(i) { m = (MAP)per_cpu_ptr (pmap->map, i); m->hist.type = HIST_LOG; m->hist.buckets = HIST_LOG_BUCKETS; diff --git a/runtime/map.c b/runtime/map.c index bb221cd..5108e59 100644 --- a/runtime/map.c +++ b/runtime/map.c < at >< at > -250,7 +250,7 < at >< at > static PMAP _stp_pmap_new(unsigned max_entries, int type, int key_size, int data /* initialize the memory lists first so if allocations fail */ /* at some point, it is easy to clean up. */ -for_each_cpu(i) { +stp_for_each_cpu(i) { m = per_cpu_ptr (map, i); INIT_LIST_HEAD(&m->pool); INIT_LIST_HEAD(&m->head); < at >< at > -258,7 +258,7 < at >< at > static PMAP _stp_pmap_new(unsigned max_entries, int type, int key_size, int data INIT_LIST_HEAD(&pmap->agg.pool); INIT_LIST_HEAD(&pmap->agg.head); -for_each_cpu(i) { +stp_for_each_cpu(i) { m = per_cpu_ptr (map, i); if (_stp_map_init(m, max_entries, type, key_size, data_size, i)) { goto err1; < at >< at > -271,7 +271,7 < at >< at > static PMAP _stp_pmap_new(unsigned max_entries, int type, int key_size, int data return pmap; err1: -for_each_cpu(i) { +stp_for_each_cpu(i) { m = per_cpu_ptr (map, i); __stp_map_del(m); } < at >< at > -358,7 +358,7 < at >< at > void _stp_pmap_clear(PMAP pmap) if (pmap == NULL) return; -for_each_cpu(i) { +stp_for_each_cpu(i) { MAP m = per_cpu_ptr (pmap->map, i); #if NEED_MAP_LOCKS spin_lock(&m->lock); < at >< at > -410,7 +410,7 < at >< at > void _stp_pmap_del(PMAP pmap) if (pmap == NULL) return; -for_each_cpu(i) { +stp_for_each_cpu(i) { MAP m = per_cpu_ptr (pmap->map, i); __stp_map_del(m); } < at >< at > -740,7 +740,7 < at >< at > MAP _stp_pmap_agg (PMAP pmap) /* every time we aggregate. which would be best? */ _stp_map_clear (agg); -for_each_cpu(i) { +stp_for_each_cpu(i) { m = per_cpu_ptr (pmap->map, i); #if NEED_MAP_LOCKS spin_lock(&m->lock); < at >< at > -916,7 +916,7 < at >< at > int _stp_pmap_size (PMAP pmap) { int i, num = 0; -for_each_cpu(i) { +stp_for_each_cpu(i) { MAP m = per_cpu_ptr (pmap->map, i); num += m->num; } diff --git a/runtime/pmap-gen.c b/runtime/pmap-gen.c index 8666549..7f7ddeb 100644 --- a/runtime/pmap-gen.c +++ b/runtime/pmap-gen.c < at >< at > -406,7 +406,7 < at >< at > PMAP KEYSYM(_stp_pmap_new) (unsigned max_entries) if (pmap) { int i; MAP m; -for_each_cpu(i) { +stp_for_each_cpu(i) { m = (MAP)per_cpu_ptr (pmap->map, i); m->get_key = KEYSYM(pmap_get_key); m->copy = KEYSYM(pmap_copy_keys); < at >< at > -459,7 +459,7 < at >< at > PMAP KEYSYM(_stp_pmap_new) (unsigned max_entries, int htype, ...) if (pmap) { int i; MAP m; -for_each_cpu(i) { +stp_for_each_cpu(i) { m = per_cpu_ptr (pmap->map, i); m->get_key = KEYSYM(pmap_get_key); m->copy = KEYSYM(pmap_copy_keys); < at >< at > -649,7 +649,7 < at >< at > VALTYPE KEYSYM(_stp_pmap_get) (PMAP pmap, ALLKEYSD(key)) } /* now total each cpu */ -for_each_cpu(cpu) { +stp_for_each_cpu(cpu) { map = per_cpu_ptr (pmap->map, cpu); head = &map->hashes[hv]; diff --git a/runtime/runtime.h b/runtime/runtime.h index cd3d0b1..7507e59 100644 --- a/runtime/runtime.h +++ b/runtime/runtime.h < at >< at > -39,8 +39,14 < at >< at > #define STP_OLD_TRANSPORT #endif -#ifndef for_each_cpu -#define for_each_cpu(cpu) for_each_cpu_mask((cpu), cpu_possible_map) +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28) +#ifndef stp_for_each_cpu +#define stp_for_each_cpu(cpu) for_each_cpu((cpu), cpu_possible_map) +#endif +#else +#ifndef stp_for_each_cpu +#define stp_for_each_cpu(cpu) for_each_cpu_mask((cpu), cpu_possible_map) +#endif #endif static void _stp_dbug (const char *func, int line, const char *fmt, ...); diff --git a/runtime/stat.c b/runtime/stat.c index 8bd7bf1..e40a4f2 100644 --- a/runtime/stat.c +++ b/runtime/stat.c < at >< at > -109,7 +109,7 < at >< at > Stat _stp_stat_init (int type, ...) #if NEED_STAT_LOCKS == 1 { int i; -for_each_cpu(i) { +stp_for_each_cpu(i) { stat *sdp = per_cpu_ptr (sd, i); spin_lock_init(sdp->lock); } < at >< at > -210,7 +210,7 < at >< at > stat *_stp_stat_get (Stat st, int clear) STAT_LOCK(agg); _stp_stat_clear_data (st, agg); -for_each_cpu(i) { +stp_for_each_cpu(i) { stat *sd = per_cpu_ptr (st->sd, i); STAT_LOCK(sd); if (sd->count) { < at >< at > -245,7 +245,7 < at >< at > stat *_stp_stat_get (Stat st, int clear) void _stp_stat_clear (Stat st) { int i; -for_each_cpu(i) { +stp_for_each_cpu(i) { stat *sd = per_cpu_ptr (st->sd, i); STAT_LOCK(sd); _stp_stat_clear_data (st, sd); diff --git a/runtime/transport/procfs.c b/runtime/transport/procfs.c index e0ecd9b..ca33e0f 100644 --- a/runtime/transport/procfs.c +++ b/runtime/transport/procfs.c < at >< at > -328,7 +328,7 < at >< at > static int _stp_register_ctl_channel(void) #ifdef STP_BULKMODE /* now for each cpu "n", create /proc/systemtap/module_name/n */ -for_each_cpu(i) { +stp_for_each_cpu(i) { sprintf(buf, "%d", i); de = create_proc_entry(buf, 0600, _stp_proc_root); if (de == NULL) < at >< at > -361,7 +361,7 < at >< at > err1: #ifdef STP_BULKMODE for (de = _stp_proc_root->subdir; de; de = de->next) _stp_kfree(de->data); -for_each_cpu(j) { +stp_for_each_cpu(j) { if (j == i) break; sprintf(buf, "%d", j); < at >< at > -389,7 +389,7 < at >< at > static void _stp_unregister_ctl_channel(void) for (de = _stp_proc_root->subdir; de; de = de->next) _stp_kfree(de->data); -for_each_cpu(i) { +stp_for_each_cpu(i) { sprintf(buf, "%d", i); remove_proc_entry(buf, _stp_proc_root); } Wenji Huang 2008-11-14T07:07:12 http://comments.gmane.org/gmane.linux.systemtap/10295 Hi, These are test results on 2.6.28-rc4 from labrat. In fact, stap couldn't work on 2.6.28-rc4 due to kernel change in include/linux/cpumask.h. +#define for_each_cpu(cpu, mask) \ + for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask) in commit cb56d98e2a7530615899597551db685d68a2e852. Unfortunately, Stap has own for_each_cpu macro in runtime/runtime.h The conflict will cause compilation error even the simplest script like 'probe begin{}'. To make test running, I temporarily disabled kernel for_each_cpu macro. Maybe this will affect test results. Anyway, the problem needs a long term solution. Maybe we can get rid of for_each_cpu, use for_each_cpu_mask directed. Regards, Wenji ------------------------------------------------------------------------------ Package: systemtap_snapshot (0.7.1/0.131-master(589db2fc)-2.6.28_rc4-snapshot) Previous build: 2008/11/03 09:15:54 - 2008/11/03 09:15:54 Current build: 2008/11/11 02:25:03 - 2008/11/11 02:25:03 Host: rctest-32 Platform: Linux 2.6.28-rc4 i386 (EL4U6) (before: Linux 2.6.28-rc3 i386 (EL4U6)) URL: http://build.alchar.org/cgi/showBuild?host=rctest-32&pkg=systemtap_snapshot&date=20081111-022503 First failure: test Test result: 823: 760 +, 34 -, 29 S, 0 E (before: 825: 760 +, 36 -, 29 S, 0 E) Old -> New Test ----- ----- ---------------------------------- PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit alarm) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit uid16) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit unlink) FAIL -> N/A test - systemtap.stress/current.exp(systemtap.stress/current.stp shutdown) N/A -> PASS test - systemtap.stress/current.exp(systemtap.stress/current.stp shutdown and output) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit dir) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit select) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit stat) FAIL -> N/A test - systemtap.examples/check.exp(systemtap.examples/general/para-callgraph run) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit mmap) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit chmod) FAIL -> PASS test - systemtap.syscall/syscall.exp(32-bit acct) PASS -> N/A test - systemtap.examples/check.exp(systemtap.examples/profiling/functioncallcount run) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit clock) ------------------------------------------------------------------------------ Package: systemtap_snapshot (0.7.1/0.131-master(589db2fc)-2.6.28_rc4-snapshot) Previous build: 2008/11/04 09:47:14 - 2008/11/04 09:47:14 Current build: 2008/11/11 09:55:56 - 2008/11/11 09:55:56 Host: rctest-64 Platform: Linux 2.6.28-rc4 x86_64 (EL5.2) (before: Linux 2.6.28-rc3 x86_64 (EL5.2)) URL: http://build.alchar.org/cgi/showBuild?host=rctest-64&pkg=systemtap_snapshot&date=20081111-095556 First failure: test Test result: 854: 787 +, 36 -, 31 S, 0 E (before: 854: 793 +, 30 -, 31 S, 0 E) Old -> New Test ----- ----- ---------------------------------- N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit alarm) FAIL -> N/A test - systemtap.syscall/syscall.exp(64-bit dir) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit link) PASS -> N/A test - systemtap.syscall/syscall.exp(alarm) PASS -> FAIL test - systemtap.base/global_end.exp(global_end) PASS -> FAIL test - systemtap.samples/queue_demo.exp(queue_demo) N/A -> PASS test - systemtap.syscall/syscall.exp(dir) PASS -> N/A test - systemtap.syscall/syscall.exp(net1) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit umask) PASS -> N/A test - systemtap.syscall/syscall.exp(link) PASS -> FAIL test - systemtap.syscall/syscall.exp(32-bit timer) N/A -> FAIL test - systemtap.syscall/syscall.exp(64-bit net1) Wenji Huang 2008-11-14T02:32:46 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.systemtap