gmane.linux.nfs

[PATCH 0/3] AF_INET6 support for probe_bothports()

Chuck Lever — 2008-12-02T17:59:44

Hi Steve- Here's the next step. This small series of patches rewires probe_bothports() to support AF_INET6 addresses, now that the underlying functions can handle them. Since legacy code in other parts of the mount command still use probe_bothports() and the clnt_addr_t data type, I've added a new function call to do the IPv6 duties. The old API still exists and continues to support only AF_INET, but under the covers it calls the new code. Again, for the time being, this is used only for the legacy binary mount(2) interface. We will need this for umount later, and that is used to support both binary and text-based mounts. --- Chuck Lever (3): mount command: AF_INET6 support for probe_bothports() mount command: support AF_INET6 in probe_nfsport() and probe_mntport() mount command: full support for AF_INET6 addresses in probe_port() utils/mount/network.c | 178 +++++++++++++++++++++++++++++++++++++++---------- utils/mount/network.h | 3 + 2 files changed, 144 insertions(+), 37 deletions(-)

[PATCH/RFC] svcgssd always sets an infinite expiry on authentication tokens etc.

Neil Brown — 2008-12-02T05:18:17

Hi, I have a report of an NFS server which runs out of kernel memory when it gets heave rpcsec_gss traffic (auth_sys doesn't trigger the problem so it must be gss related). From looking at /proc/slab_allocators it seems that the main user of memory is the rsc and rsi caches. It appears entries are inserted into these caches with an expiry of 'forever' so they grow but never shrink. We should fix this. For the rsi (init) cache I assume the entry is only needed once so a short expiry of (say) one minute should be plenty. For the rsc (context) cache, the entry could be needed repeatedly during the lifetime of a 'session'. However eventually it will become stale and should be allowed to expire. I assume that if the kernel requests a particular entry a second time, an hour later, it will get the same answer - is that correct? In that case, setting the expiry to something largish seems appropriate. Hence the following patch (untested yet - but I will get it tested in due course). Does this seem reasonable? Thanks, NeilBrown diff --git a/utils/gssd/svcgssd_proc.c b/utils/gssd/svcgssd_proc.c index 794c2f4..088a007 100644 --- a/utils/gssd/svcgssd_proc.c +++ b/utils/gssd/svcgssd_proc.c < at >< at > -86,7 +86,9 < at >< at > do_svc_downcall(gss_buffer_desc *out_handle, struct svc_cred *cred, } qword_printhex(f, out_handle->value, out_handle->length); /* XXX are types OK for the rest of this? */ -qword_printint(f, 0x7fffffff); /*XXX need a better timeout */ + +/* 'context' could be needed for a while. */ +qword_printint(f, time(0) + 60*60); qword_printint(f, cred->cr_uid); qword_printint(f, cred->cr_gid); qword_printint(f, cred->cr_ngroups); < at >< at > -130,7 +132,8 < at >< at > send_response(FILE *f, gss_buffer_desc *in_handle, gss_buffer_desc *in_token, qword_addhex(&bp, &blen, in_handle->value, in_handle->length); qword_addhex(&bp, &blen, in_token->value, in_token->length); -qword_addint(&bp, &blen, 0x7fffffff); /*XXX need a better timeout */ +/* INIT context info will only be needed for a short while */ +qword_addint(&bp, &blen, time(0) + 60); qword_adduint(&bp, &blen, maj_stat); qword_adduint(&bp, &blen, min_stat); qword_addhex(&bp, &blen, out_handle->value, out_handle->length); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/1] lockd: convert reclaimer thread to kthread interface

2008-12-01T22:27:48

From: Jeff Layton public.gmane.org> My understanding is that there is a push to turn the kernel_thread interface into a non-exported symbol and move all kernel threads to use the kthread API. This patch changes lockd to use kthread_run to spawn the reclaimer thread. I've made the assumption here that the extra module references taken when we spawn this thread are unnecessary and removed them. I've also added a KERN_ERR printk that pops if the thread can't be spawned to warn the admin that the locks won't be reclaimed. In the future, it would be nice to be able to notify userspace that locks have been lost (probably by implementing SIGLOST), and adding some good policies about how long we should reattempt to reclaim the locks. Finally, I removed a comment about memory leaks that I believe is obsolete and added a new one to clarify the result of sending a SIGKILL to the reclaimer thread. As best I can tell, doing so doesn't actually cause a memory leak. Signed-off-by: Jeff Layton public.gmane.org> Cc: Trond Myklebust public.gmane.org> Cc: "J. Bruce Fields" public.gmane.org> Signed-off-by: Andrew Morton public.gmane.org> --- fs/lockd/clntlock.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff -puN fs/lockd/clntlock.c~lockd-convert-reclaimer-thread-to-kthread-interface fs/lockd/clntlock.c --- a/fs/lockd/clntlock.c~lockd-convert-reclaimer-thread-to-kthread-interface +++ a/fs/lockd/clntlock.c < at >< at > -14,6 +14,7 < at >< at > #include #include #include +#include #define NLMDBG_FACILITYNLMDBG_CLIENT < at >< at > -191,11 +192,15 < at >< at > __be32 nlmclnt_grant(const struct sockad void nlmclnt_recovery(struct nlm_host *host) { +struct task_struct *task; + if (!host->h_reclaiming++) { nlm_get_host(host); -__module_get(THIS_MODULE); -if (kernel_thread(reclaimer, host, CLONE_FS | CLONE_FILES) < 0) -module_put(THIS_MODULE); +task = kthread_run(reclaimer, host, "%s-reclaim", host->h_name); +if (IS_ERR(task)) +printk(KERN_ERR "lockd: unable to spawn reclaimer " +"thread. Locks for %s won't be reclaimed! " +"(%ld)\n", host->h_name, PTR_ERR(task)); } } < at >< at > -207,7 +212,6 < at >< at > reclaimer(void *ptr) struct file_lock *fl, *next; u32 nsmstate; -daemonize("%s-reclaim", host->h_name); allow_signal(SIGKILL); down_write(&host->h_rwsem); < at >< at > -233,7 +237,12 < at >< at > restart: list_for_each_entry_safe(fl, next, &host->h_reclaim, fl_u.nfs_fl.list) { list_del_init(&fl->fl_u.nfs_fl.list); -/* Why are we leaking memory here? --okir */ +/* + * sending this thread a SIGKILL will result in any unreclaimed + * locks being removed from the h_granted list. This means that + * the kernel will not attempt to reclaim them again if a new + * reclaimer thread is spawned for this host. + */ if (signalled()) continue; if (nlmclnt_reclaim(host, fl) != 0) < at >< at > -261,5 +270,5 < at >< at > restart: nlm_release_host(host); lockd_down(); unlock_kernel(); -module_put_and_exit(0); +return 0; } _ -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[NFS] D entists Contact List for the USA

Strong O Karin — 2008-12-01T22:04:01

Comes with unlimited use license and at a very resonable price: --> 164,574 |>entists --> 158,242 Physical Addresses --> 163,185 Phone Numbers --> 77,878 Office Fax Numbers --> 45,954 e mails only during this week you won't pay the regular $593 price, you get it for $296 Write an email to Monroe-YiFMxoQ3Mhodw2Fo+rOw49BPR1lH4CV8< at >public.gmane.org for additional info to get off please email exclude-YiFMxoQ3Mhodw2Fo+rOw49BPR1lH4CV8< at >public.gmane.org ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ NFS maillist - NFS-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org https://lists.sourceforge.net/lists/listinfo/nfs _______________________________________________ Please note that nfs-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org is being discontinued. Please subscribe to linux-nfs-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org instead. http://vger.kernel.org/vger-lists.html#linux-nfs -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/6] First set of patches for 2.6.29

Chuck Lever — 2008-12-01T18:57:25

These patches add some IPv6 support to the Linux kernel's NSM upcall implementation, and address a couple of shortcomings in the existing NLM/NSM implementation. I'd like you to consider these for 2.6.29. There are 40 more patches I have queued for 2.6.29 that finish IPv6 support in the NSM upcall implementation, enable IPv6 for lockd, and finish and enable IPv6 support in NFSD. --- Chuck Lever (6): NSM: Serialize SM_MON and SM_UNMON upcalls NLM: Clean up nsm_monitor() call NLM: Clean up nsm_monitor() call NSM: Support IPv6 version of mon_name NLM: Support IPv6 scope IDs in nlm_display_address() NLM: Remove address eye-catcher buffers from nlm_host fs/lockd/host.c | 53 ++++++++++-------- fs/lockd/mon.c | 120 +++++++++++++++++++++------------------- include/linux/lockd/lockd.h | 21 ++++++- include/linux/lockd/sm_inter.h | 2 - 4 files changed, 109 insertions(+), 87 deletions(-)

[PATCH 0/4] Make mount.nfs use new getport() function

Chuck Lever — 2008-12-01T18:48:33

Hi Steve- Four new IPv6-related patches for mount.nfs. These replace the existing PMAP_GETPORT implementation in utils/mount/network.c with a call to the new library functions we just added. The probe_statd() function is used by both the legacy and the text- based paths, but replacing the mount.nfs command's getport() function affects only the *legacy* NFS mount path, not text-based mounts. For anyone testing this code, please try it on pre-2.6.23 kernels, or patch mount.nfs to use legacy binary style mounts. This will exercise the new PMAP_GETPORT implementation using all the special cases needed by mount.nfs. The new RPCB_GETADDR implementation will not be used until mount.nfs can pass in IPv6 addresses. --- Chuck Lever (4): mount command: remove local getport() implementation mount command: Replace clnt_ping() and getport() calls in probe_port() mount command: Use nfs_error() instead of perror() mount command: Use nfs_pmap_getport() in probe_statd() utils/mount/network.c | 144 +++++++++++++++---------------------------------- 1 files changed, 43 insertions(+), 101 deletions(-)

[PATCH] nfs: remove redundant tests on reading new pages

Wu Fengguang — 2008-12-01T03:19:22

aops->readpages() and its NFS helper readpage_async_filler() will only be called to do readahead I/O for newly allocated pages. So it's not necessary to test for the always 0 dirty/uptodate page flags. The removal of nfs_wb_page() call also fixes a readahead bug: the NFS readahead has been synchronous since 2.6.23, because that call will clear PG_readahead, which is the reminder for asynchronous readahead. More background: the PG_readahead page flag is shared with PG_reclaim, one for read path and the other for write path. clear_page_dirty_for_io() unconditionally clears PG_readahead to prevent possible readahead residuals, assuming itself to be always called in the write path. However, NFS is one and the only exception in that it _always_ calls clear_page_dirty_for_io() in the read path, i.e. for readpages()/readpage(). Cc: Trond Myklebust public.gmane.org> Signed-off-by: Wu Fengguang public.gmane.org> --- fs/nfs/read.c | 6 ------ 1 file changed, 6 deletions(-) This bug was found when playing with my readahead tracing module posted at http://lkml.org/lkml/2008/11/27/373 and confirmed to work. The NFS readahead traces are now [ 59.972526] readahead-initial0(pid=3646(dd), dev=00:0f(0:f), ino=293189(1G), req=0+25, ra=0+60-30, async=0) = 60 [ 59.992734] readahead-subsequent(pid=3646(dd), dev=00:0f(0:f), ino=293189(1G), req=30+20, ra=60+30-30, async=1) = 30 [ 60.030900] readahead-subsequent(pid=3646(dd), dev=00:0f(0:f), ino=293189(1G), req=60+15, ra=90+30-30, async=1) = 30 [ 60.031687] readahead-subsequent(pid=3646(dd), dev=00:0f(0:f), ino=293189(1G), req=90+10, ra=120+30-30, async=1) = 30 The async field was always 0 before this patch. --- linux-2.6.orig/fs/nfs/read.c +++ linux-2.6/fs/nfs/read.c < at >< at > -533,12 +533,6 < at >< at > readpage_async_filler(void *data, struct unsigned int len; int error; -error = nfs_wb_page(inode, page); -if (error) -goto out_unlock; -if (PageUptodate(page)) -goto out_unlock; - len = nfs_page_length(page); if (len == 0) return nfs_return_empty_page(page); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

ipv6 status

Brian J. Murrell — 2008-12-01T00:40:16

Hi All, So what exactly is the status of NFS and IPv6 in the most recent (say, 2.6.24-28) kernels? Is it present and if so, working? Feel free to simply point me to a roadmap that shows where we are if you like. Cheers and thanx, b.

No write access with recent versions of nfs-utils in Debian

David Liontooth — 2008-11-30T22:13:49

This appears to be a Debian-specific issue, so I'm just looking for a pointer from someone who may know about it. I installed Debian sid on a new machine back in July, including the current nfs-common and nfs-kernel-server. NFS mounts were successful, but did not allow write -- I lost some serious data on one occasion before I noticed the problem. mount and nfs-utils were upgraded several times since, and never gave the requested write access. I've been assuming the problem was firewall-related and lived with it. On the other machines in the group, NFS writes worked fine. I banged my head against the wall for a while today, after finally finding time to look into the problem, and discovered a completely different version of nfs-utils was running on the new machine. After a painful downgrade things work fine again. Here's the verbose output of the version that didn't work, nfs-common 1:1.1.3-2: mount -vvv /mnt/cortona1 mount: fstab path: "/etc/fstab" mount: lock path: "/etc/mtab~" mount: temp path: "/etc/mtab.tmp" mount: spec: "cortona:/tv1" mount: node: "/mnt/cortona1" mount: types: "nfs" mount: opts: "noauto,user,exec,rw,rsize=16k,wsize=16k,hard,intr" mount: external mount: argv[0] = "/sbin/mount.nfs" mount: external mount: argv[1] = "cortona:/tv1" mount: external mount: argv[2] = "/mnt/cortona1" mount: external mount: argv[3] = "-v" mount: external mount: argv[4] = "-o" mount: external mount: argv[5] = "rw,nosuid,nodev,noauto,user,rsize=16k,wsize=16k,hard,intr" mount.nfs: trying xxx.xxx.xxx.178 prog 100003 vers 3 prot TCP port 2049 mount.nfs: trying xxx.xxx.xxx.178 prog 100005 vers 3 prot UDP port 32774 cortona:/tv1 on /mnt/cortona1 type nfs (noauto,user,exec,rw,rsize=16k,wsize=16k,hard,intr) tna< at >roma$ cd /mnt/cortona1 tna< at >roma:/mnt/cortona1$ touch one touch: cannot touch `one': Permission denied Downgrading to 1:1.1.0-5 restored proper write access. Is this a familiar-looking problem to someone? Dave -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Is order for "exportfs -r" and rpc.mountd important?

Dr. Tilmann Bubeck — 2008-11-28T14:41:38

According to manual page "exportfs -r" has two modes: legacy and new. Fedora 10 seems to use the new mode and mounts /proc/fs/nfsd. But they use the following order in /etc/init.d/nfs: exportfs -r rpc.mountd This results in /proc/fs/nfsd/exports having all obsolete entries from /var/lib/nfs/rmtab which causes a lot of trouble with stale NFS file handles. This seems to be wrong according to "man exportfs" in new mode. If I change the order to rpc.mountd exportfs -r then everything is OK and /proc/fs/nfsd/exports only contains the info from /etc/exports and not all stale clients. This seems to be correct according to "man exportfs" in new mode. Questions: is this behaviour a bug or at least bad? Shouldn't exportfs being changed, so that when it detects "new" mode it will never feed rmtab into the kernel and rely upon rpc.mountd answering the kernels questions as stated in "man exportfs"? If yes, then the order or the programs is irrelevant. If not, should the order of the programs be reversed in Fedora? Thanks Till

[PATCH 1/1] NFS: fix ERR_PTR with un mapped NFSv4 error

2008-11-26T22:49:00

From: Andy Adamson public.gmane.org> NFSv4 errors need to be mapped prior to ERR_PTR. Signed-off-by: Andy Adamson public.gmane.org> --- fs/nfs/client.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 7547600..49f06ce 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c < at >< at > -1154,7 +1154,7 < at >< at > struct nfs_server *nfs4_create_server(const struct nfs_parsed_mount_data *data, error: nfs_free_server(server); dprintk("<-- nfs4_create_server() = error %d\n", error); -return ERR_PTR(error); +return ERR_PTR(nfs4_map_errors(error)); } /* < at >< at > -1231,7 +1231,7 < at >< at > struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, error: nfs_free_server(server); dprintk("<-- nfs4_create_referral_server() = error %d\n", error); -return ERR_PTR(error); +return ERR_PTR(nfs4_map_errors(error)); } #endif /* CONFIG_NFS_V4 */ < at >< at > -1299,7 +1299,7 < at >< at > struct nfs_server *nfs_clone_server(struct nfs_server *source, out_free_server: nfs_free_server(server); dprintk("<-- nfs_clone_server() = error %d\n", error); -return ERR_PTR(error); +return ERR_PTR(nfs4_map_errors(error)); } #ifdef CONFIG_PROC_FS

[NFS] Comprehensive Healthcare Marketing List

Elizabeth N Ritter — 2008-11-26T17:36:41

Certified Medical Doctors in the US Medical Doctors in many different specialties you can sort by many different fields like city, state or zip Regular price is $494 but this week you only pay: $399 ~~~~~ These lists come at no charge when you order: ~~~~~ --> Dentists --> Veterinarians --> Physical Therapists --> Visiting Nurses & RN's Email us at:: Benitez-Px9Zx9/iZEOakBO8gow8eQ< at >public.gmane.org this offer is only valid until Nov 28, 2008 ============== To invoke no further correspondence status please send an email to gone-Px9Zx9/iZEOakBO8gow8eQ< at >public.gmane.org ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ NFS maillist - NFS-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org https://lists.sourceforge.net/lists/listinfo/nfs _______________________________________________ Please note that nfs-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org is being discontinued. Please subscribe to linux-nfs-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org instead. http://vger.kernel.org/vger-lists.html#linux-nfs -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Patch to prevent rpc.gssd spamming logs when Kerberos credentials are expired

Andrew Pollock — 2008-11-25T21:22:21

Hi, We've seen excessive (disk filling) log spam from rpc.gssd where users mount their home directory via Kerberised NFS, and their Kerberos TGT expires. You get lots of noise like described at https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/293705 Attached is the patch that we've been using to address this. regards Andrew -- Andrew Pollock Google Systems Administrator

[NFS] Database of geriatric specialists and more

Harvey spiky — 2008-11-25T15:56:27

Fully Licensed MDs in the US Coverage in many different areas of medicine such as Endocrinology, Pathology, Urology, Neurology, Plastic Surgery, Psychiatry, Cardiology and much more you can sort by many different fields like city, state or zip This week's special price = $394 ***** Order this week and you will get at no charge: ***** <> Chiropractors <> Physical Therapists <> Massage Therapists <> Acupuncturists contact your rep:: Calhoun-Px9Zx9/iZEOakBO8gow8eQ< at >public.gmane.org from now until Friday . have a look at this if you don't like to recieve these kinds of emails please send an email to gone-Px9Zx9/iZEOakBO8gow8eQ< at >public.gmane.org ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ NFS maillist - NFS-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org https://lists.sourceforge.net/lists/listinfo/nfs _______________________________________________ Please note that nfs-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org is being discontinued. Please subscribe to linux-nfs-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org instead. http://vger.kernel.org/vger-lists.html#linux-nfs -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] NLM: client-side nlm_lookup_host() should avoid matching onsrcaddr

Chuck Lever — 2008-11-24T17:51:55

Since commit c98451bd, the loop in nlm_lookup_host() unconditionally compares the host's h_srcaddr field to the incoming source address. For client-side nlm_host entries, both are always AF_UNSPEC, so this check is unnecessary. Since commit 781b61a6, which added support for AF_INET6 addresses to nlm_cmp_addr(), nlm_cmp_addr() now returns FALSE for AF_UNSPEC addresses, which causes nlm_lookup_host() to create a fresh nlm_host entry every time it is called on the client. These extra entries will eventually expire once the server is unmounted, so the impact of this regression, introduced with lockd IPv6 support in 2.6.28, should be minor. We could fix this by adding an arm in nlm_cmp_addr() for AF_UNSPEC addresses, but really, nlm_lookup_host() shouldn't be matching on the srcaddr field for client-side nlm_host lookups. Signed-off-by: Chuck Lever public.gmane.org> --- fs/lockd/host.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/lockd/host.c b/fs/lockd/host.c index 9fd8889..70fc63a 100644 --- a/fs/lockd/host.c +++ b/fs/lockd/host.c < at >< at > -167,7 +167,8 < at >< at > static struct nlm_host *nlm_lookup_host(struct nlm_lookup_host_info *ni) continue; if (host->h_server != ni->server) continue; -if (!nlm_cmp_addr(nlm_srcaddr(host), ni->src_sap)) +if (ni->server && + !nlm_cmp_addr(nlm_srcaddr(host), ni->src_sap)) continue; /* Move to head of hash chain. */ -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH nfs-utils] Ensure statd gets started if required when non-root user mounts an NFS filesystem.

Neil Brown — 2008-11-24T00:07:19

openSUSE-11.1 betas rely in mount.nfs to start statd when required. This helped me discover that it doesn't work when a non-root user is mounting a filesystem as the setuid status gets lots. This patch fixes it. Thanks, NeilBrown From 78d2001f031553ef90db708d5a7b3fbb9b31a873 Mon Sep 17 00:00:00 2001 From: Neil Brown public.gmane.org> Date: Mon, 24 Nov 2008 11:00:19 +1100 Subject: [PATCH] Ensure statd gets started if required when non-root user mounts an NFS filesystem. The first time an NFS filesystem is mounted, we start statd from /sbin/mount.nfs. If this first time is a non-root user doing the mount, (thanks to e.g. the 'users' option in /etc/fstab) then we need to be sure that the 'setuid' status from mount.nfs is inherited through to rpc.statd so that it runs as root. There are two places where we loose our setuid status due to the shell (/bin/sh) discarding. 1/ mount.nfs uses "system" to run /usr/sbin/start-statd. This runs a shell which is likely to drop privileges. So change that code to use 'fork' and 'execl' explicitly. 2/ start-statd is a shell script. To convince the shell to allow the program to run in privileged mode, we need to add a "-p" flag. We could just call setuid(getuid()) at some appropriate time, and it might be worth doing that as well, however I think that getting rid of 'system()' is a good idea and once that is done, the adding of '-p' is trivial and sufficient. Signed-off-by: Neil Brown public.gmane.org> --- utils/mount/network.c | 13 ++++++++++++- utils/statd/start-statd | 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/utils/mount/network.c b/utils/mount/network.c index 2db694d..541003a 100644 --- a/utils/mount/network.c +++ b/utils/mount/network.c < at >< at > -705,7 +705,18 < at >< at > int start_statd(void) #ifdef START_STATD if (stat(START_STATD, &stb) == 0) { if (S_ISREG(stb.st_mode) && (stb.st_mode & S_IXUSR)) { -system(START_STATD); +pid_t pid = fork(); +switch (pid) { +case 0: /* child */ +execl(START_STATD, START_STATD, NULL); +exit(1); +case -1: /* error */ +perror("Fork failed"); +break; +default: /* parent */ +waitpid(pid, NULL,0); +break; +} if (probe_statd()) return 1; } diff --git a/utils/statd/start-statd b/utils/statd/start-statd index 6e7ea04..c7805ee 100644 --- a/utils/statd/start-statd +++ b/utils/statd/start-statd < at >< at > -1,4 +1,4 < at >< at > -#!/bin/sh +#!/bin/sh -p # nfsmount calls this script when mounting a filesystem with locking # enabled, but when statd does not seem to be running (based on # /var/run/rpc.statd.pid).

[PATCH] svcsock: Add a reference to sunrpc in svc_addsock

Tom Tucker — 2008-11-23T14:08:36

The svc_addsock function adds transport instances without taking a reference on the sunrpc.ko module, however, the generic transport destruction code drops a reference when a transport instance is destroyed. Add a try_module_get call to the svc_addsock function for transport instances added by this function. Signed-off-by: Tom Tucker public.gmane.org> --- net/sunrpc/svcsock.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 95293f5..a1951dc 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c < at >< at > -1183,7 +1183,11 < at >< at > int svc_addsock(struct svc_serv *serv, else if (so->state > SS_UNCONNECTED) err = -EISCONN; else { -svsk = svc_setup_socket(serv, so, &err, SVC_SOCK_DEFAULTS); +if (!try_module_get(THIS_MODULE)) +err = -ENOENT; +else +svsk = svc_setup_socket(serv, so, &err, +SVC_SOCK_DEFAULTS); if (svsk) { struct sockaddr_storage addr; struct sockaddr *sin = (struct sockaddr *)&addr; < at >< at > -1196,7 +1200,8 < at >< at > int svc_addsock(struct svc_serv *serv, spin_unlock_bh(&serv->sv_lock); svc_xprt_received(&svsk->sk_xprt); err = 0; -} +} else +module_put(THIS_MODULE); } if (err) { sockfd_put(so); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] NLM: AF_UNSPEC addresses are all equal

Chuck Lever — 2008-11-22T16:58:08

The nlm_cmp_addr() function, which compares two IP addresses, is sometimes used to check AF_UNSPEC addresses. If both addresses are AF_UNSPEC, then it should consider them equal -- the contents of an AF_UNSPEC address, other than the address family, are inconsequential. This is important because the loop in nlm_lookup_host() always compares the h_srcaddr field to the incoming source address. For client nlm_host entries, both are always AF_UNSPEC, and should allow the entry match to succeed. If it always fails, then we create a fresh nlm_host entry every time we mount the same server, even if all other items in the existing entry (protocol, NLM version, host address) match. These extra entries will eventually expire once the server is unmounted, so the impact of this bug, introduced in 2.6.28 with commit 781b61a6, should be minor. Signed-off-by: Chuck Lever public.gmane.org> --- Bruce- Another minor lockd IPv6 bug fix for 2.6.28. Alternate fix for this problem is to change nlm_lookup_host() so that it compares the srcaddrs only when h_server is set. include/linux/lockd/lockd.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/lockd/lockd.h b/include/linux/lockd/lockd.h index b56d5aa..e8aa108 100644 --- a/include/linux/lockd/lockd.h +++ b/include/linux/lockd/lockd.h < at >< at > -344,6 +344,8 < at >< at > static inline int nlm_cmp_addr(const struct sockaddr *sap1, { if (sap1->sa_family == sap2->sa_family) { switch (sap1->sa_family) { +case AF_UNSPEC: +return 1; case AF_INET: return __nlm_cmp_addr4(sap1, sap2); case AF_INET6: -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[NFS] General Dentists List in America

Roman Dalton — 2008-11-21T04:34:07

Just Released: for the USA --> 164,341 D entists --> 158,048 Postal Addresses --> 163,958 Tel #'s --> 77,093 Fax Numbers --> 45,870 E-Mail Addresses for only this week you can take the above with unlimited use rights for $297 - a $594 value Write an email to Dalton-W3yqWAQfaE6Bik42HM7KXg< at >public.gmane.org for additional info By emailing release-W3yqWAQfaE6Bik42HM7KXg< at >public.gmane.org you will have your email taken off ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ NFS maillist - NFS-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org https://lists.sourceforge.net/lists/listinfo/nfs _______________________________________________ Please note that nfs-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org is being discontinued. Please subscribe to linux-nfs-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org instead. http://vger.kernel.org/vger-lists.html#linux-nfs -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] SUNRPC: Fix a performance regression in the RPC authentication code

Trond Myklebust — 2008-11-20T21:06:21

Fix a regression reported by Max Kellermann whereby kernel profiling showed that his clients were spending 45% of their time in rpcauth_lookup_credcache. It turns out that although his processes had identical uid/gid/groups, generic_match() was failing to detect this, because the task->group_info pointers were not shared. This again lead to the creation of a huge number of identical credentials at the RPC layer. The regression is fixed by comparing the contents of task->group_info if the actual pointers are not identical. Signed-off-by: Trond Myklebust public.gmane.org> --- net/sunrpc/auth_generic.c | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c index 744b79f..4028502 100644 --- a/net/sunrpc/auth_generic.c +++ b/net/sunrpc/auth_generic.c < at >< at > -133,13 +133,29 < at >< at > static int generic_match(struct auth_cred *acred, struct rpc_cred *cred, int flags) { struct generic_cred *gcred = container_of(cred, struct generic_cred, gc_base); +int i; if (gcred->acred.uid != acred->uid || gcred->acred.gid != acred->gid || - gcred->acred.group_info != acred->group_info || gcred->acred.machine_cred != acred->machine_cred) -return 0; +goto out_nomatch; + +/* Optimisation in the case where pointers are identical... */ +if (gcred->acred.group_info == acred->group_info) +goto out_match; + +/* Slow path... */ +if (gcred->acred.group_info->ngroups != acred->group_info->ngroups) +goto out_nomatch; +for (i = 0; i < gcred->acred.group_info->ngroups; i++) { +if (GROUP_AT(gcred->acred.group_info, i) != +GROUP_AT(acred->group_info, i)) +goto out_nomatch; +} +out_match: return 1; +out_nomatch: +return 0; } void __init rpc_init_generic_auth(void)

nfs-utils, umount -l, and unmount requests

David Mathog — 2008-11-19T23:54:42

[I hope this is the right place to send this. I tried agud-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org, who is listed on the relevant file's copyright, but that mailbox was disabled.] This concerns nfsmount.c in nfs-utils-1.1.4. I spent most of today trying to figure out why after upgrading an NFS client machine from Mandriva 2007.1 to 2008.1 suddenly the NFS server stopped logging "authenticated unmount request" messages when the client rebooted. It turned out this was a consequence of the umount "-l" flag, which is used in the shutdown scripts and the many recent changes in the organization of the umount commands. Long story short, under Mandriva 2007.1 umount looked for umount.nfs, which was not present in that release, and then went on to send the unmount request itself. On Mandriva 2008.1, where umount.nfs is present, the ball was passed to this program, which promptly dropped it if "-l" had been specified. The NFS directory was unmounted correctly, but the "unmount request" was never sent. I traced this issue down to these lines of code in nfsumount.c, starting at line 351 (some may wrap): if (mc) { if (!lazy && strcmp(mc->m.mnt_type, "nfs4") != 0) /* We ignore the error from do_nfs_umount23. * If the actual umount succeeds (in del_mtab), * we don't want to signal an error, as that * could cause /sbin/mount to retry! */ do_nfs_umount23(mc->m.mnt_fsname, mc->m.mnt_opts); ret = del_mtab(mc->m.mnt_fsname, mc->m.mnt_dir); } else if (*spec != '/') { if (!lazy) ret = do_nfs_umount23(spec, "tcp,v3"); } else ret = del_mtab(NULL, spec); return ret; Removing the first "!lazy &&" resolved my immediate problem. What I don't understand is why it, and the latter "!lazy", were there in the first place. The do_nfs_umount23() routine seems to be relatively harmless, it either sends the message or it doesn't, but either way it doesn't seem to do anything to the mount information on the local node. So why is it not run if "-l" (lazy) is set? Thanks, David Mathog mathog-7GExONQZ6ZKVc3sceRu5cw< at >public.gmane.org Manager, Sequence Analysis Facility, Biology Division, Caltech -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html