gmane.editors.lyx.devel

master (trunk?) not compilable

Kornel Benko — 2012-05-26T08:22:58

This is on ubuntu 12.04

...
cd /usr/BUILD/BuildLyxGit/src/frontends/qt4 && /usr/bin/c++   -DUSE_ENCHANT=1 -DQT_GENUINE_STR -DLYX_BUILD_QT4_FRONTEND -Wall -Wunused-parameter -fno-strict-aliasing  -Wall -Wunused-parameter -O3 -DNDEBUG -I/usr/BUILD/BuildLyxGit -I/usr/src/lyx/lyx-git/src -I/usr/include/enchant -I/usr/src/lyx/lyx-git/po -I/usr/src/lyx/lyx-git/boost -I/usr/src/lyx/lyx-git/src/frontends -I/usr/src/lyx/lyx-git/src/frontends/qt4 -I/usr/include/qt4 -I/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtTest -I/usr/BUILD/BuildLyxGit/src/frontends/qt4    -DBOOST_USER_CONFIG="<config.h>" -o CMakeFiles/frontend_qt4.dir/GuiWorkArea.cpp.o -c /usr/src/lyx/lyx-git/src/frontends/qt4/GuiWorkArea.cpp
/usr/src/lyx/lyx-git/src/frontends/qt4/GuiWorkArea.cpp: In member function ‘virtual void lyx::frontend::TabWorkArea::paintEvent(QPaintEvent*)’:
/usr/src/lyx/lyx-git/src/frontends/qt4/GuiWorkArea.cpp:1566:3: error: ‘QStylePainter’ was not declared in this scope
/usr/src/lyx/lyx-git/src/frontends/qt4/GuiWorkArea.cpp:1566:17: error: expected ‘;’ before ‘p’
/usr/src/lyx/lyx-git/src/frontends/qt4/GuiWorkArea.cpp:1572:3: error: ‘p’ was not declared in this scope
make[2]: *** [src/frontends/qt4/CMakeFiles/frontend_qt4.dir/GuiWorkArea.cpp.o] Error 1
make[2]: Leaving directory `/usr/BUILD/BuildLyxGit'
make[1]: *** [src/frontends/qt4/CMakeFiles/frontend_qt4.dir/all] Error 2
make[1]: Leaving directory `/usr/BUILD/BuildLyxGit'
make: *** [all] Error 2
...
class QStylePainter defined in "/usr/include/qt4/Qt/qstylepainter.h", which is included by "/usr/include/qt4/Qt/QtGui"

Kornel

Feature request: native lyx format in View Source window

Andrew Parsloe — 2012-05-25T23:41:41

Among the formats listed in the drop-down box of the View Source window 
(although only Default and LyXHTML work), LyX itself is missing i.e. LyX 
in the form of

\begin_layout Standard
...
\end_layout

etc.

At present I can look at a LyX file in a text editor to examine the 
format, but surely the natural place is the View Source window? For 
someone writing a converter to or from LyX format, this would be of 
great assistance.

(I'm aware the drop-down box is labelled "Output format:" but given that 
only two of the formats have any effect, that seems a misnomer. In fact 
I would expect Default to be LyX's native format, instead of LaTeX as at 
present, and LaTeX to be explicitly mentioned in the list.)

Andrew

LyX 2.0.4

Richard Heck — 2012-05-25T14:22:11

We've accumulated a good number of bug fixes for 2.0.4, and it's been 
almost three months since the last release, so it's time to start 
thinking about another one. I'll remerge strings and inform the 
translators shortly. Before I do that, please have a look at our list of 
bugs for 2.0.4
     
http://www.lyx.org/trac/wiki/BugTrackerHome#Unresolvedbugstargetedtonextmaintenancerelease2.0.4
and let me know if there are any we really need to fix before strings 
are frozen. Also, let me know which of these bugs you think we need to 
fix for the release, and let's mark them high priority.

Richard

Upgrade Qt to 4.8?

Jerry — 2012-05-25T03:26:26

What would be the effects if any on LyX by upgrading my Qt installation from 4.7 to 4.8?

Jerry

Branch 2.0.x-candidate

Vincent van Ravesteijn — 2012-05-24T12:43:03

Hi all,

Is it a good idea to create a branch "2.0.x-candidate" to where we can 
backport the fixes without asking for permission. If Richard likes all 
candidates, he just needs to fast-forward the 2.0.x branch to 
2.0.x-candidate. If not all candidates can be accepted, Richard can 
cherry-pick the commits he likes, or interactively rebase the branch 
"2.0.x-candidate" on top of 2.0.x after indicating which commits to use 
and which not.

This allows to commit to trunk and branch in one go and saves the 
questioning, waiting and answering of backport requests.

Such a branch would be a temporary one and can be rewound by Richard 
after he acknowledged all fixes.

Vincent

Trac improvements

Vincent van Ravesteijn — 2012-05-24T12:25:58

Hi all,

Some ideas to improve the trac experience:

a) It is possible to automatically update a bug report when a commit has 
been made that references a bug.

This can be done with the trac plugin:
- 
http://trac.edgewall.org/wiki/TracFaq#can-trac-automatically-update-a-ticket-when-i-commit-a-changeset

or by installing something like this as a git hook:
- 
http://trac.edgewall.org/browser/branches/0.11-stable/contrib/trac-post-commit-hook

b) if someone can change in trac.ini the option git.shortrev_len to 8, 
we can more easily copy-paste the abbreviation to use in the bug 
reports/comments (this requires an abbreviation of 8 characters).

c) is it possible to have lyxgit the default for linking to revisions ?
- 1) rename all links in all bugreports from e.g, r20030  to 
[r20030/lyxsvn] (or something like that).
- 2) update trac.ini such that the default repository is an alias of lyxgit.

Vincent

[patch] autogen.sh better exit message

Scott Kostyshak — 2012-05-23T07:57:40

If autogen.sh completes successfully, it outputs "run ./configure ; make". I do not think this is good advice because what if configure has an error? The "make" command will still run.

I suggest:
<<You can now run "./configure">> [autogen.patch]
because upon successful exit, configure tells you to run make and make install.

An alternative that suggests both ./configure and make but does not run make on a failed configure is:
<<run "./configure && make">> [autogen_alt.patch]

Scott

trunk regression

Scott Kostyshak — 2012-05-23T07:21:04

LyX hangs if a converter fails. I can reproduce this in current trunk by opening a new document and putting \foo in an ERT box and trying to view or export to pdflatex.

git bisect led me here:
288c1e0faad85d4b0f17e366cb5c44473a133957

Scott

plan for the next LyX developer meeting

Uwe Stöhr — 2012-05-22T23:06:55

Dear colleagues,

it has been several years now without a developer meeting and I think we should meet again. It is in 
my opinion time to plan what to do in future, to drink some beers together, discuss the things that 
usually end up in a flamewar when only discussed on the list and of course to enjoy a nice weekend 
in a nice town.

The last time we met in Berlin and I found the location nice as most of us live in Europe, Berlin is 
central, there are a lot of cheap flights to Berlin and there are night trains too.
I asked André if we could again stay at Nokia but that doesn't seem to be possible. However, there 
is a possibility to get a room with Internet access at one of Berlin's Universities. The problem 
will be the accommodation but Berlin should be big enough to find something suitable.

But before I go on to organize a room I would like to hear your opinions. Who will come, when do you 
prefer to meet, is Berlin OK or are there other places you propose?

I'm curious about your input.

best regards
Uwe

[PATCH] Deal With Memory Issue

Richard Heck — 2012-05-22T22:07:58

The attached patch deals with the memory leak (not quite) reported a 
while ago, connected with the creation and non-destruction of 
DocumentClass objects. It uses a shared_ptr instead of a storehouse. 
Comments? I wouldn't think this was for 2.0.4....

Richard

Shared Pointers

Richard Heck — 2012-05-22T21:37:43

Suppose I have a shared_ptr<DocumentClass const> and I need a 
shared_ptr<DocumentClass>. You can't copy the pointer and make a new 
shared_ptr, because then we have two shared_ptr's that think they own 
the same object. I can copy the DocumentClass object and make a new 
shared_ptr, but that seems wasteful. Any other options?

Richard

[HELP] Canceling Background Export, Again

Richard Heck — 2012-05-22T19:30:27

Hi, all,

Back to trying to get some way of canceling background export reliably. 
I'm playing with patches Peter attached earlier, but am also working on 
a different sort of solution. The attached is some playing, but it won't 
compile. I keep getting an "undeclared reference to vtable" error. Any help?

Richard

why does import save?

Scott Kostyshak — 2012-05-22T06:45:09

I've only tried this for importing .tex and .csv files but whenever I import them LyX automatically saves the resulting lyx file. In some cases, this is exactly what I want to do but I was surprised because in my experience usually an import function just imports and does not automatically save. I searched but could not find any previous discussion on this.

Instead of "import" I would describe this as "convert the file (assuming an output file name) and open" although "import" does sound nicer.

In any case, I could see this behavior causing problems. A few examples:
1. If a user tries to import a .tex file from a read-only directory (which seems legitimate to me) they get an (uninformative) error.
2. If they have an existing .lyx file with the same name, they will be asked if they want to overwrite that file. I think this message would confuse users that thought they were just importing a .tex file.
3. Often I want to import a .tex file from one folder and save it to a different folder. It's not much of a pain to save-as it and then delete the other one. But until now I didn't realize that I needed to delete the other one.
4. Similar to (3) I often want to import a few .tex files (usually tables) and merge them into one .lyx file.

The current behavior does have some advantages. I think in most cases the user is planning on saving the .tex file with the same name. Also, it's nice if you want to convert a lot of .tex files at once and you aren't comfortable with the command line. You can just drag them on top of LyX and you're done.

I could get used to this "convert and open" behavior now that I expect it, but I just wanted to mention my surprise. What I expected to happen was what happens when you create a new document. I expected to have an unsaved newfile1.lyx.

Any thoughts?

Thanks,

Scott

buffer-reload when using LyX as a viewer

Andrew Parsloe — 2012-05-22T05:25:07

Working on editing bibliographies in LyX, I've arrived at this 
situation: it's convenient to attach to each bibliographic record a 
yellow note containing a (cross-reference) label e.g. a bib record 
beginning (say) < at >book{knuth, would have a yellow note containing the 
label book-knuth. For a large already existing bibliography, it's a 
substantial labour attaching such notes and labels to each entry and 
I've created a Python converter that does the job: it exports the LyX 
file containing the original bibliography to another LyX file, but this 
time with yellow notes containing labels. It means defining another LyX 
file format which I've called LyX (bib yl). Obviously LyX is the natural 
viewer for this file format. Now when I click on the View Other Formats 
button and select LyX (bib yl), in due course a second instance of LyX 
appears displaying the bibliography but this time with yellow notes and 
labels attached to the records. (The sorted labels provide a way of 
searching for duplicate records.)

But if I edit and change the original bibliography and click on the 
Update Other Formats button and select LyX (bib yl), although the status 
line tells me that a successful export has been made, the second LyX 
instance doesn't update. It's not a significant problem because I've 
assigned the L-FUN buffer-reload to a shortcut key combination, and 
simply pressing that key combination in the viewer-LyX updates the 
display, but it would be nice if, when LyX is used as a *viewer*, 
buffer-reload were automatically invoked. Overwriting the existing file 
displayed is not a concern in this case -- in fact it's exactly what one 
wants.

Andrew

[patch] ampersand + shortcut leaves an underscore in menu

Scott Kostyshak — 2012-05-20T10:50:57

In the menu when there is an entry that has an ampersand and it has a shortcut,
an unnecessary underscore is displayed. For example, instead of "Find & Replace (Quick)..." I see "_Find & Replace (Quick)...". I see this behavior on Ubuntu 12.04 with Qt 4.8.1.

The attached patch fixes this.

Note that I also changed the ampersand in "Find & Replace (Advanced)..." even though no shortcut is associated with it (so there is no problem currently).

Do others also observe this behavior?

Thanks,

Scott

no GUI error when configure fails on first configure

Scott Kostyshak — 2012-05-20T02:54:25

When you reconfigure by going to Tools > Reconfigure, if the python script returns a non-zero exit status, a useful GUI error is displayed. However, when configure is run from LyX.cpp on the first run, you can only see if there is an error in the terminal and this will pass unnoticed by most. To test this case, in configure.py put a system.exit(1) just before sys.exit(ret is not None) at the end and force a startup configure (for example by renaming your .lyx folder).

Is this a problem that should be fixed?

If so, what is the best design? Should a bool be passed to the Application constructor?

Thanks, Scott

[PATCH] comment out function to get rid of a compiler warning

Lars Gullik Bjønnes — 2012-05-18T09:57:07

[PATCH 0/2] Use system's theme icons

Vincent van Ravesteijn — 2012-05-15T14:28:23

The following two patches add support for using the system's theme icons. 

To this end, the commands have to be translated into standardized commands.

Objections or comments ?

Vincent van Ravesteijn (2):
  Use system's theme icons
  Make the use of system's theme icons configurable

 lib/scripts/prefs2prefs_prefs.py     |    4 ++
 src/LyXRC.cpp                        |   19 ++++++++++-
 src/LyXRC.h                          |    3 ++
 src/frontends/qt4/GuiApplication.cpp |   61 ++++++++++++++++++++++++++++++++++
 src/frontends/qt4/GuiPrefs.cpp       |    8 ++++
 src/frontends/qt4/ui/PrefUi.ui       |   20 +++++++++--
 6 files changed, 111 insertions(+), 4 deletions(-)

[PATCH] Fix bug #6389: Make columns RTL in RTL document

Vincent van Ravesteijn — 2012-05-15T14:12:28

This patch adds LaTeX code to make sure that the columns in an RTL document are also ordered RTL.

Objections or comments ? 

---
 src/BufferParams.cpp  |    3 +++
 src/LaTeXFeatures.cpp |   39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 0 deletions(-)

diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp
index 0a7e594..64aab6e 100644
--- a/src/BufferParams.cpp
+++ b/src/BufferParams.cpp
< at >< at > -1157,6 +1157,9 < at >< at > void BufferParams::validate(LaTeXFeatures & features) const
 {
 features.require(documentClass().requires());
 
+if (columns > 1 && language->rightToLeft())
+features.require("rtloutputdblcol");
+
 if (outputChanges) {
 bool dvipost    = LaTeXFeatures::isAvailable("dvipost");
 bool xcolorulem = LaTeXFeatures::isAvailable("ulem") &&
diff --git a/src/LaTeXFeatures.cpp b/src/LaTeXFeatures.cpp
index 2a3d099..550ab29 100644
--- a/src/LaTeXFeatures.cpp
+++ b/src/LaTeXFeatures.cpp
< at >< at > -276,6 +276,42 < at >< at > static docstring const lyxref_def = from_ascii(
 "  {\\def\\RSlemtxt{lemma~}\\newref{lem}{name = \\RSlemtxt}}\n" 
 "  {}\n");
 
+// Make sure the columns are also outputed as rtl
+static docstring const rtloutputdblcol_def = from_ascii(
+"\\def\\< at >outputdblcol{%\n"
+"  \\if< at >firstcolumn\n"
+"    \\global \\< at >firstcolumnfalse\n"
+"    \\global \\setbox\\< at >leftcolumn \\box\\< at >outputbox\n"
+"  \\else\n"
+"    \\global \\< at >firstcolumntrue\n"
+"    \\setbox\\< at >outputbox \\vbox {%\n"
+"      \\hb< at >xt< at >\\textwidth {%\n"
+"      \\kern\\textwidth \\kern-\\columnwidth %**\n"
+"      \\hb< at >xt< at >\\columnwidth {%\n"
+"         \\box\\< at >leftcolumn \\hss}%\n"
+"      \\kern-\\textwidth %**\n"
+"      \\hfil\n"
+"      {\\normalcolor\\vrule \\< at >width\\columnseprule}%\n"
+"      \\hfil\n"
+"      \\kern-\\textwidth  %**\n"
+"      \\hb< at >xt< at >\\columnwidth {%\n"
+"         \\box\\< at >outputbox \\hss}%\n"
+"      \\kern-\\columnwidth \\kern\\textwidth %**\n"
+"    }%\n"
+"  }%\n"
+"  \\< at >combinedblfloats\n"
+"  \\< at >outputpage\n"
+"  \\begingroup\n"
+"  \\< at >dblfloatplacement\n"
+"  \\< at >startdblcolumn\n"
+"  \\< at >whilesw\\if< at >fcolmade \\fi\n"
+"  {\\< at >outputpage\n"
+"    \\< at >startdblcolumn}%\n"
+"  \\endgroup\n"
+"  \\fi\n"
+"}\n"
+"\\< at >mparswitchtrue\n");
+
 
 /////////////////////////////////////////////////////////////////////
 //
< at >< at > -997,6 +1033,9 < at >< at > docstring const LaTeXFeatures::getMacros() const
 if (mustProvide("ct-none"))
 macros << changetracking_none_def;
 
+if (mustProvide("rtloutputdblcol"))
+macros << rtloutputdblcol_def;
+
 return macros.str();
 }

[patch] Load footmisc.sty instead of using copied code from obsolete stblftnt.sty

Georg Baum — 2012-05-13T17:23:21

While investigating bug 8116 I saw that LyX ships a code fragment of 
stblfnt.sty instead of loading the successor package footmisc.sty (with the 
'stable' option, see 
http://comments.gmane.org/gmane.comp.tex.ctan.announce/4290). Why is that 
the case? If nobody objects I will submit the attached patch.


Georg

temporary files listed in View > Hidden

Scott Kostyshak — 2012-05-12T01:23:46

In trunk when I open LyX with no documents there are two documents listed under View > Hidden, for example embedded.internal.n12357 and embedded.internal.W12357

This appears to occur because of
http://www.lyx.org/trac/changeset/5e4e4b674c00bc546213d42258f19e13a2b28bc3/lyxgit

I'm on Ubuntu 12.04.

Scott