http://blog.gmane.org/gmane.comp.web.curl.curlpp.general hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/329 _______________________________________________ cURLpp mailing list cURLpp-V5R0HI2H36zQT0dZR+AlfA< at >public.gmane.org http://www.rrette.com/mailman/listinfo/curlpp Josh Dye 2008-11-26T04:13:58 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/306 I just pushed the fixes to support building curlpp as a dynamic library on MSVC. The corrections mostly concern the proper usage of CURLPPAPI macro. I also defined BUILDING_CURLPP in curlpp project. I did tested the stuff (= built curlpp for all targets, built all tests, checked example01 works ok) on MSVC8 only. Could somebody (Piotr? ;)) please check the stuff works on VC9 as well? Thanks, Andrei Andrei 2008-11-22T20:01:42 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/303 Hallo Jean and other curlpp contributors, I see the life around curlpp got more active the latest months. As a result there are a number of issue requests around in the maillist. IMHO there is a time to have an issue tracker for the project. Personally I am ready to contribute the project from time to time, but so far I'm entitled to read the entire maillist since my last visit just in order to answer one question 'what useful can I do for curlpp in my 4 spare hours this weekend?'. With the issue tracker I would decide instantly based on the issue severity, category and description linked to the relevant maillist discussion. And I believe this is true for other contributors. I do not see it is much work (for Jean?) to make formal issues out of relevant discussions, however the whole project will significantly benefit from this. What do you think? Andrei Andrei 2008-11-22T17:06:12 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/302 Jean The reason curlpp might work now as a library is because it doesn't use templates with user defined types at all. And even in case of setOpt all arguments are either of type OptionBase or OptionBase or OptionList. Below are 3 exports from curlpp dll lib which are responsible for this void cURLpp::Easy::setOpt(class cURLpp::OptionBase const &) void cURLpp::Easy::setOpt(class cURLpp::OptionList const &) void cURLpp::Easy::setOpt(class cURLpp::OptionBase *) If we are going to add the new setOpt() and set() functions taking as an argument the real type of option's type then we'll have to explicit instantiate both of these functions with all possible options' types. template CURLAPI set<Options::Url>(std::string const & value); template CURLAPI set<Options::SslVerifyHost>(long const & value); template CURLAPI set<Options::SslVerifyPeer>(bool const & value); etc. I'm not sure if even in the current source there aren't places where we should have made explicit instantiations that would generate all needed by users code in the library object file instead of generating it in user's application object file. Regards Piotr Piotr Dobrogost 2008-11-22T11:46:05 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/301 _______________________________________________ cURLpp mailing list cURLpp-V5R0HI2H36zQT0dZR+AlfA< at >public.gmane.org http://www.rrette.com/mailman/listinfo/curlpp rajashri bhor 2008-11-21T06:35:24 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/297 Jean I noticed there are two different namespaces cURLpp and curlpp which differ only in capitalization. The same is with Utilspp and utilspp. Is it by any purpose? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-19T23:18:12 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/295 Jean I managed to compile curlpp and all examples some time ago. Right now I added the second project to VC9 solution for building all examples. But with each example I get the following error: 'void cURLpp::Easy::setOpt(const cURLpp::OptionBase &)' : member function templates cannot be virtuald:\projects\curlpp\include\curlpp\easy.hpp (line 82) That's very interesting. Member function templates REALLY cannot be virtual. Could you tell me what's going on? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-19T22:06:51 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/293 Jean I was too quick. Afer refreshing my memory a little bit I'd like to state what follows. Actually <string.h> in C++ is a C header and totally different from <string>. I guess some buggy compilers treat <string.h> like <string> but that's nonconforming. I propose to remove all <xxx.h> headers from sources (I'm withdrawing my earlier proposition to change <xxx.h> to <cxxx>). We could introduce macro INCLUDE(X) and define it eihter to include <xxx> style headers or <xxx.h> style headers for buggy compilers but I wouldn't do that. Every macro takes 5% of users away :) Regards Piotr Dobrogost -------- Original Message -------- Subject: [cURLpp] Compilation fixes from Bob Ham <rah-zfCUeDfr9BM< at >public.gmane.org> - it shouldn't be like this :) Date: Tue, 18 Nov 2008 22:23:08 +0100 From: Piotr Dobrogost <curlpp-wFPGMCNilwaSM/JszlHmzA< at >public.gmane.org> Reply-To: cURLpp's mailing-list <curlpp-V5R0HI2H36zQT0dZR+AlfA< at >public.gmane.org> To: cURLpp's mailing-list <curlpp-V5R0HI2H36zQT0dZR+AlfA< at >public.gmane.org> Jean Some of Bob's changes resulted in string header included twice; curlpp/CurlHandle.cpp: #include <string> #include <iostream> #include <string.h> We should introduce MACRO informing weather std string (<string>) is present or not and include either <string> or <string.h> Shall I make changes? Regards Piotr Dobrogost _______________________________________________ cURLpp mailing list cURLpp-V5R0HI2H36zQT0dZR+AlfA< at >public.gmane.org http://www.rrette.com/mailman/listinfo/curlpp Piotr Dobrogost 2008-11-18T22:49:24 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/292 Jean Since all <xxx.h> headers are depreciated in C++ since 1998 I propose to change them to more modern <cxxx> ones. Regards Piotr Dobrogost Piotr Dobrogost 2008-11-18T22:30:45 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/291 Jean Some of Bob's changes resulted in string header included twice; curlpp/CurlHandle.cpp: #include <string> #include <iostream> #include <string.h> We should introduce MACRO informing weather std string (<string>) is present or not and include either <string> or <string.h> Shall I make changes? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-18T21:23:08 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/286 Jean In example 12 you have this request.setOpt(new cURLpp::Options::PostFields("abcd")); request.setOpt(new cURLpp::Options::PostFieldSize(5)); Why is PostFieldSize set to 5? Do you have to take into account null terminated string used by libcurl? And do you know why in libcurl's tutorial (http://curl.haxx.se/libcurl/c/libcurl-tutorial.html) in this example struct curl_slist *headers=NULL; headers = curl_slist_append(headers, "Content-Type: text/xml"); /* post binary data */ curl_easy_setopt(easyhandle, CURLOPT_POSTFIELDS, binaryptr); /* set the size of the postfields data */ curl_easy_setopt(easyhandle, CURLOPT_POSTFIELDSIZE, 23L); /* pass our list of custom made headers */ curl_easy_setopt(easyhandle, CURLOPT_HTTPHEADER, headers); curl_easy_perform(easyhandle); /* post away! */ curl_slist_free_all(headers); /* free the header list */ they set CURLOPT_POSTFIELDSIZE to 23? They don't show in this example the data pointed to by binaryptr. Strange enough the length of Content-Type header is exactly 23 but this is only a coincidence, isn't it? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-17T19:23:51 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/284 Jean In example 12 you have this request.setOpt(new cURLpp::Options::PostFields("abcd")); request.setOpt(new cURLpp::Options::PostFieldSize(5)); Why is PostFieldSize set to 5? Do you have to take into account null terminated string used by libcurl? And do you know why in libcurl's tutorial (http://curl.haxx.se/libcurl/c/libcurl-tutorial.html) in this example struct curl_slist *headers=NULL; headers = curl_slist_append(headers, "Content-Type: text/xml"); /* post binary data */ curl_easy_setopt(easyhandle, CURLOPT_POSTFIELDS, binaryptr); /* set the size of the postfields data */ curl_easy_setopt(easyhandle, CURLOPT_POSTFIELDSIZE, 23L); /* pass our list of custom made headers */ curl_easy_setopt(easyhandle, CURLOPT_HTTPHEADER, headers); curl_easy_perform(easyhandle); /* post away! */ curl_slist_free_all(headers); /* free the header list */ they set CURLOPT_POSTFIELDSIZE to 23? They don't show in this example the data pointed to by binaryptr. Strange enough the length of Content-Type header is exactly 23 but this is only a coincidence, isn't it? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-17T18:49:58 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/280 Jean I get error C2988: unrecognizable template declaration/definition in line 35 of d:\projects\curlpp\include\utilspp\ThreadingSingle.inl template< typename T > inline utilspp::ThreadingSingle< T >::lock::lock( utilspp::ThreadingSingle< T >::mutex & ) < this is line 35 {} I don't know why as this file and ThreadingSingle.hpp haven't changed. Regards Piotr Dobrogost -------- Original Message -------- Subject: Re: [cURLpp] cURLpp folder structure Date: Sun, 16 Nov 2008 19:05:29 +0100 From: Piotr Dobrogost <curlpp-wFPGMCNilwaSM/JszlHmzA< at >public.gmane.org> To: cURLpp's mailing-list <curlpp-V5R0HI2H36zQT0dZR+AlfA< at >public.gmane.org> References: <49183C57.6050309-wFPGMCNilwaSM/JszlHmzA< at >public.gmane.org><4e3cf5960811100611s283c12cfy67e1329c566adf6d-JsoAwUIsXosN+BqQ9rBEUg< at >public.gmane.org><491981BB.60207-wFPGMCNilwaSM/JszlHmzA< at >public.gmane.org><4e3cf5960811110518k7958c5ffw956db97294b6f82c-JsoAwUIsXosN+BqQ9rBEUg< at >public.gmane.org><4e3cf5960811121020l4591780fiec75150659140840-JsoAwUIsXosN+BqQ9rBEUg< at >public.gmane.org> <4e3cf5960811121834n9b92d75u9fc6604bd0cfce4f-JsoAwUIsXosN+BqQ9rBEUg< at >public.gmane.org> Jean-Philippe Barette-LaPierre wrote: Jean Thanks a lot for this work. Below there are some comments from me. 0. curlpp .cpp files are missing (CurlHandle.cpp, Easy.cpp etc.) 1. Copyright notice is not updated to current year. 2. Some headers have include guard beginning with CURLPP and some don't have this prefix. I think all should have. 3. Some headers don't have include guard. 4. Some .inl files don't have include guard. 5. NonCopyable is in both curlpp and utilspp. Shouldn't we have only one in utilspp? If you agree with above I could make these changes. Regards Piotr Dobrogost Piotr Dobrogost 2008-11-16T19:28:36 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/267 Jean .inl files are included in headers but sematically they are more source then header files. I'm writing this because with the previous folder structure I put all .inl files in the header section of VC project but now I think they would rather be put in the source section of the project. This doesn't make any difference in build since there is no build rule for them. It's kind of philosophic problem :) Regards Piotr Dobrogost Piotr Dobrogost 2008-11-16T16:49:45 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/265 Hi I'm sure I saw somewhere in libcurl docs how to set libcurl to follow url in CONTENT element of the HEAD tag but I can't find it anymore. Anyone? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-16T12:01:22 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/263 Jean In CurlHandle.inl we have this template< typename OptionType > void cURLpp::CurlHandle::option(CURLoption optionType, OptionType value) { CURLcode code; code = curl_easy_setopt(mCurl, optionType, value); libcurlRuntimeAssert(mErrorBuffer, code); } template< typename OptionType, CURLoption optionType > void cURLpp::CurlHandle::option(OptionType value) { option(optionType, value); } So there are as many option functions as there are many OptionType types. Do we really need this? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-15T19:01:20 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/261 Jean Using Easy::setOpt is not as convenient as it should be. Now we have std::string address = "http://example.com" // Setting the URL to retrive. request.setOpt(new cURLpp::Options::Url(address)); Could we do better? std::string url = "http://example.com" // Setting the URL to retrive. request.set<url>(address); Regards Piotr Dobrogost Piotr Dobrogost 2008-11-14T21:12:29 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/259 Jean What is the reason for allowing to set an option using a pointer? I think that having a version with reference is enough. The version with pointer is not needed and brings problems with memory management into the library. Regards Piotr Dobrogost Piotr Dobrogost 2008-11-14T18:09:00 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/255 Hi Has anyone tried to build cURLpp as dynamic library? How did you solve the problem of templates in this case? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-12T11:30:17 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/253 Hi There is a problem with FormPart base class. It's polymorphic and we can make copies of objects of type FormPart* or FormPart& using the virtual clone() method but there is neither Copy Constructor nor Assignment Operator defined. It looks line we need to implement solution described in item 33 from "More Effecive C++" by Scott Meyers. What do you think? Regards Piotr Dobrogost Piotr Dobrogost 2008-11-11T16:24:19 http://comments.gmane.org/gmane.comp.web.curl.curlpp.general/248 Jean On the cURLpp's mailing-list archives there are no posts newer then from March 2008. I think something is wrong with it. Regards Piotr Dobrogost Piotr Dobrogost 2008-11-11T13:21:39 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.web.curl.curlpp.general