gmane.comp.php.phplist.devel

Prefixed from in send page - How to implement?

adrian15 — 2010-01-21T10:46:57

One of my customers has asked me so that his email (the one associated 
with its normal admin account) does not appear in the From field when 
sending an email (send page).

He wants something else to appear like noreply< at >hisdomain.com.

So... the question is how should I implement this?

Maybe a field associated to the list? So that you when create or edit a 
list you can also fill this field?

This will imply modifying the database and thus changing the database 
version as I did with my admin ownership patch.

And should there be a config option to enable or disable this feature?
In the same list new/edit page? Maybe in config.php (or its successor, I 
just cannot remember the name right now).

Maybe this field should be more useful if it can be used in all the 
lists (config table on database)? (I personally do no think so.)

What are your thoughts as a phplist developer or advanced user?

Thank you very much for your advice.

adrian15

Average time for patch acception in svn

adrian15 — 2010-01-18T16:05:14

What's the average time so that a patch reported in mantis is accepted 
in the svn?

I have some several patches that I would like to see in the svn (or at 
least in mantis being reported as fixed) and it seems too long for me. 
(More than one month and a half).

But maybe I am wrong and phplist has some timings that I am unaware of?

Thank you.

adrian15

Autophlist (Automatic PhpList Installer)

adrian15 — 2010-01-09T19:12:05

Hi,

I have developed kind of an automatic phplist installer which I call: 
Autophplist.

You can find it here:

http://adrian15.raulete.net/ficheros/phplist/autophplist/

It might not work on your setup so you might need to tweak some sql 
files to your own needs. It is based on a fork of phplist dev version 
(An hipothetic 2.11.5 version).

You can download the fork source code here:

http://adrian15.raulete.net/ficheros/phplist/cumulus_fork/

Any comments, requests, new features, ideas, are welcome.

adrian15

oracle and adodb status report

Tim Holliefield — 2009-12-23T16:26:35

I would like to update the list on my efforts to use phpList with adodb 
and Oracle. I don't have a complete migration to adodb but would like to 
share what I have learned.

There is a lot of mysql-specific syntax in the code. One way for phpList 
to use different database backends via adodb is to make the sql more 
generic. Generic date data is an issue. Adodb provides some support for 
handling dates but in some cases the only way I could see to keep the 
code generalized was to do the date arithmetic in the code.

The file structure.php is almost entirely mysql "create table" 
statements. I rewrote it into a version more usable with the adodb table 
creation facility, which also slightly simplified other parts of the 
code that referenced the database structure.

Adodb provides a Replace() function call similar to the mysql "replace 
into". I was able to change almost all remaining instances of "replace 
into" with calls to Sql_Replace() in adodb.inc.

If you are targeting Oracle use the adodb driver oci8po, not oci8.

My current set of changes will create a database structure and 
initialise the tables using Oracle as the backend. I can see the setup 
page but have not gotten very far past that due to date handling issues. 
I've also run out of time - these changes were made during work hours 
and I need to move on to other tasks. I will probably try to get a 
stealth mysql database running because phpList has needed functionality.

If anyone would like a copy of the changed code please let me know.

ver. 2.10.10 - error handling in processqueue.php

Alberto Granzotto — 2009-12-09T15:26:42

PHPList version: 2.10.10
PHP version: 5
Hosting: tophost.it

I had a problem sending a message, after pressing "Process Queue" I had
a lot of "MySQL server has gone away" errors.
  I have took a look to [b]processqueue.php[/b], the common pattern in
errors handling is:
  $userids = Sql_query($query);
  if (Sql_Has_Error($database_connection)) {
ProcessError(Sql_Error($database_connection)); }

  More or less:
 * do the query;
 * if some error happens, do ProcessError (which [b]exits[/b] from the
script).

  Sql_Has_Error w/ ProcessError are not used -- as far as I can see, and
only in the "sending loop" -- in those lines:

528: $userids = Sql_Query(sprintf('select * from %s where id =
0',$tables["user"]));

559: $um = Sql_query("select entered from {$tables['usermessage']} where
userid = $userdata[0] and messageid = $messageid");

564: $users = Sql_query("select
id,email,uniqid,htmlemail,rssfrequency,confirmed,blacklisted from
{$tables['user']} where id = $userid");

654: $um = Sql_query("replace into {$tables['usermessage']}
(entered,userid,messageid,status)
values(now(),$userid,$messageid,\"sent\")");

657: $status = Sql_query("update {$tables['rssitem']} set processed =
processed +1 where id = $rssitemid");

658: $um = Sql_query("replace into {$tables['rssitem_user']}
(userid,itemid) values($userid,$rssitemid)");

660: Sql_Query("replace into {$tables["user_rss"]} (userid,last)
values($userid,date_sub(now(),interval 15 minute))");

673: Sql_Query(sprintf('update %s set confirmed = 0 where email = "%s"',
$GLOBALS['tables']['user'],$useremail));

715: $um = Sql_query("replace into {$tables['usermessage']}
(entered,userid,messageid,status) values(now(),$userid,$messageid,\"not
sent\")");

737: $um = Sql_query("replace into {$tables['usermessage']}
(entered,userid,messageid,status)
values(now(),$userid,$messageid,\"unconfirmed user\")");

745: $um = Sql_query("replace into {$tables['usermessage']}
(entered,userid,messageid,status)
values(now(),$userid,$messageid,\"invalid email\")");

760: $status = Sql_query("update {$tables['message']} set processed =
processed +1 where id = $messageid");

792: Sql_Query(sprintf('insert ignore into %s (name,id,data)
values("end_notified",%d,now())',
$GLOBALS['tables']['messagedata'],$messageid));

795: $timetaken = Sql_Fetch_Row_query("select sent,sendstart from
{$tables['message']} where id = \"$messageid\"");

  So, afaik, if a connection problem occurs during the main loop,
nothing calls ProcessError and so the script goes on printing ADO errors
using the function Sql_Error. I don't think this is the right behaviour,
I think the script must exits with an error code.

thank you,
vrde

P.S.: sometimes the function Sql_affected_rows() is used, other times
Sql_Affected_Rows() (with different "case"), why?

phplist rewrite started?

Tim Holliefield — 2009-12-02T13:58:54

Hi list,

While looking over the list archives I saw a thread from August 2009 
discussing a rewrite of phplist. Did anything actually happen as a 
result of that thread? There have been no further messages on the topic 
on this list and what seems to be a low level of activity in svn. Am I 
not looking in the correct location, or has there really been no further 
work done on a rewrite?

List page: Added Edit column

adrian15 — 2009-11-29T15:28:11

When evaluating svn_r1703 it seems that list page does not have an 
explicit edit column.
I have made a patch so that there is an explicit edit column.

Are you interested in this patch?
Should I open a mantis issue for this?

Thank you for your time.

adrian15

List page: Id links to editlist page

adrian15 — 2009-11-29T15:14:37

When evaluating svn_r1703 I have seen that id (the number) links to 
editlist (even if there is no permissions from the owner to editlist page).

However I do not like this behaviour so I just rewrite the code so that 
the id is seen as a plain number.

You might be interested in this patch or maybe not.

I have made a patch so that the delete links come back.

As always I will open a mantis issue whenever I have time.

adrian15

List page: Delete link was not there patch

adrian15 — 2009-11-29T14:48:05

When evaluating svn_r1703 it seems that list page no longer has the 
delete column with links to delete the different lists.

I have made a patch so that the delete links come back.

As always I will open a mantis issue whenever I have time.

adrian15

List: Admin can see list title even if editlistaccesslevel is none

adrian15 — 2009-11-29T13:12:56

If an admin that had list page enabled wanted to see its lists and at 
the same time editlist acceslevel was set to none:

He saw listing but with the title of each mailing list empty.

This is because the title was set to be an editlist link with the 
PageLink2 function.

This patch fixes this issue.

As always I will open a mantis issue for this problem whenever I have time.

adrian15

admin can delete other admins lists patch

adrian15 — 2009-11-29T12:02:32

If one admin have access to list page he can write an url like this:
http://domain.com/lists/admin/?page=list&delete=4

Even if list with id=4 is not a property of the admin it gets deleted!

Attached you will find a patch to solve this issue.

As always whenever I have time I will open a mantis issue for this problem.

adrian15

minimal bug at editlist.php: accesslist reads listpage permissions

adrian15 — 2009-11-29T10:38:36

Here there is a patch for forcing that editlist.php reads accesslist 
values from editlist not from list.

This patch seems to generate another bug in list.php when the admin who 
has been set its editlist permissions to none does not see the title of 
its own lists.

I will investigate and come back with more findings.

As always, whenever I have more time I will open a mantis issue for this.

Thank you very much for your patience (me sending some many emails).

adrian15

second subscribe appear when re subscribing patchdoubt

adrian15 — 2009-11-28T18:34:23

Attached is the patch for the "second subscribe appear when re 
subscribing" issue which it is the 10th of my 15 initial patches for 
v2.10.10.

This patch should apply to svn revision 1703 with no problem at all.

The patch basically removes the following lines from 
admin/subscribelib2.php file.


   $blacklisted = isBlackListed($email);
   if ($blacklisted) {
     $thankyoupage .= '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
     return 1;
   }

Is this patch actually safe?
Does not it broke something else like I do not know the blacklist check?!

I do not know if it is ok to apply to my personal fork so this is why I 
ask what do you think about it.

Thank you very much for your time!

adrian15

unsubscribe reason still asked when disabled bug svnstatus?

adrian15 — 2009-11-28T18:44:56

While trying to apply the 2.10.10 initial patches to svn I have noticed
that the eleventh of them:

"unsubscribe reason still asked when disabled"
that modified lists/index.php file no longer applies because an else 
sentence has been removed.

Can you please confirm me if this bug has been actually solved in the 
svn? (I mean, that the bug cannot be reproduced.)

I attach the patch just in case you might be interested in seeing it.

Thank you.

adrian15

attributes order on subscribe cannot be saved bug svnstatus?

adrian15 — 2009-11-28T19:10:37

While trying to apply the 2.10.10 initial patches to svn I have noticed
that the second of them:

"attributes order on subscribe cannot be saved"
which it is about:

//BUGFIX 15285 - note 50677 (part 1: Attribute order) - by tipichris -
mantis.phplist.com/view.php?id=15285
//BUGFIX 15285 - note 50677 (part 2: RSS preferences cannot be saved) -
by tipichris

applies to a file called admin/spageedit.php which no longer exists.

Can you please confirm me if this bug has been solved in the svn?

Thank you.

adrian15

2.10.10 initial patches for svn revision 1703

adrian15 — 2009-11-28T19:10:20

After some work I have just generated the initial patches for svn
revision 1703.

As you can see there are not all the patches that originally were
intented for 2.10.10 because I have some doubts about them (check my
other emails) that I have not resolved yet.

I have not tested that phplist works ok after applying these patches.
I suppose that yes, I will test it in an hour or so... but... I send
here just in case someone else is working on porting my 2.10.10 inital
patches to svn.

And a question... should I open a new mantis issue or should I update 
the current one that I had already opened for these 10 bugs?

Thank you.

adrian15

Possible bug at editlist.php

adrian15 — 2009-11-28T17:16:29

I have created an admin named admin2.
I have logged in as admin2 and I have added a list.
Whenever I have come back to list of lists page (page=list) I have seen
that I had not any link to add a new list.

I think it is ok because somewhere at config.php there's a setting that
says that an admin can only have one mailing list per default.

But what does happen when admin2 writes something like:

http://domain.com/lists/admin/?page=editlist

Yes, here you are. He can add another list and it get listed and
page=list page.

Should not editlist.php check for the admin's lists number and forgive
the entrace if the maximum number of lists per admin have been reached?

----

Further investigation has led me to another bug. Writing the id from
another list from another admin
(http://domain.com/lists/admin/?page=editlist&id=3) you can save the
list and stole it (stole the ownership) !!!

How's that possible?!

I am using the svn version but I have also found the first bug on
2.10.10. I have not checked if the bug is on in 2.10.10 but I will bet 
that yes.

Note: At the admin2 properties editlist page is listed as "owner".

adrian15

2.10.10 initial patches for svn revision 1703

adrian15 — 2009-11-28T19:09:17

After some work I have just generated the initial patches for svn 
revision 1703.

As you can see there are not all the patches that originally were 
intented for 2.10.10 because I have some doubts about them (check my 
other emails) that I have not resolved yet.

I have not tested that phplist works ok after applying these patches.
I suppose that yes, I will test it in an hour or so... but... I send 
here just in case someone else is working on porting my 2.10.10 inital 
patches to svn.

adrian15

members.php counts more users than maximum at lastpage

adrian15 — 2009-11-28T17:22:40

After applying my updated 
2.10.10_patch_01_view_more_than_50_members_on_the_list.patch to 
svn_r1703 I have seen that whenever you list the users and the total 
numbers of users are not multiple of users per page you have got 
something like that:

140 Usuarios de esta lista
Enumerando usuarios 100 a 150

It should say:

Enumerando usuarios 100 a 140

(This is spanish but I think you understand what it means).

So this is a minimal bug which I might fix myself but as I have to check 
so many bugs I just send this email so that it does not get lost.

adrian15

powered by phplist policy

adrian15 — 2009-11-28T15:43:47

I want to use a highly patched svn version of phplist and sell it as a 
service.

Is there any webpage where I can read about the phplist trademark policy?

Do you like seeing powered by phplist even if it is not an official release?

Do you prefer us to remove powered by phplist?

Do you prefer us to write powered by phplist and then improved by 
ourentreprise.com ?

And what about the phplist logo (I actually do not know remember if 
there is one :))?

Thank you very much.

adrian15

Add basic template ownership patch for svn revision1703

adrian15 — 2009-11-28T14:46:06

Hi, I have updated my patch so that it works on revision 1703 of svn.

Should I update my mantis issue or should I open a new one becasue it 
applies to another phplist version?

I think I will leave old files 
http://adrian15.raulete.net/ficheros/phplist_template_ownership/ and I 
will not upload the new ones.

So the other place where this file will be uploaded will be mantis issue.

Thank you.

Your comments on this patch are highly appreciated because I am 
interested in this patch becoming part of official phplist version.

Note: My patch modifies upgrade.php so that now we are in version 2.11.5 
instead of 2.11.4 which was the last svn version for phplist version as 
far as I understand from the upgrade.php file.

adrian15

The original message that was intented for 2.10.10:
===================================================
Hi phplist developers mailing list,

I have developed a patch to add basic template ownership to phplist.

I have opened a new mantis issue for that on:
http://mantis.phplist.com/view.php?id=15366

I am going to attach here the diff file and copy and paste the
instructions which both can be found here:
http://adrian15.raulete.net/ficheros/phplist_template_ownership/ .

Before coding that a superadmin can change an admin template ownership I
wanted to know your impression.

And as I have already said in the mantis issue (I copy and paste):

I am very interested in this patch becoming part of the official phplist.

So I am ready to correct it as many times as it is needed so that it
fits the way that you want things to be coded or if it needs to be
improved somehow or whatever.

I think I have done a great job because I have also coded the database
upgrade part but it's up to you to judge my work so that we can improve
it a lot better and add it to official phplist upstream code.


Thank you very much for your attention.

adrian15

Instructions:

This patch applies for phplist 2.10.10.

Here there are some generic instructions to apply it:

   Instructions

In any pc:

Save .diff file on phplist_patrones folder.
Save/Download phplist-2.10.10.tgz (Available at phplist.com webpage)

Inside phplist_patrones folder we make desde_cero folder.
mkdir desde_cero
We enter inside it and untar
cd desde_cero
tar xvzf ../phplist-2.10.10.tgz
Let's apply the patch
patch -p1 < ../phplist_basic_template_ownership_support.diff
We rename the folder :
mv phplist-2.10.10 phplist-2.10.11

We create another tgz file:
tar cvzf phplist-2.10.11.tgz phplist-2.10.11

Now we are going to be able to work with phplist-2.10.11.tgz file.

Now we go to the machine where we want to install or upgrade our new
improved with template ownership support phplist.

Optional: With phpmyadmin or a similar tool we can make a database
backup in order to recreate it if something fails.

Let's rename the folder /var/www/lists/ (where we can see
admin,config,dl.php,... folders/files))and we rename it to lists_old (Do
not remove it yet!).
mv /var/www/lists /var/www/lists_old

Let's untar phplist-2.10.11.tgz (Let's suppose that we have saved a copy
in the /tmp folder)

cd /tmp
tar xvzf phplist-2.10.11.tgz
cp -r phplist-2.10.11/public_html/lists /var/www

Now we are going to recover our old config file:

cd /var/www/lists/config
cp ../../lists_old/config/config.php config.php

We visit:
http://url/lists/admin/

We login as a super admin (usually admin).

As we are requested we click "upgrade" link.
And we click on "here" link.

We should see: Information: Success

If we already had patterns we should assign them an admin in order to
use them.

We can use phpmyadmin for this task. We will check admin table first.
In the admin table we can identify each one of the admin ids (We will
use this data later).

We go to template table.

In each one of its rows we will edit the column adminid and we will set
it to the id value that we had already seen in the admin table so that
each template gets associated an admin.


Note: As you might think if you have too many data you can try to speed
things with an appropiated SQL sentence.

Optional: Now it is safe to delete /var/www/lists_old/ but, as always,
the best way of doing things is saving a copy of this folder, just in case.
And, of course, remove it from /var/www folder so that the folder cannot
be accessed from outside the server.

And that's all.