gmane.comp.java.openjdk.hotspot.compiler.devel

hg: hsx/hotspot-comp/hotspot: 8001345: VM crashes withassert(n->outcnt() != 0 || C->top() == n || n->is_Proj())failed: No dead instructions after post-alloc

2013-06-19T00:56:32

Changeset: 08d35fd1b599
Author:    adlertz
Date:      2013-06-19 00:41 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/08d35fd1b599

8001345: VM crashes with assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
Summary: Remove unnecessary LoadN / DecodeN nodes at MemBarAcquire nodes.
Reviewed-by: kvn, roland

! src/share/vm/opto/memnode.cpp

hg: hsx/hotspot-comp/hotspot: 8002160: Compilation issue with adlcusing latest SunStudio compilers

2013-06-17T21:31:03

Changeset: 87a6f2df28e2
Author:    drchase
Date:      2013-06-17 12:35 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/87a6f2df28e2

8002160: Compilation issue with adlc using latest SunStudio compilers
Summary: modify declaration of 'swap' overloading; dodge optimizer bug in c1_LIR.cpp
Reviewed-by: kvn, jrose

! src/cpu/sparc/vm/macroAssembler_sparc.hpp
! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp
! src/share/vm/c1/c1_LIR.cpp

RFR (S) JDK-8001345: VM crashes with assert(n->outcnt() != 0 ||C->top() == n || n->is_Proj()) failed: No dead instructionsafter post-alloc

Niclas Adlertz — 2013-06-17T12:43:37

Hi all,

Problem:
The uses of LoadN / DecodeN nodes can sometimes be optimized away so that they are only used as precedence nodes at MemBarAcquire nodes, which means they are no longer needed.
They are later removed when building the IFG in the register allocator, after creating the liveness. Usually this is not a problem.
But if the register allocator decides that one or more virtual registers need to be spilled, and a spilled virtual register X was used at the already removed loadN / decodeN, the split code in reg_split.cpp will create a phi node chain which reaches the place where the loadN / decodeN nodes originally existed. Eventually, this leads to an empty phi node doesn't get removed. Thus, the assert triggers.

assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc

Solution:
When the ideal graph has been built, and the ideal() method is called on each node in an attempt to optimize the graph, we look for unnecessary LoadN / DecodeN nodes at MemBarAcquire nodes, and remove them so that no "dead" nodes of this kind can reach the register allocator in the first place. 

WEBREV: http://cr.openjdk.java.net/~adlertz/JDK-8001345/webrev00
JBS: https://jbs.oracle.com/bugs/browse/JDK-8001345


Kind Regards,
Niclas Adlertz

hg: hsx/hotspot-comp/hotspot: 6 new changesets

2013-06-15T01:33:30

Changeset: f2110083203d
Author:    sla
Date:      2013-06-10 11:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/f2110083203d

8005849: JEP 167: Event-Based JVM Tracing
Reviewed-by: acorn, coleenp, sla
Contributed-by: Karen Kinnear <karen.kinnear-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Bengt Rutisson <bengt.rutisson-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Calvin Cheung <calvin.cheung-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Erik Gahlin <erik.gahlin-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Erik Helin <erik.helin-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Jesper Wilhelmsson <jesper.wilhelmsson-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Keith McGuigan <keith.mcguigan-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Mattias Tobiasson <mattias.tobiasson-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Markus Gronlund <markus.gronlund-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Mikael Auno <mikael.auno-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Nils Eliasson <nils.eliasson-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Nils Loodin <nils.loodin-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Rickard Backman <rickard.backman-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Staffan Larsen <staffan.larsen-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Stefan Karlsson <stefan.karlsson-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>, Yekaterina Kantserova <yekaterina.kantserova-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>

! make/Makefile
! make/bsd/makefiles/buildtree.make
! make/bsd/makefiles/minimal1.make
! make/bsd/makefiles/top.make
+ make/bsd/makefiles/trace.make
! make/bsd/makefiles/vm.make
! make/defs.make
! make/excludeSrc.make
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/minimal1.make
! make/linux/makefiles/top.make
+ make/linux/makefiles/trace.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/buildtree.make
! make/solaris/makefiles/top.make
+ make/solaris/makefiles/trace.make
! make/solaris/makefiles/vm.make
! make/windows/build.make
! make/windows/create_obj_files.sh
! make/windows/makefiles/generated.make
! make/windows/makefiles/projectcreator.make
+ make/windows/makefiles/trace.make
! make/windows/makefiles/vm.make
! make/windows/projectfiles/common/Makefile
! src/cpu/sparc/vm/frame_sparc.cpp
! src/cpu/x86/vm/frame_x86.cpp
! src/os/bsd/vm/osThread_bsd.hpp
! src/os/bsd/vm/os_bsd.cpp
! src/os/bsd/vm/os_bsd.hpp
! src/os/bsd/vm/os_bsd.inline.hpp
! src/os/linux/vm/osThread_linux.hpp
! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp
! src/os/linux/vm/os_linux.inline.hpp
! src/os/solaris/vm/osThread_solaris.cpp
! src/os/solaris/vm/osThread_solaris.hpp
! src/os/solaris/vm/os_share_solaris.hpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/solaris/vm/os_solaris.hpp
! src/os/windows/vm/os_windows.cpp
! src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp
! src/os_cpu/bsd_x86/vm/thread_bsd_x86.hpp
! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp
! src/os_cpu/linux_x86/vm/thread_linux_x86.hpp
! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp
! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.hpp
! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp
! src/os_cpu/solaris_x86/vm/thread_solaris_x86.hpp
! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp
! src/os_cpu/windows_x86/vm/thread_windows_x86.hpp
! src/share/tools/ProjectCreator/BuildConfig.java
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp
! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/compiler/compileBroker.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp
+ src/share/vm/gc_implementation/g1/evacuationInfo.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.hpp
! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp
+ src/share/vm/gc_implementation/g1/g1YCTypes.hpp
! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp
! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp
! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp
! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp
! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp
+ src/share/vm/gc_implementation/shared/copyFailedInfo.hpp
+ src/share/vm/gc_implementation/shared/gcHeapSummary.hpp
+ src/share/vm/gc_implementation/shared/gcTimer.cpp
+ src/share/vm/gc_implementation/shared/gcTimer.hpp
+ src/share/vm/gc_implementation/shared/gcTrace.cpp
+ src/share/vm/gc_implementation/shared/gcTrace.hpp
+ src/share/vm/gc_implementation/shared/gcTraceSend.cpp
+ src/share/vm/gc_implementation/shared/gcTraceTime.cpp
+ src/share/vm/gc_implementation/shared/gcTraceTime.hpp
+ src/share/vm/gc_implementation/shared/gcWhen.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/gc_implementation/shared/vmGCOperations.cpp
! src/share/vm/gc_implementation/shared/vmGCOperations.hpp
+ src/share/vm/gc_interface/allocTracer.cpp
+ src/share/vm/gc_interface/allocTracer.hpp
! src/share/vm/gc_interface/collectedHeap.cpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/gc_interface/collectedHeap.inline.hpp
! src/share/vm/gc_interface/gcCause.cpp
! src/share/vm/gc_interface/gcCause.hpp
+ src/share/vm/gc_interface/gcName.hpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/defNewGeneration.cpp
! src/share/vm/memory/defNewGeneration.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/memory/generation.cpp
! src/share/vm/memory/heapInspection.cpp
! src/share/vm/memory/heapInspection.hpp
+ src/share/vm/memory/klassInfoClosure.hpp
! src/share/vm/memory/metaspace.hpp
! src/share/vm/memory/oopFactory.hpp
! src/share/vm/memory/referenceProcessor.cpp
! src/share/vm/memory/referenceProcessor.hpp
+ src/share/vm/memory/referenceProcessorStats.hpp
+ src/share/vm/memory/referenceType.hpp
! src/share/vm/memory/universe.cpp
! src/share/vm/memory/universe.hpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/klass.cpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/compile.hpp
! src/share/vm/opto/escape.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/loopnode.cpp
! src/share/vm/opto/matcher.cpp
+ src/share/vm/opto/phasetype.hpp
! src/share/vm/precompiled/precompiled.hpp
! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvmtiGen.java
! src/share/vm/prims/jvmtiImpl.cpp
! src/share/vm/prims/jvmtiImpl.hpp
! src/share/vm/prims/unsafe.cpp
! src/share/vm/runtime/frame.hpp
! src/share/vm/runtime/frame.inline.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/java.cpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/objectMonitor.cpp
! src/share/vm/runtime/objectMonitor.hpp
! src/share/vm/runtime/os.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/runtime/perfData.cpp
! src/share/vm/runtime/perfData.hpp
! src/share/vm/runtime/stubRoutines.hpp
! src/share/vm/runtime/sweeper.cpp
! src/share/vm/runtime/sweeper.hpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/task.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp
! src/share/vm/runtime/timer.cpp
! src/share/vm/runtime/timer.hpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/runtime/vmThread.cpp
! src/share/vm/runtime/vm_operations.cpp
! src/share/vm/runtime/vm_operations.hpp
! src/share/vm/services/attachListener.cpp
! src/share/vm/services/diagnosticArgument.cpp
! src/share/vm/services/diagnosticCommand.cpp
! src/share/vm/services/memBaseline.cpp
+ src/share/vm/trace/noTraceBackend.hpp
+ src/share/vm/trace/trace.dtd
+ src/share/vm/trace/trace.xml
+ src/share/vm/trace/traceBackend.hpp
+ src/share/vm/trace/traceDataTypes.hpp
+ src/share/vm/trace/traceEvent.hpp
+ src/share/vm/trace/traceEventClasses.xsl
+ src/share/vm/trace/traceEventIds.xsl
- src/share/vm/trace/traceEventTypes.hpp
! src/share/vm/trace/traceMacros.hpp
+ src/share/vm/trace/traceStream.hpp
+ src/share/vm/trace/traceTime.hpp
+ src/share/vm/trace/traceTypes.xsl
+ src/share/vm/trace/tracetypes.xml
! src/share/vm/trace/tracing.hpp
+ src/share/vm/trace/xinclude.mod
+ src/share/vm/trace/xsl_util.xsl
! src/share/vm/utilities/globalDefinitions.hpp
! src/share/vm/utilities/macros.hpp

Changeset: 3a353050e85a
Author:    katleman
Date:      2013-06-13 09:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/3a353050e85a

Added tag jdk8-b94 for changeset 1beed1f6f9ed

! .hgtags

Changeset: 69689078dff8
Author:    amurillo
Date:      2013-06-13 23:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/69689078dff8

Merge

- src/share/vm/trace/traceEventTypes.hpp

Changeset: 5d65c078cd0a
Author:    amurillo
Date:      2013-06-13 23:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/5d65c078cd0a

Added tag hs25-b37 for changeset 69689078dff8

! .hgtags

Changeset: f9709e27a876
Author:    amurillo
Date:      2013-06-14 07:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/f9709e27a876

8016567: new hotspot build - hs25-b38
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: ac91879aa56f
Author:    kvn
Date:      2013-06-14 16:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/ac91879aa56f

Merge

- src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp
- src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp
! src/share/vm/opto/matcher.cpp
! src/share/vm/prims/jvm.cpp

RFR (S) 8002160 : Compilation issue with adlc using latest SunStudiocompilers

David Chase — 2013-06-15T00:26:59

webrev:
http://cr.openjdk.java.net/~drchase/8002160/webrev.01/

bug:
1) 12.3 SolarisStudio compilers (and it turns out, also some versions of g++, as well as Eclipse) did not like some of the code in adlc; a reference to overloaded + default-arg'd "swap" failed to resolve.

2) Once (1) is cleared, code in c1_LIR.cpp would cause 12.3 iropt (optimizer) to crash.

fix:
1) Add "const" to the overloading, that seems to fix that for SolarisStudio and g++/
2) Locate offending function in c1_LIR
2a) file bug against Solaris Studio compilers with that as test case
2b) modify that function in harmless ways until iropt gets happy.

(And after the fix, entire new build with SS 12.3, slowdebug and fastdebug, successful compilation, and fastdebug -- the whole new build with SS12.3 - passed the jtreg tests below.

testing:
This is a sparc-only bug, so I ran jtreg on a Sparc box against compiler and closed/compiler.
I ran tests twice, once tiered, once tiered stopping at level 1.
I ran JPRT (old compilers) to be sure that I had not broken anything.

not 100% sure of the indenting of the switch/case statement after adding local scopes, but it looked slightly non-conforming to start with.

David

Any writeup on JDK8 SIMD support?

Sand Stone — 2013-06-14T06:13:29

Hi, compiler folks.

It looks like there is better SIMD instruction support at the code gen.

For a Java programmer, any guidance and code example on how to be JIT
friendlier? The best article on the Web so far is this one:
    http://developers.opengamma.com/articles/DGEMV.pdf

BTW, any plan to support Haswell AVX integer instructions?

Regards.

Bug relating to the JIT and the JNI

Guilherme Espada — 2013-06-14T00:38:56

I've found a bug relating to the JIT and the JNI, but I am unsure on
where to post it.

The official way (http://bugreport.sun.com/bugreport/) did not work for me.

hg: hsx/hotspot-comp/hotspot: 8016157: During CTW: C2:assert(!def_outside->member(r)) failed: Use of external LRGoverlaps the same LRG defined in this block

2013-06-14T01:55:59

Changeset: 7fa25f5575c9
Author:    adlertz
Date:      2013-06-14 01:19 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/7fa25f5575c9

8016157: During CTW: C2: assert(!def_outside->member(r)) failed: Use of external LRG overlaps the same LRG defined in this block
Summary: Disable rematerialization for negD node
Reviewed-by: kvn, roland

! src/share/vm/adlc/formssel.cpp
! src/share/vm/adlc/formssel.hpp

hg: hsx/hotspot-comp/hotspot: 8010124: JVM_GetClassContext: useGrowableArray instead of KlassLink

2013-06-14T00:07:19

Changeset: c52abc8a0b08
Author:    drchase
Date:      2013-06-13 15:39 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/c52abc8a0b08

8010124: JVM_GetClassContext: use GrowableArray instead of KlassLink
Summary: replace linked data structure with array (performance)
Reviewed-by: kvn
Contributed-by: christian.thalinger-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org, david.r.chase-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/share/vm/prims/jvm.cpp

RFR(M/L): 7145569: G1: optimize nmethods scanning

John Cuthbertson — 2013-06-13T22:30:59

Hi Everyone,

Can I have a few volunteers look over the changes for this CR - ideally 
I would like at least one person from the compiler team and one from the 
GC team.

Summary:
For some workloads with G1, the scanning of the Code cache cache can 
take quite a long time. In fact there have been cases where the scanning 
of the code cache is the dominator of the pause and the other worker 
threads sit an spin in the termination code while the worker that 
claimed the code cache scanning task chugs along. Part of the reason is 
that the list of nmethods with scavengable oops is a single root task. 
Another part, specifically affecting G1, is that the presence of an 
nmethod in the list depends on the definition of is_scavengable. For the 
other collectors, when the oops in an nmethod are promoted to the old 
generation that nmethod ceases to be scavengable and is pruned from the 
scavengable list. For G1, because we can collect "old" data during a 
mixed evacuation pause we can't prune the scavengable nmethod list.

The changes are my attempt at a solution outlined by Igor Veresov.

I have added a list of nmethods to each HeapRegion. That list is 
populated by nmethods that contain roots that point into that heap 
region. The lists are populated when an nmethod is created (or in the 
case of C1 when it is patched).

During an evacuation pause we skip scanning the entire code cache and 
instead scan the oops in each nmethod attached to a region when we scan 
that regions RSet. Near the end of the pause we have migrate the 
nmethods attached to regions in the collection to regions in to-space. 
During an initial mark pause, we walk the nmethods attached to all heap 
regions (other than those in the collection set - they're marked when 
their nmethod lists are scanned). During a full GC we empty the nmethod 
list attached to each region and then rebuild it - similar to what 
happens to the RSets.

To verify the integrity of these nmethod lists I've extended the heap 
verification. When scanning the code cache we check that an nmethod is 
attached to heap regions that it points into. When verifying the heap 
regions we ensure that the nmethods attached to a region contain at 
least one pointer into that region. This additional verification can add 
some time so I recently put it under control of a diagnostic flag 
(testing was performed with it enabled).

As part of these changes I moved some code around (specifically the 
verification code) in g1CollectedHeap.[ch]pp and heapRegion.[ch]pp. The 
purely clean up changes can be found at: 
http://cr.openjdk.java.net/~johnc/7145569/webrev.0.code-movement/

The webrev containing just the functionality can be found at: 
http://cr.openjdk.java.net/~johnc/7145569/webrev.1.optimize-nmethod-scanning/

The whole shebang can be found at: 
http://cr.openjdk.java.net/~johnc/7145569/webrev.all

Testing:
GC test suite with C1, C2, and Tiered on x64 and sparc (Xmixed and 
Xcomp) - with and without verification (including the extra verification);
a few jprt runs
Kitchensink (4 hour runs) with C1, C2, Tiered on x64 (Xmixed and Xcomp) 
- with and without verification (including the extra verification).

Future enhancements:
* Currently I'm using a growable array for the nmethod lists but in the 
long term I want to move to a more suitable data structure. Perhaps a 
specialized version of Stack.
* Currently I migrate nmethods from regions in the collection set to 
regions in to-space in a separate phase. Ideally this should be done 
when we're finished scanning a region's RSet. When we do this, migration 
will be performed in parallel and two threads could be pushing to a 
to-space regions nmethod list at the same time - we will need an 
"atomic" push operation. When the compilers push an nmethod, the do it 
while holding the CodeCache_lock so such an operation is, currently, 
unnecessary.

Thanks,

JohnC

hg: hsx/hotspot-comp/hotspot: 2 new changesets

2013-06-12T03:15:58

Changeset: 693e4d04fd09
Author:    drchase
Date:      2013-06-11 16:34 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/693e4d04fd09

8014959: assert(Compile::current()->live_nodes() < (uint)MaxNodeLimit) failed: Live Node limit exceeded limit
Summary: Insert extra checks and bailouts for too many nodes
Reviewed-by: kvn

! src/share/vm/opto/c2_globals.hpp
! src/share/vm/opto/chaitin.cpp
! src/share/vm/opto/coalesce.cpp
! src/share/vm/opto/matcher.cpp

Changeset: bc8956037049
Author:    kvn
Date:      2013-06-11 16:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/bc8956037049

Merge

hg: hsx/hotspot-comp/hotspot: 8003268:SharedRuntime::generate_native_wrapper doesn't save allregisters across runtime tracing calls for JNI critical native methods

2013-06-11T23:36:10

Changeset: e7f5651d459c
Author:    twisti
Date:      2013-06-11 11:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/e7f5651d459c

8003268: SharedRuntime::generate_native_wrapper doesn't save all registers across runtime tracing calls for JNI critical native methods
Reviewed-by: kvn

! src/cpu/x86/vm/sharedRuntime_x86_64.cpp

RFR(XS): 8016187: assert(nbits == 32 || (-(1 << nbits-1) <= x &&x < ( 1 << nbits-1))) failed: value out of range

Morris Meyer — 2013-06-11T18:40:08

Folks,

Could I get a review of this hsx24 backport change?  Its the same change 
as 8015437, which was pushed in last Friday.

Thanks much.

         --morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8016187.01/
JBS - https://jbs.oracle.com/bugs/browse/JDK-8016187

RFR(M) : 8010124 : JVM_GetClassContext: use GrowableArray instead ofKlassLink

David Chase — 2013-06-11T17:52:09

This is an update and application of a leftover patch from Christian Thalinger's bug 7198429 .
I believe it is intended to accumulate call stacks slightly more quickly; it is not a correctness bug.

There were some minor differences and some parts had already been applied, so it required a hand-apply and line-by-line inspection.

http://cr.openjdk.java.net/~drchase/8010124/webrev.00/

Testing: jtreg locally, JPRT, also hand-tested some applets that attempt to do Bad Things, and they failed.

David

RFR (XS): 8003268: SharedRuntime::generate_native_wrapper doesn'tsave all registers across runtime tracing calls for JNIcritical native methods

Christian Thalinger — 2013-06-10T23:28:00

http://cr.openjdk.java.net/~twisti/8003268

8003268: SharedRuntime::generate_native_wrapper doesn't save all registers across runtime tracing calls for JNI critical native methods
Reviewed-by:

SharedRuntime::generate_native_wrapper calculates c_arg as: 

  int c_arg = total_c_args - total_in_args;

which is then used for save_args/restore_args to save all already loaded arguments when calling out to the runtime. For JNI critical methods we add one additional argument to total_c_args for each array passed which means that c_arg is not zero and we skip the first argument(s) when saving them across runtime calls. 

There are two runtime calls in a native wrapper: SharedRuntime::dtrace_method_entry and SharedRuntime::rc_trace_method_entry 

The former is guarded by a SkipIfEqual and normally not executed. The latter is guarded by TraceRedefineClasses which is the reason why we crash. Using dtrace should also crash but I never tried.

src/cpu/x86/vm/sharedRuntime_x86_64.cpp

RFR (S) : 8014959 : assert(Compile::live less than(uint)MaxNodeLimit) failed: Live Node limit exceeded limit

David Chase — 2013-06-09T04:43:42

Resending, wonder if the angles in the previous subject had caused problems.
And if so, they might cause problems for other automated posts that key off the bug report title.

webrev: http://cr.openjdk.java.net/~drchase/8014959/webrev.00/

bug:
SQE MethodHandle + breakpoint + step torture test has four outcomes:
1) success;
2) failure, timeout.;
3) failure, does not reach target breakpoint;
4) crash, too many nodes

Failures 2 & 3 are a result of the torture being a little too thorough; the target methodHandle is wrapped in a random number N of various MH transformations, where N varies from 0 to 999.  However, the number of steps required to complete is about 22-25 times the wrapping level, and only 9000 steps are allowed (only enough for about 360-410 deep).  So it is recommended that the test be random in a smaller range that runs to nearly 9000 steps (i.e., 250-350).

fix: two-part; see also INTJDK-7604173 filed against the test.
This fix hardens the compiler against running out of nodes (failure #4); several missing bailout checks were added, the fudgefactor was doubled, and the node limit was increased to leave about the same number of available nodes net of tripled fudgefactor (which occurs in some tests).

testing:
1) jtreg test/compiler + test/closed on Mac laptop
2) JPRT on compiler
3) 200 runs of tweaked version of SQE test in attempt to provoke crash (with failures ignored): 100 from 900-999, 100 from 400 to 900.

David

RFR(S) 8016157: During CTW: C2: assert(!def_outside->member(r))failed: Use of external LRG overlaps the same LRG defined inthis block

Niclas Adlertz — 2013-06-10T08:12:05

Hi all, 

In bug 8005956 (https://jbs.oracle.com/bugs/browse/JDK-8005956) this assert triggered when trying to rematerialize reaches at phi nodes. This time it's failing because of rematerialization at uses (reg_split.cpp: 931).  These are the only two places that rematerialization is handled during splitting.

Doing the same fix as for JDK-8005956, i.e. removing rematerialization for nodes with live range input, gave too much performance regression. Instead, this fix invalidates rematerialization of the node type that is causing the problem negD node.

WEBREV: http://cr.openjdk.java.net/~adlertz/JDK-8016157/webrev00/
JBS: https://jbs.oracle.com/bugs/browse/JDK-8016157

Kind Regards,
Niclas Adlertz

ping?

David Chase — 2013-06-09T22:44:29

Checking to see if mail works.  Two earlier messages did not show up.

RFR (S) : 8014959 : assert(Compile::current()->live_nodes() <(uint)MaxNodeLimit) failed: Live Node limit exceeded limit

David Chase — 2013-06-08T23:56:26

webrev: http://cr.openjdk.java.net/~drchase/8014959/webrev.00/

bug:
SQE MethodHandle + breakpoint + step torture test has four outcomes:
1) success;
2) failure, timeout.;
3) failure, does not reach target breakpoint;
4) crash, too many nodes

Failures 2 & 3 are a result of the torture being a little too thorough; the target methodHandle is wrapped in a random number N of various MH transformations, where N varies from 0 to 999.  However, the number of steps required to complete is about 22-25 times the wrapping level, and only 9000 steps are allowed (only enough for about 360-410 deep).  So it is recommended that the test be random in a smaller range that runs to nearly 9000 steps (i.e., 250-350).

fix: two-part; see also INTJDK-7604173 filed against the test.
This fix hardens the compiler against running out of nodes (failure #4); several missing bailout checks were added, the fudgefactor was doubled, and the node limit was increased to leave about the same number of available nodes net of tripled fudgefactor (which occurs in some tests).

testing:
1) jtreg test/compiler + test/closed on Mac laptop
2) JPRT on compiler
3) 200 runs of tweaked version of SQE test in attempt to provoke crash (with failures ignored): 100 from 900-999, 100 from 400 to 900.

David

hg: hsx/hotspot-comp/hotspot: 8008407: remove SPARC V8 support

2013-06-08T05:18:22

Changeset: 46c544b8fbfc
Author:    morris
Date:      2013-06-07 16:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/46c544b8fbfc

8008407: remove SPARC V8 support
Summary: Removed most of the SPARC V8 instructions
Reviewed-by: kvn, twisti

! src/cpu/sparc/vm/assembler_sparc.hpp
! src/cpu/sparc/vm/assembler_sparc.inline.hpp
! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp
! src/cpu/sparc/vm/c2_init_sparc.cpp
! src/cpu/sparc/vm/disassembler_sparc.hpp
! src/cpu/sparc/vm/globals_sparc.hpp
! src/cpu/sparc/vm/interp_masm_sparc.cpp
! src/cpu/sparc/vm/macroAssembler_sparc.cpp
! src/cpu/sparc/vm/macroAssembler_sparc.hpp
! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp
! src/cpu/sparc/vm/nativeInst_sparc.cpp
! src/cpu/sparc/vm/nativeInst_sparc.hpp
! src/cpu/sparc/vm/register_sparc.hpp
! src/cpu/sparc/vm/sharedRuntime_sparc.cpp
! src/cpu/sparc/vm/sparc.ad
! src/cpu/sparc/vm/stubGenerator_sparc.cpp
! src/cpu/sparc/vm/stubRoutines_sparc.cpp
! src/cpu/sparc/vm/stubRoutines_sparc.hpp
! src/cpu/sparc/vm/templateInterpreter_sparc.cpp
! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/sparc/vm/vm_version_sparc.cpp
! src/cpu/sparc/vm/vm_version_sparc.hpp
- src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp
! src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp
- src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp
! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp
! src/os_cpu/solaris_sparc/vm/solaris_sparc.il
! src/share/vm/runtime/arguments.cpp

hg: hsx/hotspot-comp/hotspot: 25 new changesets

2013-06-07T23:05:47

Changeset: 5534bd30c151
Author:    jcoomes
Date:      2013-05-30 13:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/5534bd30c151

6725714: par compact - add a table to speed up bitmap searches
Reviewed-by: jmasa, tschatzl

! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp

Changeset: 47bdfb3d010f
Author:    stefank
Date:      2013-05-30 10:58 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/47bdfb3d010f

8015486: PSScavenge::is_obj_in_young is unnecessarily slow with UseCompressedOops
Summary: Compare compressed oops to a compressed young gen boundary instead of uncompressing the oops before doing the young gen boundary check.
Reviewed-by: brutisso, jmasa

! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp

Changeset: c20186fa611b
Author:    jwilhelm
Date:      2013-06-01 10:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/c20186fa611b

Merge


Changeset: e72f7eecc96d
Author:    tschatzl
Date:      2013-05-28 09:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/e72f7eecc96d

8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
Summary: Fixed the output of G1SummarizeRSetStats: too small datatype for the number of concurrently processed cards, added concurrent remembered set thread time retrieval for Linux and Windows (BSD uses os::elapsedTime() now), and other cleanup. The information presented during VM operation is now relative to the previous output, not always cumulative if G1SummarizeRSetStatsPeriod > 0. At VM exit, the code prints a cumulative summary.
Reviewed-by: johnc, jwilhelm

! make/excludeSrc.make
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
+ src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp
+ src/share/vm/gc_implementation/g1/g1RemSetSummary.hpp
+ test/gc/g1/TestSummarizeRSetStats.java

Changeset: 3a4805ad0005
Author:    johnc
Date:      2013-06-04 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/3a4805ad0005

8015244: G1: Verification after a full GC is incorrectly placed.
Summary: In a full GC, move the verification after the GC to after RSet rebuilding. Verify RSet entries during a full GC under control of a flag.
Reviewed-by: tschatzl, brutisso

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp

Changeset: 87c64c0438fb
Author:    tamao
Date:      2013-06-03 14:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/87c64c0438fb

6976350: G1: deal with fragmentation while copying objects during GC
Summary: Create G1ParGCAllocBufferContainer to contain two buffers instead of previously using one buffer, in order to hold the first priority buffer longer. Thus, when some large objects hits the value of free space left in the first priority buffer it has an alternative to fit in the second priority buffer while the first priority buffer is given more chances to try allocating smaller objects. Overall, it will improve heap space efficiency.
Reviewed-by: johnc, jmasa, brutisso
Contributed-by: tamao <tao.mao-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>

! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp

Changeset: 2f7a31318b84
Author:    johnc
Date:      2013-06-04 14:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/2f7a31318b84

Merge


Changeset: a1ebd310d5c1
Author:    iklam
Date:      2013-05-28 16:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/a1ebd310d5c1

8014912: Restore PrintSharedSpaces functionality after NPG
Summary: Added dumping of object sizes in CDS archive, sorted by MetaspaceObj::Type
Reviewed-by: coleenp, acorn

! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp
! src/share/vm/memory/metaspaceShared.cpp
! src/share/vm/oops/annotations.cpp
! src/share/vm/oops/constMethod.cpp
! src/share/vm/oops/constantPool.cpp
! src/share/vm/oops/cpCache.cpp
! src/share/vm/oops/klass.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/oops/methodCounters.cpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/oops/symbol.cpp
! src/share/vm/utilities/array.hpp

Changeset: fe00365c8f31
Author:    sspitsyn
Date:      2013-05-30 11:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/fe00365c8f31

8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds
Summary: The InstanceKlass _initial_method_idnum value must be adjusted if overpass methods are added.
Reviewed-by: twisti, kvn
Contributed-by: serguei.spitsyn-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/share/vm/classfile/defaultMethods.cpp
+ test/compiler/8015436/Test8015436.java

Changeset: a589c78a8811
Author:    rbackman
Date:      2013-05-31 13:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/a589c78a8811

8014709: Constructor.getAnnotatedReturnType() returns empty AnnotatedType
Reviewed-by: stefank, rbackman
Contributed-by: Joel Borggren-Franck <joel.franck-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>

! src/share/vm/runtime/reflection.cpp
! test/runtime/8007320/ConstMethodTest.java

Changeset: efe8b7d64424
Author:    ctornqvi
Date:      2013-05-31 20:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/efe8b7d64424

6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits
Summary: Using CHECK_NULL when calling multi_allocate() from the corresponding reflection code; added test for this condition
Reviewed-by: dholmes, minqi
Contributed-by: Mikhailo Seledtsov <mikhailo.seledtsov-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>

! src/share/vm/runtime/reflection.cpp
+ test/runtime/memory/MultiAllocateNullCheck.java

Changeset: 532c55335fb6
Author:    dcubed
Date:      2013-06-01 09:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/532c55335fb6

Merge


Changeset: 4552a7633a07
Author:    hseigel
Date:      2013-06-03 10:00 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/4552a7633a07

8015385: Remove RelaxAccessControlCheck for JDK 8 bytecodes
Summary: Check bytecode versions along with RelaxAccessControlCheck version
Reviewed-by: dholmes, acorn

! src/share/vm/classfile/verifier.hpp
! src/share/vm/runtime/reflection.cpp

Changeset: e7d29a019a3c
Author:    sspitsyn
Date:      2013-06-03 14:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/e7d29a019a3c

8014052: JSR292: assert(end_offset == next_offset) failed: matched ending
Summary: A call to the finalize_operands_merge() must be unconditional
Reviewed-by: kvn, twisti
Contributed-by: serguei.spitsyn-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/share/vm/prims/jvmtiRedefineClasses.cpp

Changeset: 2f004f9dc9e1
Author:    sspitsyn
Date:      2013-06-04 01:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/2f004f9dc9e1

8015803: Test8015436.java fails 'can not access a member of class Test8015436 with modifiers "public static"'
Summary: Newly added test has an issue: the main class must be public
Reviewed-by: kvn, jbachorik, coleenp
Contributed-by: serguei.spitsyn-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! test/compiler/8015436/Test8015436.java

Changeset: 04551f4dbdb9
Author:    nloodin
Date:      2013-06-05 09:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/04551f4dbdb9

Merge


Changeset: 62e7bac9524f
Author:    dcubed
Date:      2013-06-04 19:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/62e7bac9524f

8010257: remove unused thread-local variables _ScratchA and _ScratchB
Summary: Remove dead code.
Reviewed-by: twisti, coleenp

! src/share/vm/runtime/thread.hpp

Changeset: 6bf8b8bb7c19
Author:    hseigel
Date:      2013-06-05 14:12 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/6bf8b8bb7c19

8009302: Mac OS X: JVM crash on infinite recursion on Appkit Thread
Summary: Use SA_ONSTACK flag to ensure signal gets delivered properly.
Reviewed-by: dholmes, coleenp
Contributed-by: gerard.ziemski-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/os/bsd/vm/os_bsd.cpp

Changeset: f8c8cace25ad
Author:    dcubed
Date:      2013-06-06 05:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/f8c8cace25ad

Merge

! src/os/bsd/vm/os_bsd.cpp

Changeset: ef1818846c22
Author:    kvn
Date:      2013-06-06 11:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/ef1818846c22

Merge

! src/os/bsd/vm/os_bsd.cpp

Changeset: 61dcf187a198
Author:    katleman
Date:      2013-06-06 09:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/61dcf187a198

Added tag jdk8-b93 for changeset 573d86d412cd

! .hgtags

Changeset: 3c78a14da19d
Author:    amurillo
Date:      2013-06-07 09:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/3c78a14da19d

Merge

! .hgtags

Changeset: 1beed1f6f9ed
Author:    amurillo
Date:      2013-06-07 09:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/1beed1f6f9ed

Added tag hs25-b36 for changeset 3c78a14da19d

! .hgtags

Changeset: d0add7016434
Author:    amurillo
Date:      2013-06-07 09:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/d0add7016434

8016078: new hotspot build - hs25-b37
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: ea60d1de6735
Author:    kvn
Date:      2013-06-07 11:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/ea60d1de6735

Merge