gmane.os.freebsd.devel.cvs.src

Re: svn commit: r250856 - head/sys/dev/ath/ath_hal/ar5416

Adrian Chadd — 2013-05-21T18:16:51

Yup, this should be fixed, thanks!


Adrian


On 21 May 2013 09:42, Glen Barber <gjb< at >freebsd.org> wrote:
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250866 - head/sys/dev/ath

Adrian Chadd — 2013-05-21T18:13:58

Author: adrian
Date: Tue May 21 18:13:57 2013
New Revision: 250866
URL: http://svnweb.freebsd.org/changeset/base/250866

Log:
  Implement a separate hardware queue threshold for aggregate and non-aggr
  traffic.
  
  When transmitting non-aggregate traffic, we need to keep the hardware
  busy whilst transmitting or small bursts in txdone/tx latency will
  kill us.
  
  This restores non-aggregate iperf performance, especially when doing
  TDMA.
  
  Tested:
  
  * AR5416<->AR5416, TDMA
  * AR5416 STA <-> AR9280 AP

Modified:
  head/sys/dev/ath/if_ath.c
  head/sys/dev/ath/if_ath_sysctl.c
  head/sys/dev/ath/if_ath_tx.c
  head/sys/dev/ath/if_ath_tx.h
  head/sys/dev/ath/if_athvar.h

Modified: head/sys/dev/ath/if_ath.c
==============================================================================
--- head/sys/dev/ath/if_ath.cTue May 21 18:02:54 2013(r250865)
+++ head/sys/dev/ath/if_ath.cTue May 21 18:13:57 2013(r250866)
< at >< at > -839,7 +839,8 < at >< at > ath_attach(u_int16_t devid, struct ath_s
 /*
  * Initial aggregation

svn commit: r250865 - head/sys/dev/ath

Adrian Chadd — 2013-05-21T18:02:54

Author: adrian
Date: Tue May 21 18:02:54 2013
New Revision: 250865
URL: http://svnweb.freebsd.org/changeset/base/250865

Log:
  Enable the use of TDMA on an 802.11n channel (with aggregation disabled,
  of course.)
  
  There's a few things that needed to happen:
  
  * In case someone decides to set the beacon transmission rate to be
    at an MCS rate, use the MCS-aware version of the duration calculation
    to figure out how long the received beacon frame was.
  
  * If TxOP enforcing is available on the hardware and we're doing TDMA,
    enable it after a reset and set the TDMA guard interval to zero.
    This seems to behave fine.
  
  TODO:
  
  * Although I haven't yet seen packet loss, the PHY errors that would be
    triggered (specifically Transmit-Override-Receive) aren't enabled
    by the 11n HAL.  I'll have to do some work to enable these PHY errors
    for debugging.
  
  What broke:
  
  * My recent changes to the TX queue handling has resulted in the driver
    not keeping the hardware queu

svn commit: r250864 - head/sys/powerpc/include

Marcel Moolenaar — 2013-05-21T18:00:47

Author: marcel
Date: Tue May 21 18:00:47 2013
New Revision: 250864
URL: http://svnweb.freebsd.org/changeset/base/250864

Log:
  Fix the PowerPC Book-E register definitions used by the remote GDB
  protocol.
  
  Obtained from:Juniper Networks, Inc.

Modified:
  head/sys/powerpc/include/gdb_machdep.h

Modified: head/sys/powerpc/include/gdb_machdep.h
==============================================================================
--- head/sys/powerpc/include/gdb_machdep.hTue May 21 17:47:53 2013(r250863)
+++ head/sys/powerpc/include/gdb_machdep.hTue May 21 18:00:47 2013(r250864)
< at >< at > -29,11 +29,20 < at >< at >
 #ifndef _MACHINE_GDB_MACHDEP_H_
 #define_MACHINE_GDB_MACHDEP_H_
 
+#ifdef BOOKE
+#definePPC_GDB_NREGS01
+#definePPC_GDB_NREGS4(70 + 1)
+#definePPC_GDB_NREGS8(1 + 32)
+#definePPC_GDB_NREGS160
+#else
+#definePPC_GDB_NREGS00
 #definePPC_GDB_NREGS4(32 + 7 + 2)
 #definePPC_GDB_NREGS832
 #definePPC_GDB_NREGS1632
+#endif
 
-#define GDB_NREGS(PPC_GDB_NREGS4 + PPC_GDB_NREGS8 + PPC_GDB_NREGS16)
+#define

svn commit: r250863 - head/lib/csu

Marcel Moolenaar — 2013-05-21T17:47:54

Author: marcel
Date: Tue May 21 17:47:53 2013
New Revision: 250863
URL: http://svnweb.freebsd.org/changeset/base/250863

Log:
  Add a makefle that recurses into the right architecture-specific
  sub-directory. This to allow simpler logic outside of the csu
  directory.
  
  Obtained from:Juniper Networks, Inc.

Added:
  head/lib/csu/Makefile   (contents, props changed)

Added: head/lib/csu/Makefile
==============================================================================
--- /dev/null00:00:00 1970(empty, because file is newly added)
+++ head/lib/csu/MakefileTue May 21 17:47:53 2013(r250863)
< at >< at > -0,0 +1,10 < at >< at >
+# $FreeBSD$
+
+ARCH= ${MACHINE_ARCH:S/i386/i386-elf/}
+.if exists(${.CURDIR}/${ARCH})
+SUBDIR+= ${ARCH}
+.else
+SUBDIR+= ${MACHINE_CPUARCH}
+.endif
+
+.include <bsd.subdir.mk>
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r247086 - head/sys/x86/isa

Jung-uk Kim — 2013-05-21T17:28:22

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-05-21 05:18:46 -0400, Bruce Evans wrote:
...

When I wrote the resume code for amd64, I studied the pmtimer and
realized the same problems, of course.  So, I simply reduced the code
and embedded it in acpi.c (without fixing underlying problems) because
a) I didn't want the dead code in pmtimer, b) acpi is mandatory for
amd64, and c) I didn't want to disturb i386 (or ia64) code paths.

In fact, my evil plan was a) deprecate apm and pmtimer for i386, b)
improve the code in acpi.c, and c) fix "calcru: runtime went
backwards" problem for good.  But I never found free time to do that. :-(


/etc/rc.{suspend,resume} already do that.  So, yes, the "feature" is
redundant.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)

iQEcBAEBAgAGBQJRm662AAoJECXpabHZMqHO+fgH/iEGdzAXeZuG6F4+fGBk9wCi
nEyz/RoJeQ7OwdR8vVIcs3z9TwZT58QVOipt5Tgh6cr77fRWfTrBhdZEWDSInXcb
wpnFXeXNe0MVNHduuq3QIpmpHxJLHUMLKTdaBJhaVixATcQovYhMZUljq0AxVKDs
VJw346YrdXI3IaAzXbm1Oon

svn commit: r250861 - head/gnu/usr.bin/grep

Marcel Moolenaar — 2013-05-21T17:30:28

Author: marcel
Date: Tue May 21 17:30:27 2013
New Revision: 250861
URL: http://svnweb.freebsd.org/changeset/base/250861

Log:
  Don't look for headers outside of the source or object directories. In
  particular, don't use DESTDIR. Such creates an unnecessary dependency
  on the build machine.
  
  Obtained from:  Juniper Networks, Inc.

Modified:
  head/gnu/usr.bin/grep/Makefile

Modified: head/gnu/usr.bin/grep/Makefile
==============================================================================
--- head/gnu/usr.bin/grep/MakefileTue May 21 17:28:19 2013(r250860)
+++ head/gnu/usr.bin/grep/MakefileTue May 21 17:30:27 2013(r250861)
< at >< at > -13,7 +13,7 < at >< at > SRCS=closeout.c dfa.c error.c exclude.c
 isdir.c kwset.c obstack.c quotearg.c savedir.c search.c xmalloc.c \
 xstrtoumax.c
 
-CFLAGS+=-I${.CURDIR} -I${DESTDIR}/usr/include/gnu -DHAVE_CONFIG_H
+CFLAGS+=-I${.CURDIR} -I${.CURDIR}/../../lib/libregex -DHAVE_CONFIG_H
 
 .if ${MK_BSD_GREP} != "yes"
 LINKS+=${BINDIR}/grep ${BINDIR}/egrep \
_______________________

svn commit: r250860 - head/gnu/usr.bin/diff

Marcel Moolenaar — 2013-05-21T17:28:19

Author: marcel
Date: Tue May 21 17:28:19 2013
New Revision: 250860
URL: http://svnweb.freebsd.org/changeset/base/250860

Log:
  Don't look for headers outside of the source or object directories. In
  particular, don't use DESTDIR. Such creates an unnecessary dependency
  on the build machine.
  
  Obtained from:Juniper Networks, Inc.

Modified:
  head/gnu/usr.bin/diff/Makefile

Modified: head/gnu/usr.bin/diff/Makefile
==============================================================================
--- head/gnu/usr.bin/diff/MakefileTue May 21 16:58:23 2013(r250859)
+++ head/gnu/usr.bin/diff/MakefileTue May 21 17:28:19 2013(r250860)
< at >< at > -17,10 +17,10 < at >< at > CFLAGS+=-funsigned-char
 
 CFLAGS+=-DHAVE_CONFIG_H
 CFLAGS+=-DPR_PROGRAM=\"/usr/bin/pr\"
-CFLAGS+=-I${DESTDIR}/usr/include/gnu
 CFLAGS+=-I${.CURDIR}/../../../contrib/diff
 CFLAGS+=-I${.CURDIR}/../../../contrib/diff/src
 CFLAGS+=-I${.CURDIR}/../../../contrib/diff/lib
+CFLAGS+=-I${.CURDIR}/../../lib/libregex
 
 SUBDIR+=doc
 
___________________________________

Re: svn commit: r250659 - in head: . share/mk tools/build/options tools/tools/makeroot

Brooks Davis — 2013-05-21T17:00:00

The problem seems to be that clang and gcc don't agree about the meaning
of -isystem and --sysroot.  I've committed a change that I belive
restores the status quo.

svn commit: r250859 - head

Brooks Davis — 2013-05-21T16:58:23

Author: brooks
Date: Tue May 21 16:58:23 2013
New Revision: 250859
URL: http://svnweb.freebsd.org/changeset/base/250859

Log:
  Restore the ability to build on systems with 32-bit compat when
  the system compiler is not clang.  clang and gcc appear to differ
  signficantly in their interpretation of -isystem and --sysroot.  Further
  work is likely required to support an external gcc.
  
  Reported by:andreast, fidaj< at >ukr.net, sergey.dyatko< at >gmail.com

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1Tue May 21 16:34:44 2013(r250858)
+++ head/Makefile.inc1Tue May 21 16:58:23 2013(r250859)
< at >< at > -366,10 +366,12 < at >< at > LIB32WMAKEFLAGS=\
 
 
 LIB32FLAGS=-m32 ${LIB32CPUFLAGS} -DCOMPAT_32BIT \
---sysroot=${WORLDTMP} \
 -isystem ${LIB32TMP}/usr/include/ \
 -L${LIB32TMP}/usr/lib32 \
 -B${LIB32TMP}/usr/lib32
+.if ${XCC:M/*}
+LIB32FLAGS+=--sysroot=${WORLDTMP}
+.endif
 
 # Yes, the flags are redund

Re: svn commit: r250856 - head/sys/dev/ath/ath_hal/ar5416

Glen Barber — 2013-05-21T16:42:00

This breaks tinderbox.

/src/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c -I/src/sys/dev/ath
-I/src/sys/dev/ath/ath_hal
/src/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c:507:12: error: implicit
conversion from enumeration type 'HAL_STATUS' to different enumeration
type 'HAL_BOOL' [-Werror,-Wenum-conversion]
                        return (HAL_ENOTSUPP);
                        ~~~~~~  ^~~~~~~~~~~~
1 error generated.
*** Error code 1

Stop.
make: stopped in /obj/arm.arm/src/sys/LINT

Glen

Re: svn commit: r250853 - in head/sys: compat/freebsd32 kern

John Baldwin — 2013-05-21T14:41:30

I get to share the pointy hat as I missed the padding requirement for the 
posix_f*() compat32 shims.

svn commit: r250856 - head/sys/dev/ath/ath_hal/ar5416

Adrian Chadd — 2013-05-21T14:28:05

Author: adrian
Date: Tue May 21 14:28:05 2013
New Revision: 250856
URL: http://svnweb.freebsd.org/changeset/base/250856

Log:
  Fix build break - the SetCapability calls return HAL_BOOL,
  not HAL_STATUS.

Modified:
  head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c

Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c
==============================================================================
--- head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.cTue May 21 13:02:37 2013(r250855)
+++ head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.cTue May 21 14:28:05 2013(r250856)
< at >< at > -504,7 +504,7 < at >< at > ar5416SetCapability(struct ath_hal *ah, 
 return AH_TRUE;
 case HAL_CAP_ENFORCE_TXOP:
 if (capability != 1)
-return (HAL_ENOTSUPP);
+return AH_FALSE;
 if (setting) {
 AH5212(ah)->ah_miscMode
     |= AR_PCU_TXOP_TBTT_LIMIT_ENA;
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-un

svn commit: r250854 - in head/sys: compat/freebsd32 kern sys

Konstantin Belousov — 2013-05-21T11:41:08

Author: kib
Date: Tue May 21 11:41:08 2013
New Revision: 250854
URL: http://svnweb.freebsd.org/changeset/base/250854

Log:
  Regenerate.

Modified:
  head/sys/compat/freebsd32/freebsd32_proto.h
  head/sys/compat/freebsd32/freebsd32_syscall.h
  head/sys/compat/freebsd32/freebsd32_syscalls.c
  head/sys/compat/freebsd32/freebsd32_sysent.c
  head/sys/compat/freebsd32/freebsd32_systrace_args.c
  head/sys/kern/init_sysent.c
  head/sys/kern/syscalls.c
  head/sys/kern/systrace_args.c
  head/sys/sys/syscall.h
  head/sys/sys/syscall.mk
  head/sys/sys/sysproto.h

Modified: head/sys/compat/freebsd32/freebsd32_proto.h
==============================================================================
--- head/sys/compat/freebsd32/freebsd32_proto.hTue May 21 11:40:16 2013(r250853)
+++ head/sys/compat/freebsd32/freebsd32_proto.hTue May 21 11:41:08 2013(r250854)
< at >< at > -3,7 +3,7 < at >< at >
  *
  * DO NOT EDIT-- this file is automatically generated.
  * $FreeBSD$
- * created from FreeBSD: head/sys/compat/freebsd32/syscalls.master 250159

svn commit: r250853 - in head/sys: compat/freebsd32 kern

Konstantin Belousov — 2013-05-21T11:40:16

Author: kib
Date: Tue May 21 11:40:16 2013
New Revision: 250853
URL: http://svnweb.freebsd.org/changeset/base/250853

Log:
  Fix the wait6(2) on 32bit architectures and for the compat32, by using
  the right type for the argument in syscalls.master.  Also fix the
  posix_fallocate(2) and posix_fadvise(2) compat32 syscalls on the
  architectures which require padding of the 64bit argument.
  
  Noted and reviewed by:jhb
  Pointy hat to:kib
  MFC after:1 week

Modified:
  head/sys/compat/freebsd32/freebsd32_misc.c
  head/sys/compat/freebsd32/syscalls.master
  head/sys/kern/syscalls.master

Modified: head/sys/compat/freebsd32/freebsd32_misc.c
==============================================================================
--- head/sys/compat/freebsd32/freebsd32_misc.cTue May 21 11:31:56 2013(r250852)
+++ head/sys/compat/freebsd32/freebsd32_misc.cTue May 21 11:40:16 2013(r250853)
< at >< at > -198,8 +198,8 < at >< at > freebsd32_wait6(struct thread *td, struc
 bzero(sip, sizeof(*sip));
 } else
 sip = NULL;
-error = kern_

svn commit: r250852 - head/sys/fs/nullfs

Konstantin Belousov — 2013-05-21T11:31:56

Author: kib
Date: Tue May 21 11:31:56 2013
New Revision: 250852
URL: http://svnweb.freebsd.org/changeset/base/250852

Log:
  Do not leak the NULLV_NOUNLOCK flag from the nullfs_unlink_lowervp(),
  for the case when the nullfs vnode is not reclaimed.  Otherwise, later
  reclamation would not unlock the lower vnode.
  
  Reported by:antoine
  Tested by:pho
  Sponsored by:The FreeBSD Foundation
  MFC after:1 week

Modified:
  head/sys/fs/nullfs/null_vfsops.c

Modified: head/sys/fs/nullfs/null_vfsops.c
==============================================================================
--- head/sys/fs/nullfs/null_vfsops.cTue May 21 11:24:32 2013(r250851)
+++ head/sys/fs/nullfs/null_vfsops.cTue May 21 11:31:56 2013(r250852)
< at >< at > -409,16 +409,28 < at >< at > nullfs_unlink_lowervp(struct mount *mp, 
 vhold(vp);
 vunref(vp);
 
-/*
- * If vunref() dropped the last use reference on the nullfs
- * vnode, it must be reclaimed, and its lock was split from
- * the lower vnode lock.  Need to do extra unlock before
- * allowin

svn commit: r250851 - in head/sys/amd64: amd64 include

Konstantin Belousov — 2013-05-21T11:24:32

Author: kib
Date: Tue May 21 11:24:32 2013
New Revision: 250851
URL: http://svnweb.freebsd.org/changeset/base/250851

Log:
  Fix the hardware watchpoints on SMP amd64.  Load the updated %dr
  registers also on other CPUs, besides the CPU which happens to execute
  the ddb.  The debugging registers are stored in the pcpu area,
  together with the command which is executed by the IPI stop handler
  upon resume.
  
  Reviewed by:jhb
  Sponsored by:The FreeBSD Foundation
  MFC after:1 week

Modified:
  head/sys/amd64/amd64/db_trace.c
  head/sys/amd64/amd64/mp_machdep.c
  head/sys/amd64/include/md_var.h
  head/sys/amd64/include/pcpu.h

Modified: head/sys/amd64/amd64/db_trace.c
==============================================================================
--- head/sys/amd64/amd64/db_trace.cTue May 21 11:07:12 2013(r250850)
+++ head/sys/amd64/amd64/db_trace.cTue May 21 11:24:32 2013(r250851)
< at >< at > -33,6 +33,7 < at >< at > __FBSDID("$FreeBSD$");
 #include <sys/systm.h>
 #include <sys/kdb.h>
 #include <sys/proc.h>
+#includ

svn commit: r250850 - head/sys/amd64/amd64

Konstantin Belousov — 2013-05-21T11:07:12

Author: kib
Date: Tue May 21 11:07:12 2013
New Revision: 250850
URL: http://svnweb.freebsd.org/changeset/base/250850

Log:
  Add amd64-specific ddb command 'show phys2dmap', which calculates the
  address in the direct map corresponding to the given physical address.
  
  Reviewed by:jhb
  Sponsored by:The FreeBSD Foundation
  MFC after:1 week

Modified:
  head/sys/amd64/amd64/pmap.c

Modified: head/sys/amd64/amd64/pmap.c
==============================================================================
--- head/sys/amd64/amd64/pmap.cTue May 21 11:04:00 2013(r250849)
+++ head/sys/amd64/amd64/pmap.cTue May 21 11:07:12 2013(r250850)
< at >< at > -5535,4 +5535,16 < at >< at > DB_SHOW_COMMAND(pte, pmap_print_pte)
 pte = pmap_pde_to_pte(pde, va);
 db_printf(" pte %#016lx\n", *pte);
 }
+
+DB_SHOW_COMMAND(phys2dmap, pmap_phys2dmap)
+{
+vm_paddr_t a;
+
+if (have_addr) {
+a = (vm_paddr_t)addr;
+db_printf("0x%jx\n", (uintmax_t)PHYS_TO_DMAP(a));
+} else {
+db_printf("show phys2dmap addr\n");
+}
+}
 #endif
__________________

svn commit: r250849 - head/sys/vm

Konstantin Belousov — 2013-05-21T11:04:00

Author: kib
Date: Tue May 21 11:04:00 2013
New Revision: 250849
URL: http://svnweb.freebsd.org/changeset/base/250849

Log:
  Add ddb command 'show pginfo' which provides useful information about
  a vm page, denoted either by an address of the struct vm_page, or, if
  the '/p' modifier is specified, by a physical address of the
  corresponding frame.
  
  Reviewed by:jhb
  Sponsored by:The FreeBSD Foundation
  MFC after:1 week

Modified:
  head/sys/vm/vm_page.c

Modified: head/sys/vm/vm_page.c
==============================================================================
--- head/sys/vm/vm_page.cTue May 21 06:13:38 2013(r250848)
+++ head/sys/vm/vm_page.cTue May 21 11:04:00 2013(r250849)
< at >< at > -2884,4 +2884,27 < at >< at > DB_SHOW_COMMAND(pageq, vm_page_print_pag
 *vm_pagequeues[PQ_ACTIVE].pq_cnt,
 *vm_pagequeues[PQ_INACTIVE].pq_cnt);
 }
+
+DB_SHOW_COMMAND(pginfo, vm_page_print_pginfo)
+{
+vm_page_t m;
+boolean_t phys;
+
+if (!have_addr) {
+db_printf("show pginfo addr\n");
+return;
+}
+
+phys = strchr(

Re: svn commit: r247086 - head/sys/x86/isa

Bruce Evans — 2013-05-21T09:18:46


In theory, acpi should handle this, but I've never been able to find where
acpi either reads an acpi clock that gives the time or sets the time to
the current time on resume after reading it from some other clock.

Now I just found acpi_resync_clock() in dev/acpica/acpi.c.  This if under
an amd64 ifdef, so it can't work for i386, and its quality is much lower
than that of pmtimer's already low quality (PS: actually it is equally low
in a different way):

< at > static void
< at > acpi_resync_clock(struct acpi_softc *sc)
< at > {
< at > #ifdef __amd64__
< at >     if (!acpi_reset_clock)
< at > return;

Since the code has not been tested (according to the comment on the sysctl),
there is a sysctl to clear this variable to turn it off.  The variable
defaults to on.

< at > 
< at >     /*
< at >      * Warm up timecounter again and reset system clock.
< at >      */
< at >     (void)timecounter->tc_get_timecount(timecounter);
< at >     (void)timecounter->tc_get_timecount(timecounter);
< at >     inittodr(time_second + sc->acpi_sleep_delay);
< at > #endif
< at > }

The parameter to

svn commit: r250848 - in head/sys/dev/usb: . quirk

Hans Petter Selasky — 2013-05-21T06:13:38

Author: hselasky
Date: Tue May 21 06:13:38 2013
New Revision: 250848
URL: http://svnweb.freebsd.org/changeset/base/250848

Log:
  Add new USB quirk.
  
  MFC after:1 week
  PR:usb/178771

Modified:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs

Modified: head/sys/dev/usb/quirk/usb_quirk.c
==============================================================================
--- head/sys/dev/usb/quirk/usb_quirk.cTue May 21 06:10:26 2013(r250847)
+++ head/sys/dev/usb/quirk/usb_quirk.cTue May 21 06:13:38 2013(r250848)
< at >< at > -427,6 +427,7 < at >< at > static struct usb_quirk_entry usb_quirks
     UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_INQUIRY_EVPD,
     UQ_MSC_NO_SYNC_CACHE),
 USB_QUIRK(WESTERN, MYPASSWORD, 0x0000, 0xffff, UQ_MSC_FORCE_SHORT_INQ),
+USB_QUIRK(WESTERN, MYPASSPORT, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE),
 USB_QUIRK(WINMAXGROUP, FLASH64MC, 0x0000, 0xffff, UQ_MSC_FORCE_WIRE_BBB,
     UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_INQUIRY),
 USB_QUIRK(YANO, FW800HD, 0x0000, 0xffff, UQ_MSC_FORCE_WIRE_BBB,

M