gmane.org.wikimedia.mediawiki.cvs

[MediaWiki-commits] [Gerrit] Convert from DOS line endings (CRLF)to Unix ones (LF) - change (mediawiki...VisualEditor)

jenkins-bot (Code Review — 2013-05-25T22:04:44

jenkins-bot has submitted this change and it was merged.

Change subject: Convert from DOS line endings (CRLF) to Unix ones (LF)
......................................................................


Convert from DOS line endings (CRLF) to Unix ones (LF)

Change-Id: I66c2d6662c7512d5c55daf7a8a1876f00f8a7705
---
M modules/jquery/jquery.js
M modules/rangy/rangy-core-1.3.js
M modules/rangy/rangy-core.js
M modules/ve/ui/styles/images/callout.svg
M modules/ve/ui/styles/images/icons/accept.svg
M modules/ve/ui/styles/images/icons/add-item.svg
M modules/ve/ui/styles/images/icons/alert.svg
M modules/ve/ui/styles/images/icons/arched-arrow-ltr.svg
M modules/ve/ui/styles/images/icons/arched-arrow-rtl.svg
M modules/ve/ui/styles/images/icons/bold-a.svg
M modules/ve/ui/styles/images/icons/bold-b.svg
M modules/ve/ui/styles/images/icons/bold-f.svg
M modules/ve/ui/styles/images/icons/bullet-list-ltr.svg
M modules/ve/ui/styles/images/icons/bullet-list-rtl.svg
M modules/ve/ui/styles/images/icons/check.svg
M modules/ve/ui/styl

[MediaWiki-commits] [Gerrit] Optimize JS, move JS ResLoad module,bump to 0.3.3 - change (mediawiki...CommunityTwitter)

RAN1 (Code Review — 2013-05-25T21:59:10

RAN1 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65479


Change subject: Optimize JS, move JS ResLoad module, bump to 0.3.3
......................................................................

Optimize JS, move JS ResLoad module, bump to 0.3.3

This commit introduces a major change in the structure of js/ext.CommunityTwitter.updatecount.js and
a minor change in the code for CommunityTwitter_body.php. The JS code for updating the characters
remaining counter proved to be a source of lag on mobile devices such as the fifth-generation iPod
Touch, with much greater lag time expected for devices which are less powerful. The source of this
lag was identified to be the relatively-expensive recursion of document.getElementById three times
per character input, once for the textarea element to grab the number of characters used, the strong
element for the counter output, and the input element for disabling/re-enabling the "Tweet" button.
Two methods were used to optimize the JS, implemen

[MediaWiki-commits] [Gerrit] Replace old SDK with new one byMicrosoft - change (mediawiki...WindowsAzureSDK)

Aaron Schulz (Code Review — 2013-05-25T20:51:26

Aaron Schulz has submitted this change and it was merged.

Change subject: Replace old SDK with new one by Microsoft
......................................................................


Replace old SDK with new one by Microsoft

Change-Id: I2dbce6b8fa74f6d2715424dbce90e2dd3637fc4a
---
A README
D README.txt
M WindowsAzureSDK.i18n.php
M WindowsAzureSDK.php
A composer.json
A composer.phar
D lib/PHPAzure/library/Microsoft/AutoLoader.php
D lib/PHPAzure/library/Microsoft/Exception.php
D lib/PHPAzure/library/Microsoft/Http/Client.php
D lib/PHPAzure/library/Microsoft/Http/Client/Adapter/Curl.php
D lib/PHPAzure/library/Microsoft/Http/Client/Adapter/Exception.php
D lib/PHPAzure/library/Microsoft/Http/Client/Adapter/Interface.php
D lib/PHPAzure/library/Microsoft/Http/Client/Adapter/Proxy.php
D lib/PHPAzure/library/Microsoft/Http/Client/Adapter/Socket.php
D lib/PHPAzure/library/Microsoft/Http/Client/Adapter/Stream.php
D lib/PHPAzure/library/Microsoft/Http/Client/Exception.php
D lib/PHPAzure/library/Microsoft/Http/Co

[MediaWiki-commits] [Gerrit] Re-grouping and ordering the editingpreferences - change (mediawiki/core)

TMg (Code Review — 2013-05-25T20:45:34

TMg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65478


Change subject: Re-grouping and ordering the editing preferences
......................................................................

Re-grouping and ordering the editing preferences

Arange the settings in three groups: How to call the editor, how
the editor looks and how the preview works. The only toolbar
preference is at the bottom because the WikiEditor extension adds
its stuff there. All the preferences are untouched. This does not
add or remove a preference.

Change-Id: I429c8125b8db789d2756d61249f6cf1fa7f2f51c
---
M includes/Preferences.php
M languages/messages/MessagesDe.php
M languages/messages/MessagesEn.php
3 files changed, 55 insertions(+), 59 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/78/65478/1

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 848cd32..8f784bb 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
< at >< at > -732,45 +732

[MediaWiki-commits] [Gerrit] Support using alternative tables in$wgSharedTables - change (mediawiki/core)

Liangent (Code Review — 2013-05-25T18:20:15

Liangent has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65477


Change subject: Support using alternative tables in $wgSharedTables
......................................................................

Support using alternative tables in $wgSharedTables

$wgSharedTables can now be an associative array. If a shared table entry
is 'alt_table' => 'table' and when `table` is being accessed, it's mapped
to `alt_table` transparently on $wgSharedDB.

Change-Id: Ibcffdc743cc595eea1dbc83586d49fa749935348
---
M includes/db/Database.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/77/65477/1

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 85c459e..a4e4d77 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
< at >< at > -2069,9 +2069,12 < at >< at >
 list( $table ) = $dbDetails;
 if ( $wgSharedDB !== null # We have a shared database
 && !$this->isQuotedIdentifier( $table ) # Paranoia chec

[MediaWiki-commits] [Gerrit] Punctuation and consistency forlog-description-thanks - change (mediawiki...Thanks)

jenkins-bot (Code Review — 2013-05-25T17:47:00

jenkins-bot has submitted this change and it was merged.

Change subject: Punctuation and consistency for log-description-thanks
......................................................................


Punctuation and consistency for log-description-thanks

Added period and made consistent with core log descriptions.
<https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Log-description-thanks/en>

Change-Id: I7aaeecad6b662428bff9a2f4918a1943033f45d0
---
M Thanks.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kaldari: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Thanks.i18n.php b/Thanks.i18n.php
index 9cbe58f..dcc70c0 100644
--- a/Thanks.i18n.php
+++ b/Thanks.i18n.php
< at >< at > -33,7 +33,7 < at >< at >
 $4',
 'notification-thanks-email-batch-body' => '$1 {{GENDER:$1|thanked}} you for your edit on $2.',
 'log-name-thanks' => 'Thanks log',
-'log-description-thanks' => 'These events track when users thank other users',
+'log-description-thanks' => 'Below is a list of users

[MediaWiki-commits] [Gerrit] Add coroutine-based,URI-configured generic event processor - change(mediawiki...EventLogging)

jenkins-bot (Code Review — 2013-05-25T17:21:13

jenkins-bot has submitted this change and it was merged.

Change subject: Add coroutine-based, URI-configured generic event processor
......................................................................


Add coroutine-based, URI-configured generic event processor

Rather than have several scripts (each with different command-line argument
semantics) that each do the same basic thing -- consume an event stream into
some data store -- it is better to have a script that takes an input source and
an output source and correctly delegates to the right handler for each.

Making handler registration dynamic (using the < at >writes and < at >reads decorators)
makes it possible to have a plug-in architecture for event writers. A future
change-set will load Python files from some designated path, allowing people to
simply write a coroutine to write out to some data store and register it with
EventLogging, which will have the effect of making it available to the main
'eventlogger' script.

'eventlogger' deprecates json2mongo,

[MediaWiki-commits] [Gerrit] Removed uiprop=preferencestoken frommeta=userinfo - change (mediawiki/core)

Umherirrender (Code Review — 2013-05-25T16:34:14

Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65476


Change subject: Removed uiprop=preferencestoken from meta=userinfo
......................................................................

Removed uiprop=preferencestoken from meta=userinfo

To change options with the new action=options, you have to use
action=tokens&type=options

Was added with r41257 for future use

Change-Id: I3797c61a7c5921e74866fa24a663c5dd1690e306
---
M RELEASE-NOTES-1.22
M includes/api/ApiQueryUserInfo.php
2 files changed, 1 insertion(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/76/65476/1

diff --git a/RELEASE-NOTES-1.22 b/RELEASE-NOTES-1.22
index 361ab25..1a288a4 100644
--- a/RELEASE-NOTES-1.22
+++ b/RELEASE-NOTES-1.22
< at >< at > -132,6 +132,7 < at >< at >
 * prop=info now adds the content model and page language of the title.
 * New upload log entries will now contain information on the relavent
   image (sha1 and timestamp).
+* Removed uiprop=preferencestoke

[MediaWiki-commits] [Gerrit] Rename 'langlinks' to 'languages' -change (mediawiki...VisualEditor)

Esanders (Code Review — 2013-05-25T16:11:14

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65475


Change subject: Rename 'langlinks' to 'languages'
......................................................................

Rename 'langlinks' to 'languages'

For internal naming consistency (e.g. with MWLanguageMetaItem).

Change-Id: Ifb53fa10da52e1ea87389b024b7c581b8dd730e6
---
M VisualEditor.i18n.php
M VisualEditor.php
M modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
3 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/75/65475/1

diff --git a/VisualEditor.i18n.php b/VisualEditor.i18n.php
index d18f410..8889c04 100644
--- a/VisualEditor.i18n.php
+++ b/VisualEditor.i18n.php
< at >< at > -88,7 +88,7 < at >< at >
 'visualeditor-dialog-meta-categories-input-matchingcategorieslabel' => 'Matching categories',
 'visualeditor-dialog-meta-categories-sortkey-label' => 'Page name in category',
 'visualeditor-dialog-meta-categories-defaultsort-label' => 'Default p

[MediaWiki-commits] [Gerrit] Stop uploading if maxLimit reached -change (mediawiki...UploadWizard)

Nischayn22 (Code Review — 2013-05-25T16:06:46

Nischayn22 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65474


Change subject: Stop uploading if maxLimit reached
......................................................................

Stop uploading if maxLimit reached

Bug: 40158
Change-Id: If0a0362f988d1b9a235c36120d4e07b05755ca77
---
M UploadWizard.i18n.php
M resources/mw.UploadWizardUpload.js
M resources/mw.UploadWizardUploadInterface.js
3 files changed, 17 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/74/65474/1

diff --git a/UploadWizard.i18n.php b/UploadWizard.i18n.php
index f420c46..ffc6d8f 100644
--- a/UploadWizard.i18n.php
+++ b/UploadWizard.i18n.php
< at >< at > -241,7 +241,7 < at >< at >
 'mwe-upwiz-error-license-wikitext-invalid' => 'This does not seem to be valid wikitext, or does not contain a license.',
 'mwe-upwiz-details-error-count' => 'There {{PLURAL:$1|is one error|are $1 errors}} with the {{PLURAL:$2|form|forms}} above. Correct the {{PLURAL:$1|erro

[MediaWiki-commits] [Gerrit] batch script for stresstest of thedatabase - change (mediawiki...MathSearch)

Physikerwelt (Code Review — 2013-05-25T15:58:00

Physikerwelt has submitted this change and it was merged.

Change subject: batch script for stresstest of the database
......................................................................


batch script for stresstest of the database

Change-Id: I3e81e0f607f47fa41863cbd090aa8e1c488aa0b5
---
A batch.sh
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Physikerwelt: Verified; Looks good to me, approved



diff --git a/batch.sh b/batch.sh
new file mode 100644
index 0000000..13d0b10
--- /dev/null
+++ b/batch.sh
< at >< at > -0,0 +1,9 < at >< at >
+#!/bin/sh
+i=0
+while [ $i -le 28 ]
+do
+  j=`expr $i + 1`
+  echo $i
+  php ReRenderMath.php  ${i}000 ${j}000 -f --conf /home/wiki/LocalSettings.php>$i&
+  i=$j
+done
\ No newline at end of file

[MediaWiki-commits] [Gerrit] batch script for stresstest of thedatabase - change (mediawiki...MathSearch)

Physikerwelt (Code Review — 2013-05-25T15:57:07

Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65473


Change subject: batch script for stresstest of the database
......................................................................

batch script for stresstest of the database

Change-Id: I3e81e0f607f47fa41863cbd090aa8e1c488aa0b5
---
A batch.sh
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch refs/changes/73/65473/1

diff --git a/batch.sh b/batch.sh
new file mode 100644
index 0000000..13d0b10
--- /dev/null
+++ b/batch.sh
< at >< at > -0,0 +1,9 < at >< at >
+#!/bin/sh
+i=0
+while [ $i -le 28 ]
+do
+  j=`expr $i + 1`
+  echo $i
+  php ReRenderMath.php  ${i}000 ${j}000 -f --conf /home/wiki/LocalSettings.php>$i&
+  i=$j
+done
\ No newline at end of file

[MediaWiki-commits] [Gerrit] Newlines should be converted to spacesfor IRC feed - change (mediawiki/core)

Alex Monk (Code Review — 2013-05-25T15:50:28

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65472


Change subject: Newlines should be converted to spaces for IRC feed
......................................................................

Newlines should be converted to spaces for IRC feed

Instead of just removing them, which was causing reasons to show up like this:
"Automatically blocked by abuse filter.Description of matched rule: Long-term Chinese spambots"
While showing like this on the web pages:
"Automatically blocked by abuse filter. Description of matched rule: Long-term Chinese spambots"

Change-Id: I058e4b446aaa42b4dfe3369f101191f36b6f6978
---
M includes/RecentChange.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/72/65472/1

diff --git a/includes/RecentChange.php b/includes/RecentChange.php
index b5d4a1c..169b034 100644
--- a/includes/RecentChange.php
+++ b/includes/RecentChange.php
< at >< at > -328,7 +328,7 < at >< at >
  * < at >return String
  */

[MediaWiki-commits] [Gerrit] Convert from DOS line endings (CRLF)to Unix ones (LF) - change (mediawiki...VisualEditor)

Catrope (Code Review — 2013-05-25T15:27:49

Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65471


Change subject: Convert from DOS line endings (CRLF) to Unix ones (LF)
......................................................................

Convert from DOS line endings (CRLF) to Unix ones (LF)

Change-Id: I66c2d6662c7512d5c55daf7a8a1876f00f8a7705
---
M modules/jquery/jquery.js
M modules/rangy/rangy-core-1.3.js
M modules/rangy/rangy-core.js
M modules/ve/ui/styles/images/callout.svg
M modules/ve/ui/styles/images/icons/accept.svg
M modules/ve/ui/styles/images/icons/add-item.svg
M modules/ve/ui/styles/images/icons/alert.svg
M modules/ve/ui/styles/images/icons/arched-arrow-ltr.svg
M modules/ve/ui/styles/images/icons/arched-arrow-rtl.svg
M modules/ve/ui/styles/images/icons/bold-a.svg
M modules/ve/ui/styles/images/icons/bold-b.svg
M modules/ve/ui/styles/images/icons/bold-f.svg
M modules/ve/ui/styles/images/icons/bullet-list-ltr.svg
M modules/ve/ui/styles/images/icons/bullet-list-rtl.svg
M modules/ve/ui/styles/images/icons/c

[MediaWiki-commits] [Gerrit] test commit,do not merge. - change (operations/puppet)

Ottomata (Code Review — 2013-05-25T15:17:58

Ottomata has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65470


Change subject: test commit, do not merge.
......................................................................

test commit, do not merge.

Change-Id: I46e0f345eca2de4446c7baea7b4250c2446d3108
---
M typos
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/70/65470/1

diff --git a/typos b/typos
index e866550..1656ab4 100644
--- a/typos
+++ b/typos
< at >< at > -1,3 +1,4 < at >< at >
 pmpta
 gadolinum
 wikmedia
+

[MediaWiki-commits] [Gerrit] Ensure carrier redirect hyperlink for'Yes' action uses same... - change(mediawiki...ZeroRatedMobileAccess)

Dr0ptp4kt (Code Review — 2013-05-25T15:14:02

Dr0ptp4kt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65469


Change subject: Ensure carrier redirect hyperlink for 'Yes' action uses same 'zero' or 'm' subdomain.
......................................................................

Ensure carrier redirect hyperlink for 'Yes' action uses same 'zero' or 'm' subdomain.

Change-Id: Ifc7003ae00425310bd216f634d0951adc08ac2c8
---
M includes/PageRenderingHooks.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess refs/changes/69/65469/1

diff --git a/includes/PageRenderingHooks.php b/includes/PageRenderingHooks.php
index 299460e..896ce36 100644
--- a/includes/PageRenderingHooks.php
+++ b/includes/PageRenderingHooks.php
< at >< at > -22,6 +22,9 < at >< at >
 class PageRenderingHooks {
 private static $formatMobileUrl = '//%s.m.wikipedia.org/wiki/Main_Page';
 private static $formatZeroUrl = '//%s.zero.wikipedia.org/wiki/Main_Page';
+private static $originParent = '.wi

[MediaWiki-commits] [Gerrit] Renaming the "Beta" label to "Editor"- change (mediawiki...WikiEditor)

TMg (Code Review — 2013-05-25T15:09:19

TMg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65468


Change subject: Renaming the "Beta" label to "Editor"
......................................................................

Renaming the "Beta" label to "Editor"

The WikiEditor is the default since a long time now. It does not
make much sense to still call it "Beta". This depends on my other
change to the core preferences because of the new word that needs
to be translated.

Change-Id: Id8b9a47a9d83dc1acdec46cb6e993deac33cc066
---
M WikiEditor.hooks.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor refs/changes/68/65468/1

diff --git a/WikiEditor.hooks.php b/WikiEditor.hooks.php
index 57b8ff3..89f27f4 100644
--- a/WikiEditor.hooks.php
+++ b/WikiEditor.hooks.php
< at >< at > -12,7 +12,7 < at >< at >
 
 protected static $features = array(
 
-/* Beta Features */
+/* Toolbar Features */
 
 'toolbar' => array(
 'preferences' => array(
< at >< at > -20,7 +20,7 < at >< at >
 '

[MediaWiki-commits] [Gerrit] Fix getAnnotationIndexesFromOffset()to always return an array - change (mediawiki...VisualEditor)

jenkins-bot (Code Review — 2013-05-25T15:08:43

jenkins-bot has submitted this change and it was merged.

Change subject: Fix getAnnotationIndexesFromOffset() to always return an array
......................................................................


Fix getAnnotationIndexesFromOffset() to always return an array

It used to, but a recent change broke it

Change-Id: I03ecfd5a515855a286136b57217779fd1c5912a5
---
M modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js b/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
index f02dd99..b608208 100644
--- a/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
+++ b/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
< at >< at > -323,7 +323,7 < at >< at >
 if ( typeof element === 'string' ) {
 return [];
 } else {
-return element.annotations || element[1];
+return element.annotations || element[1] || [];
 }
 };

[MediaWiki-commits] [Gerrit] Remove trailing whitespace everywhere- change (mediawiki...VisualEditor)

jenkins-bot (Code Review — 2013-05-25T15:05:35

jenkins-bot has submitted this change and it was merged.

Change subject: Remove trailing whitespace everywhere
......................................................................


Remove trailing whitespace everywhere

Change-Id: I14f812bd31bd33d9fbd1148a474cbe7a3375d954
---
M ApiVisualEditor.php
M README.txt
M modules/rangy/rangy-core.js
M modules/ve/ui/styles/images/icons/accept.svg
M modules/ve/ui/styles/images/icons/check.svg
M modules/ve/ui/styles/images/icons/close.svg
M modules/ve/ui/styles/images/icons/collapse.svg
M modules/ve/ui/styles/images/icons/expand.svg
M modules/ve/ui/styles/images/icons/external-link.svg
M modules/ve/ui/styles/images/icons/italic-i.svg
M modules/ve/ui/styles/images/icons/move-ltr.svg
M modules/ve/ui/styles/images/icons/move-rtl.svg
M modules/ve/ui/styles/images/icons/number-list-ltr.svg
M modules/ve/ui/styles/images/icons/number-list-rtl.svg
M modules/ve/ui/styles/images/icons/picture.svg
M modules/ve/ui/styles/ve.ui.Widget.css
16 files changed, 1,229 insertions(+), 1,

[MediaWiki-commits] [Gerrit] standalone phpunit for Ask and Diff -change (integration/jenkins-job-builder-config)

Hashar (Code Review — 2013-05-25T15:05:06

Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65467


Change subject: standalone phpunit for Ask and Diff
......................................................................

standalone phpunit for Ask and Diff

Change-Id: I55f98b84266ea32f32c27ba487c1398a6dce8fc7
---
M macro.yaml
M mediawiki-extensions.yaml
2 files changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config refs/changes/67/65467/1

diff --git a/macro.yaml b/macro.yaml
index fcb7e74..4c04f25 100644
--- a/macro.yaml
+++ b/macro.yaml
< at >< at > -232,6 +232,11 < at >< at >
      - mw-run-update-script
 
 - builder:
+    name: phpunit
+    builders:
+     - shell: 'phpunit --log-junit junit-phpunit.xml'
+
+- builder:
     name: mw-phpunit
     builders:
       - shell: 'php tests/phpunit/phpunit.php --log-junit junit-phpunit.xml'
diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index a1ff0da..c909348 100644
--- a/mediawiki-extensions.yaml
+++ b

[MediaWiki-commits] [Gerrit] Tidy and miscellaneous bugfix - change(mediawiki...TranslateSvg)

Jarry1250 (Code Review — 2013-05-25T14:55:53

Jarry1250 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65466


Change subject: Tidy and miscellaneous bugfix
......................................................................

Tidy and miscellaneous bugfix

Change-Id: I262c6e1d05383657fec34de61cfa85288ed21449
---
M SVGFormatWriter.php
M TranslateSvg.php
M TranslateSvgTasks.php
3 files changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg refs/changes/66/65466/1

diff --git a/SVGFormatWriter.php b/SVGFormatWriter.php
index ebecadd..f8d03c4 100644
--- a/SVGFormatWriter.php
+++ b/SVGFormatWriter.php
< at >< at > -168,9 +168,6 < at >< at >
 return $this->processVerificationError( $details );
 }
 
-// URL needed later for redirect to file description page
-$this->url = $uploader->getLocalFile()->getTitle()->getFullURL();
-
 // Actually perform upload
 $bot = User::newFromName( $wgTranslateSvgBotName, false );
 $status = $uploader->performUpload( $comment, false, false, $b