gmane.mail.popa3d.user

Re: popa3d-vname, allowing hierarchies for "domain:directory" in vnamemap

Andy Sy — 2010-11-09T12:15:45

Yes, sorry, typo.  This is how the new line looks:

   if ( strstr(address, '/') || strchr(user, '/')) ...

became:

   if ( strstr(address, "..") || strchr(user, '/'))

- Andy

Re: popa3d-vname, allowing hierarchies for "domain:directory" in vnamemap

Solar Designer — 2010-11-09T11:49:13

Andy,

On Tue, Nov 09, 2010 at 07:24:25PM +0800, Andy Sy wrote:

You need to keep the user check as well!

Alexander

Re: popa3d-vname, allowing hierarchies for "domain:directory" in vnamemap

Andy Sy — 2010-11-09T11:24:25

Hi Alexander,


Was able to drastically simplify the patch by just replacing

   if ( strchr(user, '/') || ...

with:

   if ( strstr(address, "..") || ...

The above seems to work fine.

- Andy

Re: popa3d-vname, allowing hierarchies for "domain:directory" in vnamemap

Solar Designer — 2010-11-09T10:35:32

Hi Andy,

On Tue, Nov 09, 2010 at 06:13:07PM +0800, Andy Sy wrote:
[...]

I didn't review it in full context, but it looks like you're lucky
as it relates to "address" since the directory pathname comes from a
trusted config file only, but not as it relates to "user".

There doesn't appear to be any reason for you to remove the check of
"user", so I suggest that you fix the (patched) code in this respect.

As to "address", I recommend that rather than completely remove the
check for slash you replace it with a check preventing traversal to
upper-level directories.

Something like:

if (strchr(user, '/') ||
    !strcmp(user, "..") ||
    strstr(address, ".."))
return NULL;

...and you don't need vname_lookup_fail.

This is completely untested, use at your own risk.

Alexander

popa3d-vname, allowing hierarchies for "domain:directory" in vnamemap

Andy Sy — 2010-11-09T10:13:07

Hi all,

I am using hhg's patch at

   http://hhg.to/popa3d/popa3d-0.6.3-vname-2.diff

but it doesn't seem to support directory hierarchies for
directory values in vnamemap. e.g.

   "mydomain.com:mydomain"

works, but

   "mydomain.com:anotherdir/mydomain"

won't.

I wrote the attached patch to allow the above to happen,
but is this safe?

Note that the patch can be applied to unpatched 1.0.2
and result in compilable virtual.c, but only makes
sense when popa3d-0.6.3-vname-2.diff is also applied.

- Andy


============================
http://webmechs.com/webpress
The Webmechs Webpress Blog
--- virtual.c.orig2010-11-09 10:06:10.829767335 +0000
+++ virtual.c2010-11-09 10:06:15.847769298 +0000
< at >< at > -127,6 +127,7 < at >< at > struct passwd *virtual_userpass(char *us
 char *address, *pathname;
 char *template, *passwd;
 int fail;
+    int vname_lookup_fail=1;
 int fd, size;
 
 *known = 0;
< at >< at > -137,7 +138,9 < at >< at > struct passwd *virtual_userpass(char *us
 virtual_spool = NULL;
 
 #if VIRTUAL_VNAME
-if (!(address = vname_l

Re: popa3d in Minix3

Solar Designer — 2010-08-24T12:50:00

It is unreasonable for me to spend time on this, sorry.

I've placed your patch into contrib/ and listed it on the popa3d homepage:

http://www.openwall.com/popa3d/

"popa3d 1.0.2 MINIX 3 support by Pavel V Samsonov
ditto, context format diff to be applied on MINIX natively"

Thanks,

Alexander

Re: popa3d in Minix3

Pavel V Samsonov — 2010-08-24T11:04:38

В Tue, 24 Aug 2010 02:03:40 +0400
Solar Designer <solar-cxoSlKxDwOJWk0Htik3J/w< at >public.gmane.org> пишет:


I not currently very sure, but in my installation of Minix3, the child
process die when parent exit. In Linux with same code, it still running
without parent. May be I wrong. Please verify if possible.

Thanks.

Re: popa3d in Minix3

Solar Designer — 2010-08-23T22:03:40

Hi Pavel,

On Thu, Aug 19, 2010 at 03:34:01PM +0400, Pavel V Samsonov wrote:

Please regenerate the patch to meet these conventions:

http://openwall.info/wiki/how-to-make-patches

I'd like to add it to the contrib/ directory.  As to applying it to the
main popa3d tree, I'd rather not, at least not without some cleanup.

Why are you removing the fork-into-background code for "popa3d -D" (when
building on Minix)?

Thanks,

Alexander

popa3d in Minix3

Pavel V Samsonov — 2010-08-19T11:34:01

Good day!
I have patch for run popa3d-1.0.2 on Minix3.
I test basic functionality of popa3d in Minix3 and want add this patch
in mainstream. How I can make this?
Thanks.

Re: popa3d log facility

Michael Meyer — 2009-12-13T10:54:05

Wow...this list is still alive... ;)

*** Wijatmoko U. Prayitno <koko-RmlLcU31VplnUnNnYzyGRNBPR1lH4CV8< at >public.gmane.org> wrote:

Have a look at "params.h".

,---[ params.h ]
| #define SYSLOG_FACILITY                 LOG_DAEMON
`---|

Change "LOG_DAEMON" to "LOG_MAIL" and rebuild.

HTH

Micha

popa3d log facility

Wijatmoko U. Prayitno — 2009-12-12T16:21:22

Helo lists,

Is there any possiblity to change popa3d log from /var/log/messages to
/var/log/mail* ?  Which files (*.c, *.h) I should modify??