gmane.lisp.who.general

Re: Bug report: ESC applied to attribute values produces spurious output

Sebastian Tennant — 2013-04-30T20:55:53

Quoth Ron Garret <ron< at >flownet.com>:

You have a choice.  You can either stick with single quotes around foo and
change *attribute-quote-char* to double quotes, or leave *attribute-quote-char*
as it is and use double quotes around foo.

Re: Bug report: ESC applied to attribute values produces spurious output

2013-04-30T19:51:43

How about this:

(setq cl-who:*attribute-quote-char* #\")

(cl-who:with-html-output-to-string (s) ((:input :type :button :onclick "alert('foo')")))
"<input type=\"BUTTON\" onclick=\"alert('foo')\" />"

PT

Re: Bug report: ESC applied to attribute values produces spurious output

Ron Garret — 2013-04-30T19:46:46

On Apr 30, 2013, at 12:33 PM, Jens Teich wrote:


Ooh!  So close!  Turns out this exposes a bug in parenscript:

? (setq ps:*js-string-delimiter* #\" )
#\"
? (princ (ps:ps (alert "'\"")))
alert("\'"");
"alert(\"\\'\"\");"

But I guess this is close enough for my current needs.  Thanks!

rg

Re: Bug report: ESC applied to attribute values produces spurious output

Jens Teich — 2013-04-30T19:33:50

Am 30.04.2013 21:19, schrieb Ron Garret:
(setq ps:*js-string-delimiter* #\" )

Re: Bug report: ESC applied to attribute values produces spurious output

Ron Garret — 2013-04-30T19:19:25

On Apr 30, 2013, at 12:13 PM, Jens Teich wrote:


No, that won't help.  PS just produces the same troublesome string:

? (parenscript::ps (alert "foo"))
"alert('foo');"
? (with-html-output-to-string (s) ((:input :type :button :onclick (parenscript::ps (alert "foo")))))
"<input type='BUTTON' onclick='alert('foo');' />"

Re: Bug report: ESC applied to attribute values produces spurious output

Jens Teich — 2013-04-30T19:13:28

Am 30.04.13 21:02, schrieb Ron Garret:

You need parenscript

:onclick (ps (alert ...))

~jens

Re: Bug report: ESC applied to attribute values produces spurious output

Ron Garret — 2013-04-30T19:02:36

On Apr 30, 2013, at 11:47 AM, Stas Boukarev wrote:



Well, they need something if you want to embed a single-quoted string inside them:

? (with-html-output-to-string (s) ((:input :type :button :onclick "alert('foo')")))
"<input type='BUTTON' onclick='alert('foo')' />"

rg

Re: Bug report: ESC applied to attribute values produces spurious output

Stas Boukarev — 2013-04-30T18:47:53

That's not a bug, the attributes don't need STR or ESC.
(with-html-output-to-string (s) ((:a :href (escape-string "XXX")) (esc "YYY")))

Bug report: ESC applied to attribute values produces spurious output

Ron Garret — 2013-04-30T18:39:43

? (with-html-output-to-string (s) ((:a :href (esc "XXX")) (esc "YYY")))
"<aXXX href='XXX'>YYY</a>"

My actual use case is:

(:a :onclick (esc "f('str')"))

This is CL-WHO 1.1.1 acquired through quicklisp.

rg

undefined variable: CL-WHO::ATTR problem again

Jeff Cunningham — 2013-03-01T17:18:14

I just upgraded everything through quicklisp and rebuilt a project I'm 
working on and an error came back that I've run into before. There is a 
missing comma in cl-who.lisp that I manually fixed the last two times 
I've upgraded quicklisp dists.

Trying to google on the error doesn't get you anywhere, although someone 
posted to the mail list about it once before. I don't think they 
captured the error message in their post. So here it is for anyone 
running into this problem.

; --> CL-WHO:FMT
; ==>
;   (FORMAT *STANDARD-OUTPUT* " ~A" CL-WHO::ATTR)
;
; caught WARNING:
;   undefined variable: CL-WHO::ATTR
;
; compilation unit finished
;   Undefined variable:
;     CL-WHO::ATTR
;   caught 1 WARNING condition


Here's the fix: (add the comma)

  $ diff who.lisp who.lisp~
120c120
<                                      `(fmt " ~A" ,attr))
---
 >                                      `(fmt " ~A" attr))


I'm going see if I can submit a bug fix on this.

Cheers,
--Jeff

Re: undefined variable: CL-WHO::ATTR problem again

Jeff Cunningham — 2013-03-01T17:37:26

I just submitted a pull request to fix this. Hopefully this will be the 
end of it.
--Jeff


On 03/01/2013 09:18 AM, Jeff Cunningham wrote:

Missing comma in who.lisp

2012-10-10T10:20:55

--- who.lisp~2012-10-05 17:16:12.007971946 +0200
+++ who.lisp2012-10-09 21:08:39.026986297 +0200
< at >< at > -117,7 +117,7 < at >< at >
                                 ((eq ,=var= t)
                                  ,(case *html-mode*
                                     (:sgml
-                                     `(fmt " ~A" attr))
+                                     `(fmt " ~A" ,attr))
                                     ;; otherwise default to :xml mode
                                     (t
                                      `(fmt " ~A=~C~A~C"

Re: The problem with "esc"

Stas Boukarev — 2012-08-01T03:16:34

esc is a shortcut for (princ (escape-string ...))

Re: The problem with "esc"

Kenneth Yan — 2012-08-01T00:56:40

Of course, escape-string always works. But this is not my point. Since
"esc" is the shortcut of "escape-string", hope "esc" will be better.

Best,
Kenneth


On Tue, Jul 31, 2012 at 10:05 AM, Stas Boukarev <stassats< at >gmail.com> wrote:

Re: The problem with "esc"

Stas Boukarev — 2012-07-31T02:05:33

Try escape-string instead.

The problem with "esc"

Kenneth Yan — 2012-07-31T01:49:59

Dear all,

Please pay attention to the issue below.

(with-html-output-to-string (*standard-output* nil :prologue nil)
  (:input :type "text" :name (escape-string "你好") :readonly "readonly"
          :value (esc "你好")))

"<input type=\"text\" name=\"&#20320;&#22909;\"
readonly=\"readonly\"&#20320;&#22909; value=\"&#20320;&#22909;\">"


Best,
Kenneth

using cl-who to expand dynamically created s-html?

Jim Prewett — 2012-05-24T17:41:33

Hi All,

I've been (happily) using cl-who for quite a while, but now I'm stuck!  
I'd like to use cl-who to expand s-expressions (which are generated on 
the fly) into HTML.

So, instead of doing what I normally do like this:

(cl-who:with-html-output (*standard-output*)
  (cl-who:htm 
    (:pre "this is some preformatted text")))

I'd like to do something like this (where the s-exprs are generated by 
calling a function):
(cl-who:with-html-output (*standard-output*)
  (cl-who:htm 
    (funcall #'(lambda () '(:pre "this is some preformatted text")))))

Of course, this doesn't work as with-html-output is a macro.

I feel like I'm missing something horribly obvious! :)

Thanks for any help you can provide,
Jim

James E. Prewett                    Jim< at >Prewett.org download< at >hpc.unm.edu 
Systems Team Leader           LoGS: http://www.hpc.unm.edu/~download/LoGS/ 
Designated Security Officer         OpenPGP key: pub 1024D/31816D93    
HPC Systems Engineer III   UNM HPC  505.277.8210

Re: declarations placement issue

Ala'a Mohammad — 2012-05-05T10:42:20

Thanks for taking the time to reply.

I've already forked the github version and got the patch approved by Hans.

Best wishes,

Ala'a.

On Sat, May 5, 2012 at 1:26 AM, Edi Weitz <edi< at >agharta.de> wrote:

Re: declarations placement issue

Edi Weitz — 2012-05-04T21:26:01

Sorry for the late reply... :(

Yeah, look like you're right.  I think the documentation is to blame
in that it talks about declarations although I think CL-WHO never took
care of them.  I'd suggest to just remove this from the docs unless
you have a patch.  (I myself am too busy with other things to work on
the code.)

Thanks,
Edi.


On Thu, Apr 19, 2012 at 10:42 PM, Ala'a Mohammad <amalawi< at >gmail.com> wrote:

declarations placement issue

Ala'a Mohammad — 2012-04-19T20:42:37

Hi,

Please, correct me If I'm wrong.

in the expansion of the following (using cl-who from quicklisp)

(with-html-output (var)
  (declare (special var)))
;=>
(LET ((VAR VAR))
   (PROGN
      (DECLARE (SPECIAL VAR))))

I think that the declaration is placed in the wrong place. CLHS does
not specify any declarations for PROGN entry. and in this declaration
provides information about the bindings of LET, thus I thought the
correct expansion should be:

(with-html-output (var)
  (declare (special var)))
;=>
(LET ((VAR VAR))
   (DECLARE (SPECIAL VAR))
   (PROGN))

the fix should should only affect with-html-output (since
with-html-output-to-string passes the declarations to the former
macro)

Regards,

Ala'a

Re: onclick

Andy Peterson — 2012-04-12T15:55:13

From the parenscript manual:
(PS-INLINE form &optional *JS-STRING-DELIMITER*)
(PS-INLINE* form &optional *JS-STRING-DELIMITER*)
PS-INLINE and PS-INLINE* take a single Parenscript form and output a
string starting with javascript: that can be used in HTML node
attributes. As well, they provide an argument to bind the value of
*JS-STRING-DELIMITER* to control the value of the JavaScript string
escape character to be compatible with whatever the HTML generation
mechanism is used (for example, if HTML strings are delimited using
#\', using #\" will avoid conflicts without requiring the output
JavaScript code to be escaped). By default the value is taken from
*JS-INLINE-STRING-DELIMITER*.

comment: the default value for  *JS-INLINE-STRING-DELIMITER* is #\"