gmane.linux.serial

Re: [PATCH 22/27] serial: Make uart_port's ioport "unsigned long".

David Miller — 2008-10-10T16:19:25

From: Josh Boyer gmail.com> Date: Fri, 10 Oct 2008 08:54:34 -0400 That seems like a fine idea to me, please post a follow-on patch if you like :-) -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 22/27] serial: Make uart_port's ioport "unsigned long".

Josh Boyer — 2008-10-10T12:54:34

I emailed on an earlier posting of this about using resource_size_t instead as we have 32-bit CPUs with 64-bit address spaces. If I'm totally wrong, that's fine but I'm still wondering if that would be a better general solution. josh -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] max3100 driver

Christian Pellegrin — 2008-10-10T12:08:58

Hi, This patch fixes a problem about PM in my code that I found when testing patches that went in -mm. The full patch against the Linus tree can be found at http://www.evolware.org/chri/paciugo/ --- diff --git a/drivers/serial/max3100.c b/drivers/serial/max3100.c index 7a269a6..462d6a4 100644 --- a/drivers/serial/max3100.c +++ b/drivers/serial/max3100.c < at >< at > -566,6 +566,7 < at >< at > static void max3100_shutdown(struct uart_port *port) if (s->workqueue) { flush_workqueue(s->workqueue); destroy_workqueue(s->workqueue); +s->workqueue = NULL; } if (s->irq) free_irq(s->irq, s); < at >< at > -614,6 +615,7 < at >< at > static int max3100_startup(struct uart_port *port) dev_warn(&s->spi->dev, "cannot allocate irq %d\n", s->irq); s->irq = 0; destroy_workqueue(s->workqueue); +s->workqueue = NULL; return -EBUSY; } < at >< at > -884,7 +886,8 < at >< at > static int max3100_resume(struct spi_device *spi) enable_irq(s->irq); s->conf_commit = 1; -max3100_dowork(s); +if (s->workqueue) +max3100_dowork(s); return 0; } -- T

[PATCH 27/27] serial_8250: pci_enable_device fail is not fully handled

Alan Cox — 2008-10-10T10:52:00

talking about leaks - I noticed that the 'check return of pci_enable_dev()' in the 8250 pci resume function finally made it in, inspite my objections against it (causing stuff in higher levels to leak). Signed-off-by: Alan Cox redhat.com> --- drivers/serial/8250_pci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c index c2f2393..c014ffb 100644 --- a/drivers/serial/8250_pci.c +++ b/drivers/serial/8250_pci.c < at >< at > -2041,9 +2041,9 < at >< at > static int pciserial_resume_one(struct pci_dev *dev) * The device may have been disabled. Re-enable it. */ err = pci_enable_device(dev); +/* FIXME: We cannot simply error out here */ if (err) -return err; - +printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n"); pciserial_resume_ports(priv); } return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org Mo

[PATCH 24/27] serial-make-uart_ports-ioport-unsigned-long-fix

Alan Cox — 2008-10-10T10:51:13

From: Andrew Morton linux-foundation.org> Signed-off-by: Andrew Morton linux-foundation.org> Signed-off-by: Alan Cox redhat.com> --- drivers/serial/serial_core.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c index f977c98..308588e 100644 --- a/drivers/serial/serial_core.c +++ b/drivers/serial/serial_core.c < at >< at > -2154,12 +2154,11 < at >< at > uart_report_port(struct uart_driver *drv, struct uart_port *port) switch (port->iotype) { case UPIO_PORT: -snprintf(address, sizeof(address), - "I/O 0x%x", port->iobase); +snprintf(address, sizeof(address), "I/O 0x%lx", port->iobase); break; case UPIO_HUB6: snprintf(address, sizeof(address), - "I/O 0x%x offset 0x%x", port->iobase, port->hub6); + "I/O 0x%lx offset 0x%x", port->iobase, port->hub6); break; case UPIO_MEM: case UPIO_MEM32: -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to ma

[PATCH 25/27] usb: fix pl2303 initialization

Alan Cox — 2008-10-10T10:51:21

From: Jason Wessel windriver.com> This patch removes the private check for the termios_initialized for the pl2303 usb driver. It forced the baud to 9600 on the first call to pl2303_set_termios() Based on the tty changes in the 2.6.27 kernel, the termios passed to the *_set_termios functions is always populated the first time. This means there is no need to privately initialize the settings the first time, and doing so will not allow the use of the kernel parameter "console=ttyUSB0,115200" as an example. Signed-off-by: Jason Wessel windriver.com> Signed-off-by: Alan Cox redhat.com> --- drivers/usb/serial/pl2303.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 1ede144..8d60068 100644 --- a/drivers/usb/serial/pl2303.c +++ b/drivers/usb/serial/pl2303.c < at >< at > -154,7 +154,6 < at >< at > struct pl2303_private { wait_queue_head_t delta_msr_wait; u8 line_control; u8 line_status; -u8

[PATCH 21/27] audit: Handle embedded NUL in TTY input auditing

Alan Cox — 2008-10-10T10:50:47

From: Miloslav Trmac redhat.com> Data read from a TTY can contain an embedded NUL byte (e.g. after pressing Ctrl-2, or sent to a PTY). After the previous patch, the data would be logged only up to the first NUL. This patch modifies the AUDIT_TTY record to always use the hexadecimal format, which does not terminate at the first NUL byte. The vast majority of recorded TTY input data will contain either ' ' or '\n', so the hexadecimal format would have been used anyway. Signed-off-by: Miloslav Trmac redhat.com> Signed-off-by: Alan Cox redhat.com> --- drivers/char/tty_audit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/tty_audit.c b/drivers/char/tty_audit.c index 3582f43..5787249 100644 --- a/drivers/char/tty_audit.c +++ b/drivers/char/tty_audit.c < at >< at > -93,7 +93,7 < at >< at > static void tty_audit_buf_push(struct task_struct *tsk, uid_t loginuid, get_task_comm(name, tsk); audit_log_untrustedstring(ab, name); audit_log_format(ab, " data="); -audi

[PATCH 22/27] serial: Make uart_port's ioport "unsigned long".

Alan Cox — 2008-10-10T10:50:56

From: David Miller davemloft.net> Otherwise the top 32-bits of the resource value get chopped off on 64-bit systems, and the resulting I/O accesses go to random places. Thanks to testing and debugging by Josip Rodin, which helped track this down. Signed-off-by: David S. Miller davemloft.net> Signed-off-by: Alan Cox redhat.com> --- include/linux/serial_core.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h index 3b2f6c0..e27f216 100644 --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h < at >< at > -241,7 +241,7 < at >< at > typedef unsigned int __bitwise__ upf_t; struct uart_port { spinlock_tlock;/* port lock */ -unsigned intiobase;/* in/out[bwl] */ +unsigned longiobase;/* in/out[bwl] */ unsigned char __iomem*membase;/* read/write[bwl] */ unsigned intirq;/* irq number */ unsigned intuartclk;/* base uart clock */ -- To unsubscribe from this list: send the line "uns

[PATCH 26/27] ftdi: A few errors are err() that should be debug whichcauses much spewage

Alan Cox — 2008-10-10T10:51:30

Fixes #10783 Signed-off-by: Alan Cox redhat.com> --- drivers/usb/serial/ftdi_sio.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 3dc93b5..1ac7e80 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c < at >< at > -860,7 +860,7 < at >< at > static int update_mctrl(struct usb_serial_port *port, unsigned int set, kfree(buf); if (rv < 0) { -err("%s Error from MODEM_CTRL urb: DTR %s, RTS %s", +dbg("%s Error from MODEM_CTRL urb: DTR %s, RTS %s", __func__, (set & TIOCM_DTR) ? "HIGH" : (clear & TIOCM_DTR) ? "LOW" : "unchanged", < at >< at > -2256,7 +2256,7 < at >< at > static int ftdi_tiocmget(struct tty_struct *tty, struct file *file) 0, 0, buf, 1, WDR_TIMEOUT); if (ret < 0) { -err("%s Could not get modem status of device - err: %d", __func__, +dbg("%s Could not get modem status of device - err: %d", __func__, ret); return ret; } < at >< at > -2275,7 +2275,7 < at >< at > static in

[PATCH 23/27] nozomi: Fix close on error

Alan Cox — 2008-10-10T10:51:05

Nozomi assumes the close method isn't called if open errors. The tty layer is different to other drives in this respect however. Pointed out by Denis J Barrow. Signed-off-by: Alan Cox redhat.com> --- drivers/char/nozomi.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c index 66a0f93..9a34a19 100644 --- a/drivers/char/nozomi.c +++ b/drivers/char/nozomi.c < at >< at > -1599,7 +1599,10 < at >< at > static int ntty_open(struct tty_struct *tty, struct file *file) return 0; } -/* Called when the userspace process close the tty, /dev/noz*. */ +/* Called when the userspace process close the tty, /dev/noz*. Also + called immediately if ntty_open fails in which case tty->driver_data + will be NULL an we exit by the first return */ + static void ntty_close(struct tty_struct *tty, struct file *file) { struct nozomi *dc = get_dc_by_tty(tty); -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to m

[PATCH 19/27] ip2, init/deinit cleanup

Alan Cox — 2008-10-10T10:50:30

From: Jiri Slaby gmail.com> Cleanup of module_init/exit: - mostly whitespace - remove empty functions - replace c++ comments - remove useless prints (module loaded, unloaded) - mark the calls as __exit and __init - use break; and return; to save some indent levels after it - note resource leakage It's still mess, but now it's readable. Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Alan Cox redhat.com> --- drivers/char/ip2/i2ellis.c | 32 --- drivers/char/ip2/i2ellis.h | 2 drivers/char/ip2/ip2main.c | 415 +++++++++++++++++++++----------------------- 3 files changed, 198 insertions(+), 251 deletions(-) diff --git a/drivers/char/ip2/i2ellis.c b/drivers/char/ip2/i2ellis.c index 3601017..29db44d 100644 --- a/drivers/char/ip2/i2ellis.c +++ b/drivers/char/ip2/i2ellis.c < at >< at > -69,38 +69,6 < at >< at > static DEFINE_RWLOCK(Dl_spinlock); //======================================================= //****************************************************************************** -//

[PATCH 18/27] ip2, fix sparse warnings

Alan Cox — 2008-10-10T10:50:22

From: Jiri Slaby gmail.com> Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Alan Cox redhat.com> --- drivers/char/ip2/ip2main.c | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c index 1d46284..098c9de 100644 --- a/drivers/char/ip2/ip2main.c +++ b/drivers/char/ip2/ip2main.c < at >< at > -375,9 +375,7 < at >< at > have_requested_irq( char irq ) /* handle subsequent installations of the driver. All memory allocated by the */ /* driver should be returned since it may be unloaded from memory. */ /******************************************************************************/ -#ifdef MODULE -void __exit -ip2_cleanup_module(void) +static void __exit ip2_cleanup_module(void) { int err; int i; < at >< at > -431,7 +429,8 < at >< at > ip2_cleanup_module(void) ip2config.pci_dev[i] = NULL; } #endif -if ((pB = i2BoardPtrTable[i]) != 0 ) { +pB = i2BoardPtrTable[i]; +if (pB != NULL) { kfree ( pB );

[PATCH 15/27] Char: sx, fix io unmapping

Alan Cox — 2008-10-10T10:49:54

From: Jiri Slaby gmail.com> board->base is increased for CF cards after mapping. Use board->base2 for unmapping the region, since it holds the original/correct address. Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Andrew Morton linux-foundation.org> Signed-off-by: Alan Cox redhat.com> --- drivers/char/sx.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/sx.c b/drivers/char/sx.c index c385206..5b8d7a1 100644 --- a/drivers/char/sx.c +++ b/drivers/char/sx.c < at >< at > -2504,7 +2504,7 < at >< at > static void __devexit sx_remove_card(struct sx_board *board, del_timer(&board->timer); if (pdev) { #ifdef CONFIG_PCI -pci_iounmap(pdev, board->base); +pci_iounmap(pdev, board->base2); pci_release_region(pdev, IS_CF_BOARD(board) ? 3 : 2); #endif } else { < at >< at > -2703,7 +2703,7 < at >< at > static int __devinit sx_pci_probe(struct pci_dev *pdev, return 0; err_unmap: -pci_iounmap(pdev, board->base); +pci_iounmap(pdev, board->base2); err_reg

[PATCH 12/27] Blackfin Serial Driver: Fix bug - request UART2/3peripheral mapped interrupts in PIO mode

Alan Cox — 2008-10-10T10:49:23

From: Sonic Zhang analog.com> Signed-off-by: Sonic Zhang analog.com> Signed-off-by: Bryan Wu kernel.org> Signed-off-by: Alan Cox redhat.com> --- arch/blackfin/kernel/bfin_dma_5xx.c | 13 ++++----- drivers/serial/bfin_5xx.c | 50 +++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+), 7 deletions(-) diff --git a/arch/blackfin/kernel/bfin_dma_5xx.c b/arch/blackfin/kernel/bfin_dma_5xx.c index 93229b3..339293d 100644 --- a/arch/blackfin/kernel/bfin_dma_5xx.c +++ b/arch/blackfin/kernel/bfin_dma_5xx.c < at >< at > -117,15 +117,14 < at >< at > int request_dma(unsigned int channel, char *device_id) #ifdef CONFIG_BF54x if (channel >= CH_UART2_RX && channel <= CH_UART3_TX) { -if (strncmp(device_id, "BFIN_UART", 9) == 0) { -dma_ch[channel].regs->peripheral_map &= 0x0FFF; -dma_ch[channel].regs->peripheral_map |= +unsigned int per_map; +per_map = dma_ch[channel].regs->peripheral_map & 0xFFF; +if (strncmp(device_id, "BFIN_UART", 9) == 0) +dma_ch[

[PATCH 17/27] ip2, cleanup globals

Alan Cox — 2008-10-10T10:50:10

From: Jiri Slaby gmail.com> - do not init .bss zeroed data to zero again (by memset or explicit assignment) - use char [] instead of char * for string constants Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Alan Cox redhat.com> --- drivers/char/ip2/ip2main.c | 18 +++++++----------- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c index 79bca61..1d46284 100644 --- a/drivers/char/ip2/ip2main.c +++ b/drivers/char/ip2/ip2main.c < at >< at > -150,12 +150,12 < at >< at > static int ip2_read_proc(char *, char **, off_t, int, int *, void * ); /*************/ /* String constants to identify ourselves */ -static char *pcName = "Computone IntelliPort Plus multiport driver"; -static char *pcVersion = "1.2.14"; +static const char pcName[] = "Computone IntelliPort Plus multiport driver"; +static const char pcVersion[] = "1.2.14"; /* String constants for port names */ -static char *pcDriver_name = "ip2"; -static char *

[PATCH 13/27] Fix oti6858 debug level

Alan Cox — 2008-10-10T10:49:36

From: Scott Ashcroft talk21.com> For some reason the oti6858 driver undefines and redefines the dbg macro. This makes it spew debugging messages at KERN_INFO instead of KERN_DEBUG. This patch removes the undef and define making the driver log like every other USB serial driver. Signed-off-by: Scott Ashcroft talk21.com> Signed-off-by: Alan Cox redhat.com> --- drivers/usb/serial/oti6858.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c index 81db571..42f9281 100644 --- a/drivers/usb/serial/oti6858.c +++ b/drivers/usb/serial/oti6858.c < at >< at > -224,10 +224,6 < at >< at > struct oti6858_private { struct usb_serial_port *port; /* USB port with which associated */ }; -#undef dbg -/* #define dbg(format, arg...) printk(KERN_INFO "%s: " format "\n", __FILE__, ## arg) */ -#define dbg(format, arg...) printk(KERN_INFO "" format "\n", ## arg) - static void setup_line(struct work_struct *work) { st

[PATCH 14/27] Char: cyclades. remove bogus iomap

Alan Cox — 2008-10-10T10:49:46

From: Jiri Slaby gmail.com> readl/writel are not expected to accept iomap return value. Replace bogus mapping by standard ioremap. Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Andrew Morton linux-foundation.org> Signed-off-by: Alan Cox redhat.com> --- drivers/char/cyclades.c | 21 ++++++++++++--------- 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c index fe6d774..5e5b1dc 100644 --- a/drivers/char/cyclades.c +++ b/drivers/char/cyclades.c < at >< at > -4993,12 +4993,14 < at >< at > static int __devinit cy_pci_probe(struct pci_dev *pdev, device_id == PCI_DEVICE_ID_CYCLOM_Y_Hi) { card_name = "Cyclom-Y"; -addr0 = pci_iomap(pdev, 0, CyPCI_Yctl); +addr0 = ioremap_nocache(pci_resource_start(pdev, 0), +CyPCI_Yctl); if (addr0 == NULL) { dev_err(&pdev->dev, "can't remap ctl region\n"); goto err_reg; } -addr2 = pci_iomap(pdev, 2, CyPCI_Ywin); +addr2 = ioremap_nocache(pci_resource_start(pdev, 2

[PATCH 20/27] ip2: avoid add_timer with pending timer

Alan Cox — 2008-10-10T10:50:37

From: Akinobu Mita gmail.com> add_timer() is not suppose to be called when the timer is pending. ip2 driver attempts to avoid that condition by setting and resetting a flag (TimerOn) in timer function. But there is some gap between add_timer() and setting TimerOn. This patch fix this problem by using mod_timer() and remove TimerOn which has been unnecessary by this change. Signed-off-by: Akinobu Mita gmail.com> Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Alan Cox redhat.com> --- drivers/char/ip2/ip2main.c | 19 ++++--------------- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c index 39269d1..66f52a2 100644 --- a/drivers/char/ip2/ip2main.c +++ b/drivers/char/ip2/ip2main.c < at >< at > -249,7 +249,6 < at >< at > static unsigned long bh_counter; */ #define POLL_TIMEOUT (jiffies + 1) static DEFINE_TIMER(PollTimer, ip2_poll, 0, 0); -static char TimerOn; #ifdef IP2DEBUG_TRACE /* Trace (debug

[PATCH 16/27] Char: merge ip2main and ip2base

Alan Cox — 2008-10-10T10:50:01

From: Jiri Slaby gmail.com> It's pretty useless to have one setup() function separated along with module_init() which only calls a function from ip2main anyway. Get rid of ip2base. Remove also checks of always-true now. Signed-off-by: Jiri Slaby gmail.com> Signed-off-by: Alan Cox redhat.com> --- drivers/char/ip2/Makefile | 2 - drivers/char/ip2/ip2base.c | 108 -------------------------------------------- drivers/char/ip2/ip2main.c | 92 +++++++++++++++++++++++++++++++------ 3 files changed, 77 insertions(+), 125 deletions(-) delete mode 100644 drivers/char/ip2/ip2base.c diff --git a/drivers/char/ip2/Makefile b/drivers/char/ip2/Makefile index 939618f..bc397d9 100644 --- a/drivers/char/ip2/Makefile +++ b/drivers/char/ip2/Makefile < at >< at > -4,5 +4,5 < at >< at > obj-$(CONFIG_COMPUTONE) += ip2.o -ip2-objs:= ip2base.o ip2main.o +ip2-objs:= ip2main.o diff --git a/drivers/char/ip2/ip2base.c b/drivers/char/ip2/ip2base.c deleted file mode 100644 index 8155e24..0000000 -

[PATCH 09/27] Blackfin Serial Driver: Remove useless stop

Alan Cox — 2008-10-10T10:48:57

From: Sonic Zhang analog.com> Signed-off-by: Sonic Zhang analog.com> Signed-off-by: Bryan Wu kernel.org> Signed-off-by: Alan Cox redhat.com> --- drivers/serial/bfin_5xx.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c index 382fb8d..8d2d757 100644 --- a/drivers/serial/bfin_5xx.c +++ b/drivers/serial/bfin_5xx.c < at >< at > -320,9 +320,6 < at >< at > static void bfin_serial_tx_chars(struct bfin_serial_port *uart) if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) uart_write_wakeup(&uart->port); - -if (uart_circ_empty(xmit)) -bfin_serial_stop_tx(&uart->port); } static irqreturn_t bfin_serial_rx_int(int irq, void *dev_id) -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 10/27] Blackfin Serial Driver: Fix bug - Don't call tx_stop intx_transfer.

Alan Cox — 2008-10-10T10:49:06

From: Sonic Zhang analog.com> Disable irq and return immediately. Signed-off-by: Sonic Zhang analog.com> Signed-off-by: Bryan Wu kernel.org> Signed-off-by: Alan Cox redhat.com> --- drivers/serial/bfin_5xx.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c index 8d2d757..5e20f50 100644 --- a/drivers/serial/bfin_5xx.c +++ b/drivers/serial/bfin_5xx.c < at >< at > -301,7 +301,11 < at >< at > static void bfin_serial_tx_chars(struct bfin_serial_port *uart) bfin_serial_mctrl_check(uart); if (uart_circ_empty(xmit) || uart_tx_stopped(&uart->port)) { -bfin_serial_stop_tx(&uart->port); +#ifdef CONFIG_BF54x +/* Clear TFI bit */ +UART_PUT_LSR(uart, TFI); +#endif +UART_CLEAR_IER(uart, ETBEI); return; } -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm