gmane.linux.scsi

[PATCH 3/3] [LIO-Target/ConfigFS]: Add Target Portal Group*_write_protect attributes and iSCSI LUN ACL write_protect bit

Nicholas A. Bellinger — 2008-12-04T04:35:13

From: Nicholas Bellinger linux-iscsi.org> Date: Wed, 3 Dec 2008 18:58:14 -0800 Subject: [PATCH] [LIO-Target/ConfigFS]: Add Target Portal Group *_write_protect attributes and iSCSI LUN ACL write_protect bit This patch adds demo_mode_write_protect and prod_mode_write_protect TPG attributes to /sys/kernel/config/target/iscsi/$IQN/$TPGT/attrib, here is what the current list of TPG attributes for LIO-Target v3.0 looks like with tree $CONFIGFS |-- iscsi | |-- iqn.2003-01.org.linux-iscsi.target.i686:sn.e475ed6fcdd0 | | `-- tpgt_1 | | |-- attrib | | | |-- authentication | | | |-- cache_dynamic_acls | | | |-- default_cmdsn_depth | | | |-- demo_mode_write_protect | | | |-- generate_node_acls | | | |-- login_timeout | | | |-- netif_timeout | | | `-- prod_mode_write_protect And the new write_protect bit for the iSCSI Initiator LUN ACLs: |-- iscsi |

[PATCH 2/3] [LIO-Target]: Add TPG attributesdemo_mode_write_protect and prod_mode_write_protect

Nicholas A. Bellinger — 2008-12-04T04:35:07

From: Nicholas Bellinger linux-iscsi.org> Date: Wed, 3 Dec 2008 18:56:56 -0800 Subject: [PATCH] [LIO-Target]: Add TPG attributes demo_mode_write_protect and prod_mode_write_protect Renamed the v2.9 TPG attrib "demo_mode_lun_access" to "demo_mode_write_protect" and added TPG ATTRIB prdo_mode_write_protect. By default values are as follows from iscsi_target_core.h: +#define TA_DEMO_MODE_WRITE_PROTECT 1 // Enabled by default in demo mode (generic_node_acls=1) +#define TA_PROD_MODE_WRITE_PROTECT 0 // Disabled by default in production mode w/ explict ACLs This patch adds iscsi_ta_demo_mode_write_protect() and iscsi_ta_prod_mode_write_protect(), which are used in iscsi_target_configfs.c. Signed-off-by: Nicholas A. Bellinger linux-iscsi.org> --- drivers/lio-core/iscsi_target_core.h | 6 ++++-- drivers/lio-core/iscsi_target_tpg.c | 33 ++++++++++++++++++++++++++------- drivers/lio-core/iscsi_target_tpg.h | 3 ++- 3 files changed, 32 insertions(+), 10 deletions(-) diff --git a/drive

[PATCH 1/3] [LIO-Target]: Update for iSCSI Initiator LUN ACLsusing write_protect

Nicholas A. Bellinger — 2008-12-04T04:35:04

From: Nicholas Bellinger linux-iscsi.org> Date: Wed, 3 Dec 2008 18:48:11 -0800 Subject: [PATCH] [LIO-Target]: Update for iSCSI Initiator LUN ACLs using write_protect Reenabled the write-protect logic in iscsi_target_device.c. This patch does some cleanups for iscsi_update_device_list_access() and iscsi_update_device_list_for_node(). Also, it removes the legacy usage of iscsi_check_device_list_access() in iscsi_dev_init_initiator_node_lun_acl(). This patch also removes the following functions that where part of v2.9 IOCTL: iscsi_check_device_list_access() and iscsi_dev_set_initiator_node_lun_access() Signed-off-by: Nicholas A. Bellinger linux-iscsi.org> --- drivers/lio-core/iscsi_target_device.c | 109 +++++++------------------------- drivers/lio-core/iscsi_target_device.h | 2 +- 2 files changed, 24 insertions(+), 87 deletions(-) diff --git a/drivers/lio-core/iscsi_target_device.c b/drivers/lio-core/iscsi_target_device.c index e811b70..a375c69 100644 --- a/drivers/lio-core/iscsi_target_

[PATCH 0/3] Add ConfigFS enabled write_protect support toLIO-Target

Nicholas A. Bellinger — 2008-12-04T04:34:44

Greetings all, This patch series adds support for turning on LUN level SCSI WRITE-Protect for iSCSI Target Portal Groups (TPGs) and iSCSI Initiator LUN ACLs in the Linux-iSCSI.org Target (LIO-Target). They are made against against lio-core-2.6.git/master and tested on v2.6.28-rc7. [PATCH 1/3] [LIO-Target]: Update for iSCSI Initiator LUN ACLs using write_protect [PATCH 2/3] [LIO-Target]: Add TPG attributes demo_mode_write_protect and prod_mode_write_protect [PATCH 3/3] [LIO-Target/ConfigFS]: Add Target Portal Group *_write_protect attributes and iSCSI LUN ACL write_protect bit The lio-core-2.6.git is located at: http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=summary Comments are appericated, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 12120] [Block layer or SCSI] requests aborted too early during check_partition()

2008-12-04T01:15:51

http://bugzilla.kernel.org/show_bug.cgi?id=12120 ------- Comment #11 from rjw< at >sisk.pl 2008-12-03 17:15 ------- On Thursday, 4 of December 2008, James Bottomley wrote:

Re: [PATCH 1/2] ibmvfc: Delay NPIV login retry and add retries

Brian King — 2008-12-03T21:54:04

They can go in 2.6.29. They are bug fixes, but they are not easily hit. They apply on top of all the other ibmvfc patches queued for 2.6.29. Thanks, Brian

Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c

Kay Sievers — 2008-12-03T21:41:36

Sure, here is it. These are the files I could compile-test. I have another patch, which touches the stuff I couldn't compile, I will send that in the next days. Thanks, Kay From: Kay Sievers vrfy.org> Subject: SCSI: struct device - replace bus_id with dev_name(), dev_set_name() CC: James E.J. Bottomley HansenPartnership.com> Signed-off-by: Kay Sievers vrfy.org> Signed-off-by: Greg Kroah-Hartman suse.de> --- drivers/misc/enclosure.c | 8 +++--- drivers/scsi/aic94xx/aic94xx_tmf.c | 2 - drivers/scsi/hosts.c | 6 +---- drivers/scsi/ipr.c | 2 - drivers/scsi/ipr.h | 2 - drivers/scsi/libsas/sas_discover.c | 2 - drivers/scsi/libsas/sas_dump.c | 2 - drivers/scsi/libsas/sas_port.c | 2 - drivers/scsi/raid_class.c | 3 -- drivers/scsi/scsi_debug.c | 4 +-- drivers/scsi/scsi_ioctl.c | 3 +- drivers/scsi/scsi_scan.c

Re: [PATCH] [Target_Core_Mod/PSCSI]: Use struct request to structscsi_device->request_queue

Nicholas A. Bellinger — 2008-12-03T21:40:47

sorry for the confusion. Ok yes, this one is the 2nd rev of the original patch to remove the usage of scsi_execute_async(). The other two are for getting rid of the casts in between target_core_mod se_task_t scatterlist memory and mapping into target core subsystem plugins (PSCSI, IBLOCK, FILEIO) following your recommendations. request_queue http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commitdiff;h=1b14b5e1fc9a7074322b1015bb86eca2a8ef4560 [PATCH] [Target_Core_Mod]: Convert to se_task_t->task_sg usage in core and subsystem plugins http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commitdiff;h=41e98940da5ffaf7e31fce8d1f706e3e0a679654 [PATCH] [Target_Core_Mod]: Update PSCSI, IBLOCK, FILEIO and RAMDISK for se_task_t->task_sg http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=comm

Re: [PATCH] SCSI: fix the return type of the remove() method insgiwd93.c

James Bottomley — 2008-12-03T21:33:45

Sure ... can you send a copy of it rather than me having to pull it out of your git tree. Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c

Kay Sievers — 2008-12-03T21:28:46

On Wed, Dec 3, 2008 at 22:02, James Bottomley hansenpartnership.com> wrote: Do you want to take over the patch to the scsi tree, and we will work from there. It's through Greg's tree in -next since a while. Kay -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: fix the return type of the remove() method insgiwd93.c

James Bottomley — 2008-12-03T21:02:22

Well, the problem is the stupid ioctl which gives nowhere to say how many bytes the buffer is. For safety's sake, yes, I think you have to limit it to 20 bytes. Otherwise, on the day we introduce long names some random application using this ioctl will die with data corruption and that will be extremely hard to debug. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c

Kay Sievers — 2008-12-03T20:59:12

On Wed, Dec 3, 2008 at 21:52, James Bottomley hansenpartnership.com> wrote: Yeah, but the name will have no real limit. What should we do here? Just Truncate at 20, because we "know" it's not longer? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: fix the return type of the remove() method insgiwd93.c

James Bottomley — 2008-12-03T20:52:09

Hmm, OK ... if you want a review, over the SCSI list is best. Things like this: Give cause for concern: in the original, we know we scribble over 20 bytes of user space. With the new one we scribble over an unknown number (which could potentially be much greater than 20). That's an accident waiting to happen in userspace. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH-mm] scsi: use unaligned endian helpers rather thanbyteshifting

James Bottomley — 2008-12-03T20:33:06

Well, as I've said before, I'm not particularly interested in moving SCSI over to the generic accessors. It does look like the proponents of SCSI specific ones gave up as well (most driver writers even open coded their own over the u32 one we already have). However, things like this Make me think absolutely no way. It's far less readable than the original. The first thing that leaps to the mind of any SCSI person seeing this is what on earth is the opcode doing loaded as part of that expression. It takes a bit of thought to see it's loaded and then discarded by the and operation. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c

Kay Sievers — 2008-12-03T20:29:38

On Wed, Dec 3, 2008 at 20:00, James Bottomley hansenpartnership.com> wrote: http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=driver-core/bus_id-scsi.patch;hb=HEAD Kay -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH-mm] scsi: use unaligned endian helpers rather than byteshifting

Harvey Harrison — 2008-12-03T20:27:48

Pardon me? How could I have done this better: 1) I went through the work to create a common API the whole kernel can use. 2) I hooked up ~20 arches and let arches provide optimized versions where they can. 3) Mine generates better code than what is already there 4) I made it exist for the aligned cases too in case you know it's aligned Then, when I send an RFC you call it crazy? If anything I made it a whole lot goddamn easier on _YOU_ to get you scsi patches to generate good code as these endian helpers are now available on every arch. You're fucking welcome by the way. I also went through the kernel and removed a bunch of private endian wrappers and got them through maintainers, who, by and large, were happy to use the common infrastructure....other than scsi for some reason I cannot for the life of me understand. So add a private scsi helper if you want, I'm not standing in your way but if anything, I think you are crazy one here. Harvey -- To unsubscribe from this list: send the line "unsubscri

Re: [RFC PATCH-mm] scsi: use unaligned endian helpers rather than byteshifting

Matthew Wilcox — 2008-12-03T20:15:06

That may well generate better code, but I have a hard time convincing myself that it's correct. This badly needs to be abstracted into something *THAT MAKES SENSE FOR SCSI*. James, if I resend my patches that introduce scsi_get_u24() et al, will you apply them? I'm tired of having to nack all the crazy patches that Harvey keeps sending.

Re: [PATCH 00/11] st: remove scsi_execute_async usage (the first half)

Kai Makisara — 2008-12-03T19:40:53

... Now that I looked more carefully, it does that. Yes. I replaced my patch with yours. Now the tests pass. I did some tests with debugging enabled and those showed that the sense data is returned correctly. I am not sure that -EBUSY is a valid error return any more. Should the error be -ENOMEM if blk_get_request fails and otherwise return what blk_rq_map_kern returns? Yes. I am not sure that -EBUSY is correct return value there. Thanks, Kai -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC PATCH-mm] scsi: use unaligned endian helpers rather than byteshifting

Harvey Harrison — 2008-12-03T19:37:23

Signed-off-by: Harvey Harrison gmail.com> --- Depends on the unaligned access work in -mm. Just so you can see what the transition would look like. See in particular the READ/WRITE6 bits as just reading the full 32 bits and masking ends up being better on lots of arches. (x86/powerpc/SH at least) drivers/scsi/aacraid/aachba.c | 126 +++++++++------------------------------- 1 files changed, 29 insertions(+), 97 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 90d1d08..5cdbc7d 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c < at >< at > -33,6 +33,7 < at >< at > #include #include #include /* For flush_kernel_dcache_page */ +#include #include #include < at >< at > -1479,29 +1480,18 < at >< at > static void io_callback(void *context, struct fib * fibptr) switch (scsicmd->cmnd[0]) { case WRITE_6: case READ_6: -lba = ((scsicmd->cmnd[1] &

Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c

Vorobiev Dmitri — 2008-12-03T19:10:29

...and meanwhile, could you James please apply the original patch to silence the compiler warning until the void (*remove)() is introduced? Thanks, Dmitri -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c

Vorobiev Dmitri — 2008-12-03T19:07:34

Well, I don't really want to look like a coward, but I guess this a good project for Kernel Janitors, and I'm Cc:ing their mailing list now. Dmitri -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html