gmane.linux.scsi

Re: [RFC PATCH] scsi: fix hot unplug vs async scan race

Mike Christie — 2012-05-26T04:52:21

I do not think it is safe to have the starget pointer on the phy and
then pass it to scsi_remove_target. If you did

for each device
echo 1 > /sys/..../remove

then the target would get reaped/freed from under the transport class right?

It looks like the fc class needs a similar fix though too.

iSCSI is ok since no iscsi driver does scsi_scan_host and does async
scanning from userspace.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(unknown)

robothroli company — 2012-05-25T13:45:54

 i am robothroli, Purchase manager from roli Merchant Ltd. We are
Import/export Company based in taiwan. We are interested in purchasing
your product and I would like to make an inquiry. Please inform me on:

Sample availability and price
Minimum order quantity
FOB Prices

Sincerely
Purchase Manager
robothroli



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Resend PATCH v2] scsi_lib: rate-limit the error message from failing commands

Robert Love — 2012-05-25T21:29:34

From: Yi Zou <yi.zou< at >intel.com>

When performing a cable pull test w/ active stress I/O using fio over
a dual port Intel 82599 FCoE CNA, w/ 256LUNs on one port and about 32LUNs
on the other, it is observed that the system becomes not usable due to
scsi-ml being busy printing the error messages for all the failing commands.
I don't believe this problem is specific to FCoE and these commands are
anyway failing due to link being down (DID_NO_CONNECT), just rate-limit
the messages here to solve this issue.

v2->v1: use __ratelimit() as Tomas Henzl mentioned as the proper way for
rate-limit per function. However, in this case, the failed i/o gets to
blk_end_request_err() and then blk_update_request(), which also has to
be rate-limited, as added in the v2 of this patch.

Signed-off-by: Yi Zou <yi.zou< at >intel.com>
Acked-by: Tomas Henzl <thenzl< at >redhat.com>
Signed-off-by: Robert Love <robert.w.love< at >intel.com>
---
 block/blk-core.c        |    8 +++++---
 drivers/scsi/scsi_lib.c |    5 ++++-
 2 files changed, 9 insertio

Re: [RFC] How to fix an async scan - 'rmmod --wait' race?

Dan Williams — 2012-05-25T18:46:19

Have a look at:

http://marc.info/?l=linux-scsi&m=133793175125892&w=2

...it addresses tearing down targets before they are added which
appears to be the signature here.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] libfc: update fcp and exch stats

Vasu Dev — 2012-05-25T17:26:54

Updates newly added stats from fc_get_host_stats,
added new function fc_exch_update_stats to
update exches related stats from fc_exch.c
by going thru internal ema_list elements.

Signed-off-by: Vasu Dev <vasu.dev< at >intel.com>
Acked-by : Robert Love <robert.w.love< at >intel.com>
Tested-by: Ross Brattain <ross.b.brattain< at >intel.com>
---

 drivers/scsi/libfc/fc_exch.c  |   30 +++++++++++++++++++++++++-----
 drivers/scsi/libfc/fc_lport.c |    7 +++++++
 include/scsi/libfc.h          |    1 +
 3 files changed, 33 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 1d0334f..10a6a2a 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
< at >< at > -99,11 +99,6 < at >< at > struct fc_exch_mgr {
 u16max_xid;
 u16pool_max_index;
 
-/*
- * currently exchange mgr stats are updated but not used.
- * either stats can be expose via sysfs or remove them
- * all together if not used XXX
- */
 struct {
 atomic_t no_free_exch;
 atomic_t no_free_exch_xid;
< at >< at >

[PATCH 2/4] libfc: cleanup fcoe_dev_stats

Vasu Dev — 2012-05-25T17:26:43

The libfc is used by fcoe but fcoe agnostic,
and therefore should not have any fcoe references.

So renaming fcoe_dev_stats from libfc as its for fc_stats.
After that libfc is fcoe string free except some strings for
Open-FCoE.org.

Signed-off-by: Vasu Dev <vasu.dev< at >intel.com>
Acked-by : Robert Love <robert.w.love< at >intel.com>
Tested-by: Ross Brattain <ross.b.brattain< at >intel.com>
---

 drivers/scsi/bnx2fc/bnx2fc_fcoe.c  |   10 +++----
 drivers/scsi/bnx2fc/bnx2fc_io.c    |    4 +--
 drivers/scsi/fcoe/fcoe.c           |   18 ++++++------
 drivers/scsi/fcoe/fcoe_ctlr.c      |   13 ++++-----
 drivers/scsi/fcoe/fcoe_transport.c |   10 +++----
 drivers/scsi/libfc/fc_exch.c       |    4 +--
 drivers/scsi/libfc/fc_fcp.c        |    8 +++--
 drivers/scsi/libfc/fc_frame.c      |    2 +
 drivers/scsi/libfc/fc_lport.c      |   54 ++++++++++++++++++------------------
 include/scsi/libfc.h               |   17 +++++------
 10 files changed, 69 insertions(+), 71 deletions(-)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/d

[PATCH 3/4] libfc: adds FCP failures stats

Vasu Dev — 2012-05-25T17:26:48

Adds stats to track FCP pkt and frame alloc
failure.

Signed-off-by: Vasu Dev <vasu.dev< at >intel.com>
Acked-by : Robert Love <robert.w.love< at >intel.com>
Tested-by: Ross Brattain <ross.b.brattain< at >intel.com>
---

 drivers/scsi/libfc/fc_fcp.c |    8 ++++++++
 include/scsi/libfc.h        |    6 ++++++
 2 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index 5c4c504..3c96e93 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
< at >< at > -158,6 +158,9 < at >< at > static struct fc_fcp_pkt *fc_fcp_pkt_alloc(struct fc_lport *lport, gfp_t gfp)
 fsp->timer.data = (unsigned long)fsp;
 INIT_LIST_HEAD(&fsp->list);
 spin_lock_init(&fsp->scsi_pkt_lock);
+} else {
+per_cpu_ptr(lport->stats, get_cpu())->FcpPktAllocFails++;
+put_cpu();
 }
 return fsp;
 }
< at >< at > -264,6 +267,9 < at >< at > static int fc_fcp_send_abort(struct fc_fcp_pkt *fsp)
 if (!fsp->seq_ptr)
 return -EINVAL;
 
+per_cpu_ptr(fsp->lp->stats, get_cpu())->FcpPktAborts++;
+put_cpu();
+
 f

[PATCH 1/4] fc: adds some more FC specific stats to fc_host

Vasu Dev — 2012-05-25T17:26:38

The libfc provides more flexibility and with that
we can monitor some more FC specific stats for
FC exches or FCP error cases, this patch add
such new FC stats.

The patch adds *only* FC specific new stats to
existing fc_host attribute container.

Added stats names are self explanatory as
existing FC stats already has, however anyway
still added commentary along their definition
to describe them.

CC: James Smart <james.smart< at >emulex.com>

Signed-off-by: Vasu Dev <vasu.dev< at >intel.com>
Acked-by : Robert Love <robert.w.love< at >intel.com>
Tested-by: Ross Brattain <ross.b.brattain< at >intel.com>
---

 drivers/scsi/scsi_transport_fc.c |   18 ++++++++++++++++++
 include/scsi/scsi_transport_fc.h |   12 ++++++++++++
 2 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 5797604..2fded79 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
< at >< at > -1744,6 +1744,15 < at >< at > fc_host_statistic(fcp_output_requests);
 fc_host_s

Tercume edilecek metinleriniz hakkinda

2012-05-23T13:14:22

Sayin ilgili,
 
Biz 10 yili askin bir süredir internet üzerinden profesyonel olarak
CEVIRI / TERCUME HIZMETLERI veren bir kurulusuz. Kurulusumuzun 10. yili  
serefine firmalara ozel, sayfasi 12 TL+KDV'lik bir kampanya hazirladik.

Sadece INGILIZCE - TURKCE ve TURKCE - INGILIZCE cevirilerde gecerli olan ve 
kisa bir sure 
devam edecek bu cazip fiyat avantajindan yararlanmak icin
lutfen bizi hemen simdi arayiniz veya bir e-posta gonderiniz. Diger diller 
icin lutfen fiyat sorunuz.

Not: 1 sayfa = 1000 karakter veya 180 kelimelik dunya standardi 
esas alinmistir. Teknik metinlerde %25 fark alinacaktir. Diger diller icin 
lutfen fiyat aliniz.

Saygilarimizla,
 
Levent Turer,  
Genel Koordinator
Turer Ceviri Hizmetleri

e-posta: info< at >turerceviri.com 
web: www.turerceviri.com 
Tel: 0232 421 13 60
Faks: 0232 421 13 32

Bu e-mail size otomatik olarak, yani bir reklam amaciyla rastgele 
gonderilmemistir.  Eger bizden bu veya benzeri bir konuda 
bir daha e-posta almak istemiyorsaniz, lutfen bize bildiriniz. Size 
ra

[PATCH] scsi: fix async probe regression

Dan Williams — 2012-05-25T16:39:15

Commit a7a20d1 "[SCSI] sd: limit the scope of the async probe domain"
moved sd probe work out of reach of wait_for_device_probe().  Allow it
to be synced via scsi_complete_async_scans().

Cc: David Miller <davem< at >davemloft.net>
Cc: Alan Stern <stern< at >rowland.harvard.edu>
Reported-by: Meelis Roos <mroos< at >linux.ee>
Tested-by: Meelis Roos <mroos< at >linux.ee>
Signed-off-by: Dan Williams <dan.j.williams< at >intel.com>
---

 So this is the stop gap that allows us to keep a7a20d1 as a fix for a
 resume deadlock, and gives us time to figure out how to clarify
 async_synchronize_full() properly in the 3.6 timeframe.

 drivers/scsi/scsi_scan.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 01b0374..41f9192 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
< at >< at > -141,13 +141,13 < at >< at > struct async_scan_data {
  * started scanning after this function was called may or may not have
  * finished.
  */
-int scsi_complete_async_

Re: [RFC PATCH] scsi: fix hot unplug vs async scan race

Dan Williams — 2012-05-25T15:34:03

[ add the folks on the cc ]

On Fri, May 25, 2012 at 12:55 AM, Dan Williams <dan.j.williams< at >intel.com> wrote:
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC] How to fix an async scan - 'rmmod --wait' race?

Tomas Henzl — 2012-05-25T15:13:18

The async_synchronize_full : "This function returns when there are no asynchronous
function calls in the system."
The point is that the async scan is not started with async_schedule but with kthread_run,
so the synchronization doesn't work in this case (an error log is attached at bottom).
I wish I would knew, but everything seems to be too much complicated, one idea
was to use in the teardown path new special functions only for this use, but...

Tomas


May 25 04:25:54 localhost kernel: [  461.525209] BUG: unable to handle kernel NULL pointer dereference at 0000000000000079
May 25 04:25:54 localhost kernel: [  461.525242] IP: [<ffffffff811f0c45>] sysfs_create_dir+0x35/0xc0
May 25 04:25:54 localhost kernel: [  461.525259] PGD 0 
May 25 04:25:54 localhost kernel: [  461.525267] Oops: 0000 [#1] SMP 
May 25 04:25:54 localhost kernel: [  461.525278] CPU 0 
May 25 04:25:54 localhost kernel: [  461.525283] Modules linked in: mpt2sas(-) lockd bnep bluetooth be2iscsi iscsi_boot_sysfs bnx2i cnic uio cxgb4i cxgb4 cxgb

Re: [PATCH 1/4] async: introduce 'async_domain' type

James Bottomley — 2012-05-25T08:48:20

OK, that's what I hadn't seen.  I can't think of another way we could
fail at the moment, except in suspend/resume because the
scsi_complete_async_scans will be a nop. Can someone test the
suspend/resume case?


There is actually one good thing to come out of this:  Rafael's commit

commit c751085943362143f84346d274e0011419c84202
Author: Rafael J. Wysocki <rjw< at >sisk.pl>
Date:   Sun Apr 12 20:06:56 2009 +0200

    PM/Hibernate: Wait for SCSI devices scan to complete during resume

Actually broke the scsi_wait_scan module, because for modular SCSI
(which is effectively all distributions) its scsi_complete_async_scans()
is also a nop.  I assume this means that no distributions rely on it any
more and we can remove it?


I appreciate this is a bug, but it's not quite as serious as breaking
suspend and hibernate ... can we demonstrate they're still working?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at

Re: [PATCH 1/4] async: introduce 'async_domain' type

Dan Williams — 2012-05-25T08:18:21

On Fri, May 25, 2012 at 12:51 AM, James Bottomley
<James.Bottomley< at >hansenpartnership.com> wrote:

Makes sense... but could also go ahead with the smaller fix I posted
for 3.5.  Meelis confirms it is working.

Otherwise this leaves the pending libsas suspend/resume support in
limbo, since it will certainly deadlock in the case where any device
fails, or is slow to come back from resume.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] async: introduce 'async_domain' type

James Bottomley — 2012-05-25T07:51:07

This looks good, but I want Arjan and others who invented the async code
to speed up boot to comment on all of this.  What was the intention of
async_synchronize_full() and if it wasn't to synchronise all domains,
should we fix the documentation and add a new primitive to do that,
since boot clearly assumes the all domains behaviour.

In the mean time, this is probably all a bit much for a merge window, so
I'll revert 

commit a7a20d103994fd760766e6c9d494daa569cbfe06
Author: Dan Williams <dan.j.williams< at >intel.com>
Date:   Thu Mar 22 17:05:11 2012 -0700

    [SCSI] sd: limit the scope of the async probe domain

And we'll put whatever is chosen in early for the next merge window.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 3.4.0-02580-g72c04af regression on sparc64 - partitions not recognized

James Bottomley — 2012-05-25T07:45:21

I don't understand this.

Why would it make a difference whether SCSI is modular at hybernation
resume time?  The reason it makes a difference at boot time is because
there's no initrd to wait for the scans and mount the root if we're not
modular, so the init path has to do it.  However, when resuming an
image, the module is already loaded into that image, so there should be
no difference at all between steps taken in the modular and non-modular
cases.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH] scsi: fix hot unplug vs async scan race

Dan Williams — 2012-05-25T07:55:48

The following crash results from cases where the end_device has been
removed before scsi_sysfs_add_sdev has had a chance to run.

 BUG: unable to handle kernel NULL pointer dereference at 0000000000000098
 IP: [<ffffffff8115e100>] sysfs_create_dir+0x32/0xb6
 ...
 Call Trace:
  [<ffffffff8125e4a8>] kobject_add_internal+0x120/0x1e3
  [<ffffffff81075149>] ? trace_hardirqs_on+0xd/0xf
  [<ffffffff8125e641>] kobject_add_varg+0x41/0x50
  [<ffffffff8125e70b>] kobject_add+0x64/0x66
  [<ffffffff8131122b>] device_add+0x12d/0x63a
  [<ffffffff814b65ea>] ? _raw_spin_unlock_irqrestore+0x47/0x56
  [<ffffffff8107de15>] ? module_refcount+0x89/0xa0
  [<ffffffff8132f348>] scsi_sysfs_add_sdev+0x4e/0x28a
  [<ffffffff8132dcbb>] do_scan_async+0x9c/0x145

...teach scsi_sysfs_add_devices to check for deleted device before
trying to add them.

This teaches scsi_transport_sas to bypass scsi_remove_target() since it
is unable to find the target from the end_device rphy since
device_for_each_child() relies on the target device having gon

[PATCH 4/4] scsi: cleanup usages of scsi_complete_async_scans

Dan Williams — 2012-05-25T07:50:43

Now that scsi registers its async scan work with the async subsystem,
wait_for_device_probe() is sufficient for ensuring all scanning is
complete.

Cc: Arjan van de Ven <arjan< at >linux.intel.com>
Cc: Len Brown <len.brown< at >intel.com>
Cc: Rafael J. Wysocki <rjw< at >sisk.pl>
Cc: James Bottomley <JBottomley< at >parallels.com>
Signed-off-by: Dan Williams <dan.j.williams< at >intel.com>
---
 drivers/scsi/scsi_scan.c      |   12 ------------
 drivers/scsi/scsi_wait_scan.c |   15 +++++----------
 include/scsi/scsi_scan.h      |   11 -----------
 kernel/power/hibernate.c      |    8 --------
 kernel/power/user.c           |    2 --
 5 files changed, 5 insertions(+), 43 deletions(-)
 delete mode 100644 include/scsi/scsi_scan.h

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index fb42aa0..20c7108 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
< at >< at > -184,18 +184,6 < at >< at > int scsi_complete_async_scans(void)
 return 0;
 }
 
-/* Only exported for the benefit of scsi_wait_scan */
-EXPORT_SYMBOL_GPL(scsi_co

Re: [3.0.y, 3.2.y, 3.3.y] Re: [PATCH 05/10] hpsa: Fix problem with MSA2xxx devices

Jonathan Nieder — 2012-05-24T22:02:16


Thanks, both.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

HHS5877 {Verify Your Ownership}

2012-05-24T16:47:06

Your email just earn 1,000,000GBP in the  HEINEKEN STAR PRIZE Offer. 
Your reference code is: HHS5877. To proceed, please reply to verify 
you are the owner of this E-mail Address.

Info Dept.
Heineken Star prize

**SERVER**
THIS MESSAGE HAS BENN VERIFIED AND IT IS THEREFORE AUTHENTIC. If found 
in Junk/Spam folder please move to inbox before you reply, this is to 
avoid loss of relevant information regarding details of procedures 
from the sender.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC v2 PATCH 2/4] block: add queue runtime pm callbacks

Lin Ming — 2012-05-24T10:19:36

Just found that it's because "printk".

When disk is suspended, it prints out some message, for example,

[  670.597103] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[  670.597827] sd 0:0:0:0: [sda] Stopping disk

Then syslogd is waken up to write the log.
So disk is resumed right after suspended.

Lin Ming

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html