gmane.linux.ppp

Re: [PATCH v3 3/4] ppp_mppe: cleanup kernel log messages

David Miller — 2013-05-24T01:32:52

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>
Date: Wed, 22 May 2013 13:32:52 +0200


You've got to be kidding me.  Don't do this.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 4/4] ppp_mppe: formatting and style cleanup

Jorge Boncompte [DTI2] — 2013-05-22T11:32:53

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

- Changes format and style to comply with networking code requirements.
- Adds include guards to ppp_mppe.h.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
Changes from v2:
- Checkpatch clean.

 drivers/net/ppp/ppp_mppe.c |  252 ++++++++++++++++++--------------------------
 drivers/net/ppp/ppp_mppe.h |   38 ++++---
 2 files changed, 124 insertions(+), 166 deletions(-)

diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index 97989db..25575a0 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
< at >< at > -68,8 +68,8 < at >< at > MODULE_LICENSE("Dual BSD/GPL");
 MODULE_ALIAS("ppp-compress-" __stringify(CI_MPPE));
 MODULE_VERSION("1.0.2");
 
-static unsigned int
-setup_sg(struct scatterlist *sg, const void *address, unsigned int length)
+static unsigned int setup_sg(struct scatterlist *sg, const void *address,
+     unsigned int length)
 {
 sg_set_buf(sg, address, length);
 return length;
< at >< at > -77,11 +77,9 < at >< at > setup_sg(struct s

[PATCH v3 2/4] ppp_mppe: check coherency counter for out-of-order sequencing

Jorge Boncompte [DTI2] — 2013-05-22T11:32:51

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

While testing a L2TP tunnel without sequencing with MPPE encryption in
stateless mode I noticed that after a packet was reordered the encapsulated
traffic session was stuck but testing against a Cisco gear did work.

From RFC3078 "MPPE expects packets to be delivered in sequence".

The thing it's that the ppp_mppe module treats the reorder as if the
coherency counter did wrap and rekeys all the "missing" packets.

The link layer protocol should deliver the packets in order but at least
with this patch in place the decryption process survives some packet reorder.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
Changes from v2:
- Addressed Eric Dumazet review.
- Checkpatch clean.

 drivers/net/ppp/ppp_mppe.c |   19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index 9a1849a..f2e3d17 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
< at >< at > -

[PATCH v3 1/4] ppp: adds new decompressor error code to signal that packet must be dropped

Jorge Boncompte [DTI2] — 2013-05-22T11:32:50

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

Currently decompressors can't signal the generic PPP layer to silently
drop a packet without notifying the PPP daemon or the other party.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
 drivers/net/ppp/ppp_generic.c |   12 ++++++++++++
 include/linux/ppp-comp.h      |    6 ++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 72ff14b..7d26825 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
< at >< at > -1729,6 +1729,10 < at >< at > ppp_receive_nonmp_frame(struct ppp *ppp, struct sk_buff *skb)
     (ppp->rstate & (SC_DC_FERROR | SC_DC_ERROR)) == 0)
 skb = ppp_decompress_frame(ppp, skb);
 
+/* Packet dropped */
+if (skb == NULL)
+goto err;
+
 if (ppp->flags & SC_MUST_COMP && ppp->rstate & SC_DC_FERROR)
 goto err;
 
< at >< at > -1888,6 +1892,13 < at >< at > ppp_decompress_frame(struct ppp *ppp, struct sk_buff *skb)
 len = ppp->rcomp->decompress(ppp->rc_state, sk

благо посетить на наш сайт. Вам Понравится то что Вы на нем увидите.

i_ebevova — 2013-05-22T02:22:30

доступнее нежели У нас это бесплатно  http://goo.gl/L57nx?/egRfioWs - Пора вставать, уж ровно пять. Ну, а младший, наконец,

Re: [RFC PATCH v2 3/4] ppp_mppe: cleanup kernel log messages

Joe Perches — 2013-05-21T18:40:26

[]
[]

Please don't split formats across multiple lines.

net_warn_ratelimited("%s[%d]: crypto_blkcipher_encrypt failed\n",
     __func__, state->unit);

is just fine.


this could probably use:
%*ph, (int)sizeof(state->session_key), state->session_key

[]

another split format, please coalesce.

etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH v2 4/4] ppp_mppe: style cleanup

Jorge Boncompte [DTI2] — 2013-05-21T18:18:24

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
 drivers/net/ppp/ppp_mppe.c |  104 +++++++++++++++++++++-----------------------
 1 file changed, 49 insertions(+), 55 deletions(-)

diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index 54c64cf..4d27245 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
< at >< at > -66,8 +66,8 < at >< at > MODULE_LICENSE("Dual BSD/GPL");
 MODULE_ALIAS("ppp-compress-" __stringify(CI_MPPE));
 MODULE_VERSION("1.0.2");
 
-static unsigned int
-setup_sg(struct scatterlist *sg, const void *address, unsigned int length)
+static unsigned int setup_sg(struct scatterlist *sg, const void *address,
+     unsigned int length)
 {
 sg_set_buf(sg, address, length);
 return length;
< at >< at > -138,7 +138,7 < at >< at > struct ppp_mppe_state {
  * Key Derivation, from RFC 3078, RFC 3079.
  * Equivalent to Get_Key() for MS-CHAP as described in RFC 3079.
  */
-static void get_new_key_from_sha(struct ppp_mppe_state * state)
+stat

[RFC PATCH v2 3/4] ppp_mppe: cleanup kernel log messages

Jorge Boncompte [DTI2] — 2013-05-21T18:18:23

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

- Consolidate log messages, print PPP unit number where available.
- Changes error or warning messages to correct log level.
- Use _ratelimited() functions for messages triggered by network packets.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
 drivers/net/ppp/ppp_mppe.c |   78 +++++++++++++++++++++++---------------------
 1 file changed, 41 insertions(+), 37 deletions(-)

diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index 97f4804..54c64cf 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
< at >< at > -178,7 +178,8 < at >< at > static void mppe_rekey(struct ppp_mppe_state * state, int initial_key)
 setup_sg(sg_out, state->session_key, state->keylen);
 if (crypto_blkcipher_encrypt(&desc, sg_out, sg_in,
      state->keylen) != 0) {
-        printk(KERN_WARNING "mppe_rekey: cipher_encrypt failed\n");
+net_warn_ratelimited("%s[%d]: crypto_blkcipher_encrypt "
+     "failed\n", __func__, state->unit);
 }

[RFC PATCH v2 1/4] ppp: adds new error for decompressors to signal that packet must be dropped

Jorge Boncompte [DTI2] — 2013-05-21T18:18:21

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

Currently decompressors can't signal the generic PPP layer to silently
drop a packet without notifying the PPP daemon or the other party.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
 drivers/net/ppp/ppp_generic.c |   12 ++++++++++++
 include/linux/ppp-comp.h      |    6 ++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 72ff14b..7d26825 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
< at >< at > -1729,6 +1729,10 < at >< at > ppp_receive_nonmp_frame(struct ppp *ppp, struct sk_buff *skb)
     (ppp->rstate & (SC_DC_FERROR | SC_DC_ERROR)) == 0)
 skb = ppp_decompress_frame(ppp, skb);
 
+/* Packet dropped */
+if (skb == NULL)
+goto err;
+
 if (ppp->flags & SC_MUST_COMP && ppp->rstate & SC_DC_FERROR)
 goto err;
 
< at >< at > -1888,6 +1892,13 < at >< at > ppp_decompress_frame(struct ppp *ppp, struct sk_buff *skb)
 len = ppp->rcomp->decompress(ppp->rc_state, sk

У Вашего малыша действительно нету

лександр — 2013-05-20T19:59:41

Побалуйте оригинальным http://goo.gl/9yQPC?/sfOyu
N‹§Іжмrё›yъиљШbІX¬¶З§vШ^–)Ює{.nЗ+‰·ҐЉ{±¦љbћШ^n‡rЎц¦zЛЃлh™ЁиЪ&ўш®G«ќйh®(йљЋЉЭўj"ќъ¶m§япЃкдz№Ю–ЉаюfЈў·hљ€§~€m

Re: [RFC PATCH 2/2] ppp_mppe: Check coherency counter for out-of-order sequencing

Jorge Boncompte [DTI2] — 2013-05-20T18:03:40

El 20/05/2013 19:32, Eric Dumazet escribió:

The coherency count it's a 12-bit value. I'll add a define for it.


I think it will be better if I prepare a third patch that cleanups the whole
file after.

Re: [RFC PATCH 2/2] ppp_mppe: Check coherency counter for out-of-order sequencing

Eric Dumazet — 2013-05-20T17:32:50

How was chosen this magical value ?



net_dbg_ratelimited() ?



--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH 2/2] ppp_mppe: Check coherency counter for out-of-order sequencing

Jorge Boncompte [DTI2] — 2013-05-20T16:34:00

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

While testing a L2TP tunnel without sequencing with MPPE encryption in
stateless mode noticed that after a packet was reordered the encapsulated
traffic session was stuck but testing against a Cisco gear did work.

From RFC3078 "MPPE expects packets to be delivered in sequence".

The thing it's that the ppp_mppe module treats the reorder as if the
coherency counter did wrap and rekeys all the "missing" packets.

The link layer protocol should deliver the packets in order but at least
with this patch in place the decryption process survives some packet reorder.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
 drivers/net/ppp/ppp_mppe.c |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index 9a1849a..0a10a6d 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
< at >< at > -55,6 +55,7 < at >< at >
 #include <linux/ppp_defs.h>
 #include <linux/ppp-comp.h>
 #include <lin

[RFC PATCH 1/2] ppp: adds new error for decompressors to signal that packet must be dropped

Jorge Boncompte [DTI2] — 2013-05-20T16:33:59

From: "Jorge Boncompte [DTI2]" <jorge< at >dti2.net>

Currently decompressors can't signal the generic PPP layer to silently
drop a packet without notifying the PPP daemon or the other party.

Signed-off-by: Jorge Boncompte [DTI2] <jorge< at >dti2.net>
---
 drivers/net/ppp/ppp_generic.c |   12 ++++++++++++
 include/linux/ppp-comp.h      |    6 ++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 72ff14b..7d26825 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
< at >< at > -1729,6 +1729,10 < at >< at > ppp_receive_nonmp_frame(struct ppp *ppp, struct sk_buff *skb)
     (ppp->rstate & (SC_DC_FERROR | SC_DC_ERROR)) == 0)
 skb = ppp_decompress_frame(ppp, skb);
 
+/* Packet dropped */
+if (skb == NULL)
+goto err;
+
 if (ppp->flags & SC_MUST_COMP && ppp->rstate & SC_DC_FERROR)
 goto err;
 
< at >< at > -1888,6 +1892,13 < at >< at > ppp_decompress_frame(struct ppp *ppp, struct sk_buff *skb)
 len = ppp->rcomp->decompress(ppp->rc_state, sk

Это доступно

флена — 2013-05-20T02:12:42

  Вы получите возможность разговаривать на британском непосредственно после дебютного урока. Поднять личную стоимость на поприще работы. Быстрое изучение. Потребляются засекреченные методы. Изготовить личную биографию разновиднее, подзаняться любопытнейшим занятием. Web: http://goo.gl/DxIG1 . 
 
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Investment Placement

Mr. Wayne Scott — 2013-05-06T19:18:18

Greetings,

I am a Civil Lawyer in the United Kingdom. I have a Client that has Interest in investing in Your country. Can You be of assistance?

I shall give you details when you reply

Wayne
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Investment Placement

Mr. Wayne Scott — 2013-05-03T18:14:24

Greetings,

I am a Civil Lawyer in the United Kingdom. I have a Client that has Interest in investing in Your country. Can You be of assistance?

I shall give you details when you reply

Wayne
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Investment Placement

Mr. Wayne Scott — 2013-05-08T23:41:12

Greetings,

I am a Civil Lawyer in the United Kingdom. I have a Client that has Interest in investing in Your country. Can You be of assistance?

I shall give you details when you reply

Wayne
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

надежды устанавливаются очевидностью

trash64 — 2013-05-10T02:07:37

Адрес интернет-магазина: http://tinyurl.com/d9934g9 она поможет Вам <<разложить полностью по полочкам>> и сфокусировать органичные источники на наиболее - на Вашей цели! и не существенно, какую цель Вы пред собою назначаете - переменить профессию, развернуть дело али похудеть на |O килограмм. Мы ведим как поспособствовать Вам достичь успеха! Мы презентуем вашему вниманию новейшую программу людям, какие бегут к своим целям!
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

dringender Vorschlag

John P. Goldman — 2013-05-08T08:46:28


Entschuldigungen für kommen in Ihre Privatsphäre! Ich bin Rechtsanwalt
Werner Erich Zeller; Ich habe einen meiner einflussreichen und
wohlhabenden Kunden zum Tode; und er hatte eine sehr geheime und private
Investitionen von €15,000,000.00 bei einer privaten Bank in Großbritannien
hier zu Lebzeiten. Diese Investition wurde ohne einen deklarierten
nächsten Angehörigen und begünstigte. Jetzt brauche ich Sie arbeiten mit
mir als mein Partner zu erholen und zu je 50 % Aktienfonds. Alle Dokumente
werden rechtlich beantragt und beschafft, und in 5 Werktage, wird diese
Transaktion auftreten. Aber ich brauche einen ernsten, treuen und
glaubwürdigen Partner.

Bitte senden Sie mir eine vertrauliche Antwort, wenn Sie denken, Sie
vertraut werden können und sind von den Qualitäten! Ich warte auf Ihre
schnelle Antwort.

Werner Erich Zeller (Rechtsanwalt)
Rufen Sie + 44-702-409-0820 (Office)
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kerne

RE: Loan Offer! Contact: transcopeloan12< at >qq.com

Bernstein, Harry — 2013-04-30T03:14:56

________________________________________
From: Bernstein, Harry
Sent: Monday, April 29, 2013 9:57 PM
To: info< at >notice.com
Subject: Loan Offer! Contact: transcopeloan12< at >qq.com

Do You Need an urgent loan of any Amount? Then contact us now, we give out all kinds of loans with a very low interest rate of 3%. Contact us with your name, your country: loan amount needed: loan duration: monthly income: your valid cell phone number : sex : via E-mail Only  transcopeloan12< at >qq.com--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html