gmane.linux.ports.arm.kernel

Re: [PATCH v7] arm: use built-in byte swap function

Dirk Behme — 2013-05-26T05:38:37

Am 23.05.2013 18:46, schrieb Kim Phillips:

I'm no GCC tool chain expert, so I just have an understanding 
question: Could anyone kindly give a brief explanation (*) of what the 
advantage of this is on ARM?

http://comments.gmane.org/gmane.linux.kernel.cross-arch/16016

mentions "lwbrx/stwbrx on PowerPC, movbe on Atom". But for ARM?

I haven't understood yet why the __arch_swabXX() in 
arch/arm/include/asm/swab.h [1] aren't sufficient? How can this be 
done better? E.g. does anybody have a disassembly without/with this 
change to illustrate that?

Many thanks and best regards

Dirk

(*) or in case this already done provide a link. I couldn't find it in 
the discussion of this patch.

[1]

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/include/asm/swab.h

Re: [PATCH 0/4] Power off drivers for QNAP and LSXL.

Jason Cooper — 2013-05-26T01:19:51

Yeah.... So thanks to Andrew for bringing this to my attention.
Somewhere along the line, I must've dropped patches 2 and 4.

Thankfully, patches 1 and 3 made it in, so I've just applied 2 and 4 to
mvebu/boards.

thx, and sorry for the delay.

Jason.

Kirkwood CPU Freq driver

Adam Baker — 2013-05-25T21:32:04

Hi,

I've been trying to test Andrew Lunn's work creating a CPU Idle driver 
for Kirkwood. The first problem I encountered was that somehow in 
merging the patch the ARCH_HAS_CPUFREQ line appears to have got lost in 
arch/arm/Kconfig so I put that back (this may not be an issue if you 
build a multiarch kernel but I was targetting just Kirkwood)

--- a/arch/arm/Kconfig2013-05-24 19:45:59.000000000 +0100
+++ b/arch/arm/Kconfig2013-05-17 19:58:21.000000000 +0100
< at >< at > -567,6 +567,7 < at >< at > config ARCH_DOVE

  config ARCH_KIRKWOOD
  bool "Marvell Kirkwood"
+select ARCH_HAS_CPUFREQ
  select ARCH_REQUIRE_GPIOLIB
  select CPU_FEROCEON
  select GENERIC_CLOCKEVENTS

Then I saw that the driver needs a cpu definition and none of the 
kirkwood dts files provide one. I believe all kirkwood SoCs are 
uniprocessor so I created an entry in kirkwood.dtsi

--- a/arch/arm/boot/dts/kirkwood.dtsi2013-05-19 22:57:07.000000000 +0100
+++ b/arch/arm/boot/dts/kirkwood.dtsi2013-05-19 23:10:32.000000000 +0100
< at >< at > -4,6 +4,18 < at >< at >
  comp

[PATCH] ARM: mx6: Use the same sdma firmware name for all mx6 variants

Fabio Estevam — 2013-05-25T17:47:28

From: Fabio Estevam <fabio.estevam< at >freescale.com>

All the mx6 variants (quad, dual, solo and solo-lite) use the same sdma 
firmware, so drop the the suffix from the file name.

Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
 arch/arm/boot/dts/imx6sl.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 42e461c..b6730cc 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
< at >< at > -582,7 +582,7 < at >< at >
 interrupts = <0 2 0x04>;
 clocks = <&clks 155>, <&clks 155>;
 clock-names = "ipg", "ahb";
-fsl,sdma-ram-script-name = "imx/sdma/sdma-imx6q.bin";
+fsl,sdma-ram-script-name = "imx/sdma/sdma-imx6.bin";
 };
 };
 
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index c5e5da0..9596000 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
< at >< at > -594,7 +594,7 < at >< at >
 clocks = <&clks

Re: [PATCH 00/21] ARM: kirkwood: improve pinmux configs in Device Tree

Andrew Lunn — 2013-05-25T16:54:09

Hi Thomas, Jason

You can add a

Tested-By: Andrew Lunn <andrew< at >lunn.ch>

to the topkick and ts219 patches, and a general 

Acked-by: Andrew Lunn <andrew< at >lunn.ch>

to the rest.

 Andrew

Re: [PATCH 00/21] ARM: kirkwood: improve pinmux configs in Device Tree

Thomas Petazzoni — 2013-05-25T13:36:18

Dear Jason Cooper,

On Fri, 24 May 2013 14:33:10 -0400, Jason Cooper wrote:


Ok, thanks!

Thomas

Re: clock framework: Don't disable a clock already enabled by boot loader?

Shawn Guo — 2013-05-25T11:17:49

I do not like the idea to set CLK_IGNORE_UNUSED in clock driver on clk
basis.  If the clk is needed by some driver, why cannot the driver
enable it using clk API?  Or if the clk is some fundamental one that
does not clearly belong to particular IP block and no driver wants to
manage it, we may want to not implement it in clock driver at all and
just leave it to bootloader to set it up for once.

Shawn

[RFC PATCHv4 1/6] arm: TI-Nspire platform code

Daniel Tang — 2013-05-25T11:08:02

Add initial platform support for the TI-Nspire series.

Signed-off-by: Daniel Tang <dt.tangr< at >gmail.com>
---
 arch/arm/Kconfig                   |   2 +
 arch/arm/Kconfig.debug             |  16 +++++
 arch/arm/Makefile                  |   1 +
 arch/arm/include/debug/nspire.S    |  28 +++++++++
 arch/arm/mach-nspire/Kconfig       |  15 +++++
 arch/arm/mach-nspire/Makefile      |   2 +
 arch/arm/mach-nspire/Makefile.boot |   0
 arch/arm/mach-nspire/clcd.c        | 119 +++++++++++++++++++++++++++++++++++++
 arch/arm/mach-nspire/clcd.h        |  14 +++++
 arch/arm/mach-nspire/mmio.h        |  23 +++++++
 arch/arm/mach-nspire/nspire.c      | 117 ++++++++++++++++++++++++++++++++++++
 11 files changed, 337 insertions(+)
 create mode 100644 arch/arm/include/debug/nspire.S
 create mode 100644 arch/arm/mach-nspire/Kconfig
 create mode 100644 arch/arm/mach-nspire/Makefile
 create mode 100644 arch/arm/mach-nspire/Makefile.boot
 create mode 100644 arch/arm/mach-nspire/clcd.c
 create mode 100644 arch/arm/mach-nspire/clcd

[RFC PATCHv4 0/6] arm: Initial TI-Nspire support

Daniel Tang — 2013-05-25T11:08:01

Changes between http://archive.arm.linux.org.uk/lurker/message/20130408.113343.585af217.en.html and v2:
* Added new drivers to support the irqchip and timers on older models.
* Added new device trees to support the other models.

Changes between v2 and v3:
* Clean up keypad driver
* Update copyright messages (2012->2013)
* Added clock driver
* Fix keypad support for classic models
* Fix nspire-classic-timer code to use updated CLOCKSOURCE_OF_DECLARE
* Change CLCD code to use panel capabilities
* Change UART clock to match APB speed
* Support for reset

Changes between v3 and v4:
* Remove redundant clock-names in device tree
* Re-enable bus access to some peripherals on bootup
* Clean up nspire-classic-timer code.
  - Implement a nspire_timer_set_mode function
  - Removed messy IO_MATCHx and CNTL_MATCHx macros
  - Timer starts disabled to begin with
  - Interrupt handling code return IRQ_NONE for spurious interrupts
  - Delete unnessecary shift
* Change clk-nspire to use compatible property to determine IO ty

Re: [PATCH v2] ARM: mm: Get rid of L_PTE_USER ref from PAGE_S2_DEVICE

Marc Zyngier — 2013-05-25T10:02:33

On Fri, 24 May 2013 18:12:39 -0700, Christoffer Dall
<cdall< at >cs.columbia.edu> wrote:
|

Actually, there's a much better solution.

Just get rid of PAGE_S2_DEVICE altogether, as it is completely useless. We
never have to enforce a memory type in S2 that is stronger than the guest's
view. If the guest insists on doing something silly (mapping a device as
normal memory, for example), we really don't have to fix things for them.

See the patch I posted a while ago as part of my pending fixes series:
https://lists.cs.columbia.edu/pipermail/kvmarm/2013-May/005827.html

        M.

Re: [PATCH] ARM: at91: Fix link breakage when !CONFIG_PHY

Alexandre Belloni — 2013-05-25T07:26:56

Hi,

Scrap that, I'll send a v2.

Regards

On 25/05/2013 00:19, Alexandre Belloni wrote:

Re: clock framework: Don't disable a clock already enabled by boot loader?

Dirk Behme — 2013-05-25T07:16:44

Am 25.05.2013 08:54, schrieb Shawn Guo:

Yes, I know ;) But this is slightly different: In the end it disables 
the complete clk_disable_unused() call, i.e. for all unused clocks.

I'd like to set the flag CLK_IGNORE_UNUSED for just one clock. I.e. I 
want to set a flag for an i.MX6 clock, and I want to set it only for 
one clock.

What's the preferred way to do this?

Best regards

Dirk

Re: clock framework: Don't disable a clock already enabled by boot loader?

Shawn Guo — 2013-05-25T06:54:36

Commit 1e43525 (clk: add clk_ignore_unused option to keep boot clocks
on) introduced an option "clk_ignore_unused" for bypassing
clk_disable_unused() call.

Shawn

Re: clock framework: Don't disable a clock already enabled by boot loader?

Dirk Behme — 2013-05-25T05:59:45

Hi Sascha,

Am 25.05.2013 01:00, schrieb Sascha Hauer:

Thanks for the fast answer! :)

Hmm, but what's the best way to set a flag in

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/mach-imx/clk-imx6q.c

?

In mx6q_clocks_init() there doesn't seem to be an explicit interface 
to set the flags?

I'm not sure if

clk[xxx]->flags |= CLK_IGNORE_UNUSED;

is the way to go?

Best regards

Dirk

Re: [PATCH V4] ARM: handle user space mapped pages in flush_kernel_dcache_page

Nicolas Pitre — 2013-05-25T03:53:19


VIVT and highmem do work together.  Highmem for ARM was in fact 
developed on such a platform.


Nicolas

[PATCH v2] ARM: mm: Get rid of L_PTE_USER ref from PAGE_S2_DEVICE

Christoffer Dall — 2013-05-25T01:12:39

THe L_PTE_USER actually has nothing to do with stage 2 mappings and the
L_PTE_S2_RDWR value sets the readable bit, which was what L_PTE_USER
was used for before proper handling of stage 2 memory defines.

Changelog:
 [v2]: Change default mappings to be r/w instead of r/o, as per Marc
       Zyngier's suggestion.

Cc: Marc Zyngier <marc.zyngier< at >arm.com>
Signed-off-by: Christoffer Dall <cdall< at >cs.columbia.edu>
---
 arch/arm/include/asm/pgtable.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index 9bcd262..8afc60c 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
< at >< at > -97,7 +97,7 < at >< at > extern pgprot_tpgprot_s2_device;
 #define PAGE_HYP_MOD_PROT(pgprot_kernel, L_PTE_HYP)
 #define PAGE_HYP_DEVICE_MOD_PROT(pgprot_hyp_device, L_PTE_HYP)
 #define PAGE_S2_MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY)
-#define PAGE_S2_DEVICE_MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY)
+#define PAGE_S2_DEVICE

[v2] ARM: mm: Get rid of L_PTE_USER ref from PAGE_S2_DEVICE

Christoffer Dall — 2013-05-25T01:12:00

THe L_PTE_USER actually has nothing to do with stage 2 mappings and the
L_PTE_S2_RDWR value sets the readable bit, which was what L_PTE_USER
was used for before proper handling of stage 2 memory defines.

Changelog:
 [v2]: Change default mappings to be r/w instead of r/o, as per Marc
       Zyngier's suggestion.

Cc: Marc Zyngier <marc.zyngier< at >arm.com>
Signed-off-by: Christoffer Dall <cdall< at >cs.columbia.edu>
---
 arch/arm/include/asm/pgtable.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index 9bcd262..8afc60c 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
< at >< at > -97,7 +97,7 < at >< at > extern pgprot_tpgprot_s2_device;
 #define PAGE_HYP_MOD_PROT(pgprot_kernel, L_PTE_HYP)
 #define PAGE_HYP_DEVICE_MOD_PROT(pgprot_hyp_device, L_PTE_HYP)
 #define PAGE_S2_MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY)
-#define PAGE_S2_DEVICE_MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY)
+#define PAGE_S2_DEVICE

Re: clock framework: Don't disable a clock already enabled by boot loader?

Sascha Hauer — 2013-05-24T23:00:21

Hi Dirk,

On Fri, May 24, 2013 at 02:44:58PM +0200, Dirk Behme wrote:

Yes, and it's great since after this point the hardware state is in sync
with the enable counter.


You could set the CLK_IGNORE_UNUSED flag in the clock, but I suggest to
just clk_get/clk_enable the clock in the driver using it.

Sascha

[PATCH] ARM: nomadik: move the pin configuration to DT

Linus Walleij — 2013-05-24T21:13:29

This moves the pin configuration for the Nomadik over to the
device tree using Gabriel's bindings. Remove the auxdata
nailing down the name of the pin controller as this is no
longer necessary.

Cc: Gabriel Fernandez <gabriel.fernandez< at >st.com>
Cc: Patrice Chotard <patrice.chotard< at >st.com>
Signed-off-by: Linus Walleij <linus.walleij< at >linaro.org>
---
 arch/arm/boot/dts/ste-nomadik-s8815.dts    | 41 +++++++++++++++
 arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 82 ++++++++++++++++++++++++++++++
 arch/arm/mach-nomadik/cpu-8815.c           | 51 -------------------
 3 files changed, 123 insertions(+), 51 deletions(-)

diff --git a/arch/arm/boot/dts/ste-nomadik-s8815.dts b/arch/arm/boot/dts/ste-nomadik-s8815.dts
index 666945a..638ec8d 100644
--- a/arch/arm/boot/dts/ste-nomadik-s8815.dts
+++ b/arch/arm/boot/dts/ste-nomadik-s8815.dts
< at >< at > -14,6 +14,43 < at >< at >
 bootargs = "root=/dev/ram0 console=ttyAMA1,115200n8 earlyprintk";
 };
 
+pinctrl {
+/* Hog CD pins */
+pinctrl-names = "default";
+pinctrl-0 = <&cd_default_mod

Re: Allwinner sunXi Fixes for 3.10

Olof Johansson — 2013-05-24T20:31:41

On Fri, May 24, 2013 at 12:53 PM, Maxime Ripard
<maxime.ripard< at >free-electrons.com> wrote:

Pulled, but tags/sunxi-fixes-for-3.10 instead, as discussed on IRC.


-Olof

[PATCH 2/2] ARM: imx: clk: No need to initialize phandle struct

Fabio Estevam — 2013-05-24T19:55:42

From: Fabio Estevam <fabio.estevam< at >freescale.com>

commit 84344b43c (ARM: i.MX5: Allow DT clock providers) introduce the following
sparse warning:

arch/arm/mach-imx/clk.c:12:43: warning: Using plain integer as NULL pointer

There is no need to initialize phandle, so remove it.

Cc: Martin Fuzzey <mfuzzey< at >parkeon.com>
Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 arch/arm/mach-imx/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/clk.c b/arch/arm/mach-imx/clk.c
index 53e8788..55bc80a 100644
--- a/arch/arm/mach-imx/clk.c
+++ b/arch/arm/mach-imx/clk.c
< at >< at > -9,7 +9,7 < at >< at > DEFINE_SPINLOCK(imx_ccm_lock);
 
 static struct clk * __init imx_obtain_fixed_clock_from_dt(const char *name)
 {
-struct of_phandle_args phandle = {0};
+struct of_phandle_args phandle;
 struct clk *clk = ERR_PTR(-ENODEV);
 char *path;