gmane.linux.kernel

Re: [PATCH] tty: tty_mutex: fix lockdep warning in tty_lock_pair(v3)

Ming Lei — 2012-05-26T09:23:53


I remember that the patch may cause kernel hang in
my test. I will test it again to see if it is good.


You mean that the below is good usage of lock?

        LOCK A
        LOCK B

        UNLOCK A
        UNLOCK B


Thanks,
--
Ming Lei

Re: [PATCH] STA2X11 CAN: CAN driver for the STA2X11 board

Federico Vaga — 2012-05-26T08:36:10

You are right, this is a C-CAN but it isn't specified on the board manual.
I compared the board manual with the Bosch C-CAN manual, and it is the same.
I'm working on a PCI module for this board, when it is ready we can think for
a generic c_can_pci

Thank you

Re: [PATCH 2/6] amba: use the new linux/sizes.h

Russell King - ARM Linux — 2012-05-26T08:33:56

Please move this up alongside the other linux/ includes.

Re: [rfc][patch] select_idle_sibling() inducing bouncing on westmere

Mike Galbraith — 2012-05-26T08:27:14

On Sat, 2012-05-26 at 09:29 +0200, Peter Zijlstra wrote: 

All better.

Too bad 'enterprise dude' turned cpuhog at 3.0, 'silly tester guy' would
have spotted this instantly.  Hohum, back to finding out what happened
to cpufreq.

[    0.212062] CPU0 attaching sched-domain:
[    0.216016]  domain 0: span 0-1 level MC
[    0.220013]   groups: 0 1
[    0.222664]   domain 1: span 0-3 level CPU
[    0.225754]    groups: 0-1 (cpu_power = 2048) 2-3 (cpu_power = 2048)
[    0.233859] CPU1 attaching sched-domain:
[    0.236015]  domain 0: span 0-1 level MC
[    0.241673]   groups: 1 0
[    0.244385]   domain 1: span 0-3 level CPU
[    0.248016]    groups: 0-1 (cpu_power = 2048) 2-3 (cpu_power = 2048)
[    0.254219] CPU2 attaching sched-domain:
[    0.256016]  domain 0: span 2-3 level MC
[    0.261673]   groups: 2 3
[    0.264578]   domain 1: span 0-3 level CPU
[    0.268016]    groups: 2-3 (cpu_power = 2048) 0-1 (cpu_power = 2048)
[    0.276020] CPU3 attaching sched-domain:
[    0.279929]  domain 0: span 2-3 level MC
[

Re: [PATCH 6/6] serial: add amba-pl011-pci

Alessandro Rubini — 2012-05-26T07:58:55

Yes, it's possible. Actually, this was my longer-time plan: propose a
factorization when more of those were ready.  So I'll remove the
special name in the device and offer an implementation as generic
as possible.

BTW, are the prerequisite patches of with you?

thanks
/alessandro

[GIT PULL FOR v3.5] Move sta2x11_vip to staging

Hans Verkuil — 2012-05-26T07:39:58

Mauro,

This patch moves the sta2x11_vip driver to the staging directory. In my opinion
this driver is not ready for prime-time.

As I mentioned a week ago, I never saw this driver when it was posted as that
was during a period were I was unavoidably absent from the list. The problem
with this driver is that it doesn't use any of the new frameworks (the control
framework and videobuf2 in particular), and this should be corrected first.

In addition it has a clear V4L2 API violation in that only one filehandle at
a time can open the video node. Developers really *must* run v4l2-compliance
before posting a new driver! Almost all of this would be caught by that tool
(except for using videobuf instead of vb2). Personally I think showing the
output of v4l2-compliance should be a requirement for getting a driver merged
under drivers/media/video.

I didn't get any reply from Federico when I posted my concerns last week, so
that makes me unhappy as well.

I hope the author will fix these issues, but in the meantime

Re: [PATCH 6/6] serial: add amba-pl011-pci

Arnd Bergmann — 2012-05-26T07:39:31

Aside from the dma mask, this looks almost entirely generic. Would it
be possible to make this a generic pci-amba driver that lives under
drivers/amba/ and does not care about the type of device behind it?

Arnd

[PATCH 2/2] remoteproc: remove the now-redundant kref

Ohad Ben-Cohen — 2012-05-26T07:36:31

Now that every rproc instance contains a device, we don't need a
kref anymore to maintain the refcount of the rproc instances:
that's what device are good with!

This patch removes the now-redundant kref, and switches to
{get, put}_device instead of kref_{get, put}.

We also don't need the kref's release function anymore, and instead,
we just utilize the class's release handler (which is now responsible
for all memory de-allocations).

Cc: Stephen Boyd <sboyd< at >codeaurora.org>
Cc: Fernando Guzman Lugo <fernando.lugo< at >ti.com>
Signed-off-by: Ohad Ben-Cohen <ohad< at >wizery.com>
---
 drivers/remoteproc/remoteproc_core.c   |   59 +++++++++++---------------------
 drivers/remoteproc/remoteproc_virtio.c |    8 ++--
 include/linux/remoteproc.h             |    3 --
 3 files changed, 24 insertions(+), 46 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 9e3d4cf..7214393 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
< at >< at >

Re: [rfc][patch] select_idle_sibling() inducing bouncing on westmere

Peter Zijlstra — 2012-05-26T07:29:24



Oh yikes, I guess I wrecked
arch/x86/kernel/smpboot.c:cpu_coregroup_mask() in
8e7fbcbc22c12414bcc9dfdd683637f58fb32759.

That should very much always return llc mask, I just got that AMD case
confused. It looks like it should look like:


const struct cpumask *cpu_coregroup_mask(int cpu)
{
return cpu_llc_mask(cpu);
}

And the AMD_DCM check was just to undo powersavings damage on
Magny-Cours or somesuch.

Andreas?

[GIT PULL 2/8] arm-soc: driver specific updates

Olof Johansson — 2012-05-26T07:22:32

These changes are specific to some driver that may be used by multiple
boards or socs. The most significant change in here is the move of the
samsung iommu code from a platform specific in-kernel interface to the
generic iommu subsystem.

----------------------------------------------------------------

The following changes since commit cfda982fa8b2affe2b42ab5bb7d5737736fa8caf:

  Merge tag 'defconfig' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/drivers

for you to fetch changes up to 046fae440d32cc6dec8148c7e06a8b4b987f8a2f:

  Merge branch 'next/devel-samsung-iommu' of git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung into next/drivers

----------------------------------------------------------------

Allen Martin (1):
      ARM: tegra: Add pllc clock init table

Arnd Bergmann (7):
      Merge branch 'keyboard' of git://github.com/hzhuang1/linux into nex

[GIT PULL 3/8] arm-soc: cleanups, part 2

Olof Johansson — 2012-05-26T07:22:33

More cleanups, continuing an earlier set with omap and samsung specific
cleanups. These could not go into the first set because they have
dependencies on various other series that in turn depend on the first
cleanups.

----------------------------------------------------------------

The following changes since commit 2f31a25ab6ccffb07990e36576fc47f4b6661ccf:

  Merge tag 'drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/cleanup2

for you to fetch changes up to 424663566c43ce87e8b33228860bf882f1ea61bf:

  Merge branch 'next/cleanup-plat-s3c24xx-s5p' of git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung into next/cleanup2

----------------------------------------------------------------

Arnd Bergmann (2):
      Merge branch 'exynos/sysmmu' into next/cleanup2
      Merge branch 'next/cleanup-plat-s3c24xx-s5p' of git://git.kernel.org/.../kgene/linux-samsun

[GIT PULL 4/8] arm-soc: clock driver changes

Olof Johansson — 2012-05-26T07:22:34

The new clock subsystem was merged in linux-3.4 without any users, this
now moves the first three platforms over to it: imx, mxs and spear.

The series also contains the changes for the clock subsystem itself,
since Mike preferred to have it together with the platforms that require
these changes, in order to avoid interdependencies and conflicts.

----------------------------------------------------------------

The following changes since commit d4a80a59ed34bd8c099099e8a8320f49a7e6dc7a:

  Merge tag 'cleanup2' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/clock

for you to fetch changes up to 3c0dec5f58b3c7b3627715126d1bf9b030a076f0:

  Merge branch 'clk-next' of git://git.linaro.org/people/mturquette/linux into next/clock

----------------------------------------------------------------

Andrew Lunn (14):
      ARM: Orion: Add clocks using the generic clk infrastructure.

[GIT PULL 5/8] arm-soc: add stmp-dev library code

Olof Johansson — 2012-05-26T07:22:35

A number of devices are using a common register layout, this adds support
code for it in lib/stmp_device.c so we do not need to duplicate it in
each driver.

----------------------------------------------------------------

The following changes since commit 0ac1de7ff6397b16530c23fcd31961a21498cff0:

  Merge tag 'clock' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/stmp-dev

for you to fetch changes up to 3f81b2c49d31e763a9c1da831ceb6cef087cf6c6:

  Merge branch 'stmp_device' of git://git.pengutronix.de/git/wsa/linux into next/stmp-dev

----------------------------------------------------------------

Arnd Bergmann (1):
      Merge branch 'stmp_device' of git://git.pengutronix.de/git/wsa/linux into next/stmp-dev

Wolfram Sang (2):
      lib: add support for stmp-style devices
      i2c: mxs: use global reset function


 drivers/i2c/busses/Kconfig   |  1 +
 drivers/i2c/busses

[GIT PULL 7/8] arm-soc: soc specific changes, part 2

Olof Johansson — 2012-05-26T07:22:37

This adds support for the spear13xx platform, which has first been under
review a long time ago and finally been completed after generic spear
work has gone into the clock, dt and pinctrl branches.

Also a number of updates for the samsung socs are part of this branch.

----------------------------------------------------------------

The following changes since commit 56e16c5e06b624d0ec7e958b212c368864a78504:

  Merge tag 'dt2' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/soc2

for you to fetch changes up to 820f3dd7964f1889baaaaa0c2ba45d05bb619f66:

  ARM: exynos: fix building with CONFIG_OF disabled

----------------------------------------------------------------

Arnd Bergmann (6):
      Merge branch 'spear/13xx' into next/soc2
      Merge branch 'exynos/iommu' into next/soc2
      Merge branch 'next/devel-samsung' of git://git.kernel.org/.../kgene/linux-samsung into n

[GIT PULL 8/8] arm-soc: sweeping late_initcall cleanup

Olof Johansson — 2012-05-26T07:22:38

This is a patch series from Shawn Guo that moves from individual
late_initcalls() to using a member in the machine structure to invoke
a platform's late initcalls.

This cleanup is a step in the move towards multiplatform kernels since
it would reduce the need to check for compatible platforms in each and
every initcall.

----------------------------------------------------------------

The following changes since commit 7ff2e2e928102ba1bd0d375a649dec5980c3a130:

  Merge tag 'soc2' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/cleanup-initcall

for you to fetch changes up to 80b9abf973462499c1a0110df47f62cc90361e2c:

  Merge branch 'clean/late_initcall_v2' of git://git.linaro.org/people/shawnguo/linux-2.6 into staging/cleanup

----------------------------------------------------------------

Olof Johansson (1):
      Merge branch 'clean/late_initcall_v2' of git://git.linaro.

[GIT PULL 6/8] arm-soc: device tree conversions, part 2

Olof Johansson — 2012-05-26T07:22:36

These continue the device tree work from part 1, this set is for the
tegra, mxs and imx platforms, all of which have dependencies on clock
or pinctrl changes submitted earlier.

----------------------------------------------------------------

The following changes since commit 672b9ea0bd2e9c8ac957b888cdb08d1f29d332e8:

  Merge tag 'stmp-dev' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into HEAD

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/dt2

for you to fetch changes up to deb88cc3c69975cbd9875ed9fac259b351f6b64d:

  Merge branch 'drivers/mmc' into next/dt2

----------------------------------------------------------------

Arnd Bergmann (4):
      Merge branch 'imx/pinctrl' into imx/dt
      Merge branch 'imx/dt/for-3.5' of git://git.linaro.org/people/shawnguo/linux-2.6.git into next/dt2
      Merge branch 'for-3.5/dt2' of git://git.kernel.org/.../swarren/linux-tegra into for-next
      Merge branch 'drivers/mmc' into next/d

[GIT PULL 1/8] arm-soc: defconfig updates

Olof Johansson — 2012-05-26T07:22:31

For the first time, we have one branch that collects just updates to
defconfig files, mostly for adapting to changes in other subsystems.

----------------------------------------------------------------

The following changes since commit 786f02b719f2285e2c0350b6a04dab4a1a0871a1:

  Merge tag 'x86-mce-merge' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/defconfig

for you to fetch changes up to 4a230408e83698a3d7ff0a9988a58675c2c92cb9:

  ARM: PRIMA2: add prima2_defconfig for CSR SiRFprimaII

----------------------------------------------------------------

Arnd Bergmann (2):
      Merge tag 'imx-defconfig' of git://git.pengutronix.de/git/imx/linux-2.6 into next/defconfig
      Merge branch 'for-3.5/defconfig2' of git://git.kernel.org/.../swarren/linux-tegra into next/defconfig

Barry Song (1):
      ARM: PRIMA2: add prima2_defconfig for CSR SiRFprimaII

Fabio Estevam (2):
      ARM: imx

[GIT PULL 0/8] Second batch of arm-soc branches for 3.5

Olof Johansson — 2012-05-26T07:22:30

Hi Linus,

This is the second and last large set of arm-soc branches for the 3.5
merge window. There will likely be a couple of small pull requests next
week (and thereafter fixes).

Descriptions of each branch are in the corresponding request.

Most of them have some trivial merge conflicts with earlier branches or
other code that has gone in since they were staged. Notes below are for
the slightly trickier cases. Just like with the last batch I've pushed
up resolved/<tagname> branches with proposed resolutions if you want
to compare.

cleanup2 branch:
omap_init_clocksource_32k(): Keep the version from this branch but add
in the register_persistent_clock() addition from bd0493e.

clock branch:
An awkward add/remove conflict in mach-kirkwood/common.c. Code is removed
here that was fixed in one of our earlier branches. The right thing to
do is to still just remove the code.

dt2 branch:
gpio-mxs.c: Keep the (port) side but change false -> 0 on the last arg.

soc2 branch:
gpio-samsung.c: Slightly awkward move/

Re: [PATCH] tty: tty_mutex: fix lockdep warning in tty_lock_pair(v3)

Peter Zijlstra — 2012-05-26T07:16:04


Oh very much not!




I've still to hear what's wrong with a simple:


  if (!tty2 || tty == tty2) {
tty_lock(tty);
return;
  }

  if (tty > tty2)
swap(tty, tty2);

  tty_lock(tty);
  tty_lock_nested(tty2, SINGLE_DEPTH_NESTING);


That's a lot more readable than the proposed code.


This is complete crap, unlock order doesn't matter.

Re: [PATCH 12/13] backlight: tosa_bl: use devm_ functions

Dmitry Eremin-Solenikov — 2012-05-26T06:43:07

Strictly speaking I see no point in this changes. There are no
'missing free' problems
in these drivers, the code path is clean enough. Is devm_kzalloc usage some kind
of policy, or it is just a future-proof change?

Re: [rfc][patch] select_idle_sibling() inducing bouncing on westmere

Mike Galbraith — 2012-05-26T06:37:39

On Fri, 2012-05-25 at 08:14 +0200, Mike Galbraith wrote: 

Ew. 3.4 went broke for Q6600, and performance went... far far away.

[    0.200057] CPU0 attaching sched-domain:
[    0.204016]  domain 0: span 0-3 level MC
[    0.208015]   groups: 0 1 2 3
[    0.210970] CPU1 attaching sched-domain:
[    0.212014]  domain 0: span 0-3 level MC
[    0.216016]   groups: 1 2 3 0
[    0.220016] CPU2 attaching sched-domain:
[    0.224015]  domain 0: span 0-3 level MC
[    0.228016]   groups: 2 3 0 1
[    0.232015] CPU3 attaching sched-domain:
[    0.236016]  domain 0: span 0-3 level MC
[    0.240017]   groups: 3 0 1 2

11.791806 usecs/loop -- avg 11.534552 173.4 KHz

Cause: sometimes during boot, hw Siamese twins are 0-1 2-3, and
sometimes, as in this boot, 0-3 1-2, so busted groups above does the
worst thing possible.  When twins are 0-1 2-3, busted groups doesn't
matter with $subject patch applied, it glues Siamese twins back
together.  During this boot, it created Siamese aliens from hell.

-Mike