gmane.linux.kernel

Re: [PATCH 2/5] Add aix lvm partitions support files

Philippe De Muyter — 2013-05-21T07:27:54

Hi Andrew,

On Mon, May 20, 2013 at 04:39:27PM -0700, Andrew Morton wrote:

AIX LVM permits to make "logical volumes" which are made of multiple slices
of multiple disks.  The new code allows only access to the "logical volumes"
which are made of one slice on the probed disk, a slice being a contiguous
disk area.  The code also detects "logical volumes" made of multiple slices
on the probed disk, but can not describe them to the partition layer, because
the partition layer generic code does not support that.  When such
non-contiguous "logical volumes" are detected, a diagnostic message is
printed.

Philippe

Re: [RFC 0/7] perf report/gtk: Add support for hierarchy view

Namhyung Kim — 2013-05-21T07:26:25

Hi Pekka,

On Tue, 21 May 2013 10:04:05 +0300, Pekka Enberg wrote:

Yes, I think it's doable.  I don't have an idea how to use both of the
features at the same time though.  Anyway, I'll try to add support for
callchains later.

Thanks,
Namhyung

Re: [PATCH 3/5] partitions/msdos: enumerate also AIX LVM partitions

Philippe De Muyter — 2013-05-21T07:16:04

Hi Andrew,

On Mon, May 20, 2013 at 04:41:52PM -0700, Andrew Morton wrote:

Well, PowerPC BIOS (PPCBUG or Open Firmware) mimics PC BIOS and requires the
first block of the disk to describe the boot partition the same way that
PC BIOS does.  Remember, the aim of IBM, Motorola and Apple was to replace
the PC's by PowerPC's :).  So, an AIX disk can erroneously be recognized as
a dos disk with two partitions (two times the same boot partition).  That's
the reason why there is already code in block/partitions/msdos.c to avoid
that.

I didn't want to remove the AIX protection from msdos.c, for the likely case
that someone would compile the kernel without AIX_PARTITION support,  And, as
a part of the AIX detection was already done by 'aix_magic_present', I did
not want to duplicate it.  I can move the AIX detection logic to aix.c and
still keep the AIX protection for msdos.c with some more #ifdef's if you prefer.

Philippe

Re: [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

David Miller — 2013-05-21T07:14:44

From: "Eilon Greenstein" <eilong< at >broadcom.com>
Date: Tue, 21 May 2013 10:06:43 +0300


I think in two or three more iterations it will be merged.

There are no objections on the fundamentals, it's just implementation
details and coding style at this point.

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

David Miller — 2013-05-21T07:13:15

From: Thomas Petazzoni <thomas.petazzoni< at >free-electrons.com>
Date: Tue, 21 May 2013 08:41:08 +0200


Even better.

Re: [PATCH 1/1] numa, mm, memory-hotplug: Do not allocate pagetable to local node with MEMORY_HOTREMOVE enabled.

Tang Chen — 2013-05-21T07:12:53

Hi

On 05/21/2013 03:02 PM, Pekka Enberg wrote:
......

Please refer to the following patch-set.
https://lkml.org/lkml/2013/4/11/829

patch21 and patch22 will allocate pagetable to local, which may cause
memory hot-remove fail.

But this patch-set is not in the mainline now.

Thanks. :)

[GIT PULL] s390 patches for the 3.10-rc3

Martin Schwidefsky — 2013-05-21T07:06:17

Hi Linus,

please pull from the 'for-linus' branch of

git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus

to receive the following updates:
An additional sysfs attribute for channel paths and a couple of bux fixes.

Alexander Shiyan (1):
      s390: remove non existent reference to GENERIC_KERNEL_THREAD

Christian Borntraeger (4):
      s390: disable pfmf for clear page instruction
      s390: fix gmap_ipte_notifier vs. software dirty pages
      s390/xpram: mark xpram as non-rotational
      s390/pgtable: fix ipte notify bit

Heiko Carstens (2):
      s390/disassembler: prevent endless loop in print_fn_code()
      s390/ftrace: fix mcount adjustment

Martin Schwidefsky (1):
      s390/smp: fix cpu re-scan vs. cpu state

Peter Oberparleiter (1):
      s390/cio: add channel ID sysfs attribute

 arch/s390/Kconfig               |    1 -
 arch/s390/include/asm/ftrace.h  |   12 +++++++-----
 arch/s390/include/asm/page.h    |   20 ++++++++------------
 arch/s390/include/asm/pgtable.h |    4 +

Re: [RFC 0/7] perf report/gtk: Add support for hierarchy view

Pekka Enberg — 2013-05-21T07:04:05

Hello,

On Tue, May 21, 2013 at 9:14 AM, Namhyung Kim <namhyung< at >kernel.org> wrote:

Can use this infrastructure to support call-graphs in the GTK UI?

                        Pekka

Re: [PATCH 1/1] numa, mm, memory-hotplug: Do not allocate pagetable to local node with MEMORY_HOTREMOVE enabled.

Pekka Enberg — 2013-05-21T07:02:45

Ugh. Special-casing for CONFIG_MEMORY_HOTPLUG is just begging for
trouble. Were you able to determine which commit broke memory
hot-remove?

Re: [RFC PATCH 6/8] kthread: Enable parking requests from setup() and unpark() callbacks

Srivatsa S. Bhat — 2013-05-21T06:59:25

unpark() can already do a proper park, because immediately after
coming out of the parked state, the 'continue' statement helps
re-evaluate the stop/park condition.

So this fix is only for the ->setup() case.


Sounds good to me.

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat< at >linux.vnet.ibm.com>

But I wonder what nmi_watchdog=0 should actually mean, semantically..
The current code works as if the user asked us not to run the watchdog
threads, but it could as well be interpreted as if the user does not
want to run *any* watchdog-related *code*. In that case, ideally we
should *unregister* the watchdog threads, instead of just parking them.
And when the user enables them again via sysctl/procfs, we should
register the watchdog threads with the smpboot infrastructure.

I'm not saying that the current semantics is wrong, but if we really
implement it the other way I proposed above, then we won't have to deal
with weird issues like ->setup() code wanting to park, and watchdog
threads unparking and parking thems

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

Geert Uytterhoeven — 2013-05-21T06:57:36

No, you missed "and we can remove the long list of architectures from the
current option".


I strongly support CONFIG_HAVE_VGA_CONSOLE.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert< at >linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] sched: wake-affine throttle

Michael Wang — 2013-05-21T06:52:21

Got it, thanks for your review :)

Regards,
Michael Wang

Re: [PATCH v2] sched: wake-affine throttle

Alex Shi — 2013-05-21T06:47:27

You can change CC to
Reviewed-by: Alex Shi <alex.shi< at >intel.com>

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

Thomas Petazzoni — 2013-05-21T06:41:08

Dear David Miller,

On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote:

Or, maybe make the existing module_platform_driver() macro do this?

Best regards,

Thomas

Re: [PATCH 1/3] imx-drm: imx-tve: Check the return value of 'regulator_enable()'

Sascha Hauer — 2013-05-21T06:38:08

All three:

Acked-by: Sascha Hauer <s.hauer< at >pengutronix.de>

Sascha

Re: [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat

Olof Johansson — 2013-05-21T06:31:39

Done.

Thanks,

-Olof

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

David Miller — 2013-05-21T06:26:19

From: Libo Chen <libo.chen< at >huawei.com>
Date: Tue, 21 May 2013 10:42:00 +0800


Instead of doing it this way, which is obviously error prone and
easy to forget, make platform_driver_register() be a macro which
sets the module owner field then calls the real __platform_driver_register().

Re: [GIT PULL] at91: fixes for 3.10 #1

Olof Johansson — 2013-05-21T06:25:27

Pulled, thanks.


-Olof

[PATCH 8/8] rtc: rtc-sh: use devm_*() functions

Jingoo Han — 2013-05-21T06:18:54

Use devm_*() functions to make cleanup paths simpler.

Signed-off-by: Jingoo Han <jg1.han< at >samsung.com>
---
 drivers/rtc/rtc-sh.c |   72 +++++++++++++++-----------------------------------
 1 file changed, 21 insertions(+), 51 deletions(-)

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index cb2f839..6d87e26 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
< at >< at > -593,7 +593,7 < at >< at > static int __init sh_rtc_probe(struct platform_device *pdev)
 char clk_name[6];
 int clk_id, ret;
 
-rtc = kzalloc(sizeof(struct sh_rtc), GFP_KERNEL);
+rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL);
 if (unlikely(!rtc))
 return -ENOMEM;
 
< at >< at > -602,9 +602,8 < at >< at > static int __init sh_rtc_probe(struct platform_device *pdev)
 /* get periodic/carry/alarm irqs */
 ret = platform_get_irq(pdev, 0);
 if (unlikely(ret <= 0)) {
-ret = -ENOENT;
 dev_err(&pdev->dev, "No IRQ resource\n");
-goto err_badres;
+return -ENOENT;
 }
 
 rtc->periodic_irq = ret;
< at >< at > -613,24 +612,21 < at >< at > static int __init sh_rtc_pr

[PATCH 7/8] rtc: rtc-rx8025: use devm_*() functions

Jingoo Han — 2013-05-21T06:18:32

Use devm_*() functions to make cleanup paths simpler.

Signed-off-by: Jingoo Han <jg1.han< at >samsung.com>
---
 drivers/rtc/rtc-rx8025.c |   18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
index 0722d36..8fa23ea 100644
--- a/drivers/rtc/rtc-rx8025.c
+++ b/drivers/rtc/rtc-rx8025.c
< at >< at > -549,7 +549,7 < at >< at > static int rx8025_probe(struct i2c_client *client,
 goto errout;
 }
 
-rx8025 = kzalloc(sizeof(*rx8025), GFP_KERNEL);
+rx8025 = devm_kzalloc(&client->dev, sizeof(*rx8025), GFP_KERNEL);
 if (!rx8025) {
 dev_err(&adapter->dev, "failed to alloc memory\n");
 err = -ENOMEM;
< at >< at > -562,7 +562,7 < at >< at > static int rx8025_probe(struct i2c_client *client,
 
 err = rx8025_init_client(client, &need_reset);
 if (err)
-goto errout_free;
+goto errout;
 
 if (need_reset) {
 struct rtc_time tm;
< at >< at > -572,12 +572,12 < at >< at > static int rx8025_probe(struct i2c_client *client,
 rx8025_set_time(&client->dev, &tm);
 }
 
-rx8025->rtc = rtc_dev

[PATCH 6/8] rtc: rtc-pxa: use devm_*() functions

Jingoo Han — 2013-05-21T06:18:14

Use devm_*() functions to make cleanup paths simpler.

Signed-off-by: Jingoo Han <jg1.han< at >samsung.com>
---
 drivers/rtc/rtc-pxa.c |   43 ++++++++++++-------------------------------
 1 file changed, 12 insertions(+), 31 deletions(-)

diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index ed037ae..a355f2b 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
< at >< at > -324,37 +324,35 < at >< at > static int __init pxa_rtc_probe(struct platform_device *pdev)
 int ret;
 u32 rttr;
 
-pxa_rtc = kzalloc(sizeof(struct pxa_rtc), GFP_KERNEL);
+pxa_rtc = devm_kzalloc(dev, sizeof(*pxa_rtc), GFP_KERNEL);
 if (!pxa_rtc)
 return -ENOMEM;
 
 spin_lock_init(&pxa_rtc->lock);
 platform_set_drvdata(pdev, pxa_rtc);
 
-ret = -ENXIO;
 pxa_rtc->ress = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 if (!pxa_rtc->ress) {
 dev_err(dev, "No I/O memory resource defined\n");
-goto err_ress;
+return -ENXIO;
 }
 
 pxa_rtc->irq_1Hz = platform_get_irq(pdev, 0);
 if (pxa_rtc->irq_1Hz < 0) {
 dev_err(dev, "No 1Hz IRQ