gmane.linux.ide

Re: [PATCH] Resurrect IT8172 IDE controller driver

Shane McDonald — 2008-12-04T03:08:30

On Mon, Nov 24, 2008 at 7:38 AM, Sergei Shtylyov ru.mvista.com> wrote: The spec says that PIO mode 0 is supported, but Sergei is correct -- the maximum values give a cycle time of 480 ns. How can this be? The old driver appeared to have tried to support PIO mode 0 by setting to the maximum. Which fast timing bits are documented as reserved? My spec has the IDE Drive 0/1 Recovery Time and IDE Drive 0/1 Pulse Width bits in it. Are there other timing bits that aren't documented in my spec? Please excuse my dumb question -- I'm a little over my head here. Shane -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Resurrect IT8172 IDE controller driver

Shane McDonald — 2008-12-04T02:39:56

Hello: I have made some of the required changes, but I have some questions. See in-line for my resolution / questions for each comment. On Mon, Nov 24, 2008 at 4:33 AM, Sergei Shtylyov ru.mvista.com> wrote: OK, I will update accordingly. Ah yes, the prototypes were removed, but not the comment. I will remove this. I don't believe it can be dropped entirely -- although the controller only has a single channel, it does support two drives on that channel. Unless I understand incorrectly, I will make the "drive->dn & 1" change. I will remove it, and the associated spin_unlock_irqrestore. I will change. Although, the change to the pulse width of DIOR/DIOW doesn't seem that difficult to make. Maybe I should just go ahead and do that. I will update the comment to reflect reality, unless I implement the FIXME. Hmmm, that's right, that is what the code is doing. I will update the comment accordingly. The specs I have indicate that it is not the same. For example, bits 13:12 in t

[PATCH-mm 2/2] ata: replace byteshifting with unaligned endian helpers

Harvey Harrison — 2008-12-03T18:13:40

Signed-off-by: Harvey Harrison gmail.com> --- Depends on the unaligned access work in -mm. drivers/ata/libata-scsi.c | 50 ++++++-------------------------------------- 1 files changed, 7 insertions(+), 43 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index d763b2b..1c16b63 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c < at >< at > -46,6 +46,7 < at >< at > #include #include #include +#include #include "libata.h" < at >< at > -1384,19 +1385,10 < at >< at > static unsigned int ata_scsi_flush_xlat(struct ata_queued_cmd *qc) */ static void scsi_6_lba_len(const u8 *cdb, u64 *plba, u32 *plen) { -u64 lba = 0; -u32 len; - VPRINTK("six-byte command\n"); -lba |= ((u64)(cdb[1] & 0x1f)) << 16; -lba |= ((u64)cdb[2]) << 8; -lba |= ((u64)cdb[3]); - -len = cdb[4]; - -*plba = lba; -*plen = len; +*plba = load_be32_noalign((__be32 *)&cdb[0]) & 0x1fffff; +*plen = cdb[4]; } /** < at >< at > -1411,21 +1

Re: [PATCH] remove ide-scsi

James Bottomley — 2008-12-03T15:09:00

Depends. If you're still using drivers/ide then yes, it is. With libata (which is what most modern distros use), osst just works as an ATAPI transport. git log tells me ide-scsi has been updated quite a bit recently, but it mostly looks to be fallout around the drivers/ide churn. Can we get ide maintainer's buy in for this (I think they've been maintaining ide-tape and ide-cd in preference to ide-scsi)? James -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] remove ide-scsi

Christoph Hellwig — 2008-12-03T10:06:43

Isn't ide-scsi the only way to use ATAPI OnStream tapes supported by the osst driver? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ST31500341AS vs ICH10, exception Emask 0x50 SAct 0x1 SErr 0x280900 action 0x6 frozen

Tejun Heo — 2008-12-03T03:00:12

hello, Soeren Sonnenburg wrote: Your machine seems to be suffering genuine link layer problem. In most cases, this indicates hardware problem and in my experience common causes are (in the order of ballpark frequency)... 1. inadequate power supply 2. device and controller don't like each other on 3Gbps 3. cable too long or flaky connector (especially w/ eSATA cables or genders or backplanes) 4. faulty controller or drive

[Bug 10216] kernel from different versions hangs with some CD/DVD drives

2008-12-02T20:23:25

http://bugzilla.kernel.org/show_bug.cgi?id=10216 ------- Comment #30 from sshtylyov< at >ru.mvista.com 2008-12-02 12:23 ------- (In reply to comment #29) I keep been overloaded for months already...

[git pull] IDE fixes for 2.6.28-rc7

Bartlomiej Zolnierkiewicz — 2008-12-02T20:02:14

* amd74xx host driver fix for nVidia controllers (this should take care of most bugreports about ATAPI devices not working properly) [ libata developers are encouraged to copy the fix to pata_amd (the issue manifests itself with pata_amd reporting diagnostics failure on good devices) ] * quirk for SAMSUNG SP0822N with firmware WA100-10 to allow UDMA > 33 * fix ide_release_lock imbalance for Atari (from Michael Schmitz) + few misc fixes Linus, please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/alim15x3.c | 2 +- drivers/ide/amd74xx.c | 11 ++++++++++- drivers/ide/ide-io.c | 30 ++++++++++++++---------------- drivers/ide/ide-iops.c | 9 +++------ drivers/ide/ide-probe.c | 3 ++- include/linux/ide.h | 8 ++++++++ 6 files changed, 38 insertions(+), 25 deletions(-) Bartlomiej Zolnierkiewicz (5): amd74xx: workaround unreliable AltStatus register for nVidia controllers ide: add

[Bug 10216] kernel from different versions hangs with some CD/DVD drives

2008-12-02T19:19:21

http://bugzilla.kernel.org/show_bug.cgi?id=10216 ------- Comment #29 from bzolnier< at >gmail.com 2008-12-02 11:19 ------- Lars: thanks for testing, I updated patch description accordingly. Sergei: seems so, could you make a patch for it?

Re: ST31500341AS vs ICH10, exception Emask 0x50 SAct 0x1 SErr0x280900 action 0x6 frozen

Soeren Sonnenburg — 2008-12-02T14:05:53

OK, if this happens again I will try a new cable. However, the backplane (it is this one: http://www.raidsonic.de/en/pages/products/backplanes.php?we_objectID=4251 ) was working nicely with another disk in the same slot (but maybe I did not perfectly insert the disk...) Yes. This is actually the only difference to the drive before (which was 1.5 Gbps). For now it is all running nicely and I did a full dd if= ... read of the disk: ata3: SATA max UDMA/133 irq_stat 0x00400040, connection status changed irq 510 ata3: SATA link up 3.0 Gbps (SStatus 123 SControl 300) ata3.00: HPA detected: current 2930277168, native 18446744072344861488 ata3.00: ATA-8: ST31500341AS, CC1G, max UDMA/133 ata3.00: 2930277168 sectors, multi 0: LBA48 NCQ (depth 31/32) ata3.00: configured for UDMA/133 Thank you very much!! Soeren -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Promise PDC20376

David Ellingsworth — 2008-12-02T13:36:25

Right, with LBA28 addressing you get 2^28 sector addresses = 2^27 KiB = 2^17 MiB = 2^7 GiB = 128 GiB which is approximately 137GB. When I wrote 128GB I really meant 128 GiB. Regards, David Ellingsworth P.S. I hate the "new" binary size notations they only cause confusion. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ST31500341AS vs ICH10, exception Emask 0x50 SAct 0x1 SErr 0x280900 action 0x6 frozen

Justin Piszcz — 2008-12-02T09:49:18

On Tue, 2 Dec 2008, Soeren Sonnenburg wrote: A few items: res 40/00:00:48:19:67/00:00:1e:00:00/40 Emask 0x50 (ATA bus error) ata3: SError: { UnrecovData HostInt 10B8B BadCRC } These are usually realted to a bad cable or connector. ata3: SATA link up 1.5 Gbps (SStatus 113 SControl 310) Did you remove the 1.5 Gbps jumper so it can run at 3.0 Gbps? Justin. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Promise PDC20376

David Ellingsworth — 2008-12-02T01:43:38

A small update to this. It seems the above mentioned interrupt fails somewhere around the 128GB boundary. Interrupt 13h, AH=42 uses a 64 bit sector address and should be capable of addressing the entire drive. For a SATA controller, this limitation seems relatively arbitrary. For IDE controllers, a limitation such as this is apparently common. Regards, David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH #upstream-fixes] ata_piix: add borked Tecra M4 to broken suspend list

Jeff Garzik — 2008-12-01T19:24:44

applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pata-rb532-cf: fix signature of the xfer function

Jeff Garzik — 2008-12-01T19:24:35

Re: [PATCH] pata-rb532-cf: fix and rename register definitions

Jeff Garzik — 2008-12-01T19:24:25

Re: [PATCH #upstream-fixes] libata: blacklist Seagate drives which time out FLUSH_CACHE when used with NCQ

Jeff Garzik — 2008-12-01T19:24:15

[git patches] libata fixes

Jeff Garzik — 2008-12-01T19:06:53

1) pata_rb532_cf significant fixes 2) laptop- and drive-specific workarounds Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c | 15 +++++++++++++++ drivers/ata/libata-core.c | 21 +++++++++++++++++++++ drivers/ata/pata_rb532_cf.c | 15 ++++++++++----- include/linux/libata.h | 1 + 4 files changed, 47 insertions(+), 5 deletions(-) Phil Sutter (2): [libata] pata_rb532_cf: fix and rename register definitions [libata] pata_rb532_cf: fix signature of the xfer function Tejun Heo (2): ata_piix: add borked Tecra M4 to broken suspend list libata: blacklist Seagate drives which time out FLUSH_CACHE when used with NCQ diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index 8e37be1..d6d97d8 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c < at >< at > -1066,6 +1066,21 < at >< at > static int piix_broken_suspend(void) if (dmi_f

Re: [PATCH #upstream-fixes] sata_promise: request follow-up SRST

Peter Favrholdt — 2008-11-30T15:06:23

Hi Mikael and list, Mikael Pettersson wrote: > ...snip... > Testers welcome. I don't have physical access to my system at the moment, and some channels/drives had already failed during previous testing. Without a proper power-cycle the system did not recover the failed channels when rebooted into 2.6.28-rc6 with your patch :-( Best regards, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: about TRIM/DISCARD support and barriers

Tejun Heo — 2008-11-29T22:57:36

hello, Raz Ben-Yehuda wrote: Not that I know of. FTL (flash translation layer) in SSDs can do better job if the OS tells it which area is unused so that the SSD can just drop or overwrite those regions.

Re: [PATCH #upstream-fixes] sata_promise: request follow-up SRST

Mikael Pettersson — 2008-11-29T21:50:39

> hrm.... at this point we have deviated massively from the standard > Promise method of hard reset... > > * set PMP port > * make hotplug irqs > * reset port# in PDC_GLOBAL_CTL > * pdc_reset_port() > * reset FPDMA -- probably a good idea even if not doing FPDMA > * clear SATA Error register (0xffffffff) > * clear errors-reported-from-link-layer register > * wait standard length of time for SATA connection > * clear hotplug bits > * set PMP port > > The PDC_GLOBAL_CTL bitbang is the most notable missing element in the I assume you meant the PCI control register (offset 0x48). > hard reset path, though we also miss clearing an apparently-important > error register as well. FPDMA reset would be a good idea I think, even > if not in use, mainly for paranoia's sake and because that's what > Promise's driver does. Here's a patch on top of 2.6.28-rc6 that should make sata_promise's reset sequences a closer match to what Promise's drivers do. - soft reset (pdc_reset_port): * wait