gmane.linux.drivers.video-input-infrastructure

Mistake on the colorspace page in the API doc

Wouter Thielen — 2013-05-26T06:34:26

Hi all,

I have been trying to get the colors right in the images grabbed from my
webcam, and I tried the color conversion code on
http://linuxtv.org/downloads/v4l-dvb-apis/colorspaces.html.

It turned out to be very white, so I checked out the intermediate steps,
and thought the part:

ER = clamp (r * 255); /* [ok? one should prob. limit y1,pb,pr] */
EG = clamp (g * 255);
EB = clamp (b * 255);


should be without the * 255. I tried removing *255 and that worked.

Regards,

--
Wouter Thielen
http://morannon.org/

Re: [PATCH v2 1/5] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically

Laurent Pinchart — 2013-05-26T00:49:37

Hi Prabhakar,

Thank you for the patch.

On Saturday 25 May 2013 22:06:32 Prabhakar Lad wrote:

Acked-by: Laurent Pinchart <laurent.pinchart< at >ideasonboard.com>

Re: [PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api

Laurent Pinchart — 2013-05-26T00:49:22

Hi Prabhakar,

Thank you for the patch.

On Saturday 25 May 2013 22:06:33 Prabhakar Lad wrote:

You're loosing the request_mem_region(). You should use 
devm_request_and_ioremap() function instead of devm_ioremap_resource(). With 
that change,

Acked-by: Laurent Pinchart <laurent.pinchart< at >ideasonboard.com>

cron job: media_tree daily build: WARNINGS

Hans Verkuil — 2013-05-25T18:28:59

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:Sat May 25 19:00:22 CEST 2013
git branch:test
git hash:6a084d6b3dc200b855ae8a3c6771abe285a3835d
gcc version:i686-linux-gcc (GCC) 4.8.0
host hardware:x86_64
host os:3.8-3.slh.2-amd64

linux-git-arm-davinci: OK
linux-git-arm-exynos: WARNINGS
linux-git-arm-omap: WARNINGS
linux-git-blackfin: WARNINGS
linux-git-i686: OK
linux-git-m32r: OK
linux-git-mips: OK
linux-git-powerpc64: OK
linux-git-sh: OK
linux-git-x86_64: OK
linux-2.6.31.14-i686: WARNINGS
linux-2.6.32.27-i686: WARNINGS
linux-2.6.33.7-i686: WARNINGS
linux-2.6.34.7-i686: WARNINGS
linux-2.6.35.9-i686: WARNINGS
linux-2.6.36.4-i686: WARNINGS
linux-2.6.37.6-i686: WARNINGS
linux-2.6.38.8-i686: WARNINGS
linux-2.6.39.4-i686: WARNINGS
linux-3.0.60-i686: WARNINGS
linux-3.10-rc1-i686: WARNINGS
linux-3.1.10-i686: WARNINGS
linux-3.2.37-i686: WARNINGS
linux-3.3.8-i686: WARNINGS
linux-3.4.27-i6

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

Prabhakar Lad — 2013-05-25T17:43:29

Hi Sekhar,

On Sat, May 25, 2013 at 11:09 PM, Prabhakar Lad
<prabhakar.csengg< at >gmail.com> wrote:
Can you please ack this patch as I intend to take this patch via media
tree.

Regards,
--Prabhakar Lad

Re: InstantFM

Patrice Levesque — 2013-05-25T17:18:53


A disconnect-connect of the USB device reset its internal state and now
I can confirm the device properly works with the 3.9.3-gentoo kernel,
using the 3.103 version of xawtv.

Under the same kernel, the 3.95-r2 xawtv version shipped with gentoo
fails to detect signal: “radio -i -d” outputs no channel and shows
“get_baseline: min=0.000000 max=0.000000”.


Thanks for your good work on this, you know who you are,

[PATCH v2 1/5] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically

Prabhakar Lad — 2013-05-25T16:36:32

From: Lad, Prabhakar <prabhakar.csengg< at >gmail.com>

This patch removes unwanted header include of mach/hardware.h
and along side sorts the header inclusion alphabetically.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg< at >gmail.com>
---
 drivers/media/platform/davinci/vpif.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
index ea82a8b..761c825 100644
--- a/drivers/media/platform/davinci/vpif.c
+++ b/drivers/media/platform/davinci/vpif.c
< at >< at > -17,18 +17,16 < at >< at >
  * GNU General Public License for more details.
  */
 
+#include <linux/err.h>
 #include <linux/init.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/spinlock.h>
-#include <linux/kernel.h>
-#include <linux/io.h>
-#include <linux/err.h>
 #include <linux/pm_runtime.h>
+#include <linux/spinlock.h>
 #include <linux/v4l2-dv-timings.h>
 
-#include <mach/hardware.h>
-
 #

[PATCH v2 0/5] media: davinci: vpif trivial cleanup

Prabhakar Lad — 2013-05-25T16:36:31

From: Lad, Prabhakar <prabhakar.csengg< at >gmail.com>

This patch series cleans the VPIF driver, uses devm_* api wherever
required and uses module_platform_driver() to simplify the code.

This patch series applies on http://git.linuxtv.org/hverkuil/media_tree.git/
shortlog/refs/heads/for-v3.11 and is tested on OMAP-L138.

Changes for v2:
1: Rebased on v3.11 branch of Hans.
2: Dropped the patches which removed headers as mentioned by Laurent.

Lad, Prabhakar (5):
  media: davinci: vpif: remove unwanted header mach/hardware.h and sort
    the includes alphabetically
  media: davinci: vpif: Convert to devm_* api
  media: davinci: vpif: remove unnecessary braces around defines
  media: davinci: vpif_capture: Convert to devm_* api
  media: davinci: vpif_display: Convert to devm_* api

 drivers/media/platform/davinci/vpif.c         |   45 ++++-----------
 drivers/media/platform/davinci/vpif_capture.c |   73 +++++--------------------
 drivers/media/platform/davinci/vpif_display.c |   61 ++++-----------------
 3 files c

[PATCH 5/5] s5p-mfc: Remove unused s5p_mfc_get_decoded_status_v6() function

Sylwester Nawrocki — 2013-05-25T11:25:55

This patch fixes following compilation warning:

  CC [M]  drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.o
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:1733:12: warning: ‘s5p_mfc_get_decoded_status_v6’ defined but not used

It assigns existing but not used s5p_mfc_get_dec_status_v6() function to the
get_dec_status callback. It seems the get_dec_status callback is not used
anyway, as there is no corresponding s5p_mfc_hw_call().

Cc: Kamil Debski <k.debski< at >samsung.com>
Cc: Arun Kumar K <arun.kk< at >samsung.com>
Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki< at >gmail.com>
---
WARNING: This patch has not been tested.
---
 drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
index 7e76fce..3f97363 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
< at >< at > -62,12 +62,6 < at >< at > static

[PATCH 4/5] s5p-tv: Don't ignore return value of regulator_bulk_enable() in hdmi_drv.c

Sylwester Nawrocki — 2013-05-25T11:25:54

This patch fixes following compilation warning:
 CC [M]  drivers/media/platform/s5p-tv/hdmi_drv.o
drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_resource_poweron’:
drivers/media/platform/s5p-tv/hdmi_drv.c:583:23: warning: ignoring return value
 of ‘regulator_bulk_enable’, declared with attribute warn_unused_result

Cc: Tomasz Stanislawski <t.stanislaws< at >samsung.com>
Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki< at >gmail.com>
---
 drivers/media/platform/s5p-tv/hdmi_drv.c |   16 ++++++++++++----
 1 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c
index 4e86626..cca83f5 100644
--- a/drivers/media/platform/s5p-tv/hdmi_drv.c
+++ b/drivers/media/platform/s5p-tv/hdmi_drv.c
< at >< at > -576,16 +576,22 < at >< at > static int hdmi_s_stream(struct v4l2_subdev *sd, int enable)
 return hdmi_streamoff(hdev);
 }
 
-static void hdmi_resource_poweron(struct hdmi_resources *res)
+static int hdmi_resource_poweron(struct hdm

[PATCH 3/5] s5p-tv: Do not ignore regulator/clk API return values in sdo_drv.c

Sylwester Nawrocki — 2013-05-25T11:25:53

This patch fixes following compilation warning:

drivers/media/platform/s5p-tv/sdo_drv.c: In function ‘sdo_runtime_resume’:
drivers/media/platform/s5p-tv/sdo_drv.c:268:18: warning: ignoring return value of ‘regulator_enable’,
  declared with attribute warn_unused_result
drivers/media/platform/s5p-tv/sdo_drv.c:269:18: warning: ignoring return value of ‘regulator_enable’,
  declared with attribute warn_unused_result

Cc: Tomasz Stanislawski <t.stanislaws< at >samsung.com>
Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki< at >gmail.com>
---
 drivers/media/platform/s5p-tv/sdo_drv.c |   22 +++++++++++++++++++---
 1 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c
index ab6f9ef..0afa90f 100644
--- a/drivers/media/platform/s5p-tv/sdo_drv.c
+++ b/drivers/media/platform/s5p-tv/sdo_drv.c
< at >< at > -262,11 +262,21 < at >< at > static int sdo_runtime_resume(struct device *dev)
 {
 struct v4l2_subdev *sd = dev_get_drvdata(dev);
 struct

[PATCH 2/5] s5p-tv: Don't ignore return value of regulator_enable() in sii9234_drv.c

Sylwester Nawrocki — 2013-05-25T11:25:52

This patch fixes following compilation warning:

  CC [M]  drivers/media/platform/s5p-tv/sii9234_drv.o
drivers/media/platform/s5p-tv/sii9234_drv.c: In function ‘sii9234_runtime_resume’:
drivers/media/platform/s5p-tv/sii9234_drv.c:252:18: warning: ignoring return
  value of ‘regulator_enable’, declared with attribute warn_unused_result

Cc: Tomasz Stanislawski <t.stanislaws< at >samsung.com>
Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki< at >gmail.com>
---
 drivers/media/platform/s5p-tv/sii9234_drv.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/media/platform/s5p-tv/sii9234_drv.c b/drivers/media/platform/s5p-tv/sii9234_drv.c
index 39b77d2..3dd762e 100644
--- a/drivers/media/platform/s5p-tv/sii9234_drv.c
+++ b/drivers/media/platform/s5p-tv/sii9234_drv.c
< at >< at > -249,7 +249,9 < at >< at > static int sii9234_runtime_resume(struct device *dev)
 int ret;
 
 dev_info(dev, "resume start\n");
-regulator_enable(ctx->power);
+ret = regulator_enable(ctx->power);
+if (ret < 0)
+return

[PATCH 1/5] s5c73m3: Do not ignore errors from regulator_enable()

Sylwester Nawrocki — 2013-05-25T11:25:51

This fixes following compilation warning:

drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘__s5c73m3_power_off’:
drivers/media/i2c/s5c73m3/s5c73m3-core.c:1389:19: warning: ignoring return value
of ‘regulator_enable’, declared with attribute warn_unused_result

Cc: Andrzej Hajda <a.hajda< at >samsung.com>
Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki< at >gmail.com>
---
 drivers/media/i2c/s5c73m3/s5c73m3-core.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
index d3e867a..402da96 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
< at >< at > -1385,9 +1385,12 < at >< at > static int __s5c73m3_power_off(struct s5c73m3 *state)
 }
 return 0;
 err:
-for (++i; i < S5C73M3_MAX_SUPPLIES; i++)
-regulator_enable(state->supplies[i].consumer);
-
+for (++i; i < S5C73M3_MAX_SUPPLIES; i++) {
+int r = regulator_enable(state->supplies[i].consumer);
+if (r <

[PATCH 0/5] arm/exynos compilation warning fixes

Sylwester Nawrocki — 2013-05-25T11:25:50

This patch set fixes couple issues that cause warnings seen in the media 
daily build. Any testing/ack are welcome, as these patches are completely 
untested yet.

Sylwester Nawrocki (5):
  s5c73m3: Do not ignore errors from regulator_enable()
  s5p-tv: Don't ignore return value of regulator_enable() in
    sii9234_drv.c
  s5p-tv: Do not ignore regulator/clk API return values in sdo_drv.c
  s5p-tv: Don't ignore return value of regulator_bulk_enable() in
    hdmi_drv.c
  s5p-mfc: Remove unused s5p_mfc_get_decoded_status_v6() function

 drivers/media/i2c/s5c73m3/s5c73m3-core.c        |    9 ++++++---
 drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |    8 +-------
 drivers/media/platform/s5p-tv/hdmi_drv.c        |   16 ++++++++++++----
 drivers/media/platform/s5p-tv/sdo_drv.c         |   22 +++++++++++++++++++---
 drivers/media/platform/s5p-tv/sii9234_drv.c     |    4 +++-
 5 files changed, 41 insertions(+), 18 deletions(-)

Re: Audio: no sound

Jon Arne Jørgensen — 2013-05-25T07:00:20

Hi,




It seems you are still using the easycap driver.

[...]


This should say stk1160 if you were using the new driver.
I'm not sure what about what kernel first included the stk1160, but it
doesn't seem to be included in the kernel you built.

Best regards
Jon Arne Jørgensen

cron job: media_tree daily build: WARNINGS

Hans Verkuil — 2013-05-24T18:28:20

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:Fri May 24 19:00:22 CEST 2013
git branch:test
git hash:6a084d6b3dc200b855ae8a3c6771abe285a3835d
gcc version:i686-linux-gcc (GCC) 4.8.0
host hardware:x86_64
host os:3.8-3.slh.2-amd64

linux-git-arm-davinci: OK
linux-git-arm-exynos: WARNINGS
linux-git-arm-omap: WARNINGS
linux-git-blackfin: WARNINGS
linux-git-i686: OK
linux-git-m32r: OK
linux-git-mips: OK
linux-git-powerpc64: OK
linux-git-sh: OK
linux-git-x86_64: OK
linux-2.6.31.14-i686: WARNINGS
linux-2.6.32.27-i686: WARNINGS
linux-2.6.33.7-i686: WARNINGS
linux-2.6.34.7-i686: WARNINGS
linux-2.6.35.9-i686: WARNINGS
linux-2.6.36.4-i686: WARNINGS
linux-2.6.37.6-i686: WARNINGS
linux-2.6.38.8-i686: WARNINGS
linux-2.6.39.4-i686: WARNINGS
linux-3.0.60-i686: WARNINGS
linux-3.10-rc1-i686: WARNINGS
linux-3.1.10-i686: WARNINGS
linux-3.2.37-i686: WARNINGS
linux-3.3.8-i686: WARNINGS
linux-3.4.27-i6

[PATCH 2/2] em28xx: complete GPIO register caching

Frank Schäfer — 2013-05-24T16:34:08

The current GPIO register caching is incomplete.
Only one GPIO register and one GPO register is cached, but
nearly all chip variants have more than one GPIO register.
Caching of pure GPO registers (reg 0x04) also isn't needed.
At least parts of register 0x0c seem to be assigned to GPIO lines,
so we need to cache this register, too.

Signed-off-by: Frank Schäfer <fschaefer.oss< at >googlemail.com>
---
 drivers/media/usb/em28xx/em28xx-cards.c | 12 ---------
 drivers/media/usb/em28xx/em28xx-core.c  | 43 ++++++++++++++++++++++-----------
 drivers/media/usb/em28xx/em28xx.h       | 15 ++++++++----
 3 files changed, 39 insertions(+), 31 deletions(-)

diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index 83bfbe4..7486533 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
< at >< at > -2881,10 +2881,6 < at >< at > static int em28xx_init_dev(struct em28xx *dev, struct usb_device *udev,
 
 em28xx_set_model(dev);
 
-/* Set the default GPO/GPIO for

[PATCH 1/2] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers

Frank Schäfer — 2013-05-24T16:34:07

em25xx/em276x/7x/8x provides 3 GPIO register sets,
each of them consisting of separate read and a write registers.

Signed-off-by: Frank Schäfer <fschaefer.oss< at >googlemail.com>
---
 drivers/media/usb/em28xx/em28xx-reg.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/usb/em28xx/em28xx-reg.h b/drivers/media/usb/em28xx/em28xx-reg.h
index 622871d..17bdb78 100644
--- a/drivers/media/usb/em28xx/em28xx-reg.h
+++ b/drivers/media/usb/em28xx/em28xx-reg.h
< at >< at > -210,6 +210,14 < at >< at >
 #define EM2874_TS2_FILTER_ENABLE  (1 << 5)
 #define EM2874_TS2_NULL_DISCARD   (1 << 6)
 
+/* em25xx, em276x/7x/8x GPIO registers */
+#define EM25XX_R80_GPIO_P0_W    0x80
+#define EM25XX_R81_GPIO_P1_W    0x81
+#define EM25XX_R83_GPIO_P3_W    0x83
+#define EM25XX_R84_GPIO_P0_R    0x84
+#define EM25XX_R85_GPIO_P1_R    0x85
+#define EM25XX_R87_GPIO_P3_R    0x87
+
 /* register settings */
 #define EM2800_AUDIO_SRC_TUNER  0x0d
 #define EM2800_AUDIO_SRC_LINE   0x0c

RE: [PATCH 2/2] [media] s5p-mfc: Remove redundant use of of_match_ptr macro

Kamil Debski — 2013-05-24T12:28:38

Hi Sachin,

Thank you for your patch.

Best wishes,

[PATCH 2/2] [media] soc_camera: tw9910: Remove empty function

Sachin Kamat — 2013-05-24T11:25:07

After the switch to devm_* functions, the 'remove' function does
not do anything. Delete it.

Signed-off-by: Sachin Kamat <sachin.kamat< at >linaro.org>
Cc: Kuninori Morimoto <morimoto.kuninori< at >renesas.com>
---
 drivers/media/i2c/soc_camera/tw9910.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/i2c/soc_camera/tw9910.c b/drivers/media/i2c/soc_camera/tw9910.c
index bad90b1..6b9cc2a 100644
--- a/drivers/media/i2c/soc_camera/tw9910.c
+++ b/drivers/media/i2c/soc_camera/tw9910.c
< at >< at > -938,11 +938,6 < at >< at > static int tw9910_probe(struct i2c_client *client,
 return tw9910_video_probe(client);
 }
 
-static int tw9910_remove(struct i2c_client *client)
-{
-return 0;
-}
-
 static const struct i2c_device_id tw9910_id[] = {
 { "tw9910", 0 },
 { }
< at >< at > -954,7 +949,6 < at >< at > static struct i2c_driver tw9910_i2c_driver = {
 .name = "tw9910",
 },
 .probe    = tw9910_probe,
-.remove   = tw9910_remove,
 .id_table = tw9910_id,
 };

[PATCH 1/2] [media] soc_camera: mt9t112: Remove empty function

Sachin Kamat — 2013-05-24T11:25:06

After the switch to devm_* functions, the 'remove' function does
not do anything. Delete it.

Signed-off-by: Sachin Kamat <sachin.kamat< at >linaro.org>
Cc: Kuninori Morimoto <morimoto.kuninori< at >renesas.com>
---
 drivers/media/i2c/soc_camera/mt9t112.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/i2c/soc_camera/mt9t112.c b/drivers/media/i2c/soc_camera/mt9t112.c
index a7256b7..0af29a4 100644
--- a/drivers/media/i2c/soc_camera/mt9t112.c
+++ b/drivers/media/i2c/soc_camera/mt9t112.c
< at >< at > -1118,11 +1118,6 < at >< at > static int mt9t112_probe(struct i2c_client *client,
 return ret;
 }
 
-static int mt9t112_remove(struct i2c_client *client)
-{
-return 0;
-}
-
 static const struct i2c_device_id mt9t112_id[] = {
 { "mt9t112", 0 },
 { }
< at >< at > -1134,7 +1129,6 < at >< at > static struct i2c_driver mt9t112_i2c_driver = {
 .name = "mt9t112",
 },
 .probe    = mt9t112_probe,
-.remove   = mt9t112_remove,
 .id_table = mt9t112_id,
 };