gmane.linux.drivers.video-input-infrastructure

Re: [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file

Sylwester Nawrocki — 2012-05-26T08:39:50

Hi Sachin,

On 05/25/2012 07:38 PM, Sachin Kamat wrote:

Thanks for the patches. However I'm inclined to squash this whole
series into one patch, since it addresses same issue in one driver,
just in different. I don't see a good reason to split those changes
like this. Could you make it just one patch instead ?


Regards,
Sylwester

Re: rtl28xxu - rtl2832 frontend attach

poma — 2012-05-26T02:47:27

True. Whatever a value is changed - 'rtl2832u_power_ctrl', it brakes
even more.
Precisely, what breaks a tuner on next soft [re]boot are apps/utils
which engage tzap/scan[dvb].

· · · — — — · · ·

cheers,
poma

(unknown)

robothroli company — 2012-05-25T13:45:54

 i am robothroli, Purchase manager from roli Merchant Ltd. We are
Import/export Company based in taiwan. We are interested in purchasing
your product and I would like to make an inquiry. Please inform me on:

Sample availability and price
Minimum order quantity
FOB Prices

Sincerely
Purchase Manager
robothroli

[PATCH 07/15] video: mx2_camera: Use clk_prepare_enable/clk_disable_unprepare

Fabio Estevam — 2012-05-25T23:14:48

From: Fabio Estevam <fabio.estevam< at >freescale.com>

Prepare the clock before enabling it.

Cc: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
Cc: <linux-media< at >vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 drivers/media/video/mx2_camera.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
index ded26b7..71b67a3 100644
--- a/drivers/media/video/mx2_camera.c
+++ b/drivers/media/video/mx2_camera.c
< at >< at > -402,7 +402,7 < at >< at > static void mx2_camera_deactivate(struct mx2_camera_dev *pcdev)
 {
 unsigned long flags;
 
-clk_disable(pcdev->clk_csi);
+clk_disable_unprepare(pcdev->clk_csi);
 writel(0, pcdev->base_csi + CSICR1);
 if (cpu_is_mx27()) {
 writel(0, pcdev->base_emma + PRP_CNTL);
< at >< at > -430,7 +430,7 < at >< at > static int mx2_camera_add_device(struct soc_camera_device *icd)
 if (pcdev->icd)
 return -EBUSY;
 
-ret = clk_enable(pcdev->clk_csi);
+ret = clk_prepare_enable(pcdev->clk_csi);

[PATCH 08/15] video: mx2_emmaprp: Use clk_prepare_enable/clk_disable_unprepare

Fabio Estevam — 2012-05-25T23:14:49

From: Fabio Estevam <fabio.estevam< at >freescale.com>

Prepare the clock before enabling it.

Cc: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
Cc: <linux-media< at >vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 drivers/media/video/mx2_emmaprp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/mx2_emmaprp.c b/drivers/media/video/mx2_emmaprp.c
index 0bd5815..b364557 100644
--- a/drivers/media/video/mx2_emmaprp.c
+++ b/drivers/media/video/mx2_emmaprp.c
< at >< at > -800,7 +800,7 < at >< at > static int emmaprp_open(struct file *file)
 return ret;
 }
 
-clk_enable(pcdev->clk_emma);
+clk_prepare_enable(pcdev->clk_emma);
 ctx->q_data[V4L2_M2M_SRC].fmt = &formats[1];
 ctx->q_data[V4L2_M2M_DST].fmt = &formats[0];
 
< at >< at > -816,7 +816,7 < at >< at > static int emmaprp_release(struct file *file)
 
 dprintk(pcdev, "Releasing instance %p\n", ctx);
 
-clk_disable(pcdev->clk_emma);
+clk_disable_unprepare(pcdev->clk_emma);
 v4l2_m2m_ctx_release(ctx->m2m_ctx);
 kfree(ctx);

[PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

Fabio Estevam — 2012-05-25T23:14:47

From: Fabio Estevam <fabio.estevam< at >freescale.com>

Prepare the clock before enabling it.

Cc: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
Cc: <linux-media< at >vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 drivers/media/video/mx1_camera.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/mx1_camera.c b/drivers/media/video/mx1_camera.c
index 4296a83..dc58084 100644
--- a/drivers/media/video/mx1_camera.c
+++ b/drivers/media/video/mx1_camera.c
< at >< at > -402,7 +402,7 < at >< at > static void mx1_camera_activate(struct mx1_camera_dev *pcdev)
 
 dev_dbg(pcdev->icd->parent, "Activate device\n");
 
-clk_enable(pcdev->clk);
+clk_prepare_enable(pcdev->clk);
 
 /* enable CSI before doing anything else */
 __raw_writel(csicr1, pcdev->base + CSICR1);
< at >< at > -421,7 +421,7 < at >< at > static void mx1_camera_deactivate(struct mx1_camera_dev *pcdev)
 /* Disable all CSI interface */
 __raw_writel(0x00, pcdev->base + CSICR1);
 
-clk_disable(pcdev->clk);
+clk_disable_unp

DVB USB: change USB stream settings dynamically

Antti Palosaari — 2012-05-25T22:47:45

I was planning make DVB USB be able to switch USB streaming parameters 
dynamically. I mean [struct usb_data_stream_properties] parameters.

Currently it reserves USB streaming buffers when device is plugged. Own 
buffer is reserved for each frontend, which means currently 1-3 
streaming buffers depending on device.

Basically I see USB TS as a DVB USB device property - not property of 
frontend. USB TS is interface between computer and USB-bridge and amount 
of parallel USB TS or TS configurations depends on USB-bridge 
capabilities. Sometimes used USB TS could be configured to fit better 
used stream. Smaller buffers for the narrow radio stream and biggest 
buffers for the wide DVB-S2 stream.

I was wondering how to resolve that situation? It is not very big 
problem currently but I still want to make it better as there is surely 
coming new devices that needs better control for the USB streaming 
parameters. Currently there is mxl111sf driver which seems to offer 6 
different streaming configurations but

[PATCH] Revert "[media] media: mx2_camera: Fix mbus format handling"

Guennadi Liakhovetski — 2012-05-25T22:06:33

This reverts commit d509835e32bd761a2b7b446034a273da568e5573. That commit
breaks support for the generic pass-through mode in the driver for formats,
not natively supported by it. Besides due to a merge conflict it also breaks
driver compilation:

drivers/media/video/mx2_camera.c: In function 'mx2_camera_set_bus_param':
drivers/media/video/mx2_camera.c:937: error: 'pixfmt' undeclared (first use in this function)
drivers/media/video/mx2_camera.c:937: error: (Each undeclared identifier is reported only once
drivers/media/video/mx2_camera.c:937: error: for each function it appears in.)

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
Cc: Javier Martin <javier.martin< at >vista-silicon.com>
---
 arch/arm/plat-mxc/include/mach/mx2_cam.h |    2 +
 drivers/media/video/mx2_camera.c         |   52 +++---------------------------
 2 files changed, 7 insertions(+), 47 deletions(-)

diff --git a/arch/arm/plat-mxc/include/mach/mx2_cam.h b/arch/arm/plat-mxc/include/mach/mx2_cam.h
index 7ded6f1..3c080a3 100644
--- a

[GIT PATCHES FOR 3.5] s5p-fimc driver fixes

Sylwester Nawrocki — 2012-05-25T19:58:05

Hi Mauro,

The following changes since commit 5472d3f17845c4398c6a510b46855820920c2181:

  [media] mt9m032: Implement V4L2_CID_PIXEL_RATE control (2012-05-24 09:27:24
-0300)

are available in the git repository at:

  git://git.infradead.org/users/kmpark/linux-samsung v4l-fimc-fixes

for you to fetch changes up to e17efe77cc112420a5a9169a77402cc590a96908:

  s5p-fimc: Stop media entity pipeline if fimc_pipeline_validate fails
(2012-05-25 12:18:27 +0200)

----------------------------------------------------------------
Sachin Kamat (2):
      s5p-fimc: Fix compiler warning in fimc-lite.c
      s5p-fimc: Stop media entity pipeline if fimc_pipeline_validate fails

Sakari Ailus (1):
      s5p-fimc: media_entity_pipeline_start() may fail

Sylwester Nawrocki (8):
      s5p-fimc: Fix bug in capture node open()
      s5p-fimc: Don't create multiple active links to same sink entity
      s5p-fimc: Honour sizeimage in VIDIOC_S_FMT
      s5p-fimc: Remove superfluous checks for buffer type
      s5p-fimc: Prevent lock-u

[RFC/PATCH 03/13] ARM: Samsung: Remove unused fields from FIMC and CSIS platform data

Sylwester Nawrocki — 2012-05-25T19:52:42

The MIPI-CSI2 bus data alignment is now being derived from the media
bus pixel code, the drivers don't use the corresponding structure
fields, so remove them. Also remove the s5p_csis_phy_enable callback
which is now used directly by s5p-csis driver.

Signed-off-by: Sylwester Nawrocki <s.nawrocki< at >samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park< at >samsung.com>
---
 arch/arm/mach-exynos/mach-nuri.c               |    3 ---
 arch/arm/mach-exynos/mach-universal_c210.c     |    3 ---
 arch/arm/plat-samsung/include/plat/mipi_csis.h |   13 +++----------
 include/media/s5p_fimc.h                       |    2 --
 4 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
index c9ca54a..1cd4ded 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
< at >< at > -1148,9 +1148,7 < at >< at > static struct platform_device cam_8m_12v_fixed_rdev = {
 static struct s5p_platform_mipi_csis mipi_csis_platdata = {
 .clk_rate= 166000000UL,

[PATCH 14/14] s5p-fimc: Add FIMC and MIPI-CSIS devices to CAM power domain

Sylwester Nawrocki — 2012-05-25T19:52:53

From: Bartlomiej Zolnierkiewicz <b.zolnierkie< at >samsung.com>

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie< at >samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki< at >samsung.com>
---
 drivers/media/video/s5p-fimc/fimc-core.c |   15 +++++++++++++++
 drivers/media/video/s5p-fimc/mipi-csis.c |   15 +++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/drivers/media/video/s5p-fimc/fimc-core.c b/drivers/media/video/s5p-fimc/fimc-core.c
index 30c6365..15c7cc6 100644
--- a/drivers/media/video/s5p-fimc/fimc-core.c
+++ b/drivers/media/video/s5p-fimc/fimc-core.c
< at >< at > -19,6 +19,7 < at >< at >
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/pm_domain.h>
 #include <linux/list.h>
 #include <linux/io.h>
 #include <linux/of.h>
< at >< at > -1057,6 +1058,17 < at >< at > static int fimc_m2m_resume(struct fimc_dev *fimc)
 return 0;
 }
 
+static void bus_add_dev_to_pd(struct device *dev)
+{
+struct device_node *np;
+
+np = of_parse_phandle(dev->of_node, "pd", 0);
+if (np)
+

[RFC/PATCH 13/13] media: s5p-fimc: Add parallel video port pin configuration

Sylwester Nawrocki — 2012-05-25T19:52:52

This patch adds parsing of 'samsung,fimc-camport-a-gpios' and
'samsung,fimc-camport-b-gpios' properties from 'camera' node
and configuration of camera parallel port pins. It can be
in future replaced with equivalent pinctrl API calls.

Signed-off-by: Sylwester Nawrocki <s.nawrocki< at >samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie< at >samsung.com>
Signed-off-by: Kyugmin Park <kyungmin.park< at >samsung.com>
---
 .../bindings/camera/soc/samsung-fimc.txt           |   12 +++
 drivers/media/video/s5p-fimc/fimc-mdevice.c        |   87 ++++++++++++++++++++
 drivers/media/video/s5p-fimc/fimc-mdevice.h        |   10 +++
 3 files changed, 109 insertions(+)

diff --git a/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt
index ffe09ac..efa5be5 100644
--- a/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt
+++ b/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt
< at >< at > -23,6 +23,18 < at >< at > Optional properties:
 - csi-rx-co

[RFC/PATCH 06/13] media: s5p-fimc: Add device tree support for FIMC-LITE

Sylwester Nawrocki — 2012-05-25T19:52:45

Signed-off-by: Sylwester Nawrocki <s.nawrocki< at >samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park< at >samsung.com>
---
 .../bindings/camera/soc/samsung-fimc.txt           |   15 ++++
 drivers/media/video/s5p-fimc/fimc-lite.c           |   73 ++++++++++++++------
 2 files changed, 67 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt
index 1ec48e9..b459da2 100644
--- a/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt
+++ b/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt
< at >< at > -39,6 +39,21 < at >< at > Required properties:
        depends on the SoC revision. For S5PV210 valid values are:
        0...2, for Exynos4x1x: 0...3.
 
+
+'fimc-lite' device node
+-----------------------
+
+Required properties:
+
+- compatible : should be one of:
+"samsung,exynos4212-fimc";
+"samsung,exynos4412-fimc";
+- reg     : physical base address and size of the device's memory mapped
+

Re: [RFCv1] DVB-USB improvements [alternative 2]

Antti Palosaari — 2012-05-25T18:51:20

Using macro you will save mostly one line but it looks maybe a little 
bit cleaner. There was such macros used by some other USB drivers.


Keymap is moved similarly as a name
.driver_info = (kernel_ulong_t) &((struct dvb_usb_driver_info) {
.name = "TerraTec Cinergy T Stick Dual RC",
.rc_map = RC_MAP_TERRATEC_SLIM,
.props = &af9015_properties })},


For the other remote configurations I will introduce callback. Also 
callback for the stream and pid filters, which is called every-time when 
streaming is started. IIRC stream was the reason Michael introduced 
stream configuration per frontend. Also sometimes it could be nice to 
configure smaller stream buffers runtime for example in case of pid 
filters are enabled.

My development tree is here:
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb-usb


Antti

Re: [RFCv1] DVB-USB improvements [alternative 2]

Mauro Carvalho Chehab — 2012-05-25T18:38:03

Em 25-05-2012 15:32, Mauro Carvalho Chehab escreveu:

Ah, I suggest you to try to convert a driver like dib0700 (with has 83 types of devices
and several options of tuners/demods). 

It shold be noticed that dib0700, has two tables (well, there are actually several 
different keymaps there - but they ended to be converted into just two tables - 
mainly because of my lack of time and device specifics knowledge to break the NEC 
and RC5 tables on a per-device table). Any dvb-usb driver newer than RC core that
supports multiple vendors will have a different RC table for each device.

Regards,
Mauro

Re: [RFCv1] DVB-USB improvements [alternative 2]

Mauro Carvalho Chehab — 2012-05-25T18:32:33

Em 25-05-2012 14:44, Antti Palosaari escreveu:

It will be better if you inline a diff at the email, instead of pointing 
to the changed files.

Also, instead of doing:

static struct usb_device_id af9015_usb_table[] = {
{ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9015_9015),
.driver_info = (kernel_ulong_t) &((struct dvb_usb_driver_info) {
.name = "Afatech AF9015 reference design",
.props = &af9015_properties })},

I suggest you to add a macro for it, converting the above to something similar to:

DVB_USB_DRIVER_INFO("Afatech AF9015 reference design", &af9015_properties),

or, even better, to:

DVB_USB_DEVICE(USB_VID_AFATECH,
       USB_PID_AFATECH_AF9015_9015,
       "Afatech AF9015 reference design", 
       &af9015_properties),

Btw, I still think that you should move things like RC type to be stored outside
the properties struct.

Regards,
Mauro

cron job: media_tree daily build: WARNINGS

Hans Verkuil — 2012-05-25T17:59:32

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:        Fri May 25 19:00:23 CEST 2012
git hash:    5472d3f17845c4398c6a510b46855820920c2181
gcc version:      i686-linux-gcc (GCC) 4.6.3
host hardware:    x86_64
host os:          3.3-6.slh.2-amd64

linux-git-arm-eabi-davinci: WARNINGS
linux-git-arm-eabi-exynos: WARNINGS
linux-git-arm-eabi-omap: WARNINGS
linux-git-i686: WARNINGS
linux-git-m32r: WARNINGS
linux-git-mips: WARNINGS
linux-git-powerpc64: WARNINGS
linux-git-x86_64: WARNINGS
linux-2.6.31.12-i686: WARNINGS
linux-2.6.32.6-i686: WARNINGS
linux-2.6.33-i686: WARNINGS
linux-2.6.34-i686: WARNINGS
linux-2.6.35.3-i686: WARNINGS
linux-2.6.36-i686: WARNINGS
linux-2.6.37-i686: WARNINGS
linux-2.6.38.2-i686: WARNINGS
linux-2.6.39.1-i686: WARNINGS
linux-3.0-i686: WARNINGS
linux-3.1-i686: WARNINGS
linux-3.2.1-i686: WARNINGS
linux-3.3-i686: WARNINGS
linux-3.4-i686: WARNINGS
linux-2.6.31.12-x86_64:

Re: [RFCv1] DVB-USB improvements [alternative 2]

Antti Palosaari — 2012-05-25T17:48:50

Argh, reduces 8-9kB from the *af9015* as it was defining three (struct 
dvb_usb_device_properties). Also line count reduces 350 lines and will 
reduce some more after all those planned callbacks are done.


Antti

Re: [RFCv1] DVB-USB improvements [alternative 2]

Antti Palosaari — 2012-05-25T17:44:29

I have now implemented some basic stuff. Most interesting is new way of 
map device id and properties for it. I found that I can use .driver_info 
field from the (struct usb_device_id) to carry pointer. I used it to 
carry all the other data to the DVB USB core. Thus that one big issue is 
now resolved. It reduces something like 8-9 kB of binary size which is 
huge improvement. Same will happen for every driver using multiple 
(struct dvb_usb_device_properties) - for more you are used more you save.

Here is 3 example drivers I have converted to that new style:
http://palosaari.fi/linux/v4l-dvb/dvb-usb-2012-05-25/

regards
Antti

[PATCH 2/4] [media] s5p-fimc: Add missing static storage class in fimc-mdevice.c file

Sachin Kamat — 2012-05-25T17:38:51

Fixes the following sparse warnings:
drivers/media/video/s5p-fimc/fimc-mdevice.c:183:5: warning: symbol '__fimc_pipeline_shutdown' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:1013:12: warning: symbol 'fimc_md_init' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:1024:13: warning: symbol 'fimc_md_exit' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat< at >linaro.org>
---
 drivers/media/video/s5p-fimc/fimc-mdevice.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/media/video/s5p-fimc/fimc-mdevice.c b/drivers/media/video/s5p-fimc/fimc-mdevice.c
index 52cef48..e65bb28 100644
--- a/drivers/media/video/s5p-fimc/fimc-mdevice.c
+++ b/drivers/media/video/s5p-fimc/fimc-mdevice.c
< at >< at > -180,7 +180,7 < at >< at > EXPORT_SYMBOL_GPL(fimc_pipeline_initialize);
  * sensor clock.
  * Called with the graph mutex held.
  */
-int __fimc_pipeline_shutdown(struct fimc_pipeline *p)
+static int __fimc_pipe

[PATCH 4/4] [media] s5p-fimc: Add missing static storage class in fimc-capture.c file

Sachin Kamat — 2012-05-25T17:38:53

Fixes the following sparse warning:
drivers/media/video/s5p-fimc/fimc-capture.c:1163:5: warning: symbol 'enclosed_rectangle' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat< at >linaro.org>
---
 drivers/media/video/s5p-fimc/fimc-capture.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c b/drivers/media/video/s5p-fimc/fimc-capture.c
index 516cd5b..b7caaf5 100644
--- a/drivers/media/video/s5p-fimc/fimc-capture.c
+++ b/drivers/media/video/s5p-fimc/fimc-capture.c
< at >< at > -1160,7 +1160,7 < at >< at > static int fimc_cap_g_selection(struct file *file, void *fh,
 }
 
 /* Return 1 if rectangle a is enclosed in rectangle b, or 0 otherwise. */
-int enclosed_rectangle(struct v4l2_rect *a, struct v4l2_rect *b)
+static int enclosed_rectangle(struct v4l2_rect *a, struct v4l2_rect *b)
 {
 if (a->left < b->left || a->top < b->top)
 return 0;