gmane.linux.drivers.driver-project.devel

hello

YOUSSEF KHELIL — 2013-05-17T17:54:17



Hello,
I AM YOUSSEF KHELIL BY NAME, A BRITISH NATIONAL. LODGER FOR THE LATE
PRESIDENT OF VENEZUELA (LATE HUGO CHAVEZ) WE MET FEW WEEKS IN CUBA BEFORE
HIS DEATH TO DISCUSS ABOUT HIS VITAL DOCUMENTS, ACCOUNTS AND SAFE DEPOSIT
FUNDS MEANT TO BE TRANSFERRED TO CUBA AND TALKED OVER HIS ILL HEALTH.

RECENTLY DURING THE ELECTION CAMPAIGN SOME CASHED WERE ALSO DEPOSITED INTO
A FINANCIAL INSTITUTION READY TO BE MOVED TO CUBA, BEFORE HIS
DEATH.PRESENTLY THESE FUNDS ARE STILL AVAILABLE TO BE CLAIMED AND MOVED TO
THE FINAL DESIGNATIONS,I AM LOOKING FOR A SILENT PARTNER THAT CAN LAY
CLAIMS TO THE FUNDS FOR FINAL AUTHORIZATIONS TO ANY PROVIDED ACCOUNTS,
UNDER REACHED AGREEMENTS FROM BOTH OF US.

I AM WILLING WE SHARE IT 40% FOR ME AND 40 % FOR YOU, WHILE - (20 % FOR
THE VENEZUELA CHARITY ORGANIZATIONS) AND WHICH WILL BE CARRIED OUT THROUGH
YOU. BE-INFORMED THAT I AM STILL IN POCESSION OF ALL THE IMPORTANT FILES
AND DOCUMENTS REGARDS THE DEPOSITS AND OTHER VITAL INFORMATION.

ONCE I READ FROM YOU, I WILL FURNISH YOU WIT

Re: [PATCHv10 1/4] debugfs: add get/set for atomic types

Dave Hansen — 2013-05-17T22:26:37

lib/fault_inject.c has something that looks pretty similar:

static struct dentry *debugfs_create_atomic_t(const char *name, umode_t
 mode, struct dentry *parent, atomic_t *value)

should add even more of an argument to merge this patch _now_, and
separately from the rest of zswap.

[PATCH] staging/xgifb: Remove dead assignments/increments

Peter Huewe — 2013-05-17T22:19:54

The code now contains several dead assignments which are shadowed by
another assignment a few lines later.

-> This patch removes them (and possibly associated code).

Signed-off-by: Peter Huewe <peterhuewe< at >gmx.de>
---

The patch did not remove occurences where a register from the device is read.
If the device does not have implicit actions associated with reading from its
registers these instances could also be removed.

 drivers/staging/xgifb/vb_init.c    |  1 -
 drivers/staging/xgifb/vb_setmode.c | 20 +-------------------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 090c424..5c72104 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
< at >< at > -1296,7 +1296,6 < at >< at > unsigned char XGIInitNew(struct pci_dev *pdev)
 xgifb_reg_set(pVBInfo->Part1Port, 0x00, 0x00);
 /* chk if BCLK>=100MHz */
 temp1 = xgifb_reg_get(pVBInfo->P3d4, 0x7B);
-temp = (unsigned char) ((temp1 >> 4) & 0x0F);
 
 xgifb_r

Re: [PATCH 1/1] Staging: bcm: Fix of various code style issues.

Greg Kroah-Hartman — 2013-05-17T22:08:19

You are doing 3 different things, so this should be at least 3 different
patches, right?

Please split them up and resend them, thanks.

greg k-h

Re: [PATCH] Staging: wlan-ng: Replace printk with pr_ to fix checkpatch warnings.

Greg KH — 2013-05-17T22:03:55

As this is a network driver, can't these be net_dev, or dev_warn() calls
instead?

thanks,

greg k-h

Re: [PATCH 2/2] Staging: android: sync: use seq_puts()/seq_putc() to follow coding style

Greg KH — 2013-05-17T21:59:03

Sorry, someone beat you to this same patch a few days ago, so I can't
apply it.

greg k-h

Re: [PATCH 2/2] Staging: android: sync: use seq_puts()/seq_putc() to follow coding style

Greg KH — 2013-05-17T21:57:58

Where patch 1/2 in this series?

confused,

greg k-h

[PATCH 2/2] staging/btmtk_usb: Mark local functions as static

Peter Huewe — 2013-05-17T21:51:58

sparse complains about some local functions not being static:
drivers/staging/btmtk_usb/btmtk_usb.c:50:6:
warning: symbol 'hex_dump' was not declared. Should it be static?
drivers/staging/btmtk_usb/btmtk_usb.c:227:5:
warning: symbol 'checksume16' was not declared. Should it be static?

-> add the static keyword

Signed-off-by: Peter Huewe <peterhuewe< at >gmx.de>
---
 drivers/staging/btmtk_usb/btmtk_usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index 772c49e..a7539df 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
< at >< at > -47,7 +47,7 < at >< at > static struct usb_driver btmtk_usb_driver;
 static int btmtk_usb_load_rom_patch(struct btmtk_usb_data *);
 static int btmtk_usb_load_fw(struct btmtk_usb_data *);
 
-void hex_dump(char *str, u8 *src_buf, u32 src_buf_len)
+static void hex_dump(char *str, u8 *src_buf, u32 src_buf_len)
 {
 unsigned char *pt;
 int x;
< at >< at > -224,7 +224,7

[PATCH 1/2] staging/btmtk_usb: use module_usb_driver to register driver

Peter Huewe — 2013-05-17T21:51:57

Removing some boilerplate by using module_usb_driver instead of calling
register and unregister in the otherwise empty init/exit functions

Signed-off-by: Peter Huewe <peterhuewe< at >gmx.de>
---
 drivers/staging/btmtk_usb/btmtk_usb.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index 6b01f61..772c49e 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
< at >< at > -1771,20 +1771,7 < at >< at > static struct usb_driver btmtk_usb_driver = {
 .disable_hub_initiated_lpm = 1,
 };
 
-static int __init btmtk_usb_init(void)
-{
-BT_INFO("btmtk usb driver ver %s", VERSION);
-
-return usb_register(&btmtk_usb_driver);
-}
-
-static void __exit btmtk_usb_exit(void)
-{
-usb_deregister(&btmtk_usb_driver);
-}
-
-module_init(btmtk_usb_init);
-module_exit(btmtk_usb_exit);
+module_usb_driver(btmtk_usb_driver);
 
 MODULE_DESCRIPTION("Mediatek Bluetooth USB driver ver " VERSION);
 MODULE_VERS

[PATCH 5/6] staging: comedi: me_daq: use comedi_load_firmware()

H Hartley Sweeten — 2013-05-17T18:17:40

Use comedi_load_firmware() instead of duplicating the code in a
private function.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/me_daq.c | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c
index a5551e6..313f702 100644
--- a/drivers/staging/comedi/drivers/me_daq.c
+++ b/drivers/staging/comedi/drivers/me_daq.c
< at >< at > -33,7 +33,6 < at >< at >
 #include <linux/pci.h>
 #include <linux/interrupt.h>
 #include <linux/sched.h>
-#include <linux/firmware.h>
 
 #include "../comedidev.h"
 
< at >< at > -456,22 +455,6 < at >< at > static int me2600_xilinx_download(struct comedi_device *dev,
 return 0;
 }
 
-static int me2600_upload_firmware(struct comedi_device *dev)
-{
-struct pci_dev *pcidev = comedi_to_pci_dev(dev);
-const struct firmware *fw;
-int ret;
-
-ret = request_firmware(&fw, ME26

[PATCH 6/6] staging: comedi: ni_pcidio: use comedi_load_firmware()

H Hartley Sweeten — 2013-05-17T18:18:01

Use comedi_load_firmware() instead of duplicating the code in a
private function.

This driver loads multiple firmware images to the device. Modify
comedi_load_firmware() to take a 'context' that is passed to the
firmware upload callback function.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/comedidev.h            |  4 +++-
 drivers/staging/comedi/drivers.c              |  7 +++++--
 drivers/staging/comedi/drivers/daqboard2000.c |  5 +++--
 drivers/staging/comedi/drivers/jr3_pci.c      |  9 +++++----
 drivers/staging/comedi/drivers/me_daq.c       |  5 +++--
 drivers/staging/comedi/drivers/ni_pcidio.c    | 25 +++++++++++--------------
 6 files changed, 30 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 7adc426..a31915f 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedide

[PATCH 4/6] staging: comedi: daqboard2000: use comedi_load_firmware()

H Hartley Sweeten — 2013-05-17T18:17:22

Use comedi_load_firmware() instead of duplicating the code in a
private function.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/daqboard2000.c | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
index 6e6a9bb..ed3b3e6 100644
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
< at >< at > -105,7 +105,6 < at >< at > Configuration options: not applicable, uses PCI auto config
 #include <linux/pci.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
-#include <linux/firmware.h>
 
 #include "../comedidev.h"
 
< at >< at > -560,22 +559,6 < at >< at > static int initialize_daqboard2000(struct comedi_device *dev,
 return result;
 }
 
-static int daqboard2000_upload_firmware(struct comedi_device *dev)
-{
-struct pci_dev *pcide

[PATCH 3/6] staging: comedi: drivers: generalize comedi_load_firmware()

H Hartley Sweeten — 2013-05-17T18:17:00

Move comedi_load_firmware() from jr3_pci.c to drivers.c and export
it for general use by the comedi drivers.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/comedidev.h       |  5 +++++
 drivers/staging/comedi/drivers.c         | 30 +++++++++++++++++++++++++++
 drivers/staging/comedi/drivers/jr3_pci.c | 35 +++++---------------------------
 3 files changed, 40 insertions(+), 30 deletions(-)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index ff7fc45..7adc426 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
< at >< at > -346,6 +346,11 < at >< at > int comedi_alloc_subdevices(struct comedi_device *, int);
 
 void comedi_spriv_free(struct comedi_device *, int subdev_num);
 
+int comedi_load_firmware(struct comedi_device *, struct device *,
+ const char *name,
+ int (*cb)(struct comedi_device *,
+   const u8 *data,

[PATCH 2/6] staging: comedi: jr3_pci: tidy up comedi_load_firmware()

H Hartley Sweeten — 2013-05-17T18:16:39

Refactor the function to remove some unnecessary indents and make
it a bit more concise.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/jr3_pci.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
index 42e78d1..9b61b55 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
< at >< at > -95,28 +95,28 < at >< at > struct jr3_pci_subdev_private {
 /* Hotplug firmware loading stuff */
 static int comedi_load_firmware(struct comedi_device *dev, const char *name,
 int (*cb)(struct comedi_device *dev,
-const u8 *data, size_t size))
+  const u8 *data, size_t size))
 {
 struct pci_dev *pcidev = comedi_to_pci_dev(dev);
-int result = 0;
 const struct firmware *fw;
 char *firmware_path;
+int ret;
+
+if (

[PATCH 1/6] staging: comedi: jr3_pci: use kasprintf

H Hartley Sweeten — 2013-05-17T18:16:12

kasprintf combines kmalloc and sprintf, and takes care of the size
calculation itself.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/jr3_pci.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
index c240e6d..42e78d1 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
< at >< at > -101,15 +101,11 < at >< at > static int comedi_load_firmware(struct comedi_device *dev, const char *name,
 int result = 0;
 const struct firmware *fw;
 char *firmware_path;
-static const char *prefix = "comedi/";
 
-firmware_path = kmalloc(strlen(prefix) + strlen(name) + 1, GFP_KERNEL);
+firmware_path = kasprintf(GFP_KERNEL, "comedi/%s", name);
 if (!firmware_path) {
 result = -ENOMEM;
 } else {
-firmware_path[0] = '\0';
-strcat(firmware_path, pr

[PATCH 0/6] staging: comedi: export comedi_load_firmware()

H Hartley Sweeten — 2013-05-17T18:15:43

Cleanup and make comedi_load_firmware(), currently in the jr3_pci driver,
a generic helper function that is exported by the comedi core.

Use the exported helper in the comedi drivers instead of duplicating
the code privately.

The usbdux* drivers currently use request_firmware_nowait() to get the
firmware image asynchronously.

The usbduxfast driver has already been converted to use request_firmware()
but the patches have not shown up on linux-next yet. I will submit a patch
to use the the exported helper in this driver as soon as they do.

The usbdux and usbduxsigma drivers will also be converted to request the
firmware synchronously and use the exported helper.

H Hartley Sweeten (6):
  staging: comedi: jr3_pci: use kasprintf
  staging: comedi: jr3_pci: tidy up comedi_load_firmware()
  staging: comedi: drivers: generalize comedi_load_firmware()
  staging: comedi: daqboard2000: use comedi_load_firmware()
  staging: comedi: me_daq: use comedi_load_firmware()
  staging: comedi: ni_pcidio: use comedi_load_fir

Re: [PATCHv11 3/4] zswap: add to mm/

Mel Gorman — 2013-05-17T17:00:53

I think there is a lot of ugly in there and potential for weird performance
bugs. I ran out of beans complaining about different parts during the
review but fixing it out of tree or in staging like it's been happening to
date has clearly not worked out at all. As starting points go, it could be
a hell of a lot worse. I do agree that it needs a big fat warning until
some of the ugly is beaten out of it.  Requiring that it address all the
issues such as automatic pool sizing, NUMA issues, proper allocation prior
to merging will just end up with an unreviewable set of patches again so
lets just bite the bullet because at least there is a chance reviewers
can follow the incremental developments. Merging it to drivers will not
address anything IMO.

Re: [PATCHv11 3/4] zswap: add to mm/

Mel Gorman — 2013-05-17T16:54:18

potentially reduces IO. No guarantees.


While this is likely, it's also not necessarily true if the swap device
is particularly fast. Also, swap devices can be asynchronously written,
is the same true for zswap? I doubt it as I would expect the compression
operation to slow down pages being added to swap cache.


I know I initially suggested an LRU but don't worry about this thing
being an LRU too much. A FIFO list would be just fine as the pages are
presumably idle if they ended up in zswap in the first place.


They underlying allocator should be tracking the number of physical
pages used, not this layer.


Document what these mean.


read_mostly


This will need additional love in the future. If you have an 8 node machine
then zswap pool could completely exhaust a single NUMA node with this
parameter. This is pretty much a big fat hammer that stops zswap getting
compltely out of control and taking over the system but it'll need some
sort of sensible automatic resizing based on system activity in the fut

Re: [PATCHv11 4/4] zswap: add documentation

Mel Gorman — 2013-05-17T16:04:31

*Potentially* reduces IO and *potentially* shows performance gains. If the
system is swap trashing, this may make things worse as you're generating
the same amount of IO but having to compress/decompress as well. If there
is less physical memory available because zswap pool is fragmented then an
application may be pushed to swap prematurely and again, the performance
is worse. Don't oversell this and the comment applies throughout the
documentation.

I also think it should be marked with a bit fat warning that it's a WIP
and an additional warning that the performance characteristics are very
heavily workload dependant.

Re: [PATCHv11 2/4] zbud: add to mm/

Mel Gorman — 2013-05-17T15:48:37

I'm not familiar with the code in staging/zcache/zbud.c and this looks
like a rewrite but I'm curious, why was an almost complete rewrite
necessary? The staging code looks like it had debugfs statistics and
the like that would help figure how well the packing was working and so
on. I guess it was probably because it was integrated tightly with other
components in staging but could that not be torn out? I'm guessing you
have a good reason but it'd be nice to see that in the changelog.


Fixing the size of the chunks at compile time is a very strict
limitation! Distributions will have to make that decision for all workloads
that might conceivably use zswap. Having the allocator only deal with pairs
of pages limits the worst-case behaviour where reclaim can generate lots of
IO to free a single physical page. However, the chunk size directly affects
the fragmentation properties, both internal and external, of this thing.
Once NCHUNKS is > 2 it is possible to create a workload that externally
fragments this allo

[PATCH 1/1] Staging: bcm: Fix of various code style issues.

Severin Gsponer — 2013-05-17T14:44:22

Changed comment style to C89 in Version.h
Fixed some whitespace issues in Typedefs.h
Changed comment style to C89 in vendorspecificextn.c
All issues found with checkpatch.pl

Signed-off-by: Severin Gsponer <svgsponer< at >gmail.com>
---
 drivers/staging/bcm/Typedefs.h           |   22 ++--
 drivers/staging/bcm/Version.h            |    8 +-
 drivers/staging/bcm/vendorspecificextn.c |  197 +++++++++++++++---------------
 3 files changed, 110 insertions(+), 117 deletions(-)

diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h
index a985abf..3dea509 100644
--- a/drivers/staging/bcm/Typedefs.h
+++ b/drivers/staging/bcm/Typedefs.h
< at >< at > -25,16 +25,16 < at >< at > typedef unsigned int B_UINT32;
 typedef unsigned long ULONG;
 typedef unsigned long DWORD;
 
-typedef char* PCHAR;
-typedef short* PSHORT;
-typedef int* PINT;
-typedef long* PLONG;
-typedef void* PVOID;
-
-typedef unsigned char* PUCHAR;
-typedef unsigned short* PUSHORT;
-typedef unsigned int* PUINT;
-typedef unsigned long* PULONG;
+typedef char *P