http://permalink.gmane.org/gmane.linux.bluez.kernel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.linux.bluez.kernel/36649 <pre>Hi Mikel, and many well-known UIs do not show this information. So what is the point exactly here. Maybe some UIs need to be brought into 2013 and being stuck in what we did 6 years ago. My question however was not about if a profile is connected or not, my question was why we always end up with stupid interim states like "connecting". I still do not agree with the fact that we need to disable profiles. However first order of business before I even consider allowing something like this is that we interop with ourselves on profiles (SDP record) updates and I have not seen anybody trying to handle this. My point is that we do not need the connecting state at all. What is it good for? Has this really been thought through. What happens if a Device1.Connect is triggered and then oFono starts later on. What is the expected behavior here? And what name is that exactly? How do you handle translation? For what usage? If you need special interfaces, there is always the possibility of a vendor plugin usi</pre> Marcel Holtmann 2013-06-19T08:02:13 http://permalink.gmane.org/gmane.linux.bluez.kernel/36648 <pre>Hi Lucas, if I remember this correctly, then I was doing it to be able to hide commands from the help output. Mainly commands that are on purpose duplicates. Regards Marcel </pre> Marcel Holtmann 2013-06-19T05:08:33 http://permalink.gmane.org/gmane.linux.bluez.kernel/36647 <pre>here is the hciconfig output: bluez 4.93 in phone hciconfig hci0 version hci0: Type: BR/EDR Bus: UART BD Address: 00:A0:C6:29:94:B4 ACL MTU: 1024:5 SCO MTU: 60:8 HCI Version: 4.0 (0x6) Revision: 0x0 LMP Version: 4.0 (0x6) Subversion: 0xc Manufacturer: Qualcomm (29) does this enough to get version? and via LMP Version, seems it is Bluetooth Core Specification 4.0. but as I know Google officially announced LE feature is not supported yet, see it: http://www.theverge.com/2013/5/15/4334882/google-adopts-bluetooth-smart-hints-android-update-within-two-months </pre> 明 2013-06-19T02:06:21 http://permalink.gmane.org/gmane.linux.bluez.kernel/36646 <pre>From: Lucas De Marchi &lt;lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; Having no description doesn't mean it's not an available command. So add command to the output of "help" command, even if it has no description. --- client/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/main.c b/client/main.c index b0a66d8..54af807 100644 --- a/client/main.c +++ b/client/main.c &lt; at &gt;&lt; at &gt; -1182,10 +1182,9 &lt; at &gt;&lt; at &gt; static void rl_handler(char *input) printf("Available commands:\n"); for (i = 0; cmd_table[i].cmd; i++) { -if (cmd_table[i].desc) -printf("\t%s %s\t%s\n", cmd_table[i].cmd, +printf("\t%s %s\t%s\n", cmd_table[i].cmd, cmd_table[i].arg ? : " ", -cmd_table[i].desc); +cmd_table[i].desc ? : ""); } done: </pre> Lucas De Marchi 2013-06-18T20:13:46 http://permalink.gmane.org/gmane.linux.bluez.kernel/36645 <pre>From: Lucas De Marchi &lt;lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; adapter_remove_device() is always called with remove_storage set to TRUE, so remove it. --- src/adapter.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/adapter.c b/src/adapter.c index 9e817f2..17f5508 100644 --- a/src/adapter.c +++ b/src/adapter.c &lt; at &gt;&lt; at &gt; -1019,8 +1019,7 &lt; at &gt;&lt; at &gt; static void service_auth_cancel(struct service_auth *auth) } static void adapter_remove_device(struct btd_adapter *adapter, -struct btd_device *dev, -gboolean remove_storage) +struct btd_device *dev) { GList *l; &lt; at &gt;&lt; at &gt; -1052,7 +1051,7 &lt; at &gt;&lt; at &gt; static void adapter_remove_device(struct btd_adapter *adapter, service_auth_cancel(auth); } -device_remove(dev, remove_storage); +device_remove(dev, TRUE); } struct btd_device *adapter_get_device(struct btd_adapter *adapter, &lt; at &gt;&lt; at &gt; -1514,7 +1513,7 &lt; at &gt;&lt; at &gt; static gboolean remove_temp_devices(gpointer user_data) next = g_slist_next(l); if (device_is_tempora</pre> Lucas De Marchi 2013-06-18T20:13:45 http://permalink.gmane.org/gmane.linux.bluez.kernel/36644 <pre>From: Lucas De Marchi &lt;lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; cmd + options have a maximum length of 25. Align the description after this value. In order not to reach 80 chars so easily change the first \t to 2 spaces, like is done in udev, kmod, systemd, etc. --- client/main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/client/main.c b/client/main.c index 54af807..db6705f 100644 --- a/client/main.c +++ b/client/main.c &lt; at &gt;&lt; at &gt; -1182,9 +1182,10 &lt; at &gt;&lt; at &gt; static void rl_handler(char *input) printf("Available commands:\n"); for (i = 0; cmd_table[i].cmd; i++) { -printf("\t%s %s\t%s\n", cmd_table[i].cmd, -cmd_table[i].arg ? : " ", -cmd_table[i].desc ? : ""); +printf(" %s %-*s %s\n", cmd_table[i].cmd, +(int)(25 - strlen(cmd_table[i].cmd)), +cmd_table[i].arg ? : "", +cmd_table[i].desc ? : ""); } done: </pre> Lucas De Marchi 2013-06-18T20:13:47 http://permalink.gmane.org/gmane.linux.bluez.kernel/36643 <pre>We are currently compiling gdbus 3 times: one for tests, one for bluetoothd and another for obexd. $ ls gdbus/*watch.o gdbus/bluetoothd-watch.o gdbus/obexd-watch.o gdbus/watch.o Instead of prepending $(gdbus_sources) to several _SOURCES variable, use a convenience library. --- Makefile.am | 16 +++++++++++----- Makefile.obexd | 4 ++-- Makefile.tools | 25 ++++++++++++------------- 3 files changed, 25 insertions(+), 20 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9d570fb..19782ce 100644 --- a/Makefile.am +++ b/Makefile.am &lt; at &gt;&lt; at &gt; -112,6 +112,11 &lt; at &gt;&lt; at &gt; builtin_nodist = include Makefile.plugins +noinst_LTLIBRARIES += gdbus/libgdbus.la +gdbus_libgdbus_la_SOURCES = $(gdbus_sources) +gdbus_libgdbus_la_LDFLAGS = $(AM_LDFLAGS) &lt; at &gt;DBUS_LIBS&lt; at &gt; &lt; at &gt;GLIB_LIBS&lt; at &gt; +gdbus_libgdbus_la_CFLAGS = $(AM_CFLAGS) &lt; at &gt;DBUS_CFLAGS&lt; at &gt; &lt; at &gt;GLIB_CFLAGS&lt; at &gt; + if MAINTAINER_MODE plugin_LTLIBRARIES += plugins/external-dummy.la plugins_external_dummy_la_SOURCES = plugins/external-dummy.c &lt; at &gt;&lt; at &gt; -122,7 +127,7 &lt; at &gt;&lt; at &gt; endif libexec_PROGRAMS +=</pre> Lucas De Marchi 2013-06-18T20:13:43 http://permalink.gmane.org/gmane.linux.bluez.kernel/36642 <pre>From: Lucas De Marchi &lt;lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index c6e0ae2..550b350 100644 --- a/.gitignore +++ b/.gitignore &lt; at &gt;&lt; at &gt; -59,6 +59,8 &lt; at &gt;&lt; at &gt; tools/avtest tools/bdaddr tools/btiotest tools/mpris-player +tools/bluetooth-player +tools/l2cap-tester test/sap_client.pyc test/bluezutils.pyc unit/test-eir </pre> Lucas De Marchi 2013-06-18T20:13:44 http://permalink.gmane.org/gmane.linux.bluez.kernel/36641 <pre>Hi Christian, On Mon, Jun 17, 2013 at 11:35 AM, Christian Fetzer &lt;christian.fetzer-Y0tyK2LzuKvpgbXj0Ix11Q&lt; at &gt;public.gmane.org&gt; wrote: This patch has been applied, the rest of the set I will review latter as we are preparing a new release. -- Luiz Augusto von Dentz </pre> Luiz Augusto von Dentz 2013-06-18T11:53:37 http://permalink.gmane.org/gmane.linux.bluez.kernel/36640 <pre>Hi Christian, On Mon, Jun 17, 2013 at 3:10 PM, Christian Fetzer &lt;christian.fetzer-Y0tyK2LzuKvpgbXj0Ix11Q&lt; at &gt;public.gmane.org&gt; wrote: Pushed, thanks. -- Luiz Augusto von Dentz </pre> Luiz Augusto von Dentz 2013-06-18T11:33:44 http://permalink.gmane.org/gmane.linux.bluez.kernel/36639 <pre>Hi Luiz, On Tue, Jun 18, 2013, Luiz Augusto von Dentz wrote: All three patches have been applied. Thanks. Johan </pre> Johan Hedberg 2013-06-18T10:29:36 http://permalink.gmane.org/gmane.linux.bluez.kernel/36638 <pre>Hi Luiz, On Tue, Jun 18, 2013, Luiz Augusto von Dentz wrote: Applied. Thanks. Johan </pre> Johan Hedberg 2013-06-18T10:29:16 http://permalink.gmane.org/gmane.linux.bluez.kernel/36637 <pre>From: Luiz Augusto von Dentz &lt;luiz.von.dentz-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; The response to RegisterNotification for event settings changed was not setting the initial length properly which cause the code to send malformed/invalid PDUs. --- profiles/audio/avrcp.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c index f0554fe..f028da9 100644 --- a/profiles/audio/avrcp.c +++ b/profiles/audio/avrcp.c &lt; at &gt;&lt; at &gt; -1450,20 +1450,25 &lt; at &gt;&lt; at &gt; static uint8_t avrcp_handle_register_notification(struct avrcp *session, len = 1; break; case AVRCP_EVENT_SETTINGS_CHANGED: +len = 1; settings = player_list_settings(player); -pdu-&gt;params[++len] = g_list_length(settings); +pdu-&gt;params[len++] = g_list_length(settings); for (; settings; settings = settings-&gt;next) { const char *key = settings-&gt;data; -uint8_t attr = attr_to_val(key); +int attr; int val; +attr = attr_to_val(key); +if (attr &lt; 0) +continue; + </pre> Luiz Augusto von Dentz 2013-06-18T08:09:53 http://permalink.gmane.org/gmane.linux.bluez.kernel/36636 <pre>From: Luiz Augusto von Dentz &lt;luiz.von.dentz-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; The value has to be converted to MPRIS setting otherwise the player won't recognize it and will probably discard the change. --- profiles/audio/avrcp.c | 4 ++-- profiles/audio/media.c | 54 +++++++++++++++++++++++++++++++++++++++++++------- 2 files changed, 49 insertions(+), 9 deletions(-) diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c index f028da9..ffc6415 100644 --- a/profiles/audio/avrcp.c +++ b/profiles/audio/avrcp.c &lt; at &gt;&lt; at &gt; -661,8 +661,8 &lt; at &gt;&lt; at &gt; void avrcp_player_event(struct avrcp_player *player, uint8_t id, if (val &lt; 0) return; -pdu-&gt;params[++size] = attr; -pdu-&gt;params[++size] = val; +pdu-&gt;params[size++] = attr; +pdu-&gt;params[size++] = val; break; default: error("Unknown event %u", id); diff --git a/profiles/audio/media.c b/profiles/audio/media.c index 45dfe53..d4d82cf 100644 --- a/profiles/audio/media.c +++ b/profiles/audio/media.c &lt; at &gt;&lt; at &gt; -1007,12 +1007,54 &lt; at &gt;&lt; at &gt; static const char *get_sett</pre> Luiz Augusto von Dentz 2013-06-18T08:09:54 http://permalink.gmane.org/gmane.linux.bluez.kernel/36635 <pre>From: Luiz Augusto von Dentz &lt;luiz.von.dentz-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; We should notify only the setting that has changed not all of them. --- profiles/audio/avrcp.c | 30 +++++++++++++----------------- profiles/audio/avrcp.h | 3 ++- profiles/audio/media.c | 7 +------ 3 files changed, 16 insertions(+), 24 deletions(-) diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c index 730f061..f0554fe 100644 --- a/profiles/audio/avrcp.c +++ b/profiles/audio/avrcp.c &lt; at &gt;&lt; at &gt; -612,13 +612,15 &lt; at &gt;&lt; at &gt; static int play_status_to_val(const char *status) return -EINVAL; } -void avrcp_player_event(struct avrcp_player *player, uint8_t id, void *data) +void avrcp_player_event(struct avrcp_player *player, uint8_t id, +const void *data) { uint8_t buf[AVRCP_HEADER_LENGTH + 9]; struct avrcp_header *pdu = (void *) buf; uint16_t size; GSList *l; -GList *settings; +int attr; +int val; if (player-&gt;sessions == NULL) return; &lt; at &gt;&lt; at &gt; -649,24 +651,18 &lt; at &gt;&lt; at &gt; void avrcp_player_event(struct avrcp_playe</pre> Luiz Augusto von Dentz 2013-06-18T08:09:52 http://permalink.gmane.org/gmane.linux.bluez.kernel/36634 <pre>From: Luiz Augusto von Dentz &lt;luiz.von.dentz-ral2JQCrhuEAvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; Invalid read of size 8 at 0x470101: update_bredr_services (device.c:2784) by 0x470591: browse_cb (device.c:2975) by 0x458B0E: search_completed_cb (sdp-client.c:186) by 0x47C154: sdp_process (sdp.c:4343) by 0x458954: search_process_cb (sdp-client.c:205) by 0x3F31A47A54: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3400.2) by 0x3F31A47D87: ??? (in /usr/lib64/libglib-2.0.so.0.3400.2) by 0x3F31A48181: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3400.2) by 0x40A265: main (main.c:595) Address 0x0 is not stack'd, malloc'd or (recently) free'd --- src/device.c | 65 +++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 38 insertions(+), 27 deletions(-) diff --git a/src/device.c b/src/device.c index 0f75c60..c324764 100644 --- a/src/device.c +++ b/src/device.c &lt; at &gt;&lt; at &gt; -2677,6 +2677,40 &lt; at &gt;&lt; at &gt; static int rec_cmp(const void *a, const void *b) return r1-&gt;handle - r</pre> Luiz Augusto von Dentz 2013-06-18T08:08:54 http://permalink.gmane.org/gmane.linux.bluez.kernel/36633 <pre> Loan Syndicacion Am AFG Guaranty Trust Bank, zu strukturieren wir Kreditlinien treffen Sie unsere Kunden spezifischen geschäftlichen Anforderungen und einen deutlichen Mehrwert für unsere Kunden Unternehmen. eine Division der AFG Finance und Private Bank plc. Wenn Sie erwägen, eine große Akquisition oder ein Großprojekt sind, können Sie brauchen eine erhebliche Menge an Kredit. AFG Guaranty Trust Bank setzen können zusammen das Syndikat, das die gesamte Kredit schnürt für Sie. Als Bank mit internationaler Reichweite, sind wir gekommen, um Darlehen zu identifizieren Syndizierungen als Teil unseres Kerngeschäfts und durch spitzte diese Zeile aggressiv sind wir an einem Punkt, wo wir kommen, um als erkannt haben Hauptakteur in diesem Bereich. öffnen Sie ein Girokonto heute mit einem Minimum Bankguthaben von 500 £ und Getup zu £ 10.000 als Darlehen und auch den Hauch einer Chance und gewann die Sterne Preis von £ 500.000 in die sparen und gewinnen promo in may.aply jetzt. mit dem Folowin</pre> AFG GTBANK LOAN 2013-06-17T19:28:00 http://permalink.gmane.org/gmane.linux.bluez.kernel/36632 <pre>Hi, On Fri, Jun 14, 2013 at 3:41 PM, Luiz Augusto von Dentz &lt;luiz.dentz-Re5JQEeQqe8AvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; wrote: This patch-set has been applied. -- Luiz Augusto von Dentz </pre> Luiz Augusto von Dentz 2013-06-17T16:46:53 http://permalink.gmane.org/gmane.linux.bluez.kernel/36631 <pre>From: Christian Fetzer &lt;christian.fetzer-98C5kh4wR6ohFhg+JK9F0w&lt; at &gt;public.gmane.org&gt; The function obc_session_mkdir needs to use file_op_complete as callback. 0 0x00007ffff72f7553 in ?? () from /usr/lib/libdbus-1.so.3 1 0x00007ffff72f7dff in ?? () from /usr/lib/libdbus-1.so.3 2 0x00007ffff72fef9a in dbus_message_get_sender () from /usr/lib/libdbus-1.so.3 3 0x00007ffff72feff9 in dbus_message_new_method_return () from /usr/lib/libdbus-1.so.3 4 0x000000000043c93f in async_cb (session=0x6a9d30, transfer=0x0, err=0x0, user_data=0x675660) at obexd/client/ftp.c:65 5 0x0000000000438c7c in async_cb (obex=0x6aa980, err=0x0, rsp=0x67a690, user_data=0x67ced0) at obexd/client/session.c:1035 6 0x000000000041cbcc in handle_response (obex=0x6aa980, err=0x0, rsp=0x67a690) at gobex/gobex.c:949 7 0x000000000041d49f in incoming_data (io=0x67d0f0, cond=G_IO_IN, user_data=0x6aa980) at gobex/gobex.c:1192 8 0x00007ffff702de46 in g_main_context_dispatch () fr</pre> Christian Fetzer 2013-06-17T12:10:55 http://permalink.gmane.org/gmane.linux.bluez.kernel/36630 <pre>From: Christian Fetzer &lt;christian.fetzer-98C5kh4wR6ohFhg+JK9F0w&lt; at &gt;public.gmane.org&gt; The function setpath_complete has to be called with a pending_request as user_data. In one possible error case, the current code calls it incorrectly with setpath_data. --- obexd/client/session.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/obexd/client/session.c b/obexd/client/session.c index eda3412..a780b8c 100644 --- a/obexd/client/session.c +++ b/obexd/client/session.c &lt; at &gt;&lt; at &gt; -967,7 +967,7 &lt; at &gt;&lt; at &gt; static void setpath_cb(GObex *obex, GError *err, GObexPacket *rsp, p-&gt;req_id = g_obex_setpath(obex, next, setpath_cb, p, &amp;err); if (err != NULL) { -setpath_complete(p-&gt;session, NULL, err, data); +setpath_complete(p-&gt;session, NULL, err, user_data); g_error_free(err); } } </pre> Christian Fetzer 2013-06-17T12:10:53 http://permalink.gmane.org/gmane.linux.bluez.kernel/36629 <pre>From: Christian Fetzer &lt;christian.fetzer-98C5kh4wR6ohFhg+JK9F0w&lt; at &gt;public.gmane.org&gt; The file_op_complete callback added for the OBEX session command queuing is called with a file_data parameter and not with a pending_request. This fixes a crash when calling one of the file commands (like delete). 0 0x0000000000438cd6 in file_op_complete (session=0x6a9d30, transfer=0x0, err=0x0, user_data=0x6762e0) at obexd/client/session.c:1054 1 0x0000000000438c64 in async_cb (obex=0x6aa980, err=0x0, rsp=0x67a710, user_data=0x6ac2c0) at obexd/client/session.c:1035 2 0x000000000041cbcc in handle_response (obex=0x6aa980, err=0x0, rsp=0x67a710) at gobex/gobex.c:949 3 0x000000000041d49f in incoming_data (io=0x67d0f0, cond=G_IO_IN, user_data=0x6aa980) at gobex/gobex.c:1192 4 0x00007ffff702de46 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 5 0x00007ffff702e198 in ?? () from /usr/lib/libglib-2.0.so.0 6 0x00007ffff702e59a in g_main_loop_run () from /</pre> Christian Fetzer 2013-06-17T12:10:54 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.bluez.kernel