http://permalink.gmane.org/gmane.emacs.diffs hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.emacs.diffs/120609 <pre> I just meant it would be nice to automatically test the whole of ruby.rb with both ruby-use-smie on and off. With otherwise default settings. Ah, okay. If you think testing the non-important engine is not important, I'm not going to argue. So, you prefer the multi-file approach over delineating the one file? I think they're more or less equivalent, only you're forced to have more files open when debugging. By "cases", I mean just different situations here, not different indentation settings. Like currently, we have a bunch of separate `ruby-should-indent-buffer' automated tests, ported from the Ruby repository. If I were to make a blunder in the code that breaks, say, all of them, seeing separate diffs for each case should be easier to comprehend than the big summary diff for one big file. Naming tests helps, too. </pre> Dmitry Gutov 2013-05-23T01:59:00 http://permalink.gmane.org/gmane.emacs.diffs/120608 <pre> Yes. No, there is only one correct indentation and both engines should find it. Also only one engine is important at any given time (if/when the SMIE code becomes good enough, it will make the other one obsolete). I don't see any problem with that. FWIW, the need for such things will largely depend on how configurable the indentation is. For cc-mode's hellish configurability there's probably a need for something serious, but for most modes I didn't find much need for such details. In many other cases you can get away with just setting the indentation vars to "unusual values" in the file-local vars so that it's obvious enough whether that value is obeyed. Stefan </pre> Stefan Monnier 2013-05-23T01:24:11 http://permalink.gmane.org/gmane.emacs.diffs/120607 <pre> Can't disagree with that. Sounds interesting. That would take some work to implement, I suppose. Having ruby.rb indented according to the default settings and test any alternative settings via ERT sounds fine, except we now have two indentation engines, after all, and ideally we'd like to test all indentation cases in both of them, automatically. How about having one big test in ruby-mode-tests.el that would load test/indent/ruby.rb and do the reindent-and-compare thing that is currently performed via make? For bonus points, we could delineate test.rb with comments in some special way, so that we can have multiple tests "coexist" in it (by being able to refer and test just one part). </pre> Dmitry Gutov 2013-05-22T23:25:58 http://permalink.gmane.org/gmane.emacs.diffs/120606 <pre> True. Tho most bug reports about regexp literals do include such unpaired quotes or parens (since that's the case where the lack of special treatment really hurts), so I'd expect most "test cases" in the test/indent directory to include such entries. Probably. Tho you could potentially change the test so it first un-htmlizes the file, then runs font-lock, then htmlfontify, in which case the file stored in test/indent would be the html version. I guess that sounds more like enriched-mode than htmlfontify-buffer. Yes. We could, but then we'd lose the easy way to test&amp;debug interactively by simply visiting the file. ERT isn't much worse in that case (and the two aren't mutually exclusive: use test/indent the general indentation rules, and use ERT rules to check how indentation obeys the various indentation variables). Stefan </pre> Stefan Monnier 2013-05-22T23:01:17 http://permalink.gmane.org/gmane.emacs.diffs/120605 <pre>------------------------------------------------------------ revno: 112672 fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14424 author: Barry OReilly &lt;gundaetiapo&lt; at &gt;gmail.com&gt; committer: Stefan Monnier &lt;monnier&lt; at &gt;iro.umontreal.ca&gt; branch nick: trunk timestamp: Wed 2013-05-22 17:35:00 -0400 message: * src/casetab.c (init_casetab_once): Fix last change. modified: src/ChangeLog src/casetab.c </pre> Stefan Monnier 2013-05-22T21:35:00 http://permalink.gmane.org/gmane.emacs.diffs/120604 <pre>------------------------------------------------------------ revno: 112673 author: Adam Sjøgren &lt;asjo&lt; at &gt;koldfront.dk&gt; committer: Katsumi Yamaoka &lt;yamaoka&lt; at &gt;jpl.org&gt; branch nick: trunk timestamp: Wed 2013-05-22 22:16:29 +0000 message: lisp/gnus/gnus-spec.el (gnus-parse-complex-format): Try to maximize compatibility modified: lisp/gnus/gnus-spec.el </pre> Katsumi Yamaoka 2013-05-22T22:16:29 http://permalink.gmane.org/gmane.emacs.diffs/120603 <pre> That's largely true, with the exception that some syntax-propertization is mostly performed for the sake of appearance. An unpropertized regexp literal without unpaired parens or quotes inside is unlikely to fail the test. So, there would be a reference html file everyone would have to update after making a change in indent/ruby.rb? I see, that's better. I suppose we could set the variables via file-local vars mechanism, but that'll require us to have multiple files, one per combination of variables. Or introduce some new kind of preprocessing, say, treat the same kind of comment in the middle of the file as an indication to stop, change the values, and indent the part of the file below with new values applied. </pre> Dmitry Gutov 2013-05-22T22:10:26 http://permalink.gmane.org/gmane.emacs.diffs/120602 <pre> No, indeed. It does mostly work to test the syntax-ppss behavior, tho, because a bug in it will typically cause bugs in indentation as well. IOW it does largely test syntax-table and syntax-propertize, but it doesn't test the font-lock-keywords part. We could potentially test it by calling htmlfontify-buffer. No, I just do something like make ruby.rb.test EMACS="emacs -Q --eval '(setq ruby-use-smie t)'" Indeed, that's a widespread limitation with the current system. Stefan </pre> Stefan Monnier 2013-05-22T21:58:09 http://permalink.gmane.org/gmane.emacs.diffs/120601 <pre> Speaking of SMIE and indentation, though, don't you find it inconvenient that to run the tests with it enabled, you have to put (setq ruby-use-smie t) in your init file, and then maybe remove it later and rerun the tests, to see that some changes did't break anything in the default algorithm? M-: (setq ruby-use-smie t) is easier. ruby-mode also has customization variables that change indentation behavior (at least one, for now, and we should add more). How do you propose to test that? </pre> Dmitry Gutov 2013-05-22T19:15:49 http://permalink.gmane.org/gmane.emacs.diffs/120600 <pre> Good point, though I think I still prefer the reliability of automated testing over that convenience. Huh, I didn't know that. I don't think there can be a way to do the same for syntax highlighting, though. Should I move all indentation tests to ruby.rb, and everything else to ruby-mode-tests.el? </pre> Dmitry Gutov 2013-05-22T19:07:37 http://permalink.gmane.org/gmane.emacs.diffs/120599 <pre> I find it inconvenient, actually, because when the test fails, it's a handy to be able to have a ruby-mode buffer where I can try out sexp movement and indentation functions "in the usual way", together with Edebug if needed. Indentation checking is automated, via "(cd test/indent; make ruby.rb.test)" It's not for syntax-highlighting, sadly. Ruby's SMIE indentation is very much "work in progress", indeed. Stefan </pre> Stefan Monnier 2013-05-22T18:55:42 http://permalink.gmane.org/gmane.emacs.diffs/120598 <pre>------------------------------------------------------------ revno: 112671 fixes bug: http://debbugs.gnu.org/14433 committer: Leo Liu &lt;sdl.web&lt; at &gt;gmail.com&gt; branch nick: trunk timestamp: Wed 2013-05-22 23:28:42 +0800 message: * progmodes/octave.el (inferior-octave-startup): Fix bug#14433. modified: lisp/ChangeLog lisp/progmodes/octave.el </pre> Leo Liu 2013-05-22T15:28:42 http://permalink.gmane.org/gmane.emacs.diffs/120597 <pre>------------------------------------------------------------ revno: 112669 committer: Michael Albinus &lt;michael.albinus&lt; at &gt;gmx.de&gt; branch nick: trunk timestamp: Wed 2013-05-22 16:47:19 +0200 message: * autorevert.el (auto-revert-notify-add-watch) (auto-revert-notify-handler): Add `attrib' for the inotify case, it indicates changes in file modification time. modified: lisp/ChangeLog lisp/autorevert.el </pre> Michael Albinus 2013-05-22T14:47:19 http://permalink.gmane.org/gmane.emacs.diffs/120596 <pre>------------------------------------------------------------ revno: 112668 author: Daiki Ueno &lt;ueno&lt; at &gt;gnu.org&gt; committer: Katsumi Yamaoka &lt;yamaoka&lt; at &gt;jpl.org&gt; branch nick: trunk timestamp: Wed 2013-05-22 13:18:40 +0000 message: lisp/gnus/mml2015.el (mml2015-epg-sign): Make sure to insert newline after the signed data to conform the standard (Bug#14232) modified: lisp/gnus/ChangeLog lisp/gnus/mml2015.el </pre> Katsumi Yamaoka 2013-05-22T13:18:40 http://permalink.gmane.org/gmane.emacs.diffs/120595 <pre>------------------------------------------------------------ revno: 112667 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Wed 2013-05-22 00:50:30 -0700 message: Tweak byte-compile-file-form-autoload warnings * emacs-lisp/bytecomp.el (byte-compile-file-form-autoload): Always delete the autoloaded function from the noruntime and unresolved functions lists. modified: lisp/ChangeLog lisp/emacs-lisp/bytecomp.el </pre> Glenn Morris 2013-05-22T07:50:30 http://permalink.gmane.org/gmane.emacs.diffs/120594 <pre>------------------------------------------------------------ revno: 112666 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Wed 2013-05-22 00:30:44 -0700 message: Add some declarations to url-handlers.el * lisp/url/url-handlers.el (mm-save-part-to-file, mm-destroy-parts) (mm-decode-string, mail-content-type-get): Declare. modified: lisp/url/ChangeLog lisp/url/url-handlers.el </pre> Glenn Morris 2013-05-22T07:30:44 http://permalink.gmane.org/gmane.emacs.diffs/120593 <pre>------------------------------------------------------------ revno: 112665 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Wed 2013-05-22 00:07:19 -0700 message: Silence allout.el compilation * lisp/allout.el: No need to load epa, epg, overlay when compiling. (epg-context-set-passphrase-callback, epg-list-keys) (epg-decrypt-string, epg-encrypt-string, epg-user-id-string) (epg-key-user-id-list): Declare. modified: lisp/ChangeLog lisp/allout.el </pre> Glenn Morris 2013-05-22T07:07:19 http://permalink.gmane.org/gmane.emacs.diffs/120592 <pre>------------------------------------------------------------ revno: 112664 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Tue 2013-05-21 20:21:30 -0700 message: Small viper clean-up * lisp/emulation/viper-cmd.el (viper-set-searchstyle-toggling-macros) (viper-set-parsing-style-toggling-macro) (viper-set-emacs-state-searchstyle-macros): Use called-interactively-p on Emacs. (viper-looking-back): Make it an obsolete alias. Update callers. * lisp/emulation/viper-ex.el: Load viper-keym, not viper-cmd. Use looking-back rather than viper-looking-back. (viper-tmp-insert-at-eob, viper-enlarge-region) (viper-read-string-with-history, viper-register-to-point) (viper-append-to-register, viper-change-state-to-vi) (viper-backward-char-carefully, viper-forward-char-carefully) (viper-Put-back, viper-put-back, viper-add-newline-at-eob-if-necessary) (viper-change-state-to-emacs): Declare. * lisp/emulation/viper-macs.el: Load viper-mous, viper-ex, not viper-cmd. (viper-ch</pre> Glenn Morris 2013-05-22T03:21:30 http://permalink.gmane.org/gmane.emacs.diffs/120591 <pre>------------------------------------------------------------ revno: 112663 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Tue 2013-05-21 20:17:22 -0700 message: * lisp/vc/ediff.el (ediff-version): Use called-interactively-p on Emacs. modified: lisp/ChangeLog lisp/vc/ediff.el </pre> Glenn Morris 2013-05-22T03:17:22 http://permalink.gmane.org/gmane.emacs.diffs/120590 <pre>------------------------------------------------------------ revno: 112662 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Tue 2013-05-21 20:16:05 -0700 message: * progmodes/idlw-help.el (idlwave-help-fontify): Use called-interactively-p. modified: lisp/ChangeLog lisp/progmodes/idlw-help.el </pre> Glenn Morris 2013-05-22T03:16:05 http://permalink.gmane.org/gmane.emacs.diffs/120589 <pre>------------------------------------------------------------ revno: 112659 committer: Glenn Morris &lt;rgm&lt; at &gt;gnu.org&gt; branch nick: trunk timestamp: Tue 2013-05-21 19:56:22 -0700 message: ChangeLog fix modified: src/ChangeLog </pre> Glenn Morris 2013-05-22T02:56:22 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.emacs.diffs