gmane.editors.vim.devel

Re: bug related to patch 7.3.449 (Autocommands caused command to abort)

Alex Efros — 2012-05-26T06:50:00

Hi!

On Sat, May 26, 2012 at 07:59:41AM +0200, Christian Brabandt wrote:

That still doesn't make sense to me. If autocommand closed some
window/buffer then current command should be aborted? Why is that?

Is there any way to work around this in BufWinLeave autocommand?

(I've work around this by moving logic to close orphan location-list
on BufEnter into that location-list, but that's ugly because it's
complicated to detect is that location-list have/have not related source
file opened, while on source file's BufWinLeave it's enough to :lclose.)

As for 'unexpected', for me it's much more unexpected to get location-list
window opened full screen after you've closed source file related to that
location-list…

Re: [patch] v/V with a count

Christian Brabandt — 2012-05-26T06:01:09

Hi James!

On Fr, 25 Mai 2012, James McCoy wrote:


I saw it in the code and didn't know how to trigger that code path ;)

But anyhow, it should still work and I think it does.

Mit freundlichen Grüßen
Christian

Re: bug related to patch 7.3.449 (Autocommands caused command to abort)

Christian Brabandt — 2012-05-26T05:59:41

Hi Alex!

On Fr, 25 Mai 2012, Alex Efros wrote:


I don't think so, but Bram has the final saying. I would certainly find 
it unexpected, if this would quit my vim. The error is simply telling 
you, that an autocommand closed a window/buffer and that's why Vim 
aborts executing the :q command.


I'll look into it.

regards,
Christian

Re: bug related to patch 7.3.449 (Autocommands caused command to abort)

Alex Efros — 2012-05-25T20:03:53

Hi!

On Thu, May 24, 2012 at 10:14:41PM +0200, Christian Brabandt wrote:

I'm not really understood what you mean, sorry.

I can see reason for 'E855: Autocommands caused command to abort'
when something bad happens in a loop, for example like this:

    :autocmd BufWinLeave * lclose

when it run with open location-list and result in calling :lclose
again while executing BufWinLeave as result of :lclose.

But I don't see any reason why E855 happens using this:

    $ vi -u /dev/null --noplugin
    :autocmd BufWinLeave * if empty(getbufvar(0+expand('<abuf>'), '&bt')) | lclose | endif
    :lexpr system('echo :1:some')
    :lopen
    :wincmd p
    :q
    E855: Autocommands caused command to abort

So, is this a bug or not?


Thanks! But, sorry, I just found another simple way to crash 7.3.530
without tabs:

    $ vi -u /dev/null --noplugin
    :autocmd BufWinLeave * if empty(getbufvar(0+expand('<abuf>'), '&bt')) | lclose | endif
    :lexpr system('echo :1:some')
    :lopen
    :wincmd p
    :bd
    Vim: Caught

Re: v/V with a count

Ingo Karkat — 2012-05-25T18:45:59


Yeah, I noticed that, too. This is probably due to an implementation detail, and
I think it should be changed. I would have expected 1v to work as soon as the
visual selection has been quit via <Esc>; i.e. as soon as gv is able to restore it.

Re: Patch 7.3.530

tux. — 2012-05-25T18:27:00

John Marriott schrob am 25. May. 2012 um 15:09 Zeit:

At least that fixes said issue for me.

Re: [patch] v/V with a count

Ben Fritz — 2012-05-25T18:24:34

I've found that in order for 1v to work, you need to have "done something" with the last visual selection. E.g. this will not work:

vaw<Esc>3w1v (enter visual mode, select a word, leave visual mode, move forward 3 words, try to select the same sized visual area)

But this will work:

vawy3w1v (enter visual mode, select a word, yank it, move forward 3 words, select the same sized visual area)

Re: Patch 7.3.527

Dominique Pellé — 2012-05-25T16:25:55

...


Hi John

I'm not sure why the patch does not apply cleanly.
It's a bit special since the old code contained non-ASCII latin1 char.

Can't you get the latest source with Mercurial?  It's more
convenient than using patches.  If somehow you don't like
Mercurial and the patch does not apply cleanly, you can
download the latest version of src/charset.c here:

http://code.google.com/p/vim/source/browse/src/charset.c

(click on "View raw file")

Regards

Re: [patch] v/V with a count

James McCoy — 2012-05-25T15:41:39

I saw that in the docs when reviewing your patch, but I couldn't
actually get Vim to do what it said should happen.  1v just made Vim
beep at me.  So, did that actually work or am I just unable to figure
what needs to be done to make it work?

Re: v/V with a count

Ingo Karkat — 2012-05-25T14:24:52


Good catch, Ben! I use that (also with a count > 1) in some of my plugins, and I
also find it useful in interactive use, though mostly for characterwise mode.

Alternatively, we could offer a Vimscript implementation (maybe just for
linewise mode, which I find most useful) in vimrc_example.vim, so users can
choose whether to have this, and plugins aren't affected (when using :normal!).

    nnoremap <silent> V :<C-u>execute 'normal! V' . v:count1 . '_'<CR>

Re: [patch] v/V with a count

Ben Fritz — 2012-05-25T14:05:49

Will this break typing 1v to reselect an area equal to the last visual selection, but at the new cursor position? From just below :help <LeftRelease>:


If Visual mode is not active and the "v", "V" or CTRL-V is preceded with a
count, the size of the previously highlighted area is used for a start.  You
can then move the end of the highlighted area and give an operator.  The type
of the old area is used (character, line or blockwise).
- Linewise Visual mode: The number of lines is multiplied with the count.
- Blockwise Visual mode: The number of lines and columns is multiplied with
  the count.
- Normal Visual mode within one line: The number of characters is multiplied
  with the count.
- Normal Visual mode with several lines: The number of lines is multiplied
  with the count, in the last line the same number of characters is used as
  in the last line in the previously highlighted area.
The start of the text is the Cursor position.  If the "$" command was used as
one of the last commands to extend the hi

Re: Substitution of metacharacters

Ben Fritz — 2012-05-25T14:01:03

Well, there's this in todo.txt:

7   More features in the find/replace dialog:
    - regexp on/off
    - search in selection/buffer/all buffers/directory
       when all buffers/directory is used:
- filter for file name
       when directory is used:
- subdirectory on/off
- top directory browser

Re: Patch 7.3.527

John Marriott — 2012-05-25T13:13:30

Re: Patch 7.3.530

John Marriott — 2012-05-25T13:09:18

Patch 7.3.530

Bram Moolenaar — 2012-05-25T12:06:52

Patch 7.3.530 (after 7.3.520)
Problem:    Gvim does not work when 'guioptions' includes "f". (Davido)
Solution:   Call gui_mch_init_check() when running GUI in the foreground.
    (Yasuhiro Matsumoto)
Files:    src/gui.c


*** ../vim-7.3.529/src/gui.c2012-05-18 17:03:13.000000000 +0200
--- src/gui.c2012-05-25 14:01:26.000000000 +0200
***************
*** 102,107 ****
--- 102,111 ----
      else
  #endif
      {
+ /* If there is 'f' in 'guioptions' and specify -g argument,
+  * gui_mch_init_check() was not called yet.  */
+ if (gui_mch_init_check() != OK)
+     exit(1);
  gui_attempt_start();
      }
  
*** ../vim-7.3.529/src/version.c2012-05-25 13:12:33.000000000 +0200
--- src/version.c2012-05-25 14:05:46.000000000 +0200
***************
*** 716,717 ****
--- 716,719 ----
  {   /* Add new patch number below this line */
+ /**/
+     530,
  /**/

Re: [patch] v/V with a count

Bram Moolenaar — 2012-05-25T11:12:51

Christian Brabandt wrote:


Thanks, that's useful.  I will change it to take care of 'selectmode'.
And update the docs.

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

Bram Moolenaar — 2012-05-25T11:12:51

Ben Fritz wrote:


There was a specific library that some Linux versions compiled Vim with,
and this library was GPL.  A Vim built that way could not be
distributed, because there is a small incompatibility between GPL and
the Vim license.  To solve that the dual-license method was introduced.
Richard Stallman was involved in updating the license text, thus it
should be OK for everybody.

Patch 7.3.529

Bram Moolenaar — 2012-05-25T11:12:51

Patch 7.3.529
Problem:    Using a count before "v" and "V" does not work (Kikyous)
Solution:   Make the count select that many characters or lines. (Christian
    Brabandt)
Files:    src/normal.c


*** ../vim-7.3.528/src/normal.c2012-05-25 11:04:34.000000000 +0200
--- src/normal.c2012-05-25 13:12:06.000000000 +0200
***************
*** 7660,7672 ****
      else    /* start Visual mode */
      {
  check_visual_highlight();
! if (cap->count0)    /* use previously selected part */
  {
!     if (resel_VIsual_mode == NUL)   /* there is none */
!     {
! beep_flush();
! return;
!     }
      VIsual = curwin->w_cursor;
  
      VIsual_active = TRUE;
--- 7660,7668 ----
      else    /* start Visual mode */
      {
  check_visual_highlight();
! if (cap->count0 > 0 && resel_VIsual_mode != NUL)
  {
!     /* use previously selected part */
      VIsual = curwin->w_cursor;
  
      VIsual_active = TRUE;
***************
*** 7725,7730 ****
--- 7721,7736 ----
  /* start Select mode when 'selec

Re: bug related to patch 7.3.449 (Autocommands caused command to abort)

Bram Moolenaar — 2012-05-25T10:39:38

Christian Brabandt wrote:


Great, thanks.

We can make the method static, since it's only used in window.c

Patch 7.3.528

Bram Moolenaar — 2012-05-25T10:39:38

Patch 7.3.528
Problem:    Crash when closing last window in a tab. (Alex Efros)
Solution:   Use common code in close_last_window_tabpage(). (Christian
    Brabandt)
Files:    src/window.c


*** ../vim-7.3.527/src/window.c2012-03-16 19:07:54.000000000 +0100
--- src/window.c2012-05-25 12:25:16.000000000 +0200
***************
*** 23,28 ****
--- 23,29 ----
  static void win_totop __ARGS((int size, int flags));
  static void win_equal_rec __ARGS((win_T *next_curwin, int current, frame_T *topfr, int dir, int col, int row, int width, int height));
  static int last_window __ARGS((void));
+ static int close_last_window_tabpage __ARGS((win_T *win, int free_buf, tabpage_T *prev_curtab));
  static win_T *win_free_mem __ARGS((win_T *win, int *dirp, tabpage_T *tp));
  static frame_T *win_altframe __ARGS((win_T *win, tabpage_T *tp));
  static tabpage_T *alt_tabpage __ARGS((void));
***************
*** 2105,2110 ****
--- 2106,2147 ----
  }
  
  /*
+  * Close the possibly last window in a tab page.
+  * Returns TRUE whe

Patch 7.3.527

Bram Moolenaar — 2012-05-25T09:56:47

Patch 7.3.527
Problem:    Clang complains about non-ASCII characters in a string.
Solution:   Change to \x88 form. (Dominique Pelle)
Files:    src/charset.c


*** ../vim-7.3.526/src/charset.c2012-01-26 13:40:04.000000000 +0100
--- src/charset.c2012-05-25 11:49:58.000000000 +0200
***************
*** 1602,1611 ****
  #define LATIN1LOWER 'l'
  #define LATIN1UPPER 'U'
  
- /*                                                                 !"#$%&'()*+,-./0123456789:;<=>?< at >ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]%_'abcdefghijklmnopqrstuvwxyz{|}~                                  ¡¢£¤¥¦§¨©ª«¬®¯°±²³´µ¶·¸¹º»¼½¾¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõö÷øùúûüýþÿ */
  static char_u latin1flags[257] = "                                                                 UUUUUUUUUUUUUUUUUUUUUUUUUU      llllllllllllllllllllllllll                                                                     UUUUUUUUUUUUUUUUUUUUUUU UUUUUU