gmane.comp.video.mesa3d.devel

[Bug 63435] [Regression since 9.0] Flickering in EGL OpenGL full-screen window with swap interval 1

2013-05-25T10:55:03

https://bugs.freedesktop.org/show_bug.cgi?id=63435

post+fdo< at >ralfj.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Other                       |x86-64 (AMD64)
           Severity|normal                      |major
           Priority|medium                      |high

--- Comment #4 from post+fdo< at >ralfj.de ---
The patch uncovering this issue ended up in Mesa 9.1.3. This means that
full-screen EGL applications attempting to use v-sync are unusable with the
current stable Mesa release.
Why is it that nobody cares about this bug, which breaks an entire GL window
system?

Re: intel driver blit rework

Kenneth Graunke — 2013-05-25T10:44:29

Patches 2-11 are:
Reviewed-by: Kenneth Graunke <kenneth< at >whitecape.org>

I agree with Ian's concerns in patch 10.

I'm done with review for tonight.  I'll plan to review the rest 
eventually, but don't feel obligated to wait for me.

Re: [PATCH 04/17] intel: Make a wrapper for intelEmitCopyBlit using miptrees.

Kenneth Graunke — 2013-05-25T10:30:29

This /is/ intel_miptree_blit.  Presumably you mean intelEmitCopyBlit.

[snip]
[snip]

Technically, it can now, and intelEmitCopyBlit already enforces the 
proper generation checks.  Perhaps just delete this check here?


Assuming the comment gets fixed (and regardless of the Y-tile idea):
Reviewed-by: Kenneth Graunke <kenneth< at >whitecape.org>

Re: [PATCH 1/7] mesa: Add infrastructure forARB_shading_language_420pack.

Kenneth Graunke — 2013-05-25T09:13:00

Patches 1-5 and 7 are:
Reviewed-by: Kenneth Graunke <kenneth< at >whitecape.org>

I'll have to think more carefully about patch 6.

Re: [PATCH] i965: Mask the cut index based on the index buffer type in 3DSTATE_VF.

Kenneth Graunke — 2013-05-25T02:17:57

NAK on this patch.  It looks like 0x133700ff is not supposed to match 
0xff in GL_UNSIGNED_BYTE mode.  I think i've found a bunch more bugs. 
Going to write some tests and new patches...

Re: [PATCH 5/5] i965 gen7: use SURFACE_STATE fields to select render level/layer

Jordan Justen — 2013-05-25T01:39:27

I guess I forgot this discussion of ours. I spent some time trying to
get BRW_SURFACE_CUBE working (again, I suppose), with no luck.

Anyway...

Either of you good for an r-b on this second version of patch 5 in
this series then?

-Jordan

[PATCH 0/7] Beginnings of ARB_shading_language_420pack

Matt Turner — 2013-05-25T01:31:12

I'm on vacation for the next week, so in case anyone else wants to
finish off ARB_shading_language_420pack, here are the tests and
patches I've done so far.

They cover
 - Swizzles on scalars
 - .length() method of matrices and vectors
 - gl_{Max,Min}ProgramTexelOffset built-in constants (needs a piglit test)
 - Implicit conversion of return values
 - Non-constant expression initializers of const variables
 - and a GLSL spec clarification tacked on at the end

Thanks,
Matt

[PATCH 7/7] glsl: Disallow return with a void argumentfrom void functions.

Matt Turner — 2013-05-25T01:28:19

NOTE: This is a candidate for the stable branches.
---
 src/glsl/ast_to_hir.cpp | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 6b56e87..6ee50f5 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
< at >< at > -3401,7 +3401,23 < at >< at > ast_jump_statement::hir(exec_list *instructions,
                                 state->current_function->function_name(),
                                 state->current_function->return_type->name);
             }
- }
+         } else if (state->current_function->return_type->base_type ==
+                    GLSL_TYPE_VOID) {
+            YYLTYPE loc = this->get_location();
+
+            /* The ARB_shading_language_420pack, GLSL ES 3.0, and GLSL 4.20
+             * specs add a clarification:
+             *
+             *    "A void function can only use return without a return argument, even if
+             *     the return argument has void type. Return statements only acce

[PATCH 6/7] glsl: Allow non-constant expressioninitializers of const-qualified vars.

Matt Turner — 2013-05-25T01:28:18

Required by ARB_shading_language_420pack.
---
 src/glsl/ast_to_hir.cpp | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 6e689b4..6b56e87 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
< at >< at > -2337,17 +2337,25 < at >< at > process_initializer(ir_variable *var, ast_declaration *decl,
 
  ir_constant *constant_value = rhs->constant_expression_value();
  if (!constant_value) {
-    _mesa_glsl_error(& initializer_loc, state,
-     "initializer of %s variable `%s' must be a "
-     "constant expression",
-     (type->qualifier.flags.q.constant)
-     ? "const" : "uniform",
-     decl->identifier);
-    if (var->type->is_numeric()) {
-       /* Reduce cascading errors. */
-       var->constant_value = ir_constant::zero(state, var->type);
-    }
- } else {
+            /* If ARB_shading_language_420pack is enabled, initializers of
+             * const-qualified local variables do

[PATCH 5/7] glsl: Allow implicit conversion of returnvalues.

Matt Turner — 2013-05-25T01:28:17

Required by ARB_shading_language_420pack.
---
 src/glsl/ast_to_hir.cpp | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index b206380..6e689b4 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
< at >< at > -3358,7 +3358,7 < at >< at > ast_jump_statement::hir(exec_list *instructions,
       assert(state->current_function);
 
       if (opt_return_value) {
- ir_rvalue *const ret = opt_return_value->hir(instructions, state);
+ ir_rvalue *ret = opt_return_value->hir(instructions, state);
 
  /* The value of the return type can be NULL if the shader says
   * 'return foo();' and foo() is a function that returns void.
< at >< at > -3370,16 +3370,29 < at >< at > ast_jump_statement::hir(exec_list *instructions,
  const glsl_type *const ret_type =
     (ret == NULL) ? glsl_type::void_type : ret->type;
 
- /* Implicit conversions are not allowed for return values. */
- if (state->current_function->return_type != ret_type) {
+

[PATCH 4/7] glsl: Add gl_{Max,Min}ProgramTexelOffset built-in constants.

Matt Turner — 2013-05-25T01:28:16

Required by ARB_shading_language_420pack. Note that the 420pack spec
incorrectly specifies their values as (Min, Max) = (-7, 8) when they
should be (-8, 7) as listed in the GLSL 4.30 and ESSL 3.0 specs.
---
 src/glsl/builtin_variables.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
index 4bb361c..f4ac205 100644
--- a/src/glsl/builtin_variables.cpp
+++ b/src/glsl/builtin_variables.cpp
< at >< at > -790,6 +790,13 < at >< at > generate_130_uniforms(exec_list *instructions,
                         state->Const.MaxClipPlanes);
    add_builtin_constant(instructions, symtab, "gl_MaxVaryingComponents",
 state->Const.MaxVaryingFloats);
+
+   if (state->ARB_shading_language_420pack_enable) {
+      add_builtin_constant(instructions, symtab, "gl_MinProgramTexelOffset",
+                           state->Const.MinProgramTexelOffset);
+      add_builtin_constant(instructions, symtab, "gl_MaxProgramTexelOffset",
+                           state->Const.MaxProg

[PATCH 3/7] glsl: Allow swizzles on scalars.

Matt Turner — 2013-05-25T01:28:15

Required by ARB_shading_language_420pack.
---
 src/glsl/hir_field_selection.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/glsl/hir_field_selection.cpp b/src/glsl/hir_field_selection.cpp
index cc7ba61..ceb0a4c 100644
--- a/src/glsl/hir_field_selection.cpp
+++ b/src/glsl/hir_field_selection.cpp
< at >< at > -96,7 +96,9 < at >< at > _mesa_ast_field_selection_to_hir(const ast_expression *expr,
       } else {
  _mesa_glsl_error(&loc, state, "Unknown method: `%s'.", method);
       }
-   } else if (op->type->is_vector()) {
+   } else if (op->type->is_vector() ||
+              (state->ARB_shading_language_420pack_enable &&
+               op->type->is_scalar())) {
       ir_swizzle *swiz = ir_swizzle::create(op,
     expr->primary_expression.identifier,
     op->type->vector_elements);

[PATCH 2/7] glsl: Allow .length() method on vectors andmatrices.

Matt Turner — 2013-05-25T01:28:14

Required by ARB_shading_language_420pack.
---
 src/glsl/hir_field_selection.cpp | 58 ++++++++++++++++++++++++++--------------
 1 file changed, 38 insertions(+), 20 deletions(-)

diff --git a/src/glsl/hir_field_selection.cpp b/src/glsl/hir_field_selection.cpp
index 0035a5f..cc7ba61 100644
--- a/src/glsl/hir_field_selection.cpp
+++ b/src/glsl/hir_field_selection.cpp
< at >< at > -47,20 +47,6 < at >< at > _mesa_ast_field_selection_to_hir(const ast_expression *expr,
    YYLTYPE loc = expr->get_location();
    if (op->type->is_error()) {
       /* silently propagate the error */
-   } else if (op->type->is_vector()) {
-      ir_swizzle *swiz = ir_swizzle::create(op,
-    expr->primary_expression.identifier,
-    op->type->vector_elements);
-      if (swiz != NULL) {
- result = swiz;
-      } else {
- /* FINISHME: Logging of error messages should be moved into
-  * FINISHME: ir_swizzle::create.  This allows the generation of more
-  * FINISHME: specific error messages.
-  */
- _mesa_glsl_error(& loc, state, "Invalid s

[PATCH 1/7] mesa: Add infrastructure forARB_shading_language_420pack.

Matt Turner — 2013-05-25T01:28:13

From: Todd Previte <tprevite< at >gmail.com>

v2 [mattst88]
  - Split infrastructure into separate patch.
  - Add preprocessor #define.
---
 src/glsl/glcpp/glcpp-parse.y    | 3 +++
 src/glsl/glsl_parser_extras.cpp | 1 +
 src/glsl/glsl_parser_extras.h   | 2 ++
 src/mesa/main/extensions.c      | 1 +
 src/mesa/main/mtypes.h          | 1 +
 5 files changed, 8 insertions(+)

diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y
index 81ba04b..2e3e6a8 100644
--- a/src/glsl/glcpp/glcpp-parse.y
+++ b/src/glsl/glcpp/glcpp-parse.y
< at >< at > -1242,6 +1242,9 < at >< at > glcpp_parser_create (const struct gl_extensions *extensions, int api)
 
       if (extensions->AMD_vertex_shader_layer)
          add_builtin_define(parser, "GL_AMD_vertex_shader_layer", 1);
+
+      if (extensions->ARB_shading_language_420pack)
+         add_builtin_define(parser, "GL_ARB_shading_language_420pack", 1);
    }
 }
 
diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
index c0dd713..d02b308 100644
--- a/src/gl

Re: libclc: vload/vstore initial implementation

Tom Stellard — 2013-05-24T23:50:27

Hi Aaron,

I've pushed these to my libclc repo, thanks!

-Tom

Re: [PATCH 01/12] sso: Create extensions entry points

Ian Romanick — 2013-05-24T23:27:59

I'm finally getting off my lazy behind and reviewing this series.  I'll 
probably only be able to review one or two patches today, but I should 
be able to get through the rest shortly.

So far, it's just little stuff.

On 05/03/2013 10:44 AM, Gregory Hainaut wrote:

This should either be GLC or GL.  GLL causes the extension to only be 
advertised in compatibility profile contexts.  I think we either want 
this in both core and compatibility or core only.  I'm leaning towards 
the former since there are several shipping compatibility-profile apps 
(e.g., Serious Sam 3) that really want this extension.


Our friends that compile with Visual Studio will have a problem with 
this... it only does C89, so you can't mix declarations and code.


_______________________________________________
mesa-dev mailing list
mesa-dev< at >lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: intel driver blit rework

Ian Romanick — 2013-05-24T23:13:57

I sent out comments on a few of the patches.  Other than the first 
question on patch 10, I didn't see anything that should prevent these 
patches from going in.  You can probably convince me that even the 
question on patch 10 doesn't matter.

I also did a full gles3conform run (instead of the abbreviated run that 
piglit does) on IVB, and there were no regressions.

Reviewed-and-tested-by: Ian Romanick <ian.d.romanick< at >intel.com>

Re: [PATCH 14/17] intel: Rebuild PBO blit glTexImage()on top of miptrees.

Eric Anholt — 2013-05-24T23:01:11


I thought about doing so, but the aperture check is painful enough I
decided not to duplicate it.
_______________________________________________
mesa-dev mailing list
mesa-dev< at >lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [PATCH 14/17] intel: Rebuild PBO blit glTexImage() on top of miptrees.

Ian Romanick — 2013-05-24T22:35:45

It looks like after this the two remaining callers are all in 
intel_blit.c.  Should intelEmitCopyBlit be static?

Looking at what's left, it looks like there should be some more 
refactoring of intelEmitCopyBlit after this commit.  A bunch of the 
checks, etc. in intelEmitCopyBlit are only relevant for one of the 
callers.  That can happen later, if there's value.

Re: [PATCH 10/17] intel: Make a temporary miptree when doing blit uploads for glTexSubImage().

Ian Romanick — 2013-05-24T22:35:13

The old code did error checking.  Should we continue to error check 
temp_mt and dst (below)?


Since this code doesn't bail (and never has), we blit garbage into the 
texture, right?

Re: [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

Ian Romanick — 2013-05-24T22:35:04

unsigned?