gmane.comp.lang.ruby.rails.core

Re: Re: How can I enable assets minifying in development environment?

Rodrigo Rosenfeld Rosas — 2012-05-25T15:21:45

I tried really hard to replicate the issue in a separate application for 
almost a full hour and I couldn't.

It only happens to one file and it doesn't happen if I rename it.

Since this seems to be an odd case instead of a general issue, I gave up 
on trying to identify it as I don't actually need to run my specs in 
minified versions of my assets and if I needed to it was just a matter 
of renaming the spec affected by this bug.

Also, for the record, it doesn't seem that config.assets.precompile 
option is required for this to work as my other assets were being 
minified even when not specified in the precompile option.

Cheers,
Rodrigo.

Em 25-05-2012 11:24, Rodrigo Rosenfeld Rosas escreveu:

Re: Re: How can I enable assets minifying in development environment?

Rodrigo Rosenfeld Rosas — 2012-05-25T14:24:35

Hi, Simon, thanks for your reply.

I guess you meant %w() instead of %(), right?

Indeed, the precompile options is required, but that alone won't make my 
application work.

I've tested in a fresh Rails application and the trick worked for it.

I'm investigating what could be causing this strange issue in my own 
application...

I'll let you know if I find some bug in any included gem...

Thanks,
Rodrigo.

Em 25-05-2012 09:57, Simon de Boer escreveu:

Re: How can I enable assets minifying in development environment?

Simon de Boer — 2012-05-25T12:57:16

It appears that you have to be explicit in specifying the files that get 
compiled.

config.assets.precompile += %(asset1.js asset2.js style1.css)

The default just contains application.(css|js)

Hopefully this assists you.


On Thursday, 24 May 2012 12:30:02 UTC-4, Rodrigo Rosenfeld Rosas wrote:

Typecast values on change_column for postgresql

Gabriel Sobrinho — 2012-05-25T12:41:13

Hello,

Currently if you have a string column that have only number values (think a 
year column using string by mistake) and you want to change to integer, you 
can't.

If you apply this monkey-patch will be possible: 
https://gist.github.com/1393441


Note: if some value can't be casted by postgresql (if have a letter for 
example), the migration will fail as expected.

I think this is the expected behavior on change_column and I'm not sure but 
I guess mysql already does that.


What you think?

Re: Re: Simple idea for simplifying client-side code test built-in in Rails

Gabriel Sobrinho — 2012-05-25T12:34:06

I started to use konacha on my rails applications and it feels so right.

Would be great to have something like konacha integrated on rails 
applications or at least as default suggestion on Gemfile like happens with 
coffe-script.

On Friday, May 25, 2012 12:58:44 AM UTC-3, Rodrigo Rosenfeld Rosas wrote:

Re: Engine's Application Controller

Luís Ferreira — 2012-05-25T10:17:00

Your monkey patch will allow me to change the app from the engine. But my idea was to change the engine from the app.

Maybe this could be solved some other way, since my problem is as simple as wanting to set some defaults in the engine's application controller and allowing the app to change those defaults easily (eg. overwriting them in its own application controller).

Is there a better way of doing this?

BTW, the engine's routes.url_helpers are not loaded in rspec and cucumber tests by default. It feels kind of hackish to load them myself. Wouldn't it be possible to correct this or is it a feature?

On May 24, 2012, at 3:53 PM, Scott Johnson wrote:


Cumprimentos,
Luís Ferreira

Re: Re: Simple idea for simplifying client-side code test built-in in Rails

Rodrigo Rosenfeld Rosas — 2012-05-25T03:58:44

Hi John, thank you very much for your feedback. I really appreciate very 
much your Konacha gem and I would be actually using it if I didn't want 
to run my specs against IE...

But back to the subject, I've just created some examples on how you 
could achieve what you wanted on top of rails-sandbox-assets. Please see 
the commit logs so that you can see how little effort was required.

 From scratch:

https://github.com/rosenfeld/konacha_like

By reusing rails_sandbox_mocha_chai gem:

https://github.com/rosenfeld/konacha_reuse

The reason I don't set the default template in any of my example gems is 
to allow you to have a mixed spec-runners environment:

https://github.com/rosenfeld/mixed_test_runners

Can you see how having some base support would help a lot?

But more importantly, you don't even need any extra gem if your 
application depends on rails-sandbox-assets.

Just follow the example in konacha_like, but place your assets and spec 
runner view directly into your application.

Anyway, I've just op

Re: Re: Simple idea for simplifying client-side code test built-in in Rails

John Firebaugh — 2012-05-25T02:05:46

As the author of Konacha, let me add my two cents.

I think it would be great if Rails was opinionated about JS testing. I
fully support having the generated Gemfile for a new Rails application
include a JS testing gem -- any gem: konacha, jasmine, jasminerice,
whatever. I'd prefer to have the default be a framework other than Konacha
to Rails having no opinion about JS testing at all.

However, I don't really see the value in a framework agnostic base, either
as a gem or built in to Rails. Honestly, 98% of what I need for Konacha is
provided out of the box by engines and the asset pipeline, and I'd rather
have complete flexibility in the remaining 2% than save a few lines of code
but be limited by the base. To pick a couple examples of limitations in
rails-sandbox-assets: I want the name of the config root for Konacha to be
'konacha', not 'sandbox_assets', and I don't want to require
configuration (config.sandbox_assets.template
= 'mocha_chai/runner') that is redundant to simply adding the gem to the
Gemfil

How can I enable assets minifying in development environment?

Rodrigo Rosenfeld Rosas — 2012-05-24T16:30:02

I was trying an concept and found an weird issue when trying to enable 
compression in my development environment.

I'd like to be able to run my specs on the minified versions as well, 
so, using my rails_sandbox_jasmine gem, I'd like to use it this way:

SIMULATE_PRODUCTION=1 rake sandbox_assets:serve

And in my development.rb, I've set it to:

   config.assets.js_compressor = :uglifier
   config.assets.compress = !!ENV['SIMULATE_PRODUCTION']
   config.assets.digest = !!ENV['SIMULATE_PRODUCTION']
   config.assets.debug = !ENV['SIMULATE_PRODUCTION']

The debug (concatenation) and digest feature work but the generated 
assets are not minified.

Is that expected?

Thanks in advance,
Rodrigo.

Re: Engine's Application Controller

Scott Johnson — 2012-05-24T14:53:16

Insert some warning about why it would be better to change the code in your main app here.  But, if you want to change it in your engine you can.  Something like

class  ::Admin::ApplicationController
  # do your monkey patching here
end

Just make sure this is in a file that gets loaded when your engine loads -- I would suggest an initializer, but ...

Sent from my iPhone

On May 24, 2012, at 9:06 AM, Luís Ferreira <zamith.28< at >gmail.com> wrote:

Re: Simple idea for simplifying client-side code test built-in in Rails

Rodrigo Rosenfeld Rosas — 2012-05-24T14:07:11

Here is an example of what I was talking about. Framework agnostic and 
easy to extend:

https://github.com/rosenfeld/rails-sandbox-assets

As you can see, adding support for the Jasmine test runner on top of the 
gem above is pretty simple:

https://github.com/rosenfeld/rails_sandbox_jasmine

Any chances of getting something like this built into Rails 4?

Cheers,
Rodrigo.

Em 23-05-2012 00:05, Rodrigo Rosenfeld Rosas escreveu:

Re: Engine's Application Controller

Luís Ferreira — 2012-05-24T14:06:14

Ok. I get it. It would really be a mess when you have multiple engines, I'll namespace everything in the engine. Thanks.

Still, this won't solve my cancan problem.


On May 24, 2012, at 3:03 PM, Scott Johnson wrote:


Cumprimentos,
Luís Ferreira

Re: Engine's Application Controller

Scott Johnson — 2012-05-24T14:03:43

If you just merged the ApplicationControllers, then the code in the last loaded engine would take precedence in the main app and all other engines.  And if you overwrote some methods in one engine and others in another you would quickly have a quagmire.

Using inheritance provides a nice predictable way to change behavior.  This way you main application stays unaltered and each engine can access this code and change its behavior without affecting the main app or other engines.

Sent from my iPhone

On May 24, 2012, at 8:31 AM, Luís Ferreira <zamith.28< at >gmail.com> wrote:

Re: Engine's Application Controller

Luís Ferreira — 2012-05-24T13:57:42

Ok. So now I've namespace my ApplicationController like so:

class Citygate::Admin::ApplicationController < ::Admin::ApplicationController
  protect_from_forgery
  layout 'admin/application'

  rescue_from CanCan::AccessDenied do |exception|
    redirect_to root_url, :alert => exception.message
  end
end

The problem here is that I want the app/admin/application_controller.rb to be able to change the cancan redirect and since the engine's controller inherits from it, the engine's definitions will always take precendence. This is not the functionality I want. I want to be able to provide some defaults in the engine that can be overidden in the app.

Am I doing anything wrong here?


On May 23, 2012, at 11:49 PM, Ryan Bigg wrote:


Cumprimentos,
Luís Ferreira

Re: Engine's Application Controller

Luís Ferreira — 2012-05-24T13:31:55

Ok. This will solve the problem, but still I don't understand why both application controllers could not be merged.
On May 23, 2012, at 11:49 PM, Ryan Bigg wrote:


Cumprimentos,
Luís Ferreira

Re: Engine's Application Controller

Ryan Bigg — 2012-05-23T22:49:15

Indeed, the application's app/controllers/application_controller.rb will take precedence over a similarly named file in the engine. The same goes for anything else in the app directory, too.

This is why you namespace your engine: to avoid collisions such as these.   


On Thursday, 24 May 2012 at 4:46 AM, Luís Ferreira wrote:

Re: Engine's Application Controller

markmcspadden — 2012-05-23T20:17:13

See previous discussion on this thread:
https://groups.google.com/group/rubyonrails-core/browse_thread/thread/449521aed8b4cd7a#

That thread did result to this change in the guides:
https://github.com/rails/rails/commit/a0d9b7903588cd988c8c9b4164494c792344f43e

Hope that helps.

Mark

On May 23, 1:46 pm, Luís Ferreira <zamith...< at >gmail.com> wrote:

Engine's Application Controller

Luís Ferreira — 2012-05-23T18:46:50

Hi,

I've been using rails 3 engines and (at least in my experience) the engine's application controller is overidden by the app's application controller. Wouldn't it be better if the app would just load on top of the engine? 

I mean that if an engine's application controller has methods or anything else that does not collide with the stuff defined with the app, couldn't it be used?

Isn't this the default behaviour of ruby, that you can just reopen a class and add methods to it possibly overriding them but not deleting the rest of the class?


Regards,
Luís Ferreira

Re: Having 2 ActiveRecord test failures on master: "Errors running test_postgresql" using pg 9.1

Patrick Mahoney — 2012-05-23T15:01:03

A pull request of mine seems to have triggered these failures.  Sorry about 
that.

But I now think the problem is unrelated to my patch since I can reproduce 
on master (where the patch was reverted) with both sqlite3 and postgres 
with this command:

    ruby -w -I"lib:test" -e '["test/cases/associations/eager_test.rb", 
"test/cases/associations/join_model_test.rb", 
"test/cases/base_test.rb"].each { |f| load f }'

Can anyone else reproduce this?

See https://github.com/rails/rails/pull/6416#issuecomment-5871744

Re: Having 2 ActiveRecord test failures on master: "Errors running test_postgresql" using pg 9.1

P . — 2012-05-23T14:42:15

A pull request of mine seemed to trigger this problem.  Sorry about that.

However, I am able to reproduce the problem with both sqlite3 and 
postgresql on master (where my patch has been reverted) like this:

    activerecord$ ruby -w -I"lib:test" -e 
'["test/cases/associations/eager_test.rb", 
"test/cases/associations/join_model_test.rb", 
"test/cases/base_test.rb"].each { |f| load f }'

So I think there are some assumptions in the tests that aren't true 
depending on test order or something else. 
 See https://github.com/rails/rails/pull/6416#issuecomment-5871744

Can anyone else reproduce?

Re: Simple idea for simplifying client-side code test built-in in Rails

Steve Klabnik — 2012-05-23T15:06:26

+1 from me. Rails did a lot to bring testing to web apps, people are
now doing JS testing, we should have some kind of JS story.