http://permalink.gmane.org/gmane.comp.kde.devel.core hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.kde.devel.core/79191 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review32785 ----------------------------------------------------------- Ship it! Ship It! - David Faure On May 19, 2013, 2:53 p.m., Dawit Alemayehu wrote: </pre> David Faure 2013-05-19T18:11:30 http://permalink.gmane.org/gmane.comp.kde.devel.core/79190 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ ----------------------------------------------------------- (Updated May 19, 2013, 2:53 p.m.) Review request for kdelibs and David Faure. Changes ------- Updated patch based on feedback. Description ------- If you open a directory that contains other directories in Konqueror or Dolphin, change the permission of one of these directories from outside, say the command line, and right click on the same directory to look at the permission tab in the properties dialog, you will see that the permission change has not been updated. This patch addresses that bug. This addresses bug 173733. http://bugs.kde.org/show_bug.cgi?id=173733 Diffs (updated) ----- kio/kio/kdirlister.cpp 94b1d1d kio/tests/kdirlistertest.h 1b117bb kio/tests/kdirlistertest.cpp a0b296d Diff: http://git.reviewboard.kde.org/r/103555/diff/ Testing ------- 1. In </pre> Dawit Alemayehu 2013-05-19T14:53:09 http://permalink.gmane.org/gmane.comp.kde.devel.core/79189 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review32773 ----------------------------------------------------------- Looks good, just a few minor things to fix. kio/kio/kdirlister.cpp &lt;http://git.reviewboard.kde.org/r/103555/#comment24344&gt; This should only be called if _dir.isLocalFile(). Needs to be added in one of the if()s above. kio/kio/kdirlister.cpp &lt;http://git.reviewboard.kde.org/r/103555/#comment24345&gt; No need for double-lookup. Remove the if(), insert() will do nothing if this path is already in the QSet. kio/tests/kdirlistertest.cpp &lt;http://git.reviewboard.kde.org/r/103555/#comment24347&gt; QVERIFY(job-&gt;exec()); kio/tests/kdirlistertest.cpp &lt;http://git.reviewboard.kde.org/r/103555/#comment24346&gt; Use QCOMPARE() so that failures are easier to debug. - David Faure On May 18, 2013, 11:20 p.m., Dawit Alemayehu wrote: </pre> David Faure 2013-05-19T08:49:11 http://permalink.gmane.org/gmane.comp.kde.devel.core/79188 <pre> Can you be more specific in both cases? He has to keep in sync, if it matters. We don't. I'm not convinced. I don't see any need to release it until KF5 is closer to release. Thanks, Steve. </pre> Stephen Kelly 2013-05-19T08:37:04 http://permalink.gmane.org/gmane.comp.kde.devel.core/79187 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ ----------------------------------------------------------- (Updated May 18, 2013, 11:20 p.m.) Review request for kdelibs and David Faure. Changes ------- - Updated patch to fix the stale permission bug without affecting existing behavior. - Added a unit test Description ------- If you open a directory that contains other directories in Konqueror or Dolphin, change the permission of one of these directories from outside, say the command line, and right click on the same directory to look at the permission tab in the properties dialog, you will see that the permission change has not been updated. This patch addresses that bug. This addresses bug 173733. http://bugs.kde.org/show_bug.cgi?id=173733 Diffs (updated) ----- kio/kio/kdirlister.cpp 94b1d1d kio/tests/kdirlistertest.h 1b117bb kio/tests/kdirlistertest.cpp a0b296d Diff</pre> Dawit Alemayehu 2013-05-18T23:20:41 http://permalink.gmane.org/gmane.comp.kde.devel.core/79186 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32763 ----------------------------------------------------------- This caused an unhandled switch warning in kdoctools/genshortcutents.cpp, which can be trivially fixed with: diff --git a/kdoctools/genshortcutents.cpp b/kdoctools/genshortcutents.cpp index b35b5a4..92bdea5 100644 --- a/kdoctools/genshortcutents.cpp +++ b/kdoctools/genshortcutents.cpp &lt; at &gt;&lt; at &gt; -300,6 +300,9 &lt; at &gt;&lt; at &gt; static QString entityForAccel( KStandardShortcut::StandardShortcut accel ) case KStandardShortcut::AboutKDE: markup += "AboutKDE"; break; + case KStandardShortcut::JoinTheGame: + markup += "JoinTheGame"; + break; case KStandardShortcut::StandardShortcutCount: break; } however I'm not sure if there is anythin</pre> Michael Pyne 2013-05-18T22:08:14 http://permalink.gmane.org/gmane.comp.kde.devel.core/79185 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/ ----------------------------------------------------------- (Updated May 18, 2013, 10:05 p.m.) Status ------ This change has been marked as submitted. Review request for kdelibs and David Faure. Description ------- "Unable to open temporary file" isn't very informative. Diffs ----- kdecore/io/ksavefile.cpp 6cdd41e Diff: http://git.reviewboard.kde.org/r/110514/diff/ Testing ------- yep Thanks, Sergio Luis Martins </pre> Sergio Luis Martins 2013-05-18T22:05:01 http://permalink.gmane.org/gmane.comp.kde.devel.core/79184 <pre> Was about to post more interesting stuff, but seems someone ( you ) already fixed it a couple of weeks ago :) - Sergio Luis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/#review32757 ----------------------------------------------------------- On May 18, 2013, 7:43 p.m., Sergio Luis Martins wrote: </pre> Sergio Luis Martins 2013-05-18T22:04:58 http://permalink.gmane.org/gmane.comp.kde.devel.core/79183 <pre> Code looks fine from my point of view. I'm not the maintainer of kdeui though, so I won't give it a ship it for now. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32735 ----------------------------------------------------------- On May 9, 2013, 11:05 p.m., Albert Astals Cid wrote: </pre> Ben Cooksley 2013-05-18T20:50:40 http://permalink.gmane.org/gmane.comp.kde.devel.core/79182 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/#review32757 ----------------------------------------------------------- Ship it! Sure (I'm pretty sure this didn't even need reviewing :). I suppose the error was "no write permissions in the directory", it's the most likely one. (partition full would be the other one I can think of) - David Faure On May 18, 2013, 7:43 p.m., Sergio Luis Martins wrote: </pre> David Faure 2013-05-18T19:50:31 http://permalink.gmane.org/gmane.comp.kde.devel.core/79181 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/ ----------------------------------------------------------- Review request for kdelibs and David Faure. Description ------- "Unable to open temporary file" isn't very informative. Diffs ----- kdecore/io/ksavefile.cpp 6cdd41e Diff: http://git.reviewboard.kde.org/r/110514/diff/ Testing ------- yep Thanks, Sergio Luis Martins </pre> Sergio Luis Martins 2013-05-18T19:43:22 http://permalink.gmane.org/gmane.comp.kde.devel.core/79180 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109246/#review32742 ----------------------------------------------------------- any KDE Windows folks feel like taking a look at this one? - Allen Winter On March 2, 2013, 4:54 p.m., Michel Ludwig wrote: </pre> Allen Winter 2013-05-18T14:36:35 http://permalink.gmane.org/gmane.comp.kde.devel.core/79179 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109245/#review32741 ----------------------------------------------------------- Ship it! please commit. remember to add the kdepimlibs 4.10 requirement in the CMakeLists.txt though - Allen Winter On March 2, 2013, 2:12 p.m., Sergio Luis Martins wrote: </pre> Allen Winter 2013-05-18T14:26:15 http://permalink.gmane.org/gmane.comp.kde.devel.core/79178 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32735 ----------------------------------------------------------- ShipIt from anyone? - Albert Astals Cid On May 9, 2013, 11:05 p.m., Albert Astals Cid wrote: </pre> Albert Astals Cid 2013-05-18T13:33:03 http://permalink.gmane.org/gmane.comp.kde.devel.core/79177 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/ ----------------------------------------------------------- (Updated May 18, 2013, 12:44 p.m.) Status ------ This change has been marked as submitted. Review request for kdelibs. Description ------- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This addresses bug 267365. http://bugs.kde.org/show_bug.cgi?id=267365 Diffs ----- kimgio/CMakeLists.txt 26329c0 kimgio/webp.cpp PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/webp.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106300/diff/ Testing ------- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller </pre> Commit Hook 2013-05-18T12:44:10 http://permalink.gmane.org/gmane.comp.kde.devel.core/79176 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review32734 ----------------------------------------------------------- This review has been submitted with commit df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin Koller to branch master. - Commit Hook On May 9, 2013, 6:20 p.m., Martin Koller wrote: </pre> Commit Hook 2013-05-18T12:44:05 http://permalink.gmane.org/gmane.comp.kde.devel.core/79175 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110331/#review32719 ----------------------------------------------------------- If there are no objections I intend to commit this patch early next week. - Eike Hein On May 8, 2013, 11:16 p.m., Eike Hein wrote: </pre> Eike Hein 2013-05-17T23:06:28 http://permalink.gmane.org/gmane.comp.kde.devel.core/79174 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32718 ----------------------------------------------------------- If there are no objections I intend to commit this patch early next week. - Eike Hein On May 8, 2013, 11:12 p.m., Eike Hein wrote: </pre> Eike Hein 2013-05-17T23:06:19 http://permalink.gmane.org/gmane.comp.kde.devel.core/79173 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/#review32717 ----------------------------------------------------------- If there are no objections I intend to commit this patch early next week. - Eike Hein On May 6, 2013, 5:25 p.m., Eike Hein wrote: </pre> Eike Hein 2013-05-17T23:06:05 http://permalink.gmane.org/gmane.comp.kde.devel.core/79172 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/#review32716 ----------------------------------------------------------- kurifilter-plugins/ikws/searchproviderdlg.cpp &lt;http://git.reviewboard.kde.org/r/110423/#comment24325&gt; I would rather see the button besides the shortcut url edit itself. That way you do not even have to worry about enabling/disabling the button or installing an event filter. You can simply show the icon so the button is small and use the text as a tool tip. kurifilter-plugins/ikws/searchproviderdlg.cpp &lt;http://git.reviewboard.kde.org/r/110423/#comment24324&gt; Why not simply disable the button on a FocusOut event for m_dlg.leQuery ? That way you do not need to install an event filter on all the edits. - Dawit Alemayehu On May 14, 2013, 1:53 p.m., Maarten De Meyer wrote: </pre> Dawit Alemayehu 2013-05-17T22:36:58 http://permalink.gmane.org/gmane.comp.kde.devel.core/79170 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32696 ----------------------------------------------------------- This review has been submitted with commit 71fc7c112076ac2eb83146e58167d95bf04d8f5f by Luiz Romário Santana Rios to branch master. - Commit Hook On May 17, 2013, 8:26 a.m., Romário Rios wrote: </pre> Commit Hook 2013-05-17T12:57:36 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.kde.devel.core