gmane.comp.java.openjdk.build.devel

Re: Building sunpkcs11.jar

Valerie (Yu-Ching) Peng — 2012-05-25T23:50:14

There is no such flag; otherwise it'd be an easy way to circumvent 
existing checks for enforcing export/import control.
Cryptographic vendors who develop JCE providers can apply for JCE code 
signing certificates through a process documented in the JCE guide.

The easiest route may be just to test against your OpenJDK build since 
the JCE framework in the OpenJDK can accept unsigned providers.
Valerie

On 05/25/12 15:13, Deneau, Tom wrote:

RE: Building sunpkcs11.jar

Deneau, Tom — 2012-05-25T22:13:30

Valerie --

I don't believe we have a JCE code signing keypair (where would we have gotten one?)

Is there any test flag that tells the Oracle 7u4 jre to not require a signed crypto provider

Re: Building sunpkcs11.jar

Valerie (Yu-Ching) Peng — 2012-05-25T19:11:01

The provider built from OpenJDK workspace is unsigned.
It can't be used with Oracle 7u4 JRE which require crypto provider to be 
signed for export/import conformance.

If Your company has a JCE code signing keypair, you can sign the 
provider built using OpenJDK with that keypair and then use it w/ Oracle 
7u4 JRE.
Thanks,
Valerie

On 05/23/12 08:54, Deneau, Tom wrote:

Building sunpkcs11.jar

Deneau, Tom — 2012-05-23T15:54:01

I want to be able to modify and rebuild lib/ext/sunpkcs11.jar.

When I do a "make all; make images" everything completes successfully.
With javap, I can see my modified class in the build/linux-amd64/j2sdk-image/jre/lib/ext

When I use this built ext directory as a replacement of the Oracle 7U4 JRE, and run some code that does

  KeyGenerator gen = KeyGenerator.getInstance("AES");
I get
      Test1,java.security.NoSuchAlgorithmException: AES KeyGenerator not available
at javax.crypto.KeyGenerator.<init>(KeyGenerator.java:158)
at javax.crypto.KeyGenerator.getInstance(KeyGenerator.java:207)

This code runs successfully with the regular Oracle 7U4 JRE.

Am I missing something in the build process?

Re: Review Request: Build-infra update

Fredrik Öhrström — 2012-05-24T19:27:12

But it has a meaning for JLS+JVMS, if you change the final static
and the native code depends on its value, and you forget to rerun
javah, then something will break. A final static field that is
used from native, is as bound to the running Java program
as any native method is. Change something without rerunning javah,
and it breaks. 

The native keyword is good because it tells the programmer that
if you change this final static, then you have to verify the C-code
as well!

The real bad design decision was to export all final statics by default
to the generated c header file.

//Fredrik

----- jonathan.gibbons-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org skrev:

Re: Review Request: Build-infra update

Jonathan Gibbons — 2012-05-24T19:04:52

The rationale for not allowing it is that it has no meaning at either 
the JLS or JVMS level.  It would simply be a hint for tools, and hints 
for tools are best done by annotations.

Re: Review Request: Build-infra update

Fredrik Öhrström — 2012-05-24T19:02:34

Not by me anyway. In fact, I think that solution is the best one!

//Fredrik

2012/5/23 Jonathan Gibbons <jonathan.gibbons-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>:

Re: code review for JDK FDS gobjcopy work arounds (7170449)

Karen Kinnear — 2012-05-24T16:33:22

Looks good. Thank you.

thanks,
Karen

On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:

Re: code review for second hotspot FDS gobjcopy work around (7165598)

2012-05-24T07:52:25

I do not see any issues with that webrev.
Looks good.

Thanks,
Serguei

On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:

hg: jdk8/build/langtools: 6 new changesets

2012-05-23T22:56:53

Changeset: 8b869afd2eb4
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/langtools/rev/8b869afd2eb4

Added tag jdk8-b39 for changeset a9f547c218d9

! .hgtags

Changeset: d10db3576c08
Author:    ksrini
Date:      2012-05-04 07:55 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/langtools/rev/d10db3576c08

7166010: (javac) JavacMessager incorrectly restores log source file
Reviewed-by: jjg
Contributed-by: jan.lahoda-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java
+ test/tools/javac/processing/messager/MessagerDiags.java

Changeset: 833bab705918
Author:    ksrini
Date:      2012-05-10 12:32 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/langtools/rev/833bab705918

7159445: (javac) emits inaccurate diagnostics for enhanced for-loops
Reviewed-by: jjg
Contributed-by: jan.lahoda-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! sr

hg: jdk8/build/jdk: 71 new changesets

2012-05-23T22:42:14

Changeset: 47cd90bf0f66
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jdk/rev/47cd90bf0f66

Added tag jdk8-b39 for changeset b6f529117521

! .hgtags

Changeset: 7c4eed4b6c19
Author:    bae
Date:      2012-05-21 14:04 +0400
URL:       http://hg.openjdk.java.net/jdk8/build/jdk/rev/7c4eed4b6c19

7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs)
Reviewed-by: anthony, kizune

! src/macosx/classes/sun/awt/CGraphicsDevice.java
! test/java/awt/GraphicsDevice/CloneConfigsTest.java

Changeset: 416b3a498e71
Author:    bae
Date:      2012-05-21 14:53 +0400
URL:       http://hg.openjdk.java.net/jdk8/build/jdk/rev/416b3a498e71

7154088: [macosx] Regression: Component.createImage do not inherits component attributes
Reviewed-by: art, kizune

! src/macosx/classes/sun/lwawt/LWComponentPeer.java

Changeset: 1b90a0113359
Author:    lana
Date:      2012-05-21 11:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/bui

hg: jdk8/build/jaxws: Added tag jdk8-b39 for changeset 7f6b44fd3034

2012-05-23T22:41:09

Changeset: 09a0ddda03cb
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jaxws/rev/09a0ddda03cb

Added tag jdk8-b39 for changeset 7f6b44fd3034

! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b39 for changeset f95fdbe525c8

2012-05-23T22:40:58

Changeset: 9ecfdbd6aed4
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jaxp/rev/9ecfdbd6aed4

Added tag jdk8-b39 for changeset f95fdbe525c8

! .hgtags

hg: jdk8/build/hotspot: 15 new changesets

2012-05-23T22:38:42

Changeset: 26423ef693ac
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26423ef693ac

Added tag jdk8-b39 for changeset 96a403721094

! .hgtags

Changeset: 56d1af561395
Author:    amurillo
Date:      2012-05-11 14:54 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/56d1af561395

7168247: new hotspot build - hs24-b11
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 35e504cb49a6
Author:    collins
Date:      2012-05-11 11:30 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/35e504cb49a6

7167625: Adjustments for SE-Embedded build process
Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users.
Reviewed-by: kvn, dholmes

! make/linux/makefiles/vm.make
! src/share/vm/runtime/arguments.cpp

Changeset: fada85d11d92
Author:    jprovino
Date:      2012-05-16 13:33 -0400
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fada85d11d92

Merge


Changeset: 8f

hg: jdk8/build/corba: Added tag jdk8-b39 for changeset 785af00e2827

2012-05-23T22:36:25

Changeset: 56d030e5035f
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/corba/rev/56d030e5035f

Added tag jdk8-b39 for changeset 785af00e2827

! .hgtags

hg: jdk8/build: Added tag jdk8-b39 for changeset 8927dd68aee3

2012-05-23T22:36:20

Changeset: a2b2d435f1d2
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/a2b2d435f1d2

Added tag jdk8-b39 for changeset 8927dd68aee3

! .hgtags

Re: Review Request: Build-infra update

Jonathan Gibbons — 2012-05-23T18:03:34

I wanted to be able to declare fields as native, but that was deemed 
unacceptable.

Re: Review Request: Build-infra update

Alan Bateman — 2012-05-23T17:05:29

As Jon put it, for the classes in the base module, "we are delicate 
bootstrapping ground" so if you add something like "private static 
native void dummy()" rather than the annotation to the classes in the 
base module then it could be a solution for the short term. This means 
the following sources in the webrev:

src/share/classes/java/lang/Integer.java
src/share/classes/java/lang/Long.java
src/share/classes/java/net/SocketOptions.java
src/windows/classes/sun/nio/ch/PollArrayWrapper.java

Also it would be good to remove it from 
src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in 
the first round).

-Alan.

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] BuildingExtensionSubtables.cpp should use -fno-strict-aliasing

Kelly O'Hair — 2012-05-23T16:53:23

On May 23, 2012, at 9:32 AM, Andrew Hughes wrote:


You can add something like this to CFLAGS:
    CFLAGS += $(CFLAGS_$(< at >F))

Then:
   CFLAGS_foobar.o = -someoptions

-kto

Re: Review Request: Build-infra update

Kelly O'Hair — 2012-05-23T16:50:30

Has anyone tried creating an unused native method declaration in the class to trigger the native header
generation?   public native void GenerateNativeHeader();   ???  Is that too ugly?

-kto

On May 23, 2012, at 8:01 AM, Jonathan Gibbons wrote:

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] BuildingExtensionSubtables.cpp should use -fno-strict-aliasing

Phil Race — 2012-05-23T16:50:33

I would normally suggest a pragma but when I googled around
it looks like the appropriate one is actually non-functional on purpose ..
https://bugzilla.redhat.com/show_bug.cgi?id=486176

So it might require a bit more makefile smarts. I think there's a chance
some other example template of how to do this exists but I do not know.


I would suppose it is needed but haven't closely examined the code.

-phil.