gmane.comp.java.jbehave.devel

[jira] (JBEHAVE-922) Allow mapping of ExamplesTable rows to annotated custom types

Ghislain Nadeau (JIRA — 2013-06-18T00:11:03

[jira] (JBEHAVE-922) Allow mapping of ExamplesTable rows to annotated custom types

Mauro Talevi (JIRA — 2013-06-17T22:47:03

[jira] (JBEHAVE-922) Allow mapping of ExamplesTable rows to annotated custom types

Ghislain Nadeau (JIRA — 2013-06-17T19:51:03

[jira] (JBEHAVE-922) Allow mapping of ExamplesTable rows to annotated custom types

Ghislain Nadeau (JIRA — 2013-06-17T19:49:03

[jira] (JBEHAVE-922) Allow mapping of ExamplesTable rows to annotated custom types

Mauro Talevi (JIRA — 2013-06-16T17:55:03

[jira] (JBEHAVE-922) Allow mapping of ExamplesTable rows to annotated custom types

Mauro Talevi (JIRA — 2013-06-16T17:53:03

[jira] (JBEHAVE-927) Disable Timeout in debuggingmode

Mauro Talevi (JIRA — 2013-06-12T21:29:03

Re: keywords in CandidateSteps and MarkUnmatchedStepsAsPending

Mauro Talevi — 2013-06-12T21:18:40

Hi Sebastian,

the principle followed is that of loose coupling, as expressed by the 
Law of Demeter:

http://en.wikipedia.org/wiki/Law_of_Demeter

This means that if a class, e.g. MarkUnmatchedStepsAsPending, depends on 
two collaborators such as Keywords and StepFinder, it should depend on 
these, and only on these, not on the more generic Configuration.

To ensure the uniqueness of the instances we could have only one 
constructor, but this is sometimes impractical.     There is a trade-off 
between loose coupling and potential duplicate instances of 
collaborators when using default constructors.

We can improve the default wiring up of the dependencies via the 
Configuration to avoid or minimise duplicate instances.

Cheers

On 12/06/2013 21:10, Sebastian Sickelmann wrote:

Re: Re: Scenario and Story Scope for Guice Injections

Mauro Talevi — 2013-06-12T20:46:04

Hi Sebastian,

as far I can see this is still Guice-specific.    There is no guarantee 
that other DI containers would actually support scopes.

I can understand your syntactical preference for Guice-centric 
solutions, but I think it's not a very generic path to follow.

What about trying to implement the other more generic solution we 
discussed with controls via < at >Before/After annotations?

Cheers

On 11/06/2013 21:59, Sebastian Sickelmann wrote:


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

keywords in CandidateSteps and MarkUnmatchedStepsAsPending

Sebastian Sickelmann — 2013-06-12T20:10:03

Hi,

is there any use case where it is usefull to have different keywords 
inside the CandidateSteps-Instances and the StepCollector 
MarkUnmatchedStepsAsPending.

If there is no use-case for this. Can we change the implementation of
MarkUnmatchedStepsAsPending as follows?


https://github.com/picpromusic/jbehave-core/compare/master...keywordCheckCandidates


Also it seems that the keywords in MarkUnmatchedStepsAsPending are 
always a new Instance of LocalizedKeywords and not the configured one in 
the Configuration-Instance. I tried to change too. Maybe there are other 
Classes that should get the same refactoring with 
InitializableByConfiguration.


Kind regards
Sebastian


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

Re: Scenario and Story Scope for Guice Injections

Sebastian Sickelmann — 2013-06-11T20:59:44

Hi Mauro,

i created a new POC which now don't misuse the StepCollector for 
inserting pseudo-steps that tells the Guice-Scopes to start and stop.

I now use a part of an implementation in found in a fork by andreiserea

https://github.com/andreiserea/jbehave-core/commits/jbehave-3.7.5-arquillian

I cherry-picked e3dee13f49321067d33993a207d9fc8f2d5a4a5c and 
e0b15759d478fbd80f34ece3e8e0628b9a889f3e and removed all unneeded 
functionality and just leave the LifecycleOberservers.

My new POC is in my branch DependencyInjectionScopesWithLifecycle

at my fork git://github.com/picpromusic/jbehave-core.git

Use can see a quick diff here:

https://github.com/picpromusic/jbehave-core/compare/master...DependencyInjectionScopesWithLifecycle

The POC shows a solution for providing the same scopes also for
the other containers. Every Container-Impl should subclass
org.jbehave.core.configuration.AbstractDependencyInjectionAnnotationBuilder
see createScopeModule() in 
org.jbehave.core.configuration.guice.GuiceAnnotationBu

[jira] (JBEHAVE-927) Disable Timeout in debuggingmode

Sebastian Sickelmann (JIRA — 2013-06-11T20:42:03

[jira] (JBEHAVE-926) Build issue, cannot find org.jenkins-ci:annotation-indexer:jar:1.4 in http//repol.maven.org/maven2

Cristiano Gavião (JIRA — 2013-06-11T16:43:03

[jira] (JBEHAVE-926) Build issue, cannot find org.jenkins-ci:annotation-indexer:jar:1.4 in http//repol.maven.org/maven2

Paige Riley (JIRA — 2013-06-11T15:57:03

[jira] (JBEHAVE-925) Failures at BeforeStories is not being transmited to junit viewer

Cristiano Gavião (JIRA — 2013-06-11T15:02:03

[jira] (JBEHAVE-922) Parse ExamplesTable directly into Pojos

Ghislain Nadeau (JIRA — 2013-06-09T23:30:03

[jira] (JBEHAVE-922) Parse ExamplesTable directly into Pojos

Mauro Talevi (JIRA — 2013-06-09T22:48:03

[jira] (JBEHAVE-924) PatternVariableBuilder can be extremely inefficient in some cases

Victor Rosenberg (JIRA — 2013-06-09T20:09:03

[jira] (JBEHAVE-922) Parse ExamplesTable directly into Pojos

Ghislain Nadeau (JIRA — 2013-06-09T17:32:03

[jira] (JBEHAVE-922) Parse ExamplesTable directly into Pojos

Mauro Talevi (JIRA — 2013-06-09T16:45:03

[jira] (JBEHAVE-923) Add scenario-specific filters as anchors of GivenStories paths

Mauro Talevi (JIRA — 2013-06-09T16:39:03