gmane.comp.gnome.apps.gnucash.devel

Re: About translation of Gnucash in Gujarati (India)

Cristian Marchi — 2012-05-25T18:49:51

You can send your translated po file to gnucash-devel< at >gnucash.org (I'm 
also sending this message to it).

A developer will take care to commit your translation to the GnuCash 
repository and it will be available to all with the next release of the 
program.

Regards
Cristian


Il 25/05/2012 08:47, Abdul Zummerwala ha scritto:

Re: r22195 - gnucash/branches/2.4/packaging/win32 - Add EXTRA_CFLAGS to inst_gnucash compile line so that cflags can be added by custom.sh

John Ralls — 2012-05-25T13:43:08

On May 25, 2012, at 5:31 AM, Derek Atkins wrote:


Now you've made me curious: Phil added it in r20560 as part of a much larger change. 

Regards,
John Ralls

Re: r22195 - gnucash/branches/2.4/packaging/win32 - Add EXTRA_CFLAGS to inst_gnucash compile line so that cflags can be added by custom.sh

Derek Atkins — 2012-05-25T12:31:14


Ahh, I must've missed the trunk commit and didn't see a back-reference.

-derek

Trying to recover from corrupted files - not going well.

2012-05-24T19:35:48

My gnucash install has now went off the rails :-(   I wanted the bill import section so that
means compile trunk from scratch and include --with-python

Under 2012-1-14 version of trunk there was an export as XML.  Today's trunk r22201 no longer has that export as XML but export as CVS.   How can I get past this data corruption issue and export/import the dataset in trunk?

The 2011 version was broken where billing importing was hit and miss - known bug.
The 2012-1-14 version worked for a while, then after various linux system upgrades at some point when I returned to entering stuff in the accounting system when I save a file the saved file is not openable.  I just did another grab of trunk and did a save from a working file and get a non-working file.   The below is an example from the trace file of a:

$ gnucash gnuworked2
(within GnuCash File -> Save As gnuborked)
$ date;gnucash gnuborked.gnucash
Thu May 24 11:57:47 CDT 2012


This is a development version. It may or may not work.
Report bugs and other pr

Re: Menu accelerator keys in 2.4.10 (Colin Law)

Tiago Neiva — 2012-05-24T17:43:40

I Posted a bug about menu accelerator keys a couple of weeks ago.
Just changed it in launchpad to a Unity bug, in this version of Ubuntu.
I was able to replicate the bug in another app.

https://bugs.launchpad.net/ubuntu/+source/unity/+bug/994564

Re: r22195 - gnucash/branches/2.4/packaging/win32 - Add EXTRA_CFLAGS to inst_gnucash compile line so that cflags can be added by custom.sh

John Ralls — 2012-05-24T15:33:40

On May 24, 2012, at 7:23 AM, Derek Atkins wrote:


That would be difficult: I pinched the idea from trunk. ;-)

Regards,
John Ralls

Re: r22195 - gnucash/branches/2.4/packaging/win32 - Add EXTRA_CFLAGS to inst_gnucash compile line so that cflags can be added by custom.sh

Derek Atkins — 2012-05-24T14:23:21


Shouldn't this change be applied to trunk as well?

-derek

Re: Running unit tests under valgrind

John Ralls — 2012-05-22T18:11:22

On May 21, 2012, at 1:30 PM, John Ralls wrote:


There's a little bug in Swig [1] that prevents this from working cleanly, but it's easily enough patched:
--- a/Lib/guile/guile_scm_run.swg~Tue Mar  6 14:17:58 2012
+++ b/Lib/guile/guile_scm_run.swgMon May 21 16:38:09 2012
< at >< at > -74,7 +74,7 < at >< at >
   char *ret;
   size_t l;
 
-  SCM_ASSERT (gh_string_p(str), str, 1, FUNC_NAME);
+  SCM_ASSERT (scm_string_p(str), str, 1, FUNC_NAME);
   
   #ifdef HAC_SCM_C_STRING_LENGTH
   l = scn_c_string_length(str);

That file is $PREFIX/share/swig/2.0.x/guile/guile_scm_run.swg if you want to fix an installed swig.

It would be A Good Thing™ to add -Wall to -Werror when --enable-error-on-warning is set in configure (so that it's the default from building from a subversion or git checkout), but I'm afraid that until Swig gets that bug fixed and the fixed version is widespread in distros that it would cause more trouble than good.

Regards,
John Ralls

[1] https://sourceforge.net/tracker/?func=detail&aid=3528887&group_id=1645&ati

Re: Running unit tests under valgrind

John Ralls — 2012-05-22T20:36:02

On May 21, 2012, at 1:30 PM, John Ralls wrote:


There's a little bug in Swig [1] that prevents this from working cleanly, but it's easily enough patched:
--- a/Lib/guile/guile_scm_run.swg~Tue Mar  6 14:17:58 2012
+++ b/Lib/guile/guile_scm_run.swgMon May 21 16:38:09 2012
< at >< at > -74,7 +74,7 < at >< at >
  char *ret;
  size_t l;

-  SCM_ASSERT (gh_string_p(str), str, 1, FUNC_NAME);
+  SCM_ASSERT (scm_string_p(str), str, 1, FUNC_NAME);

  #ifdef HAC_SCM_C_STRING_LENGTH
  l = scn_c_string_length(str);

That file is $PREFIX/share/swig/2.0.x/guile/guile_scm_run.swg if you want to fix an installed swig.

It would be A Good Thing™ to add -Wall to -Werror when --enable-error-on-warning is set in configure (so that it's the default from building from a subversion or git checkout), but I'm afraid that until Swig gets that bug fixed and the fixed version is widespread in distros that it would cause more trouble than good.

Regards,
John Ralls

[1] https://sourceforge.net/tracker/?func=detail&aid=3528887&group_id=1645&atid=101645

Re: Running unit tests under valgrind

John Ralls — 2012-05-22T14:55:19

On May 22, 2012, at 7:38 AM, Derek Atkins wrote:


Assuming that you have installed Valgrind, of course. Depending on how your distro packages Gnucash, you may need to build your own to get symbols, and the Valgrind docs recommend turning off optimizations (-O0) as well. Some useful instructions:

http://wiki.gnucash.org/wiki/FAQ#Q:_I_heard_it_is_too_hard_to_compile_GnuCash.21
wiki.gnucash.org/wiki/Building
http://valgrind.org/docs/manual/quick-start.html


Regards,
John Ralls

Re: Running unit tests under valgrind

Donald Allen — 2012-05-22T14:48:59

You urge me above to "pay closer attention to what I wrote, please".
Now do the same with my message. I made a suggestion to you, based on
many years of experience in software development as a manager and as
an individual participant, and then I VOLUNTEERED TO HELP. Instead, I
get this absurdly rude response from you. Look in the mirror before
you start spouting about restraint. My offer of help is withdrawn.

Re: Running unit tests under valgrind

John Ralls — 2012-05-22T14:42:36

On May 21, 2012, at 8:23 PM, Donald Allen wrote:


Pay closer attention to what I wrote, please. Merely launching Gnucash and doing a few basic operations under Valgrind won't accomplish much -- but it will take a long time, because Valgrind slows execution by a factor of 20-30x, according to their own documentation.

As for the comprehensive testing, I'm plugging away at that in the engine, and Phil started this thread by noting that he was finding leaks with tests -- which is what he's working on (in the backend code).

As a more general observation, your constant carping about a process that *you don't participate in* is annoying and unhelpful.
Please restrain yourself.

Regards,
John Ralls

Re: Running unit tests under valgrind

Derek Atkins — 2012-05-22T14:38:55

Don,

Donald Allen <donaldcallen< at >gmail.com> writes:


There is a gnucash-valgrind script that gets generated on all platforms
except Windows, and it gets installed into the bindir alongside
gnucash.  So you should just be able to run "gnucash-valgrind" instead
of "gnucash" already.


-derek

Re: Running unit tests under valgrind

Donald Allen — 2012-05-22T14:32:46

Yes, I said so above. Make a valgrind+gnucash executable available to
me (or tell me how to build one), and I will put it through the kind
of paces that I use gnucash for normally. I've got a very fast box
with 8 Gb of memory and SSDs running Linux that should make the
performance hit tolerable. I can easily test both the db (postgresql)
and xml backends.

/Don

Re: Running unit tests under valgrind

Derek Atkins — 2012-05-22T14:23:01

Donald,

Donald Allen <donaldcallen< at >gmail.com> writes:


Are you offering to help do this periodic testing!?   If so, thank you!


-derek

Re: Running unit tests under valgrind

Donald Allen — 2012-05-22T03:23:08

I would argue that waiting until you have what you think is adequate
test coverage is not a good strategy. Releases don't happen that often
and it sounds like running the whole thing under valgrind isn't that
difficult, so the cost of doing it is not high. And it just might turn
up something important, even without comprehensive test coverage. You
could make the gnucash+valgrind package available to some volunteers
whever you see fit during the release cycle (I'd be happy to be one of
them) to exercise the system and report the problems it turns up. So I
think it makes sense from a cost-benefit standpoint not to wait.

I would also argue that the comprehensive test suite, especially on a
volunteer project like this, could be a pipe dream. I've been involved
in projects where people were being paid for their work and all the
right things were said, but not done, about test coverage. It's like
documentation. Programmers like to program, not write tests, not write
documentation. I'm not saying it never happens

Re: Running unit tests under valgrind

John Ralls — 2012-05-22T03:10:04

On May 21, 2012, at 3:41 PM, Donald Allen wrote:


Not routinely. Every so often someone will get motivated and run under valgrind for a while and chase down some of the leaks, but there are too many execution paths and not yet enough tests to be sure of exercising even a significant percentage of the program. We'll get that sorted eventually.

Regards,
John Ralls

Re: Running unit tests under valgrind

Donald Allen — 2012-05-21T22:41:59

Do you guys run the whole system under valgrind (John is obviously
right about tests on the parts don't necessarily say anything about
the whole) prior to release as part of your QA process?

/Don

Re: Running unit tests under valgrind

Phil Longstaff — 2012-05-21T22:22:53

Yes.  A lot of the leaks are in the unit test code.  But I've found 2 legitimate leaks as well.

Phil

________________________________
 From: John Ralls <jralls< at >ceridwen.us>
To: Christian Stimming <christian< at >cstimming.de> 
Cc: gnucash-devel< at >gnucash.org; Phil Longstaff <phil.longstaff< at >yahoo.ca> 
Sent: Monday, May 21, 2012 4:56:52 PM
Subject: Re: Running unit tests under valgrind

On May 21, 2012, at 1:42 PM, Christian Stimming wrote:

OK, though a leak in a unit test doesn't necessarily mean that the application leaks, nor does the absence of a leak in the unit test guarantee that the application doesn't leak. 

Regards,
John Ralls

Re: Running unit tests under valgrind

John Ralls — 2012-05-21T20:56:52

On May 21, 2012, at 1:42 PM, Christian Stimming wrote:


OK, though a leak in a unit test doesn't necessarily mean that the application leaks, nor does the absence of a leak in the unit test guarantee that the application doesn't leak. 

Regards,
John Ralls

Re: Running unit tests under valgrind

Christian Stimming — 2012-05-21T20:42:13

Am Montag, 21. Mai 2012, 13:30:11 schrieb John Ralls:

I think Phil's suggestion is a very valid idea in order to find memory leaks 
inside the functions that are being tested. On the other hand, I agree with 
Derek and John in that using valgrind doesn't make much sense as a default 
when running the unittests. Hence, I think it would be good to provide some 
infrastructure for optionally running the tests with valgrind. But it 
shouldn't be added as a normal testing step that needs to be performed by 
everyone who is running the tests.

Regards,

Christian