gmane.comp.emulators.qemu

Re: [PATCH] makefile: detect corrupted elf files

Markus Armbruster — 2013-05-22T07:44:04


Any generated file could be truncated then, not just objects.

If you abort a build with kill -9 or equivalent, you blow away the build
tree and start over.  A sufficiently unlucky truncation could still
build, but not work.

[...]

Re: [PATCHv2 RFC] makefile: detect corrupted elf files

Michael S. Tsirkin — 2013-05-22T07:28:17

One way would be to make this optional.


True, I'll fix this up.

Re: [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

Qiao Nuohan — 2013-05-22T06:37:37

Hi eric and luiz,

Does you have some comments on this version?

Re: [PATCHv2 RFC] makefile: detect corrupted elf files

Stefan Weil — 2013-05-22T06:32:52

Am 22.05.2013 00:07, schrieb Michael S. Tsirkin:


This modification adds build complexity and execution time for
each build, just to fix a potential problem which is very rare.

I personally prefer the current solution (remove bad object files
manually).

I did not test the patch, but won't cross builds be caught in an
endless loop when the native size command does not know the
cross object format?

Regards,
Stefan

[Bug 1181796] Re: Qemu locks up when incoming serialfills up

Evan Green — 2013-05-22T06:02:08

The following patch gets things moving again for me. It only reports
that the poll was satisfied if there was data that could be written to
the destination. While it successfully opens up a window where the I/O
thread is unlocked (previously there was no such window, hence the
hang), it's far from ideal.

Someone with more familiarity than me could consider an approach where
descriptors that have responded to the poll but are unable to be acted
on are temporarily disabled or removed from the list. This would allow
the main thread to quiet back down, rather than aggressively spinning
locking and unlocking the global mutex, which puts a drag on the VCPU
threads that need to acquire the same lock and do real work.

The line numbers here might not line up, but you get the idea.

--- qemu-char.c.orig2   2013-05-19 22:27:16 -0700
+++ qemu-char.c 2013-05-19 23:49:38 -0700
< at >< at > -1650,6 +1650,7 < at >< at >

 static int win_chr_poll(void *opaque)
 {
+    int available;
     CharDriverState *chr = opaque;
     WinCharState *s = c

Re: [PATCH v1 1/1] glib: Fix some misuses ofgsize/size_t types

Edgar E. Iglesias — 2013-05-22T06:25:28

Reviewed-by: Edgar E. Iglesias <edgar.iglesias< at >gmail.com>

Re: [PATCH v2 1/1] qom/object: Don't poll cast cachefor NULL objects

Edgar E. Iglesias — 2013-05-22T06:16:09


Reviewed-by: Edgar E. Iglesias <edgar.iglesias< at >gmail.com>

Re: [PATCH v2 1/1] qom/object: Don't poll cast cache for NULL objects

Paolo Bonzini — 2013-05-22T06:04:43


----- Messaggio originale -----

Reviewed-by: Paolo Bonzini <pbonzini< at >redhat.com>

... and added qemu-stable< at >nongnu.org since this got in pretty close to a release.

Paolo

Re: [PATCH v1 1/1] glib: Fix some misuses ofgsize/size_t types

Paolo Bonzini — 2013-05-22T06:03:05


----- Messaggio originale -----

Adding qemu-trivial...

Reviewed-by: Paolo Bonzini <pbonzini< at >redhat.com>

Paolo

[RFC PATCH v1 13/20] piix3,ich9: create pit through composition

Hu Tao — 2013-05-22T05:33:17

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc.c             | 16 +---------------
 hw/isa/lpc_ich9.c        | 30 ++++++++++++++++++++++++++++++
 hw/pci-host/piix.c       | 32 ++++++++++++++++++++++++++++++++
 include/hw/i386/ich9.h   |  1 +
 include/hw/timer/i8254.h |  3 +++
 5 files changed, 67 insertions(+), 15 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 97bfad4..8438d0f 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
< at >< at > -1128,9 +1128,8 < at >< at > void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
 {
     int i;
     DriveInfo *fd[MAX_FD];
-    DeviceState *hpet = NULL;
     qemu_irq *a20_line;
-    ISADevice *i8042, *port92, *vmmouse, *pit = NULL;
+    ISADevice *i8042, *port92, *vmmouse;
     qemu_irq *cpu_exit_irq;
     MemoryRegion *ioport80_io = g_new(MemoryRegion, 1);
     MemoryRegion *ioportF0_io = g_new(MemoryRegion, 1);
< at >< at > -1141,19 +1140,6 < at >< at > void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
     memory_region_init_io(ioportF0_io, &ioportF0_io_ops, NULL, "iopo

[RFC PATCH v1 11/20] add rtc_set_irq

Hu Tao — 2013-05-22T05:33:15

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/timer/mc146818rtc.c         | 6 ++++++
 include/hw/timer/mc146818rtc.h | 1 +
 2 files changed, 7 insertions(+)

diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 481604d..2fdae55 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
< at >< at > -687,6 +687,12 < at >< at > int rtc_get_memory(ISADevice *dev, int addr)
     return s->cmos_data[addr];
 }
 
+void rtc_set_irq(ISADevice *dev, qemu_irq irq)
+{
+    RTCState *s = MC146818_RTC(dev);
+    s->irq = irq;
+}
+
 static void rtc_set_date_from_host(ISADevice *dev)
 {
     RTCState *s = MC146818_RTC(dev);
diff --git a/include/hw/timer/mc146818rtc.h b/include/hw/timer/mc146818rtc.h
index eaf6497..0eea138 100644
--- a/include/hw/timer/mc146818rtc.h
+++ b/include/hw/timer/mc146818rtc.h
< at >< at > -9,5 +9,6 < at >< at >
 ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq);
 void rtc_set_memory(ISADevice *dev, int addr, int val);
 int rtc_get_memory(ISADevice *dev, int addr);
+void rtc_set_irq(ISADev

Re: [PATCH 2/4] acpi/gpe: expand bits of gpe register

li guang — 2013-05-22T05:37:41

在 2013-05-22三的 14:28 +0900，Isaku Yamahata写道：

the fact is I can't guess why gpe->sts is defined uint8_t 
but the real hardware is 32-bit width.
I expand it to 32 because the future usage for me will 
access bit beyond 8.
of course, I can keep it, but I don't if I can
violate the bit usage indication of this register.

[RFC PATCH v1 08/20] rtc: remove rtc_set_date

Hu Tao — 2013-05-22T05:33:12

Since it's not defined and used anywhere.

Cc: qemu-trivial< at >nongnu.org
Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 include/hw/timer/mc146818rtc.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/timer/mc146818rtc.h b/include/hw/timer/mc146818rtc.h
index 753dda6..eaf6497 100644
--- a/include/hw/timer/mc146818rtc.h
+++ b/include/hw/timer/mc146818rtc.h
< at >< at > -9,6 +9,5 < at >< at >
 ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq);
 void rtc_set_memory(ISADevice *dev, int addr, int val);
 int rtc_get_memory(ISADevice *dev, int addr);
-void rtc_set_date(ISADevice *dev, const struct tm *tm);
 
 #endif /* !MC146818RTC_H */

[RFC PATCH v1 07/20] piix3: create piix3 throughcomposition.

Hu Tao — 2013-05-22T05:33:11

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/pci-host/piix.c | 74 ++++++++++++++++++++++++++++++++----------------------
 1 file changed, 44 insertions(+), 30 deletions(-)

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 021da6e..6796cb5 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
< at >< at > -38,16 +38,6 < at >< at >
  * http://download.intel.com/design/chipsets/datashts/29054901.pdf
  */
 
-#define TYPE_I440FX_DEVICE "i440FX"
-#define I440FX_DEVICE(obj) \
-    OBJECT_CHECK(I440FXState, (obj), TYPE_I440FX_DEVICE)
-
-typedef struct I440FXState {
-    PCIHostState parent_obj;
-    MemoryRegion *address_space_io;
-    MemoryRegion *pci_address_space;
-} I440FXState;
-
 #define PIIX_NUM_PIC_IRQS       16      /* i8259 * 2 */
 #define PIIX_NUM_PIRQS          4ULL    /* PIRQ[A-D] */
 #define XEN_PIIX_NUM_PIRQS      128ULL
< at >< at > -79,6 +69,8 < at >< at > typedef struct PIIX3State {
 #endif
     uint64_t pic_levels;
 
+    ISABus *bus;
+
     qemu_irq *pic;
 
     /* This member isn't used. Just for save/load compa

[RFC PATCH v1 14/20] piix3,ich9: create pc speaker through composition

Hu Tao — 2013-05-22T05:33:18

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/isa/lpc_ich9.c      |  9 +++++++--
 hw/pci-host/piix.c     | 10 ++++++++--
 include/hw/i386/ich9.h |  1 +
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index 42f60b9..a1927b2 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
< at >< at > -597,8 +597,9 < at >< at > static int ich9_lpc_realize(PCIDevice *d)
                               qdev_get_gpio_in(DEVICE(lpc->pit), 0));
     }
 
-    /* FIXME this should be refactored */
-    pcspk_init(lpc->isa_bus, lpc->pit);
+    /* Realize pcspk */
+    qdev_set_parent_bus(DEVICE(lpc->pcspk), BUS(lpc->isa_bus));
+    qdev_init_nofail(DEVICE(lpc->pcspk));
 
     return 0;
 }
< at >< at > -669,6 +670,10 < at >< at > static void ich9_lpc_initfn(Object *obj)
     }
     object_property_add_child(obj, "pit", OBJECT(s->pit), NULL);
     qdev_prop_set_uint32(DEVICE(s->pit), "iobase", 0x40);
+
+    s->pcspk = ISA_DEVICE(object_new(TYPE_PC_SPEAKER));
+    qdev_prop_set_uint32(&s->pcspk->qdev, "iobase

[RFC PATCH v1 19/20] i440fx-pmc: move raminitialization into i440fx-pmc

Hu Tao — 2013-05-22T05:33:23

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc.c         | 27 ++-------------------------
 hw/i386/pc_piix.c    |  5 ++---
 hw/pci-host/piix.c   | 39 +++++++++++++++++++++++++++++++--------
 include/hw/i386/pc.h |  6 ++----
 4 files changed, 37 insertions(+), 40 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 8438d0f..45d9701 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
< at >< at > -1018,37 +1018,14 < at >< at > void *pc_memory_init(MemoryRegion *system_memory,
                     const char *initrd_filename,
                     ram_addr_t below_4g_mem_size,
                     ram_addr_t above_4g_mem_size,
-                    MemoryRegion *rom_memory,
-                    MemoryRegion **ram_memory)
+                    MemoryRegion *rom_memory)
 {
     int linux_boot, i;
-    MemoryRegion *ram, *option_rom_mr;
-    MemoryRegion *ram_below_4g, *ram_above_4g;
+    MemoryRegion *option_rom_mr;
     void *fw_cfg;
 
     linux_boot = (kernel_filename != NULL);
 
-    /* Allocate RAM.  We allocate it

[RFC PATCH v1 12/20] piix3,ich9: create the RTC through composition

Hu Tao — 2013-05-22T05:33:16

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc.c           |  8 +-------
 hw/i386/pc_piix.c      |  6 +++++-
 hw/i386/pc_q35.c       |  6 +++++-
 hw/isa/lpc_ich9.c      | 15 +++++++++++++++
 hw/pci-host/piix.c     | 15 +++++++++++++++
 hw/timer/mc146818rtc.c |  2 +-
 include/hw/i386/ich9.h |  1 +
 include/hw/i386/pc.h   |  2 +-
 8 files changed, 44 insertions(+), 11 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index d0e7a41..97bfad4 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
< at >< at > -290,7 +290,7 < at >< at > static int set_boot_dev(ISADevice *s, const char *boot_device, int fd_bootchk)
     return(0);
 }
 
-static int pc_boot_set(void *opaque, const char *boot_device)
+int pc_boot_set(void *opaque, const char *boot_device)
 {
     return set_boot_dev(opaque, boot_device, 0);
 }
< at >< at > -1123,14 +1123,12 < at >< at > static const MemoryRegionOps ioportF0_io_ops = {
 };
 
 void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
-                          ISADevice **rtc_state,
                           ISADev

[RFC PATCH v1 16/20] i440fx-pmc: calculate PCI memoryhole directly

Hu Tao — 2013-05-22T05:33:20

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc_piix.c    |  6 ------
 hw/pci-host/piix.c   | 49 ++++++++++++++++++++++++-------------------------
 include/hw/i386/pc.h |  4 ----
 3 files changed, 24 insertions(+), 35 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 80e29d2..79747fa 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
< at >< at > -138,12 +138,6 < at >< at > static void pc_init1(MemoryRegion *system_memory,
     if (pci_enabled) {
         pci_bus = i440fx_init(&piix3_devfn, &isa_bus, gsi,
                               system_memory, system_io, ram_size,
-                              below_4g_mem_size,
-                              0x100000000ULL - below_4g_mem_size,
-                              0x100000000ULL + above_4g_mem_size,
-                              (sizeof(hwaddr) == 4
-                               ? 0
-                               : ((uint64_t)1 << 62)),
                               pci_memory, ram_memory);
     } else {
         pci_bus = NULL;
dif

[RFC PATCH v1 17/20] i440fx-pmc: create pci addressspace

Hu Tao — 2013-05-22T05:33:21

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc_piix.c    | 33 +++++++++++++++------------------
 hw/pci-host/piix.c   | 16 +++++++++-------
 include/hw/i386/pc.h |  2 +-
 3 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 79747fa..2120dc6 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
< at >< at > -109,23 +109,6 < at >< at > static void pc_init1(MemoryRegion *system_memory,
         below_4g_mem_size = ram_size;
     }
 
-    if (pci_enabled) {
-        pci_memory = g_new(MemoryRegion, 1);
-        memory_region_init(pci_memory, "pci", INT64_MAX);
-        rom_memory = pci_memory;
-    } else {
-        pci_memory = NULL;
-        rom_memory = system_memory;
-    }
-
-    /* allocate ram and load rom/bios */
-    if (!xen_enabled()) {
-        fw_cfg = pc_memory_init(system_memory,
-                       kernel_filename, kernel_cmdline, initrd_filename,
-                       below_4g_mem_size, above_4g_mem_size,
-                       rom_memor

[RFC PATCH v1 20/20] q35-mch: move ram initializationinto q35-mch

Hu Tao — 2013-05-22T05:33:24

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc_q35.c          |  7 ++-----
 hw/pci-host/q35.c         | 36 +++++++++++++++++++++++++++++++-----
 include/hw/pci-host/q35.h |  9 +++++++--
 3 files changed, 40 insertions(+), 12 deletions(-)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index a6d1eae..32c882e 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
< at >< at > -65,7 +65,6 < at >< at > static void pc_q35_init(QEMUMachineInitArgs *args)
     ISADevice *rtc_state;
     ISADevice *floppy;
     MemoryRegion *rom_memory;
-    MemoryRegion *ram_memory;
     GSIState *gsi_state;
     ISABus *isa_bus;
     int pci_enabled = 1;
< at >< at > -108,7 +107,7 < at >< at > static void pc_q35_init(QEMUMachineInitArgs *args)
     if (!xen_enabled()) {
         pc_memory_init(get_system_memory(), kernel_filename, kernel_cmdline,
                        initrd_filename, below_4g_mem_size, above_4g_mem_size,
-                       rom_memory, &ram_memory);
+                       rom_memory);
     }
 
     /* irq lines */
< at >< at > -121,11 +120,

[RFC PATCH v1 10/20] piix3,ich9: create the HPET through composition

Hu Tao — 2013-05-22T05:33:14

Signed-off-by: Hu Tao <hutao< at >cn.fujitsu.com>
---
 hw/i386/pc.c            | 22 +---------------------
 hw/i386/pc_q35.c        |  9 ++++++---
 hw/isa/lpc_ich9.c       | 28 ++++++++++++++++++++++++++++
 hw/pci-host/piix.c      | 30 ++++++++++++++++++++++++++++++
 hw/timer/hpet.c         |  2 +-
 include/hw/i386/ich9.h  |  2 ++
 include/hw/timer/hpet.h |  3 +++
 7 files changed, 71 insertions(+), 25 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 197d218..d0e7a41 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
< at >< at > -1130,8 +1130,6 < at >< at > void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
     int i;
     DriveInfo *fd[MAX_FD];
     DeviceState *hpet = NULL;
-    int pit_isa_irq = 0;
-    qemu_irq pit_alt_irq = NULL;
     qemu_irq rtc_irq = NULL;
     qemu_irq *a20_line;
     ISADevice *i8042, *port92, *vmmouse, *pit = NULL;
< at >< at > -1145,24 +1143,6 < at >< at > void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
     memory_region_init_io(ioportF0_io, &ioportF0_io_ops, NULL, "ioportF0", 1);
     memory_regi